Re: [libvirt] [RFC] libvirt hexagon sticker design

Hi Erik, On Mon, 2018-02-19 at 09:44 +0100, Erik Skultety wrote: > Hi folks, > those who attended at least one conference for the past year have probably > noticed the rising trend (more like "sticker hype") of FOSS projects giving > away > these hexagon stickers, it's very inexpensive way of

Re: [libvirt] [PATCH] util: xml: Don't conflict with other libxml2 user callbacks

On Fri, Feb 23, 2018 at 06:21:15PM -0500, Cole Robinson wrote: lxml is a popular python XML processing library. It uses libxml2 behind the scenes, and registers custom callbacks via xmlSetExternalEntityLoader. However this can cause crashes if if an app uses both lxml and libxml2 together in the

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 26, 2018 at 09:23:17AM +0100, Cedric Bosdonnat wrote: > Hi Erik, > > On Mon, 2018-02-19 at 09:44 +0100, Erik Skultety wrote: > > Hi folks, > > those who attended at least one conference for the past year have probably > > noticed the rising trend (more like "sticker hype") of FOSS

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, 2018-02-26 at 09:50 +0100, Erik Skultety wrote: > Why can't we have both? Suits everyone, just like NHL jerseys - one with a > light base and a second one with a darker-colored base :). I'm still to rework > the design with the latest SVG set which Dan re-worked as part of the > webdesign

[libvirt] [PATCH 2/2] vz: build fix: handle missing switch enum cases

Ensure all enum cases are listed in switch statements, or cast away enum type in places where we don't wish to cover all cases. Build is broken after 67966ad51 [1]. [1] m4: enforce that all enum cases are listed in switch statements Signed-off-by: Nikolay Shirokovskiy

[libvirt] [PATCH 1/2] vz: build fix after excluding cross driver headers

Build is broken by 5529b057 [1]. [1] cfg: forbid includes of headers in network and storage drivers again Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_sdk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index

[libvirt] [PATCH 0/2] vz: build fixes

Build is broken only in not yet released 4.1. Nikolay Shirokovskiy (2): vz: build fix after excluding cross driver headers vz: build fix: handle missing switch enum cases src/vz/vz_sdk.c | 17 + src/vz/vz_utils.c | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-)

[libvirt] Entering freeze for libvirt 4.1.0 release

I didn't sent a warning mail, but people reminded me that it's time to roll the releases, so I just tagged rc1 in git head and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Looks fine with my limited testing, amazingly https://ci.centos.org/view/libvirt/

Re: [libvirt] [PATCH] util: xml: Don't conflict with other libxml2 user callbacks

On Mon, Feb 26, 2018 at 09:48:39AM +0100, Ján Tomko wrote: > On Fri, Feb 23, 2018 at 06:21:15PM -0500, Cole Robinson wrote: > > lxml is a popular python XML processing library. It uses libxml2 > > behind the scenes, and registers custom callbacks via > > xmlSetExternalEntityLoader. However this

[libvirt] [PATCH 2/4] qemu: introduce SEV feature in hypervisor capabilities

Extend hypervisor capabilities to include sev feature. When available, hypervisor supports launching an encrypted VM on AMD platform. The sev feature tag provides additional details like platform diffie-hellman key and certificate chain which can be used by the guest owner to establish a

[libvirt] [PATCH 4/4] libvirt-domain: add new virDomainGetSevVmMeasurement() API

The virDomainGetSevVmMeasurement() can be used to retrieve the measurement of encrypted VM launched using AMD SEV feature. The measurement is a signature of the memory contents that can be sent to the guest owner as an attestation that the memory was encrypted correctly by the firmware before

[libvirt] [PATCH 0/4] x86: Secure Encrypted Virtualization (AMD)

This patch series provides support for launching an encrypted guest using AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV feature allows the memory

[libvirt] [PATCH 1/4] qemu: provide support to query the SEV capability

QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD X86 platform using Secure Encrypted Virtualization (SEV) feature. This patch adds support to query the SEV capability from the qemu. Signed-off-by: Brijesh Singh --- QEMU SEV v9 patch does not

[libvirt] [PATCH 3/4] conf: introduce sev element in domain

Secure Encrypted Virtualization (sev) element is used to provide the guest owners input parameters used for creating an encrypted VM using AMD SEV feature. SEV feature supports running encrypted VM under the control of KVM. Encrypted VMs have their pages (code and data) secured such that only the

Re: [libvirt] [PATCH v4 3/8] libxl: error out on not supported CPU mode, instead of silently ignoring

On 02/15/2018 02:47 PM, Marek Marczykowski-Górecki wrote: On Tue, Feb 13, 2018 at 09:02:35AM -0700, Jim Fehlig wrote: On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: This change make libvirt XML with plain element invalid for libxl, which affect not only upcoming CPUID support, but

Re: [libvirt] [PATCH v4 3/8] libxl: error out on not supported CPU mode, instead of silently ignoring

On Mon, Feb 26, 2018 at 01:20:49PM -0700, Jim Fehlig wrote: > On 02/15/2018 02:47 PM, Marek Marczykowski-Górecki wrote: > > On Tue, Feb 13, 2018 at 09:02:35AM -0700, Jim Fehlig wrote: > > > It looks like we never answered my question from V3, i.e. should we change > > > the default mode in the

Re: [libvirt] [PATCH v4 4/8] libxl: do not enable nested HVM unless global nested_hvm option enabled

On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: Introduce global libxl option for enabling nested HVM feature, similar to kvm module parameter. This will prevent enabling experimental feature by mere presence of element in domain config, unless explicitly enabled. element may be used

Re: [libvirt] [PATCH libvirt] qemu: log the crash information for S390

On Mon, Feb 26, 2018 at 08:25:11 +0100, Bjoern Walk wrote: > John Ferlan [2018-02-20, 12:25PM -0500]: > > On 02/15/2018 06:58 AM, Bjoern Walk wrote: > > > Since QEMU 2.12 guest crash information for S390 is available in the > > > QEMU monitor, e.g.: > > > > > > { > > >

Re: [libvirt] [PATCH v4 5/8] libxl: add support for CPUID features policy

On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: Convert CPU features policy into libxl cpuid policy settings. Use new ("libxl") syntax, which allow to enable/disable specific bits, using host CPU as a base. For this reason, only "host-passthrough" mode is accepted. Libxl do not have

Re: [libvirt] [PATCH v4 7/8] xenconfig: add CPUID handling to domXML <-> xl.cfg conversion

On 02/08/2018 03:59 PM, Marek Marczykowski-Górecki wrote: Only "libxl" format supported for now. Special care needed around vmx/svm, because those two are translated into "nestedhvm" setting. --- Changes since v3: - improve error reporting (VIR_ERR_CONF_SYNTAX) - ignore empty cpuid option -

Re: [libvirt] [PATCH v4 8/8] tests: add test case for CPUID in xenconfig driver

On 02/08/2018 03:59 PM, Marek Marczykowski-Górecki wrote: Check conversion of "cpuid" setting, check all supported policy settings ("1", "0", "x"). Also, check interaction with "nestedhvm" - should not be included as "vmx=1" in "cpuid" setting. --- Changes since v3: - adjust for nested HVM

Re: [libvirt] [PATCH v4 4/8] libxl: do not enable nested HVM unless global nested_hvm option enabled

On Mon, Feb 26, 2018 at 04:23:18PM -0700, Jim Fehlig wrote: > On 02/26/2018 04:10 PM, Marek Marczykowski-Górecki wrote: > > On Mon, Feb 26, 2018 at 03:47:11PM -0700, Jim Fehlig wrote: > > > On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: > > > > + > > > > +# Nested HVM global control. In

Re: [libvirt] [PATCH v4 5/8] libxl: add support for CPUID features policy

On Mon, Feb 26, 2018 at 04:08:44PM -0700, Jim Fehlig wrote: > On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: > > +const char * > > +xenTranslateCPUFeature(const char *feature_name, bool from_libxl) > > +{ > > +static const char *translation_table[][2] = { > > +/* libvirt

Re: [libvirt] [PATCH v4 4/8] libxl: do not enable nested HVM unless global nested_hvm option enabled

On 02/26/2018 04:51 PM, Marek Marczykowski-Górecki wrote: On Mon, Feb 26, 2018 at 04:23:18PM -0700, Jim Fehlig wrote: On 02/26/2018 04:10 PM, Marek Marczykowski-Górecki wrote: On Mon, Feb 26, 2018 at 03:47:11PM -0700, Jim Fehlig wrote: On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote:

Re: [libvirt] [PATCH v4 6/8] tests: check CPU features handling in libxl driver

On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: Test enabling/disabling individual CPU features and also setting nested HVM support, which is also controlled by CPU features node. Signed-off-by: Marek Marczykowski-Górecki --- Changes since v3: -

Re: [libvirt] [PATCH v4 4/8] libxl: do not enable nested HVM unless global nested_hvm option enabled

On 02/26/2018 04:10 PM, Marek Marczykowski-Górecki wrote: On Mon, Feb 26, 2018 at 03:47:11PM -0700, Jim Fehlig wrote: On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: + +# Nested HVM global control. In order to use nested HVM feature, this option +# needs to be enabled, in addition to

Re: [libvirt] [PATCH v4 3/8] libxl: error out on not supported CPU mode, instead of silently ignoring

On 02/26/2018 01:48 PM, Marek Marczykowski-Górecki wrote: On Mon, Feb 26, 2018 at 01:20:49PM -0700, Jim Fehlig wrote: On 02/15/2018 02:47 PM, Marek Marczykowski-Górecki wrote: On Tue, Feb 13, 2018 at 09:02:35AM -0700, Jim Fehlig wrote: It looks like we never answered my question from V3, i.e.

Re: [libvirt] [PATCH v4 4/8] libxl: do not enable nested HVM unless global nested_hvm option enabled

On Mon, Feb 26, 2018 at 03:47:11PM -0700, Jim Fehlig wrote: > On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: > > + > > +# Nested HVM global control. In order to use nested HVM feature, this > > option > > +# needs to be enabled, in addition to specifying > mode='host-passthrough'> > >

Re: [libvirt] [PATCH 0/2] Cosmetic changes to the banner SVGs to enable object alignment

On 02/25/2018 11:45 PM, Erik Skultety wrote: > Erik Skultety (2): > docs: logos: Remove empty text elements from the banner SVGs > docs: logos: Resize the 'Drop shadow' filter bounding box > > docs/logos/logo-banner-dark.svg | 39 +-- >

Re: [libvirt] [PATCH 0/2] vz: build fixes

On Mon, Feb 26, 2018 at 12:25:49PM +0300, Nikolay Shirokovskiy wrote: > Build is broken only in not yet released 4.1. > > Nikolay Shirokovskiy (2): > vz: build fix after excluding cross driver headers > vz: build fix: handle missing switch enum cases > > src/vz/vz_sdk.c | 17

[libvirt] [PATCH for release 0/3] Fix broken migration

Currently, we are unable to migrate ANY domain. These should get in before the release. Okay, the first one is not that crucial. The last one is! Michal Privoznik (3): qemuMigrationSrcIsSafe: Check local storage more thoroughly qemuProcessLaunch: Print all arguments to debug qemu: Add

[libvirt] [PATCH 2/3] qemuProcessLaunch: Print all arguments to debug

Signed-off-by: Michal Privoznik --- src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1923c8e35..57c06c7c1 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c

[libvirt] [PATCH 3/3] qemu: Add virConnectPtr back to some migration methods

This partially reverts 82592551cb8c4112cfa2264d50b8dce5349533d5. When migrating a domain, qemuMigrationDstPrepareAny() is called which eventually calls qemuProcessLaunch(conn = NULL, flags = VIR_QEMU_PROCESS_START_AUTODESTROY); But the very first thing that qemuProcessLaunch does is check if

[libvirt] [PATCH 1/3] qemuMigrationSrcIsSafe: Check local storage more thoroughly

https://bugzilla.redhat.com/show_bug.cgi?id=1494454 If a domain disk is stored on local filesystem (e.g. ext4) but is not being migrated it is very likely that domain is not able to run on destination. Regardless of share/cache mode. Signed-off-by: Michal Privoznik ---

Re: [libvirt] [PATCH 1/3] qemuMigrationSrcIsSafe: Check local storage more thoroughly

On Mon, Feb 26, 2018 at 11:05:49AM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1494454 > > If a domain disk is stored on local filesystem (e.g. ext4) but is > not being migrated it is very likely that domain is not able to > run on destination. Regardless of

Re: [libvirt] [PATCH 0/2] Cosmetic changes to the banner SVGs to enable object alignment

On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote: > On 02/25/2018 11:45 PM, Erik Skultety wrote: > > Erik Skultety (2): > > docs: logos: Remove empty text elements from the banner SVGs > > docs: logos: Resize the 'Drop shadow' filter bounding box > > > >

Re: [libvirt] [PATCH 0/2] Cosmetic changes to the banner SVGs to enable object alignment

On Mon, Feb 26, 2018 at 11:41:16AM +, Daniel P. Berrangé wrote: > On Mon, Feb 26, 2018 at 12:20:49PM +0100, Erik Skultety wrote: > > On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote: > > > On 02/25/2018 11:45 PM, Erik Skultety wrote: > > > > Erik Skultety (2): > > > > docs:

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 26, 2018 at 10:05:57AM +0100, Cedric Bosdonnat wrote: > On Mon, 2018-02-26 at 09:50 +0100, Erik Skultety wrote: > > Why can't we have both? Suits everyone, just like NHL jerseys - one with a > > light base and a second one with a darker-colored base :). I'm still to > > rework > > the

[libvirt] [PATCH 2/2] lxc: fix rpc event leak on error path in virLXCControllerEventSend

Signed-off-by: Nikolay Shirokovskiy --- src/lxc/lxc_controller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 7346804..59609b0 100644 --- a/src/lxc/lxc_controller.c +++

Re: [libvirt] [PATCH 3/3] qemu: Add virConnectPtr back to some migration methods

On Mon, Feb 26, 2018 at 11:05:51AM +0100, Michal Privoznik wrote: > This partially reverts 82592551cb8c4112cfa2264d50b8dce5349533d5. > > When migrating a domain, qemuMigrationDstPrepareAny() is called > which eventually calls qemuProcessLaunch(conn = NULL, flags = >

Re: [libvirt] [PATCH 2/3] qemuProcessLaunch: Print all arguments to debug

On Mon, Feb 26, 2018 at 11:05:50AM +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_process.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index

[libvirt] [PATCH 1/2] daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend

Signed-off-by: Nikolay Shirokovskiy --- src/remote/remote_daemon_dispatch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index fdb0a36..ea67cb7 100644 ---

[libvirt] [PATCH 0/2] rpc: fix memleak

Nikolay Shirokovskiy (2): daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend lxc: fix rpc event leak on error path in virLXCControllerEventSend src/lxc/lxc_controller.c| 3 ++- src/remote/remote_daemon_dispatch.c | 3 ++- 2 files changed, 4 insertions(+), 2

Re: [libvirt] [PATCH 0/2] Cosmetic changes to the banner SVGs to enable object alignment

On Mon, Feb 26, 2018 at 12:20:49PM +0100, Erik Skultety wrote: > On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote: > > On 02/25/2018 11:45 PM, Erik Skultety wrote: > > > Erik Skultety (2): > > > docs: logos: Remove empty text elements from the banner SVGs > > > docs: logos:

Re: [libvirt] [PATCH 2/2] lxc: fix rpc event leak on error path in virLXCControllerEventSend

On Mon, Feb 26, 2018 at 02:13:50PM +0300, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > src/lxc/lxc_controller.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/lxc/lxc_controller.c

Re: [libvirt] [PATCH 1/2] daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend

On Mon, Feb 26, 2018 at 02:13:49PM +0300, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > src/remote/remote_daemon_dispatch.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/remote/remote_daemon_dispatch.c >

Re: [libvirt] [PATCH] docs: add SVGs for sticker logos

On Mon, Feb 26, 2018 at 04:35:54PM +0100, Erik Skultety wrote: > On Mon, Feb 26, 2018 at 11:00:06AM +, Daniel P. Berrangé wrote: > > Since you edited the template you referenced ^above, you added the whole thing > which I'm not sure is really necessary. There's also some leftover star >

Re: [libvirt] [PATCH] docs: add SVGs for sticker logos

On Mon, Feb 26, 2018 at 03:51:32PM +, Daniel P. Berrangé wrote: > On Mon, Feb 26, 2018 at 04:35:54PM +0100, Erik Skultety wrote: > > On Mon, Feb 26, 2018 at 11:00:06AM +, Daniel P. Berrangé wrote: > > > > Since you edited the template you referenced ^above, you added the whole > > thing >

Re: [libvirt] [PATCH] travis: add a scenario for running make distcheck

On 02/22/2018 05:13 PM, Daniel P. Berrangé wrote: > Running "make distcheck" ensures that we have CLEANFILES and uninstall > rules setup correctly, as well as validating VPATH builds succeeed. > > Signed-off-by: Daniel P. Berrangé > --- > .travis.yml | 5 + > 1 file

Re: [libvirt] [PATCH] nwfilter: save error from DHCP snoop thread to report in main thread

On 02/23/2018 04:05 PM, Laine Stump wrote: > A problem encountered due to a bug in libpcap was reported to the caller as: > >An error occurred, but the cause is unknown > > This was because the error had been logged in the DHCPSnoop > thread. The worker thread handling the API call to start