Re: [libvirt] [PATCH v1 7/7] qemu: Enable memory-backend-file.discard-data whenever possible

On Tue, Apr 17, 2018 at 10:49:39 +0200, Michal Privoznik wrote: > On 04/17/2018 10:05 AM, Peter Krempa wrote: > > On Thu, Apr 12, 2018 at 18:39:52 +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > >> > >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v1 6/7] tests: Update qemucapabilitiesdata

On 04/17/2018 10:39 AM, Peter Krempa wrote: > On Thu, Apr 12, 2018 at 18:39:51 +0200, Michal Privoznik wrote: >> Signed-off-by: Michal Privoznik > > So this really needs to be squashed into the previous commit. Also It > would help if you'd describe what you are doing since

Re: [libvirt] [PATCH v2 73/73] qemuxml2xmltest: Add status XML tests for migration params

On Mon, Apr 16, 2018 at 20:59:04 +0200, Ján Tomko wrote: > On Wed, Apr 11, 2018 at 04:42:03PM +0200, Jiri Denemark wrote: > >Signed-off-by: Jiri Denemark > >--- > > .../migration-in-params-in.xml| 400 + > > .../migration-in-params-out.xml

Re: [libvirt] [libvirt PATCH v2 35/44] Deprecate QEMU_CAPS_NETDEV_BRIDGE

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > Unused since commit <2d80fbb1>. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_capabilities.c | 1 - > src/qemu/qemu_capabilities.h | 2 +- >

Re: [libvirt] [PATCH v1 7/7] qemu: Enable memory-backend-file.discard-data whenever possible

On 04/17/2018 10:05 AM, Peter Krempa wrote: > On Thu, Apr 12, 2018 at 18:39:52 +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1480668 >> >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_command.c | 6 ++ >> 1 file changed, 6

Re: [libvirt] [libvirt PATCH v2 34/44] Deprecate QEMU_CAPS_WAKEUP

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 06b5d1387d..2cfcbacaf0 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -18747,15 +18747,6 @@ qemuDomainPMSuspendForDuration(virDomainPtr dom, >

Re: [libvirt] [PATCH v1 1/7] qemu: Rename qemuMonitorGetObjectProps to qemuMonitorGetDeviceProps

On Thu, Apr 12, 2018 at 18:39:46 +0200, Michal Privoznik wrote: > This function is indeed getting -device properties and not > -object properties. The current name is misleading. > > Signed-off-by: Michal Privoznik > --- ACK signature.asc Description: PGP signature --

Re: [libvirt] [libvirt PATCH v2 33/44] Deprecate QEMU_CAPS_DRIVE_IOTUNE

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 4e5d180c62..6a2a141069 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -1659,17 +1659,13 @@ mymain(void) >

Re: [libvirt] [PATCH v1 6/7] tests: Update qemucapabilitiesdata

On Thu, Apr 12, 2018 at 18:39:51 +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik So this really needs to be squashed into the previous commit. Also It would help if you'd describe what you are doing since it does not seem to be the classic churn from just

Re: [libvirt] [PATCH v2 4/5] virobject: Check if @parent is the first member in class

On Tue, Apr 17, 2018 at 10:20:52AM +0200, Michal Privoznik wrote: > Our virObject code relies heavily on the fact that the first > member of the class struct is type of virObject (or some > derivation of if). Let's check for that. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH v1 5/7] qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

On Thu, Apr 12, 2018 at 18:39:50 +0200, Michal Privoznik wrote: > This capability tracks if memory-backend-file has discard-data > attribute or not. Neither this nor the next commit mention that they need to be squashed together. Since tests are broken otherwise, you really need to do that.

Re: [libvirt] [PATCH v2 3/5] virobject: Introduce VIR_CLASS_NEW() macro

On Tue, Apr 17, 2018 at 10:20:51AM +0200, Michal Privoznik wrote: > So far we are repeating the following lines over and over: > > if (!(virSomeObjectClass = virClassNew(virClassForObject(), > "virSomeObject", > sizeof(virSomeObject), >

Re: [libvirt] [libvirt PATCH v2 32/44] Deprecate QEMU_CAPS_FSDEV_WRITEOUT

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index ae183a380f..4e5d180c62 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -1506,9 +1506,8 @@ mymain(void) >

Re: [libvirt] [libvirt PATCH v2 31/44] Deprecate QEMU_CAPS_DRIVE_COPY_ON_READ

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 9534eb6fae..ae183a380f 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -955,8 +955,7 @@ mymain(void) >

[libvirt] [PATCH v2 5/5] cfg.mk: Introduce syntax-check rule to prefer VIR_CLASS_NEW

Now that we have macro that does some checks lets forbid raw usage of virClassNew() in favor of VIR_CLASS_NEW(). Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- cfg.mk | 8 1 file changed, 8 insertions(+) diff --git a/cfg.mk

[libvirt] [PATCH v2 3/5] virobject: Introduce VIR_CLASS_NEW() macro

So far we are repeating the following lines over and over: if (!(virSomeObjectClass = virClassNew(virClassForObject(), "virSomeObject", sizeof(virSomeObject), virSomeObjectDispose); return -1; While

[libvirt] [PATCH v2 0/5] virClassNew rework

Patches ACKed from v1 are pushed now (mostly, unless they don't make sense alone). diff to v1: - Expanded 1/5 to rename remote_protocol.x too, - Extended VIR_CLASS_NEW to be a standalone macro - Switched to compile time check instead of runtime one in 4/5 Michal Privoznik (5): datatypes:

[libvirt] [PATCH v2 4/5] virobject: Check if @parent is the first member in class

Our virObject code relies heavily on the fact that the first member of the class struct is type of virObject (or some derivation of if). Let's check for that. Signed-off-by: Michal Privoznik --- src/util/virobject.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[libvirt] [PATCH v2 2/5] src: Unify virObject member name

Whenever we declare a new object the first member of the struct has to be virObject (or any other member of that family). Now, up until now we did not care about the name of the struct member. But lets unify it so that we can do some checks at compile time later. The unified name is 'parent'.

[libvirt] [PATCH v2 1/5] datatypes: Rename @parent to @parentName in virNodeDevice

In next patches this name will be needed for a different memeber. Also, it makes sense to rename the variable because it does not contain reference to parent device, just its name. Signed-off-by: Michal Privoznik --- src/conf/virnodedeviceobj.c | 2 +-

Re: [libvirt] [libvirt PATCH v2 30/44] Deprecate QEMU_CAPS_FSDEV_READONLY

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > Implied by QEMU >= 1.2.0. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_capabilities.c | 1 - > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_command.c

Re: [libvirt] [PATCH v1 0/4] CPU Model Comparsion via QEMU

On Mon, Apr 16, 2018 at 19:16:05 -0400, Collin Walling wrote: > [Overview] > > This patch series implements an interface to "query-cpu-model-comparison" > (available QEMU ~2.8.0) via virsh cpu-compare. > > [Using This Feature] > > Run virsh cpu-compare (ensure you are running the virsh in your

Re: [libvirt] [PATCH v1 7/7] qemu: Enable memory-backend-file.discard-data whenever possible

On Thu, Apr 12, 2018 at 18:39:52 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_command.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH] docs: index.html.in: Fix a typo in "virtualization platforms" link

This was pointing to an .html.in file rather than to the intended html document. Signed-off-by: Erik Skultety --- Pushed under the trivial rule. docs/index.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.html.in b/docs/index.html.in

Re: [libvirt] [PATCH 8/9] virobject: Check if @parent is the first member in class

On Mon, Apr 16, 2018 at 06:27:45PM +0200, Michal Privoznik wrote: > On 04/16/2018 02:30 PM, Erik Skultety wrote: > > On Fri, Apr 13, 2018 at 04:47:15PM +0200, Michal Privoznik wrote: > >> Our virObject code relies heavily on the fact that the first > >> member of the class struct is type of

Re: [libvirt] [PATCH] virsh: Clear vsh last error during virshCommandOptVolBy

On Mon, Apr 16, 2018 at 11:55:51 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1529256 > > If one of the virStorageVolLookupBy{Key|Name|Path} succeeds and > we have a @vol, then clear the last libvirt error; otherwise, a > subsequent "other" failure may cause

Re: [libvirt] [PATCH] domain: avoid slash characters to the new domain name.

On Tue, Apr 17, 2018 at 00:27:27 -0300, Julio Faracco wrote: > The 'domrename' command needs to check if the new domain name contains > the slash character. This character is not accepted by libvirt XML > definition because it is an invalid char (see Cole's commit b1fc6a7b7). > This commit enhace

<    1   2   3