Re: [libvirt] [jenkins-ci PATCH 4/8] guests: libosinfo needs libcurl and wget

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 10:44 +0200, Pavel Hrdina wrote: > On Tue, May 15, 2018 at 04:40:05PM +0200, Andrea Bolognani wrote: > > libcurl is used directly, and wget is used to retrieve PCI > > and USB IDs at build time on platforms that don't ship them > > as part of the operating system, such as

Re: [libvirt] [jenkins-ci PATCH 4/8] guests: libosinfo needs libcurl and wget

2018-05-16 Thread Pavel Hrdina
On Tue, May 15, 2018 at 04:40:05PM +0200, Andrea Bolognani wrote: > libcurl is used directly, and wget is used to retrieve PCI > and USB IDs at build time on platforms that don't ship them > as part of the operating system, such as MinGW. > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [dbus PATCH 2/4] events: Rename AgentLifecycle event

2018-05-16 Thread kkoukiou
On Tue, 2018-05-15 at 15:35 +0200, Pavel Hrdina wrote: > Other lifecycle events use "{object}Event" format so use the same > format for this event as well. > > Signed-off-by: Pavel Hrdina > --- > data/org.libvirt.Domain.xml | 2 +- > src/events.c| 12

Re: [libvirt] [PATCH 0/8] GnuTLS fixes and requirements

2018-05-16 Thread Michal Privoznik
On 05/15/2018 02:03 PM, Ján Tomko wrote: > The first two patches fix the build and tests without GnuTLS. > The third requires GnuTLS 3.2.0 or newer. > > That means we don't have to worry about gnutls_hash_fast not > being present (introduced in GnuTLS 2.10.0). > > The rest of the patches cleans

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-16 Thread Ján Tomko
On Tue, May 15, 2018 at 05:24:40PM +0100, Daniel P. Berrangé wrote: On Tue, May 15, 2018 at 06:12:05PM +0200, Andrea Bolognani wrote: On Fri, 2018-05-11 at 14:59 +0200, Ján Tomko wrote: > Per the discussion here: > https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html > Switch

Re: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages

2018-05-16 Thread Pavel Hrdina
On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote: > Even though the packages are technically only needed when > performing a MinGW build, it doesn't hurt to have them > installed when performing native build, and keeping the > native packages all in one place is cleaner. > >

[libvirt] [jenkins-ci PATCH 4/3] guests: Add Package::Constants dependency for Perl projects

2018-05-16 Thread Andrea Bolognani
Module::Build requires Package::Constants in order to create distribution archives, but on some operating systems there is no explicit dependency dragging it the latter when installing the former, so we need to handle it ourselves. Signed-off-by: Andrea Bolognani --- It

Re: [libvirt] [PATCH python 0/5] Some fixes and one improvement

2018-05-16 Thread Michal Privoznik
On 05/16/2018 10:24 AM, Marc Hartmayer wrote: > Boris Fiuczynski (1): > libvirt-override.py: fix sparseSendAll > > Marc Hartmayer (4): > libvirt_qemu/lxc: import 'sys' package > libvirt_qemu/lxc: fix a namespace issue > libvirt-override.py: remove unused import > Allow virConnect to be

Re: [libvirt] [perl PATCH] Switch over to using Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:49:39AM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 20:47 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 08:17:09PM +0200, Andrea Bolognani wrote: > > > + /usr/bin/perl Build.PL installdirs=vendor > > > Created MYMETA.yml and MYMETA.json > > >

Re: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 10:49 +0200, Pavel Hrdina wrote: > On Tue, May 15, 2018 at 04:40:08PM +0200, Andrea Bolognani wrote: > > The MinGW variant of a build can assume native dependencies > > are installed, so no need to spell them out again. > > > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-16 Thread Erik Skultety
On Mon, May 14, 2018 at 02:53:49PM +0100, Daniel P. Berrangé wrote: > Historically we matched log filters with strstr(), and when switching to > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that > we would continue to match substrings, with "foo" being equivalent to >

[libvirt] [PATCH python 5/5] Allow virConnect to be used as a context manager

2018-05-16 Thread Marc Hartmayer
From: Marc Hartmayer The libvirt python bindings are now more 'pythonic' as virConnect can now be used as a context manager. For example, it's possible to write the following code: with libvirt.open() as conn: # do something with the connection...

Re: [libvirt] [PATCH] tests: Update caps for QEMU 2.12.0 on s390x

2018-05-16 Thread Boris Fiuczynski
On 05/15/2018 10:37 PM, John Ferlan wrote: On 05/15/2018 07:46 AM, Shalini Chellathurai Saroja wrote: Let us update the existing xml and replies files for QEMU 2.12.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja ---

[libvirt] [PATCH 12/22] Introduce virConnectBaselineHypervisorCPU public API

2018-05-16 Thread Jiri Denemark
The new API computes the most feature-rich CPU which is compatible with all given CPUs and can be provided by the specified hypervisor. It is a more useful version of vitConnectBaselineCPU, which doesn't consider any hypervisor capabilities when computing the best CPU. Signed-off-by: Jiri

[libvirt] [PATCH 22/22] news: Mention new CPU related APIs

2018-05-16 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 7d40e85b9a..bd7885e91a 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -54,6 +54,15 @@ a QEMU virtual machine.

[libvirt] [PATCH 16/22] cpu_x86: Add support for passing guest CPUs to virCPUx86Baseline

2018-05-16 Thread Jiri Denemark
Modern host CPU models from domain capabilities XMLs are reported as guest CPU definitions with feature policies. This patch updates virCPUx86Baseline to properly handle such CPU models. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 7 ++- 1 file changed, 2

[libvirt] [PATCH 11/22] qemu: Implement virConnectCompareHypervisorCPU

2018-05-16 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 60 ++ 1 file changed, 60 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6c086b9ef8..4b48afdad1 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 14/22] virsh: Introduce new hypervisor-cpu-baseline command

2018-05-16 Thread Jiri Denemark
This command is a virsh wrapper for virConnectBaselineHypervisorCPU. Signed-off-by: Jiri Denemark --- tools/virsh-host.c | 96 ++ tools/virsh.pod| 47 --- 2 files changed, 137 insertions(+), 6 deletions(-)

[libvirt] [PATCH 19/22] cpu: Add optional list of allowed features to virCPUBaseline

2018-05-16 Thread Jiri Denemark
When computing a baseline CPU for a specific hypervisor we have to make sure to include only CPU features supported by the hypervisor. Otherwise the computed CPU could not be used for starting a new domain. Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_driver.c | 2 +-

Re: [libvirt] [jenkins-ci PATCH] projects: Temporarily skip expensive tests on FreeBSD

2018-05-16 Thread Erik Skultety
On Tue, May 15, 2018 at 03:34:04PM +0200, Andrea Bolognani wrote: > The gnulib issue has been reported upstream, but solving it > is taking a bit and all jobs downstream of libvirt-master-check > are blocked in the meantime, which is less than ideal. Put a > temporary workaround in place. > >

[libvirt] [PATCH 17/22] cpu: Add explicit arch parameter for virCPUBaseline

2018-05-16 Thread Jiri Denemark
This is required for virCPUBaseline to accept a list of guest CPU definitions since they do not have arch set. Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_driver.c | 2 +- src/cpu/cpu.c| 16 +++- src/cpu/cpu.h| 3 ++-

Re: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote: > On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote: > > Even though the packages are technically only needed when > > performing a MinGW build, it doesn't hurt to have them > > installed when performing native build, and

Re: [libvirt] [dbus PATCH 3/4] events: Rename all lifecycle event functions to follow the signal name

2018-05-16 Thread kkoukiou
On Tue, 2018-05-15 at 15:35 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/events.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/src/events.c b/src/events.c > index deda9cc..6cc2164 100644 > ---

Re: [libvirt] [PATCH 0/9] Some virsh completion fixes

2018-05-16 Thread Michal Privoznik
On 05/15/2018 01:10 PM, Lin Ma wrote: > patch 1 is not about completion, I merge it into this patch set for > easy review because it's a tiny fix. > > Lin Ma (9): > virsh: Remove 'id' text from help message for 'domrename' command > virsh: Only return active domain names for 'reset' command >

Re: [libvirt] [PATCH 9/9] virsh: Add target name completion for block device options

2018-05-16 Thread Michal Privoznik
On 05/15/2018 01:18 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tools/virsh-domain-monitor.c | 2 ++ > tools/virsh-domain.c | 8 > 2 files changed, 10 insertions(+) > > diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c > index

Re: [libvirt] [PATCH 8/9] virsh: Introduce virshDomainBlockTargetCompleter

2018-05-16 Thread Michal Privoznik
On 05/15/2018 01:18 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tools/virsh-completer.c | 48 > tools/virsh-completer.h | 4 > 2 files changed, 52 insertions(+) > > diff --git a/tools/virsh-completer.c

Re: [libvirt] [jenkins-ci PATCH 5/8] guests: libvirt-dbus needs python3-gi

2018-05-16 Thread Pavel Hrdina
On Tue, May 15, 2018 at 04:40:06PM +0200, Andrea Bolognani wrote: > libvirt-glib is accessed through GObject Introspection > in the test suite. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/projects/libvirt-dbus.yml | 1 + > 1 file changed, 1 insertion(+)

Re: [libvirt] [jenkins-ci PATCH 6/8] guests: virt-manager needs gtk-update-icon-cache

2018-05-16 Thread Pavel Hrdina
On Tue, May 15, 2018 at 04:40:07PM +0200, Andrea Bolognani wrote: > It's used during installation. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 6 ++ > guests/vars/projects/virt-manager.yml | 1 + > 2 files changed, 7 insertions(+)

Re: [libvirt] [perl PATCH] Switch over to using Module::Build

2018-05-16 Thread Andrea Bolognani
On Tue, 2018-05-15 at 20:47 +0100, Daniel P. Berrangé wrote: > On Tue, May 15, 2018 at 08:17:09PM +0200, Andrea Bolognani wrote: > > + /usr/bin/perl Build.PL installdirs=vendor > > Created MYMETA.yml and MYMETA.json > > Creating new 'Build' script for 'Sys-Virt' version 'v4.4.0' > > + ./Build > >

Re: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages

2018-05-16 Thread Pavel Hrdina
On Tue, May 15, 2018 at 04:40:08PM +0200, Andrea Bolognani wrote: > The MinGW variant of a build can assume native dependencies > are installed, so no need to spell them out again. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/projects/libvirt+mingw.yml | 2

Re: [libvirt] [dbus PATCH 2/4] events: Rename AgentLifecycle event

2018-05-16 Thread k . koukiou
On Wed, 2018-05-16 at 10:54 +0200, kkouk...@redhat.com wrote: > On Tue, 2018-05-15 at 15:35 +0200, Pavel Hrdina wrote: > > Other lifecycle events use "{object}Event" format so use the same > > format for this event as well. > > > > Signed-off-by: Pavel Hrdina > > --- > >

[libvirt] [PATCH python 2/5] libvirt_qemu/lxc: fix a namespace issue

2018-05-16 Thread Marc Hartmayer
From: Marc Hartmayer Signed-off-by: Marc Hartmayer Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- generator.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[libvirt] [PATCH python 3/5] libvirt-override.py: fix sparseSendAll

2018-05-16 Thread Marc Hartmayer
From: Boris Fiuczynski Variable ret is used before assignment. Signed-off-by: Boris Fiuczynski Signed-off-by: Marc Hartmayer --- libvirt-override-virStream.py | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH python 0/5] Some fixes and one improvement

2018-05-16 Thread Marc Hartmayer
Boris Fiuczynski (1): libvirt-override.py: fix sparseSendAll Marc Hartmayer (4): libvirt_qemu/lxc: import 'sys' package libvirt_qemu/lxc: fix a namespace issue libvirt-override.py: remove unused import Allow virConnect to be used as a context manager generator.py | 8

[libvirt] [PATCH python 1/5] libvirt_qemu/lxc: import 'sys' package

2018-05-16 Thread Marc Hartmayer
From: Marc Hartmayer This fixes the pylint [1] warning "E: 25,16: Undefined variable 'sys' (undefined-variable)". [1] https://www.pylint.org/ Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski

[libvirt] [PATCH python 4/5] libvirt-override.py: remove unused import

2018-05-16 Thread Marc Hartmayer
From: Marc Hartmayer Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- libvirt-override.py | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 11:59:31AM +0200, Erik Skultety wrote: > On Mon, May 14, 2018 at 02:53:49PM +0100, Daniel P. Berrangé wrote: > > Historically we matched log filters with strstr(), and when switching to > > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that > > we would

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:53:22AM +0200, Ján Tomko wrote: > On Tue, May 15, 2018 at 05:24:40PM +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 06:12:05PM +0200, Andrea Bolognani wrote: > > > On Fri, 2018-05-11 at 14:59 +0200, Ján Tomko wrote: > > > > Per the discussion here: > > > >

Re: [libvirt] [dbus PATCH v2 0/4] API name fixes

2018-05-16 Thread kkoukiou
On Wed, 2018-05-16 at 12:55 +0200, Pavel Hrdina wrote: > changes in v2: > - fixed build error for each patch by moving all lifecycle > function > rename into a single patch > > Pavel Hrdina (4): > domain: Rename (Get|Set)BlkioParameters > events: Rename AgentLifecycle event >

Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Add Archive::Tar dependency for Perl projects

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 15:56 +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 13:39 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote: > > > Module::Build requires Archive::Tar in order to create > > > distribution archives, but on some

Re: [libvirt] [PATCH python 0/5] Some fixes and one improvement

2018-05-16 Thread Marc Hartmayer
On Wed, May 16, 2018 at 10:54 AM +0200, Michal Privoznik wrote: > On 05/16/2018 10:24 AM, Marc Hartmayer wrote: >> Boris Fiuczynski (1): >> libvirt-override.py: fix sparseSendAll >> >> Marc Hartmayer (4): >> libvirt_qemu/lxc: import 'sys' package >> libvirt_qemu/lxc:

Re: [libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 15:05 +0200, Erik Skultety wrote: > On Tue, May 15, 2018 at 03:00:15PM +0200, Andrea Bolognani wrote: > > On Mon, 2018-05-07 at 16:20 +0200, Andrea Bolognani wrote: > > > Changes from [v1]: > > > > > > * rename the script instead of dropping it; > > > > > > * perform some

Re: [libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

2018-05-16 Thread Pavel Hrdina
On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: > Using a QEMU 2.12 tagged tree build and full build, used: > > tests/qemucapsprobe /home/qemu/x86_64-softmmu/qemu-system-x86_64 > \ > tests/qemucapabilitiesdata/caps_2.12.0.x86_64.replies > > VIR_TEST_REGENERATE_OUTPUT=1

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Define archive_format for osinfo-db

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 15:25 +0200, Erik Skultety wrote: > On Thu, May 10, 2018 at 05:26:33PM +0200, Andrea Bolognani wrote: > > Follow the standard templating behavior instead of needlessly > > hardcoding information in the script. > > > > Signed-off-by: Andrea Bolognani > >

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Marc Hartmayer
On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" wrote: > On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: >> Introduce new libvirt API virDomainCreateWithParams that allows to >> temporarily boot from another boot device, to use another kernel, >>

Re: [libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 13:40 +0100, Daniel P. Berrangé wrote: > On Tue, May 15, 2018 at 08:27:36PM +0200, Andrea Bolognani wrote: > > We no longer need it, so blacklist it to make sure existing > > guests, where it was installed in the past, are cleaned up. > > > > We'll be able to drop it from

Re: [libvirt] [PATCH] tests: Update caps for QEMU 2.12.0 on s390x

2018-05-16 Thread Boris Fiuczynski
On 05/16/2018 04:41 PM, John Ferlan wrote: I'll add the following to the commit message: Used a z14 using a QEMU 2.12 GA build and the following sequence: tests/qemucapsprobe /path/to/s390x-softmmu/qemu-system-s390x > \ tests/qemucapabilitiesdata/caps_2.12.0.s390x.replies Hi

Re: [libvirt] [jenkins-ci PATCH 2/3] jobs: Use local_env for Perl test arguments

2018-05-16 Thread Erik Skultety
On Thu, May 10, 2018 at 05:35:44PM +0200, Andrea Bolognani wrote: > We're already using this approach for Go tests, the main > advantage being that we can use existing facilities instead > of defining custom one-use variables. > > Signed-off-by: Andrea Bolognani Reviewed-by:

Re: [libvirt] [tck PATCH] Use a pre-created MANIFEST file

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 11:01 +0100, Daniel P. Berrangé wrote: > Using the MANIFEST.SKIP blacklist approach risks creating tarballs with > extra files mistakenly included if the working directory is not clean. > Switch to a pre-created MANIFEST file, since maintaining this short list > of files is

Re: [libvirt] [perl PATCH v2] Switch over to using Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 04:56:24PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 18:54 +0100, Daniel P. Berrangé wrote: > [...] > > diff --git a/prepare-release.sh b/prepare-release.sh > > index fea03f4..6850350 100755 > > --- a/prepare-release.sh > > +++ b/prepare-release.sh > > @@ -4,52

[libvirt] [jenkins-ci PATCH] jobs: don't create MANIFEST file during build

2018-05-16 Thread Daniel P . Berrangé
Projects have switched to a pre-built MANIFEST Signed-off-by: Daniel P. Berrangé --- jobs/perl-modulebuild.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/jobs/perl-modulebuild.yaml b/jobs/perl-modulebuild.yaml index 60374da..a80d6b8 100644 ---

Re: [libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too

2018-05-16 Thread Erik Skultety
On Thu, May 10, 2018 at 05:35:45PM +0200, Andrea Bolognani wrote: > Perl jobs use the -test suffix instead of -check, which is > used everywhere else. Rename them in order to be consistent. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety

Re: [libvirt] [perl PATCH v2] Switch over to using Module::Build

2018-05-16 Thread Andrea Bolognani
On Tue, 2018-05-15 at 18:54 +0100, Daniel P. Berrangé wrote: [...] > diff --git a/prepare-release.sh b/prepare-release.sh > index fea03f4..6850350 100755 > --- a/prepare-release.sh > +++ b/prepare-release.sh > @@ -4,52 +4,18 @@ NAME=Sys-Virt > > set -e > > -test -n "$1" && RESULTS=$1 ||

[libvirt] ANNOUNCE: libvirt-dbus 1.0.0 released

2018-05-16 Thread Pavel Hrdina
I'm happy to announce the release of libvirt-dbus 1.0.0. libvirt-dbus wraps libvirt API to provide high-level object-oriented API better suited for dbus-based applications. You can download it here: https://libvirt.org/sources/dbus/libvirt-dbus-1.0.0.tar.gz * Fist stable release, from now

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Define archive_format for osinfo-db

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 05:18:56PM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 15:25 +0200, Erik Skultety wrote: > > On Thu, May 10, 2018 at 05:26:33PM +0200, Andrea Bolognani wrote: > > > Follow the standard templating behavior instead of needlessly > > > hardcoding information in the

Re: [libvirt] [jenkins-ci PATCH 1/3] jobs: Run commands after loading environments

2018-05-16 Thread Erik Skultety
On Thu, May 10, 2018 at 05:35:43PM +0200, Andrea Bolognani wrote: > The contents of either global_env or local_env might affect > the behavior of the build, so no command should be executed > before loading them both. > > Signed-off-by: Andrea Bolognani Reviewed-by: Erik

Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Add Archive::Tar dependency for Perl projects

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 13:39 +0100, Daniel P. Berrangé wrote: > On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote: > > Module::Build requires Archive::Tar in order to create > > distribution archives, but on some operating systems there > > is no explicit dependency dragging it the

[libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

2018-05-16 Thread John Ferlan
Using a QEMU 2.12 tagged tree build and full build, used: tests/qemucapsprobe /home/qemu/x86_64-softmmu/qemu-system-x86_64 > \ tests/qemucapabilitiesdata/caps_2.12.0.x86_64.replies VIR_TEST_REGENERATE_OUTPUT=1 tests/qemucapabilitiestest VIR_TEST_REGENERATE_OUTPUT=1 tests/domaincapstest

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: > On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" > wrote: > > On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: > >> Introduce new libvirt API virDomainCreateWithParams that allows to

[libvirt] [jenkins-ci PATCH 6/3] guests: Remove mapping for perl-ExtUtils-MakeMaker

2018-05-16 Thread Andrea Bolognani
It's no longer used anywhere. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 5 - 1 file changed, 5 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 14e0150..af026e1 100644 --- a/guests/vars/mappings.yml +++

Re: [libvirt] [PATCH] tests: Update caps for QEMU 2.12.0 on s390x

2018-05-16 Thread Shalini Chellathurai Saroja
On 05/16/2018 04:41 PM, John Ferlan wrote: On 05/16/2018 04:40 AM, Boris Fiuczynski wrote: On 05/15/2018 10:37 PM, John Ferlan wrote: On 05/15/2018 07:46 AM, Shalini Chellathurai Saroja wrote: Let us update the existing xml and replies files for QEMU 2.12.0 on s390x. Signed-off-by:

Re: [libvirt] [PATCH] tests: Update caps for QEMU 2.12.0 on s390x

2018-05-16 Thread John Ferlan
On 05/16/2018 04:40 AM, Boris Fiuczynski wrote: > On 05/15/2018 10:37 PM, John Ferlan wrote: >> >> >> On 05/15/2018 07:46 AM, Shalini Chellathurai Saroja wrote: >>> Let us update the existing xml and replies files for QEMU 2.12.0 on >>> s390x. >>> >>> Signed-off-by: Shalini Chellathurai Saroja

Re: [libvirt] [dbus PATCH 3/4] events: Rename all lifecycle event functions to follow the signal name

2018-05-16 Thread Pavel Hrdina
On Wed, May 16, 2018 at 11:20:38AM +0200, kkouk...@redhat.com wrote: > On Tue, 2018-05-15 at 15:35 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/events.c | 28 ++-- > > 1 file changed, 14 insertions(+), 14 deletions(-) > >

Re: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages

2018-05-16 Thread Pavel Hrdina
On Wed, May 16, 2018 at 11:14:26AM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 10:49 +0200, Pavel Hrdina wrote: > > On Tue, May 15, 2018 at 04:40:08PM +0200, Andrea Bolognani wrote: > > > The MinGW variant of a build can assume native dependencies > > > are installed, so no need to

Re: [libvirt] [PATCH v2] log: actually do substring matches with fnmatch

2018-05-16 Thread Erik Skultety
On Wed, May 16, 2018 at 12:17:16PM +0100, Daniel P. Berrangé wrote: > Historically we matched log filters with strstr(), and when switching to > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that > we would continue to match substrings, with "foo" being equivalent to >

Re: [libvirt] [dbus PATCH v2] docs: Introduce man file for libvirt-dbus daemon

2018-05-16 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 03:48:28PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > > changes in v2: > - added pod2man build dependency into spec file > > .gitignore| 2 ++ > Makefile.am | 2 +- > configure.ac | 1 + >

Re: [libvirt] [jenkins-ci PATCH 4/3] guests: Add Package::Constants dependency for Perl projects

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:52:38AM +0200, Andrea Bolognani wrote: > Module::Build requires Package::Constants in order to create > distribution archives, but on some operating systems there > is no explicit dependency dragging it the latter when > installing the former, so we need to handle it

Re: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages

2018-05-16 Thread Pavel Hrdina
On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote: > > On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote: > > > Even though the packages are technically only needed when > > > performing a MinGW build, it

Re: [libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 10:39 +0200, Pavel Hrdina wrote: > On Tue, May 15, 2018 at 04:40:02PM +0200, Andrea Bolognani wrote: > > -PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1 > > +PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2 > > PYTHONPATH:

[libvirt] [PATCH v2 4/4] docs: Update news.xml to describe encrypted image issues

2018-05-16 Thread John Ferlan
Signed-off-by: John Ferlan --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 7d40e85b9a..216e8b9754 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -67,6 +67,18 @@ + + +

[libvirt] [PATCH v2 3/4] storage_util: Don't assume "luks" encryption for resize

2018-05-16 Thread John Ferlan
Similar to encrypted image creation/conversion resizing the volume requires providing different parameters for luks and qcow[2] encryption. Alter storageBackendResizeQemuImgImageOpts to take the @type parameter filled in during storageBackendResizeQemuImg to either the current type or "luks" for

[libvirt] [PATCH v2 0/4] Fix qemu-img qcow[2] encrypted image handling

2018-05-16 Thread John Ferlan
v1: https://www.redhat.com/archives/libvir-list/2018-April/msg01578.html Changes since v1... Rather than disallow, alter the code in order to handle the creation, conversion, and resize of qcow[2] encrypted images. See conversion processing description from review:

Re: [libvirt] [sandbox PATCH v2 0/4] Remove Test::AutoBuild leftovers

2018-05-16 Thread Erik Skultety
On Tue, May 15, 2018 at 03:00:15PM +0200, Andrea Bolognani wrote: > On Mon, 2018-05-07 at 16:20 +0200, Andrea Bolognani wrote: > > Changes from [v1]: > > > > * rename the script instead of dropping it; > > > > * perform some further clean ups. The changes look reasonable to me. Reviewed-by: Erik

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 01:38:06PM +0200, Pavel Hrdina wrote: > On Wed, May 16, 2018 at 12:09:15PM +0100, Daniel P. Berrangé wrote: > > On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > > > Hi, > > > > > > I would like to make the next libvirt-dbus release with stable APIs, > > >

Re: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages

2018-05-16 Thread Andrea Bolognani
On Wed, 2018-05-16 at 12:34 +0200, Pavel Hrdina wrote: > On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote: > > Given how tiny the packages involved are, though, I think the > > trade-off is worth it, especially in light of the stuff I > > mentioned in the comments to the previous

[libvirt] [dbus PATCH v2 3/4] events: Rename IOErrorReason event

2018-05-16 Thread Pavel Hrdina
The "Reason" suffix exists in C API because there is another event without the reason and the suffix, however, in libvirt-dbus we will have only the version with reason. Signed-off-by: Pavel Hrdina --- data/org.libvirt.Domain.xml | 2 +- src/events.c| 2 +- 2

[libvirt] [dbus PATCH v2 4/4] events: Rename all lifecycle event functions to follow the signal name

2018-05-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/events.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/src/events.c b/src/events.c index b4793ba..b51664f 100644 --- a/src/events.c +++ b/src/events.c @@ -6,11

[libvirt] [dbus PATCH v2 2/4] events: Rename AgentLifecycle event

2018-05-16 Thread Pavel Hrdina
Other lifecycle events use "{object}Event" format so use the same format for this event as well. Signed-off-by: Pavel Hrdina --- data/org.libvirt.Domain.xml | 2 +- src/events.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [dbus PATCH v2 0/4] API name fixes

2018-05-16 Thread Pavel Hrdina
changes in v2: - fixed build error for each patch by moving all lifecycle function rename into a single patch Pavel Hrdina (4): domain: Rename (Get|Set)BlkioParameters events: Rename AgentLifecycle event events: Rename IOErrorReason event events: Rename all lifecycle event

Re: [libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker

2018-05-16 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 08:27:36PM +0200, Andrea Bolognani wrote: > We no longer need it, so blacklist it to make sure existing > guests, where it was installed in the past, are cleaned up. > > We'll be able to drop it from the blacklist, along with the > corresponding mapping, after a reasonable

[libvirt] [dbus PATCH v2 1/4] domain: Rename (Get|Set)BlkioParameters

2018-05-16 Thread Pavel Hrdina
Use (Get|Set)BlockIOParameters names to have the API names unified. Signed-off-by: Pavel Hrdina --- data/org.libvirt.Domain.xml | 4 ++-- src/domain.c| 32 2 files changed, 18 insertions(+), 18 deletions(-) diff --git

Re: [libvirt] [jenkins-ci PATCH 0/2] guests: Add Ubuntu 18.04 support

2018-05-16 Thread Pavel Hrdina
On Tue, May 15, 2018 at 04:48:53PM +0200, Andrea Bolognani wrote: > Applies cleanly on top of master, but requires [1] in order > to successfully install Ubuntu 18.04 guests. > > > [1] https://www.redhat.com/archives/libvir-list/2018-May/msg01105.html > > Andrea Bolognani (2): > guests:

[libvirt] [PATCH v2] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
Historically we matched log filters with strstr(), and when switching to fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that we would continue to match substrings, with "foo" being equivalent to "*foo*". Unfortuntely I forget to provide the code to actually make that happen.

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Pavel Hrdina
On Wed, May 16, 2018 at 12:09:15PM +0100, Daniel P. Berrangé wrote: > On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > > Hi, > > > > I would like to make the next libvirt-dbus release with stable APIs, > > there is a lot of them already implemented and other projects can start > >

Re: [libvirt] [PATCH] travis: Install Jansson instead of yajl

2018-05-16 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 06:03:01PM +0200, Andrea Bolognani wrote: > libvirt has switched to Jansson as its JSON implementation, > so we need it available for builds to succeed. yajl, on the > other hand, is no longer needed. > > Signed-off-by: Andrea Bolognani > --- > Should

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Daniel P . Berrangé
On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > Hi, > > I would like to make the next libvirt-dbus release with stable APIs, > there is a lot of them already implemented and other projects can start > adapting to use libvirt-dbus. > > The release version would be 1.0.0 and

[libvirt] [PATCH v2 2/4] storage_util: Fix qemu qcow[2] encryption convert processing

2018-05-16 Thread John Ferlan
As with qcow[2] encryption create processing, the convert processing requires usage of the "encrypt.key-secret" option and secret objects for converting an input volume to use qcow[2] encryption. Assuming an input file sparse.img exists (e.g. qemu-img create -f raw sparse 500K): $ qemu-img

[libvirt] [PATCH v2 1/4] storage_util: Alter qemu storage encryption arguments

2018-05-16 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1526382 As of QEMU 2.9, qemu-img has enforced using the "encrypt.key-secret" in order to create a qcow[2] encrypted volume. Thus, the existing code to create an encrypted volume using qcow[2] encryption techniques will fail, such as : $ qemu-img

Re: [libvirt] [jenkins-ci PATCH 1/3] guests: Install Module::Build for libvirt-perl

2018-05-16 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 08:27:34PM +0200, Andrea Bolognani wrote: > The libvirt-perl project switched from ExtUtils::MakeMaker to > Module::Build, so we need to change packages accordingly. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/projects/libvirt-perl.yml |

Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Add Archive::Tar dependency for Perl projects

2018-05-16 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote: > Module::Build requires Archive::Tar in order to create > distribution archives, but on some operating systems there > is no explicit dependency dragging it the latter when > installing the former, so we need to handle it

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Define archive_format for osinfo-db

2018-05-16 Thread Erik Skultety
On Thu, May 10, 2018 at 05:26:33PM +0200, Andrea Bolognani wrote: > Follow the standard templating behavior instead of needlessly > hardcoding information in the script. > > Signed-off-by: Andrea Bolognani > --- > projects/osinfo-db.yaml | 3 ++- > 1 file changed, 2

[libvirt] [jenkins-ci PATCH 5/3] guests: Fix PERL5LIB for Module::Build

2018-05-16 Thread Andrea Bolognani
Module::Build uses different paths for installation than those used by ExtUtils::MakeMaker, so we have to update the environment accordingly. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-6/main.yml| 2 +-

Re: [libvirt] [jenkins-ci PATCH 5/3] guests: Fix PERL5LIB for Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 01:58:01PM +0200, Andrea Bolognani wrote: > Module::Build uses different paths for installation than > those used by ExtUtils::MakeMaker, so we have to update the > environment accordingly. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [jenkins-ci PATCH 1/2] jobs: Move archive_format to defaults

2018-05-16 Thread Erik Skultety
On Thu, May 10, 2018 at 05:26:32PM +0200, Andrea Bolognani wrote: > Instead of repeating the definition all over the place, move > it to the defaults where it belongs. > > Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety -- libvir-list

[libvirt] Libvirt daemon split / VM shim progress

2018-05-16 Thread Daniel P . Berrangé
A update on progress splitting libvirtd into multiple daemons * General refactoring of the RPC client/server This is about allowing libvirtd daemon to forward API calls to other daemons when there is no built-in driver. It also involves the remote client learning how to connect to

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Christian Borntraeger
On 05/16/2018 05:35 PM, Daniel P. Berrangé wrote: > On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: >> On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" >> wrote: >>> On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: Introduce

Re: [libvirt] [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options

2018-05-16 Thread Thomas Huth
On 07.05.2018 19:01, Paolo Bonzini wrote: > On 07/05/2018 18:50, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 07/05/2018 13:56, Markus Armbruster wrote: Adding more and more ways to do the same stuff does not improve an interface. Interface design

Re: [libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

2018-05-16 Thread John Ferlan
On 05/16/2018 11:09 AM, Pavel Hrdina wrote: > On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: >> Using a QEMU 2.12 tagged tree build and full build, used: >> >> tests/qemucapsprobe /home/qemu/x86_64-softmmu/qemu-system-x86_64 > \ >>

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 06:21:40PM +0200, Christian Borntraeger wrote: > > > On 05/16/2018 05:35 PM, Daniel P. Berrangé wrote: > > On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: > >> On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" > >> wrote:

Re: [libvirt] [PATCH v1] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-05-16 Thread John Ferlan
$SUBJ: util: Fix addres On 05/15/2018 04:20 AM, Olaf Hering wrote: > Currently virNetSocketNewListenTCP bails out early under the following > conditions: > - the hostname resolves to at least one IPv4 and at least one IPv6 > address which produces what error? > - the local interfaces have

  1   2   >