[libvirt] [PATCH v9 01/11] qemu: provide support to query the SEV capability

QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. This patch adds support to query the SEV capability from the qemu. Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety ---

[libvirt] [tck PATCH v2 11/15] scripts: disable known hosts file

Despite having StrictHostKeyChecking=no, SSH still complains about the host key mismatch and disables password auth as a result. Using /dev/null as the known_hosts file ensures the keys are never saved to the user's profile. Signed-off-by: Daniel P. Berrangé ---

[libvirt] [tck PATCH v2 03/15] rpm: remove obsolete clean section

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 69e5621..be40d40 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10 +105,6 @@ find

[libvirt] [tck PATCH] network tests: change network address to avoid commonly-used subnet

My own machine has a virtual network on 192.168.123.0/24, and I've been told that it's a common selection for people who create a second network after libvirt's default (and in the past was used as a manual alternative for the default network itself when 192.168.122.0/24 casued a conflict).

Re: [libvirt] [tck PATCH 08/12] rpm: delete redundant changelog

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > The changelog entries only make sense in the context of a distro, not > upstream. If even that. I don't recall *ever* getting any useful info from the changelog (and wouldn't trust it anyway, since it's just manually written from the POV of one

Re: [libvirt] [tck PATCH 03/12] rpm: add some missing dependencies

On 06/08/2018 11:10 AM, Daniel P. Berrangé wrote: > I do still need to figure out just which APIs from newer libvirt > we require. I had added a function that uses the (relatively new I guess) API to get guest IP addresses, but wrote the code so that it would fall back to the older method of

Re: [libvirt] [tck PATCH v2 11/15] scripts: disable known hosts file

On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > Despite having StrictHostKeyChecking=no, SSH still complains about the > host key mismatch and disables password auth as a result. Using > /dev/null as the known_hosts file ensures the keys are never saved to > the user's profile. Interesting. I

Re: [libvirt] [PATCHv3 1/7] xen_xm: Split the per-disk logic from xenParseXMDisk()

On Mon, May 28, 2018 at 12:28:20AM +0200, Fabiano Fidêncio wrote: xenParseXMDisk() does a lot of stuff and, in order to make things cleaner, let's split it in two new functions: - xenParseXMDisk(): it's a new function that keeps the old name. It's responsible for the whole per-disk logic from

Re: [libvirt] [PATCHv3 3/7] vmx: convert to typesafe virConf accessors

On Mon, May 28, 2018 at 12:28:22AM +0200, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/vmx/vmx.c | 194 +- 1 file changed, 70 insertions(+), 124 deletions(-) -if (virUUIDParse(value->str, uuid) < 0) { -

Re: [libvirt] [dbus PATCH 3/8] Implement NWFilterDefineXML method for Connect Interface

On Fri, May 11, 2018 at 01:57:46PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

[libvirt] [PATCH v9 03/11] libvirt: Introduce virNodeGetSEVInfo public API

The API can be used by application to retrieve the Platform Diffie-Hellman Key and Platform Certificate chain. Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety --- include/libvirt/libvirt-host.h | 42 src/driver-hypervisor.h| 6 ++

[libvirt] [jenkins-ci PATCH] guests: Install ip and tc for libvirt

They're both pretty much guaranteed to be dragged in by other packages already, but since we're being explicit in the spec file might as well be explicit here too. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 10 ++ guests/vars/projects/libvirt.yml | 2 ++ 2

Re: [libvirt] [tck PATCH 00/12] Misc fixes to the TCK

On Fri, Jun 08, 2018 at 02:45:39PM +0100, Daniel P. Berrangé wrote: > Some final misc fixes before doing a new release Self-NACK. Some more things need fixing and the license change patch is actually wrong. > > Daniel P. Berrangé (12): > rpm: use standard perl variables > rpm: fix license

Re: [libvirt] [tck PATCH 01/12] rpm: use standard perl variables

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > We don't need to manually build variables for perl install locations > as RPM includes that. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > perl-Sys-Virt-TCK.spec.PL | 16 > 1 file changed, 4

Re: [libvirt] [PATCHv3 2/7] xen_vm: convert to typesafe virConf accessors

On Mon, May 28, 2018 at 12:28:21AM +0200, Fabiano Fidêncio wrote: Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xm.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature --

[libvirt] [PATCH 3/6] qemu: Fix Coverity build for qemu_monitor

Commit id '7ef0471bf' added a new parameter to qemuMonitorOpen, but didn't update the ATTTRIBUTE_NONNULL for the @cb (param 5). Signed-off-by: John Ferlan --- src/qemu/qemu_monitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.h

[libvirt] [PATCH 5/6] test: Check return status for libxlxml2domconfigtest

Commit id d8e8b63d introduced the test, but neglected to check for error from virTestLoadFile in testCompareXMLToDomConfig. Found by Coverity Signed-off-by: John Ferlan --- tests/libxlxml2domconfigtest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/3] util: add Intel x86 RDT/CMT support

Add RDT/CMT feature (Intel x86) by interacting with kernel resctrl file system. Integrate code into util/resctrl. --- src/libvirt_private.syms | 9 ++ src/util/virresctrl.c| 316 ++- src/util/virresctrl.h| 44 +++ 3 files changed, 367

[libvirt] [PATCH 3/3] tools: virsh domstats: show RDT CMT resource utilization information

--- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 11 + src/qemu/qemu_driver.c | 48 tools/virsh-domain-monitor.c | 7 ++ 4 files changed, 67 insertions(+) diff --git

Re: [libvirt] [PATCH v2 0/2] bhyve: add CPU topology support

On Tue, 2018-05-29 at 20:57 +0400, Roman Bogorodskiy wrote: > Changes since v1: > > - Added a check that nvcpus == sockets * cores * threads and >a test for that. > > Roman Bogorodskiy (2): > bhyve: add CPU topology support > docs: bhyve: document guest CPU topology feature Seems to

Re: [libvirt] [dbus PATCH 2/8] Implement ListNWFilters method for Connect Interface

On Fri, May 11, 2018 at 01:57:45PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 38 ++ 2 files changed, 44 insertions(+) Reviewed-by: Ján Tomko Jano

[libvirt] [tck PATCH v2 06/15] rpm: cleanup docs file list

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 0dea8de..a9b4148 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10

[libvirt] [tck PATCH v2 13/15] lib: merge NetworkHelpers module into main TCK module

The TCK module requires stuff in the NetworkHelpers and also vica-verca. This circular dependancy causes import problems, when trying to use the functions in NetworkHelpers from the TCK module. Signed-off-by: Daniel P. Berrangé --- MANIFEST | 1 -

[libvirt] [tck PATCH v2 08/15] build: misc updates the Module::Build config

Signed-off-by: Daniel P. Berrangé --- Build.PL | 12 +++- MANIFEST | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Build.PL b/Build.PL index bf2d7a9..75a1436 100644 --- a/Build.PL +++ b/Build.PL @@ -61,6 +61,9 @@ EOF my $b = $class->new( module_name =>

[libvirt] [tck PATCH v2 12/15] lib: use Test::More directly instead of Test::Builder

Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK.pm | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 29280f6..1a835bd 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -35,7 +35,7 @@ use

Re: [libvirt] [tck PATCH 02/12] rpm: fix license tag to include option of Artistic license

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > perl-Sys-Virt-TCK.spec.PL | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL > index

Re: [libvirt] [tck PATCH 04/12] rpm: remove obsolete clean section

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > perl-Sys-Virt-TCK.spec.PL | 4 > 1 file changed, 4 deletions(-) > > diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL > index c92fa34..b4cb4a9 100644 >

Re: [libvirt] [tck PATCH 05/12] rpm: remove obsolete build root setting

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > perl-Sys-Virt-TCK.spec.PL | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL > index b4cb4a9..2d5c38b 100644 > ---

Re: [libvirt] [tck PATCH 06/12] rpm: remove obsolete group setting

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > perl-Sys-Virt-TCK.spec.PL | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL > index 2d5c38b..d3544b6 100644 > ---

Re: [libvirt] [dbus PATCH 4/8] Implement Name property for NWFilter Interface

On Fri, May 11, 2018 at 01:57:47PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.NWFilter.xml | 5 + src/nwfilter.c| 43 +++ 2 files changed, 48 insertions(+) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [tck PATCH v2 12/15] lib: use Test::More directly instead of Test::Builder

On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé I don't pretend to know much of anything about this testing framework, but I guess this make the code here more like what's in the other files. Reviewed-by: Laine Stump > --- > lib/Sys/Virt/TCK.pm | 20

Re: [libvirt] [tck PATCH v2 14/15] license: only refer to the GPL not Artistic

On Fri, Jun 08, 2018 at 11:42:14AM -0400, Laine Stump wrote: > On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > > The source file headers all say GPL and do not mention the Artistic > > license, likewise the Build.PL file and RPM Spec. Remove bogus > > references to the Artistic license from

Re: [libvirt] [tck PATCH v2 15/15] lib: fix array value accessor to use preferred style

On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé What? You've found a style error in my cargo-cult perl? Astounding!! :-P (My recollection is that I tried several different combinations until I hit on one that worked. I don't perl so good...) Reviewed-by:

Re: [libvirt] [dbus PATCH 5/8] Implement UUID property for NWFilter Interface

On Fri, May 11, 2018 at 01:57:48PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.NWFilter.xml | 5 + src/nwfilter.c| 21 + 2 files changed, 26 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [tck PATCH 11/12] build: ignore more auto generated files

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitignore b/.gitignore > index ca3e424..65b446f 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -3,7

Re: [libvirt] [dbus PATCH 6/8] Implement GetXMLDesc method for NWFilter Interface

On Fri, May 11, 2018 at 01:57:49PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.NWFilter.xml | 6 ++ src/nwfilter.c| 28 2 files changed, 34 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [tck PATCH 10/12] conf: update URLs for Fedora 28 images

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > conf/default.cfg | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/conf/default.cfg b/conf/default.cfg > index d9d858c..494c303 100644 > --- a/conf/default.cfg > +++

Re: [libvirt] [dbus PATCH 7/8] Implement NWFilterLookupByName method for Connect Interface

On Fri, May 11, 2018 at 01:57:50PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [dbus PATCH 0/8] NWFilter APIs

On Fri, May 11, 2018 at 01:57:43PM +0200, Katerina Koukiou wrote: Katerina Koukiou (8): Introduce NWFilter Interface Implement ListNWFilters method for Connect Interface Implement NWFilterDefineXML method for Connect Interface We have define, but there's no Undefine. Jano Implement Name

Re: [libvirt] [dbus PATCH 8/8] Implement NWFilterLookupByUUID method for Connect Interface

On Fri, May 11, 2018 at 01:57:51PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [tck PATCH] Fix typo/bug in get_network_ip

On Fri, Jun 08, 2018 at 11:52:07AM -0400, Laine Stump wrote: > Signed-off-by: Laine Stump > --- > lib/Sys/Virt/TCK.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm > index 78d3774..67eb5f0 100644 > --- a/lib/Sys/Virt/TCK.pm >

[libvirt] [tck PATCH] Fix typo/bug in get_network_ip

Signed-off-by: Laine Stump --- lib/Sys/Virt/TCK.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 78d3774..67eb5f0 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -1259,7 +1259,7 @@ sub get_network_ip { if

[libvirt] [PATCH v9 07/11] qemu/cgroup: add /dev/sev in shared devices list

QEMU uses /dev/sev device while creating the SEV guest, lets add /dev/sev in the list of devices allowed to be accessed by the QEMU. Signed-off-by: Brijesh Singh <> Reviewed-by: Erik Skultety --- docs/drvqemu.html.in | 3 ++- src/qemu/qemu.conf | 2 +-

[libvirt] [PATCH v9 11/11] qemu: Implement the driver backend for virDomainGetLaunchSecurityInfo

This patch implements the internal driver API for launch event into qemu driver. When SEV is enabled, execute 'query-sev-launch-measurement' to get the measurement of memory encrypted through launch sequence. Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety --- src/qemu/qemu_driver.c

[libvirt] [PATCH v9 02/11] conf: expose SEV feature in domain capabilities

Extend hypervisor capabilities to include sev feature. When available, hypervisor supports launching an encrypted VM on AMD platform. The sev feature tag provides additional details like Platform Diffie-Hellman (PDH) key and certificate chain which can be used by the guest owner to establish a

[libvirt] [PATCH v9 06/11] conf: introduce launch-security element in domain

The launch-security element can be used to define the security model to use when launching a domain. Currently we support 'sev'. When 'sev' is used, the VM will be launched with AMD SEV feature enabled. SEV feature supports running encrypted VM under the control of KVM. Encrypted VMs have their

[libvirt] [PATCH v9 04/11] remote: implement the remote protocol for virNodeGetSEVInfo()

Add remote support for virNodeGetSEVInfo(). Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety --- src/remote/remote_daemon_dispatch.c | 44 + src/remote/remote_driver.c | 40 + src/remote/remote_protocol.x

[libvirt] [PATCH v9 05/11] qemu: Implement the driver backend for virNodeGetSEVInfo()

Signed-off-by: Brijesh Singh <> --- src/qemu/qemu_capabilities.c | 7 src/qemu/qemu_capabilities.h | 4 +++ src/qemu/qemu_driver.c | 82 3 files changed, 93 insertions(+) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v9 00/11] x86: Secure Encrypted Virtualization (AMD)

This patch series provides support for launching an encrypted guest using AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV feature allows the memory

[libvirt] [PATCH v9 09/11] libvirt: Introduce virDomainGetLaunchSecurityInfo public API

The API can be used outside the libvirt to get the launch security information. When SEV is enabled, the API can be used to get the measurement of the launch process. Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety --- include/libvirt/libvirt-domain.h | 17 ++

[libvirt] [PATCH v9 08/11] qemu: add support to launch SEV guest

QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted VMs on AMD platform using SEV feature. The various inputs required to launch SEV guest is provided through the tag. A typical SEV guest launch command line looks like this: # $QEMU ...\ -object

[libvirt] [PATCH v9 10/11] remote: implement the remote protocol for launch security

Add remote support for launch security info. Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety --- src/remote/remote_daemon_dispatch.c | 47 + src/remote/remote_driver.c | 40 +++ src/remote/remote_protocol.x

[libvirt] [tck PATCH v2 10/15] build: ignore more auto generated files

Signed-off-by: Daniel P. Berrangé --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index ca3e424..65b446f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,10 @@ *.orig *~ Build +META.json META.yml +MYMETA.json +MYMETA.yml Makefile Makefile.PL

[libvirt] [tck PATCH v2 14/15] license: only refer to the GPL not Artistic

The source file headers all say GPL and do not mention the Artistic license, likewise the Build.PL file and RPM Spec. Remove bogus references to the Artistic license from the LICENSE file. Signed-off-by: Daniel P. Berrangé --- LICENSE | 159

[libvirt] [tck PATCH v2 09/15] conf: update URLs for Fedora 28 images

Signed-off-by: Daniel P. Berrangé --- conf/default.cfg | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index d9d858c..494c303 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images = ( hvm

[libvirt] [tck PATCH v2 02/15] rpm: add some missing dependencies

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 4b1683f..69e5621 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL

[libvirt] [tck PATCH v2 07/15] rpm: delete redundant changelog

The changelog entries only make sense in the context of a distro, not upstream. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 2 -- 1 file changed, 2 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index a9b4148..0026b7e 100644 ---

Re: [libvirt] [tck PATCH] network tests: change network address to avoid commonly-used subnet

On Fri, Jun 08, 2018 at 10:59:58AM -0400, Laine Stump wrote: > My own machine has a virtual network on 192.168.123.0/24, and I've > been told that it's a common selection for people who create a second > network after libvirt's default (and in the past was used as a manual > alternative for the

Re: [libvirt] [tck PATCH] scripts: shorten netdev/domain name to prevent overflow

On Fri, Jun 08, 2018 at 11:00:34AM -0400, Laine Stump wrote: > When new pids are more than 9 digits long > > The nwfilter tests use tck-test${pid} as the auto-generated name for > their test domains (and therefore the tap devices created for those > test domains). When the pid is > 9 digits long,

Re: [libvirt] [tck PATCH 03/12] rpm: add some missing dependencies

On Fri, Jun 08, 2018 at 11:07:13AM -0400, Laine Stump wrote: > On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > perl-Sys-Virt-TCK.spec.PL | 15 --- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git

Re: [libvirt] [tck PATCH 07/12] rpm: cleanup docs file list

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > perl-Sys-Virt-TCK.spec.PL | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL > index

Re: [libvirt] [RFC PATCH 4/7] conf: Introduce new attribute 'display'

[...] if (mdevsrc->display) >> >> ->display > VIR_TRISTATE_SWITCH_ABSENT >> >>> +virBufferAsprintf(buf, " display='%s'", >>> + >>> virTristateSwitchTypeToString(mdevsrc->display)); >>> +} >>> + >>> } >>>

Re: [libvirt] [tck PATCH v2 11/15] scripts: disable known hosts file

On Fri, Jun 08, 2018 at 11:29:35AM -0400, Laine Stump wrote: > On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > > Despite having StrictHostKeyChecking=no, SSH still complains about the > > host key mismatch and disables password auth as a result. Using > > /dev/null as the known_hosts file

Re: [libvirt] [PATCH v2 0/2] bhyve: add CPU topology support

Andrea Bolognani wrote: > On Tue, 2018-05-29 at 20:57 +0400, Roman Bogorodskiy wrote: > > Changes since v1: > > > > - Added a check that nvcpus == sockets * cores * threads and > >a test for that. > > > > Roman Bogorodskiy (2): > > bhyve: add CPU topology support > > docs: bhyve:

Re: [libvirt] [dbus PATCH 1/8] Introduce NWFilter Interface

On Fri, May 11, 2018 at 01:57:44PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/Makefile.am | 1 + data/org.libvirt.NWFilter.xml | 7 + src/Makefile.am | 1 + src/connect.c | 6 src/connect.h | 1 +

[libvirt] [jenkins-ci PATCH] guests: Don't use filters as conditionals

Recent versions of Ansible point out this mistake too. Signed-off-by: Andrea Bolognani --- To be applied on top of https://www.redhat.com/archives/libvir-list/2018-June/msg00685.html Should have posted both at the same time as a series, but it's too late for that now ¯\_(ツ)_/¯

[libvirt] [tck PATCH v2 01/15] rpm: use standard perl variables

We don't need to manually build variables for perl install locations as RPM includes that. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL

[libvirt] [tck PATCH v2 04/15] rpm: remove obsolete build root setting

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index be40d40..ab2194f 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -34,7 +34,6 @@ License: GPLv2

[libvirt] [tck PATCH v2 05/15] rpm: remove obsolete group setting

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index ab2194f..0dea8de 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -31,7 +31,6 @@ Name:

[libvirt] [tck PATCH v2 00/15] Misc fixes to the TCK

Some final misc fixes before doing a new release Daniel P. Berrangé (15): rpm: use standard perl variables rpm: add some missing dependencies rpm: remove obsolete clean section rpm: remove obsolete build root setting rpm: remove obsolete group setting rpm: cleanup docs file list

[libvirt] [tck PATCH v2 15/15] lib: fix array value accessor to use preferred style

Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 60bd136..78d3774 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -1275,7 +1275,7 @@ sub get_ip_from_leases{

[libvirt] [tck PATCH] scripts: shorten netdev/domain name to prevent overflow

When new pids are more than 9 digits long The nwfilter tests use tck-test${pid} as the auto-generated name for their test domains (and therefore the tap devices created for those test domains). When the pid is > 9 digits long, the total length of the name is > 16, which is the maximum length for

Re: [libvirt] [tck PATCH 03/12] rpm: add some missing dependencies

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > perl-Sys-Virt-TCK.spec.PL | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL > index 39cc72f..c92fa34 100644

Re: [libvirt] [PATCH v9 00/11] x86: Secure Encrypted Virtualization (AMD)

Re: Jano's below comment (Also, some of the patches have double "<< >>" around your e-mail, how did that happen?) I am not sure what I am doing that is causing the double "<< >>" around my email address in some patches. I tried fixing it after I saw Jano note but it somehow happens

Re: [libvirt] [tck PATCH 09/12] build: misc updates the Module::Build config

On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump > --- > Build.PL | 12 +++- > MANIFEST | 1 - > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/Build.PL b/Build.PL > index bf2d7a9..75a1436 100644 > ---

Re: [libvirt] [tck PATCH v2 13/15] lib: merge NetworkHelpers module into main TCK module

On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > The TCK module requires stuff in the NetworkHelpers and also vica-verca. > This circular dependancy causes import problems, when trying to use the > functions in NetworkHelpers from the TCK module. > > Signed-off-by: Daniel P. Berrangé

Re: [libvirt] [tck PATCH v2 13/15] lib: merge NetworkHelpers module into main TCK module

On Fri, Jun 08, 2018 at 11:38:07AM -0400, Laine Stump wrote: > On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > > The TCK module requires stuff in the NetworkHelpers and also vica-verca. > > This circular dependancy causes import problems, when trying to use the > > functions in NetworkHelpers

Re: [libvirt] [tck PATCH v2 14/15] license: only refer to the GPL not Artistic

On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > The source file headers all say GPL and do not mention the Artistic > license, likewise the Build.PL file and RPM Spec. Remove bogus > references to the Artistic license from the LICENSE file. > > Signed-off-by: Daniel P. Berrangé So what's the

Re: [libvirt] [RFC PATCH 7/7] qemu: command: Enable formatting vfio-pci.display option onto cmdline

On 06/08/2018 07:09 AM, Erik Skultety wrote: > On Mon, Jun 04, 2018 at 07:40:42PM -0400, John Ferlan wrote: >> >> >> On 05/30/2018 09:43 AM, Erik Skultety wrote: >>> Signed-off-by: Erik Skultety >>> --- >>> src/qemu/qemu_command.c| 24 +++- >>>

[libvirt] [PATCH 0/6] Some Coverity patches

Resolve a few things that have built up previous and a couple that are more recent. John Ferlan (6): vbox: Fix resource leak vbox: Fix resource leak qemu: Fix Coverity build for qemu_monitor test: Fix resource leak in qemumonitorjsontest test: Check return status for

[libvirt] [PATCH 6/6] conf: Check error from virXMLFormatElement call

Commit id 1bd5a08d added a call to virXMLFormatElement without also checking the return status. Found by Coverity. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 1/6] vbox: Fix resource leak

Need to free the allocated hardDiskToOpen array. The contents of the array are just pointers returned by virVBoxSnapshotConfHardDiskByLocation and not allocated AFAICT so they don't need to also be freed as well. Found by Coverity Signed-off-by: John Ferlan --- src/vbox/vbox_common.c | 8

[libvirt] [PATCH 4/6] test: Fix resource leak in qemumonitorjsontest

Introduced by commmit id 37bd4571c. Need to goto cleanup and not return directly. Found by Coverity Signed-off-by: John Ferlan --- tests/qemumonitorjsontest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index

[libvirt] [PATCH 2/6] vbox: Fix resource leak

The @disk was allocated, filled in, and consumed on the normal path, but for error/cleanup paths it would be leaked. Rename to newHardDisk and manage properly. Found by Coverity Signed-off-by: John Ferlan --- src/vbox/vbox_common.c | 20 +++- 1 file changed, 11 insertions(+),

Re: [libvirt] [jenkins-ci PATCH] Add perl-generators package

On Fri, Jun 08, 2018 at 11:41:54AM +0200, Andrea Bolognani wrote: > On Fri, 2018-06-08 at 09:49 +0100, Daniel P. Berrangé wrote: > [...] > > + perl-generators: > > +default: > > +Fedora: perl-generators > > Sorting is off - this should be further down, after perl-accessors. > > Empty

[libvirt] [PATCH] news: Add the qemu VM reconnect segfault fix into bugfixes section

Signed-off-by: Erik Skultety --- This is IMHO worth mentioning in the news as it might be forgotten with our monthly "late news" update right before the release. docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

On Wed, Jun 06, 2018 at 03:46:37PM +0800, bing.niu wrote: > Hi Pavel, > > On 2018年06月06日 13:56, bing.niu wrote: > > > > > > > Then there is the domain XML, for CAT we use this: > > > > > > > > >    ... > > >    > > > ... > > > > > >    > > >    > > > > > > ...

[libvirt] [PATCH v2 1/1] qemu: add entry for balloon stat stat-disk-caches

Signed-off-by: Tomáš Golembiovský --- include/libvirt/libvirt-domain.h | 9 - src/libvirt-domain.c | 3 +++ src/qemu/qemu_monitor_json.c | 2 ++ tools/virsh-domain-monitor.c | 2 ++ 4 files changed, 15 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 0/1] qemu: add entry for balloon stat stat-disk-caches

v2: - moved item to last position in array - documented item also in libvirt-domain.c - added item to virsh listing Tomáš Golembiovský (1): qemu: add entry for balloon stat stat-disk-caches include/libvirt/libvirt-domain.h | 9 - src/libvirt-domain.c | 3 +++

Re: [libvirt] [PATCH] news: Add the qemu VM reconnect segfault fix into bugfixes section

On Fri, 2018-06-08 at 13:44 +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > This is IMHO worth mentioning in the news as it might be forgotten with our > monthly "late news" update right before the release. Note that such last-minute updates are *not* the way release notes are

[libvirt] [tck PATCH 12/12] Disable known hosts file

Despite having StrictHostKeyChecking=no, SSH still complains about the host key mismatch and disables password auth as a result. Using /dev/null as the known_hosts file ensures the keys are never saved to the user's profile. Signed-off-by: Daniel P. Berrangé ---

[libvirt] [tck PATCH 11/12] build: ignore more auto generated files

Signed-off-by: Daniel P. Berrangé --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index ca3e424..65b446f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,10 @@ *.orig *~ Build +META.json META.yml +MYMETA.json +MYMETA.yml Makefile Makefile.PL

[libvirt] [tck PATCH 07/12] rpm: cleanup docs file list

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index d3544b6..49f4a3c 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10

[libvirt] [tck PATCH 02/12] rpm: fix license tag to include option of Artistic license

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 4b1683f..39cc72f 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -30,7 +30,7

[libvirt] [tck PATCH 04/12] rpm: remove obsolete clean section

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index c92fa34..b4cb4a9 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10 +105,6 @@ find

[libvirt] [tck PATCH 06/12] rpm: remove obsolete group setting

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 2d5c38b..d3544b6 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -31,7 +31,6 @@ Name:

[libvirt] [PATCH 2/4] qemu: Introduce APIs for manipulating qemuDomainAgentJob

The point is to break QEMU_JOB_* into smaller pieces which enables us to achieve higher throughput. For instance, if there are two threads, one is trying to query something on qemu monitor while the other is trying to query something on agent monitor these two threads would serialize. There is not

[libvirt] [tck PATCH 03/12] rpm: add some missing dependencies

Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 39cc72f..c92fa34 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL

[libvirt] [tck PATCH 09/12] build: misc updates the Module::Build config

Signed-off-by: Daniel P. Berrangé --- Build.PL | 12 +++- MANIFEST | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Build.PL b/Build.PL index bf2d7a9..75a1436 100644 --- a/Build.PL +++ b/Build.PL @@ -61,6 +61,9 @@ EOF my $b = $class->new( module_name =>

[libvirt] [PATCH 3/4] qemuDomainAgentJob: Introduce query and modify jobs

These jobs can be used to mark job type over qemu agent. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 4 +++- src/qemu/qemu_domain.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 09404f6569..e5e11f0cb7

  1   2   >