Re: [libvirt] [RFCv2 PATCH 2/5] util: Add memory bandwidth support to resctrl

On 2018年06月30日 06:39, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu Add memory bandwidth allocation support basing on existing s/basing/based Will fix. virresctrl implementation. Two new structures virResctrlInfoMB ^^ "cache"

Re: [libvirt] [RFCv2 PATCH 4/5] conf: Introduce cputune/memorytune to support memory bandwidth allocation

On 2018年06月30日 06:47, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu Introduce a new section memorytune to support memory bandwidth allocation. This is consistent with existing cachetune . As the example below:

Re: [libvirt] [PATCH 1/2] virTypedParamsSerialize: minor fixes

On Wed, Jul 04, 2018 at 11:24 AM +0200, Marc Hartmayer wrote: > On Tue, Jul 03, 2018 at 09:14 PM +0200, John Ferlan > wrote: >> On 07/03/2018 06:32 AM, Marc Hartmayer wrote: >>> On Thu, Jun 21, 2018 at 03:47 PM +0200, Marc Hartmayer >>> wrote: On Wed, Jun 13, 2018 at 03:11 PM +0200,

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Wed, 4 Jul 2018 17:14:02 +0100 Peter Maydell wrote: > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > Essentially, what is important to me isn't getting these options dropped > > exactly in 3.0, but not setting a bad precedence that deprecation isn't > > actually worth anything. We may easily

Re: [libvirt] [PATCH 0/9] Resolve libvirtd hang on termination with connected long running client

On Tue, Jul 03, 2018 at 09:21 PM +0200, John Ferlan wrote: >> >> Is there any update so far? I’m asking because I’m still getting >> segmentation faults and hang-ups on termination of libvirtd (using the >> newest version of libvirt). >> >> Example for a hang-up: >> ➤ bt >> #0

[libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode

When support was adding for passing a pre-opened listener socket to UNIX chardevs, it accidentally passed the listener socket for client mode chardevs too with predictable amounts of fail resulting. Expand the unit test coverage to validate that we are only doing FD passing when operating in

Re: [libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode

On Fri, Jul 06, 2018 at 11:03:00AM +0100, Daniel P. Berrangé wrote: > When support was adding for passing a pre-opened listener socket to UNIX > chardevs, it accidentally passed the listener socket for client mode > chardevs too with predictable amounts of fail resulting. > > Expand the unit test

Re: [libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode

On Fri, Jul 06, 2018 at 12:12:51PM +0100, Richard W.M. Jones wrote: > On Fri, Jul 06, 2018 at 11:03:00AM +0100, Daniel P. Berrangé wrote: > > When support was adding for passing a pre-opened listener socket to UNIX > > chardevs, it accidentally passed the listener socket for client mode > >

[libvirt] [REPOST PATCHv2 0/2] Alter qemu live/cold device attach algorithm

REPOST of: https://www.redhat.com/archives/libvir-list/2018-June/msg00965.html Resolves conflicts with commit 5e9b150f and 4ad54a417 (adding @live and restoring the @action to virDomainDefCompatibleDevice method). The only change from the previous posting is an update to the commit message in

[libvirt] [REPOST PATCHv2 1/2] qemu: Check for existing hostdev address for cold attach device

Prior to the hostdev being inserted in the hostdevs list, add a check during qemuDomainAttachDeviceConfig to determine whether the new/incoming device is providing the same as some existing hostdev on the list and if so fail the cold attach. This cannot be done during

[libvirt] [REPOST PATCHv2 2/2] qemu: Use the correct vm def on cold attach

https://bugzilla.redhat.com/show_bug.cgi?id=1559867 When attaching a device to the domain we need to be sure to use the correct domain definition (vm->def or vm->newDef) when calling virDomainDeviceDefParse because the post parse processing algorithms that may assign an address for the device

[libvirt] [PATCH 1/1] Changed LPC slot from 1 to 31

From: Ivan Mishonov --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 802997bd2d..e595b3d6c1 100644 --- a/src/bhyve/bhyve_command.c +++

[libvirt] [PATCH 1/1] Changed LPC slot from 1 to 31

From: Ivan Mishonov --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 802997bd2d..e595b3d6c1 100644 --- a/src/bhyve/bhyve_command.c +++

[libvirt] [PATCH 0/1] Changed LPC slot from 1 to 31

From: Ivan Mishonov There was no keyboard input on Graphical UEFI guests running Windows 2016. Changed slot number according to the example given in the FreeBSD Handbook section related to bhyve and Graphical UEFI guests Ivan Mishonov (1): Changed LPC slot from 1 to 31

[libvirt] [PATCH 1/2] configure: Adding XFS library/headers check.

This commit checks for xfs.h library to use XFS_IOC_CLONE which is defined into that library file. So, after that it is possible to use thie macro to create reflinks. Signed-off-by: Julio Faracco --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac

[libvirt] [PATCH 0/2] Adding reflink support for XFS and others.

This serie add XFS library to use the macro for reflink (clone). This is the case where BTRFS is not available but XFS is. In case of both is unavailable, the code will use FICLONE from filesystem library if it is defined. This implementation is similar to copy command. If you run a copy and trace

[libvirt] [PATCH 2/2] storage: Rename btrfsCloneFile to support other filesystems.

This commit renames and adds other macros to support aother filesystems when a reflink is performed. After that, XFS filesystems (and others) with reflink support will be able to clone. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1565004 Signed-off-by: Julio Faracco ---

Re: [libvirt] [PATCH 2/2] storage: Rename btrfsCloneFile to support other filesystems.

On 07/06/2018 03:43 PM, Julio Faracco wrote: > This commit renames and adds other macros to support aother filesystems > when a reflink is performed. After that, XFS filesystems (and others) > with reflink support will be able to clone. > > Resolves:

[libvirt] [PATCH 0/1] Changed LPC slot from 1 to 31

From: Ivan Mishonov There was no keyboard input on Graphical UEFI guests running Windows 2016. Changed slot number according to the example given in the FreeBSD Handbook section related to bhyve and Graphical UEFI guests Ivan Mishonov (1): Changed LPC slot from 1 to 31

Re: [libvirt] [PATCHv1 05/12] qemu_monitor: CPUModelExpansion on CPUModel with both name and properties

Quoting Chris Venteicher (2018-06-21 23:42:04) > Send both model name and a set of features/properties to QEMU for > expansion rather than just the model name. > --- > src/qemu/qemu_capabilities.c | 33 +-- > src/qemu/qemu_monitor.c | 38 ++ >

Re: [libvirt] [PATCHv1 12/12] qemu_driver: BaselineHypervisorCPU supports S390 using QEMU/QMP

Quoting Chris Venteicher (2018-06-21 23:42:11) > Transient S390 configurations require using QEMU to compute CPU Model > Baseline and to do CPU Feature Expansion. > > Start and use a single QEMU instance to do both the baseline and > expansion transactions required by BaselineHypervisorCPU. > ---

Re: [libvirt] [PATCHv1 11/12] qemu_capabilities: Introduce virQEMUCapsQMPBaselineCPUModel (baseline using QEMU)

Quoting Collin Walling (2018-06-27 19:03:46) > On 06/22/2018 12:42 AM, Chris Venteicher wrote: > > Baseline cpu model using QEMU/QMP query-cpu-model-baseline > > > > query-cpu-model-baseline only compares two CPUModels so multiple > > exchanges are needed to evaluate more than two CPUModels. > >

Re: [libvirt] [PATCHv1 07/12] qemu_capabilities: virCPUDef / qemuMonitorCPUModelInfo conversions

Quoting Chris Venteicher (2018-06-21 23:42:06) > Bi-directional conversion functions. > Converts model / name and features / properties. > --- > src/qemu/qemu_capabilities.c | 137 +-- > src/qemu/qemu_capabilities.h | 3 + > 2 files changed, 118 insertions(+), 22

Re: [libvirt] [PATCH 0/2] Adding reflink support for XFS and others.

On 07/06/2018 03:42 PM, Julio Faracco wrote: > This serie add XFS library to use the macro for reflink (clone). This is > the case where BTRFS is not available but XFS is. In case of both is > unavailable, the code will use FICLONE from filesystem library if it is > defined. This implementation is

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > On Wed, 4 Jul 2018 17:14:02 +0100 > Peter Maydell wrote: > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > Essentially, what is important to me isn't getting these options dropped > > > exactly in 3.0, but not setting a bad precedence

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Fri, Jul 06, 2018 at 04:56:46PM +0200, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > On Wed, 4 Jul 2018 17:14:02 +0100 > > Peter Maydell wrote: > > > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > > Essentially, what is important to me isn't getting

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On 6 July 2018 at 15:56, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> That way, we can still easily remove old cruft (case (a)), but still >> accommodate cases like this (case (c)). The obvious drawback is that >> we'd need someone to curate the deprecation

Re: [libvirt] [PATCH 0/9] Resolve libvirtd hang on termination with connected long running client

On 07/06/2018 05:15 AM, Marc Hartmayer wrote: > On Tue, Jul 03, 2018 at 09:21 PM +0200, John Ferlan > wrote: >>> >>> Is there any update so far? I’m asking because I’m still getting >>> segmentation faults and hang-ups on termination of libvirtd (using the >>> newest version of libvirt). >>>

[libvirt] [dbus PATCH 05/15] Implement ListInterfaces method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 38 2 files changed, 44 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 7014a09..0604841 100644 ---

[libvirt] [dbus PATCH 12/15] Implement Create method for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 5 + src/interface.c| 24 2 files changed, 29 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index f50bc37..f62346a 100644 ---

[libvirt] [dbus PATCH 08/15] Implement InterfaceChangeCommit method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 604afea..8c88cc8 100644 ---

[libvirt] [dbus PATCH 02/15] Implement Name property for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 5 + src/interface.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index 93fa32f..ad7c326 100644 ---

[libvirt] [dbus PATCH 13/15] Implement Destroy method for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 5 + src/interface.c| 24 2 files changed, 29 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index f62346a..16caba1 100644 ---

[libvirt] [dbus PATCH 09/15] Implement InterfaceChangeRollback method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 8c88cc8..7c97117 100644 ---

[libvirt] [dbus PATCH 03/15] Implement MACString property for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 5 + src/interface.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index ad7c326..e6d9f2a 100644 ---

[libvirt] [dbus PATCH 06/15] Implement InterfaceDefineXML method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 30 ++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 0604841..791e1f5 100644 ---

[libvirt] [dbus PATCH 07/15] Implement InterfaceChangeBegin method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 791e1f5..604afea 100644 ---

[libvirt] [dbus PATCH 11/15] Implement InterfaceLookupByMACString method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index f99e205..535d225 100644 ---

[libvirt] [dbus PATCH 01/15] Introduce Interface Interface

Signed-off-by: Anya Harter --- data/Makefile.am | 1 + data/org.libvirt.Interface.xml | 7 +++ src/Makefile.am| 2 + src/connect.c | 6 +++ src/connect.h | 1 + src/interface.c| 86

[libvirt] [dbus PATCH 15/15] Implement GetXMLDesc method for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 6 ++ src/interface.c| 28 2 files changed, 34 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index 5ca366c..efe59e3 100644 ---

[libvirt] [dbus PATCH 14/15] Implement Undefine method for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 4 src/interface.c| 21 + 2 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index 16caba1..5ca366c 100644 ---

[libvirt] [dbus PATCH 00/15] Implement Interface APIs

https://libvirt.org/html/libvirt-libvirt-interface.html The following functions have been implemented: - virConnectListAllInterfaces (connect method) - virInterfaceChangeBegin (connect method) - virInterfaceChangeCommit (connect method) -

[libvirt] [dbus PATCH 10/15] Implement InterfaceLookupByName method for Connect Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 7c97117..f99e205 100644 ---

[libvirt] [dbus PATCH 04/15] Implement Active property for Interface Interface

Signed-off-by: Anya Harter --- data/org.libvirt.Interface.xml | 4 src/interface.c| 22 ++ 2 files changed, 26 insertions(+) diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml index e6d9f2a..f50bc37 100644 ---

Re: [libvirt] [RFCv2 PATCH 1/5] util: Rename and packing parts of virresctrl

On 07/06/2018 03:00 AM, bing.niu wrote: > > > On 2018年06月30日 06:36, John Ferlan wrote: >> >> >> On 06/15/2018 05:29 AM, bing@intel.com wrote: >>> From: Bing Niu >>> >>> Renaming some functions and packing some CAT logic into functions >> >> Try to do one "thing" per patch - the "and"

Re: [libvirt] [RFCv2 PATCH 3/5] conf: rename cachetune to restune

On 2018年07月06日 06:40, John Ferlan wrote: On 07/03/2018 12:10 AM, bing.niu wrote: Hi John, Thanks for reviewing! Since major questions are from this thread, so I think we can start from this. On 2018年06月30日 06:47, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote:

Re: [libvirt] [RFCv2 PATCH 1/5] util: Rename and packing parts of virresctrl

On 2018年06月30日 06:36, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu Renaming some functions and packing some CAT logic into functions Try to do one "thing" per patch - the "and" gives it away... Thus one patch could rename various functions and