Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

在 2018/7/17 下午8:35, Cornelia Huck 写道: On Tue, 10 Jul 2018 16:02:14 +0800 Yi Min Zhao wrote: Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function identifier).

Re: [libvirt] CPU Support

On 7/18/18 8:49 AM, Eduardo Habkost wrote: > CCing the AMD people who worked on this. > > On Wed, Jul 18, 2018 at 12:18:45PM +0200, Pavel Hrdina wrote: >> On Wed, Jul 18, 2018 at 10:50:34AM +0100, Daniel P. Berrangé wrote: >>> On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote:

Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache Monitoring Technology (CMT)

On Wed, Jul 18, 2018 at 12:19:18PM +, Wang, Huaqiang wrote: -Original Message- From: Martin Kletzander [mailto:mklet...@redhat.com] Sent: Wednesday, July 18, 2018 8:07 PM To: Wang, Huaqiang Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing ; Ding, Jian-feng ; Zang, Rui

[libvirt] [PATCH 7/9] qemu: monitor: Split out code to gather data from 'query-block'

Extract the code for future reuse. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index

[libvirt] [PATCH 8/9] utils: storage: Add helper for checking if storage source is the same

To allow checking whether a storage source points to the same location add a helper which checks the relevant fields. This will allow replacing a similar check done by formatting the command line arguments for qemu-like syntax. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 +

[libvirt] [PATCH 5/9] qemu: monitor: Add the 'query-nodes' argument for query-blockstats

The 'query-blockstats' command does not return statistics for the explicitly named nodes unless the new argument is specified. Add infrastrucuture that will allow us to use the new approach if desired. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c| 2 +- src/qemu/qemu_monitor.c

[libvirt] [PATCH 2/9] qemu: domain: Move out clearing of backing chain in qemuDomainDetermineDiskChain

In some cases backing chain needs to be cleared prior to re-detection. Move this step out of qemuDomainDetermineDiskChain as only certain places need it and the function itself is able to skip to the end of the chain to perform detection. Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c

[libvirt] [PATCH 9/9] qemu: Replace qemuDomainDiskSourceDiffers by virStorageSourceIsSameLocation

Now that we have a saner replacement for checking if the disk source is the same use it instead of formatting qemu command-line chunks. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 34 -- src/qemu/qemu_domain.h | 3 --- src/qemu/qemu_driver.c | 2 +-

[libvirt] [PATCH 3/9] qemu: domain: Add helper for getting the disk backend alias

The disk backend alias was historically the alias of the -drive backing the storage. For setups with -blockdev this will become more complex as it will depend on other configs and generally will differ. --- src/qemu/qemu_domain.c | 28 src/qemu/qemu_domain.h | 6

Re: [libvirt] [PATCH 04/10] qemu: hotplug: Prepare for multiple backing chain member hotplug

On Tue, Jul 17, 2018 at 02:14:24PM +0200, Peter Krempa wrote: Similarly to how we've intergrated data belonging to a single virStorageSource for purposes of attaching it to a qemu instance we will need to agregate data relevant for the whole disk. With blockdev there will be some disk-wide

Re: [libvirt] [PATCH 02/10] qemu: hotplug: Remove pointless variable

On Tue, Jul 17, 2018 at 02:14:22PM +0200, Peter Krempa wrote: Now that there's only one use of it, replace it directly by the code filling it. Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 01/10] qemu: hotplug: Reuse qemuHotplugPrepareDiskAccess in qemuDomainRemoveDiskDevice

On Tue, Jul 17, 2018 at 02:14:21PM +0200, Peter Krempa wrote: qemuHotplugPrepareDiskAccess can be used to tear down disk access so we can replace the open-coded version collecting the same function calls. Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 13 ++--- 1 file

Re: [libvirt] [PATCH v4 02/10] qemu: qemuBuildHostdevCommandLine: Use a helper variable mdevsrc

On Wed, Jul 18, 2018 at 02:31:38PM +0200, Erik Skultety wrote: Decrease the number of accessors we have to use. Signed-off-by: Erik Skultety --- src/qemu/qemu_command.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH v4 09/10] qemu: command: Enable formatting vfio-pci.display option onto cmdline

On Wed, Jul 18, 2018 at 02:31:45PM +0200, Erik Skultety wrote: Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display' which can be used to turn on display capabilities on vgpu-enabled mediated devices, IOW emulated GPU devices like QXL will no longer be needed with vgpu-enable

Re: [libvirt] [PATCHv4 15/15] m4: Introduce STABLE_ORDERING_JANSSON

On Wed, Jul 18, 2018 at 16:44:40 +0200, Ján Tomko wrote: > Add a second check for Jansson >= 2.8, which includes > fixes to preserve ordering of object keys. > > Use this constant to guard tests that depend on stable ordering. > > Signed-off-by: Ján Tomko > --- > m4/virt-jansson.m4 |

Re: [libvirt] [PATCH v4 04/10] qemu: Introduce a new graphics display type 'headless'

On Wed, Jul 18, 2018 at 02:31:40PM +0200, Erik Skultety wrote: Since 2.10 QEMU supports a new display type egl-headless which uses the drm nodes for OpenGL rendering copying back the rendered bits back to QEMU into a dma-buf which can be accessed by standard "display" apps like VNC or SPICE.

Re: [libvirt] [PATCHv4 12/15] Remove virJSONValueNewStringLen

On Wed, Jul 18, 2018 at 16:44:37 +0200, Ján Tomko wrote: > It is no longer used. > > Signed-off-by: Ján Tomko > --- ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 6/9] qemu: json: Extract gathering of block statistics

The code is useful also when gathering statistics per node name, so extract it to a separate functions. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 51 ++-- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git

[libvirt] [PATCH 1/9] qemu: driver: Reuse qemuDomainBlocksStatsGather in qemuDomainGetBlockInfo

Allow updating capacity for the block devices returned by qemuDomainBlocksStatsGather and replace the open-coded call to qemuMonitorGetAllBlockStatsInfo by the helper. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 41 - 1 file changed, 12

[libvirt] [PATCH 0/9] qemu: stats/misc refactors (blockdev-add saga)

Last lot of refactors which could be split of prior to starting it for real. Peter Krempa (9): qemu: driver: Reuse qemuDomainBlocksStatsGather in qemuDomainGetBlockInfo qemu: domain: Move out clearing of backing chain in qemuDomainDetermineDiskChain qemu: domain: Add helper for

[libvirt] [PATCH 4/9] qemu: command: use qemuDomainDiskGetBackendAlias in commandline building

Use the proper backend for the block device both when using -drive and when using -blockdev for disk drives and floppy disks. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

[libvirt] [PATCHv4 15/15] m4: Introduce STABLE_ORDERING_JANSSON

Add a second check for Jansson >= 2.8, which includes fixes to preserve ordering of object keys. Use this constant to guard tests that depend on stable ordering. Signed-off-by: Ján Tomko --- m4/virt-jansson.m4 | 3 +++ tests/qemublocktest.c| 5 +

[libvirt] [PATCHv4 12/15] Remove virJSONValueNewStringLen

It is no longer used. Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 1 - src/util/virjson.c | 22 -- src/util/virjson.h | 1 - 3 files changed, 24 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

Re: [libvirt] [PATCH v4 08/10] conf: Introduce new attribute 'display'

On Wed, Jul 18, 2018 at 02:31:44PM +0200, Erik Skultety wrote: QEMU 2.12 introduced a new type of display for mediated devices using vfio-pci backend which allows a mediated device to be used as a VGA compatible device as an alternative to an emulated video device. QEMU exposes this feature via

Re: [libvirt] [PATCH 05/10] qemu: hotplug: Don't leak 'disk' if VM crashes during unplug finishing

On Tue, Jul 17, 2018 at 02:14:25PM +0200, Peter Krempa wrote: qemuDomainRemoveDiskDevice would leak the disk to be removed if the VM crashed since it was removed from the definition but not freed. Broken in commit 105bcdde76b which moved the removal from the definition earlier. Signed-off-by:

Re: [libvirt] [PATCH 2/5] qemu: simplify graphics port releasing

On 17.07.2018 23:15, John Ferlan wrote: > > > On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote: >> Originally port allocator have 2 functions to release ports: one >> for for manually reserved ports and one for autoallocated ports. Thus >> a bit complicated code of port releasing. Now we

Re: [libvirt] [PATCH 1/4] tests: qemu: Remove disk from graphics-vnc-tls

On Tue, Jul 17, 2018 at 17:15:53 +0200, Ján Tomko wrote: > The disk command line is tested elsewhere. > > Signed-off-by: Ján Tomko > --- > tests/qemuxml2argvdata/graphics-vnc-tls.args | 2 -- > tests/qemuxml2argvdata/graphics-vnc-tls.xml | 6 -- >

Re: [libvirt] [PATCH 4/4] qemu: vnc: switch to tls-creds-x509

On Wed, Jul 18, 2018 at 09:55:47AM +0200, Ján Tomko wrote: > On Wed, Jul 18, 2018 at 08:32:44AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 17, 2018 at 05:15:56PM +0200, Ján Tomko wrote: > > > The tls, x509 and x509verify options were deprecated in QEMU v2.5.0: > > > > > > commit

Re: [libvirt] [PATCHv2 11/11] qemu_driver: BaselineHypervisorCPU supports S390 using QEMU/QMP

On 18.07.2018 00:39, Collin Walling wrote: > On 07/17/2018 05:01 PM, David Hildenbrand wrote: >> On 13.07.2018 18:00, Jiri Denemark wrote: >>> On Mon, Jul 09, 2018 at 22:56:55 -0500, Chris Venteicher wrote: Transient S390 configurations require using QEMU to compute CPU Model Baseline

Re: [libvirt] [PATCH 4/4] qemu: vnc: switch to tls-creds-x509

On Tue, Jul 17, 2018 at 05:15:56PM +0200, Ján Tomko wrote: > The tls, x509 and x509verify options were deprecated in QEMU v2.5.0: > > commit 3e305e4a4752f70c0b5c3cf5b43ec957881714f7 > Author: Daniel P. Berrange > > ui: convert VNC server to use QCryptoTLSSession > > Use the

Re: [libvirt] [PATCH 4/4] qemu: vnc: switch to tls-creds-x509

On Wed, Jul 18, 2018 at 08:32:44AM +0100, Daniel P. Berrangé wrote: On Tue, Jul 17, 2018 at 05:15:56PM +0200, Ján Tomko wrote: The tls, x509 and x509verify options were deprecated in QEMU v2.5.0: commit 3e305e4a4752f70c0b5c3cf5b43ec957881714f7 Author: Daniel P. Berrange ui: convert

Re: [libvirt] [PATCH 3/5] qemu: vnc: mark websocket as used on reconnect

On 17.07.2018 23:16, John Ferlan wrote: > > > On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote: >> Signed-off-by: Nikolay Shirokovskiy >> --- >> src/qemu/qemu_process.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > So your contention is that commit id 84067696 missed

Re: [libvirt] [PATCH 3/4] tests: qemu: test more versions for graphics-vnc-tls

On Tue, Jul 17, 2018 at 17:15:55 +0200, Ján Tomko wrote: > Add a test with QEMU 2.4.0 capabilites, as well as the latest caps. > > The code paths for formatting TLS options will be altered and > 2.4.0 is the newest version where QEMU_CAPS_OBJECT_TLS_CREDS_X509 > is not supported. > >

Re: [libvirt] [jenkins-ci PATCH v3 00/12] lcitool: Rewrite in Python (and add Dockefile generator)

On Tue, Jul 17, 2018 at 06:35:16PM +0200, Andrea Bolognani wrote: > pylint is reasonably happy with the script now: > > $ pylint lcitool > No config file found, using default configuration > * Module lcitool > C: 1, 0: Missing module docstring (missing-docstring) > C: 37,

Re: [libvirt] [PATCH 03/10] qemu: hotplug: Don't format NULL in %s in qemuHotplugPrepareDiskAccess

On Tue, Jul 17, 2018 at 02:14:23PM +0200, Peter Krempa wrote: The warning messages which include the disk source could potentially format NULL using %s as virDomainDiskGetSource may return NULL for e.g. NBD disks. As most of the APIs are NOOP for remote disks the usage of the source string only

[libvirt] [PATCHv4 04/15] FIXUP: fix tests

Jansson does not add an extra newline after the output and it formats empty elements differently. --- tests/qemublocktest.c| 1 + tests/qemumigparamsdata/empty.json | 4 +--- tests/qemumigparamsdata/unsupported.json | 4 +--- tests/virmacmaptestdata/empty.json | 4

[libvirt] [PATCHv4 08/15] FIXUP: s/WITH_YAJL/WITH_JANSSON/

--- src/qemu/qemu_driver.c | 2 +- tests/Makefile.am | 10 +- tests/cputest.c| 16 tests/libxlxml2domconfigtest.c | 4 ++-- tests/qemuagenttest.c | 2 +- tests/qemucapabilitiestest.c | 2 +- tests/qemucaps2xmltest.c

[libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

Unless explicitly requested, enable the QEMU driver only if the Jansson library is present. Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 index 80e1d3ad46..ddb2834705

[libvirt] [PATCHv4 09/15] FIXUP: libvirt.spec: use jansson instead of yajl

--- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6f360c5579..f83e5f8601 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -330,7 +330,7 @@ BuildRequires: systemd-devel >= 185 BuildRequires: libudev-devel >=

[libvirt] [PATCHv4 14/15] build: require Jansson if QEMU driver is enabled

If the QEMU driver was requested, require Jansson, since we need to use the JSON monitor to probe capabilities for all QEMU version supported by libvirt. Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/m4/virt-driver-qemu.m4

[libvirt] [PATCHv4 01/15] build: add --with-jansson

Introduce the configure argument and check for Jansson >= 2.5 Signed-off-by: Ján Tomko --- configure.ac | 3 +++ m4/virt-jansson.m4 | 29 + 2 files changed, 32 insertions(+) create mode 100644 m4/virt-jansson.m4 diff --git a/configure.ac b/configure.ac index

[libvirt] [PATCHv4 02/15] build: undef WITH_JANSSON for SETUID_RPC_CLIENT

There is no code using WITH_JANSSON yet, but once we add it, it should not be compiled for the setuid_rpc_client. Signed-off-by: Ján Tomko --- config-post.h | 1 + 1 file changed, 1 insertion(+) diff --git a/config-post.h b/config-post.h index 063e30fa37..24117bbbd4 100644 --- a/config-post.h

[libvirt] [PATCHv4 11/15] build: remove references to WITH_YAJL for SETUID_RPC_CLIENT

We no longer allow building WITH_YAJL, remove the remaining uses of the macro. Signed-off-by: Ján Tomko --- config-post.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/config-post.h b/config-post.h index 24117bbbd4..05672121f0 100644 --- a/config-post.h +++ b/config-post.h @@ -44,8 +44,6

[libvirt] [PATCHv4 03/15] Switch from yajl to Jansson

Yajl has not seen much activity upstream recently. Switch to using Jansson >= 2.5. All the platforms we target on https://libvirt.org/platforms.html have a version >= 2.7 listed on the sites below: https://repology.org/metapackage/jansson/versions

[libvirt] [PATCHv4 10/15] Remove functions using yajl

We no longer support building WITH_YAJL, remove the dead code as well as the virJSONParser structures that are no longer used. Signed-off-by: Ján Tomko --- src/util/virjson.c | 529 + 1 file changed, 1 insertion(+), 528 deletions(-) diff

[libvirt] [PATCHv4 06/15] FIXUP: make nss depend on Jansson instead of yajl

--- m4/virt-nss.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 951a74e835..082b7b14f6 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -27,9 +27,9 @@ AC_DEFUN([LIBVIRT_CHECK_NSS],[ bsd_nss=no fail=0 if test

[libvirt] [PATCHv4 00/15] Switch from yajl to Jansson

Per the discussion here: https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html Switch from using yajl to Jansson. v1: https://www.redhat.com/archives/libvir-list/2018-March/msg01781.html v2: https://www.redhat.com/archives/libvir-list/2018-May/msg00695.html v3:

[libvirt] [PATCHv4 05/15] FIXUP: Deprecate building --with-yajl

--- m4/virt-yajl.m4 | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/m4/virt-yajl.m4 b/m4/virt-yajl.m4 index c4ea0102a3..8d4c43a6b2 100644 --- a/m4/virt-yajl.m4 +++ b/m4/virt-yajl.m4 @@ -23,31 +23,10 @@ AC_DEFUN([LIBVIRT_ARG_YAJL],[

[libvirt] [PATCHv4 07/15] FIXUP: compile and link with Jansson instead of yajl

--- src/Makefile.am | 8 src/util/Makefile.inc.am | 4 ++-- tests/Makefile.am| 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index db8c8ebd1a..83263e69e5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -544,7

[libvirt] [PATCH] locking: don't create qemu-sanlock.conf file when QEMU isn't enabled

The test targets result in the qemu-sanlock.conf file being created when sanlock is enabled, even if QEMU is not enabled. As a result it never gets cleaned up when distclean is run, breaking distcheck. Signed-off-by: Daniel P. Berrangé --- src/locking/Makefile.inc.am | 8 ++-- 1 file

[libvirt] [PATCH] tests: fix TLS handshake failure with TLS 1.3

When gnutls negotiates TLS 1.3 instead of 1.2, the order of messages sent by the handshake changes. This exposed a logic bug in the test suite which caused us to wait for the server to see handshake completion, but not wait for the client to see completion. The result was the client didn't receive

[libvirt] [PATCHv2] examples: Add clean-traffic-gateway into nwfilters

The filter purpose is to simulate isolated private VLAN. The behavior can be achieved by limiting network traffic to traffic between VM and gateway. Because there is no concept of the PVLAN in the linux bridge. The filter also contains parts from clean-traffic to prevent VM from spoofing its IP

Re: [libvirt] [PATCH 2/2] docs: formatdomain: clarify period cputune subelement

On Tue, Jul 17, 2018 at 06:01:50PM +0200, Fabiano Fidêncio wrote: > On Tue, Jul 17, 2018 at 5:47 PM, Katerina Koukiou wrote: > > Although the name of the element is not self-explanatory, > > it's affecting only the vcpu threads. > > > > Signed-off-by: Katerina Koukiou > > --- > >

[libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

From: Bing Niu Refactoring virDomainCachetuneDefParse, extracting vcpus extracting, overlapping detecting and new resctrl allocation creating logic. Those two logic is common among different resource allocation technologies. Signed-off-by: Bing Niu --- src/conf/domain_conf.c | 195

[libvirt] [PATCH 1/9] util: Rename some functions of virresctrl

From: Bing Niu Some functions in virresctrl are for CAT only, while some of other functions are for resource allocation, not just CAT. So change their names to reflect the reality. Signed-off-by: Bing Niu --- src/conf/domain_conf.c | 8 src/libvirt_private.syms | 4 ++--

[libvirt] [PATCH 9/9] conf: Add memory bandwidth allocation capability of host

From: Bing Niu Add new XML section to report host's memory bandwidth allocation capability. The format as below example: . granularity granularity of memory bandwidth, unit percentage. min minimum memory bandwidth allowed, unit

[libvirt] [PATCH 0/9] Introduce RDT memory bandwidth allocation support

From: Bing Niu This series is to introduce RDT memory bandwidth allocation support by extending current virresctrl implementation. The Memory Bandwidth Allocation (MBA) feature provides indirect and approximate control over memory bandwidth available per-core. This feature provides a method to

[libvirt] [PATCH 4/9] util: Add MBA capability information query to resctrl

From: Bing Niu Introducing virResctrlInfoMemBW for the information memory bandwidth allocation information. Those information is used for memory bandwidth allocating. Signed-off-by: Bing Niu --- src/util/virresctrl.c | 104 ++ 1 file changed,

[libvirt] [PATCH 8/9] conf: Introduce cputune/memorytune to support memory bandwidth allocation

From: Bing Niu Introduce a new section memorytune to support memory bandwidth allocation. This is consistent with existing cachetune. As the example: below: .. vpus --- vpus subjected to this memory bandwidth. id--- on which node memory bandwidth to

Re: [libvirt] [PATCH 2/2] docs: formatdomain: clarify period cputune subelement

On Wed, Jul 18, 2018 at 10:05:30AM +0200, Ján Tomko wrote: > On Tue, Jul 17, 2018 at 05:47:32PM +0200, Katerina Koukiou wrote: > > Although the name of the element is not self-explanatory, > > it's affecting only the vcpu threads. > > > > Signed-off-by: Katerina Koukiou > > --- > >

Re: [libvirt] [jenkins-ci PATCH v2 10/12] lcitool: Add projects information handling

On Tue, 2018-07-17 at 19:55 +0200, Katerina Koukiou wrote: > I meant only having a variable for the playbook location. > > playbook_path = os.getenv('PLAYBOOK_PATH', './')) > > And then use os.path.join for all the others relative paths to the > playbook path. > So that you can actually run the

Re: [libvirt] CPU Support

On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: > Hi, > > I've been looking at the CPU list and although I see lots of CPU's, I > cannot find 2 CPU families: > > * AMD Ryzen > * AMD Threadripper > > Although EPYC has been added recently. > > Are there any missing details which

Re: [libvirt] [PATCH 2/2] docs: formatdomain: clarify period cputune subelement

On Tue, Jul 17, 2018 at 05:47:32PM +0200, Katerina Koukiou wrote: Although the name of the element is not self-explanatory, it's affecting only the vcpu threads. Signed-off-by: Katerina Koukiou --- docs/formatdomain.html.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [libvirt] [PATCH 1/2] docs: formatdomain: add info about global_period and global_quota for cputune

On Tue, Jul 17, 2018 at 05:47:31PM +0200, Katerina Koukiou wrote: > Patch series > https://www.redhat.com/archives/libvir-list/2016-January/msg00482.html The commit hashes would be better IMO, i.e. commits 4d92d5 and 55ecda. > introduced the parameters but didn't update the docs. > >

[libvirt] [PATCH 3/9] util: Refactor virResctrlAllocFormat of virresctrl

From: Bing Niu Refactor virResctrlAllocFormat so that it is easy to support other resource allocation technologies. Signed-off-by: Bing Niu --- src/util/virresctrl.c | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git

[libvirt] [PATCH 2/9] util: Refactor virResctrlGetInfo in virresctrl

From: Bing Niu Separate resctrl common information parts from CAT specific parts, so that common information parts can be reused among different resource allocation technologies. Signed-off-by: Bing Niu --- src/util/virresctrl.c | 31 ++- 1 file changed, 22

[libvirt] [PATCH 5/9] util: Add MBA allocation to virresctrl

From: Bing Niu Add memory bandwidth allocation support to virresctrl class. Introducing virResctrlAllocMemBW which is used for allocating memory bandwidth. Following virResctrlAllocPerType, it also employs a nested sparse array to indicate whether allocation is available for particular last

[libvirt] [PATCH 6/9] conf: Rename cachetune to restune

From: Bing Niu Resctrl not only supports cache tuning, but also memory bandwidth tuning. Renaming cachetune to restune(resource tuning) to reflect that. With restune, all allocation for different resources (cache, memory bandwidth) are aggregated and represented by a virResctrlAllocPtr inside

[libvirt] CPU Support

Hi, I've been looking at the CPU list and although I see lots of CPU's, I cannot find 2 CPU families: * AMD Ryzen * AMD Threadripper Although EPYC has been added recently. Are there any missing details which preventing adding those CPU's to the list? Thanks -- libvir-list mailing list

[libvirt] [dbus PATCH] tests: Explicitly spawn a session libvirt-dbus instance

Tests are performed using the session D-Bus instance, so we should launch libvirt-dbus in session mode as well. This was working fine when running the tests as a regular user, because in that case libvirt-dbus would default to session mode, but fail when running them as root because libvirt-dbus

Re: [libvirt] [PATCH v4 08/10] conf: Introduce new attribute 'display'

On Wed, Jul 18, 2018 at 05:06:28PM +0200, Ján Tomko wrote: > On Wed, Jul 18, 2018 at 02:31:44PM +0200, Erik Skultety wrote: > > QEMU 2.12 introduced a new type of display for mediated devices using > > vfio-pci backend which allows a mediated device to be used as a VGA > > compatible device as an

Re: [libvirt] [PATCH] conf: Don't parse edev of non-passthrough input device

On 07/11/2018 01:57 AM, Han Han wrote: > In input devices, edev attribute is only for passthrough devices. > Don't parse this for other input devices. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591151 > > Signed-off-by: Han Han > --- > src/conf/domain_conf.c | 3 ++- > 1

Re: [libvirt] [PATCH v4 09/10] qemu: command: Enable formatting vfio-pci.display option onto cmdline

On Wed, Jul 18, 2018 at 05:15:28PM +0200, Ján Tomko wrote: > On Wed, Jul 18, 2018 at 02:31:45PM +0200, Erik Skultety wrote: > > Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display' > > which can be used to turn on display capabilities on vgpu-enabled > > mediated devices, IOW

Re: [libvirt] [PATCH v2 2/3] conf: Introduce new video type 'none'

On Fri, Jul 13, 2018 at 01:56:32PM +0200, Ján Tomko wrote: > On Thu, Jul 12, 2018 at 05:08:47PM +0200, Erik Skultety wrote: > > Historically, we've always enabled an emulated video device every time we > > see that graphics should be supported with a guest. With the appearance > > of mediated

[libvirt] [PATCH v4] qemu: fix broken autostart symlink after renaming domain.

If a domain is configured to start on boot, it has a symlink to the domain definition inside the autostart directory. If you rename this domain, the definition is renamed too. The symlink need to be pointed to this renamed file. This commit recreates the symlink after renaming the XML file.

Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache Monitoring Technology (CMT)

> -Original Message- > From: Martin Kletzander [mailto:mklet...@redhat.com] > Sent: Wednesday, July 18, 2018 10:03 PM > To: Wang, Huaqiang > Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing > ; Ding, Jian-feng ; Zang, Rui > > Subject: Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT

Re: [libvirt] [PATCH v3 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

On 07/11/2018 05:44 AM, Han Han wrote: > Rename virFileIsCDROM to virFileCheckCDROM and add enum type > virFileCDRomStatus of cdrom statuses. Add argument cd_status in > virFileCheckCDROM filled with cdrom status. > > Now virFileCheckCDROM could be used to check the cdrom drive status such >

Re: [libvirt] [PATCH v3 2/2] storage: Improve error handling on cdrom backend

On 07/11/2018 05:44 AM, Han Han wrote: > Implement virFileCheckCDROM in virStorageBackendVolOpen to check if > cdrom backend is ready. Skip the error of cdrom not ready. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096 > > Signed-off-by: Han Han > --- >

Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache Monitoring Technology (CMT)

> -Original Message- > From: Martin Kletzander [mailto:mklet...@redhat.com] > Sent: Wednesday, July 18, 2018 8:07 PM > To: Wang, Huaqiang > Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing > ; Ding, Jian-feng ; Zang, Rui > > Subject: Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache

[libvirt] [PATCH v4 01/10] docs: formatdomain: unify naming for CPUs/vCPUs

From: Katerina Koukiou CPU is an acronym and should be written in uppercase when part of plain text and not refering to an element. Signed-off-by: Katerina Koukiou --- docs/formatdomain.html.in | 84 +++ 1 file changed, 42 insertions(+), 42

[libvirt] [PATCH v4 00/10] Enable vfio-pci 'property' for mediated device

RFC here: https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html Since v1 [1]: - remodeled egl-headless to be a standalone graphics element instead of a result of some automagic with graphic's element - pushed the first 5 simple fixes that were RB'd - fixed some nits raised during

[libvirt] [PATCH v4 06/10] conf: Introduce virDomainGraphicsDefHasOpenGL helper

A simple helper which will loop through all the graphics elements and checks whether at least one of them enables OpenGL support, either by containing or being of type 'egl-headless'. Signed-off-by: Erik Skultety Acked-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/conf/domain_conf.c

[libvirt] [PATCH v4 04/10] qemu: Introduce a new graphics display type 'headless'

Since 2.10 QEMU supports a new display type egl-headless which uses the drm nodes for OpenGL rendering copying back the rendered bits back to QEMU into a dma-buf which can be accessed by standard "display" apps like VNC or SPICE. Although this display type can be used on its own, for any practical

[libvirt] [PATCH v4 02/10] qemu: qemuBuildHostdevCommandLine: Use a helper variable mdevsrc

Decrease the number of accessors we have to use. Signed-off-by: Erik Skultety --- src/qemu/qemu_command.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 44ae8dcef7..c628ac3985 100644 --- a/src/qemu/qemu_command.c

[libvirt] [PATCH v4 08/10] conf: Introduce new attribute 'display'

QEMU 2.12 introduced a new type of display for mediated devices using vfio-pci backend which allows a mediated device to be used as a VGA compatible device as an alternative to an emulated video device. QEMU exposes this feature via a vfio device property 'display' with supported values

[libvirt] [PATCH v4 09/10] qemu: command: Enable formatting vfio-pci.display option onto cmdline

Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display' which can be used to turn on display capabilities on vgpu-enabled mediated devices, IOW emulated GPU devices like QXL will no longer be needed with vgpu-enable mdevs. QEMU defaults to 'auto' for the 'display' attribute, which

[libvirt] [PATCH v4 10/10] docs: Update news about the VNC console enablement for mdevs

Signed-off-by: Erik Skultety Acked-by: Michal Privoznik --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 773c95b0da..fd08c01aeb 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,16 @@ support should be

[libvirt] [PATCH v4 07/10] conf: Replace 'error' with 'cleanup' in virDomainHostdevDefParseXMLSubsys

The exit path is the same for both success and failure, so the label should be called cleanup. Signed-off-by: Erik Skultety Reviewed-by: Ján Tomko --- src/conf/domain_conf.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless

Since QEMU 2.10, it's possible to use a new type of display - egl-headless which uses drm nodes to provide OpenGL support. This patch adds a capability for that. However, since QEMU doesn't provide a QMP command to probe it, we have to base the capability on specific QEMU version. Signed-off-by:

[libvirt] [PATCH v4 05/10] qemu: caps: Add vfio-pci.display capability

QEMU 2.12 introduced a new vfio-pci device option 'display=on/off/auto'. This patch introduces the necessary capability. Signed-off-by: Erik Skultety Reviewed-by: John Ferlan Reviewed-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v2 3/3] docs: news: Provide an update about the video type 'none'

On Fri, Jul 13, 2018 at 02:02:10PM +0200, Ján Tomko wrote: > On Thu, Jul 12, 2018 at 05:08:48PM +0200, Erik Skultety wrote: > > Signed-off-by: Erik Skultety > > --- > > docs/news.xml | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/docs/news.xml b/docs/news.xml > >

Re: [libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless

On Wed, Jul 18, 2018 at 02:31:39PM +0200, Erik Skultety wrote: > Since QEMU 2.10, it's possible to use a new type of display - > egl-headless which uses drm nodes to provide OpenGL support. This patch > adds a capability for that. However, since QEMU doesn't provide a QMP > command to probe it, we

Re: [libvirt] [PATCH v2 3/3] docs: news: Provide an update about the video type 'none'

On Wed, Jul 18, 2018 at 02:34:05PM +0200, Erik Skultety wrote: On Fri, Jul 13, 2018 at 02:02:10PM +0200, Ján Tomko wrote: On Thu, Jul 12, 2018 at 05:08:48PM +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > docs/news.xml | 14 ++ > 1 file changed, 14 insertions(+) >

Re: [libvirt] [PATCH 2/3] support new forward mode of vlan for virtual network

> Sent: Wednesday, July 18, 2018 at 12:38 AM > From: "John Ferlan" > To: "Shi Lei" , libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 2/3] support new forward mode of vlan for > virtual network > > > > On 07/05/2018 11:36 PM, Shi Lei wrote: > > Signed-off-by: Shi Lei > > --- > >

[libvirt] [PATCH 11/10] qemu: hotplug: Add/remove managed PR objects on media change

When changing cdrom media we did not handle the managed PR objects thus we'd either have a stale PR object left behind or the media change would fail. Signed-off-by: Peter Krempa --- Opps this one was also left behind in the blockdev-add series but belongs to this posting.

Re: [libvirt] [PATCH 4/4] qemu: vnc: switch to tls-creds-x509

On Tue, Jul 17, 2018 at 17:15:56 +0200, Ján Tomko wrote: > The tls, x509 and x509verify options were deprecated in QEMU v2.5.0: > > commit 3e305e4a4752f70c0b5c3cf5b43ec957881714f7 > Author: Daniel P. Berrange > > ui: convert VNC server to use QCryptoTLSSession > > Use the

Re: [libvirt] [PATCH 3/3] fix other functions to add VIR_NETWORK_FORWARD_VLAN

> Sent: Wednesday, July 18, 2018 at 12:38 AM > From: "John Ferlan" > To: "Shi Lei" , libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 3/3] fix other functions to add > VIR_NETWORK_FORWARD_VLAN > > > > On 07/05/2018 11:36 PM, Shi Lei wrote: > > Signed-off-by: Shi Lei > > --- > >

Re: [libvirt] [PATCH 1/3] add functions: load 8021q module, create/destroy vlan-dev

[...] >>> + >>> +static int >>> +controlVlanDev(unsigned int cmd, >>> + const char *ifname, unsigned int vlanid) >> >> One line per argument. > > OK > >> >>> +{ >> >> int ret = -1; >> > > Why need ret? > I was going to suggest changing the code to use a cleanup: label like

Re: [libvirt] [PATCHv2] examples: Add clean-traffic-gateway into nwfilters

On Wed, Jul 18, 2018 at 10:33:03AM +0200, Ales Musil wrote: The filter purpose is to simulate isolated private VLAN. The behavior can be achieved by limiting network traffic to traffic between VM and gateway. Because there is no concept of the PVLAN in the linux bridge. The filter also

Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache Monitoring Technology (CMT)

On Wed, Jul 18, 2018 at 02:29:32AM +, Wang, Huaqiang wrote: -Original Message- From: Martin Kletzander [mailto:mklet...@redhat.com] Sent: Tuesday, July 17, 2018 5:11 PM To: Wang, Huaqiang Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing ; Ding, Jian-feng ; Zang, Rui Subject:

  1   2   >