Re: [libvirt] [PATCH 04/10] qemu: hotplug: Prepare for multiple backing chain member hotplug

2018-07-18 Thread Ján Tomko
On Tue, Jul 17, 2018 at 02:14:24PM +0200, Peter Krempa wrote: Similarly to how we've intergrated data belonging to a single virStorageSource for purposes of attaching it to a qemu instance we will need to agregate data relevant for the whole disk. With blockdev there will be some disk-wide backin

Re: [libvirt] [PATCH 05/10] qemu: hotplug: Don't leak 'disk' if VM crashes during unplug finishing

2018-07-18 Thread Ján Tomko
On Tue, Jul 17, 2018 at 02:14:25PM +0200, Peter Krempa wrote: qemuDomainRemoveDiskDevice would leak the disk to be removed if the VM crashed since it was removed from the definition but not freed. Broken in commit 105bcdde76b which moved the removal from the definition earlier. Signed-off-by: P

Re: [libvirt] [PATCH v4 09/10] qemu: command: Enable formatting vfio-pci.display option onto cmdline

2018-07-18 Thread Erik Skultety
On Wed, Jul 18, 2018 at 05:15:28PM +0200, Ján Tomko wrote: > On Wed, Jul 18, 2018 at 02:31:45PM +0200, Erik Skultety wrote: > > Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display' > > which can be used to turn on display capabilities on vgpu-enabled > > mediated devices, IOW em

Re: [libvirt] [PATCH v4 08/10] conf: Introduce new attribute 'display'

2018-07-18 Thread Erik Skultety
On Wed, Jul 18, 2018 at 05:06:28PM +0200, Ján Tomko wrote: > On Wed, Jul 18, 2018 at 02:31:44PM +0200, Erik Skultety wrote: > > QEMU 2.12 introduced a new type of display for mediated devices using > > vfio-pci backend which allows a mediated device to be used as a VGA > > compatible device as an a

Re: [libvirt] [PATCH v2 2/3] conf: Introduce new video type 'none'

2018-07-18 Thread Erik Skultety
On Fri, Jul 13, 2018 at 01:56:32PM +0200, Ján Tomko wrote: > On Thu, Jul 12, 2018 at 05:08:47PM +0200, Erik Skultety wrote: > > Historically, we've always enabled an emulated video device every time we > > see that graphics should be supported with a guest. With the appearance > > of mediated devic

Re: [libvirt] [PATCH] conf: Don't parse edev of non-passthrough input device

2018-07-18 Thread John Ferlan
On 07/11/2018 01:57 AM, Han Han wrote: > In input devices, edev attribute is only for passthrough devices. > Don't parse this for other input devices. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591151 > > Signed-off-by: Han Han > --- > src/conf/domain_conf.c | 3 ++- > 1 file

[libvirt] [PATCH] locking: don't create qemu-sanlock.conf file when QEMU isn't enabled

2018-07-18 Thread Daniel P . Berrangé
The test targets result in the qemu-sanlock.conf file being created when sanlock is enabled, even if QEMU is not enabled. As a result it never gets cleaned up when distclean is run, breaking distcheck. Signed-off-by: Daniel P. Berrangé --- src/locking/Makefile.inc.am | 8 ++-- 1 file changed

[libvirt] [PATCH] tests: fix TLS handshake failure with TLS 1.3

2018-07-18 Thread Daniel P . Berrangé
When gnutls negotiates TLS 1.3 instead of 1.2, the order of messages sent by the handshake changes. This exposed a logic bug in the test suite which caused us to wait for the server to see handshake completion, but not wait for the client to see completion. The result was the client didn't receive

Re: [libvirt] [PATCH v3 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

2018-07-18 Thread John Ferlan
On 07/11/2018 05:44 AM, Han Han wrote: > Rename virFileIsCDROM to virFileCheckCDROM and add enum type > virFileCDRomStatus of cdrom statuses. Add argument cd_status in > virFileCheckCDROM filled with cdrom status. > > Now virFileCheckCDROM could be used to check the cdrom drive status such > a

Re: [libvirt] [PATCH v3 2/2] storage: Improve error handling on cdrom backend

2018-07-18 Thread John Ferlan
On 07/11/2018 05:44 AM, Han Han wrote: > Implement virFileCheckCDROM in virStorageBackendVolOpen to check if > cdrom backend is ready. Skip the error of cdrom not ready. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096 > > Signed-off-by: Han Han > --- > src/storage/storage_u

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-18 Thread Yi Min Zhao
在 2018/7/17 下午8:35, Cornelia Huck 写道: On Tue, 10 Jul 2018 16:02:14 +0800 Yi Min Zhao wrote: Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function identifier). The

Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache Monitoring Technology (CMT)

2018-07-18 Thread Wang, Huaqiang
> -Original Message- > From: Martin Kletzander [mailto:mklet...@redhat.com] > Sent: Wednesday, July 18, 2018 10:03 PM > To: Wang, Huaqiang > Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing > ; Ding, Jian-feng ; Zang, Rui > > Subject: Re: [libvirt] [RFC PATCHv2 00/10] x86 RDT Cache

Re: [libvirt] CPU Support

2018-07-18 Thread Brijesh Singh
On 7/18/18 8:49 AM, Eduardo Habkost wrote: > CCing the AMD people who worked on this. > > On Wed, Jul 18, 2018 at 12:18:45PM +0200, Pavel Hrdina wrote: >> On Wed, Jul 18, 2018 at 10:50:34AM +0100, Daniel P. Berrangé wrote: >>> On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: Hi

[libvirt] [PATCH v4] qemu: fix broken autostart symlink after renaming domain.

2018-07-18 Thread Julio Faracco
If a domain is configured to start on boot, it has a symlink to the domain definition inside the autostart directory. If you rename this domain, the definition is renamed too. The symlink need to be pointed to this renamed file. This commit recreates the symlink after renaming the XML file. Resolv

<    1   2