On Thu, Jul 19, 2018 at 04:52 PM +0200, John Ferlan wrote:
> On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
>> Semantically, there is no difference between an uninitialized worker
>> pool and an initialized worker pool with zero workers. Let's allow the
>> worker pool to be initialized for
On Thu, Jul 19, 2018 at 04:53 PM +0200, John Ferlan wrote:
> On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
>> ...since maxWorkers=0 is only intended for virtlockd or virlogd which
>> must not be multithreaded.
>>
>> Signed-off-by: Marc Hartmayer
>> Reviewed-by: Boris Fiuczynski
>> Reviewed-by:
On Thu, Jul 19, 2018 at 07:24:43PM -0400, John Ferlan wrote:
On 07/18/2018 10:44 AM, Ján Tomko wrote:
Yajl has not seen much activity upstream recently.
Switch to using Jansson >= 2.5.
All the platforms we target on https://libvirt.org/platforms.html
have a version >= 2.7 listed on the sites
On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote:
> On Thu, Jul 19, 2018 at 07:38:15PM -0400, John Ferlan wrote:
> >
> >
> > On 07/18/2018 10:44 AM, Ján Tomko wrote:
> > > Unless explicitly requested, enable the QEMU driver
> > > only if the Jansson library is present.
> > >
> > >
On Thu, Jul 19, 2018 at 07:38:15PM -0400, John Ferlan wrote:
On 07/18/2018 10:44 AM, Ján Tomko wrote:
Unless explicitly requested, enable the QEMU driver
only if the Jansson library is present.
Signed-off-by: Ján Tomko
---
m4/virt-driver-qemu.m4 | 6 +-
1 file changed, 5 insertions(+),
On Thu, Jul 19, 2018 at 04:51 PM +0200, John Ferlan wrote:
> On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
>> @srv must be unlocked for the call virNetServerProcessMsg otherwise a
>> deadlock can occur.
>>
>> Since the pointer 'srv->workers' will never be changed after
>> initialization and the
On Fri, July 20, 2018 at 4:52 PM, Erik wrote:
> On Fri, Jul 20, 2018 at 12:00:53PM +0800, Shi Lei wrote:
> > Hi, everyone!
> > For VIR_NETWORK_FORWARD_*, I try to replace 'if' type conditions
> > with typed 'switch()'.
> > It might be more clear.
> >
> > Signed-off-by: Shi Lei
> >
> > ---
>
>
On 19.07.2018 20:30, John Ferlan wrote:
>
>
> On 07/19/2018 04:15 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 17.07.2018 22:28, John Ferlan wrote:
>>>
>>>
>> +} else {
>> +to->code = VIR_ERR_NO_MEMORY;
>> +to->domain = VIR_FROM_NONE;
>> +to->level =
On Thu, Jul 19, 2018 at 02:03:44PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1601377
>
> Fix typo from commit id d45bee449 for the parent_wwpn field
> resulting in parent_wwnn being printed twice.
>
> Signed-off-by: John Ferlan
> ---
Reviewed-by: Erik Skultety
On Fri, Jul 20, 2018 at 12:00:53PM +0800, Shi Lei wrote:
> Hi, everyone!
> For VIR_NETWORK_FORWARD_*, I try to replace 'if' type conditions
> with typed 'switch()'.
> It might be more clear.
>
> Signed-off-by: Shi Lei
>
> ---
...
> +networkRemoveFirewallRules(def);
> +if
Drop conditionals for RHEL-6 and assume systemd is present
Daniel P. Berrangé (2):
rpm: increase min required RHEL to 7
rpm: remove conditionals for systemd
libvirt.spec.in | 246
1 file changed, 20 insertions(+), 226 deletions(-)
--
2.17.1
We no longer build on RHEL-6, so can bump min required RHEL to 7
removing many conditions.
Signed-off-by: Daniel P. Berrangé
---
libvirt.spec.in | 92 ++---
1 file changed, 11 insertions(+), 81 deletions(-)
diff --git a/libvirt.spec.in
All our supported RHEL and Fedora versions include systemd, so we can
assume it is always present in the spec.
Signed-off-by: Daniel P. Berrangé
---
libvirt.spec.in | 160
1 file changed, 12 insertions(+), 148 deletions(-)
diff --git
On Sat, 14 Jul 2018 00:06:15 +0200
c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> We need here libiscsi for the storgae pool backend.
> For the iscsi-direct storage pool, only checkPool and refreshPool should
> be necessary.
> The pool is state-less and just need the informations within
On Wed, Jul 18, 2018 at 05:22:05PM +0200, Peter Krempa wrote:
Use the proper backend for the block device both when using -drive and
when using -blockdev for disk drives and floppy disks.
Shouldn't you use future tense here?
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 24
On Sat, Jul 14, 2018 at 12:06:14AM +0200, c...@lse.epita.fr wrote:
> From: Clementine Hayat
I know that this is more like RFC patch series so before we get to the
actual patch which should be pushed into upstream there should be some
commit message.
> Signed-off-by: Clementine Hayat
> ---
>
Currently, the functions return a pointer to the
destination buffer on success or NULL on failure.
Not only does this kind of error handling look quite
alien in the context of libvirt, where most functions
return zero on success and a negative int on failure,
but it's also somewhat pointless
Changes from [v1]:
* catch a bunch more suboptimal uses of the original API;
* improve the API so that it's both more sensible and fits
better with the rest of libvirt.
[v1] https://www.redhat.com/archives/libvir-list/2018-July/msg01044.html
Andrea Bolognani (8):
src: Use
The strncpy() function has this quirk where it will copy
*up* to the requested number of bytes, that is, it will
stop early if it encounters a NULL byte in the source
string.
This makes it legal to pass the size of the destination
buffer (minus one byte needed for the string terminator)
as the
This convenience macro was created for the simple cases
where the length of the source string and the size of the
destination buffer can be figued out with strlen() and
sizeof() respectively, so we should use it wherever
possible instead of open-coding parts of it.
Signed-off-by: Andrea Bolognani
On Tue, Jul 17, 2018 at 04:03:49PM +0200, Peter Krempa wrote:
Despite the warning that virStorageSourceCopy needs to be populated on
additions to the structure commit 687730540e4 neglected to implement the
copy function.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 27
Hi Gerd,
Can I know your status on the boot display support work? I'm interested to try
it in some real use cases.
Thanks,
Henry
> -Original Message-
> From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 7, 2018 2:26
The last build of the Fedora Rawhide Docker image failed
with
Transaction check error:
file /usr/lib64/libgdbm_compat.so.4.0.0 from install
of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
from package gdbm-1:1.14.1-3.fc28.x86_64
caused by the gdbm package having recently been
On Wed, Jul 18, 2018 at 05:22:06PM +0200, Peter Krempa wrote:
The 'query-blockstats' command does not return statistics for the
explicitly named nodes unless the new argument is specified. Add
Hopefully nobody will need to use profanity in node names.
infrastrucuture that will allow us to
On Wed, Jul 18, 2018 at 05:22:03PM +0200, Peter Krempa wrote:
In some cases backing chain needs to be cleared prior to re-detection.
Move this step out of qemuDomainDetermineDiskChain as only certain
places need it and the function itself is able to skip to the end of the
chain to perform
On Wed, Jul 18, 2018 at 05:22:08PM +0200, Peter Krempa wrote:
Extract the code for future reuse.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 43 +++
1 file changed, 27 insertions(+), 16 deletions(-)
Reviewed-by: Ján Tomko
Jano
On Wed, Jul 18, 2018 at 05:22:09PM +0200, Peter Krempa wrote:
To allow checking whether a storage source points to the same location
add a helper which checks the relevant fields. This will allow replacing
a similar check done by formatting the command line arguments for
qemu-like syntax.
On Wed, Jul 18, 2018 at 05:22:10PM +0200, Peter Krempa wrote:
Now that we have a saner replacement for checking if the disk source is
the same use it instead of formatting qemu command-line chunks.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 34 --
On Wed, Jul 18, 2018 at 05:22:02PM +0200, Peter Krempa wrote:
Allow updating capacity for the block devices returned by
qemuDomainBlocksStatsGather and replace the open-coded call to
qemuMonitorGetAllBlockStatsInfo by the helper.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 41
On Wed, Jul 18, 2018 at 05:22:04PM +0200, Peter Krempa wrote:
The disk backend alias was historically the alias of the -drive backing
the storage. For setups with -blockdev this will become more complex as
it will depend on other configs and generally will differ.
---
src/qemu/qemu_domain.c | 28
On Wed, Jul 18, 2018 at 05:22:07PM +0200, Peter Krempa wrote:
The code is useful also when gathering statistics per node name, so
extract it to a separate functions.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 51 ++--
1 file changed,
On Fri, Jul 20, 2018 at 12:55 PM, Daniel P. Berrangé
wrote:
> Drop conditionals for RHEL-6 and assume systemd is present
>
> Daniel P. Berrangé (2):
> rpm: increase min required RHEL to 7
> rpm: remove conditionals for systemd
While you're on this wouldn't worth to also bump the minimum
The way virStrncpy() is called here will never result in
buffer overflow, but it won't prevent or detect truncation
either, despite what the error message might suggest. Use
virStrcpyStatic(), which does all of the above, instead.
Signed-off-by: Andrea Bolognani
---
src/esx/esx_driver.c |
We finally get rid of the strncpy()-like semantics
and implement our own, more sensible ones instead.
As a bonus, this also fixes compilation on MinGW.
Signed-off-by: Andrea Bolognani
---
docs/hacking.html.in | 29 ++---
src/util/virstring.c | 62
virStrcpy() and friends are useful when the destination
buffer has already been allocated, eg. as part of a struct;
if we have to allocate it on the spot, VIR_STRDUP() is a
better choice.
Signed-off-by: Andrea Bolognani
---
src/remote/remote_daemon_dispatch.c | 4 +---
1 file changed, 1
We're going to change virStrncpy() in a way that
requires the source string to be NULL-terminated, so
we'll no longer be able to use in this context.
Signed-off-by: Andrea Bolognani
---
src/esx/esx_vi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/esx/esx_vi.c
virStrncpy() allows us to copy a substring, but if we're
going to copy the entire thing it's much more convenient
to use virStrcpy() instead.
Signed-off-by: Andrea Bolognani
---
src/util/virnetdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virnetdev.c
On Fri, 2018-07-20 at 11:55 +0100, Daniel P. Berrangé wrote:
> Drop conditionals for RHEL-6 and assume systemd is present
>
> Daniel P. Berrangé (2):
> rpm: increase min required RHEL to 7
> rpm: remove conditionals for systemd
>
> libvirt.spec.in | 246
https://bugzilla.redhat.com/show_bug.cgi?id=1603025
Commit b57a9aec neglected to VIR_FREE(binding->filtername) as seen
in the following valgrind report
==6423== 17,328 bytes in 1,083 blocks are definitely lost in loss record 2,275
of 2,297
==6423==at 0x4C29BC3: malloc
On Fri, Jul 20, 2018 at 11:06:48AM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1603025
>
> Commit b57a9aec neglected to VIR_FREE(binding->filtername) as seen
> in the following valgrind report
>
> ==6423== 17,328 bytes in 1,083 blocks are definitely lost in loss
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 8c88cc8..7c97117 100644
---
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
tests/test_interface.py| 1 +
3 files changed, 28 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
tests/test_interface.py| 1 +
3 files changed, 28 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index
Signed-off-by: Anya Harter
---
tests/test_interface.py | 4
1 file changed, 4 insertions(+)
diff --git a/tests/test_interface.py b/tests/test_interface.py
index 88be5dc..62fd517 100755
--- a/tests/test_interface.py
+++ b/tests/test_interface.py
@@ -7,6 +7,10 @@ class
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 24
2 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index d98a646..f5ec281 100644
---
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
tests/test_interface.py| 8
3 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 791e1f5..604afea 100644
---
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 12
3 files changed, 47 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
original patch series cover letter:
https://www.redhat.com/archives/libvir-list/2018-July/msg00364.html
changes since v1:
* all commits "make" and "make check"
* MACString property => MAC property
* various corrections
* add tests for all but virConnectListAllInterfaces,
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 4
src/interface.c| 21 +
tests/test_interface.py| 5 +
3 files changed, 30 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 604afea..8c88cc8 100644
---
Signed-off-by: Anya Harter
---
tests/Makefile.am | 1 +
tests/libvirttest.py| 12
tests/test_interface.py | 16
3 files changed, 29 insertions(+)
create mode 100755 tests/test_interface.py
diff --git a/tests/Makefile.am b/tests/Makefile.am
index
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 38
2 files changed, 44 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index f690bab..791e1f5 100644
---
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5
src/interface.c| 45 ++
2 files changed, 50 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index 93fa32f..d98a646 100644
---
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 1 +
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 7 +++
src/connect.c| 30 ++
tests/test_connect.py| 4
tests/xmldata.py | 12
4 files changed, 53 insertions(+)
diff --git
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 6 ++
src/interface.c| 28
tests/test_interface.py| 4
3 files changed, 38 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
Signed-off-by: Anya Harter
---
data/Makefile.am | 1 +
data/org.libvirt.Interface.xml | 7
src/Makefile.am| 2 ++
src/connect.c | 6
src/connect.h | 1 +
src/interface.c| 65
Quoting David Hildenbrand (2018-07-18 02:26:24)
> On 18.07.2018 00:39, Collin Walling wrote:
> > On 07/17/2018 05:01 PM, David Hildenbrand wrote:
> >> On 13.07.2018 18:00, Jiri Denemark wrote:
> >>> On Mon, Jul 09, 2018 at 22:56:55 -0500, Chris Venteicher wrote:
> Transient S390
Quoting Jiri Denemark (2018-07-12 06:59:18)
> On Mon, Jul 09, 2018 at 22:56:47 -0500, Chris Venteicher wrote:
> > Renamed variable in CPUModelInfo such that
> > props_migratable_valid is true when properties in CPUModelInfo
> > have been updated to accurately indicate if property is / isn't
> >
60 matches
Mail list logo
