On Tue, 24 Jul 2018 10:20:48 +0200
Andrea Bolognani wrote:
> Looking at both the generated QEMU command line and the qemu-devel
> message linked above, I seem to understand the zpci device is
> basically some sort of adapter that sits between a regular PCI
> device (emulated or otherwise) and an
On Mon, Jul 23, 2018 at 08:19:21PM +0530, Sukrit Bhatnagar wrote:
> On Mon, 23 Jul 2018 at 16:29, Erik Skultety wrote:
> >
> > On Sat, Jul 21, 2018 at 05:36:33PM +0530, Sukrit Bhatnagar wrote:
> > > Modify virCgroupFree function signature to take a value of type
> > > virCgroupPtr instead of
On Mon, Jul 23, 2018 at 11:18:07PM +0530, Sukrit Bhatnagar wrote:
> On Mon, 23 Jul 2018 at 18:39, Erik Skultety wrote:
> >
> > On Sat, Jul 21, 2018 at 05:36:47PM +0530, Sukrit Bhatnagar wrote:
> > > By making use of GNU C's cleanup attribute handled by the
> > > VIR_AUTOFREE macro for declaring
On Mon, 2018-07-23 at 13:37 +0200, Ján Tomko wrote:
> On Tue, Jul 10, 2018 at 04:02:14PM +0800, Yi Min Zhao wrote:
> > Abstract
> >
> > The PCI representation in QEMU has recently been extended for S390
> > allowing configuration of zPCI attributes like uid (user-defined
> > identifier)
On 07/23/2018 03:55 PM, John Ferlan wrote:
>
>
> On 07/23/2018 08:34 AM, Michal Prívozník wrote:
>> On 07/23/2018 02:12 PM, John Ferlan wrote:
>>>
>>>
>>> On 07/23/2018 04:01 AM, Michal Prívozník wrote:
On 07/17/2018 09:14 PM, John Ferlan wrote:
>
>
> On 07/04/2018 05:23 AM,
On Fri, 20 Jul 2018 10:19:24 +0800
Zhenyu Wang wrote:
> Current mdev device create interface depends on fixed mdev type, which get
> uuid
> from user to create instance of mdev device. If user wants to use customized
> number of resource for mdev device, then only can create new mdev type for
On Mon, Jul 23, 2018 at 08:43:01PM +0200, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> We need here libiscsi for the storgae pool backend.
> For the iscsi-direct storage pool, only checkPool and refreshPool should
> be necessary.
> The pool is state-less and just need the informations
On Mon, Jul 23, 2018 at 08:43:00PM +0200, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> Introducing the pool as a noop. Integration inside the build
> system. Implementation will be in the following commits.
>
> Signed-off-by: Clementine Hayat
> ---
> configure.ac
ping.
Tks,
John
On 07/16/2018 05:14 PM, John Ferlan wrote:
> v2: https://www.redhat.com/archives/libvir-list/2018-July/msg00361.html
>
> Differences to v2:
>
> Patch1: NEW - As a result of code review the suggestion was to utilize
> the virDomainDefCompatibleDevice in order to make
On Fri, Jul 20, 2018 at 02:34:54PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 5 +
> src/interface.c| 22 ++
> tests/test_interface.py| 1 +
> 3 files changed, 28 insertions(+)
Reviewed-by:
On Tue, Jul 24, 2018 at 11:24:13 +0200, Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c | 6
From: Bjoern Walk
Testing with the latest capabilities has been x86_64 centric. Let's
remove the hardcoded architecture and give the user the ability to
specify the desired architecture in the macro.
Signed-off-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
tests/qemuxml2argvtest.c | 96
Add support and tests for vhost-vsock-ccw.
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 8 +++--
src/qemu/qemu_domain.c| 10 --
src/qemu/qemu_domain_address.c| 7 +++-
.../vhost-vsock-ccw-auto.s390x-latest.args
Support the vhost-vsock-ccw device on S390.
Since v1
- adjusted vsock command line generation (Ján Tomko)
- added CAPS_LATEST test coverage to s390 (Ján Tomko)
- adjusted new vsock tests to use CAPS_LATEST
Bjoern Walk (1):
tests: qemuxml2argv: make CAPS_LATEST arch generic
Boris Fiuczynski
Signed-off-by: Boris Fiuczynski
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 20c2ff7a6f..4c70499d84 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -67,6 +67,14 @@
only rendering devices within the guest.
On Fri, Jul 20, 2018 at 02:34:53PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 5 +
> src/interface.c| 22 ++
> tests/test_interface.py| 8
> 3 files changed, 35 insertions(+)
On 07/23/2018 03:10 PM, John Ferlan wrote:
>
>
> On 07/23/2018 04:01 AM, Michal Prívozník wrote:
>> On 07/17/2018 09:15 PM, John Ferlan wrote:
>>>
>>>
>>> On 07/04/2018 05:23 AM, Michal Privoznik wrote:
Extend this existing test so that a case when IQN is provided is
tested too. Since
On Fri, Jul 20, 2018 at 02:34:59PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 5 +
> src/connect.c| 22 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description:
On 07/24/2018 10:20 AM, Andrea Bolognani wrote:
On Mon, 2018-07-23 at 13:37 +0200, Ján Tomko wrote:
On Tue, Jul 10, 2018 at 04:02:14PM +0800, Yi Min Zhao wrote:
Abstract
The PCI representation in QEMU has recently been extended for S390
allowing configuration of zPCI attributes like
On Fri, Jul 20, 2018 at 02:34:49PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> tests/Makefile.am | 1 +
> tests/libvirttest.py| 12
> tests/test_interface.py | 16
> 3 files changed, 29 insertions(+)
> create mode 100755
On Fri, Jul 20, 2018 at 02:34:55PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 5 +
> src/interface.c| 22 ++
> tests/test_interface.py| 1 +
> 3 files changed, 28 insertions(+)
Reviewed-by:
On Fri, Jul 20, 2018 at 02:34:58PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 5 +
> src/connect.c| 22 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description:
On Fri, Jul 20, 2018 at 02:34:57PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 5 +
> src/connect.c| 22 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Katerina Koukiou
signature.asc
Description:
Acked-by: Christian Borntraeger
On 07/24/2018 11:24 AM, Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c
This option has been deprecated for two releases; remove it.
Signed-off-by: Cornelia Huck
---
hw/s390x/3270-ccw.c| 2 +-
hw/s390x/css-bridge.c | 1 -
hw/s390x/css.c | 6 ++
hw/s390x/s390-ccw.c| 2 +-
On Fri, Jul 20, 2018 at 02:34:51PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 4
> src/interface.c| 21 +
> tests/test_interface.py| 5 +
> 3 files changed, 30 insertions(+)
>
> diff
On Tue, Jul 24, 2018 at 11:30:10AM +0200, Katerina Koukiou wrote:
> On Fri, Jul 20, 2018 at 02:34:49PM -0400, Anya Harter wrote:
> > Signed-off-by: Anya Harter
> > ---
> > tests/Makefile.am | 1 +
> > tests/libvirttest.py| 12
> > tests/test_interface.py | 16
On Fri, Jul 20, 2018 at 02:34:56PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 38
> 2 files changed, 44 insertions(+)
Reviewed-by: Katerina Koukiou
On 23.07.2018 22:16, Collin Walling wrote:
> On 07/21/2018 12:05 AM, Chris Venteicher wrote:
>> Quoting David Hildenbrand (2018-07-18 02:26:24)
>>> On 18.07.2018 00:39, Collin Walling wrote:
On 07/17/2018 05:01 PM, David Hildenbrand wrote:
> On 13.07.2018 18:00, Jiri Denemark wrote:
SKIP_OSTYPE_CHECKS only hides some error reporting at this point,
so it can be foled into SKIP_VALIDATE
Signed-off-by: Cole Robinson
---
src/conf/domain_conf.c | 3 +--
src/conf/domain_conf.h | 13 +
src/conf/snapshot_conf.c| 2 --
src/conf/virdomainobjlist.c | 2 --
Handles parse virtType, os.type, bootloader bits, arch, machine,
emulator
Signed-off-by: Cole Robinson
---
src/conf/domain_conf.c | 96 +-
1 file changed, 58 insertions(+), 38 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
The SKIP_OSTYPE domain parse flag is largely redundant nowadays
since we have SKIP_VALIDATE. This series smoothes out some of
the SKIP_OSTYPE weirdness so we can drop it
Cole Robinson (7):
conf: Break out virDomainDefParseCaps
conf: Clean up virDomainDefParseCaps
tests: qemuhotplug: Fix
We should still make an effort to fill in data, just not raise
an error if say an ostype/virttype combo disappeared from caps.
Signed-off-by: Cole Robinson
---
src/conf/domain_conf.c | 13 ++---
tests/qemuxml2argvdata/missing-machine.xml | 2 +-
The comment says:
/* If the logic here seems fairly arbitrary, that's because it is :)
* This is duplicating how the code worked before
* CapabilitiesDomainDataLookup was added. We can simplify this,
* but it would take a bit of work because the test suite fails
* in
This test was added in 2d40e2da7ba to ensure LXC domains could be
defined correctly when caps probing was skipped due to SKIP_OSTYPE.
However we do caps probing unconditionally now, so this test case
is redundant
Signed-off-by: Cole Robinson
---
tests/lxcxml2xmltest.c | 2 --
1 file changed, 2
- Convert to 'cleanup' label naming
- Use more than one 'tmp' string and do all freeing at the end
- Make the code easier to follow
Signed-off-by: Cole Robinson
---
src/conf/domain_conf.c | 76 --
1 file changed, 37 insertions(+), 39 deletions(-)
diff
On 07/18/2018 03:57 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Some functions in virresctrl are for CAT only, while some of other
> functions are for resource allocation, not just CAT. So change
> their names to reflect the reality.
>
> Signed-off-by: Bing Niu
> ---
>
On 07/18/2018 03:57 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Separate resctrl common information parts from CAT specific parts,
> so that common information parts can be reused among different
> resource allocation technologies.
>
> Signed-off-by: Bing Niu
> ---
>
On 07/18/2018 03:57 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Introducing virResctrlInfoMemBW for the information memory bandwidth
> allocation information. Those information is used for memory
> bandwidth allocating.
Last sentence is duplicitous.
>
> Signed-off-by: Bing Niu
>
Some tests use the same VM state multiple times in a row. But if we
failed loading the VM XML, subsequent tests crash on the NULL def
pointer
Signed-off-by: Cole Robinson
---
I hit this with failing tests while writing this series
tests/qemuhotplugtest.c | 2 ++
1 file changed, 2 insertions(+)
On 07/18/2018 03:57 AM, bing@intel.com wrote:
> From: Bing Niu
>
> Refactor virResctrlAllocFormat so that it is easy to support other
> resource allocation technologies.
>
> Signed-off-by: Bing Niu
> ---
> src/util/virresctrl.c | 43 ---
> 1 file
On 07/09/2018 08:51 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1589115
>
> When doing a memory snapshot qemuOpenFile() is used. This means
> that the file where memory is saved is firstly attempted to be
> created under root:root (because that's what libvirtd is
On 07/24/2018 12:03 PM, Jiri Denemark wrote:
> On Mon, Jul 23, 2018 at 17:45:32 -0400, Collin Walling wrote:
>> When calling the query-cpu-model-expansion command via libvirt, we pass in
>> model
>> name "max" when using TCG. However, this model name is not supported for
>> s390 on
>> TCG.
On 07/24/2018 12:59 PM, Daniel P. Berrangé wrote:
> On Tue, Jul 24, 2018 at 06:53:54PM +0200, Cornelia Huck wrote:
>> On Tue, 24 Jul 2018 18:08:21 +0200
>> Jiri Denemark wrote:
>>
>>> On Mon, Jul 23, 2018 at 17:45:33 -0400, Collin Walling wrote:
Use model name "qemu" instead of "max" when
On 2018年07月25日 06:03, John Ferlan wrote:
On 07/18/2018 03:57 AM, bing@intel.com wrote:
From: Bing Niu
Refactor virResctrlAllocFormat so that it is easy to support other
resource allocation technologies.
Signed-off-by: Bing Niu
---
src/util/virresctrl.c | 43
On 2018年07月25日 06:02, John Ferlan wrote:
On 07/18/2018 03:57 AM, bing@intel.com wrote:
From: Bing Niu
Separate resctrl common information parts from CAT specific parts,
so that common information parts can be reused among different
resource allocation technologies.
Signed-off-by:
On 2018年07月25日 06:08, John Ferlan wrote:
On 07/18/2018 03:57 AM, bing@intel.com wrote:
From: Bing Niu
Introducing virResctrlInfoMemBW for the information memory bandwidth
allocation information. Those information is used for memory
bandwidth allocating.
Last sentence is duplicitous.
On 07/24/2018 06:19 PM, Clementine Hayat wrote:
> 2018-07-24 14:24 GMT+02:00 Michal Privoznik :
>> On 07/23/2018 08:43 PM, c...@lse.epita.fr wrote:
>>> From: Clementine Hayat
>>>
>>> Introducing the pool as a noop. Integration inside the build
>>> system. Implementation will be in the following
On 07/24/2018 04:53 PM, John Ferlan wrote:
>
> Let's just go back to the start on this one as light has dawned on
> marblehead and it's now clear what the technicality I was missing on the
> reinterpretation of the API docs.
>
> On 07/04/2018 05:23 AM, Michal Privoznik wrote:
>> The
On 07/16/2018 04:39 AM, Daniel P. Berrangé wrote:
Note, that libvir-list requires senders to be subscribed before mails are
delivered, otherwise they go into moderation queue. My normal approach. as
the person moderating, is to whitelist all human senders who get moderated,
so it is only a
It wasn't updated when libvirt was moved from daemon/ to src/
Signed-off-by: Cole Robinson
---
run.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/run.in b/run.in
index cbef61a674..06ad54b62b 100644
--- a/run.in
+++ b/run.in
@@ -63,7 +63,7 @@ export PKG_CONFIG_PATH
On Mon, Jul 23, 2018 at 17:45:32 -0400, Collin Walling wrote:
> When calling the query-cpu-model-expansion command via libvirt, we pass in
> model
> name "max" when using TCG. However, this model name is not supported for s390
> on
> TCG. Let's use the model name "qemu" as an alternative.
>
>
On Tue, Jul 24, 2018 at 12:01:35 -0400, Cole Robinson wrote:
> It wasn't updated when libvirt was moved from daemon/ to src/
>
> Signed-off-by: Cole Robinson
> ---
> run.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/run.in b/run.in
> index cbef61a674..06ad54b62b
On Mon, Jul 23, 2018 at 17:45:33 -0400, Collin Walling wrote:
> Use model name "qemu" instead of "max" when calling
> query-cpu-model-expansion for s390 on tcg.
>
> Signed-off-by: Collin Walling
> ---
> src/qemu/qemu_capabilities.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
2018-07-24 14:24 GMT+02:00 Michal Privoznik :
> On 07/23/2018 08:43 PM, c...@lse.epita.fr wrote:
>> From: Clementine Hayat
>>
>> Introducing the pool as a noop. Integration inside the build
>> system. Implementation will be in the following commits.
>>
>> Signed-off-by: Clementine Hayat
>> ---
Signed-off-by: Anya Harter
---
src/domain.c | 2 +-
src/interface.c | 2 +-
src/network.c | 2 +-
src/nodedev.c | 2 +-
src/nwfilter.c| 2 +-
src/secret.c | 2 +-
src/storagepool.c | 2 +-
src/storagevol.c | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff
On 07/09/2018 02:51 PM, Michal Privoznik wrote:
>
Polite ping.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Jul 20, 2018 at 02:34:50PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> tests/test_interface.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/test_interface.py b/tests/test_interface.py
> index 88be5dc..62fd517 100755
> ---
On Fri, Jul 20, 2018 at 02:34:52PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Interface.xml | 6 ++
> src/interface.c| 28
> tests/test_interface.py| 4
> 3 files changed, 38 insertions(+)
On Fri, Jul 20, 2018 at 02:35:00PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 29 +
> tests/test_connect.py| 12
> 3 files changed, 47 insertions(+)
On Fri, Jul 20, 2018 at 02:35:01PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> data/org.libvirt.Connect.xml | 6 ++
> src/connect.c| 29 +
> tests/test_connect.py| 1 +
> 3 files changed, 36 insertions(+)
Reviewed-by:
On Tue, 24 Jul 2018 13:15:50 +0200
Peter Krempa wrote:
> On Tue, Jul 24, 2018 at 11:24:13 +0200, Cornelia Huck wrote:
> > This option has been deprecated for two releases; remove it.
> >
> > Signed-off-by: Cornelia Huck
> > ---
> > hw/s390x/3270-ccw.c| 2 +-
> >
On Tue, 2018-07-24 at 11:31 +0200, Boris Fiuczynski wrote:
> On 07/24/2018 10:20 AM, Andrea Bolognani wrote:
> > Assuming the above is a correct reading of the situation, it
> > would seem the IDs are the only guest-visible part that we need
> > to make sure doesn't change during the lifetime of
On 24.07.2018 11:24, Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c | 6 ++
>
On Tue, Jul 24, 2018 at 13:31:04 +0200, Boris Fiuczynski wrote:
> From: Bjoern Walk
>
> Testing with the latest capabilities has been x86_64 centric. Let's
> remove the hardcoded architecture and give the user the ability to
> specify the desired architecture in the macro.
>
> Signed-off-by:
On 07/23/2018 08:43 PM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> Introducing the pool as a noop. Integration inside the build
> system. Implementation will be in the following commits.
>
> Signed-off-by: Clementine Hayat
> ---
> configure.ac | 6 ++-
On 07/23/2018 08:43 PM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> We need here libiscsi for the storgae pool backend.
> For the iscsi-direct storage pool, only checkPool and refreshPool should
> be necessary.
Well, they are necessary only for basic support. There is still couple
of
On 07/23/2018 08:42 PM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> The minimal required version is 1.18.0 because the synchrounous function
> needed were introduced here.
>
> Signed-off-by: Clementine Hayat
> ---
> configure.ac| 3 +++
> m4/virt-libiscsi.m4 | 30
On 07/23/2018 08:42 PM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> Hello,
>
> This is the implementation of the iscsi-direct backend storage pool
> version 2.
> The documentation, some API calls and tests are still missing and will
> be comming in a second part.
>
> Best Regards,
>
On 07/24/2018 01:59 PM, Peter Krempa wrote:
On Tue, Jul 24, 2018 at 13:31:04 +0200, Boris Fiuczynski wrote:
From: Bjoern Walk
Testing with the latest capabilities has been x86_64 centric. Let's
remove the hardcoded architecture and give the user the ability to
specify the desired architecture
On 07/24/2018 03:41 PM, Andrea Bolognani wrote:
On Tue, 2018-07-24 at 11:31 +0200, Boris Fiuczynski wrote:
On 07/24/2018 10:20 AM, Andrea Bolognani wrote:
Assuming the above is a correct reading of the situation, it
would seem the IDs are the only guest-visible part that we need
to make sure
On Tue, 2018-07-24 at 17:15 +0200, Boris Fiuczynski wrote:
> On 07/24/2018 03:41 PM, Andrea Bolognani wrote:
> > Being compatible with the existing PCI machinery is certainly a
> > good idea when it makes sense to do so, but I'm not quite convinced
> > that is the case here.
>
> From a user
On Tue, Jul 24, 2018 at 15:18:10 +0100, Daniel P. Berrangé wrote:
> Consider creating a listener socket from a hostname that resolves to
> multiple addresses. It might be the case that the hostname resolves to
> both an IPv4 and IPv6 address because it is reachable over both
> protocols, but the
On Tue, Jul 24, 2018 at 15:18:09 +0100, Daniel P. Berrangé wrote:
> When reporting socket/bind failures we want to ensure any fatal error
> reported is as accurate as possible. We'll prefer reporting a bind()
> errno over a socket() errno, because if socket() works but bind() fails
> that is a
On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
> This patch provides a caching mechanism for the device address
> extensions uid and fid on S390. For efficient sparse address allocation,
> we introduce two hash tables for uid/fid which hold the address set
> information per domain. Also in
On 07/24/2018 04:25 AM, Michal Privoznik wrote:
> On 07/23/2018 03:55 PM, John Ferlan wrote:
>>
>>
>> On 07/23/2018 08:34 AM, Michal Prívozník wrote:
>>> On 07/23/2018 02:12 PM, John Ferlan wrote:
On 07/23/2018 04:01 AM, Michal Prívozník wrote:
> On 07/17/2018 09:14 PM, John
Daniel P. Berrangé (2):
socket: preserve real errno when socket/bind calls fail
rpc: treat EADDRNOTAVAIL as non-fatal when listening
src/rpc/virnetsocket.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
--
2.17.1
--
libvir-list mailing list
On 07/24/2018 05:48 AM, Michal Privoznik wrote:
> On 07/23/2018 03:10 PM, John Ferlan wrote:
>>
>>
>> On 07/23/2018 04:01 AM, Michal Prívozník wrote:
>>> On 07/17/2018 09:15 PM, John Ferlan wrote:
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Extend this existing test so
When reporting socket/bind failures we want to ensure any fatal error
reported is as accurate as possible. We'll prefer reporting a bind()
errno over a socket() errno, because if socket() works but bind() fails
that is a more significant event.
Signed-off-by: Daniel P. Berrangé
---
Consider creating a listener socket from a hostname that resolves to
multiple addresses. It might be the case that the hostname resolves to
both an IPv4 and IPv6 address because it is reachable over both
protocols, but the IPv6 connectivity is provided off-host. In such a
case no local NIC will
Commit 77298458d027db4d3e082213355e2d792f65158d changed the esx storage
adapter from busLogic to lsilogic, introducing a typo. Changing it back
to lsiLogic (with capital L) solves the issue. With this change, libvirt can now
create volumes in ESX again.
Thanks to Jaroslav Suchanek who figured out
On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
[...]
> +static bool
> +qemuDomainDeviceSupportZPCI(virDomainDeviceDefPtr device)
> +{
> +switch ((virDomainDeviceType) device->type) {
> +case VIR_DOMAIN_DEVICE_CHR:
> +return false;
> +
> +case
On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
> +
> +
> +
> +(0x)?[0-9a-fA-F]{1,8}
> +
> +
This should probably be unignedInt instead of int, but other uint*
types defined in the file also use int so if anything changing all
of them would be the job for a
Even though the changes are self-explanatory, the commit message could
use some text, e.g.:
The function returns TRUE/FALSE, not 0/-1.
On Tue, Jul 24, 2018 at 09:31:28AM -0400, Anya Harter wrote:
Signed-off-by: Anya Harter
---
src/domain.c | 2 +-
src/interface.c | 2 +-
src/network.c
On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
> struct _virPCIDeviceAddress {
> unsigned int domain;
> unsigned int bus;
> unsigned int slot;
> unsigned int function;
> int multi; /* virTristateSwitch */
> +virZPCIDeviceAddressPtr zpci;
This should probably
On 07/24/2018 04:08 PM, John Ferlan wrote:
>
> > Reading something like:
>
> /* mocking real environment output is not feasible for [creating |
> updating | logging into], example of real environment is:
>
> xxx
>
> */
>
> I believe is better - it's not difficult to add, but I'm at the
Let's just go back to the start on this one as light has dawned on
marblehead and it's now clear what the technicality I was missing on the
reinterpretation of the API docs.
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> The documentation to virCommandWait() function states that if
>
On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
> This patch adds new functions for reservation, assignment and release
> to handle the uid/fid. If the uid/fid is defined in the domain XML,
> they will be reserved directly in collecting phase. If any of them is
> not defined, we will find
On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
[...]
> +bool
> +qemuCheckDeviceIsZPCI(virDomainDeviceInfoPtr info)
> +{
> +if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
> +((info->pciAddressExtFlags & VIR_PCI_ADDRESS_EXTENSION_ZPCI) ||
> + info->addr.pci.zpci))
On Tue, 24 Jul 2018 at 11:33, Erik Skultety wrote:
>
> On Mon, Jul 23, 2018 at 08:19:21PM +0530, Sukrit Bhatnagar wrote:
> > On Mon, 23 Jul 2018 at 16:29, Erik Skultety wrote:
> > >
> > > On Sat, Jul 21, 2018 at 05:36:33PM +0530, Sukrit Bhatnagar wrote:
> > > > Modify virCgroupFree function
On Tue, 24 Jul 2018 18:08:21 +0200
Jiri Denemark wrote:
> On Mon, Jul 23, 2018 at 17:45:33 -0400, Collin Walling wrote:
> > Use model name "qemu" instead of "max" when calling
> > query-cpu-model-expansion for s390 on tcg.
> >
> > Signed-off-by: Collin Walling
> > ---
> >
On Tue, Jul 24, 2018 at 06:53:54PM +0200, Cornelia Huck wrote:
> On Tue, 24 Jul 2018 18:08:21 +0200
> Jiri Denemark wrote:
>
> > On Mon, Jul 23, 2018 at 17:45:33 -0400, Collin Walling wrote:
> > > Use model name "qemu" instead of "max" when calling
> > > query-cpu-model-expansion for s390 on
On Tue, 24 Jul 2018 at 11:54, Erik Skultety wrote:
>
> On Mon, Jul 23, 2018 at 11:18:07PM +0530, Sukrit Bhatnagar wrote:
> > On Mon, 23 Jul 2018 at 18:39, Erik Skultety wrote:
> > >
> > > On Sat, Jul 21, 2018 at 05:36:47PM +0530, Sukrit Bhatnagar wrote:
> > > > By making use of GNU C's cleanup
On Tue, Jul 24, 2018 at 10:46:54PM +0530, Sukrit Bhatnagar wrote:
> On Tue, 24 Jul 2018 at 11:54, Erik Skultety wrote:
> >
> > On Mon, Jul 23, 2018 at 11:18:07PM +0530, Sukrit Bhatnagar wrote:
> > > On Mon, 23 Jul 2018 at 18:39, Erik Skultety wrote:
> > > >
> > > > On Sat, Jul 21, 2018 at
94 matches
Mail list logo
