On Tue, Jul 31, 2018 at 02:04:40PM +0200, Martin Kletzander wrote:
> On Tue, Jul 31, 2018 at 10:26:41AM +0200, Michal Privoznik wrote:
> > On 07/30/2018 05:20 PM, Andrea Bolognani wrote:
> > > On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
> > > >
> >
> > >
> > > Unfortunately I've
On 07/31/2018 04:28 AM, Ján Tomko wrote:
> On Mon, Jul 30, 2018 at 02:46:37PM -0400, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1107420
>>
>> As unusual as the case may be, having a name of all white space
>> has been allowed. This leads to the obvious problem of how a
From: Clementine Hayat
We need here libiscsi for the storgae pool backend.
For the iscsi-direct storage pool, only checkPool and refreshPool should
be necessary for basic support.
The pool is state-less and just need the informations within the volume
to work.
Signed-off-by: Clementine Hayat
From: Clementine Hayat
Introducing the pool as a noop. Integration inside the build
system. Implementation will be in the following commits.
Signed-off-by: Clementine Hayat
---
configure.ac | 6 +-
docs/schemas/storagepool.rng | 35
From: Clementine Hayat
The minimal required version is 1.18.0 because the synchrounous function
needed were introduced here.
Signed-off-by: Clementine Hayat
---
configure.ac| 3 +++
m4/virt-libiscsi.m4 | 30 ++
2 files changed, 33 insertions(+)
create
From: Clementine Hayat
Signed-off-by: Clementine Hayat
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index a68ef2dc1c..73e79dff0f 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,15 @@
+
+
+
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit bf114decb34f21cd225ead6dc4d929d35a8c5fe5.
Signed-off-by: Ján Tomko
---
src/util/virjson.c | 529 -
1 file changed,
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit 9cf38263d05ca7f27dbbd9b1a0b48d338d9280e2.
Signed-off-by: Ján Tomko
---
libvirt.spec.in | 4 +-
m4/virt-nss.m4 | 4
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit c5ae8e0c2b4b6bb3c667cfadaf65a66c3f4f3d85.
Signed-off-by: Ján Tomko
---
m4/virt-driver-qemu.m4 | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit 4dd60540007042bfc0087a67f57f3e9f3311a84a.
Signed-off-by: Ján Tomko
---
m4/virt-jansson.m4 | 3 ---
tests/qemublocktest.c| 5 -
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit 12b34f094e2f1c7f414f4bb8f880a9d65c8fcd85.
Signed-off-by: Ján Tomko
---
configure.ac | 3 ---
m4/virt-jansson.m4 | 29 -
2 files
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit 1caf8441604b58e4a89aa2c09975b8346928c52a.
Signed-off-by: Ján Tomko
---
config-post.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config-post.h b/config-post.h
As reported by Andrea Bolognani (Thanks, Andrea!), since the switch
to jansson applications using libvirt_nss crash due to a function
name collision with json-glib:
https://www.redhat.com/archives/libvir-list/2018-July/msg02044.html
Revert the changes until we come up with a better solution.
Ján
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit 93fdc9e0b0cbb2eec32745a868ac4633f0912ad5.
Signed-off-by: Ján Tomko
---
config-post.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/config-post.h b/config-post.h
The jansson and json-glib libraries both export symbols with a json_
name prefix and json_object_iter_next() clashes between them.
Unfortunately json_glib is linked in by GTK, so any app using GTK and
libvirt will get a clash, resulting in SEGV. This also affects the NSS
module provided by
When trying to update an interface's rom settings with an device XML
that is missing the PCI addr element, all new rom settings where not applied.
https://bugzilla.redhat.com/show_bug.cgi?id=1599513
Signed-off-by: Katerina Koukiou
---
Not sure why we chose to overwrite the whole info before
On Tue, Jul 31, 2018 at 10:26:41AM +0200, Michal Privoznik wrote:
On 07/30/2018 05:20 PM, Andrea Bolognani wrote:
On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
Unfortunately I've spotted an issue during my testing of rc1 today:
with the libvirt_guest NSS module enabled,
Daniel Veillard [2018-07-31, 12:19PM +0800]:
>It is out, tagged in git and with signed tarball and rpms at the
> usual place:
>
>ftp://libvirt.org/libvirt/
>
> in my limited testing it works but we have that pending issue
> raised by Andrea. worse case someone reverse the patches and
>
On 07/31/2018 03:54 PM, Bjoern Walk wrote:
> Bjoern Walk [2018-07-31, 03:16PM +0200]:
>> I have not yet had the time to figure out what goes wrong, any ideas are
>> welcome.
>
> Ah, classic. The mocked virRandomBytes function is not endian-agnostic,
> generating a different interface name as
Bjoern Walk [2018-07-31, 03:16PM +0200]:
> I have not yet had the time to figure out what goes wrong, any ideas are
> welcome.
Ah, classic. The mocked virRandomBytes function is not endian-agnostic,
generating a different interface name as expected by the test.
Bjoern
--
IBM Systems
Linux on
Michal Privoznik [2018-07-31, 04:10PM +0200]:
> On 07/31/2018 03:54 PM, Bjoern Walk wrote:
> > Bjoern Walk [2018-07-31, 03:16PM +0200]:
> >> I have not yet had the time to figure out what goes wrong, any ideas are
> >> welcome.
> >
> > Ah, classic. The mocked virRandomBytes function is not
Switch back to yajl until we figure out a solution for
the json_object_iter_next conflict with json-glib.
This reverts commit c31146685f5c8558ff88d52d03a68533c9220feb.
Signed-off-by: Ján Tomko
---
tests/qemuagenttest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Tue, Jul 31, 2018 at 10:26:41AM +0200, Michal Privoznik wrote:
On 07/30/2018 05:20 PM, Andrea Bolognani wrote:
On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
Unfortunately I've spotted an issue during my testing of rc1 today:
with the libvirt_guest NSS module enabled,
On Tue, Jul 31, 2018 at 12:18:16PM +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 10:26:41AM +0200, Michal Privoznik wrote:
> > On 07/30/2018 05:20 PM, Andrea Bolognani wrote:
> > > On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
> > > >
> >
> > >
> > > Unfortunately I've spotted
On Wed, Jul 25, 2018 at 05:57:59PM +0200, Peter Krempa wrote:
Initialize data for the whole backing chain when plugging in or removing
disks when a machine supports -blockdev.
Similarly to startup we need to prepare the structures for the whole
backing chain and take care of the copy-on-read
On 07/31/2018 12:25 PM, Daniel P. Berrangé wrote:
> On Tue, Jul 31, 2018 at 12:18:16PM +0200, Ján Tomko wrote:
>> On Tue, Jul 31, 2018 at 10:26:41AM +0200, Michal Privoznik wrote:
>>> On 07/30/2018 05:20 PM, Andrea Bolognani wrote:
On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
On Tue, Jul 31, 2018 at 06:07:20PM +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 03:55:28PM +0100, Daniel P. Berrangé wrote:
> > The jansson and json-glib libraries both export symbols with a json_
> > name prefix and json_object_iter_next() clashes between them.
> >
> > Unfortunately
It's on RHEL7, saves a bit of typing, and lets us drop the comment
Signed-off-by: Cole Robinson
---
There's also a %make_build macro which handles smp_mflags, but it uses
make -O which makes build output noisier at least
libvirt.spec.in | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
On Tue, Jul 31, 2018 at 05:57:21PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-07-31 at 15:55 +0100, Daniel P. Berrangé wrote:
> [...]
> > +# We dlopen() it so need an explicit dep
> > +Requires: libjansson.so.4()(64bit)
>
> Wouldn't requiring jansson be better here? I don't think many
> people
On Tue, Jul 31, 2018 at 12:19:28PM +0800, Daniel Veillard wrote:
It is out, tagged in git and with signed tarball and rpms at the
usual place:
ftp://libvirt.org/libvirt/
in my limited testing it works but we have that pending issue
raised by Andrea. worse case someone reverse the patches
On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote:
> On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote:
> > When trying to update an interface's rom settings with an device XML
> > that is missing the PCI addr element, all new rom settings where not
> > applied.
> >
> >
On Tue, Jul 31, 2018 at 11:28:02AM -0500, Eric Blake wrote:
> On 07/31/2018 09:55 AM, Daniel P. Berrangé wrote:
> > The jansson and json-glib libraries both export symbols with a json_
> > name prefix and json_object_iter_next() clashes between them.
> >
> > Unfortunately json_glib is linked in
On Tue, 2018-07-31 at 17:27 +0100, Daniel P. Berrangé wrote:
[...]
> libvirt_nss_la_LIBADD = \
> - $(JANSSON_LIBS) \
> $(NULL)
You can drop libvirt_nss_la_LIBADD altogether now.
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
Bjoern Walk [2018-07-31, 02:21PM +0200]:
> Daniel Veillard [2018-07-31, 12:19PM +0800]:
> >It is out, tagged in git and with signed tarball and rpms at the
> > usual place:
> >
> >ftp://libvirt.org/libvirt/
> >
> > in my limited testing it works but we have that pending issue
> >
On Tue, Jul 31, 2018 at 05:32:51PM +0200, Katerina Koukiou wrote:
On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote:
On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote:
> When trying to update an interface's rom settings with an device XML
> that is missing the PCI addr
esxVI_AutoStartPowerInfo_Free, which is called from
esxVI_HostAutoStartManagerConfig_Free, will always call VIR_FREE to free
memory from {start,stop}Action, leading to a invalid pointer.
With this patch applied, ESX can set autostart successfully to all it's
domains.
Signed-off-by: Marcos Paulo
SetAutoStart method cannot free virtualMachine using
esxVI_ObjectContent_Free, since:
esxVI_HostAutoStartManagerConfig_Free
-> esxVI_AutoStartPowerInfo_Free
-> esxVI_ManagedObjectReference_Free(item->key);
item->key, in this context, is virtualMachine->obj, so calling
Hi guys,
while doing some random tests using the ESX driver, I faced a crash, and these
two patches are trying to solve. I don't know if there is a better way to solve
it, since ESX driver *generated* code to alloc and free some *generated*
structs, but, please let me know if you have a better
From: Clementine Hayat
Hello,
This is the implementation of the iscsi-direct backend storage pool
version 3.
v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00918.html
v2: https://www.redhat.com/archives/libvir-list/2018-July/msg01528.html
Best Regards,
--
Clementine Hayat
On 07/30/2018 05:20 PM, Andrea Bolognani wrote:
> On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
>>
>
> Unfortunately I've spotted an issue during my testing of rc1 today:
> with the libvirt_guest NSS module enabled, Evolution would crash a
> few seconds after being started. Here's
From: Clementine Hayat
Signed-off-by: Clementine Hayat
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index a68ef2dc1c..73e79dff0f 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,15 @@
+
+
+
On Mon, Jul 30, 2018 at 02:46:37PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
As unusual as the case may be, having a name of all white space
has been allowed. This leads to the obvious problem of how a future
usage would be able to "utilize" that resource
在 2018/7/30 下午11:12, Peter Krempa 写道:
Jansson does not put a newline at the end of formatted JSON strings.
This breaks the qemucapsprobe utility as we need to keep the spacing so
that tests work. Add an explicit newline.
Signed-off-by: Peter Krempa
---
tests/qemucapsprobemock.c | 2 ++
1
On Tue, Jul 31, 2018 at 17:42:50 +0800, Yi Min Zhao wrote:
>
>
> 在 2018/7/30 下午11:12, Peter Krempa 写道:
> > Jansson does not put a newline at the end of formatted JSON strings.
> > This breaks the qemucapsprobe utility as we need to keep the spacing so
> > that tests work. Add an explicit
44 matches
Mail list logo