On 07/30/2018 11:54 PM, bing.niu wrote:
>
>
> On 2018年07月31日 06:14, John Ferlan wrote:
>>
>>
>> On 07/29/2018 11:12 PM, bing@intel.com wrote:
>>> From: Bing Niu
>>>
>>> This series is to introduce RDT memory bandwidth allocation support
>>> by extending
>>> current virresctrl
2018-08-10 5:56 GMT+02:00 Marcos Paulo de Souza :
> Before this change, esxDomainGetMaxVcpus returned -1, which in turn
> fails in libvirt. This commit reimplements esxDomainGetMaxVcpus instead
> of calling esxDomainGetVcpusFlags. The implementation checks for
> capability.maxSupportedVcpus, but
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: 20180805155428.40866-1-bogorods...@gmail.com
Subject: [libvirt] [PATCH] bhyve: fix process reconnect
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script
On 08/10/2018 12:18 PM, Marcos Paulo de Souza wrote:
> On Mon, Aug 13, 2018 at 03:51:51PM +0200, Michal Prívozník wrote:
>> On 08/11/2018 04:39 PM, Marcos Paulo de Souza wrote:
>>> When building libvirt with libcurl debug enabled (with
>>> ESX_VI__CURL__ENABLE_DEBUG_OUTPUT set), the message bellow
On Mon, 2018-08-13 at 16:39 +0200, Christian Ehrhardt wrote:
> Libvirt now tries to preserve all mounts under /dev in qemu
> namespaces.
> The old rules only listed a set of known paths but those are no more
> enough.
>
> I found some due to containers like /dev/.lxc/* and such but also
>
On 08/13/2018 07:42 AM, Erik Skultety wrote:
> On Thu, Aug 09, 2018 at 09:42:10AM +0530, Sukrit Bhatnagar wrote:
>> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
>> src/util/viralloc.h, define a new wrapper around an existing
>> cleanup function which will be called when a variable
On Thu, Aug 09, 2018 at 09:42:08AM +0530, Sukrit Bhatnagar wrote:
> This third series of patches also modifies a few files in src/util
> to use VIR_AUTOFREE and VIR_AUTOPTR for automatic freeing of memory
> and get rid of some VIR_FREE macro invocations and *Free function
> calls.
>
> This is
2018-08-10 5:56 GMT+02:00 Marcos Paulo de Souza :
> Before this patch, esxDomainGetVcpusFlags was returning -1 since
> "maxSupportedVcpus" can be NULL in ESXi[1]. In order to make it work,
> replicate the same behavior than esxDomainGetInfo that used
> config.hardware.numCPU to return the correct
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: 20180810112233.44540-1-i...@conquex.com
Subject: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable
=== TEST SCRIPT BEGIN ===
#!/bin/bash
#
On Mon, 2018-08-13 at 16:39 +0200, Christian Ehrhardt wrote:
> Several cases were found needing /tmp, for example ceph will try to
> list /tmp
> and the samba feature of qemu will place things in /tmp/qemu-smb.*.
> This is sort of safe because:
> - While /tmp could contain anything it is not
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: 20180810035658.13555-1-marcos.souza@gmail.com
Subject: [libvirt] [PATCH 0/2] esx: Fix {g,s}et vcpus
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing
On 08/01/2018 01:02 PM, Daniel P. Berrangé wrote:
> Allow for syntax
>
>
>
> to reference other files in the CPU database directory
>
> Signed-off-by: Daniel P. Berrangé
> ---
> libvirt.spec.in | 2 +-
> mingw-libvirt.spec.in | 4 +--
> src/Makefile.am | 2 +-
>
On 08/01/2018 01:02 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/cpu/cpu_map.xml | 2374 +-
> src/cpu/cpu_map_x86_486.xml |7 +
> src/cpu/cpu_map_x86_Broadwell-IBRS.xml | 61 +
>
On 08/01/2018 01:02 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/cpu/cpu_map.xml | 41 +
> src/cpu/cpu_map_ppc64_POWER6.xml| 6
> src/cpu/cpu_map_ppc64_POWER7.xml| 7 +
>
On 08/01/2018 01:02 PM, Daniel P. Berrangé wrote:
> The x86 and ppc impls both duplicate some logic when parsing CPU
> features. Change the callback signature so that this duplication can be
> pushed up a level to common code.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/cpu/cpu_map.c
在 2018/8/13 下午2:59, Cornelia Huck 写道:
On Mon, 13 Aug 2018 12:46:16 +0800
Yi Min Zhao wrote:
Is there any comment? I expect comments from all of you.
Well, I don't have any objections from my side, but you need the
libvirt folks' opinion on this.
Thanks for your response!
在 2018/8/7
On 2018年08月14日 02:33, John Ferlan wrote:
On 07/30/2018 11:54 PM, bing.niu wrote:
On 2018年07月31日 06:14, John Ferlan wrote:
On 07/29/2018 11:12 PM, bing@intel.com wrote:
From: Bing Niu
This series is to introduce RDT memory bandwidth allocation support
by extending
current
From: Bing Niu
Signed-off-by: Bing Niu
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2f0c010..c6d03f5 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,15 @@
iscsiadm. It support basic pool operations:
On Mon, 13 Aug 2018 12:46:16 +0800
Yi Min Zhao wrote:
> Is there any comment? I expect comments from all of you.
Well, I don't have any objections from my side, but you need the
libvirt folks' opinion on this.
>
>
> 在 2018/8/7 下午5:10, Yi Min Zhao 写道:
> > Abstract
> >
> > The PCI
Signed-off-by: Shi Lei
---
src/Makefile.am | 4 +++-
src/util/virkmod.c| 43 ++-
src/virt-command.conf | 10 ++
3 files changed, 55 insertions(+), 2 deletions(-)
create mode 100644 src/virt-command.conf
diff --git a/src/Makefile.am
This reverts commit bf114decb34f21cd225ead6dc4d929d35a8c5fe5.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
src/util/virjson.c | 529 -
1 file
This reverts commit 9cf38263d05ca7f27dbbd9b1a0b48d338d9280e2.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
libvirt.spec.in | 4 +-
m4/virt-nss.m4
This reverts commit c31146685f5c8558ff88d52d03a68533c9220feb.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
tests/qemuagenttest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
This reverts commit 93fdc9e0b0cbb2eec32745a868ac4633f0912ad5.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
config-post.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/config-post.h
This reverts commit ce3c6ef6843f98d81be5423ece11fad79eaab920.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
libvirt.spec.in | 2 -
src/Makefile.am | 8 +-
This reverts commit 01ce04375c3348fd683475e5aa5231149ef6a78a.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
m4/virt-driver-qemu.m4 | 3 ---
1 file changed, 3 deletions(-)
diff --git
Macro arguments are supposed to be quoted.
Signed-off-by: Andrea Bolognani
---
configure.ac | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8917b37..22d80dd 100644
--- a/configure.ac
+++ b/configure.ac
@@
Most of the calls where missing the dollar sign when
referencing variables, which caused the corresponding
version checks to be skipped.
Signed-off-by: Andrea Bolognani
---
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index
This reverts commit 8f802c6d8659beb9eb3cab96ba2553e251728337.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
src/libvirt_private.syms | 1 +
src/util/virjson.c | 22 ++
This reverts commit c5ae8e0c2b4b6bb3c667cfadaf65a66c3f4f3d85.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
m4/virt-driver-qemu.m4 | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
This reverts commit 1caf8441604b58e4a89aa2c09975b8346928c52a.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
config-post.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config-post.h
This reverts commit 12b34f094e2f1c7f414f4bb8f880a9d65c8fcd85.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Conflicts:
configure.ac:
Commit 8aa85e0b introduced LIBVIRT_*_LIBISCSI macros.
Signed-off-by: Ján Tomko
---
This reverts commit 4dd60540007042bfc0087a67f57f3e9f3311a84a.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
m4/virt-jansson.m4 | 3 ---
tests/qemublocktest.c| 5 -
Andrea Bolognani (2):
configure: Fix quoting
configure: Call PKG_CHECK_MODULES() correctly
configure.ac | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
--
2.17.1
--
libvir-list mailing list
libvir-list@redhat.com
On Mon, Aug 13, 2018 at 11:21:44AM +0200, Michal Privoznik wrote:
> We are freeing the individual strings (which were filled by
> virNetDevIPCheckIPv6ForwardingCallback()) but not the array
> itself.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virnetdevip.c | 3 +--
> 1 file changed, 1
On Mon, Aug 13, 2018 at 11:21:45AM +0200, Michal Privoznik wrote:
> When starting network a macmap object is created (which stores
> MAC -> domain name mappings). However, if something goes wrong
> (e.g. virNetDevIPCheckIPv6Forwarding() fails) then the object is
> leaked.
>
> Signed-off-by: Michal
Currently the way virStorageVolWipe() works is it looks up
pool containing given volume and hold it locked throughout while
API execution. This is suboptimal because wiping a volume means
writing data to it which can take ages. And if the whole pool is
locked during that operation no other API can
On Thu, Aug 09, 2018 at 09:42:15AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Thu, Aug 09, 2018 at 09:42:18AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Thu, Aug 09, 2018 at 09:42:10AM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope.
On 08/13/2018 11:46 AM, Simon Kobyda wrote:
> On Fri, 2018-08-10 at 15:40 +0200, Michal Privoznik wrote:
>> On 08/10/2018 11:11 AM, Simon Kobyda wrote:
>>> +static vshTableRowPtr
>>> +vshTableRowNew(size_t size, const char *arg, va_list ap)
>>
>> I know we discussed this in person, but now that
On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote:
On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote:
Ivan Mishonov wrote:
Yes, that makes sense. I'll try to find some time next week to redo my
code and send another patch. Since my time for working on libvirt is
very
On Thu, Aug 09, 2018 at 09:42:16AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Thu, Aug 09, 2018 at 09:42:17AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Monday, August 13, 2018 at 10:02 AM, Daniel P. Berrangé wrote:
>On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote:
>> Hi, everyone!
>> It's possible that the running-time of a command is long than its caller
>> expected. Perhaps, it's useful to provide timeout mode for virCommandRun or
>>
On Thu, Aug 09, 2018 at 09:42:09AM +0530, Sukrit Bhatnagar wrote:
> Add another usage for VIR_AUTOFREE macro which was left in the
> commit ec3e878, thereby dropping a VIR_FREE call and and a cleanup
> section.
>
> Signed-off-by: Sukrit Bhatnagar
> ---
> src/util/viriscsi.c | 22
On Mon, Aug 13, 2018 at 07:37:33PM +0800, shilei.massclo...@gmx.com wrote:
> On Monday, August 13, 2018 at 10:02 AM, Daniel P. Berrangé wrote:
> >On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote:
> >> Hi, everyone!
> >> It's possible that the running-time of a command is long than its
For QEMU, we need a JSON parser that is able to handle its non-compliant
JSON usage:
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Unfortunately, this does not seem to be possible with Jansson.
Revert back to using yajl, which also lets us get rid of the 'dlopen'
hacks and their bugfixes.
This reverts commit 5d40272ea67c74049600e120095d1b42287ed2d2.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
src/Makefile.am | 2 --
src/util/Makefile.inc.am | 1 -
tools/Makefile.am
This reverts commit 9e44c2db8ad94d3c20acc1d081538c280af198b4.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
src/util/virjsoncompat.c | 13 +
1 file changed, 1 insertion(+), 12
This reverts commit b3d9b08ef797e569b14cfa42d3dceba23c2a5b14.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
tools/Makefile.am | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
This reverts commit 397447f80588438545994a86883792a5999cad15.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
tests/qemucapsprobemock.c | 2 --
1 file changed, 2 deletions(-)
diff --git
This reverts commit 3251fc9c9b9639c3fec3181530599415523d671a.
Jansson cannot parse QEMU's quirky JSON.
Revert back to yajl.
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Signed-off-by: Ján Tomko
---
src/libvirt_private.syms | 4
src/remote/remote_daemon.c | 4
2 files
40p machine type should be used instead.
Signed-off-by: Hervé Poussineau
---
qemu-deprecated.texi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 9920a85adc..9c7ff3fe2d 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@
On Thu, Aug 09, 2018 at 03:14:18PM +0200, Vitaly Kuznetsov wrote:
> Several new Hyper-V enlightenments were recently added to Qemu:
> - hv-frequencies
> - hv-reenlightenment
> - hv-tlbflush
>
> Support these in libvirt.
>
> Vitaly Kuznetsov (3):
> conf: qemu: add support for Hyper-V frequency
On Mon, Aug 13, 2018 at 03:51:51PM +0200, Michal Prívozník wrote:
> On 08/11/2018 04:39 PM, Marcos Paulo de Souza wrote:
> > When building libvirt with libcurl debug enabled (with
> > ESX_VI__CURL__ENABLE_DEBUG_OUTPUT set), the message bellow pops up:
> >
> > make[3]: Entering directory
On 08/13/2018 12:26 AM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> Signed-off-by: Clementine Hayat
> ---
> src/storage/storage_backend_iscsi_direct.c | 121 -
> 1 file changed, 120 insertions(+), 1 deletion(-)
>
> diff --git
On 08/13/2018 12:26 AM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> The code to set the connection and connect using libiscsi will always be
> the same. Add function to avoid code duplication.
>
> Signed-off-by: Clementine Hayat
> ---
> src/storage/storage_backend_iscsi_direct.c |
On 08/13/2018 12:26 AM, c...@lse.epita.fr wrote:
> From: Clementine Hayat
>
> Hello,
>
> This series of patch is the follow up of:
> v1:https://www.redhat.com/archives/libvir-list/2018-August/msg00557.html
> v2:https://www.redhat.com/archives/libvir-list/2018-August/msg00570.html
>
> Best
On Thu, Aug 09, 2018 at 17:01:49 +0200, Michal Privoznik wrote:
> On 08/07/2018 01:46 PM, Bobo Du wrote:
> > the vm xml will be existed when the vm is undefined after started.
> > blockcommit interface also has the bug with above.
> > Step1:prepare a vm，eg:test1,start it and undefined
> > Step2:
On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote:
> Hi, everyone!
> It's possible that the running-time of a command is long than its caller
> expected. Perhaps, it's useful to provide timeout mode for virCommandRun or
> virCommandRunAsync + virCommandWait. And The caller can restrict the
>
On Fri, 2018-08-10 at 15:40 +0200, Michal Privoznik wrote:
> On 08/10/2018 11:11 AM, Simon Kobyda wrote:
> > It solves problems with alignment of columns. Width of each column
> > is calculated by its biggest cell. Should solve unicode bug.
> > In future, it may be implemented in virsh,
On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote:
> Ivan Mishonov wrote:
>
> > Yes, that makes sense. I'll try to find some time next week to redo my
> > code and send another patch. Since my time for working on libvirt is
> > very limited can you confirm that the LPC
The virSecretGetSecretString() helper looks up a secret for given
pool and returns its value in @secret_value and its length in
@secret_value_size. However, the trailing '\0' is not included in
either of the variables. This is because usually the value of the
secret is passed to some encoder
When starting network a macmap object is created (which stores
MAC -> domain name mappings). However, if something goes wrong
(e.g. virNetDevIPCheckIPv6Forwarding() fails) then the object is
leaked.
Signed-off-by: Michal Privoznik
---
src/network/bridge_driver.c | 2 ++
1 file changed, 2
*** NOT PUSHED. PLEASE REVIEW ***
Michal Prívozník (2):
virnetdevip: Free data.devices in virNetDevIPCheckIPv6Forwarding() too
networkStartNetworkVirtual: Don't leak macmap object
src/network/bridge_driver.c | 2 ++
src/util/virnetdevip.c | 3 +--
2 files changed, 3 insertions(+), 2
We are freeing the individual strings (which were filled by
virNetDevIPCheckIPv6ForwardingCallback()) but not the array
itself.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevip.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virnetdevip.c
I thought that it would work, but I was clearly mistaken :/
Andrea Bolognani (2):
projects: Don't build libvirt-dbus on Debian 8
guests: Don't prepare Debian 8 for libvirt-dbus
guests/host_vars/libvirt-debian-8/main.yml | 1 -
projects/libvirt-dbus.yaml | 1 -
2 files
On Fri, Jul 27, 2018 at 02:37:38PM +0200, Andrea Bolognani wrote:
We're already using node_device_create explicitly for all
test cases in order to retrieve the result of the fixture,
so using pytest.mark.usefixtures as well is pointless.
Additionally, we're soon going to add some test cases
On Thu, Aug 09, 2018 at 09:42:11AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Thu, Aug 09, 2018 at 09:42:13AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Mon, 2018-08-13 at 12:01 +0200, Michal Prívozník wrote:
> On 08/13/2018 11:46 AM, Simon Kobyda wrote:
> > On Fri, 2018-08-10 at 15:40 +0200, Michal Privoznik wrote:
> > > On 08/10/2018 11:11 AM, Simon Kobyda wrote:
>
>
> > > > +static vshTableRowPtr
> > > > +vshTableRowNew(size_t size, const
On 10/08/18 23:46, Hervé Poussineau wrote:
> 40p machine type should be used instead.
>
> Signed-off-by: Hervé Poussineau
> ---
> qemu-deprecated.texi | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 9920a85adc..9c7ff3fe2d
Commit id d45bee449 updated the pool-define-as qualifier descriptions
to add some new fields, but neglected to modify the command item list
in order to add those fields as well.
Signed-off-by: John Ferlan
---
Discovered by QE while validating bz1601377.
tools/virsh.pod | 4 +++-
1 file
On Thu, Aug 09, 2018 at 09:42:11AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
On Thu, Aug 09, 2018 at 09:42:14AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
On Mon, Aug 13, 2018 at 01:55:10PM +0200, Ján Tomko wrote:
For QEMU, we need a JSON parser that is able to handle its non-compliant
JSON usage:
https://bugzilla.redhat.com/show_bug.cgi?id=1614569
Unfortunately, this does not seem to be possible with Jansson.
Revert back to using yajl, which
On Mon, Aug 13, 2018 at 02:54:00PM +0200, Ján Tomko wrote:
> On Mon, Aug 13, 2018 at 01:55:10PM +0200, Ján Tomko wrote:
> > For QEMU, we need a JSON parser that is able to handle its non-compliant
> > JSON usage:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1614569
> >
> > Unfortunately, this
Turns out Debian 8 includes GLib 2.42 whereas libvirt-dbus
requires at least GLib 2.44 to build.
I had accidentally installed GLib 2.48 from backports on
my local Debian 8 guests, which explains how the build
could succeed during testing.
This reverts commit
We're no longer attempting the build, which was failing
anyway, so no point in installing the dependencies.
This reverts commit ef2b446ecb77cefa2f041e9ad03124bbc13d22c3.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-debian-8/main.yml | 1 -
1 file changed, 1 deletion(-)
diff
On Mon, Aug 13, 2018 at 02:08:30PM +0200, Andrea Bolognani wrote:
> I thought that it would work, but I was clearly mistaken :/
>
> Andrea Bolognani (2):
> projects: Don't build libvirt-dbus on Debian 8
> guests: Don't prepare Debian 8 for libvirt-dbus
Reviewed-by: Daniel P. Berrangé
On Thu, Aug 09, 2018 at 09:42:12AM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: 20180803093532.16922-1-berra...@redhat.com
Subject: [libvirt] [PATCH] rpm: simplify applying of patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id:
7824152ee221199b352c0753db3eefaa5ec9dbb7.1533222453.git.jdene...@redhat.com
Subject: [libvirt] [PATCH] qemu_migration: Avoid writing to freed memory
===
Ivan Mishonov wrote:
> On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote:
>
> > On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote:
> >>Ivan Mishonov wrote:
> >>
> >>> Yes, that makes sense. I'll try to find some time next week to redo my
> >>> code and send another patch.
Print the differences in case when the expected data does not match.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index
The wrapper executes the command and does error detection so there's no
need to open-code all of those things.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 37 +
1 file changed, 5 insertions(+), 32 deletions(-)
diff --git
The blockdev support will change existing approach to add disks to VMs
so all tests using the DO_TEST_CAPS_LATEST approach which have any disks
need to be forked so that the changes can be applied.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-aio.x86_64-2.12.0.args | 37
The 'device' argument matches only the legacy drive alias. For blockdev
we need to set the throttling for a QOM id and thus we'll need to use
the 'id' field.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_monitor.c | 8 +---
src/qemu/qemu_monitor.h
Add test data for nested backing chains with/without indexes (used in
status XMLs) which will excercise blockdev and the related work.
Signed-off-by: Peter Krempa
---
.../disk-backing-chains-index.x86_64-2.12.0.args | 1 +
.../disk-backing-chains-index.x86_64-latest.args | 1 +
Print the values so it's simpler to debug.
Signed-off-by: Peter Krempa
---
src/util/virqemu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/util/virqemu.c b/src/util/virqemu.c
index bc788538af..13ad7410b4 100644
--- a/src/util/virqemu.c
+++ b/src/util/virqemu.c
@@
We don't use it for anything useful so it does not make much sense to
extract it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.h | 1 -
src/qemu/qemu_monitor_json.c | 7 ---
tests/qemumonitorjsontest.c | 1 -
3 files changed, 9 deletions(-)
diff --git
The diff contains changes from the change of the JSON library
reformatting as well as dropping of the preconfig state and adding of
the 'qdev' field to output of 'query-blockstats'.
Signed-off-by: Peter Krempa
---
.../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 591 +++--
Use qemuDomainAttachDeviceDiskLive to change the media in
qemuDomainChangeDiskLive as the former function already does all the
necessary steps to prepare the new medium.
This also allows us to turn qemuDomainChangeEjectableMedia static.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c |
The disk is not necessary to test the mdevs.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml| 6 --
.../hostdev-mdev-display-spice-egl-headless.x86_64-latest.args | 2 --
SD cards are currently passed by using -drive only which would not be
compatible with using -blockdev fully.
Clear QEMU_CAPS_BLOCKDEV if the VM has such devices.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Turns out that 'query-nodes' is not what we want and the
'query-blockstats' command was in fact buggy. Revert the new field since
it's not needed.
This reverts commit 50edca1331298bfcb2622e8fe588d493aff9ab68.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c| 2 +-
Currently we'd report the alias of the drive which is backing the cdrom
rather than the device itself:
$ virsh event ds tray-change --loop
event 'tray-change' for domain ds disk drive-ide0-0-1: opened
event 'tray-change' for domain ds disk drive-ide0-0-1: closed
Report the disk device alias
Remove the pointless "empty path" check and use a better error message
if the disk was not found.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
Move the preparation steps from qemuDomainAttachDiskGeneric up into
qemuDomainAttachDeviceDiskLive so that also media changing can use the
prepared file.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git
1 - 100 of 171 matches
Mail list logo
