On 08/20/2018 05:07 PM, Daniel P. Berrangé wrote:
> On Tue, Aug 14, 2018 at 01:19:42PM +0200, Michal Privoznik wrote:
>> In order for our drivers to lock resources for metadata change we
>> need set of new APIs. Fortunately, we don't have to care about
>> every possible device a domain can have.
On Tue, Aug 14, 2018 at 01:19:42PM +0200, Michal Privoznik wrote:
> In order for our drivers to lock resources for metadata change we
> need set of new APIs. Fortunately, we don't have to care about
> every possible device a domain can have. We care only about those
> which can live on a network
On Mon, 2018-08-20 at 17:00 +0200, Erik Skultety wrote:
> On Fri, Aug 10, 2018 at 03:37:45PM +0200, Andrea Bolognani wrote:
> > None of our jobs create the archives as a side-effect, so
> > trying to remove them before generating them is pointless.
>
> Who cleans them after the jobs below? Is
https://bugzilla.redhat.com/show_bug.cgi?id=1610072
Due to historical reasons we were not parsing device info on
guestfwd channel. Sure, it doesn't make much sense to parse
but it surely makes sense to parse its alias (which
might be an user alias).
This reverts commit
On Mon, Aug 20, 2018 at 04:37:13PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-08-20 at 16:01 +0200, Erik Skultety wrote:
> > On Fri, Aug 10, 2018 at 03:37:41PM +0200, Andrea Bolognani wrote:
> > > - $PYTHON ./setup.py rpm
> > > + rm -f dist/*.tar.{{ archive_format }}
> > > +
On Tue, Aug 14, 2018 at 01:19:43PM +0200, Michal Privoznik wrote:
> Fortunately, we have qemu wrappers so it's sufficient to put
> lock/unlock call only there.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_security.c | 107
> +++
> 1 file
On Mon, 2018-08-20 at 16:11 +0200, Erik Skultety wrote:
> On Fri, Aug 10, 2018 at 03:37:44PM +0200, Andrea Bolognani wrote:
> >sed -i -e 's/BuildRequires: *perl(Sys::Virt).*//' *.spec*
> > - sed -i -e 's/BuildRequires: *perl-Sys-Virt.*//' *.spec*
>
> I assume because ^these 2 are
On 08/20/2018 05:04 PM, Daniel P. Berrangé wrote:
> On Mon, Aug 20, 2018 at 03:59:23PM +0100, Daniel P. Berrangé wrote:
>> On Fri, Aug 17, 2018 at 10:49:12AM -0400, John Ferlan wrote:
>>>
>>>
>>> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
No real support implemented here. But hey, at
On Mon, Aug 20, 2018 at 04:07:28PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 14, 2018 at 01:19:42PM +0200, Michal Privoznik wrote:
> > In order for our drivers to lock resources for metadata change we
> > need set of new APIs. Fortunately, we don't have to care about
> > every possible device
On 08/20/2018 05:16 PM, Daniel P. Berrangé wrote:
> On Tue, Aug 14, 2018 at 01:19:43PM +0200, Michal Privoznik wrote:
>> Fortunately, we have qemu wrappers so it's sufficient to put
>> lock/unlock call only there.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/qemu/qemu_security.c | 107
>>
On Sun, 19 Aug 2018 22:25:19 +0800
Zhi Wang wrote:
> Share some updates of my work on this topic recently:
>
> Thanks for Erik's guide and advices. Now my PoC patches almost works.
> Will send the RFC soon.
>
> Mostly the ideas are based on Alex's idea: a match between a device
> state
For the supporting of Intel x86 Cache Monitoring Technology (CMT) in
libvirt,
we have already discussed a couple of times, and I have raised two RFCs, you
can find the discussion from the following links, and thanks to the people
who participated in the discussion online and offline.
RFCv2 links
在 2018/8/20 下午6:48, Andrea Bolognani 写道:
On Mon, 2018-08-20 at 16:32 +0800, Yi Min Zhao wrote:
在 2018/8/16 下午11:03, Andrea Bolognani 写道:
I haven't looked into the hash table handling in detail but I
wonder if it's really necessary? IIUC you're using it just to
mark which uids and fids have
在 2018/8/20 下午6:17, Andrea Bolognani 写道:
On Mon, 2018-08-20 at 11:39 +0800, Yi Min Zhao wrote:
在 2018/8/18 上午12:21, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+
+
+ qemu: Added support for PCI device passthrough on S390
+
On Tue, Aug 21, 2018 at 10:34 AM, Julio Faracco wrote:
> This serie adds a new function into QEMU Guest Agent handlers to use
> the QEMU command 'guest-get-host-name' to retrieve the domain hostname.
> This approach requires QEMU-GA running inside the guest, but it is the
> fastest and easiest
在 2018/8/20 下午6:35, Andrea Bolognani 写道:
On Mon, 2018-08-20 at 16:19 +0800, Yi Min Zhao wrote:
在 2018/8/16 下午10:38, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
+struct _virZPCIDeviceAddress {
+unsigned int zpci_fid;
+unsigned int zpci_uid;
+bool
在 2018/8/20 下午7:34, Andrea Bolognani 写道:
So, I'm very much not familiar with the hotplug code and seeing
changes to stuff like qemuDomainAttachDiskGeneric() makes me a bit
uncomfortable:)
I can't spot anything obviously wrong in your changes, but I think
perhaps you might want to enter and
This commit implements the function qemuAgentGetHostname() that uses the
QEMU command 'guest-get-host-name' to retrieve the guest hostname of
Virtual Machine. It is a possibility where QEMU-GA is running.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_agent.c | 42
Add sub-command nodesevinfo to get node infomation of AMD SEV feature.
Signed-off-by: Han Han
---
tools/virsh-host.c | 66 ++
tools/virsh.pod| 5
2 files changed, 71 insertions(+)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index
Add virsh nodesevinfo to get AMD SEV features via virNodeGetSEVInfo.
Han Han (2):
virsh: Implement virNodeGetSEVInfo in virsh
news: Add nodesevinfo command in virsh
docs/news.xml | 9 +++
tools/virsh-host.c | 66 ++
tools/virsh.pod|
Signed-off-by: Han Han
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c6d03f5556..fc9db92d05 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -63,6 +63,15 @@
Support the vhost-vsock-ccw device on S390.
This commit add the support to use the function qemuAgentGetHostname() for
obtain the domain hostname using QEMU-GA command.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_driver.c | 40
1 file changed, 40 insertions(+)
diff --git
This serie adds a new function into QEMU Guest Agent handlers to use
the QEMU command 'guest-get-host-name' to retrieve the domain hostname.
This approach requires QEMU-GA running inside the guest, but it is the
fastest and easiest way to get this info.
Julio Faracco (2):
qemu: implementing
Hi,
> doc: switch to modern syntax for VNC TLS setup
> vnc: remove support for deprecated tls, x509, x509verify options
Added to ui queue.
thanks,
Gerd
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, 2018-08-20 at 16:01 +0200, Erik Skultety wrote:
> On Fri, Aug 10, 2018 at 03:37:41PM +0200, Andrea Bolognani wrote:
> > - $PYTHON ./setup.py rpm
> > + rm -f dist/*.tar.{{ archive_format }}
> > + $PYTHON ./setup.py sdist
> > + rpmbuild --clean --define
On Tue, Aug 14, 2018 at 01:19:37PM +0200, Michal Privoznik wrote:
> So far the virLockSpaceAcquireResource() locks the first byte in
> the underlying file. But caller might want to lock other range.
>
> Signed-off-by: Michal Privoznik
> ---
> src/locking/lock_daemon_dispatch.c | 3 +++
>
On Tue, Aug 14, 2018 at 01:19:38PM +0200, Michal Privoznik wrote:
> This flag modifies the way the lock is acquired. It waits for the
> lock to be set instead of usual set-or-fail logic that happens
> without this flag.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virlockspace.c | 14
On Mon, Aug 20, 2018 at 09:25:18AM +0200, Michal Prívozník wrote:
> On 08/17/2018 12:24 AM, John Ferlan wrote:
> >
> >
> > On 08/14/2018 07:19 AM, Michal Privoznik wrote:
> >> Signed-off-by: Michal Privoznik
> >> ---
> >> src/locking/lock_driver.h | 2 ++
> >> 1 file changed, 2 insertions(+)
>
On Mon, Aug 20, 2018 at 09:25:13AM +0200, Michal Prívozník wrote:
> On 08/17/2018 01:53 AM, John Ferlan wrote:
> >
> >
> > On 08/14/2018 07:19 AM, Michal Privoznik wrote:
> >> Signed-off-by: Michal Privoznik
> >> ---
> >> src/locking/lock_daemon_dispatch.c | 12 ++--
> >>
On Fri, Aug 17, 2018 at 10:49:12AM -0400, John Ferlan wrote:
>
>
> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
> > No real support implemented here. But hey, at least we will not
> > fail.
> >
> > Signed-off-by: Michal Privoznik
> > ---
> > src/locking/lock_driver_sanlock.c | 25
On Fri, Aug 10, 2018 at 03:37:45PM +0200, Andrea Bolognani wrote:
> None of our jobs create the archives as a side-effect, so
> trying to remove them before generating them is pointless.
Who cleans them after the jobs below? Is there a chance that you could trigger
these jobs in a sequence that
On Mon, Aug 20, 2018 at 03:59:23PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 17, 2018 at 10:49:12AM -0400, John Ferlan wrote:
> >
> >
> > On 08/14/2018 07:19 AM, Michal Privoznik wrote:
> > > No real support implemented here. But hey, at least we will not
> > > fail.
> > >
> > >
On 08/17/2018 04:49 PM, John Ferlan wrote:
>
>
> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
>> No real support implemented here. But hey, at least we will not
>> fail.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/locking/lock_driver_sanlock.c | 25 ++---
>> 1
On 08/17/2018 12:24 AM, John Ferlan wrote:
>
>
> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
>> Signed-off-by: Michal Privoznik
>> ---
>> src/locking/lock_driver.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/src/locking/lock_driver.h b/src/locking/lock_driver.h
>> index
On 08/17/2018 07:58 PM, John Ferlan wrote:
>
>
> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
>> In order for our drivers to lock resources for metadata change we
>> need set of new APIs. Fortunately, we don't have to care about
>> every possible device a domain can have. We care only about
On 08/17/2018 01:53 AM, John Ferlan wrote:
>
>
> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
>> Signed-off-by: Michal Privoznik
>> ---
>> src/locking/lock_daemon_dispatch.c | 12 ++--
>> src/locking/lock_driver_lockd.c| 31 +--
>>
On 08/17/2018 08:38 PM, John Ferlan wrote:
>
>
> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
>> Fortunately, we have qemu wrappers so it's sufficient to put
>> lock/unlock call only there.
>>
>
> Kind of sparse... Maybe a few words related to what benefit locking the
> metadata provides.
The vol-dumpxml shows the volume target format type as raw for
encrypted volumes. The error message when attempting to resize
with prealloc is confusing here.
Signed-off-by: Shivaprasad G Bhat
---
src/storage/storage_util.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Ping - as there was no other review yet for the series except a copy-paste
bug spotted (thanks Bjoern)
On Tue, Aug 14, 2018 at 11:27 AM Christian Ehrhardt <
christian.ehrha...@canonical.com> wrote:
> Hi,
> after a good discussion a few days ago in
>
On Mon, 2018-08-20 at 11:39 +0800, Yi Min Zhao wrote:
> 在 2018/8/18 上午12:21, Andrea Bolognani 写道:
> > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> > [...]
> > > +
> > > +
> > > + qemu: Added support for PCI device passthrough on S390
> > > +
> > > +
On Mon, 2018-08-20 at 16:19 +0800, Yi Min Zhao wrote:
> 在 2018/8/16 下午10:38, Andrea Bolognani 写道:
> > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> > > +struct _virZPCIDeviceAddress {
> > > +unsigned int zpci_fid;
> > > +unsigned int zpci_uid;
> > > +bool fid_assigned;
> > >
On Mon, 2018-08-20 at 16:32 +0800, Yi Min Zhao wrote:
> 在 2018/8/16 下午11:03, Andrea Bolognani 写道:
> > I haven't looked into the hash table handling in detail but I
> > wonder if it's really necessary? IIUC you're using it just to
> > mark which uids and fids have been already used by a device,
> >
On Mon, 2018-08-20 at 16:45 +0800, Yi Min Zhao wrote:
> 在 2018/8/17 上午12:31, Andrea Bolognani 写道:
> > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> > > +virBufferAddLit(, "zpci");
> > > +virBufferAsprintf(, ",uid=%u", dev->addr.pci.zpci->zpci_uid);
> > > +virBufferAsprintf(,
On Mon, 2018-08-20 at 16:04 +0800, Yi Min Zhao wrote:
> 在 2018/8/18 上午12:10, Andrea Bolognani 写道:
> > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> > > This commit adds hotplug support for PCI devices on S390 guests.
> > > There's no need to implement hot unplug for zPCI as QEMU
Both GObject and GIO are part of GLib, so there's no
point in requiring different versions of the two.
Signed-off-by: Andrea Bolognani
---
configure.ac | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index f32c735..d2e2636 100644
---
The API has been deprecated, which causes build failures
on Fedora Rawhide; use the G_DEFINE_TYPE_WITH_PRIVATE()
macro instead.
This requires bumping the minimum GLib version to 2.38.
Signed-off-by: Andrea Bolognani
---
configure.ac | 2 +-
在 2018/8/16 下午10:38, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
+typedef struct _virZPCIDeviceAddress virZPCIDeviceAddress;
+typedef virZPCIDeviceAddress *virZPCIDeviceAddressPtr;
+struct _virZPCIDeviceAddress {
+unsigned int zpci_fid;
+unsigned int
On 08/20/2018 09:25 AM, Michal Prívozník wrote:
> On 08/17/2018 04:49 PM, John Ferlan wrote:
>>
>>
>> On 08/14/2018 07:19 AM, Michal Privoznik wrote:
>>> No real support implemented here. But hey, at least we will not
>>> fail.
>>>
>>> Signed-off-by: Michal Privoznik
>>> ---
>>>
On Sat, Aug 18, 2018 at 02:18:17PM +0200, Peter Krempa wrote:
> On Fri, Aug 17, 2018 at 23:25:19 -0300, Julio Faracco wrote:
> > This commit add the support to use the function qemuAgentGetHostname() for
> > obtain the domain hostname using QEMU-GA command.
> >
> > Signed-off-by: Julio Faracco
>
From: David Abdurachmanov
---
libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index e7196b7d3b..5cb995a6a4 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -101,7 +101,7 @@
%endif
# Numactl is not available on
On Mon, Aug 20, 2018 at 10:15:05AM +0200, Andrea Bolognani wrote:
> Both GObject and GIO are part of GLib, so there's no
> point in requiring different versions of the two.
>
> Signed-off-by: Andrea Bolognani
> ---
> configure.ac | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
This fixes build on Fedora Rawhide.
Andrea Bolognani (2):
configure: Use a single required version for GLib
Remove all uses of g_type_class_add_private()
configure.ac | 7 +++
libvirt-sandbox/libvirt-sandbox-builder-container.c| 4
在 2018/8/16 下午10:39, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
Let's introduce zPCI capability.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
Reviewed-by: Ján Tomko
---
在 2018/8/16 下午10:45, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
QEMU on s390 supports PCI multibus since forever.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
Reviewed-by: Ján Tomko
---
在 2018/8/16 下午10:44, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+qemuDomainDeviceSupportZPCI(virDomainDeviceDefPtr device)
+{
+switch ((virDomainDeviceType) device->type) {
+case VIR_DOMAIN_DEVICE_CHR:
+return false;
+
+case
在 2018/8/16 下午10:52, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
The pci-root depends on zpci capability. So autogenerate pci-root if
zpci exists.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern
On Sun, 2018-08-19 at 19:46 +0100, Richard W.M. Jones wrote:
> On Sun, Aug 19, 2018 at 07:44:06PM +0100, Richard W.M. Jones wrote:
> >
> > http://fedora-riscv.tranquillity.se/koji/taskinfo?taskID=95457
Neat!
> > There were some minor changes to the spec file:
> >
> >
在 2018/8/17 上午12:31, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+char *
+qemuBuildZPCIDevStr(virDomainDeviceInfoPtr dev)
+{
+virBuffer buf = VIR_BUFFER_INITIALIZER;
+
+virBufferAddLit(, "zpci");
+virBufferAsprintf(, ",uid=%u",
在 2018/8/18 上午12:19, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+have multiple functions used. (Since 4.7.0
+), PCI address extensions depending on the architecture
+are supported. E.g. for S390 guests, PCI addresses have
+
On Mon, Aug 20, 2018 at 10:15:06AM +0200, Andrea Bolognani wrote:
> The API has been deprecated, which causes build failures
> on Fedora Rawhide; use the G_DEFINE_TYPE_WITH_PRIVATE()
> macro instead.
>
> This requires bumping the minimum GLib version to 2.38.
>
> Signed-off-by: Andrea Bolognani
在 2018/8/16 下午11:14, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+static int
+virZPCIDeviceAddressIsValid(virZPCIDeviceAddressPtr zpci)
+{
+if (zpci->uid_assigned &&
+(zpci->zpci_uid > VIR_DOMAIN_DEVICE_ZPCI_MAX_UID ||
+ zpci->zpci_uid
commit 6534b3c4 try to raise an error when there is no numa nodes but
set access='shared' in domain config. In that commit, we add a memory access
validate function for memory device, but this check is not related to memory
device and won't work if there is no memory device in guest xml.
Move the
在 2018/8/18 上午12:10, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
This commit adds hotplug support for PCI devices on S390 guests.
There's no need to implement hot unplug for zPCI as QEMU implements
an unplug callback which will unplug both PCI and zPCI device in
在 2018/8/16 下午10:38, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
+typedef struct _virZPCIDeviceAddress virZPCIDeviceAddress;
+typedef virZPCIDeviceAddress *virZPCIDeviceAddressPtr;
+struct _virZPCIDeviceAddress {
+unsigned int zpci_fid;
+unsigned int
在 2018/8/16 下午11:03, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
This patch provides a caching mechanism for the device address
extensions uid and fid on S390. For efficient sparse address allocation,
we introduce two hash tables for uid/fid which hold the
On Mon, Aug 20, 2018 at 10:40:42AM +0200, Andrea Bolognani wrote:
> On Sun, 2018-08-19 at 19:46 +0100, Richard W.M. Jones wrote:
> > On Sun, Aug 19, 2018 at 07:44:06PM +0100, Richard W.M. Jones wrote:
> > >
> > > http://fedora-riscv.tranquillity.se/koji/taskinfo?taskID=95457
>
> Neat!
>
> > >
On Mon, 2018-08-20 at 09:59 +0100, Richard W.M. Jones wrote:
> From: David Abdurachmanov
We require a Signed-off-by for libvirt contributions these days,
so we can't merge this patch unless it's provided.
[...]
> # Numactl is not available on s390[x] and ARM
Comment should be updated to
Technically, this is a v2 of:
https://www.redhat.com/archives/libvir-list/2018-August/msg00624.html
but majority of the patches are new. The review of the patch from above
made me look into storage pool locking more and I have found some
issues.
For best view of the patches (esp. 4/8 use
Even though we do some checking is not as thorough as it should
be. We already have virStoragePoolObjIsDuplicate but the way we
use it is a typical TOCTOU. Imagine two threads trying to define
two pools with the same name but different UUIDs. With the
current code neither of them finds a duplicate
Just like a few commits earlier, checking for pool source
duplicates and unlocking pools list afterwards is a buggy
pattern. The check must go into virStoragePoolObjAssignDef.
Signed-off-by: Michal Privoznik
---
src/conf/virstorageobj.c | 7 ---
src/conf/virstorageobj.h | 4
This function is going to be made static in used in
virStoragePoolObjAssignDef(). Therefore move it and all the
static functions it calls a few lines up.
Signed-off-by: Michal Privoznik
---
src/conf/virstorageobj.c | 788 +++
1 file changed, 394
There are few operations in the storage driver that read/write
data onto volumes. Such operations can take very long time to
finish. During that time the storage pool object is locked which
has bad performance impacts (other threads can't fetch its XML
for instance). This commit prepares the
The @conn argument is needed only to do some source matching in
case of iSCSI source. Anyway, it's used just for node device
driver and as such can be replaced with virGetConnectNodeDev().
At the same time, the @conn struct member is dropped from
_virStoragePoolObjFindDuplicateData.
As advertised in previous commit, there are three APIs that might
run for quite some time (because they read/write data from/to a
volume) and these three are: downloadVol, uploadVol, wipeVol.
Release pool object lock and reacquire it later to allow more
concurrency.
Signed-off-by: Michal
This function is going to be made static in used in
virStoragePoolObjAssignDef(). Therefore move it a few lines up.
Signed-off-by: Michal Privoznik
---
src/conf/virstorageobj.c | 124 +++
1 file changed, 62 insertions(+), 62 deletions(-)
diff --git
In two places the passed pool object argument is marked as
ATTRIBUTE_UNUSED even though it's used right away.
Signed-off-by: Michal Privoznik
---
src/storage/storage_backend_rbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/storage/storage_backend_rbd.c
On Fri, Aug 10, 2018 at 03:37:44PM +0200, Andrea Bolognani wrote:
> We can drop some entries and tweak some others to be
> less verbose without losing in functionality.
>
> Signed-off-by: Andrea Bolognani
> ---
> jobs/defaults.yaml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>
On Fri, Aug 10, 2018 at 03:37:41PM +0200, Andrea Bolognani wrote:
> Instead of using the custom 'rpm' target of setup.py,
> generate a dist archive using the 'sdist' target and then
> call rpmbuild ourselves: this way we can define _topdir
> and stop artifacts from ending up in ~/rpmbuild.
>
>
On Fri, Aug 10, 2018 at 03:37:42PM +0200, Andrea Bolognani wrote:
> Doing so will allow us to refactor away the common parts.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Aug 10, 2018 at 03:37:43PM +0200, Andrea Bolognani wrote:
> There's no harm in attempting to strip more BuildRequires
> than are present in a spec file, so define a shell snippet
> we can reuse for the the purpose without duplicating the
> same lines all over the place.
>
> Signed-off-by:
80 matches
Mail list logo
