On Tue, 2018-08-21 at 11:24 +0800, Yi Min Zhao wrote:
> 在 2018/8/20 下午6:35, Andrea Bolognani 写道:
> > You could do the same thing those functions do:
> >
> >* the zPCI address is empty if both uid and fid are zero;
>
> uid=0 and fid=0 can't mean zPCI address is empty, because the user might
>
On 21/08/2018 09:45, Gerd Hoffmann wrote:
> +qemu_mutex_lock(>lock);
> if (ssd->cursor) {
> +QEMUCursor *c = ssd->cursor;
> assert(ssd->dcl.con);
> +cursor_get(c);
> +qemu_mutex_unlock(>lock);
> dpy_cursor_define(ssd->dcl.con, ssd->cursor);
Gerd,
在 2018/8/21 下午4:06, Andrea Bolognani 写道:
On Tue, 2018-08-21 at 11:24 +0800, Yi Min Zhao wrote:
在 2018/8/20 下午6:35, Andrea Bolognani 写道:
You could do the same thing those functions do:
* the zPCI address is empty if both uid and fid are zero;
uid=0 and fid=0 can't mean zPCI address is
On Wed, Aug 08, 2018 at 11:49:27AM +0100, Daniel P. Berrangé wrote:
> We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
> be removed entirely in the 3.1.0 release. The min GTK3 version can also
> be bumped up based the distros we aim to support.
Doesn't apply any more.
Can
From: Marc-André Lureau
Minor code simplification.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-id: 20180801092508.4927-1-marcandre.lur...@redhat.com
Signed-off-by: Gerd Hoffmann
---
qemu-keymap.c | 2 +-
ui/console.c | 6 +++---
2 files changed, 4 insertions(+),
From: Daniel P. Berrangé
The 'tls-creds' option accepts the name of a TLS credentials
object. This replaced the usage of 'tls', 'x509' and 'x509verify'
options in 2.5.0. These deprecated options were grandfathered in
when the deprecation policy was introduded in 2.10.0, so can now
finally be
From: Thomas Huth
We've got to set the gui_fullscreen variable before creating the
SDL2 window, otherwise the initial window will not be created in
fullscreen mode.
Buglink: https://bugs.launchpad.net/bugs/1780812
Signed-off-by: Thomas Huth
Message-id:
From: Thomas Huth
SDL_INIT_NOPARACHUTE is not used in SDL2 anymore, and the define is just
a dummy (see https://wiki.libsdl.org/MigrationGuide#Some_general_truths
for example). So we can remove it and get rid of the "flags" variable
nowadays.
Signed-off-by: Thomas Huth
Message-id:
From: Peter Wu
Fixes repeated memory leaks of 18 bytes when using VNC:
Direct leak of 831024 byte(s) in 46168 object(s) allocated from:
...
#4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514
#5 0x56085cdcf660 in buffer_init util/buffer.c:59
#6
On Mon, Aug 20, 2018 at 07:29:30PM +0200, Michal Prívozník wrote:
> On 08/20/2018 05:04 PM, Daniel P. Berrangé wrote:
> > On Mon, Aug 20, 2018 at 03:59:23PM +0100, Daniel P. Berrangé wrote:
> >> On Fri, Aug 17, 2018 at 10:49:12AM -0400, John Ferlan wrote:
> >>>
> >>>
> >>> On 08/14/2018 07:19 AM,
On Mon, Aug 20, 2018 at 07:13:46PM +0200, Michal Prívozník wrote:
> On 08/20/2018 05:07 PM, Daniel P. Berrangé wrote:
> > On Tue, Aug 14, 2018 at 01:19:42PM +0200, Michal Privoznik wrote:
> >> In order for our drivers to lock resources for metadata change we
> >> need set of new APIs. Fortunately,
On Tue, Aug 21, 2018 at 10:49:28AM +0200, Marc Hartmayer wrote:
> Truncate means that if a file exists it's length will be truncated to
> 0, but the mode and the owner shall be unchanged. The current behavior
> is that the original file is deleted and a new file is created. Let's
> fix this by
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into
staging (2018-08-20 17:41:18 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/ui-20180821-pull-request
for you
From: Philippe Mathieu-Daudé
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/round.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir . --in-place
Signed-off-by: Philippe Mathieu-Daudé
Message-Id:
From: Marc-André Lureau
Some scanouts during boot are top-down without it.
y0_top is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last
patch of this series.
In current QEMU code base, only vfio/display uses dmabuf API. But the
VFIO query interface doesn't provide or need that detail
From: Paolo Bonzini
The OpenGL-enabled SPICE code was not accessing the cursor position
under the SimpleSpiceDisplay lock. Fix this.
Signed-off-by: Paolo Bonzini
Reviewed-by: Marc-André Lureau
Message-id: 20180720063109.4631-2-pbonz...@redhat.com
Signed-off-by: Gerd Hoffmann
---
From: Marc-André Lureau
vhost-user-gpu will share the same code to open a DRM node.
Signed-off-by: Marc-André Lureau
Message-Id: <20180713130916.4153-20-marcandre.lur...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
include/qemu/drm.h | 6 +
ui/egl-helpers.c | 51
From: Paolo Bonzini
spice-display should not call the ui/console.c functions dpy_cursor_define
and dpy_moues_set with the SimpleSpiceDisplay lock taken. That will cause
a deadlock, because the DisplayChangeListener callbacks will take the lock
again. It is also in general a bad idea to invoke
From: Tao Wu via Qemu-devel
When scanout_mode enabled, surface is out of sync with actual screen.
In such case, we just call sdl2_gl_scanout_flush to do redraw. This
fixes bug reported in
https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html
Signed-off-by: Tao Wu
From: Daniel P. Berrangé
The use of 'tls', 'x509' and 'x509verify' properties is the deprecated
backcompat syntax, replaced by use of TLS creds objects.
Signed-off-by: Daniel P. Berrangé
Message-id: 20180725092751.21767-2-berra...@redhat.com
Signed-off-by: Gerd Hoffmann
---
qemu-doc.texi |
Truncate means that if a file exists it's length will be truncated to
0, but the mode and the owner shall be unchanged. The current behavior
is that the original file is deleted and a new file is created. Let's
fix this by using O_TRUNC.
The function virRotatingFileWriterDelete is now unused but
On Mon, 2018-08-20 at 18:52 +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1610072
>
> Due to historical reasons we were not parsing device info on
You spelled "hysterical raisins" wrong ;)
[...]
> -if (def->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
>
On Thu, 2018-08-16 at 12:28 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 16, 2018 at 12:56:24PM +0200, Simon Kobyda wrote:
> >
>
> After asking around I have found the right solution that we need to
> use
> for measuring string width. mbstowcs()/wcswidth() will get the
> answer
> wrong wrt
The "-balloon" option has been replaced by "-device virtio-balloon".
It's been marked as deprecated since two releases, and nobody
complained, so let's remove it now.
Signed-off-by: Thomas Huth
---
docs/virtio-balloon-stats.txt | 6 +++---
qemu-deprecated.texi | 5 -
On Tue, Aug 21, 2018 at 12:05:30PM +0200, Thomas Huth wrote:
> The "-balloon" option has been replaced by "-device virtio-balloon".
> It's been marked as deprecated since two releases, and nobody
> complained, so let's remove it now.
>
> Signed-off-by: Thomas Huth
> ---
>
On Tue, Aug 21, 2018 at 12:37:54PM +0200, Marc Hartmayer wrote:
> On Tue, Aug 21, 2018 at 11:03 AM +0200, "Daniel P. Berrangé"
> wrote:
> > On Tue, Aug 21, 2018 at 10:49:28AM +0200, Marc Hartmayer wrote:
> >> Truncate means that if a file exists it's length will be truncated to
> >> 0, but the
On 08/21/2018 01:15 PM, Andrea Bolognani wrote:
> On Tue, 2018-08-21 at 12:12 +0200, Michal Privoznik wrote:
>> void
>> -virDomainDeviceInfoClear(virDomainDeviceInfoPtr info)
>> +virDomainDeviceInfoClearAddress(virDomainDeviceInfoPtr info)
>> {
>> -VIR_FREE(info->alias);
>>
On Tue, 2018-08-21 at 13:45 +0200, Michal Privoznik wrote:
> On 08/21/2018 01:15 PM, Andrea Bolognani wrote:
> > On Tue, 2018-08-21 at 12:12 +0200, Michal Privoznik wrote:
> > > void
> > > -virDomainDeviceInfoClear(virDomainDeviceInfoPtr info)
> > >
Changes from [v1]:
* refresh after recent changes to the jobs.
[v1] https://www.redhat.com/archives/libvir-list/2018-August/msg00580.html
Andrea Bolognani (2):
projects: Add default machines for libvirt-dbus
projects: Document rationale for skipping jobs
projects/libvirt-dbus.yaml|
In general, we strive for full coverage and build all
projects on all targets; however, in some cases that's
simply not feasible and we have to skip the corresponding
job. Document the rationale for each such case.
Signed-off-by: Andrea Bolognani
---
projects/libvirt-dbus.yaml| 3 +++
This doesn't change the results but brings it more in line
with how other projects are defined and will help us out
later.
Signed-off-by: Andrea Bolognani
---
projects/libvirt-dbus.yaml | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
On Tue, Aug 21, 2018 at 11:03 AM +0200, "Daniel P. Berrangé"
wrote:
> On Tue, Aug 21, 2018 at 10:49:28AM +0200, Marc Hartmayer wrote:
>> Truncate means that if a file exists it's length will be truncated to
>> 0, but the mode and the owner shall be unchanged. The current behavior
>> is that the
There is no known available OS for ppc around anymore that uses page
sizes below 4k, so it does not make much sense that we keep wasting
our time on building and testing the ppcemb-softmmu target. It has
been deprecated since two releases, and nobody complained, so let's
remove this now.
On Tue, 2018-08-21 at 11:01 +0200, Andrea Bolognani wrote:
> On Mon, 2018-08-20 at 18:52 +0200, Michal Privoznik wrote:
> [...]
> > -if (def->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
> > -def->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD) {
> > -
It was found that in cases with host devices virProcessKillPainfully
might be able to send signal zero to the target PID for quite a while
with the process already being gone from /proc/.
That is due to cleanup and reset of devices which might include a
secondary bus reset that on top of the
In cases where virProcessKillPainfully already reailizes that
SIGTERM wasn't enough we are partially on a bad path already.
Maybe the system is overloaded or having serious trouble to free and
reap resources in time.
In those case give the SIGKILL that was sent after 10 seconds some more
time to
Hi,
after a good discussion a few days ago in
https://www.redhat.com/archives/libvir-list/2018-August/msg00122.html
and a short lived but back then untested v2 in
https://www.redhat.com/archives/libvir-list/2018-August/msg00199.html
I finally get access to the right HW again and completed the
On 21/08/2018 12:05, Thomas Huth wrote:
> The "-balloon" option has been replaced by "-device virtio-balloon".
> It's been marked as deprecated since two releases, and nobody
> complained, so let's remove it now.
>
> Signed-off-by: Thomas Huth
> ---
> docs/virtio-balloon-stats.txt | 6 +++---
>
v2 of:
https://www.redhat.com/archives/libvir-list/2018-August/msg01208.html
diff to v1:
- did what Andrea suggested
Michal Prívozník (2):
device_conf: Split virDomainDeviceInfoClear
conf: Parse guestfwd channel device info again
src/conf/device_conf.c | 10 --
Some callers might want to clear the address but not the alias.
Split the virDomainDeviceInfoClear() function to allow that.
Signed-off-by: Michal Privoznik
---
src/conf/device_conf.c | 10 --
src/conf/device_conf.h | 1 +
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git
On 08/21/2018 11:18 AM, Simon Kobyda wrote:
> On Thu, 2018-08-16 at 12:28 +0100, Daniel P. Berrangé wrote:
>> On Thu, Aug 16, 2018 at 12:56:24PM +0200, Simon Kobyda wrote:
>>>
>>
>> After asking around I have found the right solution that we need to
>> use
>> for measuring string width.
On Tue, Aug 14, 2018 at 11:27:33AM +0200, Christian Ehrhardt wrote:
> It was found that in cases with host devices virProcessKillPainfully
> might be able to send signal zero to the target PID for quite a while
> with the process already being gone from /proc/.
>
> That is due to cleanup and
On Tue, Aug 21, 2018 at 12:38:05PM +0200, Andrea Bolognani wrote:
> This doesn't change the results but brings it more in line
> with how other projects are defined and will help us out
> later.
>
> Signed-off-by: Andrea Bolognani
> ---
> projects/libvirt-dbus.yaml | 16
> 1
On Tue, 2018-08-21 at 12:12 +0200, Michal Privoznik wrote:
> void
> -virDomainDeviceInfoClear(virDomainDeviceInfoPtr info)
> +virDomainDeviceInfoClearAddress(virDomainDeviceInfoPtr info)
> {
> -VIR_FREE(info->alias);
> memset(>addr, 0, sizeof(info->addr));
> info->type =
On Tue, Aug 14, 2018 at 11:27:34AM +0200, Christian Ehrhardt wrote:
> In cases where virProcessKillPainfully already reailizes that
> SIGTERM wasn't enough we are partially on a bad path already.
> Maybe the system is overloaded or having serious trouble to free and
> reap resources in time.
>
>
From: Thomas Huth
We've got to set the gui_fullscreen variable before creating the
SDL2 window, otherwise the initial window will not be created in
fullscreen mode.
Buglink: https://bugs.launchpad.net/bugs/1780812
Signed-off-by: Thomas Huth
Message-id:
From: Marc-André Lureau
Some scanouts during boot are top-down without it.
y0_top is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last
patch of this series.
In current QEMU code base, only vfio/display uses dmabuf API. But the
VFIO query interface doesn't provide or need that detail
On Tue, Aug 21, 2018 at 11:45:20AM +0200, Paolo Bonzini wrote:
> On 21/08/2018 09:45, Gerd Hoffmann wrote:
> > +qemu_mutex_lock(>lock);
> > if (ssd->cursor) {
> > +QEMUCursor *c = ssd->cursor;
> > assert(ssd->dcl.con);
> > +cursor_get(c);
> > +
On Tue, Aug 21, 2018 at 02:33:25PM +0200, Christian Ehrhardt wrote:
> It was found that in cases with host devices virProcessKillPainfully
> might be able to send signal zero to the target PID for quite a while
> with the process already being gone from /proc/.
>
> That is due to cleanup and
On Tue, Aug 21, 2018 at 12:05:30PM +0200, Thomas Huth wrote:
> The "-balloon" option has been replaced by "-device virtio-balloon".
> It's been marked as deprecated since two releases, and nobody
> complained, so let's remove it now.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Michael S.
On Tue, Aug 21, 2018 at 12:27:34PM +0200, Michal Privoznik wrote:
> On 08/21/2018 11:18 AM, Simon Kobyda wrote:
> > On Thu, 2018-08-16 at 12:28 +0100, Daniel P. Berrangé wrote:
> >> On Thu, Aug 16, 2018 at 12:56:24PM +0200, Simon Kobyda wrote:
> >>>
> >>
> >> After asking around I have found the
On Tue, 2018-08-21 at 12:12 +0200, Michal Privoznik wrote:
[...]
> if (def->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
> -def->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD) {
> -VIR_DEBUG("Ignoring device address for gustfwd channel");
> -} else if
在 2018/8/21 下午7:00, Andrea Bolognani 写道:
On Tue, 2018-08-21 at 17:35 +0800, Yi Min Zhao wrote:
I want to ask a question. For pci address, any pci device can't use slot 0.
Is that a reason why PCI part could treat all zeros as empty address?
A PCI address where all attributes are zero can't
On Tue, Aug 21, 2018 at 1:16 PM Daniel P. Berrangé
wrote:
> On Tue, Aug 14, 2018 at 11:27:34AM +0200, Christian Ehrhardt wrote:
> > In cases where virProcessKillPainfully already reailizes that
> > SIGTERM wasn't enough we are partially on a bad path already.
> > Maybe the system is overloaded
On 08/21/2018 02:15 PM, Andrea Bolognani wrote:
> On Tue, 2018-08-21 at 11:01 +0200, Andrea Bolognani wrote:
>> On Mon, 2018-08-20 at 18:52 +0200, Michal Privoznik wrote:
>> [...]
>>> -if (def->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
>>> -def->targetType ==
On Tue, Aug 21, 2018 at 02:20:21PM +0200, Christian Ehrhardt wrote:
> On Tue, Aug 21, 2018 at 1:15 PM Daniel P. Berrangé
> wrote:
>
> > On Tue, Aug 14, 2018 at 11:27:33AM +0200, Christian Ehrhardt wrote:
> > > It was found that in cases with host devices virProcessKillPainfully
> > > might be
On Tue, 2018-08-21 at 19:55 +0800, Yi Min Zhao wrote:
> 在 2018/8/21 下午7:00, Andrea Bolognani 写道:
> > On Tue, 2018-08-21 at 17:35 +0800, Yi Min Zhao wrote:
> > > I want to ask a question. For pci address, any pci device can't use slot
> > > 0.
> > > Is that a reason why PCI part could treat all
On Tue, 21 Aug 2018 12:05:30 +0200
Thomas Huth wrote:
> The "-balloon" option has been replaced by "-device virtio-balloon".
> It's been marked as deprecated since two releases, and nobody
> complained, so let's remove it now.
>
> Signed-off-by: Thomas Huth
> ---
>
https://bugzilla.redhat.com/show_bug.cgi?id=1610072
Due to historical reasons we were not parsing device info on
guestfwd channel. Sure, it doesn't make much sense to parse
but it surely makes sense to parse its alias (which
might be an user alias).
This partially reverts commit
On Tue, 2018-08-21 at 17:35 +0800, Yi Min Zhao wrote:
> I want to ask a question. For pci address, any pci device can't use slot 0.
> Is that a reason why PCI part could treat all zeros as empty address?
A PCI address where all attributes are zero can't be used, so
there's no ambiguity there;
On Tue, Aug 21, 2018 at 12:38:06PM +0200, Andrea Bolognani wrote:
> In general, we strive for full coverage and build all
> projects on all targets; however, in some cases that's
> simply not feasible and we have to skip the corresponding
> job. Document the rationale for each such case.
>
>
On Tue, 2018-08-21 at 13:21 +0200, Erik Skultety wrote:
> On Tue, Aug 21, 2018 at 12:38:06PM +0200, Andrea Bolognani wrote:
> > In general, we strive for full coverage and build all
> > projects on all targets; however, in some cases that's
> > simply not feasible and we have to skip the
From: Peter Wu
Fixes repeated memory leaks of 18 bytes when using VNC:
Direct leak of 831024 byte(s) in 46168 object(s) allocated from:
...
#4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514
#5 0x56085cdcf660 in buffer_init util/buffer.c:59
#6
From: Marc-André Lureau
Minor code simplification.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-id: 20180801092508.4927-1-marcandre.lur...@redhat.com
Signed-off-by: Gerd Hoffmann
---
qemu-keymap.c | 2 +-
ui/console.c | 6 +++---
2 files changed, 4 insertions(+),
From: Paolo Bonzini
spice-display should not call the ui/console.c functions dpy_cursor_define
and dpy_moues_set with the SimpleSpiceDisplay lock taken. That will cause
a deadlock, because the DisplayChangeListener callbacks will take the lock
again. It is also in general a bad idea to invoke
From: Marc-André Lureau
vhost-user-gpu will share the same code to open a DRM node.
Signed-off-by: Marc-André Lureau
Message-Id: <20180713130916.4153-20-marcandre.lur...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
include/qemu/drm.h | 6 +
ui/egl-helpers.c | 51
From: Paolo Bonzini
The OpenGL-enabled SPICE code was not accessing the cursor position
under the SimpleSpiceDisplay lock. Fix this.
Signed-off-by: Paolo Bonzini
Reviewed-by: Marc-André Lureau
Message-id: 20180720063109.4631-2-pbonz...@redhat.com
Signed-off-by: Gerd Hoffmann
---
From: Daniel P. Berrangé
The use of 'tls', 'x509' and 'x509verify' properties is the deprecated
backcompat syntax, replaced by use of TLS creds objects.
Signed-off-by: Daniel P. Berrangé
Message-id: 20180725092751.21767-2-berra...@redhat.com
Signed-off-by: Gerd Hoffmann
---
qemu-doc.texi |
From: Philippe Mathieu-Daudé
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/round.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir . --in-place
Signed-off-by: Philippe Mathieu-Daudé
Message-Id:
From: Daniel P. Berrangé
The 'tls-creds' option accepts the name of a TLS credentials
object. This replaced the usage of 'tls', 'x509' and 'x509verify'
options in 2.5.0. These deprecated options were grandfathered in
when the deprecation policy was introduded in 2.10.0, so can now
finally be
From: Thomas Huth
SDL_INIT_NOPARACHUTE is not used in SDL2 anymore, and the define is just
a dummy (see https://wiki.libsdl.org/MigrationGuide#Some_general_truths
for example). So we can remove it and get rid of the "flags" variable
nowadays.
Signed-off-by: Thomas Huth
Message-id:
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into
staging (2018-08-20 17:41:18 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/ui-20180821-v2-pull-request
From: Tao Wu via Qemu-devel
When scanout_mode enabled, surface is out of sync with actual screen.
In such case, we just call sdl2_gl_scanout_flush to do redraw. This
fixes bug reported in
https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html
Signed-off-by: Tao Wu
On Tue, Aug 21, 2018 at 1:15 PM Daniel P. Berrangé
wrote:
> On Tue, Aug 14, 2018 at 11:27:33AM +0200, Christian Ehrhardt wrote:
> > It was found that in cases with host devices virProcessKillPainfully
> > might be able to send signal zero to the target PID for quite a while
> > with the process
https://bugzilla.redhat.com/show_bug.cgi?id=1619625
--all option is added to cmdDomblkinfo since commit 62c39193 allowing to
show all block devices info. Remove its 'goto cleanup' part in case it breaks
the loop of domblkinfo for all disks. Remove unnecessary variables and the
condition part
The comments were accurate but misplaced. Fix that.
Signed-off-by: Andrea Bolognani
---
Pushed as somewhat embarrassing and utterly trivial.
projects/libvirt-dbus.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/projects/libvirt-dbus.yaml
Em ter, 21 de ago de 2018 às 00:28, Han Han escreveu:
>
>
>
> On Tue, Aug 21, 2018 at 10:34 AM, Julio Faracco wrote:
>>
>> This serie adds a new function into QEMU Guest Agent handlers to use
>> the QEMU command 'guest-get-host-name' to retrieve the domain hostname.
>> This approach requires
> From: Wang, Zhi A
> Sent: Wednesday, August 22, 2018 2:43 AM
> >
> > Are there any suggestions how we can deal with security issues?
> > Allowing userspace to provide a data stream representing the internal
> > state of a virtual device model living within the kernel seems
> > troublesome. If
This serie adds a new function into QEMU Guest Agent handlers to use
the QEMU command 'guest-get-host-name' to retrieve the domain hostname.
This approach requires QEMU-GA running inside the guest, but it is the
fastest and easiest way to get this info.
Julio Faracco (2):
qemu: implementing
This commit implements the function qemuAgentGetHostname() that uses
the QEMU command 'guest-get-host-name' to retrieve the guest hostname
of Virtual Machine. It is a possibility where QEMU-GA is running.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_agent.c | 39
This commit add the support to use the function qemuAgentGetHostname()
for obtain the domain hostname using QEMU-GA command.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_driver.c | 40
1 file changed, 40 insertions(+)
diff --git
在 2018/8/20 下午7:14, Andrea Bolognani 写道:
On Mon, 2018-08-20 at 16:45 +0800, Yi Min Zhao wrote:
在 2018/8/17 上午12:31, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
+virBufferAddLit(, "zpci");
+virBufferAsprintf(, ",uid=%u", dev->addr.pci.zpci->zpci_uid);
+
Em seg, 20 de ago de 2018 às 23:35, Julio Faracco
escreveu:
>
> This commit implements the function qemuAgentGetHostname() that uses the
> QEMU command 'guest-get-host-name' to retrieve the guest hostname of
> Virtual Machine. It is a possibility where QEMU-GA is running.
>
> Signed-off-by: Julio
> From: Alex Williamson [mailto:alex.william...@redhat.com]
> Sent: Wednesday, August 22, 2018 10:08 AM
>
> On Wed, 22 Aug 2018 01:27:05 +
> "Tian, Kevin" wrote:
>
> > > From: Wang, Zhi A
> > > Sent: Wednesday, August 22, 2018 2:43 AM
> > > >
> > > > Are there any suggestions how we can
On Wed, 22 Aug 2018 01:27:05 +
"Tian, Kevin" wrote:
> > From: Wang, Zhi A
> > Sent: Wednesday, August 22, 2018 2:43 AM
> > >
> > > Are there any suggestions how we can deal with security issues?
> > > Allowing userspace to provide a data stream representing the internal
> > > state of a
在 2018/8/17 上午12:06, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+static inline bool
+virDeviceInfoPCIAddressExtensionPresent(const virDomainDeviceInfo *info)
+{
+return info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
+info->addr.pci.zpci;
The former documentation was an unhelpful tautology. The suggested doc
mimicks^Wcopies the one of virDomainSetAutostart.
Signed-off-by: Dan Kenigsberg
---
src/libvirt-storage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c
On 08/17/2018 06:35 AM, Andrea Bolognani wrote:
> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote:
>> On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote:
>>> 5) Some guest OSes that we still want to support (and which would
>>> otherwise work okay on a Q35 virtual machine)
Fixes:
https://www.redhat.com/archives/libvir-list/2017-January/msg00978.html
QEMU is probed through monitor fd to check capabilities during libvirtd init.
The monitor fd is closed after probing by virQEMUCapsInitQMPCommandFree
that calls virQEMUCapsInitQMPCommandAbort that calls
libvirt affinity wrappers don't support macOS Thread Affinity API:
https://developer.apple.com/library/archive/releasenotes/Performance/RN-AffinityAPI/index.html
virProcessSetAffinity stub prevents libvirt from starting a qemu domain
on macOS:
$ virsh start vm
error: Failed to start domain vm
On 08/21/18 07:08, Alex Williamson wrote:
On Sun, 19 Aug 2018 22:25:19 +0800
Zhi Wang wrote:
Share some updates of my work on this topic recently:
Thanks for Erik's guide and advices. Now my PoC patches almost works.
Will send the RFC soon.
Mostly the ideas are based on Alex's idea: a
https://bugzilla.redhat.com/show_bug.cgi?id=1611320
Generation of the ACL API policy is a "automated process"
based on this perl script which "worked" with the changes to
add nwfilter binding API's because they had the "nwfilter"
prefix; however, the generated output name was incorrect
based on
On Tue, Aug 21, 2018 at 21:23:42 +0800, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1619625
>
> --all option is added to cmdDomblkinfo since commit 62c39193 allowing to
> show all block devices info. Remove its 'goto cleanup' part in case it breaks
> the loop of domblkinfo for
https://bugzilla.redhat.com/show_bug.cgi?id=1613737
When processing the inputvol for encryption, we need to handle
the case where the inputvol is encrypted. This then allows for
the encrypted inputvol to be used either for an output encrypted
volume or an output volume of some XML provided type.
There's really no need for it to be there since it's only ever
used inside virStorageBackendCreateQemuImgCmdFromVol
Signed-off-by: John Ferlan
---
src/storage/storage_util.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/storage/storage_util.c
On Tue, Aug 21, 2018 at 2:34 PM Christian Ehrhardt <
christian.ehrha...@canonical.com> wrote:
> Hi,
> after a good discussion a few days ago in
> https://www.redhat.com/archives/libvir-list/2018-August/msg00122.html
> and a short lived but back then untested v2 in
>
https://bugzilla.redhat.com/show_bug.cgi?id=1613737
Details in the patches (and even more in the bz).
John Ferlan (3):
storage: Remove secretPath from _virStorageBackendQemuImgInfo
storage: Allow for inputvol to have any format for encryption
storage: Allow inputvol to be encrypted
Commit 39cef12a9 altered/fixed the inputvol processing to create
a multistep process when using an inputvol to create an encrypted
output volume; however, it unnecessarily assumed/restricted the
inputvol to be of 'raw' format only.
Modify the processing code to allow the inputvol format to be
On Tue, Aug 21, 2018 at 01:40:49PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-08-21 at 13:21 +0200, Erik Skultety wrote:
> > On Tue, Aug 21, 2018 at 12:38:06PM +0200, Andrea Bolognani wrote:
> > > In general, we strive for full coverage and build all
> > > projects on all targets; however, in
99 matches
Mail list logo