On Thu, Aug 23, 2018 at 10:50:34AM +0200, Peter Krempa wrote:
> Some things were moved. Try to update the paths.
"Do. Or do not. There's no try." ;)
>
> Signed-off-by: Peter Krempa
> ---
> docs/api_extension.html.in | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff
On Thu, 2018-08-23 at 14:36 +0200, Erik Skultety wrote:
> On Wed, Aug 22, 2018 at 11:44:25AM +0200, Andrea Bolognani wrote:
> > Building master is useful for CI purposes and to debug CI
> > failures locally, but when developing we want to be able
> > to build a personal branch to validate
On 08/20/2018 07:17 PM, Michal Prívozník wrote:
> On 08/20/2018 05:16 PM, Daniel P. Berrangé wrote:
>> On Tue, Aug 14, 2018 at 01:19:43PM +0200, Michal Privoznik wrote:
>>> Fortunately, we have qemu wrappers so it's sufficient to put
>>> lock/unlock call only there.
>>>
>>> Signed-off-by: Michal
On Thu, Aug 23, 2018 at 05:45:42PM +0200, Michal Privoznik wrote:
> On 08/23/2018 05:01 PM, Daniel P. Berrangé wrote:
> > On Thu, Aug 23, 2018 at 04:54:01PM +0200, Michal Privoznik wrote:
> >> On 08/20/2018 07:17 PM, Michal Prívozník wrote:
> >>> On 08/20/2018 05:16 PM, Daniel P. Berrangé wrote:
>
On Thu, Aug 23, 2018 at 04:54:01PM +0200, Michal Privoznik wrote:
> On 08/20/2018 07:17 PM, Michal Prívozník wrote:
> > On 08/20/2018 05:16 PM, Daniel P. Berrangé wrote:
> >> On Tue, Aug 14, 2018 at 01:19:43PM +0200, Michal Privoznik wrote:
> >>> Fortunately, we have qemu wrappers so it's
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> Signed-off-by: Lubomir Rintel
> ---
> src/qemu/qemu_domain_address.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
> index
On Thu, Aug 23, 2018 at 10:50:30AM +0200, Peter Krempa wrote:
The pathches used as an example for the api_extension manual don't hold
*patches, as Erik pointed out
up to the current standards any more. Carefully remove links and
mentions of the patches from the docs.
Signed-off-by: Peter
On Wed, Aug 15, 2018 at 13:52:51 +0200, Peter Krempa wrote:
> Remove handling of errors which QEMU no longer reports and rename
> fields so that it conforms with the new semantics.
>
> Peter Krempa (8):
> qemu: monitor: Remove error classes not conforming to QAPI schema
> qemu: monitor: Use
On Thu, Aug 23, 2018 at 03:55:16PM +0200, Peter Krempa wrote:
> On Thu, Aug 23, 2018 at 15:46:30 +0200, Erik Skultety wrote:
> > On Thu, Aug 23, 2018 at 10:50:30AM +0200, Peter Krempa wrote:
> > > The pathches used as an example for the api_extension manual don't hold
> >
> > s/pathches/patches
>
On Wed, Aug 15, 2018 at 11:18:37 +0200, Peter Krempa wrote:
> Diff to v1:
> - stopped probing for active block-commit support when we can use QMP
> schema
> - qemuxml2argvmock's implementation of virCommandPassFD now passes
> through specific file descriptors and ignores the rest.
Ping?
On Thu, Aug 23, 2018 at 03:59:26PM +0200, Peter Krempa wrote:
> On Thu, Aug 23, 2018 at 15:25:17 +0200, Erik Skultety wrote:
> > On Thu, Aug 23, 2018 at 10:50:33AM +0200, Peter Krempa wrote:
> > > It probably does not make sense to do tests using that toolkit any more.
> >
> > At first I thought
On Thu, Aug 23, 2018 at 03:14:38PM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 23, 2018 at 03:55:16PM +0200, Peter Krempa wrote:
> > On Thu, Aug 23, 2018 at 15:46:30 +0200, Erik Skultety wrote:
> > > On Thu, Aug 23, 2018 at 10:50:30AM +0200, Peter Krempa wrote:
> > > > The pathches used as an
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> It's ARM specific.
>
> Signed-off-by: Lubomir Rintel
> ---
> src/qemu/qemu_capabilities.c | 4 ++--
> src/qemu/qemu_command.c| 4 ++--
> src/qemu/qemu_domain.c | 16
> src/qemu/qemu_domain.h
On 08/23/2018 05:01 PM, Daniel P. Berrangé wrote:
> On Thu, Aug 23, 2018 at 04:54:01PM +0200, Michal Privoznik wrote:
>> On 08/20/2018 07:17 PM, Michal Prívozník wrote:
>>> On 08/20/2018 05:16 PM, Daniel P. Berrangé wrote:
On Tue, Aug 14, 2018 at 01:19:43PM +0200, Michal Privoznik wrote:
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> Signed-off-by: Lubomir Rintel
> ---
> src/qemu/qemu_domain_address.c | 16
> 1 file changed, 16 insertions(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> Signed-off-by: Lubomir Rintel
> ---
> src/qemu/qemu_domain.c | 22 ++
> src/qemu/qemu_domain.h | 3 +++
> 2 files changed, 25 insertions(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat /
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
A short not explaining why you need to do this, along the lines of
We're going to need to assign virtio-mmio addresses to non-ARM
guests soon, so let's create a generic wrapper that calls to
the architecture-specific implementation.
Add necessary checks in order to allow setting sgio values for a scsi
host device.
Signed-off-by: John Ferlan
---
src/qemu/qemu_conf.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index
On Thu, Aug 23, 2018 at 15:25:17 +0200, Erik Skultety wrote:
> On Thu, Aug 23, 2018 at 10:50:33AM +0200, Peter Krempa wrote:
> > It probably does not make sense to do tests using that toolkit any more.
>
> At first I thought so too, I even thought that there hasn't been any commits
> to
> the
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> +VIR_ARCH_RISCV32, /* RISC-V 64 LE
> http://en.wikipedia.org/wiki/RISC-V */
This should be 32 LE ...
> +VIR_ARCH_RISCV64, /* RISC-V 32 BE
> http://en.wikipedia.org/wiki/RISC-V
On Thu, Aug 23, 2018 at 03:19:39PM +0200, Michal Privoznik wrote:
> On 08/22/2018 07:42 PM, Simon Kobyda wrote:
> > It solves problems with alignment of columns. Width of each column
> > is calculated by its biggest cell. Should solve unicode bug.
> > In future, it may be implemented in virsh,
On Thu, Aug 23, 2018 at 03:55:16PM +0200, Peter Krempa wrote:
> On Thu, Aug 23, 2018 at 15:46:30 +0200, Erik Skultety wrote:
> > On Thu, Aug 23, 2018 at 10:50:30AM +0200, Peter Krempa wrote:
> > > The pathches used as an example for the api_extension manual don't hold
> >
> > s/pathches/patches
>
On Thu, 2018-08-23 at 15:19 +0200, Michal Privoznik wrote:
> NB, do we need to re-encode the string? All that we care about is its
> width, isn't it?
Yes. Many nonprintable or control characters such as tabulator,
vertical tabulator, backspace... would be problematic, especially when
calculating
For now, there are 9 test cases
- testVshTableNew: Creating table with empty header
- testVshTableHeader: Printing table with/without header
- testVshTableRowAppend: Appending row with various number of cells.
Only row with same number of cells as in header is accepted.
- testUnicode: Printing
It solves problems with alignment of columns. Width of each column
is calculated by its biggest cell. Should solve unicode bug.
In future, it may be implemented in virsh, virt-admin...
This API has 5 public functions:
- vshTableNew - adds new table and defines its header
- vshTableRowAppend -
In what is perhaps a couple lifetimes ago at this point, patches
were posted and "mostly" all eventually accepted upstream to support
unpriv_sgio on SCSI generic hostdev devices. Since the needed parts
of the functionality from the kernel perspective were not yet present
upstream, a couple of the
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Introduce a few variables so that we can easily access the modifier
> character and also don't have to do pointer aritmetics when selecting
arithmetic
> the schema entries. This will simplify adding of new modifier
> characters.
>
>
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Add a new modifier character which will select given schema entry only
> when it is optional.
>
So when the object has a "*" modifier, then we need to ...?
And the check for the "default" key means what? Is it only ever present
when "*" is the
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
[...]
> * Dropped:
> qemu: no USB by default on RISC-V machines
> (not sure why I thought this was needed)
I won't hold up the series because of it - in fact I intend to
push it as soon as you have given me feedback for the few
Eduardo Habkost writes:
> On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote:
>> On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote:
>> > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote:
>> > > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote:
>>
On 08/20/2018 02:27 AM, Shivaprasad G Bhat wrote:
> The vol-dumpxml shows the volume target format type as raw for
> encrypted volumes. The error message when attempting to resize
> with prealloc is confusing here.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
> src/storage/storage_util.c |
With the current implementation, adding a new architecture
and not updating preferredMachines accordingly will not
cause a build failure, making it very likely that subtle
bugs will be introduced in the process. Rework the code
so that such issues will be caught by the compiler.
Signed-off-by:
On Thu, 2018-08-23 at 17:43 +0200, Andrea Bolognani wrote:
> On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
>
> A short not explaining why you need to do this, along the lines of
>
> We're going to need to assign virtio-mmio addresses to non-ARM
> guests soon, so let's create a
On 08/23/2018 05:51 PM, Daniel P. Berrangé wrote:
> On Thu, Aug 23, 2018 at 05:45:42PM +0200, Michal Privoznik wrote:
>> On 08/23/2018 05:01 PM, Daniel P. Berrangé wrote:
>>> On Thu, Aug 23, 2018 at 04:54:01PM +0200, Michal Privoznik wrote:
On 08/20/2018 07:17 PM, Michal Prívozník wrote:
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
[...]
> +
> +
> + qemu: Add support for RISC-V guests
> +
> +
> + riscv32 and riscv64 guest architectures are now supported.
> +
> +
Bit terse, but okay :)
Reviewed-by: Andrea
On Thu, Aug 23, 2018 at 06:08:55PM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote:
> >> On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote:
> >> > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea
On Thu, Aug 23, 2018 at 05:26:47PM +0100, Daniel P. Berrangé wrote:
[...]
> There are countless mistakes in both QEMU & libvirt, but only some of
> them are worth the cost of changing. I'm not seeing a compelling reason
> why this change is worthwhile. The impact of the design mistake is narrow
>
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> For versions where we can probe that the arguments are optional we can
> perform the probing by a schema query rather than sending a separate
> command to do so.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c
Check if the hostdev has set the sgio filtered/unfiltered and handle
appropriately.
This restores functionality removed by commit id 'ce346623' to remove
sgio support for the SCSI generic host device in the formerly named
method qemuCheckSharedDevice.
For most kernels the result of this
Instead of printing it straight in virsh, it creates table struct
which is filled with header and rows(domains). It allows us to know
more about table before printing to calculate alignment right.
Signed-off-by: Simon Kobyda
---
tests/virshtest.c| 14 ++--
Created new API for priting tables, mainly to solve alignment problems.
Implemented these test to virsh list. In the future, API may be
everywhere in virsh and virt-admin.
Also wrote basic tests for the new API, and corrected tests in virshtest
which are influenced by implementation of the API in
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Split it into a function that returns the whole schema entry so that we
> can do additional checks and a helper getting the type string from the
> schema entry.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_qapi.c | 51
On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> Signed-off-by: Lubomir Rintel
> ---
> tests/capabilityschemadata/caps-qemu-kvm.xml |36 +
> .../caps_3.0.0.riscv32.replies| 14819
> .../caps_3.0.0.riscv32.xml| 118 +
>
On Thu, Aug 23, 2018 at 15:46:30 +0200, Erik Skultety wrote:
> On Thu, Aug 23, 2018 at 10:50:30AM +0200, Peter Krempa wrote:
> > The pathches used as an example for the api_extension manual don't hold
>
> s/pathches/patches
>
> > up to the current standards any more. Carefully remove links and
>
On Thu, Aug 23, 2018 at 10:50:30AM +0200, Peter Krempa wrote:
> The pathches used as an example for the api_extension manual don't hold
s/pathches/patches
> up to the current standards any more. Carefully remove links and
> mentions of the patches from the docs.
While I understand the impetus
On Thu, Aug 23, 2018 at 10:50:31AM +0200, Peter Krempa wrote:
> Now that they are not linked any more remove them.
See my comment in previous patch.
Erik
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Aug 23, 2018 at 10:50:31AM +0200, Peter Krempa wrote:
Now that they are not linked any more remove them.
Signed-off-by: Peter Krempa
---
docs/Makefile.am | 4 +-
docs/api_extension/0001-add-to-xml.patch | 145
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> All supported qemus support FD passing so modify the tests to test the
> proper code path.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemuxml2argvdata/tpm-passthrough-crb.args | 5 +++--
> tests/qemuxml2argvdata/tpm-passthrough.args | 5
Eduardo Habkost writes:
> On Thu, Aug 23, 2018 at 05:26:47PM +0100, Daniel P. Berrangé wrote:
> [...]
>> There are countless mistakes in both QEMU & libvirt, but only some of
>> them are worth the cost of changing.
Agreed.
>> I'm not seeing a compelling
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Allow mocking of the file descriptor numbers used for the TPM
> passthrough mode by extracting the relevant code into an exported
> function.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_command.c | 41
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> The API does not report any special job-related error so the generic
> error function should be used.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor_json.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by:
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Report the generic errors using the existing function so that we don't
> reimplement the same functionality multiple times.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor_json.c | 27 +--
> 1 file changed, 9
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Now that the job name is used in single place in the respective
> functions remove the temporary strings.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor_json.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Split up for simpler reviews.
thanks! it helped.
> ---
> .../caps_2.10.0.aarch64.replies| 148
> .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 148
>
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Allow FDs which are marked as safe for FD passing.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemuxml2argvmock.c | 22 ++
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
Reviewed-by: John Ferlan
John
--
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> The capability was usable since qemu 1.3 so we can remove all the
> detection code.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 17
> src/qemu/qemu_capabilities.h
On 08/15/2018 05:18 AM, Peter Krempa wrote:
> Split up for simpler reviews.
> ---
> .../qemucapabilitiesdata/caps_1.5.3.x86_64.replies | 152
> .../qemucapabilitiesdata/caps_1.6.0.x86_64.replies | 152
> .../qemucapabilitiesdata/caps_1.7.0.x86_64.replies | 152
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Both were removed prior to qemu v1.2.0-rc0 when switching to the new
> error format where almost all error types were converted to GenericError.
>
> Relevant qemu commits are and
>
> Signed-off-by: Peter Krempa
> ---
>
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> The API deals with a block job so use the common error reporting
> function for it.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor_json.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Very strange - this got applied
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Extract the code used to probe for the functionality so that it does not
> litter the code used for actual work.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor.c | 2 +-
> src/qemu/qemu_monitor_json.c | 58
>
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Move all relevant APIs dealing with existing jobs together.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor_json.c | 55
> ++--
> 1 file changed, 28 insertions(+), 27 deletions(-)
>
On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Starting from qemu 2.7 the 'device' argument is in fact a name of the
> job itself. Change our APIs accordingly and adjust the error message.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor.c | 18 +-
>
On Wed, Aug 22, 2018 at 03:25:31PM -0500, Eric Blake wrote:
> We have an inconsistent mix of multi-word file names that use dash vs.
> underscore to separate those words.
>
> $ git ls-files '**/*_*' | wc
>24972497 146485
> $ git ls-files '**/*-*' | wc
>81478147 26
>
> Some
On Wed, 2018-08-22 at 19:42 +0200, Simon Kobyda wrote:
> It solves problems with alignment of columns. Width of each column
> is calculated by its biggest cell. Should solve unicode bug.
> In future, it may be implemented in virsh, virt-admin...
>
> This API has 5 public functions:
> -
On Wed, 2018-08-22 at 15:25 -0500, Eric Blake wrote:
[...]
> So, would anyone like a beginner's project of consistently renaming
> files, and/or would anyone object if I submitted some patches along
> those lines?
I like the idea. Consistency FTW!
After the switch, we should make sure
On Thu, Aug 23, 2018 at 01:54:46AM +0300, Roman Bolshakov wrote:
> On Wed, Aug 22, 2018 at 10:41:18AM +0100, Daniel P. Berrangé wrote:
> > I don't think we should go through the dispatch code when
> > we get EBADF, as the contents of the 'revents' fields are
> > undefined after we get an error.
>
On Thu, 2018-08-23 at 14:40 +0800, Yi Min Zhao wrote:
> 在 2018/8/22 下午6:09, Andrea Bolognani 写道:
> > On Wed, 2018-08-22 at 17:39 +0800, Yi Min Zhao wrote:
> > > I tried as your idea. It makes everything complicated, especially
> > > alloc/reserve/release
> > > zpci address. If the user defines
On Wed, Aug 22, 2018 at 04:30:40PM -0300, Eduardo Lúcio Amorim Costa wrote:
> I'm trying create a virtual machine using Xen as hypervisor and
> virt-manager (libvirt) as the management module. When trying to create the
> virtual machine I am getting the following error:
>
> "
> Unable to complete
在 2018/8/22 下午6:09, Andrea Bolognani 写道:
On Wed, 2018-08-22 at 17:39 +0800, Yi Min Zhao wrote:
在 2018/8/21 下午9:19, Andrea Bolognani 写道:
On Tue, 2018-08-21 at 19:55 +0800, Yi Min Zhao wrote:
For zPCI address, if we use the same strategy as PCI part and user
wants to assign fid=0 to the
Fix logical error in v2:
https://www.redhat.com/archives/libvir-list/2018-August/msg01358.html
https://bugzilla.redhat.com/show_bug.cgi?id=1619625
--all option is added to cmdDomblkinfo since commit 62c39193 allowing to
show all block devices info. Reset error when empty source in case error
On Wed, Aug 22, 2018 at 05:43:21PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1607202
>
> It's stated that if the admin wants to shoot themselves in
> the foot by removing the nwfilter binding while the domain
> is running we will certainly allow that. However, in
Save us hassle in the list if anybody would read this.
Signed-off-by: Peter Krempa
---
docs/api_extension.html.in | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in
index b473d09b17..d2c7fd6cfb 100644
---
Fixes:
https://www.redhat.com/archives/libvir-list/2017-January/msg00978.html
QEMU is probed through monitor fd to check capabilities during libvirtd init.
The monitor fd is closed after probing by virQEMUCapsInitQMPCommandFree
that calls virQEMUCapsInitQMPCommandAbort that calls
Drop the old patches which don't make a good example any more and
freshen up some facts.
Peter Krempa (5):
docs: api_extension: Remove links to the stale example patches
docs: api_extension: Remove example patches
docs: api_extension: Don't encourage other tools than git
docs:
在 2018/8/23 下午4:12, Andrea Bolognani 写道:
Exactly. You can either just add zpci_uid and zpci_fid to the
virPCIDeviceAddress struct, or have
struct _virZPCIDeviceAddress {
unsigned int uid;
unsigned int fid;
};
struct _virPCIDeviceAddress {
unsigned int domain;
On Thu, 2018-08-23 at 17:15 +0800, Yi Min Zhao wrote:
>
> 在 2018/8/23 下午4:12, Andrea Bolognani 写道:
> > Exactly. You can either just add zpci_uid and zpci_fid to the
> > virPCIDeviceAddress struct, or have
> >
> >struct _virZPCIDeviceAddress {
> >unsigned int uid;
> >unsigned
On Wed, 2018-08-22 at 14:15 +0100, Daniel P. Berrangé wrote:
> We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
> be removed entirely in the 3.1.0 release. The min GTK3 version can also
> be bumped up based the distros we aim to support.
>
> Note that before this can
On Wed, 08/22 14:15, Daniel P. Berrangé wrote:
> We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to
> be removed entirely in the 3.1.0 release. The min GTK3 version can also
> be bumped up based the distros we aim to support.
>
> Note that before this can merge, the openbsd
在 2018/8/23 下午4:12, Andrea Bolognani 写道:
On Thu, 2018-08-23 at 14:40 +0800, Yi Min Zhao wrote:
在 2018/8/22 下午6:09, Andrea Bolognani 写道:
On Wed, 2018-08-22 at 17:39 +0800, Yi Min Zhao wrote:
I tried as your idea. It makes everything complicated, especially
alloc/reserve/release
zpci address.
Some things were moved. Try to update the paths.
Signed-off-by: Peter Krempa
---
docs/api_extension.html.in | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in
index ce2f457b63..38235a4241 100644
---
qemuProcessInitCpuAffinity prevents a VM from getting started on a
platform that uses cpu affinity wrapper stubs e.g. macOS.
The patch adds qemuProcessInitCpuAffinity stub on all platforms without
HAVE_SCHED_GETAFFINITY or HAVE_BSD_CPU_AFFINITY.
Signed-off-by: Roman Bolshakov
---
Changes since
On 21 August 2018 at 13:05, Gerd Hoffmann wrote:
> The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into
> staging (2018-08-20 17:41:18 +0100)
>
> are available in the git repository at:
>
>
在 2018/8/22 下午5:56, Andrea Bolognani 写道:
On Wed, 2018-08-22 at 11:00 +0800, Yi Min Zhao wrote:
在 2018/8/17 上午12:06, Andrea Bolognani 写道:
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+static inline bool
+virDeviceInfoPCIAddressExtensionPresent(const virDomainDeviceInfo *info)
It probably does not make sense to do tests using that toolkit any more.
Signed-off-by: Peter Krempa
---
docs/api_extension.html.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in
index d2c7fd6cfb..ce2f457b63 100644
The pathches used as an example for the api_extension manual don't hold
up to the current standards any more. Carefully remove links and
mentions of the patches from the docs.
Signed-off-by: Peter Krempa
---
docs/api_extension.html.in | 96 +-
1 file
From: Peter Wu
Fixes repeated memory leaks of 18 bytes when using VNC:
Direct leak of 831024 byte(s) in 46168 object(s) allocated from:
...
#4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514
#5 0x56085cdcf660 in buffer_init util/buffer.c:59
#6
From: Paolo Bonzini
The OpenGL-enabled SPICE code was not accessing the cursor position
under the SimpleSpiceDisplay lock. Fix this.
Signed-off-by: Paolo Bonzini
Reviewed-by: Marc-André Lureau
Message-id: 20180720063109.4631-2-pbonz...@redhat.com
Signed-off-by: Gerd Hoffmann
---
From: Tao Wu
When scanout_mode enabled, surface is out of sync with actual screen.
In such case, we just call sdl2_gl_scanout_flush to do redraw. This
fixes bug reported in
https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html
Signed-off-by: Tao Wu
Message-id:
From: Marc-André Lureau
vhost-user-gpu will share the same code to open a DRM node.
Signed-off-by: Marc-André Lureau
Message-Id: <20180713130916.4153-20-marcandre.lur...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
include/qemu/drm.h | 6 +
ui/egl-helpers.c | 51
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into
staging (2018-08-20 17:41:18 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/ui-20180823-v3-pull-request
From: Marc-André Lureau
Some scanouts during boot are top-down without it.
y0_top is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last
patch of this series.
In current QEMU code base, only vfio/display uses dmabuf API. But the
VFIO query interface doesn't provide or need that detail
From: Paolo Bonzini
spice-display should not call the ui/console.c functions dpy_cursor_define
and dpy_moues_set with the SimpleSpiceDisplay lock taken. That will cause
a deadlock, because the DisplayChangeListener callbacks will take the lock
again. It is also in general a bad idea to invoke
From: Daniel P. Berrangé
The 'tls-creds' option accepts the name of a TLS credentials
object. This replaced the usage of 'tls', 'x509' and 'x509verify'
options in 2.5.0. These deprecated options were grandfathered in
when the deprecation policy was introduded in 2.10.0, so can now
finally be
On Thu, Aug 23, 2018 at 10:22:08AM +0100, Peter Maydell wrote:
> On 21 August 2018 at 13:05, Gerd Hoffmann wrote:
> > The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797:
> >
> > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into
> > staging
From: Philippe Mathieu-Daudé
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/round.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir . --in-place
Signed-off-by: Philippe Mathieu-Daudé
Message-Id:
From: Thomas Huth
We've got to set the gui_fullscreen variable before creating the
SDL2 window, otherwise the initial window will not be created in
fullscreen mode.
Buglink: https://bugs.launchpad.net/bugs/1780812
Signed-off-by: Thomas Huth
Message-id:
From: Daniel P. Berrangé
The use of 'tls', 'x509' and 'x509verify' properties is the deprecated
backcompat syntax, replaced by use of TLS creds objects.
Signed-off-by: Daniel P. Berrangé
Message-id: 20180725092751.21767-2-berra...@redhat.com
Signed-off-by: Gerd Hoffmann
---
qemu-doc.texi |
From: Thomas Huth
SDL_INIT_NOPARACHUTE is not used in SDL2 anymore, and the define is just
a dummy (see https://wiki.libsdl.org/MigrationGuide#Some_general_truths
for example). So we can remove it and get rid of the "flags" variable
nowadays.
Signed-off-by: Thomas Huth
Message-id:
From: Marc-André Lureau
Minor code simplification.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-id: 20180801092508.4927-1-marcandre.lur...@redhat.com
Signed-off-by: Gerd Hoffmann
---
qemu-keymap.c | 2 +-
ui/console.c | 6 +++---
2 files changed, 4 insertions(+),
On Wed, Aug 22, 2018 at 11:44:23AM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
1 - 100 of 116 matches
Mail list logo