Re: [libvirt] [PATCH v3 21/28] security_manager: Introduce virSecurityManagerLockCloseConn

2018-09-04 Thread John Ferlan
On 09/04/2018 07:53 AM, Michal Privoznik wrote: > On 08/31/2018 08:42 PM, John Ferlan wrote: >> >> >> On 08/27/2018 04:08 AM, Michal Privoznik wrote: >>> This is basically just a wrapper over virLockManagerCloseConn() >>> so that no connection is left open when it shouldn't be. >>> >>>

Re: [libvirt] [jenkins-ci PATCH 2/3] Split off MinGW builds

2018-09-04 Thread Erik Skultety
On Tue, Sep 04, 2018 at 01:01:34PM +0200, Andrea Bolognani wrote: > Up until now, we've been considering MinGW builds as > part of the respective project, at least when it > comes to grouping them. This, however, does not quite > work for a number of reasons: > > * MinGW builds have their own

Re: [libvirt] [Qemu-devel] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

2018-09-04 Thread Andrew Jones
On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [libvirt] [PATCH 2/2] qemu: Unify generation of command line for virtio devices

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 16:09 +0200, Ján Tomko wrote: > On Fri, Aug 31, 2018 at 04:03:10PM +0200, Andrea Bolognani wrote: > > +static char* > > +qemuBuildVirtioDevStr(const virDomainDeviceInfo *info, > > + const char *baseName) [...] > > +virBufferAsprintf(, "%s-%s",

Re: [libvirt] [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-04 Thread Eduardo Habkost
On Tue, Sep 04, 2018 at 05:18:48PM +0200, Andrew Jones wrote: > On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > > commit > > (5cdc9b76e3 vl.c: Remove dead assignment) > > removed sockets calculation when 'sockets' weren't provided on CLI > > since there wasn't any users for it

Re: [libvirt] [PATCH v4 0/4] Add .domainGetHostname() support for QEMU driver.

2018-09-04 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180905023833.4867-1-jcfara...@gmail.com Subject: [libvirt] [PATCH v4 0/4] Add .domainGetHostname() support for QEMU driver. === TEST SCRIPT BEGIN ===

Re: [libvirt] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

2018-09-04 Thread Eduardo Habkost
On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

[libvirt] [PATCH v4 2/4] qemu: adding domainGetHostname support for QEMU

2018-09-04 Thread Julio Faracco
This commit adds support to use the function qemuAgentGetHostname() for obtain the domain hostname using QEMU-GA command. Signed-off-by: Julio Faracco --- src/qemu/qemu_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git

[libvirt] [PATCH v4 4/4] qemu: unlink the error report from VIR_STRDUP.

2018-09-04 Thread Julio Faracco
The function to retrieve the file system info using QEMU-GA is using some conditionals to retrieve the info. This is wrong because the error of some conditionals will be raised if VIR_STRDUP return errors and not if some problem occurred with JSON. Signed-off-by: Julio Faracco ---

[libvirt] [PATCH v4 0/4] Add .domainGetHostname() support for QEMU driver.

2018-09-04 Thread Julio Faracco
This serie adds a new function into QEMU Guest Agent handler to use the QEMU command 'guest-get-host-name' to retrieve the domain hostname. This approach requires QEMU-GA running inside the guest, but it is the fastest and easiest way to get this info. This serie has some suggestion made by

[libvirt] [PATCH v4 1/4] qemu: implementing qemuAgentGetHostname() function.

2018-09-04 Thread Julio Faracco
This commit implements the function qemuAgentGetHostname() that uses the QEMU guest agent command 'guest-get-host-name' to retrieve the guest hostname of virtual machine running the QEMU-GA. Signed-off-by: Julio Faracco --- src/qemu/qemu_agent.c | 47 +++

[libvirt] [PATCH v4 3/4] docs: Add QEMU-GA get hostname feature into news.xml

2018-09-04 Thread Julio Faracco
QEMU-GA supports get geust hostname command. This commit includes a specific entry to inform this new feature for QEMU driver to 4.8.0 release. Signed-off-by: Julio Faracco --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

Re: [libvirt] [PATCH 00/10] Introduce x86 Cache Monitoring Technology (CMT)

2018-09-04 Thread Huaqiang,Wang
hi reviewer, I understand libvirt community is quite active and you are quite busy. I am written here to know if you  ever noticed this patch series, and welcome your comment. BR On 2018年08月27日 19:23, Wang Huaqiang wrote: This series of patches introduced the x86 Cache Monitoring

Re: [libvirt] Virsh reference is out of date, should it be updated from the man page?

2018-09-04 Thread Povilas Kanapickas
On 09/03/2018 01:09 PM, Ján Tomko wrote: > On Mon, Sep 03, 2018 at 10:04:16AM +0200, Michal Prívozník wrote: >> On 09/03/2018 09:38 AM, Povilas Kanapickas wrote: >>> Hi! >>> >>> The online virsh command reference at [1] seems to be very out of date >>> according to [2]. There's much more recent

[libvirt] domain XML for tracking libosinfo ID

2018-09-04 Thread Cole Robinson
Right now in virt-manager we only track a VM's OS name (win10, fedora28, etc.) during the VM install phase. This piece of data is important post-install though: if the user adds a new disk to the VM later, we want to be able to ask libosinfo about what devices the installed OS supports, so we

Re: [libvirt] [PATCH 2/2] qemu: Unify generation of command line for virtio devices

2018-09-04 Thread Ján Tomko
On Fri, Aug 31, 2018 at 04:03:10PM +0200, Andrea Bolognani wrote: A virtio device such as will be translated to one of four different QEMU devices based on the address type. This behavior is the same for all virtio devices, but unfortunately we have separate ad-hoc code dealing with each and

Re: [libvirt] [PATCH v3 14/28] lock_daemon_dispatch: Check for ownerPid rather than ownerId

2018-09-04 Thread John Ferlan
On 09/03/2018 11:13 AM, Michal Privoznik wrote: > On 08/30/2018 11:47 PM, John Ferlan wrote: >> >> >> On 08/27/2018 04:08 AM, Michal Privoznik wrote: >>> At the beginning of each dispatch function we check if owner >>> attributes were registered (these consist of ID, UUID, PID and >>> name).

Re: [libvirt] [PATCH] tests: skip some unicode tests if expected output won't match

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 04:57:42PM +0200, Simon Kobyda wrote: > On Tue, 2018-09-04 at 11:30 +0100, Daniel P. Berrangé wrote: > > The expected output strings from the vshtabletest.c are created on a > > modern Linux host where unicode printing support is very good. On > > older > > Linux platforms,

Re: [libvirt] [PATCH v3 20/28] security_manager: Load lock plugin on init

2018-09-04 Thread John Ferlan
On 09/03/2018 11:13 AM, Michal Privoznik wrote: > On 08/31/2018 07:35 PM, John Ferlan wrote: >> >> >> On 08/27/2018 04:08 AM, Michal Privoznik wrote: >>> When creating the security managers stack load the lock plugin >>> too. This is done by creating a single object that all secdrivers >>> take

[libvirt] [libvirt-snmp][PATCH] rpm: simplify applying of patches

2018-09-04 Thread Michal Privoznik
The distros we support for RPM builds all have %autosetup support. Use that instead of what we currently have (nothing). Signed-off-by: Michal Privoznik --- Pushed under trivial rule and also 'who cares about snmp' rules ;-) libvirt-snmp.spec.in | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH v6 1/2] vl.c deprecate incorrect CPUs topology

2018-09-04 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid

Re: [libvirt] [PATCH 1/2] tests: Fix use of virtio-serial for aarch64/virt

2018-09-04 Thread Ján Tomko
On Fri, Aug 31, 2018 at 04:03:09PM +0200, Andrea Bolognani wrote: virtio-serial is an alias for virtio-serial-pci, which should not have been used for a PCIe-less aarch64/virt guest but it ended up being used anyway because the I tried using the XML file with DO_TEST_CAPS_ARCH_LATEST and it

[libvirt] [go PATCH] Avoid clashing path with default storage pool

2018-09-04 Thread Daniel P . Berrangé
The test driver provides a default storage pool at /default-pool. Libvirt now enforces source path uniqueness, so we must pick a different path for our test pools. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix connect_test.go | 6 +++--- storage_pool_test.go | 2 +- 2 files

[libvirt] [perl PATCH] Avoid using /default-pool for test storage pool

2018-09-04 Thread Daniel P . Berrangé
The path /default-pool is used by a predefined storage pool in the test driver, and libvirt now enforces pool source uniqueness. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix t/400-storage-pools.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-04 Thread Igor Mammedov
commit (5cdc9b76e3 vl.c: Remove dead assignment) removed sockets calculation when 'sockets' weren't provided on CLI since there wasn't any users for it back then. Exiting checks are neither reachable } else if (sockets * cores * threads < cpus) { or nor triggable if (sockets * cores *

[libvirt] [PATCH v5 1/2] vl.c deprecate incorrect CPUs topology

2018-09-04 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid

[libvirt] [PATCH v5 0/2] deprecate incorrect CPUs topology

2018-09-04 Thread Igor Mammedov
Changelog since v4: * extend deprication doc, adding that maxcpus should be multiple of present on CLI [sockets/cores/threads] options (Eduardo Habkost ) series bundles together 2 related patches posted separately earlier: vl.c deprecate incorrect CPUs topology vl:c: make

Re: [libvirt] [PATCH] tests: skip some unicode tests if expected output won't match

2018-09-04 Thread Simon Kobyda
On Tue, 2018-09-04 at 11:30 +0100, Daniel P. Berrangé wrote: > The expected output strings from the vshtabletest.c are created on a > modern Linux host where unicode printing support is very good. On > older > Linux platforms, or non-Linux platforms, some unicode characters will > not be

Re: [libvirt] [jenkins-ci PATCH] guests: Special-case fedora-gpg-keys updates on Rawhide

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 03:59:23PM +0200, Andrea Bolognani wrote: > During each Rawhide development cycle there is a point > at which packages start being signed with new keys, which > causes updates to fail. > > To work around the problem, make sure fedora-gpg-keys is > updated before attempting

Re: [libvirt] [PATCH 2/2] qemu: Unify generation of command line for virtio devices

2018-09-04 Thread Ján Tomko
On Tue, Sep 04, 2018 at 05:32:51PM +0200, Andrea Bolognani wrote: On Tue, 2018-09-04 at 16:09 +0200, Ján Tomko wrote: On Fri, Aug 31, 2018 at 04:03:10PM +0200, Andrea Bolognani wrote: > +static char* > +qemuBuildVirtioDevStr(const virDomainDeviceInfo *info, > + const char

Re: [libvirt] [PATCH v3 13/28] lock_driver: Introduce VIR_LOCK_MANAGER_RESOURCE_TYPE_METADATA

2018-09-04 Thread John Ferlan
On 09/03/2018 11:13 AM, Michal Privoznik wrote: > On 08/30/2018 11:34 PM, John Ferlan wrote: >> >> >> On 08/27/2018 04:08 AM, Michal Privoznik wrote: >>> This is a new type of object that lock drivers can handle. >>> Currently, it is supported by lockd driver only. >>> >>> Signed-off-by: Michal

Re: [libvirt] [PATCH v3 11/28] lock_driver: Introduce new VIR_LOCK_MANAGER_OBJECT_TYPE_DAEMON

2018-09-04 Thread John Ferlan
On 09/03/2018 11:13 AM, Michal Privoznik wrote: > On 08/30/2018 10:40 PM, John Ferlan wrote: >> >> >> On 08/27/2018 04:08 AM, Michal Privoznik wrote: >>> We will want virtlockd to lock files on behalf of libvirtd and >>> not qemu process, because it is libvirtd that needs an exclusive >>>

Re: [libvirt] [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-04 Thread Andrew Jones
On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > commit > (5cdc9b76e3 vl.c: Remove dead assignment) > removed sockets calculation when 'sockets' weren't provided on CLI > since there wasn't any users for it back then. Exiting checks > are neither reachable >} else if (sockets

[libvirt] [jenkins-ci PATCH] guests: Special-case fedora-gpg-keys updates on Rawhide

2018-09-04 Thread Andrea Bolognani
During each Rawhide development cycle there is a point at which packages start being signed with new keys, which causes updates to fail. To work around the problem, make sure fedora-gpg-keys is updated before attempting to update all other packages; updating fedora-gpg-keys itself requires gpg

Re: [libvirt] [jenkins-ci PATCH 2/3] Split off MinGW builds

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 16:11 +0200, Erik Skultety wrote: > On Tue, Sep 04, 2018 at 01:01:34PM +0200, Andrea Bolognani wrote: > > Up until now, we've been considering MinGW builds as > > part of the respective project, at least when it > > comes to grouping them. This, however, does not quite > >

Re: [libvirt] [snmp PATCH] Fix wrong object OIDs sent by libvirtMib_subagent

2018-09-04 Thread Michal Privoznik
On 09/03/2018 02:44 PM, Miguel Martin wrote: > The objects OIDs sent by the guest agent are: > libvirtGuestName.0 > libvirtGuestUUID.1 > libvirtGuestState.2 > libvirtGuestRowStatus.3 > > The expected libvirtGuestNotif objects OID would be: > libvirtGuestName.0 > libvirtGuestUUID.0 >

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: > If no JSON parser is available qemublocktest fails, so skip its execution. > > Signed-off-by: Daniel P. Berrangé > --- > > Pushed as a build fix for platforms without JSON parser installed Which platforms? All machines in our CI

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: > > If no JSON parser is available qemublocktest fails, so skip its execution. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > > > Pushed as a build fix for

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Ján Tomko
On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote: On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: If no JSON parser is available qemublocktest fails, so skip its execution. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for platforms without JSON

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote: > > > Pushed as a build fix for platforms without JSON parser installed > > > > Which platforms? All machines in our CI environments should have > > yajl installed. > > It wasn't CI - it was my own FreeBSD machine without yajl I see

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 02:10:56PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote: > > > > Pushed as a build fix for platforms without JSON parser installed > > > > > > Which platforms? All machines in our CI environments should have > > > yajl

[libvirt] [jenkins-ci PATCH] guests: Hash test user password dynamically

2018-09-04 Thread Andrea Bolognani
Current versions of Ansible support the password_hash() filter, so we can avoid hardcoding a pre-computed hash and make what's happening a bit clearer. Signed-off-by: Andrea Bolognani --- guests/playbooks/update/tasks/users.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH v5 0/4] Add .domainGetHostname() support for QEMU driver.

2018-09-04 Thread Julio Faracco
This serie adds a new function into QEMU Guest Agent handler to use the QEMU command 'guest-get-host-name' to retrieve the domain hostname. This approach requires QEMU-GA running inside the guest, but it is the fastest and easiest way to get this info. This serie has some suggestion made by John

[libvirt] [PATCH v5 1/4] qemu: implementing qemuAgentGetHostname() function.

2018-09-04 Thread Julio Faracco
This commit implements the function qemuAgentGetHostname() that uses the QEMU guest agent command 'guest-get-host-name' to retrieve the guest hostname of virtual machine running the QEMU-GA. Signed-off-by: Julio Faracco --- src/qemu/qemu_agent.c | 47 +++

[libvirt] [PATCH v5 2/4] qemu: adding domainGetHostname support for QEMU

2018-09-04 Thread Julio Faracco
This commit adds support to use the function qemuAgentGetHostname() for obtain the domain hostname using QEMU-GA command. Signed-off-by: Julio Faracco --- src/qemu/qemu_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git

[libvirt] [PATCH v5 4/4] qemu: unlink the error report from VIR_STRDUP.

2018-09-04 Thread Julio Faracco
The function to retrieve the file system info using QEMU-GA is using some conditionals to retrieve the info. This is wrong because the error of some conditionals will be raised if VIR_STRDUP return errors and not if some problem occurred with JSON. Signed-off-by: Julio Faracco ---

[libvirt] [PATCH v5 3/4] docs: Add QEMU-GA get hostname feature into news.xml

2018-09-04 Thread Julio Faracco
QEMU-GA supports get geust hostname command. This commit includes a specific entry to inform this new feature for QEMU driver to 4.8.0 release. Signed-off-by: Julio Faracco --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

[libvirt] [jenkins-ci PATCH 0/3] Split off MinGW builds

2018-09-04 Thread Andrea Bolognani
See patch 2/3 for the rationale. Andrea Bolognani (3): guests: Split MinGW projects Split off MinGW builds Remove 'variant' .../host_vars/libvirt-fedora-rawhide/main.yml | 15 - .../build/jobs/autotools-build-job.yml| 4 ++-- .../build/jobs/autotools-check-job.yml

[libvirt] [jenkins-ci PATCH 3/3] Remove 'variant'

2018-09-04 Thread Andrea Bolognani
It's no longer used anywhere. Signed-off-by: Andrea Bolognani --- .../playbooks/build/jobs/autotools-build-job.yml | 4 ++-- .../playbooks/build/jobs/autotools-check-job.yml | 4 ++-- .../playbooks/build/jobs/autotools-rpm-job.yml | 4 ++-- .../build/jobs/autotools-syntax-check-job.yml

[libvirt] [jenkins-ci PATCH 1/3] guests: Split MinGW projects

2018-09-04 Thread Andrea Bolognani
The 32-bit and 64-bit MinGW builds require almost completely different sets of packages, so it makes sense to split them off into separate pseudo-projects in order to have more control over what gets installed on each host. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [PATCH v3 21/28] security_manager: Introduce virSecurityManagerLockCloseConn

2018-09-04 Thread Michal Privoznik
On 08/31/2018 08:42 PM, John Ferlan wrote: > > > On 08/27/2018 04:08 AM, Michal Privoznik wrote: >> This is basically just a wrapper over virLockManagerCloseConn() >> so that no connection is left open when it shouldn't be. >> >> Signed-off-by: Michal Privoznik >> --- >>

Re: [libvirt] [jenkins-ci PATCH] lcitool: Don't encrypt password manually

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 10:49 +0200, Martin Kletzander wrote: s/manually/ourselves/ in the subject. [...] > def get_root_password_file(self): > -root_pass_file = self._get_config_file("root-password") > -root_hash_file = self._get_config_file(".root-password.hash") > - > -

[libvirt] [PATCH] tests: skip some unicode tests if expected output won't match

2018-09-04 Thread Daniel P . Berrangé
The expected output strings from the vshtabletest.c are created on a modern Linux host where unicode printing support is very good. On older Linux platforms, or non-Linux platforms, some unicode characters will not be considered printable. While the vsh table alignment code will stil do the right

[libvirt] [jenkins-ci PATCH 2/3] Split off MinGW builds

2018-09-04 Thread Andrea Bolognani
Up until now, we've been considering MinGW builds as part of the respective project, at least when it comes to grouping them. This, however, does not quite work for a number of reasons: * MinGW builds have their own workspace, separate from the native one. It goes further than that:

[libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Daniel P . Berrangé
If no JSON parser is available qemublocktest fails, so skip its execution. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for platforms without JSON parser installed tests/qemublocktest.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-)

Re: [libvirt] [PATCH v4] qemu: Introduce state_lock_timeout to qemu.conf

2018-09-04 Thread Ján Tomko
On Tue, Aug 28, 2018 at 04:40:16PM +0800, Yi Wang wrote: When doing some job holding state lock for a long time, we may come across error: "Timed out during operation: cannot acquire state change lock" Well, sometimes it's not a problem and users wanner continue s/wanner/want to/ to wait,

Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-09-04 Thread Erik Skultety
On Fri, Aug 31, 2018 at 12:16:14PM +0200, Andrea Bolognani wrote: > On Wed, 2018-08-29 at 17:08 +0200, Andrea Bolognani wrote: > > This will allow users to build arbitrary branches from > > arbitrary git repositories, but for the moment all it > > does is parse the argument and pass it down to the

Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 09:55 +0200, Erik Skultety wrote: > Initially, I wanted to point out that "revision" is probably not the best name [...] I was thinking yesterday that perhaps it would be better to use '-g GITREVISION' here instead, to leave '-r' available for future extensions, eg. when/if

Re: [libvirt] [PATCH] api,qemu: add block latency histogram

2018-09-04 Thread Nikolay Shirokovskiy
Hi, Peter. I have questions to several of your comments: On 03.09.2018 14:59, Peter Krempa wrote: > On Mon, Sep 03, 2018 at 13:58:31 +0300, Nikolay Shirokovskiy wrote: >> This patch adds option to configure/read latency histogram of >> block device IO operations. The corresponding functionality

[libvirt] [PATCH v5 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-09-04 Thread Yi Min Zhao
This patch adds new functions for reservation, assignment and release to handle the uid/fid. If the uid/fid is defined in the domain XML, they will be reserved directly in collecting phase. If any of them is not defined, we will find out an available value for it from zPCI address hashtable, and

[libvirt] [PATCH v5 12/13] docs: Add 'uid' and 'fid' information

2018-09-04 Thread Yi Min Zhao
Update 'Device address' section to describe the 'uid' and 'fid' attributes. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- docs/formatdomain.html.in | 9 - 1 file changed, 8

[libvirt] [PATCH v5 10/13] qemu: Generate and use zPCI device in QEMU command line

2018-09-04 Thread Yi Min Zhao
Add new functions to generate zPCI command string and append it to QEMU command line. And the related tests are added. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Bjoern Walk Reviewed-by: Ján Tomko --- src/qemu/qemu_command.c

[libvirt] [PATCH v5 00/13] PCI passthrough support on s390

2018-09-04 Thread Yi Min Zhao
Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function identifier). The details can be found here: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07262.html

[libvirt] [PATCH v5 02/13] qemu: Introduce zPCI capability

2018-09-04 Thread Yi Min Zhao
Let's introduce zPCI capability. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Bjoern Walk Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[libvirt] [jenkins-ci PATCH] lcitool: Don't encrypt password manually

2018-09-04 Thread Martin Kletzander
Since version 1.9 ansible supports password_hash filter that can do that for us. Signed-off-by: Martin Kletzander --- guests/lcitool | 29 + guests/playbooks/update/tasks/users.yml | 2 +- 2 files changed, 2 insertions(+), 29 deletions(-) diff

Re: [libvirt] [jenkins-ci PATCH 4/8] guests: Use "git_branch" when building

2018-09-04 Thread Erik Skultety
On Wed, Aug 29, 2018 at 05:09:01PM +0200, Andrea Bolognani wrote: > This makes the build process use the value provided by > the user through lcitool instead of the default. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [jenkins-ci PATCH 7/8] guests: Use "git_remote" when building

2018-09-04 Thread Erik Skultety
On Wed, Aug 29, 2018 at 05:09:04PM +0200, Andrea Bolognani wrote: > This makes the build process use the value provided > by the user through lcitool instead of the default. > > With this change, building arbitrary branches from > arbitrary git repository through lcitool is fully > working. > >

Re: [libvirt] [jenkins-ci PATCH 2/8] Don't use "branch" in paths and job names

2018-09-04 Thread Erik Skultety
On Wed, Aug 29, 2018 at 05:08:59PM +0200, Andrea Bolognani wrote: > We'll soon to make it possible to build arbitrary branches > from arbitrary git repositories with lcitool: sticking with > the current scheme for on-disk storage would mean that we > would create a separate git clone for each

[libvirt] [PATCH v5 01/13] conf: Add definitions for 'uid' and 'fid' PCI address attributes

2018-09-04 Thread Yi Min Zhao
Add zPCI definitions in preparation of extending the PCI address with parameters uid (user-defined identifier) and fid (PCI function identifier). Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Bjoern Walk Reviewed-by: Ján Tomko ---

[libvirt] [PATCH v5 06/13] conf: Introduce address caching for PCI extensions

2018-09-04 Thread Yi Min Zhao
This patch provides a caching mechanism for the device address extensions uid and fid on S390. For efficient sparse address allocation, we introduce two hash tables for uid/fid which hold the address set information per domain. Also in order to improve performance of searching available value, we

[libvirt] [PATCH v5 13/13] news: Update news for PCI address extension attributes

2018-09-04 Thread Yi Min Zhao
Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Ján Tomko --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 9a17b2f612..fc54a3b6ff 100644 --- a/docs/news.xml +++

Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-09-04 Thread Erik Skultety
On Tue, Sep 04, 2018 at 10:33:18AM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 09:55 +0200, Erik Skultety wrote: > > Initially, I wanted to point out that "revision" is probably not the best > > name > [...] > > I was thinking yesterday that perhaps it would be better to > use '-g

[libvirt] [PATCH v5 07/13] conf: Introduce parser, formatter for uid and fid

2018-09-04 Thread Yi Min Zhao
This patch introduces new XML parser/formatter functions. Uid is 16-bit and non-zero. Fid is 32-bit. They are added as two new attributes of PCI address, and parsed/formatted along with PCI address parser/formatter. The related test is also added. Signed-off-by: Yi Min Zhao Reviewed-by: Boris

[libvirt] [PATCH v5 05/13] qemu: Auto add pci-root for s390/s390x guests

2018-09-04 Thread Yi Min Zhao
The pci-root depends on zpci capability. So autogenerate pci-root if zpci exists. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Bjoern Walk Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 1 + 1 file

[libvirt] [PATCH v5 04/13] qemu: Enable PCI multi bus for S390 guests

2018-09-04 Thread Yi Min Zhao
QEMU on s390 supports PCI multibus since forever. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Reviewed-by: Bjoern Walk Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 4 1 file changed, 4 insertions(+)

[libvirt] [PATCH v5 03/13] conf: Introduce a new PCI address extension flag

2018-09-04 Thread Yi Min Zhao
This patch introduces a new attribute PCI address extension flag to deal with the extension PCI attributes such as 'uid' and 'fid' on the S390 platform. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/conf/device_conf.h

[libvirt] [PATCH v5 11/13] qemu: Add hotpluging support for PCI devices on S390 guests

2018-09-04 Thread Yi Min Zhao
This commit adds hotplug support for PCI devices on S390 guests. There's no need to implement hot unplug for zPCI as QEMU implements an unplug callback which will unplug both PCI and zPCI device in a cascaded way. Currently, the following PCI devices are supported: virtio-blk-pci

[libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-04 Thread Yi Min Zhao
We should ensure that the Qemu should support zPCI when zPCI address is defined in XML. Otherwise the error should be reported. So this patch introduces the validation of zPCI address definition for qemuDomainDeviceDefValidate(). Signed-off-by: Yi Min Zhao --- src/qemu/qemu_domain.c | 26

Re: [libvirt] [jenkins-ci PATCH 8/8] guests: Update documentation

2018-09-04 Thread Erik Skultety
On Wed, Aug 29, 2018 at 05:09:05PM +0200, Andrea Bolognani wrote: > Provide instructions on how to build from non-default > git repositories and branches. > > Signed-off-by: Andrea Bolognani > --- With the necessary updates on '-g' being optional: Reviewed-by: Erik Skultety >

Re: [libvirt] [jenkins-ci PATCH 6/8] Add "git_urls" dictionary to defaults

2018-09-04 Thread Erik Skultety
On Wed, Aug 29, 2018 at 05:09:03PM +0200, Andrea Bolognani wrote: > Out of the box, it contains the upstream repository for > all projects; additionally, the user will be able to > store information about their own repositories, making > it possible to test-build in-progress branches before >

Re: [libvirt] [PATCH] qemu: clear seccomp capability if TSYNC is not supported by host

2018-09-04 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180830120941.22155-1-marcandre.lur...@redhat.com Subject: [libvirt] [PATCH] qemu: clear seccomp capability if TSYNC is not supported by host === TEST