Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
examples/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/Makefile.am b/examples/Makefile.am
index 7069d74e74..8a9c118858 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -94,7 +94,7 @@
On Tue, 2018-11-13 at 12:04 -0700, Jim Fehlig wrote:
> On 11/13/18 10:14 AM, Andrea Bolognani wrote:
> > > +uninstall-apparmor-local:
> > > + rm -f "$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper"
> > > + rmdir $(APPARMOR_LOCAL_DIR) || :
> >
> > Missing quotes here as well. Once you fix
On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
s/Qemu-3.1/QEMU 3.1/
[...]
> +
> + ipi
> + Enable PV IPI support
> + on, off
No whitespace before "on", please.
Pre-existing:
On Tue, Nov 13, 2018 at 09:21 PM +0100, John Ferlan wrote:
> Support for nested kvm is handled via a kernel module configuration
> adjustment which if done after libvirtd is started and/or the last
> QEMU capabilities adjustment can result in the inability to start a
> guest and use nested kvm
On Wed, 2018-11-14 at 11:13 +0100, Vitaly Kuznetsov wrote:
> Andrea Bolognani writes:
> ...
> > > + 4.10.0 (QEMU 3.1)
> >
> > Again pre-existing: what does the first version number refer to? It
> > would be nice to have it spelled out.
>
> My understanding is that this is libvirt
On Tue, Nov 13, 2018 at 03:21:03PM -0500, John Ferlan wrote:
> Sending as an RFC primarily because I'm looking for whether either
> or both mechanisms in the series is more or less desired. Likewise,
> if it's felt that the current process of telling customers to just
> delete the cache is
On 11/14/18 4:04 AM, Andrea Bolognani wrote:
> On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
>> The upcoming Qemu-3.1 release will bring us two new Hyper-V enlightenments:
>> hv_ipi and hv_evmcs. Support these in libvirt.
>>
>> Vitaly Kuznetsov (2):
>> conf: qemu: add support for
On Wed, 2018-11-14 at 10:00 +0100, Andrea Bolognani wrote:
> On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> > Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
>
> s/Qemu-3.1/QEMU 3.1/
>
> [...]
> > +
> > + ipi
> > + Enable PV IPI
For metadata locking we might need an extra fork() which given
latest attempts to do fewer fork()-s is suboptimal. Therefore,
there will be a qemu.conf knob to enable or this feature. But
since the feature is actually not metadata locking itself rather
than remembering of the original owner of the
Andrea Bolognani writes:
...
>
>> + 4.10.0 (QEMU 3.1)
>
> Again pre-existing: what does the first version number refer to? It
> would be nice to have it spelled out.
>
My understanding is that this is libvirt version. We can, of course,
spell it out but:
$ git grep -c 'class="since"'
On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> The upcoming Qemu-3.1 release will bring us two new Hyper-V enlightenments:
> hv_ipi and hv_evmcs. Support these in libvirt.
>
> Vitaly Kuznetsov (2):
> conf: qemu: add support for Hyper-V PV IPIs
> conf: qemu: add support for
On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
s/Qemu-3.1/QEMU 3.1/
[...]
> +
> + ipi
> + Enable PV IPI support
> + on, off
s/ on,/on,/
Everything else looks good.
--
On Tue, Nov 13, 2018 at 03:52:17PM -0500, John Ferlan wrote:
> [...]
> >>
> >> I understand (generically) why we need the lock. I'm OK with it being
> >> enabled by default. That's not the question/ask. Building in a way to
> >> allow disabling usage of virFork and/or metadata lock knowing the
>
Support Hyper-V Enlightened VMCS in domain config. QEMU support will
be implemented in the next patch, adding interim VIR_DOMAIN_HYPERV_EVMCS
cases to src/qemu/* for now.
Reviewed-by: Andrea Bolognani
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
The upcoming QEMU 3.1 release will bring us two new Hyper-V enlightenments:
hv_ipi and hv_evmcs. Support these in libvirt.
Changes since v2:
- Separate docs/news.xml hunks in their own PATCH6, squash both
changes together [Andrea Bolognani]
- s/Qemu/QEMU/g + 'whitespate' typo [Andrea Bolognani]
Support Hyper-V PV IPI enlightenment in domain config. QEMU support will
be implemented in the next patch, adding interim VIR_DOMAIN_HYPERV_IPI cases
to src/qemu/* for now.
Reviewed-by: Andrea Bolognani
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
QEMU 3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
guests to send an IPI, especially when it targets many CPUs.
Reviewed-by: Andrea Bolognani
Signed-off-by: Vitaly Kuznetsov
---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_parse_command.c | 2 +-
QEMU 3.1 supports Hyper-V Enlightened VMCS feature which significantly
speeds up nested Hyper-V on KVM environments.
Signed-off-by: Vitaly Kuznetsov
---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_parse_command.c | 2 +-
src/qemu/qemu_process.c | 2 +-
Remove redundant leading whitespaces from " on, off".
Suggested-by: Andrea Bolognani
Reviewed-by: Andrea Bolognani
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/formatdomain.html.in
Andrea Bolognani writes:
> On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote:
>> Qemu 3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
>
> s/Qemu/QEMU/
>
> Better than in v1 but not quite perfect yet ;)
>
> [...]
>> +
>> +
>> + qemu: Add Hyper-V PV
Many of the current virtio-*-pci device types actually represent
3 different types of devices:
* virtio 1.0 non-transitional devices
* virtio 1.0 transitional devices
* virtio 0.9 ("legacy device" in virtio 1.0 terminology)
That would be just an annoyance if it didn't break our device/bus
The QEMU driver now has support for Hyper-V PV IPI and Enlightened VMCS
for Windows and Hyper-V guests.
Suggested-by: Andrea Bolognani
Signed-off-by: Vitaly Kuznetsov
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index
v4 of:
https://www.redhat.com/archives/libvir-list/2018-October/msg00861.html
diff to v3:
- Introduced a config knob to enable/disable metadata locking (except
not really). We want to have a knob that enables/disables remembering
of original owner. This knob in turn enables metadata locking.
This reverts commit aaf34cb9013d6d746f4edf9807408cb9dfbcf01d.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver_lockd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c
index
This reverts commit 22baf6e08c65d9174b24f66370724ce961ce9576.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 2 -
src/locking/lock_driver_lockd.c | 297 +++---
src/locking/lock_driver_sanlock.c | 37 ++--
3 files changed, 116 insertions(+),
This reverts commit afd5a27575e8b6a494d2728552fe0e89c71e32b4.
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 3 ---
src/util/virlockspace.c| 15 +--
src/util/virlockspace.h| 4
tests/virlockspacetest.c | 29
This reverts commit 21c34b86be5233634eb38f77be64e2263bfc4e48.
Signed-off-by: Michal Privoznik
---
src/locking/lock_daemon_dispatch.c | 10 ++
src/locking/lock_driver_lockd.c| 3 +--
src/locking/lock_driver_lockd.h| 1 -
3 files changed, 3 insertions(+), 11 deletions(-)
diff
This reverts commit 3e26b476b5f322353bf0dcd8e3f037ca672b8c62.
Signed-off-by: Michal Privoznik
---
cfg.mk | 4 +---
src/lxc/lxc_controller.c | 3 +--
src/lxc/lxc_driver.c | 2 +-
src/qemu/qemu_driver.c | 3 ---
This reverts commit 35b5b244da825fb41e35e4dc62e740d716214ec9.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 4
src/locking/lock_driver_lockd.c | 4 +---
src/locking/lock_driver_sanlock.c | 4 +---
src/locking/lock_manager.c| 10 +++---
4 files
On Wed, 2018-11-14 at 13:12 +, Daniel P. Berrangé wrote:
> On Wed, Nov 14, 2018 at 01:43:10PM +0100, Andrea Bolognani wrote:
> > flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
> > releases ship pyflakes 2.0.0 these days.
>
> This rationale doesn't make sense given that I see Fedora
On 11/14/18 8:24 AM, Vitaly Kuznetsov wrote:
> John Ferlan writes:
>
>> On 11/14/18 4:04 AM, Andrea Bolognani wrote:
>>> On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
The upcoming Qemu-3.1 release will bring us two new Hyper-V enlightenments:
hv_ipi and hv_evmcs.
Trying to use virlockd to lock metadata turns out to be too big
gun. Since we will always spawn a separate process for relabeling
we are safe to use thread unsafe POSIX locks and take out
virtlockd completely out of the picture.
Signed-off-by: Michal Privoznik
---
src/security/security_dac.c
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_security.c| 73 -
src/security/security_dac.c | 56 -
src/security/security_driver.h | 3 +-
src/security/security_manager.c | 9 +++-
src/security/security_manager.h | 3 +-
The TPM code currently accepts pointer to a domain definition.
This is okay for now, but in near future the security driver APIs
it calls will require domain object. Therefore, change the TPM
code to accept the domain object pointer.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_extdevice.c
Both virProcessRunInMountNamespace() and virProcessRunInFork()
look very similar. De-duplicate the code and make
virProcessRunInMountNamespace() call virProcessRunInFork().
Signed-off-by: Michal Privoznik
Reviewed-by: John Ferlan
---
src/util/virprocess.c | 64
This reverts commit 997283b54b0e1f599aed3085ceba027eb8110acb.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 2 --
src/locking/lock_driver_lockd.c | 47 +--
src/locking/lock_driver_sanlock.c | 3 +-
3 files changed, 14 insertions(+), 38
This reverts commit 385eb8399bdb1610447c2857abfe99cee4a9fb9e.
Signed-off-by: Michal Privoznik
---
src/locking/lock_driver.h | 4 --
src/locking/lock_driver_lockd.c | 82 ++---
2 files changed, 24 insertions(+), 62 deletions(-)
diff --git
This reverts commit 8b8aefb3d6ae2139ea3d4ef6d7dd2c06f57f6075.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_conf.c | 1 -
src/qemu/qemu_conf.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 17b7e11e02..32da9a7351 100644
---
John Ferlan writes:
> On 11/14/18 4:04 AM, Andrea Bolognani wrote:
>> On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
>>> The upcoming Qemu-3.1 release will bring us two new Hyper-V enlightenments:
>>> hv_ipi and hv_evmcs. Support these in libvirt.
>>>
>>> Vitaly Kuznetsov (2):
>>>
On Wed, Nov 14, 2018 at 01:43:10PM +0100, Andrea Bolognani wrote:
> flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
> releases ship pyflakes 2.0.0 these days.
This rationale doesn't make sense given that I see Fedora has
flake8 which is happily using pyflakes 2.0.0
# rpm -q
Commit 20ab0c4d added a new constant to reflect recent libvirt upstream
changes. However, it also introduced a tiny typo which caused the build
to fail.
Signed-off-by: Erik Skultety
---
Pushed both under trivial and build-breaker rules.
domain_compat.h | 2 +-
1 file changed, 1 insertion(+), 1
On Wed, Nov 14, 2018 at 03:12:19PM +0100, Andrea Bolognani wrote:
> On Wed, 2018-11-14 at 13:12 +, Daniel P. Berrangé wrote:
> > On Wed, Nov 14, 2018 at 01:43:10PM +0100, Andrea Bolognani wrote:
> > > flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
> > > releases ship pyflakes 2.0.0
On Wed, 2018-11-14 at 14:25 +, Daniel P. Berrangé wrote:
> On Wed, Nov 14, 2018 at 03:12:19PM +0100, Andrea Bolognani wrote:
> > So we can either merge this patch to make the failures go away for
> > the time being and re-introduce the job once flake8 3.6.0 is
> > available in FreeBSD, or
flake8 3.5.0 doesn't work with pyflakes 2.0.0, and since those
are the versions available through ports there's currently no
way to successfully run flake8 on FreeBSD.
We will be able to revert this once flake8 3.6.0 is available
through ports.
Signed-off-by: Andrea Bolognani
---
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> Move a step closer to the function structure used elsewhere in
> qemu_process where qemuProcessStart and qemuProcessStop are the exposed
> functions.
>
> qemuProcessStartQmp mirrors qemuProcessStart in calling sub functions to
> intialize, launch
On Wed, Nov 14, 2018 at 03:48:16PM +0100, Andrea Bolognani wrote:
> flake8 3.5.0 doesn't work with pyflakes 2.0.0, and since those
> are the versions available through ports there's currently no
> way to successfully run flake8 on FreeBSD.
>
> We will be able to revert this once flake8 3.6.0 is
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> Make process code usable outside qemu_capabilities by moving code
> from qemu_capabilities to qemu_process and exposing public functions.
>
> The process code is used to activate a non domain QEMU process for QMP
> message exchanges.
>
> This
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> Failure to connect to QEMU to probe capabilities is not considered a error
> case
> and does not result in a negative return value.
>
> Check for a NULL monitor connection pointer before trying to send capabilities
> commands to QEMU rather than
On 11/13/18 10:25 PM, Wang Huaqiang wrote:
> Add help document in explaining the cache monitor related 'domstats'
> result.
>
> This patch is written to address John's review comment regarding
> patch16-v7 and expected to be merged with previous patch and using
> that patch's committing
The upcoming Qemu-3.1 release will bring us two new Hyper-V enlightenments:
hv_ipi and hv_evmcs. Support these in libvirt.
Changes since v1:
- Split patches into 'conf' and 'qemu' [John Ferlan]
- Add entries to docs/news.xml [Andrea Bolognani]
- Add a cleanup PATCH1 removing extra whitespaces
On 11/12/2018 02:50 PM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00339.html
>
> Changes since v1:
>
> * Do the right thing, revert the bad patch and rework it. Thus patch1 is
>the revert and patch2 is the rework. If it's decided that patch2 is
>
Add the support to work with libvirt commit 66a85cb13.
Signed-off-by: John Ferlan
---
Although it's a build breaker and this does fix the problem - I'll wait
to push just to make sure the text used for the message passes muster.
Changes| 2 +-
lib/Sys/Virt.xs| 1 +
Quoting Michal Privoznik (2018-11-14 09:45:07)
> On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> > Move a step closer to the function structure used elsewhere in
> > qemu_process where qemuProcessStart and qemuProcessStop are the exposed
> > functions.
> >
> > qemuProcessStartQmp mirrors
On 11/12/18 8:31 AM, Wang Huaqiang wrote:
> Adding the interface in qemu to report CMT statistic information
> through command 'virsh domstats --cpu-total'.
>
> Below is a typical output:
>
> # virsh domstats 1 --cpu-total
> Domain: 'ubuntu16.04-base'
>...
>
On 11/12/18 8:31 AM, Wang Huaqiang wrote:
> Signed-off-by: Wang Huaqiang
> ---
> docs/news.xml | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 88774c5..3c84126 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -50,6 +50,17 @@
On Fri, 2018-11-02 at 15:52 +0100, Pino Toscano wrote:
> The actual type of an enum in C is implementation defined when there are
> no negative values, and thus it can be int, or uint. This is the case
> of the virError* enums in libvirt, as they do not have negative values.
>
> Hence, to avoid
Support Hyper-V PV IPI enlightenment in domain config. Qemu support will
be implemented in the next patch, adding interim VIR_DOMAIN_HYPERV_IPI cases
to src/qemu/* for now.
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
docs/schemas/domaincommon.rng | 5 +
On Fri, Nov 02, 2018 at 03:52:23PM +0100, Pino Toscano wrote:
> The actual type of an enum in C is implementation defined when there are
> no negative values, and thus it can be int, or uint. This is the case
> of the virError* enums in libvirt, as they do not have negative values.
>
> Hence, to
On Wed, 2018-11-14 at 15:19 +0800, Han Han wrote:
> When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it
> always returns 0 or no snapshot. Because we never implement funtions
> to list no-metadata snapshot in virDomainSnapshotObjListGetNames():
>
> if ((data.flags &
Remove redundant leading whitespaces from " on, off".
Suggested-by: Andrea Bolognani
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index
Support Hyper-V Enlightened VMCS in domain config. Qemu support will
be implemented in the next patch, adding interim VIR_DOMAIN_HYPERV_EVMCS
cases to src/qemu/* for now.
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
docs/schemas/domaincommon.rng | 5 +
Qemu 3.1 supports Hyper-V Enlightened VMCS feature which significantly
speeds up nested Hyper-V on KVM environments.
Signed-off-by: Vitaly Kuznetsov
---
docs/news.xml | 9 +
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_parse_command.c
Qemu 3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
guests to send an IPI, especially when it targets many CPUs.
Signed-off-by: Vitaly Kuznetsov
---
docs/news.xml | 9 +
src/qemu/qemu_command.c | 2 +-
On Wed, Nov 14, 2018 at 05:19:35PM +0100, Andrea Bolognani wrote:
> On Tue, 2018-11-13 at 15:36 -0500, John Ferlan wrote:
> > From: Nikolay Shirokovskiy
> >
> > This patch introduces a new shutdown reason "daemon" in order
> > to indicate that the daemon needed to force shutdown the domain
> >
On Tue, 2018-11-13 at 15:36 -0500, John Ferlan wrote:
> From: Nikolay Shirokovskiy
>
> This patch introduces a new shutdown reason "daemon" in order
> to indicate that the daemon needed to force shutdown the domain
> as the best course of action to take at the moment.
>
> This action would
On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote:
> Support Hyper-V PV IPI enlightenment in domain config. Qemu support will
s/Qemu/QEMU/
> be implemented in the next patch, adding interim VIR_DOMAIN_HYPERV_IPI cases
> to src/qemu/* for now.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
>
This commit includes new test cases to cover LXC version 3.0 and higher.
This LXC version rebased some settings entries and deprecated other ones.
As we support both, we should include tests to minimize problems with
integration between them.
Signed-off-by: Julio Faracco
---
This series adds enhacements for LXC to cover rebased config settings
for version 3.0 without remove legacy ones. This serie includes some
test cases to cover new config files too. The title mentions the word
"partial" because there is a huge change with network settings which
this commit does not
On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote:
> Remove redundant leading whitespaces from " on, off".
In the subject: s/whitespate/whitespace/
With that fixed,
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
Signed-off-by: John Ferlan
---
Something I know even less about ;-)... Although I see Daniel has noted
he'll take care of it - I figured I'd give it a "go" (sorry) anyway.
domain.go | 1 +
1 file changed, 1 insertion(+)
diff --git a/domain.go b/domain.go
index 3a3ef5b..e011980 100644
---
The function qemuDomainGetHostdevPath() is using VIR_FREE to free the
paths stored in tmpPaths. Both syntax analyzer are reporting a warning
about this. Replacing the old method to function
virStringListFreeCount() fixes the warnings/errors.
Signed-off-by: Julio Faracco
---
Do you have any other suggestion for this?
I tried to keep it as simple as possible. Without creating new XML files for V3.
--
Julio Cesar Faracco
Em qua, 14 de nov de 2018 às 15:26, Julio Faracco
escreveu:
>
> This commit includes new test cases to cover LXC version 3.0 and higher.
> This LXC
This patch introduce the new settings for LXC 3.0 or higher. The older
versions keep the compatibility to deprecated settings for LXC, but
after release 3.0, the compatibility was removed. This commit adds the
support to the refactored settings.
v1-v2: Michal's suggestions to handle differences
This new helper can be used to spawn a child process and run
passed callback from it. This will come handy esp. if the
callback is not thread safe.
Signed-off-by: Michal Privoznik
Reviewed-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virprocess.c| 86
flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
releases ship pyflakes 2.0.0 these days.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/build/projects/libvirt-dbus.yml | 4 +---
projects/libvirt-dbus.yaml | 4 +---
2 files changed, 2 insertions(+), 6
Adding the maxCpus value in the error message of qemuValidateCpuCount
allows the user to set an acceptable maxCpus count without knowing
QEMU internals.
x86 guests, that might have been created prior to the x86
qemuDomainDefValidate maxCpus check code (that validates the maxCpus value
in editing
Previous patch removed the call to qemuProcessValidateCpuCount
from qemuProcessStartValidateXML, in qemu_process.c. The only
caller left is qemuDomainDefValidate, in qemu_domain.c.
Instead of having a public function declared inside qemu_process.c
that isn't used in that file, this patch moves
On 11/14/18 12:25 PM, Julio Faracco wrote:
> This series adds enhacements for LXC to cover rebased config settings
> for version 3.0 without remove legacy ones. This serie includes some
> test cases to cover new config files too. The title mentions the word
> "partial" because there is a huge
qemuValidateCpuCount validates the maxCpus value of a domain at
startup time, preventing it to start if the value exceeds a maximum.
This checking is also done at qemu_domain.c, qemuDomainDefValidate.
However, it is done only for x86 (and even then, in a specific
scenario). We want this check to
Adding maxCpu validation in qemuDomainDefValidate allows the user to
spot over the board maxCpus counts at editing time, instead of
facing a runtime error when starting the domain. This check is also
arch independent.
This leaves us with 2 calls to qemuProcessValidateCpuCount: one in
Commit ("qemu_domain.c: moving maxCpu validation to
qemuDomainDefValidate") shortened the code of qemuProcessStartValidateXML.
The function is called only by qemuProcessStartValidate, in the
same file, and its code is now a single check that calls virDomainDefValidate.
Instead of leaving a
On 11/14/18 12:32 PM, Julio Faracco wrote:
> The function qemuDomainGetHostdevPath() is using VIR_FREE to free the
> paths stored in tmpPaths. Both syntax analyzer are reporting a warning
> about this. Replacing the old method to function
> virStringListFreeCount() fixes the warnings/errors.
>
Fix a broken non-Linux build to use the !virFileIsDir instead
Signed-off-by: John Ferlan
---
Pushed as build breaker fix for
https://travis-ci.org/libvirt/libvirt/builds/455121079
All I can say is, well that wasn't obvious... Who knew!
src/util/virresctrl.c | 2 +-
1 file changed, 1
On 11/14/18 4:25 AM, Daniel P. Berrangé wrote:
> On Tue, Nov 13, 2018 at 03:21:03PM -0500, John Ferlan wrote:
>> Sending as an RFC primarily because I'm looking for whether either
>> or both mechanisms in the series is more or less desired. Likewise,
>> if it's felt that the current process of
v2:
- original patch was split in 3 patches as John Ferlan requested;
- patches 4 and 5 are cleanups;
- first patch link:
https://www.redhat.com/archives/libvir-list/2018-October/msg00251.html
Daniel Henrique Barboza (5):
qemu_process.c: adding maxCpus value to error message
qemu_process.c:
On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote:
> Support Hyper-V Enlightened VMCS in domain config. Qemu support will
s/Qemu/QEMU/
With that fixed,
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote:
> Qemu 3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
s/Qemu/QEMU/
Better than in v1 but not quite perfect yet ;)
[...]
> +
> +
> + qemu: Add Hyper-V PV IPI support
> +
> +
> +
On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote:
> Qemu 3.1 supports Hyper-V Enlightened VMCS feature which significantly
s/Qemu/QEMU/
[...]
> +
> +
> + qemu: Add Hyper-V Enlightened VMCS support
> +
> +
> + The QEMU driver now has
This is a simple removal of a duplicated check of the return of the
filter function. There is a nested conditional checking exactly the same
thing.
Signed-off-by: Julio Faracco
---
src/rpc/virnetserverclient.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Quoting Michal Privoznik (2018-11-14 09:45:06)
> On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> > Make process code usable outside qemu_capabilities by moving code
> > from qemu_capabilities to qemu_process and exposing public functions.
> >
> > The process code is used to activate a non
On 11/13/18 3:29 AM, Daniel P. Berrangé wrote:
On Mon, Nov 12, 2018 at 11:33:04AM -0700, Jim Fehlig wrote:
On 11/12/18 4:26 AM, Daniel P. Berrangé wrote:
On Fri, Nov 02, 2018 at 04:34:02PM -0600, Jim Fehlig wrote:
A dry run can be used as a best-effort check that a migration command
will
Missed during review and surprisingly my run through Coverity also
didn't see this. I only noticed it when reading the code while fixing
the build breaker for commit 36780a86a.
With all those continues we would leak @stats.
Signed-off-by: John Ferlan
---
Pushing under trivial rule.
On 11/14/18 12:49 PM, Julio Faracco wrote:
> This is a simple removal of a duplicated check of the return of the
> filter function. There is a nested conditional checking exactly the same
> thing.
s/./ since commit c9ede1cf removed the (ret > 0) check condition./
>
> Signed-off-by: Julio
93 matches
Mail list logo
