On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Let 'virDomainResctrlVcpuMatch' return a pointer of
@virDomainResctrlDefPtr in its third parameter.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 33 ++---
1
On 2019年05月27日 23:27, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
@n denotes the number of element under
element in function 'virDomainCachetuneDefParse' or the number of
element under element in function
virDomainMemorytuneDefParse'.
Originally it is using
On Tue, May 28, 2019 at 10:29:43AM +0200, Pino Toscano wrote:
> This way no non-namespaced OCaml C symbols are used, reducing the risk
> of clashes with other code.
>
> Signed-off-by: Pino Toscano
> ---
> libvirt/Makefile.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Sun, 26 May 2019 23:43:42 -0400
Yan Zhao wrote:
> migration_version attribute is used to check migration compatibility
> between two mdev device of the same mdev type.
s/device/devices/
> The key is that it's rw and its data is opaque to userspace.
>
> Userspace reads migration_version of
On Sun, 26 May 2019 23:44:37 -0400
Yan Zhao wrote:
> This feature implements the migration_version attribute for Intel's vGPU
> mdev devices.
>
> migration_version attribute is rw.
> It's used to check migration compatibility for two mdev devices of the
> same mdev type.
> migration_version
On 5/28/19 10:32 AM, Huaqiang,Wang wrote:
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Export virResctrlMonitorGetStats and make
virResctrlMonitorGetCacheOccupancy obsoleted.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
On 5/28/19 10:32 AM, Huaqiang,Wang wrote:
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Refactor 'virResctrlMonitorStats' to track multiple statistical
records.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 2 +-
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Plan to support Resctrl Control Monitors, which is a feature introduced
by kernel 'resctrl' sub-model. Submit some cleanup and refactoring
patches
for upcoming memory bandwidth resource monitoring (MBM)
Apply renaming of 36603bc56 for the vz driver.
Signed-off-by: Nikolay Shirokovskiy
---
Pushed as build breaker/trivial.
src/vz/vz_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index dfd49e7..2286f9a 100644
---
On 5/28/19 10:32 AM, Huaqiang,Wang wrote:
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Refactor 'virResctrlMonitorFreeStats' to let it available to free
the 'virResctrlMonitorStatsPtr' variable.
Signed-off-by: Wang Huaqiang
---
On Tue, May 28, 2019 at 05:01:35PM +0800, Cornelia Huck wrote:
> On Sun, 26 May 2019 23:44:37 -0400
> Yan Zhao wrote:
>
> > This feature implements the migration_version attribute for Intel's vGPU
> > mdev devices.
> >
> > migration_version attribute is rw.
> > It's used to check migration
On Tue, May 28, 2019 at 04:53:32PM +0800, Cornelia Huck wrote:
> On Sun, 26 May 2019 23:43:42 -0400
> Yan Zhao wrote:
>
> > migration_version attribute is used to check migration compatibility
> > between two mdev device of the same mdev type.
>
> s/device/devices/
>
yes... sorry and thanks :)
On 2019.05.26 23:44:37 -0400, Yan Zhao wrote:
> This feature implements the migration_version attribute for Intel's vGPU
> mdev devices.
>
> migration_version attribute is rw.
> It's used to check migration compatibility for two mdev devices of the
> same mdev type.
> migration_version string is
On Mon, 27 May 2019 18:36:25 +0200
Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > QEMU will crash when device-memory-region-size property is read if
> > ms->device_memory
> > wasn't initialized yet (ex: property being inspected during preconfig
> > time).
>
> Reproduced:
>
>
On Sat, May 25, 2019 at 09:34:36AM +0200, Daniel Veillard wrote:
> We should enter freeze for 5.4.0 beginning of next week, maybe Monday
> evening or Tuesday morning, then plan for RC2 around Wed - Thur for a w.e.
> release.
>
> Hope this works for everybody,
>
>thanks,
>
> Daniel
I
On Tue, 2019-05-28 at 13:34 +0200, Daniel Veillard wrote:
> On Tue, May 28, 2019 at 01:14:19PM +0200, Ján Tomko wrote:
> > This reverts commit 8a1179831b5edc0a3590489eda693914fc0ff94f.
> >
> > It bumped the version prematurely, before the EOL of Fedora 28.
Yeah, that was my bad :( I'll be more
This is tagged in git, I have put the signed tarball and source RPM at
the usual place:
https://libvirt.org/sources/
I did not build the binaries rpms, first it broke because I was still on F28
c.f. Jan's patch, and second it's true to provides little value, it's doubtful
people would just
This reverts commit 8a1179831b5edc0a3590489eda693914fc0ff94f.
It bumped the version prematurely, before the EOL of Fedora 28.
Morover, this arbitrary bump did not let us perform any cleanups in the
specfile.
Signed-off-by: Ján Tomko
---
libvirt.spec.in | 2 +-
mingw-libvirt.spec.in | 2
Adds detection of a Quobyte shared file system for
live migration.
Signed-off-by: Silvan Kaiser
---
src/util/virfile.c| 13 -
src/util/virfile.h| 1 +
tests/virfiledata/mounts3.txt | 1 +
tests/virfilemock.c | 3 +++
tests/virfiletest.c
On 28.05.2019 15:55, Peter Krempa wrote:
> On Tue, May 28, 2019 at 14:34:18 +0300, Nikolay Shirokovskiy wrote:
>> The function updates vm->newDef and frees previous pesistent definition
>> which can be used by in different thread by some API that unlocks domain
>> to communicate to qemu. So we
The function updates vm->newDef and frees previous pesistent definition
which can be used by in different thread by some API that unlocks domain
to communicate to qemu. So we have an access to freed memory in that
thread. Let's acquire job condition when changing persistent xml.
Signed-off-by:
On Tue, May 28, 2019 at 01:14:19PM +0200, Ján Tomko wrote:
> This reverts commit 8a1179831b5edc0a3590489eda693914fc0ff94f.
>
> It bumped the version prematurely, before the EOL of Fedora 28.
> Morover, this arbitrary bump did not let us perform any cleanups in the
> specfile.
Right, that said
On Tue, May 28, 2019 at 14:34:18 +0300, Nikolay Shirokovskiy wrote:
> The function updates vm->newDef and frees previous pesistent definition
> which can be used by in different thread by some API that unlocks domain
> to communicate to qemu. So we have an access to freed memory in that
> thread.
On 5/28/19 1:34 PM, Nikolay Shirokovskiy wrote:
> The function updates vm->newDef and frees previous pesistent definition
> which can be used by in different thread by some API that unlocks domain
> to communicate to qemu. So we have an access to freed memory in that
> thread. Let's acquire job
On Mon, 27 May 2019 20:38:57 +0200
Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > '-numa mem' option has a number of issues and mgmt often defaults
> > to it. Unfortunately it's no possible to replace it with an alternative
> > '-numa memdev' without breaking migration compatibility.
All current IOMMU features are specific to Intel IOMMU, so
understandably we check for the corresponding capabilities
inside the Intel-specific switch() branch; however, we want
to make sure SMMUv3 IOMMU users get an error if they try to
enable any of those features in their guest, and performing
Signed-off-by: Andrea Bolognani
---
docs/formatdomain.html.in | 7 +++--
docs/schemas/domaincommon.rng | 5 ++-
src/conf/domain_conf.c| 1 +
src/conf/domain_conf.h| 1 +
src/qemu/qemu_command.c
https://bugzilla.redhat.com/show_bug.cgi?id=1575526
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 4 +++-
tests/qemuxml2argvdata/iommu-smmuv3.aarch64-latest.args | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
This capability can be used to figure out whether the
QEMU binary at hand supports the machine type property
we need in order to enable SMMUv3 IOMMU support.
Unfortunately we can't avoid probing the RISC-V binaries
along with the ARM ones, since both architectures have
their own 'virt' machine
Current capability checks are specific to Intel IOMMU, so
we need to move them inside the switch() statement before
we can introduce more virDomainIOMMUModel values.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 28 ++--
1 file changed, 14 insertions(+),
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 4a3aa26d7e..dd7ea0941d 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6928,7 +6928,7
This doesn't make a whole lot of difference now, but once
we introduce more virDomainIOMMUModel values the current
structure will no longer work.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index fcc6caf42f..4a3aa26d7e 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6930,7 +6930,6
On Tue, May 28, 2019 at 05:28:54PM +0200, Andrea Bolognani wrote:
Ensure unexpected values are dealt with correctly, that
is by invoking virReportEnumRangeError() and immediately
returning a negative value to the caller.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 10
On Tue, May 28, 2019 at 05:28:58PM +0200, Andrea Bolognani wrote:
Current capability checks are specific to Intel IOMMU, so
we need to move them inside the switch() statement before
we can introduce more virDomainIOMMUModel values.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c |
On Tue, May 28, 2019 at 05:29:01PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 14 ++
1 file changed, 14 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
On Tue, May 28, 2019 at 05:29:00PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
Given the diffstat, it would be nice to have something in the commit
message, e.g. a copy of the text from the news or an XML snippet.
---
docs/formatdomain.html.in | 7
On Tue, May 28, 2019 at 05:29:04PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 9922cd4de0..792293686f 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -41,6
This way no non-namespaced OCaml C symbols are used, reducing the risk
of clashes with other code.
Signed-off-by: Pino Toscano
---
libvirt/Makefile.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt/Makefile.in b/libvirt/Makefile.in
index 3a68aed..77462c7 100644
---
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Refactor 'virResctrlMonitorFreeStats' to let it available to free
the 'virResctrlMonitorStatsPtr' variable.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 1 +
src/util/virresctrl.c | 4
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Export virResctrlMonitorGetStats and make
virResctrlMonitorGetCacheOccupancy obsoleted.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 33
On 2019年05月27日 23:26, Michal Privoznik wrote:
On 5/23/19 11:34 AM, Wang Huaqiang wrote:
Refactor 'virResctrlMonitorStats' to track multiple statistical
records.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 2 +-
src/util/virresctrl.c | 17 ++---
On 5/22/19 7:52 PM, Andrea Bolognani wrote:
This series changes our install procedure so that we install all
available examples on the target system; in the process, it also
removes all custom shell code from the installation procedure,
replacing it with standard autotools usage, and fixes a few
This is the ARM equivalent of Intel IOMMU.
Andrea Bolognani (11):
qemu: Fix switch() statements for virDomainIOMMUModel
qemu: Drop 'ret' from qemuBuildIOMMUCommandLine()
qemu: Use VIR_AUTOCLEAN() in qemuBuildIOMMUCommandLine()
qemu: Move virBuffer inside switch() statement
qemu: Move
Ensure unexpected values are dealt with correctly, that
is by invoking virReportEnumRangeError() and immediately
returning a negative value to the caller.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 10 --
src/qemu/qemu_domain.c | 1 +
2 files changed, 9
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 9922cd4de0..792293686f 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -41,6 +41,14 @@
+
+
+ qemu: Support SMMUv3
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 9802952046..3290cdae5f 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -6136,6 +6136,20 @@
On Tue, May 28, 2019 at 05:28:55PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
On Tue, May 28, 2019 at 05:28:57PM +0200, Andrea Bolognani wrote:
This doesn't make a whole lot of difference now, but once
we introduce more virDomainIOMMUModel values the current
structure will no longer work.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 11 +++
1
On Tue, May 28, 2019 at 05:28:59PM +0200, Andrea Bolognani wrote:
This capability can be used to figure out whether the
QEMU binary at hand supports the machine type property
we need in order to enable SMMUv3 IOMMU support.
Unfortunately we can't avoid probing the RISC-V binaries
along with the
The function updates vm->newDef and frees previous pesistent definition
which can be used by in different thread by some API that unlocks domain
to communicate to qemu. So we have an access to freed memory in that
thread. Let's acquire job condition in case of updating exiting domain.
On Tue, May 28, 2019 at 05:28:56PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
On Tue, May 28, 2019 at 05:29:02PM +0200, Andrea Bolognani wrote:
All current IOMMU features are specific to Intel IOMMU, so
understandably we check for the corresponding capabilities
inside the Intel-specific switch() branch; however, we want
to make sure SMMUv3 IOMMU users get an error if they
On Tue, May 28, 2019 at 05:29:03PM +0200, Andrea Bolognani wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1575526
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 4 +++-
tests/qemuxml2argvdata/iommu-smmuv3.aarch64-latest.args | 2 +-
2 files
54 matches
Mail list logo
