Let's change the refresh script in order to take into consideration
Dockerfiles containing the project's name. This is needed in order to
add different projects to libvirt-dockerfiles.
An important change that deservers a mention here is that the PROJECTS
variable, part of Dockerfile class, has
The corresponding libvirt-jenkins-ci commit is 81eabc6f888a3.
Signed-off-by: Fabiano Fidêncio
---
buildenv-libosinfo-centos-7.Dockerfile| 43 +
...bosinfo-debian-10-cross-aarch64.Dockerfile | 64 +++
...ibosinfo-debian-10-cross-armv6l.Dockerfile | 64
Signed-off-by: Fabiano Fidêncio
---
refresh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refresh b/refresh
index 1db0fc8..aa056af 100755
--- a/refresh
+++ b/refresh
@@ -34,7 +34,7 @@ class Dockerfile:
def __init__(self, path):
# Files that don't end with
Hi Michal,
Thanks for review, have a good day!
Br
Huaqiang
> -Original Message-
> From: Michal Privoznik [mailto:mpriv...@redhat.com]
> Sent: Wednesday, July 31, 2019 8:38 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Su, Tao
> Subject: Re: [libvirt] [PATCHv2 00/11]
On 7/31/19 9:53 AM, Michal Privoznik wrote:
On 7/23/19 7:35 PM, Daniel Henrique Barboza wrote:
This code that executes virPCIDeviceReset in all virPCIDevicePtr
objects of a given virPCIDeviceListPtr list is replicated twice
in the code. Putting it in a helper function helps with
readability.
This patch series aims to add libosinfo Dockerfiles to this project, so
those containers can be used by libosinfo projects' gitlab CI.
Please, take a look at each patch for more context of what has been done.
Changes since v1:
https://www.redhat.com/archives/libvir-list/2019-July/msg01296.html
-
libosinfo Dockerfile will consist on a single container that will be
able to build & test libosinfo, osinfo-db-tools, and osinfo-db. And from
those "subprojects", only libosinfo and osinfo-db-tools are subject for
mingw builds.
Signed-off-by: Fabiano Fidêncio
---
refresh | 5 +
1 file
On Wed, Jul 31, 2019 at 2:16 PM Andrea Bolognani wrote:
>
> On Wed, 2019-07-31 at 13:56 +0200, Andrea Bolognani wrote:
> > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > > libsoup & mingw-libsoup are new dependencies for both libosinfo &
> > > osinfo-db-tools since v1.6.0 release
If the nbd export name contains a colon, our parser would not parse it
properly as we split the string by colons. Modify the code to look up
the exportname and copy any trailing characters as the export name is
supposed to be at the end of the string.
On Wed, Jul 31, 2019 at 09:36:47AM +0100, Daniel P. Berrangé wrote:
On Wed, Jul 31, 2019 at 10:32:19AM +0200, Michal Privoznik wrote:
QEMU is perfectly capable of dealing with fully expanded PCI
address. Format PCI domain always as it will simplify next
commits.
Are you sure about that for
On 7/29/19 10:23 AM, Changlimin wrote:
For some servers, PCI domain is great than
# lspci
1:00:00.0 PCI bridge: Intel Corporation Sky Lake-E PCI Express Root Port A
(rev 04)
1:00:01.0 PCI bridge: Intel Corporation Sky Lake-E PCI Express Root Port B
(rev 04)
1:00:02.0 PCI
On Wed, Jul 31, 2019 at 10:32:19AM +0200, Michal Privoznik wrote:
> QEMU is perfectly capable of dealing with fully expanded PCI
> address. Format PCI domain always as it will simplify next
> commits.
Are you sure about that for old QEMUs ? I have a feeling that
it did not support that in the
On Tue, 2019-07-30 at 23:30 +0200, Andrea Bolognani wrote:
> On Mon, 2019-07-29 at 18:11 +0100, Daniel P. Berrangé wrote:
> > +++ b/src/remote/remote_protocol.x
> > @@ -6538,7 +6546,7 @@ enum remote_procedure {
> > */
> > REMOTE_PROC_NETWORK_PORT_DELETE = 410,
> >
> > - /**
> > +
Currently, the way we format PCI address is using printf-s
precision, e.g. "%.4x". This works if we don't want to print any
value outside of bounds (which is usually the case). However,
turns out, PCI domain can be 0x1 which doesn't work well with
our format strings. However, if we change the
There is no restriction on maximum value of PCI domain. In fact,
Linux kernel uses plain atomic inc when assigning PCI domains:
drivers/pci/pci.c:static int pci_get_new_domain_nr(void)
drivers/pci/pci.c-{
drivers/pci/pci.c- return atomic_inc_return(&__domain_nr);
drivers/pci/pci.c-}
Of
The format string for a PCI address is copied over and over
again, often with slight adjustments. Introduce global
VIR_PCI_DEVICE_ADDRESS_FMT macro that holds the formatting string
and use it wherever possible.
Signed-off-by: Michal Privoznik
---
src/conf/domain_audit.c | 3 ++-
In near future, the length restriction of PCI domain is going to
be lifted. This means that our assumption that PCI address is 13
bytes long is no longer true. We can avoid this problem by making
@name dynamically allocated and thus not bother with actual
length of stringified PCI address.
This function declares @ret variable and then uses
VIR_STEAL_PTR() to avoid freeing temporary variable @dev which is
constructed. Well, as of 267f1e6da53 we have VIR_RETURN_PTR()
macro so that we can avoid this pattern.
Signed-off-by: Michal Privoznik
---
src/util/virpci.c | 16 ++--
QEMU is perfectly capable of dealing with fully expanded PCI
address. Format PCI domain always as it will simplify next
commits.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 8
tests/qemuxml2argvdata/hostdev-pci-address-device.args
As reported here [1], a PCI domain can be just any number. Well, not in
case of traditional 32-bit PCI, bit in case of PCI-X (64-bit PCI; not to
be confused with PCI Express), the PCI domain number can really be just
anything. I wanted to download the specification from PCI SIG web but
it's paid
On Wed, 2019-07-31 at 13:56 +0200, Andrea Bolognani wrote:
> On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > libsoup & mingw-libsoup are new dependencies for both libosinfo &
> > osinfo-db-tools since v1.6.0 release
> > libcurl & mingw-curl are no longer a dependency for libosinfo
On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani wrote:
>
> On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > It's been introduced as dependency as part of v1.6.0 release.
>
> Is that so? Because the native build has had the dependency on
> libsoup ever since
>
> commit
On 7/31/19 10:36 AM, Daniel P. Berrangé wrote:
On Wed, Jul 31, 2019 at 10:32:19AM +0200, Michal Privoznik wrote:
QEMU is perfectly capable of dealing with fully expanded PCI
address. Format PCI domain always as it will simplify next
commits.
Are you sure about that for old QEMUs ? I have a
Employees from these companies have made contributions to
libvirt over the past few releases.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
docs/gitdm/companies/others | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others
Andrea Bolognani writes:
> On Mon, 2019-07-29 at 18:11 +0100, Daniel P. Berrangé wrote:
>> util: storage identity attrs as virTypedParameter internally
>
>> -if (virStrToLong_i(userid, NULL, 10, ) < 0)
>> +ret = virTypedParamsGetULLong(ident->params,
>> +
On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> It's been introduced as dependency as part of v1.6.0 release.
Is that so? Because the native build has had the dependency on
libsoup ever since
commit 1eab5a66eb0abd922a67e2c96a4c46efce525548
Author: Andrea Bolognani
Date: Tue
On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> libsoup & mingw-libsoup are new dependencies for both libosinfo &
> osinfo-db-tools since v1.6.0 release
> libcurl & mingw-curl are no longer a dependency for libosinfo since
> v1.5.0 release
>
> Fabiano Fidêncio (6):
> mappings: Add
On Wed, Jul 31, 2019 at 10:32:18AM +0200, Michal Privoznik wrote:
As reported here [1], a PCI domain can be just any number. Well, not in
case of traditional 32-bit PCI, bit in case of PCI-X (64-bit PCI; not to
be confused with PCI Express), the PCI domain number can really be just
anything. I
On Wed, Jul 31, 2019 at 10:32:24AM +0200, Michal Privoznik wrote:
There is no restriction on maximum value of PCI domain. In fact,
Linux kernel uses plain atomic inc when assigning PCI domains:
drivers/pci/pci.c:static int pci_get_new_domain_nr(void)
drivers/pci/pci.c-{
drivers/pci/pci.c-
Commit fed58d83 was a hack to fix a mingw build failure due to header
inclusion order resulting in a clash over the use of DATADIR, by
repeating a trick made several other times in the past of tweaking
inclusion order until it goes away. Better is to revert that, and
instead use pragmas to avoid
Eric,
On 7/31/19 4:52 PM, Eric Blake wrote:
On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
Max,
Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
failing, but they are also failing on master, thus I say this patch get a
pass because it didn't break anything else.
What
There is a chance that the current sed filtering used in
these new tests might fail in some machines due to the
repetition of the 'virsh #' prompt at the same line,
together with valid output that shouldn't be filtered.
This is output of virsh-snapshot test in my T480 dev box:
./virsh-snapshot
Signed-off-by: Jim Fehlig
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 82a4ec9c84..3a20f95a0d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -74,6 +74,17 @@
which portions of a disk have changed since a point
On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
> Max,
>
> Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
> failing, but they are also failing on master, thus I say this patch get a
> pass because it didn't break anything else.
What failures are you seeing? Those were just
Max,
Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
failing, but they are also failing on master, thus I say this patch get a
pass because it didn't break anything else.
Reviewed-by: Daniel Henrique Barboza
On 7/23/19 4:47 PM, Maxiwell S. Garcia wrote:
The
The xencommons service provides all the essential services such as
xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so
libvirtd should be started after xencommons.
The xendomains service uses Xen's xl tool to operate on any domains it
finds running, even those managed by libvirt.
On Wed, 2019-07-31 at 14:24 +0200, Fabiano Fidêncio wrote:
> On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani wrote:
> > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > > It's been introduced as dependency as part of v1.6.0 release.
> >
> > Is that so? Because the native build has
On 6/11/19 5:31 AM, Wang Huaqiang wrote:
Patches submitted for purpose of refactoring existing 'resctrl' related
source code, including some code cleanups as well as some fixes. This is
also a preparation for memory bandwidth monitor codes.
Plan to support Resctrl Control Monitors, which is a
On Wed, Jul 31, 2019 at 2:37 PM Andrea Bolognani wrote:
>
> On Wed, 2019-07-31 at 14:24 +0200, Fabiano Fidêncio wrote:
> > On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani
> > wrote:
> > > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > > > It's been introduced as dependency as
On 7/23/19 7:35 PM, Daniel Henrique Barboza wrote:
This code that executes virPCIDeviceReset in all virPCIDevicePtr
objects of a given virPCIDeviceListPtr list is replicated twice
in the code. Putting it in a helper function helps with
readability.
Signed-off-by: Daniel Henrique Barboza
---
On 7/23/19 7:35 PM, Daniel Henrique Barboza wrote:
changes in v2:
- changed the parameter order in the function calls
- gave up on moving virPCIDeviceSetX(pci, true) calls to
virPCIDeviceReattach(). The attributes being set changes
the behavior of virPCIDeviceReattach() in a more complex
way
On Tue, 2019-07-30 at 16:52 -0500, Eric Blake wrote:
> backup: Add news entry for checkpoints
s/backup/news/
With that changed
Reviewed-by: Andrea Bolognani
and safe for freeze. Thanks for taking care of the release notes!
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list
On Wed, 2019-07-31 at 11:57 +0800, Han Han wrote:
> +
> + Support encrypted soft tpm
> +
> +
> + A soft tpm backend could be encrypted with passphrase. Now libvirt
> + supports to use secret object to hold the passphrase,
> + and refers
On Wed, 2019-07-31 at 11:57 +0800, Han Han wrote:
> +
> + qemu: Allow to validate xml for snapshot creation
> +
> +
> + Add flag VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE to
> validate
> + snapshot input xml. For virsh, users can use it as virsh
> +
On 7/30/19 10:57 PM, Han Han wrote:
> Signed-off-by: Han Han
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 1134309ec2..6d90ea8389 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -76,6 +76,16 @@
>
On 7/30/19 10:57 PM, Han Han wrote:
> Signed-off-by: Han Han
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 6d90ea8389..660706c12c 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -86,6 +86,16 @@
>
46 matches
Mail list logo
