[libvirt] [PATCH 07/10] qemu: Pass correct qemuCaps to virDomainDefCopy

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 06/10] qemu: Pass qemuCaps to qemuMigrationCookieXMLParse

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 03/10] qemu: Pass qemuCaps to qemuDomainSaveImageOpen

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH v2] qemu: check if numa cell's cpu range match with cpu topology count

QEMU shows a warning message if partial NUMA mapping is set. This patch adds a warning message in libvirt when editing the XML. It must be an error in future, when QEMU remove this ability. Signed-off-by: Maxiwell S. Garcia --- src/qemu/qemu_domain.c | 19 ++- 1 file changed, 14

[libvirt] [PATCH 01/10] qemu: Pass qemuCaps to qemuDomainDefCopy

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 10/10] qemu: Pass correct qemuCaps to virDomainDeviceDefPostParse

Since qemuDomainDeviceDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens

[libvirt] [PATCH 09/10] qemu: Pass correct qemuCaps to virDomainDefParseNode

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 05/10] qemu: Pass correct qemuCaps to virDomainDefParseString

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 02/10] qemu: Pass qemuCaps to qemuDomainDefFormatBufInternal

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 04/10] qemu: Pass qemuCaps to qemuMigrationAnyPrepareDef

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH 00/10] Pass correct qemuCaps to qemuDomainDefPostParse

Since qemuDomain{Device,}DefPostParse callbacks require qemuCaps, we need to make sure they get the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case the cached capabilities are not valid anymore.

[libvirt] [PATCH 08/10] qemu: Pass correct qemuCaps to virDomainDefPostParse

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make sure it gets the capabilities stored in the domain's private data if the domain is running. Passing NULL may cause QEMU capabilities probing to be triggered in case QEMU binary changed in the meantime. When this happens while

[libvirt] [PATCH v2] maint: Improve use of configmake.h on mingw

Gnulib has added a patch that allows configmake.h to be included without causing build failures on mingw if is later included (whether directly, or indirectly such as through gnulib's ). This reverts commit fed58d83c60ff1c20292856bec006577788b7494 ("build: Fix checkpoint_conf on mingw"), now

[libvirt] [PATCH] nss: fix build on freebsd

The conversion to drop gnulib in the previous patch: commit 8242ce4f45700f326e13e5105accd08fb4b2f0b4 Author: Daniel P. Berrangé Date: Thu Aug 8 10:23:26 2019 +0100 tools: avoid accidentally using files from gnulib Missed a few conversions needed for FreeBSD. In particular netdb.h

Re: [libvirt] [PATCH 0/7] add virDomainGetGuestInfo()

On Wed, Aug 07, 2019 at 12:39:09 +0200, Tomáš Golembiovský wrote: > On Thu, Aug 01, 2019 at 08:37:03AM -0500, Jonathon Jongsma wrote: > > This series adds several bits of guest information provided by a new API > > function virDomainGetGuestInfo(). There is an implementation for qemu using > >

[libvirt] sockettest failures on macOS

Hello dear list, As of now there're two test failures of sockettest on macOS: 38) Test format :: family AF_UNSPEC ... Offset 2 Expect [] Actual [0.0.255.255] ... FAILED 89)

Re: [libvirt] [PATCH] configmake: Avoid namespace pollution issue on mingw.

On 8/8/19 8:08 AM, Eric Blake wrote: > Mingw includes a header that declares a struct typedef named DATADIR, > pulled in when including ; compilation fails if DATADIR > has already been defined as a macro expanding to a string prior to > that inclusion. Although the configmake module documents

[libvirt] [PATCH] configmake: Avoid namespace pollution issue on mingw.

Mingw includes a header that declares a struct typedef named DATADIR, pulled in when including ; compilation fails if DATADIR has already been defined as a macro expanding to a string prior to that inclusion. Although the configmake module documents that it should generally be included only after

Re: [libvirt] [PATCH] network: fix ability to use openvswitch with vlans

On 8/8/19 2:45 PM, Daniel P. Berrangé wrote: > Use the correct enum constant when validating vlan usage. > This fixes a merge error in > > commit 6cb0ec48bd95c95489a987e05a88e8bcf1f9109c > Author: Daniel P. Berrangé > Date: Mon Sep 3 17:34:22 2018 +0100 > > network: convert

[libvirt] [PATCH] network: fix ability to use openvswitch with vlans

Use the correct enum constant when validating vlan usage. This fixes a merge error in commit 6cb0ec48bd95c95489a987e05a88e8bcf1f9109c Author: Daniel P. Berrangé Date: Mon Sep 3 17:34:22 2018 +0100 network: convert networkAllocateActualDevice to virNetworkPortDef Signed-off-by:

Re: [libvirt] [PATCH] tools: avoid accidentally using files from gnulib

On 8/8/19 1:00 PM, Daniel P. Berrangé wrote: > The AM_CPPFLAGS setting includes the gnulib headers, which > means we can get some replacement functions defined. Since > virt-login-shell and the NSS module intentionally don't link > to gnulib, these replacement functions causes link failures. > >

Re: [libvirt] [PATCH 0/7] add virDomainGetGuestInfo()

On Wed, Aug 07, 2019 at 10:41:10AM -0500, Jonathon Jongsma wrote: > On Wed, 2019-08-07 at 12:39 +0200, Tomáš Golembiovský wrote: > > On Thu, Aug 01, 2019 at 08:37:03AM -0500, Jonathon Jongsma wrote: > > > This series adds several bits of guest information provided by a > > > new API > > > function

[libvirt] [PATCH] tools: avoid accidentally using files from gnulib

The AM_CPPFLAGS setting includes the gnulib headers, which means we can get some replacement functions defined. Since virt-login-shell and the NSS module intentionally don't link to gnulib, these replacement functions causes link failures. This was seen cross-compiling on Debian for example:

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

On Wed, Aug 07, 2019 at 12:52:17PM +0200, Ilias Stamatis wrote: > On Sun, Aug 4, 2019 at 6:32 PM Erik Skultety wrote: > > > > On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > > > Signed-off-by: Ilias Stamatis > > > --- > > > > > > I deliberately omitted the logic from

[libvirt] [PATCH] tests: Fix message for IP parse/format failures

Confusing message is printed when a parse/format sockettest fails. E.g. there's a test that parses/formats :: and the format fails like that: 38) Test format :: family AF_UNSPEC ... Offset 2 Expect [0.0.255.255] Actual [] It should be instead:

[libvirt] [PATCH] test_driver: implement virDomainGetBlockInfo

Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 40 1 file changed, 40 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6f18baa265..106e8f027e 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

On Wed, 2019-08-07 at 21:15 -0500, Eric Blake wrote: > I'm reverting the patch under the build-breaker rules, while trying to > reproduce the cross-compilation locally rather than relying solely on > CI. My local testing that proved that #pragma push_macro works with gcc > was obviously not

<    1   2