On Thu, Aug 08, 2019 at 06:00:42PM +0200, Peter Krempa wrote:
Now that we support blockdev for qemuDomainBlockCopy we can allow
copying to remote destinations as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 47 --
1 file changed, 32
On Thu, Aug 08, 2019 at 06:00:41PM +0200, Peter Krempa wrote:
Implement job handling for the block copy job (drive/blockdev-mirror)
when using -blockdev. In contrast to the previously implemented
blockjobs the block copy job introduces new images to the running qemu
instance, thus requires a bit
On Thu, Aug 08, 2019 at 06:00:40PM +0200, Peter Krempa wrote:
QEMU finally exposes an interface which allows us to instruct it to
format or create arbitrary images. This is required for blockdev
integration of block copy and snapshots as we need to pre-format images
prior to use with
John Snow writes:
> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>> To get rid of implicit filters related workarounds in future let's
>> deprecate them now.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
[...]
>> diff --git a/blockdev.c b/blockdev.c
>> index
On Thu, Aug 15, 2019 at 12:49:28 +0200, Kevin Wolf wrote:
> Am 14.08.2019 um 21:27 hat John Snow geschrieben:
[...]
> > example:
> >
> > { "return": {},
> > "deprecated": True,
> > "warning": "Omitting filter-node-name parameter is deprecated, it will
> > be required in the future"
> > }
>
On Thu, Aug 15, 2019 at 10:21:59AM +0200, Peter Krempa wrote:
Use 'id' instead of 'name' for anchors which adds the hidden clickable
headerlink helper so it's way simpler to link to a specific part of the
docs.
was deprecated in favor of anyway.
Signed-off-by: Peter Krempa
---
Peter Krempa writes:
> On Thu, Aug 15, 2019 at 12:49:28 +0200, Kevin Wolf wrote:
>> Am 14.08.2019 um 21:27 hat John Snow geschrieben:
>
> [...]
>
>> > example:
>> >
>> > { "return": {},
>> > "deprecated": True,
>> > "warning": "Omitting filter-node-name parameter is deprecated, it will
>> >
From: hexin
The parent bridge configuration of the current device
should be read and reset, instead of reading the current
device configuration.
Signed-off-by: He Xin
Signed-off-by: Liu Qi
Signed-off-by: Zhang Yu
---
src/util/virpci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, Aug 14, 2019 at 15:22:15 -0400, John Snow wrote:
>
>
> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
> > It's hard and not necessary to maintain outdated versions of these
> > commands.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy
> > ---
> > qemu-deprecated.texi |
On Wed, 2019-08-14 at 15:27 -0400, John Snow wrote:
>
> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
> > To get rid of implicit filters related workarounds in future let's
> > deprecate them now.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy
> > ---
> > qemu-deprecated.texi
On Tue, Aug 13, 2019 at 03:45:19PM +0200, Ján Tomko wrote:
> All the callers left require virPCIDeviceConfigOpen to be fatal
> and only use read-only access to the config file.
>
> Signed-off-by: Ján Tomko
> ---
FYI this patch broke make check, both virpcitest and virhostdevtest.
Erik
--
On Thu, Aug 15, 2019 at 10:10:06 +0200, Erik Skultety wrote:
> On Tue, Aug 13, 2019 at 03:45:19PM +0200, Ján Tomko wrote:
> > All the callers left require virPCIDeviceConfigOpen to be fatal
> > and only use read-only access to the config file.
> >
> > Signed-off-by: Ján Tomko
> > ---
>
> FYI
Use 'id' instead of 'name' for anchors which adds the hidden clickable
headerlink helper so it's way simpler to link to a specific part of the
docs.
Signed-off-by: Peter Krempa
---
docs/newapi.xsl | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/newapi.xsl
On Wed, Jul 31, 2019 at 17:22:48 +0200, Peter Krempa wrote:
> If the nbd export name contains a colon, our parser would not parse it
> properly as we split the string by colons. Modify the code to look up
> the exportname and copy any trailing characters as the export name is
> supposed to be at
Am 14.08.2019 um 21:27 hat John Snow geschrieben:
>
>
> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
> > To get rid of implicit filters related workarounds in future let's
> > deprecate them now.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy
> > ---
> > qemu-deprecated.texi
On 8/15/19 6:49 AM, Kevin Wolf wrote:
> Am 14.08.2019 um 21:27 hat John Snow geschrieben:
>>
>>
>> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> To get rid of implicit filters related workarounds in future let's
>>> deprecate them now.
>>>
>>> Signed-off-by: Vladimir
On Thu, Aug 15, 2019 at 05:15:57PM +0200, Michal Privoznik wrote:
> Hold on to your hat, this is going to be a wild ride. As nearly
> nothing in glic, nor open() is a real function. Just look into
> bits/fcntl2.h and you'll see that open() is actually a thin
> wrapper that calls either
On Thu, Aug 15, 2019 at 05:15:56PM +0200, Michal Privoznik wrote:
> The gdb requires ptrace capability, but the way we run containers
> now is that they drop every capability. Preserve SYS_PTRACE then.
>
> Signed-off-by: Michal Privoznik
> ---
Makes sense to me, so I can give you my:
Am 15.08.2019 um 18:07 hat John Snow geschrieben:
>
>
> On 8/15/19 6:49 AM, Kevin Wolf wrote:
> > Am 14.08.2019 um 21:27 hat John Snow geschrieben:
> >>
> >>
> >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
> >>> To get rid of implicit filters related workarounds in future let's
>
The gdb requires ptrace capability, but the way we run containers
now is that they drop every capability. Preserve SYS_PTRACE then.
Signed-off-by: Michal Privoznik
---
Makefile.ci | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.ci b/Makefile.ci
index 8857c953b2..977e0445c6 100644
See 2/2 for explanation.
Michal Prívozník (2):
ci: Allow gdb in containers
virpcimock: Mock __open_2()
Makefile.ci| 1 +
tests/virpcimock.c | 29 +
2 files changed, 30 insertions(+)
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
Hold on to your hat, this is going to be a wild ride. As nearly
nothing in glic, nor open() is a real function. Just look into
bits/fcntl2.h and you'll see that open() is actually a thin
wrapper that calls either __open_alias() or __open_2(). Now,
before 801ebb5edb6 the open() done in
On 8/15/19 12:48 PM, Kevin Wolf wrote:
> Am 15.08.2019 um 18:07 hat John Snow geschrieben:
>> On 8/15/19 6:49 AM, Kevin Wolf wrote:
>>> Am 14.08.2019 um 21:27 hat John Snow geschrieben:
This might be OK to do right away, though.
I asked Markus this not too long ago; do we want
On 8/15/19 10:16 AM, Markus Armbruster wrote:
> John Snow writes:
>
>> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> To get rid of implicit filters related workarounds in future let's
>>> deprecate them now.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>>> ---
> [...]
Signed-off-by: Ilias Stamatis
---
Probably we need to extend the host CPU's capabilities as well along
with this patch. Currently virCPUx86Compare reports "unknown host CPU".
src/test/test_driver.c | 21 +
1 file changed, 21 insertions(+)
diff --git
The current version of get_autostart seg faults. This patch
correctly passes a pointer to an int to virDomainGetAutostart
and returns a result based on the value of that int
Signed-off-by: sage Imel
---
src/domain.rs | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
On 8/15/19 3:44 AM, Peter Krempa wrote:
> On Wed, Aug 14, 2019 at 15:22:15 -0400, John Snow wrote:
>>
>>
>> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> It's hard and not necessary to maintain outdated versions of these
>>> commands.
>>>
>>> Signed-off-by: Vladimir
On 8/14/19 7:13 AM, Michal Privoznik wrote:
> Since users can enable/disable drivers at compile time, it may
> happen that @drivers array is in fact empty (in both its
> occurrences within the function). This means that
> ARRAY_CARDINALITY() returns 0UL which makes gcc unhappy because
> of loop
On Thu, Aug 15, 2019 at 05:15:57PM +0200, Michal Privoznik wrote:
Hold on to your hat, this is going to be a wild ride. As nearly
nothing in glic, nor open() is a real function. Just look into
s/glic/glibc/
bits/fcntl2.h and you'll see that open() is actually a thin
wrapper that calls either
On Wed, Aug 14, 2019 at 06:59:16PM +0200, Peter Krempa wrote:
The function will be reused in the qemu snapshot code. The argument is
turned into const similarly to the other virStorageFileSupports*
functions.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
On Wed, Aug 14, 2019 at 06:59:19PM +0200, Peter Krempa wrote:
None of the callers of qemuDomainStorageUpdatePhysical care about
errors.
Use the new flag for qemuDomainStorageOpenStat which suppresses some
errors and move the reset of the rest of the uncommon errors into this
function. Document
On Wed, Aug 14, 2019 at 06:59:18PM +0200, Peter Krempa wrote:
virStorageSourceUpdatePhysicalSize is called only from
qemuDomainStorageUpdatePhysical and all callers of it reset the libvirt
error if -1 is returned.
Don't bother setting the error in the first place.
Signed-off-by: Peter Krempa
On Wed, Aug 14, 2019 at 06:59:17PM +0200, Peter Krempa wrote:
Some callers of this function actually don't care about errors and reset
it. The message is still logged which might irritate users in this case.
Add a boolean flag which will do few checks whether it actually makes
sense to even try
Commit e69444e17 (first appeared in libvirt-5.5.0) added the new value
"VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS" to the virAccessPerNetwork
enum, and also the string "search_ports" to the VIR_ENUM_IMPL() macro
for that enum. Unfortunately, the enum value was added in the middle
of the list, while the
On Wed, Aug 14, 2019 at 06:59:21PM +0200, Peter Krempa wrote:
The function ignores all errors from qemuStorageLimitsRefresh by calling
virResetLastError. This still logs them. Since qemuStorageLimitsRefresh
allows suppressing some, do so.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c
On Wed, Aug 14, 2019 at 06:59:20PM +0200, Peter Krempa wrote:
qemuStorageLimitsRefresh uses qemuDomainStorageOpenStat internally and
there are callers which don't care about the error. Propagate the
skipInaccessible flag so that we can log less errors.
Callers currently don't care about the
Kevin Wolf writes:
> Am 15.08.2019 um 18:07 hat John Snow geschrieben:
>>
>>
>> On 8/15/19 6:49 AM, Kevin Wolf wrote:
>> > Am 14.08.2019 um 21:27 hat John Snow geschrieben:
>> >>
>> >>
>> >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>> >>> To get rid of implicit filters related
From: Andrea Bolognani
Introduced in commit 4a6ee53581b3.
Signed-off-by: Andrea Bolognani
(cherry picked from commit df1b5cf02efd4fee6f01ebe69fd0f1fd24b3947d)
Reintroduced-by: fb275b76734ba1c0b18ad1088e3c82fb01961903
Signed-off-by: Ján Tomko
---
src/test/test_driver.c | 0
1 file changed, 0
During networkPortCreateXML, if networkAllocatePort() failed,
networkReleasePort() would be called, which would (in the case of
network pools of macvtap passthrough devices) attempt to find the
allocated device by comparing port->plug.direct.linkdev to each device
in the pool. Since
virErrorPreserveLast()/virErrorRestore() (added in commit 8333e7455
back in 2017), do a better better job of saving and restoring the last
libvirt error than virSaveLastError()/virErrorRestore() (they're
simpler, and they also save/restore the system errno).
Signed-off-by: Laine Stump
---
The first patch fixes the bug. The 2nd patch just updates some code
that I noticed while fixing the bug (because I figured someone would
whine that I was just moving around calls to outdated APIs).
Laine Stump (2):
network: fix crash during cleanup from failure to allocate port
network:
41 matches
Mail list logo
