On 8/26/19 6:08 PM, Jonathon Jongsma wrote:
On Mon, 2019-08-26 at 17:29 +0200, Michal Privoznik wrote:
On 8/23/19 6:31 PM, Jonathon Jongsma wrote:
Iimplements the new guest information API by querying requested
information via the guest agent.
Signed-off-by: Jonathon Jongsma
---
On Fri, Aug 23, 2019 at 12:51:56PM -0400, Cole Robinson wrote:
On 8/23/19 12:21 PM, Cole Robinson wrote:
From: Marc-André Lureau
Accept a new attribute to specify usage of helper process, ex:
For other devices, we have
Which is an attempt to make this more generic.
IMO
On Fri, Aug 23, 2019 at 12:21:46PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
Accept a new attribute to specify usage of helper process, ex:
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
docs/formatdomain.html.in | 6 ++
Bjoern Walk [2019-08-20, 12:19PM +0200]:
> Boris Fiuczynski [2019-08-13, 05:40PM +0200]:
> > Changes in v2:
> > 1. moved refactoring into separate patch
> > 2. removed line misalignment
> > 3. moved valition from command line generator into domain xml validation
> > 4. added tests for vfio-ap
I am trying to create a VM with added persistent memory using virsh. It
fails when persistent memory namespace size is larger than available system
memory. Please see error below, prealloc=yes is set in the command line.
For dax type namespace, as I understand, prealloc should not be needed. Is
On Fri, Aug 23, 2019 at 12:21:55PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
Similar to the qemu_tpm.c, add a unit with a few functions to
start/stop and setup the cgroup of the external vhost-user-gpu
process. See function documentation.
Since the vhost-user connection fd isn't
On Fri, Aug 23, 2019 at 12:22:00PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
.../vhost-user-gpu-secondary.args | 38
.../vhost-user-gpu-secondary.xml | 44 +++
On Mon, Aug 26, 2019 at 04:06:47PM +0200, Ján Tomko wrote:
> On Fri, Aug 23, 2019 at 04:11:42PM +0100, Daniel P. Berrangé wrote:
> > When using systemd socket activation the --listen arg has no
> > effect. This is confusing to users upgrading from previous versions of
> > libvirt as their config
Introduced in v3.0.0-rc1~336, the commit message doesn't really
justifies the expensive domain def copy creation. Now, that
vm->def is guarded in this function by job acquirement we can use
vm->def directly.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 15 +--
1 file
*** BLURB HERE ***
Michal Prívozník (2):
qemu: Acquire domain job in qemuDomainGetFSInfo and
qemuDomainGetGuestInfo
qemu: Don't duplicate domain def in qemuDomainGetFSInfo
src/qemu/qemu_driver.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
--
These two functions work with vm->def in their critical sections
(i.e. after the job was acquired and before it is released). But
that means, they need QUERY domain job too to prevent vm->def
change.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 12
1 file changed, 8
On Fri, Aug 23, 2019 at 12:21:53PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
Add qemuVhostUserFetchConfigs() to discover vhost-user helpers.
qemuVhostUserFillDomainGPU() will find the first matching GPU helper
with the required capabilities and set the associated
vhost_user_binary.
On Fri, Aug 23, 2019 at 12:21:58PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
For each vhost-user GPUs,
- build a socket chardev, and pass the vhost-user socket to it
- build a vhost-user video device and associate it with the chardev
Signed-off-by: Marc-André Lureau
Signed-off-by:
Since it helps a user to know which of the storage backends support what
operation, include an autogenerated matrix showing it in the docs.
---
.gitignore | 1 +
docs/Makefile.am | 9 +++--
docs/apibuild.py | 2 ++
docs/storage.html.in | 14
On Fri, Aug 23, 2019 at 01:04:53PM -0400, Cole Robinson wrote:
On 8/23/19 12:21 PM, Cole Robinson wrote:
From: Marc-André Lureau
vhost-user-gpu helper may accept --render-node option to specify on
which GPU should the renderning be done.
What does it do if the user doesn't pass one? Pick
On Tue, Aug 27, 2019 at 09:34:06AM +0200, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (2):
qemu: Acquire domain job in qemuDomainGetFSInfo and
qemuDomainGetGuestInfo
qemu: Don't duplicate domain def in qemuDomainGetFSInfo
src/qemu/qemu_driver.c | 27
If there's a problem in encoding @ret (for instance
virTypedParamsSerialize() fails) then @ret is leaked.
Signed-off-by: Michal Privoznik
---
src/remote/remote_daemon_dispatch.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_daemon_dispatch.c
On Tue, Aug 13, 2019 at 05:40:27PM +0200, Boris Fiuczynski wrote:
Moving the hostdev boot support validation from the command line
generator code into the domain validation code.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
---
src/qemu/qemu_command.c | 13 +
On 8/22/19 10:43 AM, Xu Yandong (Yandong Xu) wrote:
Hi,
When plug a bridge interface to an active VM with both LIVE AND CONFIG flags,
libvirt generate different mac address to LIVE and CONFIG instance, so After
I reboot the VM, DHCP server doesn't assign the same IP address to the new
bridge
On Wed, 2019-08-21 at 10:38 +0200, Guido Günther wrote:
> Debian has pygrub in
>
>/usr/lib/xen-*/bin/pygrub
>
> Allow it to be run.
For those following along at home: see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931768
for more information.
> +++
On Tue, Aug 13, 2019 at 05:40:25PM +0200, Boris Fiuczynski wrote:
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
---
.../hostdev-subsys-mdev-vfio-ap-boot-fail.xml | 23 +++
.../hostdev-subsys-mdev-vfio-ap.args | 28 +++
On Tue, Aug 13, 2019 at 05:40:26PM +0200, Boris Fiuczynski wrote:
Adding a failure test for booting from a vhost scsi hostdev device.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
---
.../hostdev-scsi-vhost-scsi-pci-boot-fail.xml | 41 +++
tests/qemuxml2argvtest.c
On Tue, Aug 13, 2019 at 05:40:28PM +0200, Boris Fiuczynski wrote:
Changing the error messages to report the problem encountered.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
---
src/qemu/qemu_domain.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by:
On Tue, Aug 13, 2019 at 05:40:29PM +0200, Boris Fiuczynski wrote:
Refactoring the method signatures in preparation for
checking boot index of the mediated devices.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
---
src/qemu/qemu_domain.c | 28
1 file
On Tue, Aug 13, 2019 at 05:40:30PM +0200, Boris Fiuczynski wrote:
Add support to specify a boot order on vfio-ccw passthrough devices.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
---
src/qemu/qemu_command.c | 4 +++
src/qemu/qemu_domain.c
On Tue, Aug 27, 2019 at 02:13:28PM +0200, Michal Privoznik wrote:
On 8/22/19 10:43 AM, Xu Yandong (Yandong Xu) wrote:
Hi,
When plug a bridge interface to an active VM with both LIVE AND CONFIG flags,
libvirt generate different mac address to LIVE and CONFIG instance, so After
I reboot the VM,
At two places we are open coding xdr_free():
remoteRelayDomainEventTunable() and
remoteRelayDomainEventJobCompleted().
Bot of these functions use make_nonnull_domain() to put domain
IDs tuple into return structure and then continue encoding the
rest of structure. If that fails, they call
The return structure is a bit complicated and that's why it is
very easy to check for RPC limits incorrectly. The structure is
an array of remote_domain_stats_record structures with the limit
of REMOTE_DOMAIN_LIST_MAX. The latter structure then poses a
different limit on typed params:
The same way we check for limits when decoding typed parameters
(virTypedParamsDeserialize()) we should do the same check when
serializing them so that we don't put onto the wire more than our
limits allow. Surprisingly, we were doing so explicitly in some
places but not all of them.
Couple of bug fixes here.
Michal Prívozník (4):
remote_daemon_dispatch: Check for limit properly in
remoteDispatchConnectGetAllDomainStats
remote: Check for limits when encoding typed params
remote_daemon_dispatch: Don't leak @ret on failure
remote_daemon_dispatch: Don't open code
On Fri, Aug 23, 2019 at 12:21:54PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
See function documentation. Used in a following patch.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_security.c | 47
On Mon, 2019-08-26 at 16:02 +0300, Fabiano Fidêncio wrote:
> On Mon, Aug 26, 2019 at 11:45 AM Andrea Bolognani wrote:
> > Let me know if you're okay with me making the changes I suggested
> > before pushing, and let's coordinate so that they get applied as
> > closely as possible to the moment
First of all, we don't need the full history for builds and we can save
some time during the prepare phase. The disk footprint is about 5x
smaller, but the most important thing is the repo clone duration
difference e.g. in libvirt's case is quite significant:
full history:
real 3m45.236s
user
On Tue, Aug 27, 2019 at 02:12:12PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 27, 2019 at 02:56:02PM +0200, Erik Skultety wrote:
> > First of all, we don't need the full history for builds and we can save
> > some time during the prepare phase. The disk footprint is about 5x
> > smaller, but
On Tue, Aug 27, 2019 at 03:39:53PM +0200, Erik Skultety wrote:
> On Tue, Aug 27, 2019 at 02:12:12PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 27, 2019 at 02:56:02PM +0200, Erik Skultety wrote:
> > > First of all, we don't need the full history for builds and we can save
> > > some time
On Tue, Jul 30, 2019 at 08:32:00PM +0200, Andrea Bolognani wrote:
> On Mon, 2019-07-29 at 18:11 +0100, Daniel P. Berrangé wrote:
> > api: introduce virConnectSetIdentity for pasing uid, gid, selinux info
>
> s/pasing/passing/
>
> > When using the fine grained access control mechanism for APIs,
On Tue, Aug 27, 2019 at 02:56:02PM +0200, Erik Skultety wrote:
> First of all, we don't need the full history for builds and we can save
> some time during the prepare phase. The disk footprint is about 5x
> smaller, but the most important thing is the repo clone duration
> difference e.g. in
With the end of month coming soon, time to plan for next release,
I suggest to enter freeze tomorrow wed 28, the have an RC2 on Friday and
if everything looks good next Monday we can push 5.7.0
Hope this works for everybody,
Daniel
--
Daniel Veillard | Red Hat Developers Tools
In virNetDevMacVLanOpen(), The "retries" arg has been removed and the
value hardcoded as 10, since previously the function was only called
from one place, so it was always 10.
Signed-off-by: Laine Stump
---
src/util/virnetdevmacvlan.c | 12 +---
src/util/virnetdevmacvlan.h | 9
This function returns T if the given name is a macvtap device. This is
determined by 1) getting the ifindex of the device with that name (if
there is one), and 2) checking for existence of /dev/tapXX, where "XX"
is the ifindex learned in (1).
It's also possible to learn this by getting a netlink
This resolves https://bugzilla.redhat.com/1723367
It has become more popular to run libvirtd in an unprivileged
environment (e.g. inside a container), but until now the only possible
types of network connection for a qemu started by an unprivileged
libvirtd were:
1) a usermode slirp connection
Signed-off-by: Jim Fehlig
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c6580e4e72..990c84274d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -65,6 +65,16 @@
+
+
+ virsh: Support
On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote:
> 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote:
>> To get rid of implicit filters related workarounds in future let's
>> deprecate them now.
>
> Interesting, could we deprecate implicit filter without deprecation of
> unnecessity
Due to a typo, some of the field names didn't have closing quotes and
the information about the hostname was omitted.
Signed-off-by: Jonathon Jongsma
---
src/libvirt-domain.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/libvirt-domain.c
It appears that all commands were originally fully in alphabetical order
but as new commands were added, they were sometimes inserted out of
order. Fix up all domain commands so that they're in alphabetical order
again.
Signed-off-by: Jonathon Jongsma
---
NOTE: if this patch is too invasive,
The 'guestinfo' command uses the new virDomainGetGuestInfo() API to
query information about the specified domain and print it out for the
user. The output is modeled roughly on the 'domstats' command.
Signed-off-by: Jonathon Jongsma
---
tools/virsh-domain.c | 85
When we're collecting guest information, older agents may not support
all agent commands. In the case where the user requested all info
types (i.e. types == 0), ignore unsupported command errors and gather as
much information as possible. If the agent command failed for some other
reason, or if
Although has always been able to use an
existing tap device, this is just a coincidence due to the fact that
the same ioctl is used to create a new tap device or get a handle to
an existing device.
Even then, once we have the handle to the device, we still insist on
doing extra setup to it
Traditionally, macvtap devices are supported using , but that type requires specifying a source device name
and macvtap mode which can't be altered after the initial device
creation (and may not even be available to the management software
that's creating the XML config to feed to libvirt).
But
This will simplify addition of another attribute to the element
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b7a342bb91..f21731b5f6 100644
---
If managed='no', then the tap device must already exist, and setting
of MAC address and online status (IFF_UP) is skipped.
NB: we still set IFF_VNET_HDR and IFF_MULTI_QUEUE as appropriate,
because those bits must be properly set in the TUNSETIFF we use to set
the tap device name of the handle
with info about support for using precreated tap/macvtap devices in
unprivileged libvirtd.
Signed-off-by: Laine Stump
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c6580e4e72..be51d6c953 100644
--- a/docs/news.xml
+++
This just moves around a few things in qemuInterfaceConnect() with no
functional difference (except that a few failures that would have
previously resulted in a "success" audit log will now properly produce
a "fail" audit). The change is so that adding support for unmanaged
tap/macvtap devices
libvirt creates its tap devices without the IFF_PERSIST flag, so they
will be automatically deleted when qemu is finished with them. In the
case of tap devices created outside of libvirt, if the creating entity
wants the devices to be deleted, it will also omit IFF_PERSIST, but if
it wants them to
Nice improvement.
Reviewed-by: Jonathon Jongsma
On Tue, 2019-08-27 at 14:05 +0200, Michal Privoznik wrote:
> The same way we check for limits when decoding typed parameters
> (virTypedParamsDeserialize()) we should do the same check when
> serializing them so that we don't put onto the wire
Looks correct to me. Good catch.
Reviewed-by: Jonathon Jongsma
On Tue, 2019-08-27 at 14:05 +0200, Michal Privoznik wrote:
> The return structure is a bit complicated and that's why it is
> very easy to check for RPC limits incorrectly. The structure is
> an array of remote_domain_stats_record
On Tue, Aug 27, 2019 at 02:05:05PM +0200, Michal Privoznik wrote:
> Couple of bug fixes here.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, 2019-08-27 at 16:38 +0200, Michal Privoznik wrote:
> On 8/27/19 11:17 AM, Cedric Bosdonnat wrote:
> > Since it helps a user to know which of the storage backends support
> > what
> > operation, include an autogenerated matrix showing it in the docs.
> > ---
> > .gitignore
On Fri, Aug 23, 2019 at 12:21:45PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
The same config files disovery & priority rules are used for
vhost-user backends.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/Makefile.inc.am | 2 +
src/qemu/qemu_configs.c
On Fri, Aug 23, 2019 at 12:21:50PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
To support virtio VGA with vhost-user, vhost-user-vga device is necessary.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_domain.c | 11 ---
1 file changed, 8
On Fri, Aug 23, 2019 at 12:21:49PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
Those new devices are merged for QEMU 4.1.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h
On Fri, Aug 23, 2019 at 12:21:48PM -0400, Cole Robinson wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_cgroup.c | 24
1 file changed, 24 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
On Mon, Aug 26, 2019 at 04:21:34PM +0200, Ján Tomko wrote:
> On Fri, Aug 23, 2019 at 04:11:43PM +0100, Daniel P. Berrangé wrote:
> > Currently during RPM upgrade we restart libvirtd and unconditionally
> > enable use of systemd socket activation for the UNIX sockets.
> >
> > If the user had
From: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
.../hostdev-subsys-mdev-vfio-ap-boot-fail.xml | 23 +
.../hostdev-subsys-mdev-vfio-ap.args | 28
From: Boris Fiuczynski
Refactoring the method signatures in preparation for
checking boot index of the mediated devices.
Reviewed-by: Ján Tomko
Reviewed-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_domain.c | 28
From: Boris Fiuczynski
Adding a failure test for booting from a vhost scsi hostdev device.
Reviewed-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
.../hostdev-scsi-vhost-scsi-pci-boot-fail.xml | 41 +++
tests/qemuxml2argvtest.c
From: Boris Fiuczynski
Add support to specify a boot order on vfio-ccw passthrough devices.
Reviewed-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 4 +++
src/qemu/qemu_domain.c| 26
From: Boris Fiuczynski
Moving the hostdev boot support validation from the command line
generator code into the domain validation code.
Reviewed-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 12
v2 -> v3:
* use real QEMU capabilities data for tests
Boris Fiuczynski (6):
tests: add vfio-ap mdev tests
tests: add vhost scsi hostdev boot unsupported test
qemu: move hostdev boot validation into domain validation
qemu: make error messages device specific
qemu: refactor mdev
From: Boris Fiuczynski
Changing the error messages to report the problem encountered.
Reviewed-by: Ján Tomko
Reviewed-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_domain.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
Ján Tomko [2019-08-27, 01:51PM +0200]:
> On Tue, Aug 13, 2019 at 05:40:30PM +0200, Boris Fiuczynski wrote:
> > diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> > index 6fa9a26b64..6f672184be 100644
> > --- a/tests/qemuxml2xmltest.c
> > +++ b/tests/qemuxml2xmltest.c
> > @@ -958,6
On 8/27/19 12:09 AM, Jim Fehlig wrote:
Commit f15789ec added support for setting postcopy migration bandwidth to
the migrate subcommand. This change does the same for standard migration.
Signed-off-by: Jim Fehlig
---
I used the term 'standard migration' in the commit message but 'pre-copy'
in
On Tue, Aug 27, 2019 at 16:22:02 +0200, Bjoern Walk wrote:
> Ján Tomko [2019-08-27, 01:51PM +0200]:
> > On Tue, Aug 13, 2019 at 05:40:30PM +0200, Boris Fiuczynski wrote:
> > > diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> > > index 6fa9a26b64..6f672184be 100644
> > > ---
On 8/27/19 11:17 AM, Cedric Bosdonnat wrote:
Since it helps a user to know which of the storage backends support what
operation, include an autogenerated matrix showing it in the docs.
---
.gitignore | 1 +
docs/Makefile.am | 9 +++--
docs/apibuild.py
On 8/26/19 2:38 PM, Ján Tomko wrote:
On Mon, Aug 12, 2019 at 01:54:25PM +0200, Michal Privoznik wrote:
If a test fails, it's stderr is caught in the logs. That's how
our CI works. But virReportError() is not.
Where are you missing the error message?
If you run the tested function through
First of all, we don't need the full history for builds and we can save
some time during the prepare phase. The disk footprint is about 5x
smaller, but the most important thing is the repo clone duration
difference e.g. in libvirt's case is quite significant:
full history:
real 3m45.236s
user
76 matches
Mail list logo
