From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Ján Tomko
---
src/qemu/qemu_cgroup.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index ecd96efb0a..eb6f993d8e 100644
---
From: Marc-André Lureau
Those new devices are available since QEMU 4.1.
Signed-off-by: Marc-André Lureau
Reviewed-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 4
From: Marc-André Lureau
vhost-user-gpu helper takes --render-node option to specify on which
GPU should the renderning be done.
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.html.in | 6 ++
docs/schemas/domaincommon.rng | 5 +
From: Marc-André Lureau
To support virtio VGA with vhost-user, vhost-user-vga device is necessary.
Signed-off-by: Marc-André Lureau
Reviewed-by: Ján Tomko
---
src/qemu/qemu_domain.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c
From: Marc-André Lureau
Check qemu capability, and accept 3d acceleration. 3d acceleration
support is checked when looking for a suitable vhost-user helper.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_process.c | 57 +++-
tests/qemuxml2argvtest.c |
From: Marc-André Lureau
vhost-user device doesn't have a virgl option, it is passed to the
vhost-user-gpu helper process instead.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c| 9 ++---
tests/qemuxml2argvdata/virtio-options.args | 3 +--
2 files changed,
On Fri, Sep 13, 2019 at 11:31:34AM +0200, Andrea Bolognani wrote:
> On Fri, 2019-09-13 at 10:12 +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 13, 2019 at 11:09:16AM +0200, Andrea Bolognani wrote:
> > > On Fri, 2019-09-13 at 09:59 +0100, Daniel P. Berrangé wrote:
> > > > On Fri, Sep 13, 2019 at
To my knowledge, everything in libvirt is now prepared to fully use
-blockdev way to configure disks in qemu.
There is one known qemu bug though: Internal snapshots don't work with
-blockdev:
https://bugzilla.redhat.com/show_bug.cgi?id=1658981
Since I can't in good faith ask for merging this
We require that 'auto-read-only' is dynamic for posix-file backeds this
prevents problems with libvirt's usage of sVirt where we don't grant
qemu permissions to write backing chain until it's needed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +
Initial implementation of 'auto-read-only' didn't reopen the backing
files when needed. For '-blockdev' to work we need to be able to tel
qemu to open a file read-only and change it during blockjobs as we label
backing chains with a sVirt label which does not allow writing. The
dynamic
On Mon, Aug 05, 2019 at 06:14:20PM +0200, Michal Privoznik wrote:
[...]
> Michal Prívozník (5):
> virfirmware: Expose and define autoptr for virFirmwareFree
> qemu_firmware: Document qemuFirmwareGetSupported
> qemu_firmware: Extend qemuFirmwareGetSupported to return FW paths
>
On Fri, 2019-09-13 at 10:40 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 13, 2019 at 11:31:34AM +0200, Andrea Bolognani wrote:
> > Good to know! Still, no need to wait until December before dropping
> > Python 2 support in my opinion: we should either be able to do it
> > right now, or we're
From: Marc-André Lureau
Each vhost-user-gpu needs its own helper gpu process.
Start/stop them, and apply the emulator cgroup controller.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 45 +--
1 file changed, 39 insertions(+), 6
From: Marc-André Lureau
For each vhost-user GPUs,
- build a socket chardev, and pass the vhost-user socket to it
- build a vhost-user video device and associate it with the chardev
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c| 56 +++---
From: Marc-André Lureau
Learn to override the paths to the program to execute (vhost-user
helpers are executed to check for runtime capabilities).
Signed-off-by: Marc-André Lureau
---
tests/virfilewrapper.c | 22 ++
1 file changed, 22 insertions(+)
diff --git
From: Marc-André Lureau
Similar to the qemu_tpm.c, add a unit with a few functions to
start/stop and setup the cgroup of the external vhost-user-gpu
process. See function documentation.
The vhost-user connection fd is set on qemuDomainVideoPrivate struct.
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c | 26 +-
src/conf/domain_conf.h | 7 +--
2 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
From: Marc-André Lureau
See function documentation. Used in a following patch.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_security.c | 40
src/qemu/qemu_security.h | 6 ++
2 files changed, 46 insertions(+)
diff --git
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 38 ++
src/qemu/qemu_domain.h | 12
2 files changed, 50 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
From: Marc-André Lureau
Add qemuVhostUserFetchConfigs() to discover vhost-user helpers.
qemuVhostUserFillDomainGPU() will find the first matching GPU helper
with the required capabilities and set the associated
vhost_user_binary.
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c
From: Marc-André Lureau
Call qemuExtVhostUserGPUPrepareDomain() to fill the domain with the
location of the vhost-user binary to start.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 29 +
src/qemu/qemu_extdevice.h | 5 +
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
tests/qemuxml2argvtest.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index f9eb74e7ed..b31034be46 100644
--- a/tests/qemuxml2argvtest.c
+++
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
...host-user-gpu-secondary.x86_64-latest.args | 43 +
.../vhost-user-gpu-secondary.xml | 46 +++
.../vhost-user-vga.x86_64-latest.args | 40
On Fri, Sep 13, 2019 at 11:09:16AM +0200, Andrea Bolognani wrote:
> On Fri, 2019-09-13 at 09:59 +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 13, 2019 at 10:56:45AM +0200, Andrea Bolognani wrote:
> > > On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote:
> > > > This aligns with fact
From: Marc-André Lureau
The same config files disovery & priority rules are used for
vhost-user backends.
No functional change, the only difference is that
qemuInteropFetchConfigs() takes a "name" argument and construct paths
with it (ex: "firmware").
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Hi,
This series adds support for running virtio GPUs in seperate
processes, thanks to vhost-user backend.
The QEMU support landed for 4.1. There are several benefits of running
the GPU/virgl in an external process, since Mesa is rather heavy on
the qemu main loop, and
From: Marc-André Lureau
Whether a directory exists or is not readable shouldn't make a big
diffence.
This removes errors when firmare or vhost-user config is looked up
from a user session libvirt if /etc/libvirt is not readable.
Signed-off-by: Marc-André Lureau
---
src/util/virfile.c | 13
From: Marc-André Lureau
Accept a new driver name attribute to specify usage of helper process, ex:
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.html.in | 12 ++-
docs/schemas/domaincommon.rng | 8 +
src/conf/domain_conf.c
On 9/13/19 12:25 PM, Kashyap Chamarthy wrote:
On Mon, Aug 05, 2019 at 06:14:20PM +0200, Michal Privoznik wrote:
[...]
Michal Prívozník (5):
virfirmware: Expose and define autoptr for virFirmwareFree
qemu_firmware: Document qemuFirmwareGetSupported
qemu_firmware: Extend
This fixes bug in
commit bbe2aa627f621e6749af374b22856184d1f351dc
Author: Daniel P. Berrangé
Date: Thu Jul 26 17:24:30 2018 +0100
conf: simplify link from hostdev back to network device
hostdevs have a link back to the original network device. This is fairly
generic
On Fri, 2019-09-13 at 10:12 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 13, 2019 at 11:09:16AM +0200, Andrea Bolognani wrote:
> > On Fri, 2019-09-13 at 09:59 +0100, Daniel P. Berrangé wrote:
> > > On Fri, Sep 13, 2019 at 10:56:45AM +0200, Andrea Bolognani wrote:
> > > > My hope is that we can
On Thu, Sep 12, 2019 at 03:31:24PM +0200, Michal Privoznik wrote:
> In the domain capabilities XML there are FW image paths printed.
> There are two sources for the image paths (in order of
> preference):
>
> 1) firmware descriptor files - as returned by
> qemuFirmwareGetSupported()
>
> 2)
On 9/5/19 1:56 PM, Daniel P. Berrangé wrote:
When opening a connection to a second driver inside the daemon, we must
ensure the identity of the current user is passed across. This allows
the second daemon to perform access control checks against the real end
users, instead of against the libvirt
On Fri, Sep 13, 2019 at 05:13:09PM +0200, Michal Privoznik wrote:
> On 9/5/19 1:56 PM, Daniel P. Berrangé wrote:
> > When opening a connection to a second driver inside the daemon, we must
> > ensure the identity of the current user is passed across. This allows
> > the second daemon to perform
On 9/13/19 12:05 PM, Daniel P. Berrangé wrote:
We previously allowed bandwidth settings when attaching NICs
to networks with forward mode=bridge:
commit 42a92ee93d5432ebd9ebfd409903b5287fc7d7ff
Author: Daniel P. Berrangé
Date: Tue Nov 20 11:30:05 2018 +
network: add
On 9/13/19 12:38 PM, Daniel P. Berrangé wrote:
On Fri, Sep 13, 2019 at 12:10:34PM -0400, Laine Stump wrote:
On 9/13/19 10:59 AM, Daniel P. Berrangé wrote:
Since the introduction of the virNetworkPort object, the network driver
has a persistent record of ports that have been created against the
On 9/13/19 12:05 PM, Daniel P. Berrangé wrote:
To aid in troubleshooting add some debug messages wrt
bandwidth settings and networks.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
(although it sounds like you already found the problem you were looking
for :-)
---
On Fri, Sep 13, 2019 at 12:10:34PM -0400, Laine Stump wrote:
> On 9/13/19 10:59 AM, Daniel P. Berrangé wrote:
> > Since the introduction of the virNetworkPort object, the network driver
> > has a persistent record of ports that have been created against the
> > networks. Thus the hypervisor
On 9/9/19 6:26 PM, Jim Fehlig wrote:
AppArmorGetSecurityProcessLabel copies the VM's profile name to the
label member of virSecurityLabel struct. If the profile is not loaded,
the name is set empty before calling virStrcpy to copy it. However,
virStrcpy will fail if src is empty (0 length),
On 9/13/19 3:09 AM, Andrea Bolognani wrote:
> If I understand the SLES / OpenSUSE situation correctly, then SLES
> 12.3 should be comparable to OpenSUSE 42.3,
Nice job! Even SUSE folks are known to get confused by the numbering :-).
openSUSE 42.3 ~= SLES12 SP3
SLES12 SP4 and SP5 have no openSUSE
On 9/9/19 10:26 AM, Jim Fehlig wrote:
> AppArmorGetSecurityProcessLabel copies the VM's profile name to the
> label member of virSecurityLabel struct. If the profile is not loaded,
> the name is set empty before calling virStrcpy to copy it. However,
> virStrcpy will fail if src is empty (0
On Wed, Sep 11, 2019 at 05:23:09PM +0100, Daniel P. Berrangé wrote:
> This series is an effort to reduce the number of different
> languages we use by eliminating most use of perl in favour
> of python.
>
> This aligns with fact that the likely future build system
> we'll use (meson) is written
On 9/13/19 2:56 AM, Andrea Bolognani wrote:
> On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote:
>> This series is an effort to reduce the number of different
>> languages we use by eliminating most use of perl in favour
>> of python.
>
> Just today I found out about
>
>
>
On 9/13/19 2:43 PM, Daniel P. Berrangé wrote:
This fixes bug in
commit bbe2aa627f621e6749af374b22856184d1f351dc
Author: Daniel P. Berrangé
Date: Thu Jul 26 17:24:30 2018 +0100
conf: simplify link from hostdev back to network device
hostdevs have a link back to the
On Fri, 2019-09-13 at 13:58 +, Jim Fehlig wrote:
> On 9/13/19 2:56 AM, Andrea Bolognani wrote:
> > Jim, does SLES 12 have
> > Python 3?
>
> Yes, python 3.4.6. And python 2.7.13.
That's *amazing* news! \o/
> > And, as a side note: do you think you could find the time to add
> > OpenSUSE
The same validation should be done for both static network devices and
hotplugged devices, but they are currently inconsistent. Move all the
relevant validation from qemuBuildInterfaceCommandLine() into the new
function qemuDomainValidateActualNetDef() and call the latter from
the former.
qemuDomainAttachNetDevice() (hotplug) previously had some of the
validation that is in qemuDomainValidateActualNetDef(), but it was
incomplete. qemuDomainChangeNet() had none of that validation, but it
is all appropriate in both cases.
This is the final piece of a previously partial resolution to
There is some validation of NetDefs () that can't be done
until runtime, due to not knowing the exact configuration until that
time. This needs to happen in 3 places: 1) in the qemu commandline
when a new guest is started, 2) when an is hotplugged, and
3) when an is updated. Until now, there
It needs to be used by a function that only has a const pointer to
virDomainNetDef.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Since the introduction of the virNetworkPort object, the network driver
has a persistent record of ports that have been created against the
networks. Thus the hypervisor drivers no longer communicate to the
network driver during libvirtd restart.
This change, however, meant that the connection
The virTestOOMActive method was deleted in
commit 2c52ecd96086b4643b99b4570b5823d40ce2787b
Author: Daniel P. Berrangé
Date: Thu Aug 29 13:04:07 2019 +0100
util: purge all code for testing OOM handling
Signed-off-by: Daniel P. Berrangé
---
Pushed as a CI build fix for FreeBSD
On 9/13/19 5:23 PM, Daniel P. Berrangé wrote:
On Fri, Sep 13, 2019 at 05:13:09PM +0200, Michal Privoznik wrote:
On 9/5/19 1:56 PM, Daniel P. Berrangé wrote:
When opening a connection to a second driver inside the daemon, we must
ensure the identity of the current user is passed across. This
To aid in troubleshooting add some debug messages wrt
bandwidth settings and networks.
Signed-off-by: Daniel P. Berrangé
---
src/network/bridge_driver.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index
We previously allowed bandwidth settings when attaching NICs
to networks with forward mode=bridge:
commit 42a92ee93d5432ebd9ebfd409903b5287fc7d7ff
Author: Daniel P. Berrangé
Date: Tue Nov 20 11:30:05 2018 +
network: add missing bandwidth limits for bridge forward type
In
On 9/13/19 10:59 AM, Daniel P. Berrangé wrote:
Since the introduction of the virNetworkPort object, the network driver
has a persistent record of ports that have been created against the
networks. Thus the hypervisor drivers no longer communicate to the
network driver during libvirtd restart.
On 9/13/19 9:28 AM, Andrea Bolognani wrote:
> On Fri, 2019-09-13 at 13:58 +, Jim Fehlig wrote:
>> On 9/13/19 2:56 AM, Andrea Bolognani wrote:
>>> Jim, does SLES 12 have
>>> Python 3?
>>
>> Yes, python 3.4.6. And python 2.7.13.
>
> That's *amazing* news! \o/
>
>>> And, as a side note: do you
On 9/13/19 4:52 PM, Laine Stump wrote:
> The same validation should be done for both static network devices and
> hotplugged devices, but they are currently inconsistent. Move all the
> relevant validation from qemuBuildInterfaceCommandLine() into the new
> function
On 9/13/19 4:52 PM, Laine Stump wrote:
> There is some validation of NetDefs () that can't be done
> until runtime, due to not knowing the exact configuration until that
> time. This needs to happen in 3 places: 1) in the qemu commandline
> when a new guest is started, 2) when an is hotplugged,
If a disk that a block job is registered with already has a job
(stored in private data) it needs to be unrefed to keep the
refcounter in balance (and properly free the object):
2,577 (104 direct, 2,473 indirect) bytes in 1 blocks are definitely lost in
loss record 168 of 174
at 0x4838B86:
The 'ramfb' attribute provides a framebuffer to the guest that can be
used as a boot display for the vgpu
Signed-off-by: Jonathon Jongsma
---
docs/formatdomain.html.in | 8
docs/schemas/domaincommon.rng | 5 +++
src/conf/domain_conf.c
When the bochs display type was added, the capability was never checked.
Add that check in the same place as the other video device capability
checks.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_process.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Add a qemu capbility to see if the standalone ramfb device is available.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 +
This device is a very simple framebuffer device supported by qemu that
is mostly intended to use as a boot framebuffer in conjunction with a
vgpu. However, there is also a standalone ramfb device that can be used
as a primary display device and is useful for e.g. aarch64 guests where
different
On Fri, Sep 13, 2019 at 02:43:53PM +0200, Peter Krempa wrote:
To my knowledge, everything in libvirt is now prepared to fully use
-blockdev way to configure disks in qemu.
There is one known qemu bug though: Internal snapshots don't work with
-blockdev:
On Fri, Sep 13, 2019 at 10:26:35PM +0200, Michal Privoznik wrote:
If a disk that a block job is registered with already has a job
(stored in private data) it needs to be unrefed to keep the
refcounter in balance (and properly free the object):
Please change the wording to something more
Hi all,
I think I've found a bug in either libvirt or spice. I'll give a short
description here, but I have a stack exchange question that also has
information here:
https://unix.stackexchange.com/questions/541127/how-to-listen-on-same-port-separate-address-using-spice-from-libvirt
Basically,
On Thu, Sep 12, 2019 at 02:21:58PM -0600, Michael Edlinger wrote:
Hi all,
I think I've found a bug in either libvirt or spice. I'll give a short
description here, but I have a stack exchange question that also has
information here:
On 13.09.2019 00:08, Daniel Henrique Barboza wrote:
> Hi,
>
> While reviewing these I got one question that I think it's better
> asked here since it's not related to a single patch.
>
> I understand the use case for udev machinery to handle the device
> removal event - in fact, I wonder if
On 12.09.2019 23:37, Daniel Henrique Barboza wrote:
>
>
> On 9/9/19 8:33 AM, Nikolay Shirokovskiy wrote:
>> Imagine host usb device is unplugged from host and as a result we send
>> command to qemu to delete appropriate device. Then before qemu device is
>> deleted host usb device is plugged
On Fri, Sep 13, 2019 at 10:56:45AM +0200, Andrea Bolognani wrote:
> On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote:
> > This series is an effort to reduce the number of different
> > languages we use by eliminating most use of perl in favour
> > of python.
>
> Just today I found out
On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote:
> This series is an effort to reduce the number of different
> languages we use by eliminating most use of perl in favour
> of python.
Just today I found out about
On Fri, 2019-09-13 at 09:59 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 13, 2019 at 10:56:45AM +0200, Andrea Bolognani wrote:
> > On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote:
> > > This aligns with fact that the likely future build system
> > > we'll use (meson) is written in
72 matches
Mail list logo
