It's now tagged in git, I have pushed RC2 signed tarball and source rpm
to the usual place at:
https://libvirt.org/sources/
Passes in my minimal testing and https://ci.centos.org/view/libvirt/
CI is fully green, so things looks good on my side !
That said you should not trust me and do your
Some layered products such as oVirt have requested a way to avoid being
blocked by guest agent commands when querying a loaded vm. For example,
many guest agent commands are polled periodically to monitor changes,
and rather than blocking the calling process, they'd prefer to simply
time out when
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> signed-off-by: Fabiano Fidêncio
> ---
> guests/vars/projects/base.yml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> Together with this change, let's also remove meson as a dependency from
> the projects which are already depending on it.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> guests/vars/projects/base.yml| 1 +
>
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/vars/mappings.yml
> @@ -450,6 +450,10 @@ mappings:
>
>meson:
> default: meson
> +CentOS7:
> +Debian9:
> +Ubuntu16:
> +Ubuntu18:
Mh, the original mapping means that we have already installed the
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/vars/mappings.yml
> @@ -455,6 +455,10 @@ mappings:
> + ninja:
> + default: ninja-build
> + FreeBSD: ninja
Doing this would be a good idea regardless, since we invoke ninja
directly.
Reviewed-by: Andrea Bolognani
--
On Thu, Oct 03, 2019 at 11:43:05AM +0200, Stefano Garzarella wrote:
> Signed-off-by: Stefano Garzarella
> ---
> v2:
> - add the binary diff of the image
> ---
> updater/virt-tools/config.ini | 6 ++
> updater/virt-tools/images/sgarzare.png | Bin 0 -> 17713 bytes
> 2 files
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio
> ---
> guests/vars/projects/base.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
Signed-off-by: Stefano Garzarella
---
updater/virt-tools/config.ini | 6 ++
updater/virt-tools/images/sgarzare.png | Bin 0 -> 17713 bytes
2 files changed, 6 insertions(+)
create mode 100644 updater/virt-tools/images/sgarzare.png
diff --git a/updater/virt-tools/config.ini
On Thu, Oct 03, 2019 at 11:10:02AM +0200, Stefano Garzarella wrote:
> Signed-off-by: Stefano Garzarella
> ---
> updater/virt-tools/config.ini | 6 ++
> updater/virt-tools/images/sgarzare.png | Bin 0 -> 17713 bytes
> 2 files changed, 6 insertions(+)
> create mode 100644
On Thu, Oct 03, 2019 at 10:20:26AM +0100, Daniel P. Berrangé wrote:
> On Thu, Oct 03, 2019 at 11:10:02AM +0200, Stefano Garzarella wrote:
> > Signed-off-by: Stefano Garzarella
> > ---
> > updater/virt-tools/config.ini | 6 ++
> > updater/virt-tools/images/sgarzare.png | Bin 0 ->
On Thu, Oct 03, 2019 at 11:25:32AM +0200, Stefano Garzarella wrote:
> On Thu, Oct 03, 2019 at 10:20:26AM +0100, Daniel P. Berrangé wrote:
> > On Thu, Oct 03, 2019 at 11:10:02AM +0200, Stefano Garzarella wrote:
> > > Signed-off-by: Stefano Garzarella
> > > ---
> > > updater/virt-tools/config.ini
Signed-off-by: Stefano Garzarella
---
v2:
- add the binary diff of the image
---
updater/virt-tools/config.ini | 6 ++
updater/virt-tools/images/sgarzare.png | Bin 0 -> 17713 bytes
2 files changed, 6 insertions(+)
create mode 100644 updater/virt-tools/images/sgarzare.png
diff
On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote:
On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote:
On 10/1/19 11:45 AM, Pavel Mores wrote:
> virDomainGetBlockInfo() returns error if called on a disk with no target
> (a targetless disk might be a removable
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/vars/projects/base.yml
> @@ -24,6 +24,7 @@ packages:
>- ninja
>- patch
>- perl
> + - pip
With this changed to 'python3-pip' as per the comments on the
previous patch,
Reviewed-by: Andrea Bolognani
--
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/update/tasks/paths.yml
> +# Prefer ninja-build, fall back to ninja
> +- name: 'Export paths'
> + set_fact:
> +ninja: '{{ commands["ninja-build"] }}'
> + when:
> +- commands["ninja-build"] != ''
> +
> +-
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/vars/mappings.yml
> + pip:
> +CentOS7: python3-pip
> +Debian9: python3-pip
> +Ubuntu: python3-pip
Let's call the mapping 'python3-pip' to avoid any possible confusion.
I'd also list Ubuntu16 and Ubuntu18
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/vars/mappings.yml
> @@ -814,11 +814,12 @@ mappings:
>python3-devel:
> deb: python3-dev
> pkg: python3
> +CentOS7: python36-devel
> Fedora: python3-devel
These are out of order: CentOS7 is more
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/lcitool
> +pip_install = []
> +pip_mappings = {
> +"meson" : "meson==0.49.0",
> +}
This makes me think that perhaps we should have this information
encoded in the mapping, eg.
meson:
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> As now we've the needed packages for building and testing libosinfo
> on all systems supported by libvirt-jenkins-ci, let's just build
> libosinfo everywhere.
>
> RPM build is still not possible in CentOS7 as it doesn't have the
>
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> As now we've the needed packages for building and testing osinfo-db
> on all systems supported by libvirt-jenkins-ci, let's just build
> osinfo-db everywhere.
>
> Signed-off-by: Fabiano Fidêncio
> ---
>
If we've marked rules as skipped, there's no sense keeping them in the
maint.mk file.
Signed-off-by: Daniel P. Berrangé
---
build-aux/cfg.mk | 38 ---
build-aux/maint.mk | 245 -
2 files changed, 283 deletions(-)
diff --git a/build-aux/cfg.mk
We're going to be eliminating autotools and gnulib, but we still wish to
have the 'make syntax-check' functionality.
This imports the minimal set of gnulib files required to keep this
working. The GNUmakefile and maint.mk files had a few tweaks to enable
them to work independently of automake
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
V2: Change 2.12.0 -> 4.2.0 in
The standard maint.mk from gnulib provides alot more than just the
'syntax-check' target. This can all be purged to give a more minimal
file.
Signed-off-by: Daniel P. Berrangé
---
build-aux/cfg.mk | 10 -
build-aux/maint.mk | 473 -
2 files
The gnulib syntax-check rules are spread across GNUmakefile, cfg.mk and
maint.mk. This made sense when we were getting two of the files from the
gnulib submodule. Now that we own all files though, we can merge them
into one.
Signed-off-by: Daniel P. Berrangé
---
Makefile.am
Our syntax-check rule relies in various files imported during the gnulib
bootstrap process. As we switch to meson & try to eliminate gnulib, we
need to take ownership of syntax-check.
This patch series follows the approach taken for libosinfo & other
projects wrt syntax-check rules, but goes a
On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote:
> On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote:
> > On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 10/1/19 11:45 AM, Pavel Mores wrote:
> > > > virDomainGetBlockInfo() returns
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> As now we've the needed packages for building and testing
> osinfo-db-tools on all systems supported by libvirt-jenkins-ci, let's
> just build osinfo-db-tools everywhere.
>
> RPM build is still not possible in CentOS7 as it doesn't have
On Thu, Oct 03, 2019 at 01:09:55PM +0200, Pavel Mores wrote:
> On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote:
> > On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote:
> > > On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote:
> > > >
> > > >
> > > > On
On 10/2/19 7:22 PM, John Snow wrote:
> This parameter has been deprecated since 2.12.0 and is eligible for
> removal. Remove this parameter as it is actually completely ignored;
> let's not give false hope.
>
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
> Reviewed-by: Vladimir
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
V2: Change 2.12.0 -> 4.2.0 in
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/build/projects/libvirt-dbus.yml
> +- include: '{{ playbook_base }}/jobs/meson-check-job.yml'
>vars:
> # CentOS 7 doesn't include Python 3, while the versions of flake8
> # and pyflakes currently
086c19d69 added bochs-display capability but didn't fill in the info for
domain capabilities.
Signed-off-by: Fabiano Fidêncio
---
src/qemu/qemu_capabilities.c | 2 ++
tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1
stpcpy returns a pointer to the end of the string just copied
which in theory makes it easier to then copy another string
after it. We only use stpcpy in one place though and that
is trivially rewritten to avoid stpcpy with no less in code
clarity or efficiency.
Signed-off-by: Daniel P. Berrangé
The _getopt_internal_r func is not intended for public use, it is an
internal function shared between the gnulib getopt and argp modules.
Signed-off-by: Daniel P. Berrangé
---
src/bhyve/bhyve_parse_command.c | 88 +
1 file changed, 46 insertions(+), 42
The use of this script was discontinued when we stopped providing a full
ChangeLog in the dist with:
commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba
Author: Andrea Bolognani
Date: Mon Apr 1 17:33:03 2019 +0200
maint: Stop generating ChangeLog from git
Signed-off-by: Daniel P.
The usleep function was missing on older mingw versions, but we can rely
on it existing everywhere these days.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 09dcf78007..022f564134 100644
---
All use of this function was purged a long time ago in favour
of getaddrinfo
commit a8ae7d19f4ace62ff3f364c628cbc16baa9b080c
Author: Daniel P. Berrange
Date: Thu Oct 21 11:13:05 2010 +0100
Remove all use of inet_pton and inet_ntop
Signed-off-by: Daniel P. Berrangé
---
The getopt-posix module fixes a problem with optind being incorrectly
set after a failed option parse. This is not something that matters to
libvirt code.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
po/POTFILES| 1 -
2 files changed, 2 deletions(-)
diff --git
This reverts commit 83aca30f1e8be524780a60b9dd8a14ec5f9de878.
While the motivation of the original commit is fine, we are intending to
drop autoconf in favour of meson, and similarly wish to drop use of
gnulib. Removing this feature is part of that conversion work.
Signed-off-by: Daniel P.
gnulib fixes a portability problem on AIX which is a platform we have
never targetted.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 022f564134..257782a7b9 100644
--- a/bootstrap.conf
+++
This was fixing a problem with old versions of mingw which had a
pthread.h that polluted the namespace with random symbols. This is no
longer relevant on our mingw platform targets.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git
This fixes a problem on mingw where it doesn't know how to report
certain errnos defined by POSIX, but not used on Windows. These are
not a real problem for libvirt.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> guests: CentOS7 provides python3
> guests: Install EPEL on CentOS7
> guests: Map python36-* CentOS7 packages
> mappings: Mark the OSes where meson is not supported
> guests: Add meson to the base project
> mappings: Add ninja
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 36
src/qemu/qemu_capabilities.h | 3 +++
2 files changed, 39 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 802d3f7e1a..9d5eaf0c1a 100644
---
The function translates qemuMonitorCPUDefsPtr (used by QEMU caps probing
code) into virDomainCapsCPUModelsPtr used by domain capabilities.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 62 +++-
1 file changed, 39 insertions(+), 23 deletions(-)
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 12
src/qemu/qemu_capabilities.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 9d5eaf0c1a..51de44260d 100644
--- a/src/qemu/qemu_capabilities.c
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 28
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index b4175a846e..1d7772ee01 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
Both virDomainCapsCPUModelsAdd and virDomainCapsCPUModelsAddSteal are so
simple we can just squash the code in a single function.
Signed-off-by: Jiri Denemark
---
src/conf/domain_capabilities.c | 33 ++---
src/conf/domain_capabilities.h | 4
When starting a domain without a CPU model specified in the domain XML,
QEMU will choose a default one. Which is fine unless the domain gets
migrated to another host because libvirt doesn't perform any CPU ABI
checks and the virtual CPU provided by QEMU on the destination host can
differ from the
Signed-off-by: Jiri Denemark
---
src/conf/cpu_conf.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h
index 19ce816ec2..f26f29d9fc 100644
--- a/src/conf/cpu_conf.h
+++ b/src/conf/cpu_conf.h
@@ -151,6 +151,7 @@ virCPUDefFreeModel(virCPUDefPtr def);
On Thu, Oct 03, 2019 at 16:00:34 +0200, Jiri Denemark wrote:
> We need to create a mapping between CPU model names and their
> corresponding QOM types.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_capabilities.c |4 +
> src/qemu/qemu_monitor.c
On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
The getopt-posix module fixes a problem with optind being incorrectly
set after a failed option parse. This is not something that matters to
libvirt code.
This module was introduced by:
commit
On Thu, Oct 03, 2019 at 02:53:10PM +0100, Daniel P. Berrangé wrote:
All use of this function was purged a long time ago in favour
of getaddrinfo
commit a8ae7d19f4ace62ff3f364c628cbc16baa9b080c
Author: Daniel P. Berrange
Date: Thu Oct 21 11:13:05 2010 +0100
Remove all use of inet_pton
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor.c | 33 +
src/qemu/qemu_monitor.h | 2 ++
2 files changed, 35 insertions(+)
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 4442ef6cca..ebd7eaa1a9 100644
--- a/src/qemu/qemu_monitor.c
Some callers of virQEMUCapsGetCPUDefinitions will need to filter the
returned list of CPU models. Let's add the filtering parameters directly
to virQEMUCapsGetCPUDefinitions to avoid copying the CPU models list
twice.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 11
It is a container for a CPU models list (qemuMonitorCPUDefInfo) and a
number of elements in this list.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 24 ++--
src/qemu/qemu_monitor.c | 39 +++--
src/qemu/qemu_monitor.h | 14 +++--
Signed-off-by: Jiri Denemark
---
src/libvirt_private.syms | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 7b681fac64..b8e118db0d 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -3078,6 +3078,7 @@
Signed-off-by: Jiri Denemark
---
src/conf/domain_capabilities.c | 33 -
src/conf/domain_capabilities.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 37 deletions(-)
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
We will need to keep some QEMU-specific data for each CPU model
supported by a QEMU binary. Instead of complicating the generic
virDomainCapsCPUModelsPtr, we can just directly store
qemuMonitorCPUDefsPtr returned by the capabilities probing code.
Signed-off-by: Jiri Denemark
---
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 58 +++-
1 file changed, 24 insertions(+), 34 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 74920901b3..52a2594bf3 100644
---
QEMU 4.2.0 will report default CPU types used by each machine type and
we will want to start using it.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 15 ++-
src/qemu/qemu_monitor.c | 1 +
src/qemu/qemu_monitor.h |
On Tue, Oct 01, 2019 at 11:20:42 +0200, Paolo Bonzini wrote:
> On 30/09/19 18:16, Jiri Denemark wrote:
> > On Mon, Sep 30, 2019 at 17:16:27 +0200, Paolo Bonzini wrote:
> >> On 30/09/19 16:31, Hu, Robert wrote:
> This might be a problem if there are plans to eventually make KVM support
>
On Thu, Oct 03, 2019 at 16:27:23 +0200, Peter Krempa wrote:
> On Thu, Oct 03, 2019 at 16:00:34 +0200, Jiri Denemark wrote:
> > We need to create a mapping between CPU model names and their
> > corresponding QOM types.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> > src/qemu/qemu_capabilities.c
On Thu, Oct 03, 2019 at 02:53:11PM +0100, Daniel P. Berrangé wrote:
The mktempd module in gnulib provides an equivalent to 'mktemp -d' on
platforms which lack this shell command. All platforms on which libvirt
runs the affected tests have 'mktemp -d' support, so the gnulib module
is not
The modues in this series are either obsolete (problems now fixed), or
redundant (fixing problems we never cared about - hello AIX
portability), or trivially replaced.
Daniel P. Berrangé (11):
bhyve: stop using private gnulib _getopt_internal_r func
build: drop the getopt-posix gnulib module
The mktempd module in gnulib provides an equivalent to 'mktemp -d' on
platforms which lack this shell command. All platforms on which libvirt
runs the affected tests have 'mktemp -d' support, so the gnulib module
is not required.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf| 1 -
Rather than returning a direct pointer the list stored in qemuCaps the
function now creates a new copy of the CPU models list.
The main purpose of this seemingly useless change is to update callers
to free the result returned by virQEMUCapsGetCPUDefinitions because the
internals of this function
Let's store qemuMonitorCPUDefInfo directly in the array of CPUs in
qemuMonitorCPUDefs rather then using an array of pointers.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 8
src/qemu/qemu_monitor.c | 5 ++---
src/qemu/qemu_monitor.h | 2 +-
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index dac3d3b633..255ae8e665 100644
--- a/src/qemu/qemu_capabilities.c
+++
When starting a domain without a CPU model specified in the domain XML,
QEMU will choose a default one. Which is fine unless the domain gets
migrated to another host because libvirt doesn't perform any CPU ABI
checks and the virtual CPU provided by QEMU on the destination host can
differ from the
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor_json.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index aa6074bc02..720cd78a23 100644
--- a/src/qemu/qemu_monitor_json.c
+++
All callers use nameLen == -1 anyway.
Signed-off-by: Jiri Denemark
---
src/conf/domain_capabilities.c | 7 +++
src/conf/domain_capabilities.h | 1 -
src/qemu/qemu_capabilities.c | 2 +-
tests/cputest.c| 4 ++--
4 files changed, 6 insertions(+), 8 deletions(-)
diff --git
Signed-off-by: Jiri Denemark
---
src/conf/domain_capabilities.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index 1000d8b969..37e767d5c9 100644
--- a/src/conf/domain_capabilities.c
+++
On Thu, Oct 03, 2019 at 02:53:13PM +0100, Daniel P. Berrangé wrote:
This reverts commit 83aca30f1e8be524780a60b9dd8a14ec5f9de878.
While the motivation of the original commit is fine, we are intending to
drop autoconf in favour of meson, and similarly wish to drop use of
gnulib. Removing this
On Thu, Oct 03, 2019 at 02:53:12PM +0100, Daniel P. Berrangé wrote:
stpcpy returns a pointer to the end of the string just copied
which in theory makes it easier to then copy another string
after it. We only use stpcpy in one place though and that
is trivially rewritten to avoid stpcpy with no
On 10/3/19 10:28 AM, Fabiano Fidêncio wrote:
086c19d69 added bochs-display capability but didn't fill in the info for
domain capabilities.
Signed-off-by: Fabiano Fidêncio
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_capabilities.c | 2 ++
On Thu, Oct 03, 2019 at 02:53:15PM +0100, Daniel P. Berrangé wrote:
gnulib fixes a portability problem on AIX which is a platform we have
never targetted.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
On Thu, Oct 03, 2019 at 02:53:17PM +0100, Daniel P. Berrangé wrote:
This fixes a problem on mingw where it doesn't know how to report
certain errnos defined by POSIX, but not used on Windows. These are
not a real problem for libvirt.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf | 1 -
1
On Thu, Oct 03, 2019 at 02:53:18PM +0100, Daniel P. Berrangé wrote:
This was fixing a problem with old versions of mingw which had a
pthread.h that polluted the namespace with random symbols. This is no
longer relevant on our mingw platform targets.
Signed-off-by: Daniel P. Berrangé
---
On Thu, Oct 03, 2019 at 02:53:14PM +0100, Daniel P. Berrangé wrote:
The usleep function was missing on older mingw versions, but we can rely
on it existing everywhere these days.
Per https://www.gnu.org/software/gnulib/manual/html_node/usleep.html#usleep
usleep only works up to one second on
On Thu, Oct 03, 2019 at 02:53:16PM +0100, Daniel P. Berrangé wrote:
The use of this script was discontinued when we stopped providing a full
ChangeLog in the dist with:
commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba
Author: Andrea Bolognani
Date: Mon Apr 1 17:33:03 2019 +0200
maint:
On Thu, Oct 03, 2019 at 05:12:52PM +0200, Ján Tomko wrote:
> On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
> > The getopt-posix module fixes a problem with optind being incorrectly
> > set after a failed option parse. This is not something that matters to
> > libvirt code.
>
On Thu, Oct 03, 2019 at 05:34:50PM +0200, Ján Tomko wrote:
> On Thu, Oct 03, 2019 at 02:53:14PM +0100, Daniel P. Berrangé wrote:
> > The usleep function was missing on older mingw versions, but we can rely
> > on it existing everywhere these days.
> >
>
> Per
On Thu, Oct 03, 2019 at 02:53:08PM +0100, Daniel P. Berrangé wrote:
The _getopt_internal_r func is not intended for public use, it is an
internal function shared between the gnulib getopt and argp modules.
Signed-off-by: Daniel P. Berrangé
---
src/bhyve/bhyve_parse_command.c | 88
On Thu, Oct 03, 2019 at 02:45:36PM +0200, Pavel Mores wrote:
On Thu, Oct 03, 2019 at 01:09:55PM +0200, Pavel Mores wrote:
On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote:
> On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote:
> > On Wed, Oct 02, 2019 at 08:34:10AM -0300,
87 matches
Mail list logo
