CC'ing Nikolay on this to raise the issue of broken deps in the OpenVZ
repo for CentOS 7 & incorrectly documented GPG keys ...
On Fri, Dec 06, 2019 at 06:53:38PM +, Daniel P. Berrangé wrote:
> The OpenVZ site provides a yum repo built against RHEL-7 that includes
> the prlsdk-devel RPM needed
On Sat, Dec 7, 2019 at 4:43 PM Fabiano Fidêncio wrote:
>
> Fedora 29 has reached its end of life on November 26th 2019.
>
> For more info, please, refer to the following e-mail:
> https://lists.fedoraproject.org/archives/list/devel-annou...@lists.fedoraproject.org/thread/
>
> Signed-off-by:
Python world uses setup.py for everything so our Makefile is just a
"convenience" wrapper for people using to type 'make'. Remove it as it
doesn't add that much value and would need to be updated for python 3.
Signed-off-by: Peter Krempa
---
Makefile | 18 --
1 file changed, 18
On 06/12/2019 16.14, Eric Blake wrote:
> On 12/5/19 11:36 PM, Thomas Huth wrote:
>> Now that the "name" parameter is gone, there is hardly any difference
>> between NetLegacy and Netdev anymore. Drop NetLegacy and always use
>> Netdev to simplify the code quite a bit.
>>
>> Signed-off-by: Thomas
Refactoring of the XML parser left few instances of the
libxlDriverConfig object unused. Remove them.
Signed-off-by: Peter Krempa
---
Pushed under the build-breaker rule as it makes clang unhappy.
src/libxl/libxl_domain.c | 1 -
tests/xlconfigtest.c | 1 -
tests/xmconfigtest.c | 1 -
The .pc files in src/ are intended for use with the ./run script,
to ease building bindings against an uninstalled libvirt build.
The pointer to the API XML files is incorrect though, it needs to
point into the build tree.
This fixes use of the run script for building libvirt-python, ex:
On Tue, Dec 03, 2019 at 18:17:42 +0100, Peter Krempa wrote:
> This allows to start and manage the backup job.
>
> Signed-off-by: Peter Krempa
> ---
> po/POTFILES.in | 1 +
> src/qemu/Makefile.inc.am | 2 +
> src/qemu/qemu_backup.c | 941 +++
>
On Mon, Dec 9, 2019 at 3:25 PM Andrea Bolognani wrote:
>
> Back when they were introduced, we chose to only include the part
> of the version number preceding the dot with the rationale that
> doing so introduced no ambiguity since, while there are two Ubuntu
> releases per year, we only support
For any backing file we set 'read-only' to true, but didn't do this when
modifying the recorded backing store when creating external snapshots.
This meant that qemu would attempt to open the backing-file read-write.
This would fail for example when selinux is used as qemu doesn't have
write
On Mon, Dec 09, 2019 at 12:23:23PM +0100, Peter Krempa wrote:
> Python world uses setup.py for everything so our Makefile is just a
> "convenience" wrapper for people using to type 'make'. Remove it as it
> doesn't add that much value and would need to be updated for python 3.
>
> Signed-off-by:
On Mon, Dec 09, 2019 at 12:52:04PM +0100, Peter Krempa wrote:
For any backing file we set 'read-only' to true, but didn't do this when
modifying the recorded backing store when creating external snapshots.
This meant that qemu would attempt to open the backing-file read-write.
This would fail
On 09/12/2019 14.30, Paolo Bonzini wrote:
> On 09/12/19 14:12, Philippe Mathieu-Daudé wrote:
>> On 12/9/19 1:52 PM, Thomas Huth wrote:
>>> Now that the old pc-0.x machine types have been removed, we do not need
>>> the old "rombar" hacks anymore.
>>>
>>> Signed-off-by: Thomas Huth
>>> ---
>>>
On Mon, Dec 09, 2019 at 09:02:56AM -0500, Cole Robinson wrote:
> The .pc files in src/ are intended for use with the ./run script,
> to ease building bindings against an uninstalled libvirt build.
> The pointer to the API XML files is incorrect though, it needs to
> point into the build tree.
>
>
On Tue, Dec 03, 2019 at 06:17:29PM +0100, Peter Krempa wrote:
From: Eric Blake
This one is fairly straightforward - the generator already does what
we need.
Signed-off-by: Eric Blake
Signed-off-by: Peter Krempa
---
src/remote/remote_driver.c | 2 ++
src/remote/remote_protocol.x | 33
On Sat, 2019-12-07 at 16:51 +0100, Fabiano Fidêncio wrote:
> On Sat, Dec 7, 2019 at 1:13 AM Jim Fehlig wrote:
> > I forgot to mention, 'lcitool update libvirt-opensuse-151 libvirt' still
> > fails
> > in the Configure hostname task
> >
> > TASK [Configure hostname]
> >
On Fri, 2019-12-06 at 23:44 +, Jim Fehlig wrote:
> This change adds support for installing and updating openSUSE Leap 15.1
> using lcilool.
s/lool/tool/
> +++ b/guests/host_vars/libvirt-opensuse-151/docker.yml
> +---
> +docker_base: opensuse/leap:15.1
Docker support is still busted: if you
On 12/8/19 4:43 PM, Cole Robinson wrote:
On 11/29/19 4:40 AM, Jidong Xia wrote:
With this patch users can cold unplug some sound devices.
use "virsh detach-device vm sound.xml --config" command.
Signed-off-by: Jidong Xia
---
src/conf/domain_conf.c | 48
On 12/9/19 1:52 PM, Thomas Huth wrote:
Now that the old pc-0.x machine types have been removed, we do not need
the old "rombar" hacks anymore.
Signed-off-by: Thomas Huth
---
hw/display/vga-pci.c| 5 -
hw/display/vga.c| 4 +---
hw/display/vmware_vga.c | 5 -
3 files
On 09/12/19 14:12, Philippe Mathieu-Daudé wrote:
> On 12/9/19 1:52 PM, Thomas Huth wrote:
>> Now that the old pc-0.x machine types have been removed, we do not need
>> the old "rombar" hacks anymore.
>>
>> Signed-off-by: Thomas Huth
>> ---
>> hw/display/vga-pci.c | 5 -
>>
On Mon, Dec 09, 2019 at 02:12:35PM +0100, Philippe Mathieu-Daudé wrote:
> On 12/9/19 1:52 PM, Thomas Huth wrote:
> > Now that the old pc-0.x machine types have been removed, we do not need
> > the old "rombar" hacks anymore.
> >
> > Signed-off-by: Thomas Huth
> > ---
> > hw/display/vga-pci.c
Back when they were introduced, we chose to only include the part
of the version number preceding the dot with the rationale that
doing so introduced no ambiguity since, while there are two Ubuntu
releases per year, we only support LTS releases and those happen
once every two years.
When
On Tue, Dec 03, 2019 at 06:17:26PM +0100, Peter Krempa wrote:
From: Eric Blake
Prepare for new backup APIs by describing the XML that will represent
a backup. The XML resembles snapshots and checkpoints in being able
to select actions for a set of disks, but has other differences. It
can
This fixes some problems from my series related to RHEL-7 and
VZ, and also one that seems to have hit VZ for a long while
before.
I'm pushing all as trivial/build fixes.
Daniel P. Berrangé (5):
tests: fix warning with old GCC about missing struct initializer
vz: pass virDomainXMLOptionPtr to
The path needs to be adjusted for the new script location
Signed-off-by: Cole Robinson
---
tests/testutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/testutils.c b/tests/testutils.c
index 9312ff761e..a8215afa42 100644
--- a/tests/testutils.c
+++
On Tue, Dec 03, 2019 at 06:17:24PM +0100, Peter Krempa wrote:
A pull mode backup job uses temporary disk images to hold the changed
parts of the disk while the client is copying the changes. Since usage
of the temporary space can be monitored but doesn't really fit any of
the existing stats
On Tue, Dec 03, 2019 at 06:17:23PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
First fix is straightforward, the test-wrap-argv.py path needs to
be adjusted.
Second bit fixes an issue I hit with:
VIR_TEST_REGENERATE_OUTPUT=1 ./build/tests/qemuxml2argvtest
Where it reported not finding a python binary. I assume this is due
to some preload PATH alteration, like the
On Tue, Dec 03, 2019 at 06:17:27PM +0100, Peter Krempa wrote:
From: Eric Blake
Introduce a few new public APIs related to incremental backups. This
builds on the previous notion of a checkpoint (without an existing
checkpoint, the new API is a full backup, differing from
virDomainBlockCopy in
On Tue, Dec 03, 2019 at 06:17:28PM +0100, Peter Krempa wrote:
Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation.
Signed-off-by: Peter Krempa
---
include/libvirt/libvirt-domain.h | 1 +
tools/virsh-domain.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
On 09/12/19 13:52, Thomas Huth wrote:
> These have been on the deprecation list since a year now, so it's
> time to finally remove the pc-0.x machine types.
>
> We then can also remove some compatibility hacks in the devices, i.e.
> the "use_broken_id" in ac97, the "command_serr_enable" in PCI
This is the name used on Ubuntu.
Signed-off-by: Andrea Bolognani
---
setup.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/setup.py b/setup.py
index ea25dc0..2831595 100755
--- a/setup.py
+++ b/setup.py
@@ -297,6 +297,7 @@ class my_test(Command):
"nosetests-%d.%d" %
Extend configure to pass the detect python binary to C code, and
use it in the test suite, rather than searching PATH
Signed-off-by: Cole Robinson
---
configure.ac | 1 +
tests/testutils.c | 12 +---
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/configure.ac
On Tue, Dec 03, 2019 at 06:17:25PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
Reviewed-by: Eric Blake
Reviewed-by: Daniel P. Berrangé
---
tools/virsh-domain.c | 18 ++
1 file changed, 18 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
On Fri, 2019-12-06 at 23:44 +, Jim Fehlig wrote:
> guests: Add lci build support for openSUSE
s/lci build/'lcitool build'/
With that changed
Reviewed-by: Andrea Bolognani
I'll push the series in a few minutes.
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
These machines can't be used reliably for migration anymore, quoting
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04516.html :
"
due to the introduction of the memory API, the firmware is not
migrated correctly from source to destination. On QEMU <1.3 the
0xf-0xf area is
Now that the old pc-0.x machine types have been removed, this config
knob is not required anymore.
Signed-off-by: Thomas Huth
---
hw/pci/pci.c | 6 +-
include/hw/pci/pci.h | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index
Now that the old pc-0.x machine types are gone, we do not need
the "use_broken_id" hack anymore.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
hw/audio/ac97.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index
Now that the old pc-0.x machine types have been removed, we do not need
the old "rombar" hacks anymore.
Signed-off-by: Thomas Huth
---
hw/display/vga-pci.c| 5 -
hw/display/vga.c| 4 +---
hw/display/vmware_vga.c | 5 -
3 files changed, 1 insertion(+), 13 deletions(-)
diff
These have been on the deprecation list since a year now, so it's
time to finally remove the pc-0.x machine types.
We then can also remove some compatibility hacks in the devices, i.e.
the "use_broken_id" in ac97, the "command_serr_enable" in PCI devices
and the "rombar" stuff in VGA devices.
On Mon, Dec 09, 2019 at 03:28:58PM +0100, Andrea Bolognani wrote:
> This is the name used on Ubuntu.
>
> Signed-off-by: Andrea Bolognani
> ---
> setup.py | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
Let's always generate the unattended script file as, by doing this, we
can trea the files we have as templates, being able to change them
accordingly to whatever is needed by specific distros.
It's important to note that we *must* be careful and keep generating
those files using their "expected"
In order to add CentOS 8 to jenkins-ci, we had to:
- Adjust lcitool to generate unattended scripts based on templates
instead of using the templates themselves, as a new parameter is
expected on kickstart files for RHEL / CentOS 8 (or newer);
- Enable the EPEL and PowerTools repos;
Then, the
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index b924f1f..06a7844 100644
---
This is needed as all the development packages will come from the
PowerTools repository, which is not enabled by default.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 8
1 file changed, 8 insertions(+)
diff --git a/guests/playbooks/update/tasks/base.yml
EPEL repository should be enabled on all supported CentOS guests as it
brings in packages which are part of the "base packages" for
libvirt-jenkins-ci.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 1 -
1 file changed, 1 deletion(-)
diff --git
On Tue, Dec 03, 2019 at 06:17:34PM +0100, Peter Krempa wrote:
We will want to use the async job infrastructure along with all the APIs
and event for the backup job so add the backup job as a new async job
type.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 3 +++
On Tue, Dec 03, 2019 at 06:17:33PM +0100, Peter Krempa wrote:
Introduce QEMU_DOMAIN_JOB_STATS_TYPE_BACKUP and the convertors and other
plumbing to be able to report statistics for the backup job.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 62
On Tue, Dec 03, 2019 at 06:17:30PM +0100, Peter Krempa wrote:
From: Eric Blake
Accept XML describing a generic block job, and output it again as
needed.
This may still need a few tweaks to match the documented XML
and RNG schema.
A leftover from earlier versions? This essentially says:
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/virt-manager.yml | 3 +++
jenkins/projects/virt-manager.yaml | 3 +++
3 files changed, 7 insertions(+)
diff --git
This commit allows calling `lcitool install libvirt-centos-8`.
`lcitool update libvirt-centos-8 $project` does *not* work as:
- EPEL repository is only enabled for CentOS 7;
- The reason EPEL is needed because of some base packages (as screen);
- There's no task to enable PowerTools repository;
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/libvirt-go-xml.yml | 1 +
jenkins/projects/libvirt-go-xml.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git
Seems that for all OSes where run libvirt-dbus tests python3-entrypoints
is pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml
Seems that for all OSes where run libvirt-dbus tests python3-pyflakes is
pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 93e66e3..793ad3e 100644
---
Passing `url --url={{ install_url }}` to a kickstart file is, according
to Red Hat official documentation[0], mandatory for RHEL 8 and onwards
(which includes CentOS 8).
Using it for RHEL 7, CentOS 7, and Fedora does not cause any issue.
[0]:
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/libvirt-dbus.yml | 2 ++
jenkins/projects/libvirt-dbus.yaml | 2 ++
3 files changed, 5 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 7a55c4b..93e66e3 100644
---
In order to perform a virt-viewer `update` and `build` on a CentOS 8
guest, a few changes in the mappings have been done.
The changes are:
- libgovirt-devel and gtk-vnc2-devel are not present anymore
-
Seems that for all OSes where run libvirt-dbus tests python3-pycodestile
is pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml
Seems that for all OSes where we run libvirt-dbus tests python3-mccabe
is pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml
In order to perform a libvirt `update` and `build` on a CentOS 8 guest,
a few changes in the mappings have been done.
The changes are:
- libssh2 is not longer present:
-
On Tue, Dec 03, 2019 at 06:17:42PM +0100, Peter Krempa wrote:
This allows to start and manage the backup job.
Signed-off-by: Peter Krempa
---
po/POTFILES.in | 1 +
src/qemu/Makefile.inc.am | 2 +
src/qemu/qemu_backup.c | 941 +++
On Tue, Dec 03, 2019 at 06:17:45PM +0100, Peter Krempa wrote:
After the individual sub-blockjobs of a backup libvirt job finish we
must detect it and notify the parent job, so that it can be properly
terminated.
Since we update job information to determine success of an blockjob we
can directly
On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> This is needed as all the development packages will come from the
> PowerTools repository, which is not enabled by default.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> guests/playbooks/update/tasks/base.yml | 8
> 1 file
On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> EPEL repository should be enabled on all supported CentOS guests as it
> brings in packages which are part of the "base packages" for
> libvirt-jenkins-ci.
>
> Signed-off-by: Fabiano Fidêncio
> ---
>
On Mon, 2019-12-09 at 18:29 +0100, Andrea Bolognani wrote:
> These changes are not wrong per se, but I would prefer it if the
> series had a different structure:
>
> * set the stage
> + this is your first two patches
>
> * add support for installing a CentOS 8 guest
> + all the other
On 12/3/19 11:17 AM, Peter Krempa wrote:
After the individual sub-blockjobs of a backup libvirt job finish we
must detect it and notify the parent job, so that it can be properly
terminated.
Since we update job information to determine success of an blockjob we
s/an/a/
can directly report
On 12/9/19 1:15 PM, Cole Robinson wrote:
> Adjust virLXCDriverGetCapabilities to fill in driver->caps if it has
> never been set, regardless of the passed 'refresh' boolean.
>
> This fixes LXC XML startup parsing for me
>
> Signed-off-by: Cole Robinson
> ---
> src/lxc/lxc_conf.c | 2 +-
> 1
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml| 1 +
guests/playbooks/build/projects/libosinfo.yml | 1 +
jenkins/projects/libosinfo.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 793ad3e..63ac54b 100644
---
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 61ef995..e764964 100644
---
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/osinfo-db-tools.yml | 1 +
jenkins/projects/osinfo-db-tools.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/libvirt-go.yml | 1 +
jenkins/projects/libvirt-go.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
On Tue, Dec 03, 2019 at 06:17:32PM +0100, Peter Krempa wrote:
From: Eric Blake
Introduce virsh commands for performing backup jobs.
Signed-off-by: Eric Blake
Signed-off-by: Peter Krempa
---
po/POTFILES.in | 1 +
tools/Makefile.am| 1 +
tools/virsh-backup.c | 151
On Tue, Dec 03, 2019 at 06:17:35PM +0100, Peter Krempa wrote:
A backup job may consist of many backup sub-blockjobs. Add the new
blockjob type and add all type converter strings.
Signed-off-by: Peter Krempa
---
examples/c/misc/event-test.c | 3 +++
include/libvirt/libvirt-domain.h | 3 +++
On Tue, Dec 03, 2019 at 06:17:38PM +0100, Peter Krempa wrote:
A backup blockjob needs to be able to notify the parent backup job as
well as track all data to be able to clean up the bitmap and blockdev
used for the backup.
Add the data structure, job allocation function and status XML formatter
On Tue, Dec 03, 2019 at 06:17:43PM +0100, Peter Krempa wrote:
We can use the output of 'query-jobs' to figure out some useful
information about a backup job. That is progress in case of a push job
and scratch file use in case of a pull job.
Add a worker which will total up the data and call it
On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> guests,jenkins: Add CentOS 8
s/,jenkins//
[...]
> diff --git a/guests/playbooks/build/jobs/defaults.yml
> b/guests/playbooks/build/jobs/defaults.yml
> index 0175a05..5e4ec03 100644
> --- a/guests/playbooks/build/jobs/defaults.yml
>
On Mon, Dec 09, 2019 at 06:45:10PM +0100, Andrea Bolognani wrote:
> On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> > Seems that for all OSes where run libvirt-dbus tests python3-entrypoints
> > is pulled together when installing flake8. However, this is not the case
> > for CentOS 8
On 12/3/19 11:17 AM, Peter Krempa wrote:
Use the helper which cancels all blockjobs to perform the backup job
cancellation in qemuDomainAbortJob.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
Reviewed-by:
Patchew URL: https://patchew.org/QEMU/20191209125248.5849-1-th...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!
On Tue, Dec 03, 2019 at 06:17:31PM +0100, Peter Krempa wrote:
Now that the parser and formatter are in place we can excercise it on
the test files.
Signed-off-by: Peter Krempa
---
tests/Makefile.am | 1 +
.../backup-pull-seclabel.xml | 18
On Tue, Dec 03, 2019 at 06:17:47PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 1 +
tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 1 +
[...]
tests/domaincapsdata/qemu_4.2.0.x86_64.xml| 1 +
82 files changed, 82
On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> Seems that for all OSes where run libvirt-dbus tests python3-entrypoints
> is pulled together when installing flake8. However, this is not the case
> for CentOS 8 and that's the reason for explicitly adding the dependency
> here.
On Mon, Dec 09, 2019 at 01:16:42PM -0500, Cole Robinson wrote:
> On 12/9/19 1:15 PM, Cole Robinson wrote:
> > Adjust virLXCDriverGetCapabilities to fill in driver->caps if it has
> > never been set, regardless of the passed 'refresh' boolean.
> >
> > This fixes LXC XML startup parsing for me
> >
On Mon, Dec 09, 2019 at 01:14:26PM -0500, Cole Robinson wrote:
> $ cat f | grep -e arch -e emulator
> hvm
> $ sudo virsh define f
> error: Failed to define domain from f
> error: An error occurred, but the cause is unknown
>
> After:
> $ sudo virsh define f
> error: Failed to define domain
This fixes commit bf9d812956100442a195d99773620e1795b8633d
Signed-off-by: Daniel P. Berrangé
---
src/vz/vz_driver.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 7dd44ad153..bcdbb50404 100644
--- a/src/vz/vz_driver.c
This fixes commit 4a4132b4625778cf80acb9c92d06351b44468ac3
Signed-off-by: Daniel P. Berrangé
---
src/vz/vz_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 9e8ea676e0..7b90fee378 100644
--- a/src/vz/vz_driver.c
+++
This fixes commit 61bff77bf993ac782c850cfd1145e83c216e4a21
Signed-off-by: Daniel P. Berrangé
---
src/vz/vz_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 7b90fee378..7dd44ad153 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
The virDomainVideoDefNew requires the xml options to be
provided since
commit 3dbf3941ad7202ec4426cfe965d8ba97ee8d49df
Author: Marc-André Lureau
Date: Mon Sep 23 14:44:35 2019 +0400
conf: add privateData to virDomainVideoDef
Signed-off-by: Daniel P. Berrangé
---
src/vz/vz_sdk.c |
Old GCC isn't happy about the {0} initializer because the first
field in the struct is itself a struct.
../../tests/openvzutilstest.c: In function 'testReadNetworkConf':
../../tests/openvzutilstest.c:101:12: error: missing braces around initializer
[-Werror=missing-braces]
struct
On Mon, 2019-12-09 at 12:59 +0100, Andrea Bolognani wrote:
> On Fri, 2019-12-06 at 23:44 +, Jim Fehlig wrote:
> > guests: Add lci build support for openSUSE
>
> s/lci build/'lcitool build'/
>
> With that changed
>
> Reviewed-by: Andrea Bolognani
>
> I'll push the series in a few
On Tue, Dec 03, 2019 at 06:17:41PM +0100, Peter Krempa wrote:
The stats reported for a blockjob which is member of a domain pull
backup refer to the utilization of the scratch file rather than the
progress of the backup as the progress of the backup depends on the
client. Note this quirk in the
On Tue, Dec 03, 2019 at 06:17:39PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
.../qemustatusxml2xmldata/backup-pull-in.xml | 608 ++
.../qemustatusxml2xmldata/backup-pull-out.xml | 1 +
tests/qemuxml2xmltest.c | 2 +
3 files changed, 611
On Tue, Dec 03, 2019 at 06:17:40PM +0100, Peter Krempa wrote:
We need a place to store stats of completed sub-jobs so that we can
later report accurate stats.
Signed-off-by: Peter Krempa
---
src/conf/backup_conf.h | 7 +++
1 file changed, 7 insertions(+)
Reviewed-by: Ján Tomko
Jano
On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> guests,jenkins: Build libvirt on CentOS 8 guests
s/,jenkins//
[...]
> +++ b/jenkins/projects/libvirt.yaml
> @@ -14,6 +14,7 @@
># commands with more arguments than FreeBSD supports
>machines:
> -
On 12/3/19 11:17 AM, Peter Krempa wrote:
This allows to start and manage the backup job.
Signed-off-by: Peter Krempa
---
resuming where I left off last time
+
+static int
+qemuBackupDiskPrepareDataOne(virDomainObjPtr vm,
+
+static int
+qemuBackupDiskPrepareDataOnePush(virJSONValuePtr
$ cat f | grep -e arch -e emulator
hvm
$ sudo virsh define f
error: Failed to define domain from f
error: An error occurred, but the cause is unknown
After:
$ sudo virsh define f
error: Failed to define domain from f
error: unsupported configuration: No emulator found for arch 'mipsel'
Adjust virLXCDriverGetCapabilities to fill in driver->caps if it has
never been set, regardless of the passed 'refresh' boolean.
This fixes LXC XML startup parsing for me
Signed-off-by: Cole Robinson
---
src/lxc/lxc_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Dec 03, 2019 at 06:17:36PM +0100, Peter Krempa wrote:
Implement the transaction actions generator for blockdev-backup.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13 +
src/qemu/qemu_monitor.h | 15 +++
src/qemu/qemu_monitor_json.c | 29
1 - 100 of 172 matches
Mail list logo
