[libvirt] [PATCH 39/42] locking: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon.c | 11 +++ src/locking/lock_driver_lockd.c | 3 +-- 2 files changed, 4 insertions(+), 10 deletions(-) diff

[libvirt] [PATCH 31/42] network: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/network/bridge_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt] [PATCH 38/42] locking: Use g_autofree on virLockDaemonExecRestartStatePath()

Together with the change, let's also simplify the function and get rid of the goto. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index

[libvirt] [PATCH 15/42] qemu: Don't check the output of virGetUserCacheDirectory()

virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_conf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 389ac55bee..634c65095e 100644

[libvirt] [PATCH 24/42] util: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/util/virhostdev.c | 3 +-- src/util/virpidfile.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virhostdev.c

[libvirt] [PATCH 28/42] remote: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/remote/remote_daemon.c | 8 +--- src/remote/remote_driver.c | 3 +-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git

[libvirt] [PATCH 08/42] storage: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/storage/storage_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_driver.c

[libvirt] [PATCH 14/42] util: Don't check the output of virGetUserCacheDirectory()

virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/util/virlog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 10639d7328..6bae56e2e3

[libvirt] [PATCH 12/42] vbox: Don't check the output of virGetUserCacheDirectory()

virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/vbox/vbox_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index

[libvirt] [PATCH 17/42] remote: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/remote/remote_daemon_config.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/remote/remote_daemon_config.c

[libvirt] [PATCH 01/42] tools: Use g_autofree on cmdCd()

Signed-off-by: Fabiano Fidêncio --- tools/vsh.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 5ccda5ab44..bbb6227130 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3175,8 +3175,7 @@ bool cmdCd(vshControl *ctl, const vshCmd *cmd) {

[libvirt] [PATCH 07/42] util: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/util/virauth.c | 3 +-- src/util/virconf.c | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virauth.c

[libvirt] [PATCH 18/42] qemu: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] [PATCH 26/42] secret: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/secret/secret_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c

[libvirt] [PATCH 06/42] qemu: Don't check the output of virGetUserDirectory()

virGetUserDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/qemu/qemu_interop_config.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_interop_config.c b/src/qemu/qemu_interop_config.c index

[libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

virGetUserDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 12 src/rpc/virnettlscontext.c | 12 2 files changed, 4 insertions(+), 20 deletions(-) diff --git

[libvirt] [PATCH 11/42] vbox: Use g_autofree on vboxDomainScreenshot()

This also fixes a cacheDir's leak when g_mkstep_full() fails. Signed-off-by: Fabiano Fidêncio --- src/vbox/vbox_common.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 5957ae52c4..586937fa19 100644 ---

[libvirt] [PATCH 00/42] Cleanups after adopting g_get_*_dir()

After adopting g_get_*_dir(), internally, when implementing virGetUser*Dir(), the libvirt functions changed their behaviour as NULL is never ever returned by the GLib functions. Knowing that, let's cleanup the callers' code of those functions, removing the unnecessary checks. While doing the

[libvirt] [PATCH 04/42] rpc: Use g_autofree on virNetClientNewLibssh()

Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 75e653fec8..1b882a261a 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@

[libvirt] [PATCH 02/42] vbox: Don't leak virGetUserDirectory()'s output

On vboxStorageVolCreateXML(), virGetUserDirectory() was called without freeing its content later on. Signed-off-by: Fabiano Fidêncio --- src/vbox/vbox_storage.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vbox/vbox_storage.c b/src/vbox/vbox_storage.c index

[libvirt] [PATCH 10/42] tools: Don't check the output of virGetUserCacheDirectory()

virGetUserCacheDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- tools/vsh.c | 5 - 1 file changed, 5 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index bbb6227130..b982aeb359 100644 --- a/tools/vsh.c +++

[libvirt] [PATCH 13/42] util: Use g_autofree on virLogSetDefaultOutputToFile()

Signed-off-by: Fabiano Fidêncio --- src/util/virlog.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index d45e2dd316..10639d7328 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -173,8 +173,7 @@

[libvirt] [PATCH 23/42] locking: Don't check the output of virGetUserConfigDirectory()

virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/locking/lock_daemon_config.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/locking/lock_daemon_config.c

[libvirt] [PATCH 03/42] rpc: Use g_autofree on virNetClientNewLibSSH2()

Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 47a17d30f7..75e653fec8 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@

<    1   2