On Wed, Jun 03, 2020 at 11:34:07 +0200, Erik Skultety wrote:
> On Wed, Jun 03, 2020 at 11:11:08AM +0200, Michal Privoznik wrote:
> > On 6/3/20 10:40 AM, Peter Krempa wrote:
> > > On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal Privoznik wrote:
> > > > On 6/3/20 9:31 AM, Peter Krempa wrote:
> > > >
First time in a while - Coverity complained this morning
[...]
> diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c
> index e73b4d0690..c4223f4e06 100644
> --- a/src/lxc/lxc_fuse.c
> +++ b/src/lxc/lxc_fuse.c
> @@ -326,10 +326,10 @@ int lxcSetupFuse(virLXCFusePtr *f, virDomainDefPtr def)
>
On Tue, May 19, 2020 at 10:55:02AM +0100, Daniel P. Berrangé wrote:
> The Fedora translation team has stopped using Zanata because the
> software itself is dead upstream. In its place is the Weblate
> platform. In theory we should have been able to work with Weblate in the
> same way as we did for
This reverts b897973f2e0.
Even though it may have been the case in the past, relative
XPaths don't overwrite the ctxt->node. Thus, there's no need to
save it.
Signed-off-by: Michal Privoznik
---
src/util/virxml.c | 27 ---
1 file changed, 27 deletions(-)
diff --git
I've been playing with cocci again.
Michal Prívozník (2):
virxml: Don't overwrite ctxt->node
Use more of VIR_XPATH_NODE_AUTORESTORE
src/conf/cpu_conf.c | 3 +-
src/conf/domain_conf.c | 7 +--
src/conf/interface_conf.c | 16 ++-
src/conf/netdev_vlan_conf.c
On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal Privoznik wrote:
> On 6/3/20 9:31 AM, Peter Krempa wrote:
> > QEMU added the machine types for the 5.1 release so let's update them.
> >
> > Other notable changes are 'cpu-throttle-tailslow' migration property,
> > 'zlib' compression for qcow2 images
On 6/3/20 10:40 AM, Peter Krempa wrote:
On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal Privoznik wrote:
On 6/3/20 9:31 AM, Peter Krempa wrote:
QEMU added the machine types for the 5.1 release so let's update them.
Other notable changes are 'cpu-throttle-tailslow' migration property,
'zlib'
On Wed, Jun 03, 2020 at 11:11:08AM +0200, Michal Privoznik wrote:
> On 6/3/20 10:40 AM, Peter Krempa wrote:
> > On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal Privoznik wrote:
> > > On 6/3/20 9:31 AM, Peter Krempa wrote:
> > > > QEMU added the machine types for the 5.1 release so let's update
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> Add test to verify ZPCI address validation with uid set to 0x0
>
> Signed-off-by: Bjoern Walk
> Signed-off-by: Shalini Chellathurai Saroja
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris Fiuczynski
> ---
>
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> -if (uid &&
> -virStrToLong_uip(uid, NULL, 0, ) < 0) {
> -virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> - _("Cannot parse 'uid' attribute"));
> -goto cleanup;
> +if (uid)
On Wed, Jun 03, 2020 at 12:31:09PM +0200, Pavel Hrdina wrote:
> On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote:
> > Prior to 2621d48f005a "gnulib: delete all gnulib integration",
> > one could pass ./autogen.sh --no-git to prevent the libvirt build
> > system from running git
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> +++ b/src/conf/domain_addr.c
> @@ -145,12 +145,18 @@ static void
> virDomainZPCIAddressReleaseIds(virDomainZPCIAddressIdsPtr zpciIds,
> virZPCIDeviceAddressPtr addr)
> {
> -if (!zpciIds ||
On Wed, Jun 3, 2020 at 11:38 AM Daniel P. Berrangé wrote:
>
> On Fri, May 15, 2020 at 04:13:21PM +0100, Daniel P. Berrangé wrote:
> > On Fri, May 15, 2020 at 02:34:01PM +0200, Michal Privoznik wrote:
> > > On 5/13/20 1:56 PM, Rafael Fonseca wrote:
> > > > This patch series convert various simple
On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote:
> Prior to 2621d48f005a "gnulib: delete all gnulib integration",
> one could pass ./autogen.sh --no-git to prevent the libvirt build
> system from running git submodule update.
>
> This feature is needed by systems like the Xen Project
This is convenience macro, use it more. This commit was generated
using the following spatch:
@@
symbol node;
identifier old;
identifier ctxt;
type xmlNodePtr;
@@
- xmlNodePtr old;
+ VIR_XPATH_NODE_AUTORESTORE(ctxt);
...
- old = ctxt->node;
... when != old
- ctxt->node
On Wed, Jun 03, 2020 at 11:37:21 +0200, Erik Skultety wrote:
> On Wed, Jun 03, 2020 at 11:29:36AM +0200, Peter Krempa wrote:
> > On Wed, Jun 03, 2020 at 11:11:08 +0200, Michal Privoznik wrote:
> > > On 6/3/20 10:40 AM, Peter Krempa wrote:
> > > > On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal
We need to be able to cast from virObjectEventPtr to one of
its many subclasses. Some of these subclasses have 8 byte
alignment on 32-bit platforms, but virObjectEventPtr only
has 4 byte alignment.
Previously the virObject base class had 8 byte alignment
but this dropped to 4 byte when converted
On Wed, Jun 03, 2020 at 06:42:10 -0400, John Ferlan wrote:
> First time in a while - Coverity complained this morning
>
> [...]
>
> > diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c
> > index e73b4d0690..c4223f4e06 100644
> > --- a/src/lxc/lxc_fuse.c
> > +++ b/src/lxc/lxc_fuse.c
> > @@
On Wed, Jun 03, 2020 at 12:47:12PM +0200, Ján Tomko wrote:
> We still point to git repositories hosted on libvirt.org in various
> places. Replace the links to their gitlab.com equivalents.
>
> Note that GitLab is trying to be smart here and
> https://gitlab.com/libvirt/libvirt
> redirects to
>
On Wed, Jun 03, 2020 at 12:47:09PM +0200, Ján Tomko wrote:
> Ján Tomko (3):
> docs: csharp: remove outdated comment
> docs: virshcmdref: change repo URL to GitLab
> docs: point to GitLab as the primary git hosting
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On Wed, Jun 03, 2020 at 11:37:08AM +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 03, 2020 at 12:31:09PM +0200, Pavel Hrdina wrote:
> > On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote:
> > > Prior to 2621d48f005a "gnulib: delete all gnulib integration",
> > > one could pass
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> +static bool
> +qemuDomainDeviceDefValidateZPCIUid(virZPCIDeviceAddressPtr zpci)
> +{
> +if (zpci->uid_set &&
> +(zpci->uid > VIR_DOMAIN_DEVICE_ZPCI_MAX_UID ||
> + zpci->uid == 0)) {
> +
On 6/3/20 9:31 AM, Peter Krempa wrote:
QEMU added the machine types for the 5.1 release so let's update them.
Other notable changes are 'cpu-throttle-tailslow' migration property,
'zlib' compression for qcow2 images and absrtact socket support.
Signed-off-by: Peter Krempa
---
As usual, I'll
On Wed, Jun 03, 2020 at 11:11:08 +0200, Michal Privoznik wrote:
> On 6/3/20 10:40 AM, Peter Krempa wrote:
> > On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal Privoznik wrote:
> > > On 6/3/20 9:31 AM, Peter Krempa wrote:
> > > > QEMU added the machine types for the 5.1 release so let's update them.
On Wed, Jun 03, 2020 at 11:45:49 +0200, Peter Krempa wrote:
> On Wed, Jun 03, 2020 at 11:37:21 +0200, Erik Skultety wrote:
> > On Wed, Jun 03, 2020 at 11:29:36AM +0200, Peter Krempa wrote:
> > > On Wed, Jun 03, 2020 at 11:11:08 +0200, Michal Privoznik wrote:
> > > > On 6/3/20 10:40 AM, Peter
On 6/3/20 1:22 PM, Daniel P. Berrangé wrote:
With the normal format, we can reliably extract each string, but some
chars might have been mangled. How about we keep your current code, but
if we see a "." in a string, then we run "dmidecode -u --oem-string N"
just for that particular string, in
Also note that it's archived, because it's definitely
not maintained anymore.
Signed-off-by: Ján Tomko
---
docs/virshcmdref.html.in | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/docs/virshcmdref.html.in b/docs/virshcmdref.html.in
index
We've had no tarballs for almost 10 years.
Give up and delete the commented out links to them.
Signed-off-by: Ján Tomko
---
docs/csharp.html.in | 13 -
1 file changed, 13 deletions(-)
diff --git a/docs/csharp.html.in b/docs/csharp.html.in
index aee0b75eb8..df1db49bec 100644
---
We still point to git repositories hosted on libvirt.org in various
places. Replace the links to their gitlab.com equivalents.
Note that GitLab is trying to be smart here and
https://gitlab.com/libvirt/libvirt
redirects to
https://gitlab.com/libvirt/libvirt.git
when doing a 'git clone' and
Ján Tomko (3):
docs: csharp: remove outdated comment
docs: virshcmdref: change repo URL to GitLab
docs: point to GitLab as the primary git hosting
ChangeLog| 4 ++--
docs/aclpolkit.html.in | 2 +-
docs/bindings.html.in| 2 +-
docs/csharp.html.in
QEMU added the machine types for the 5.1 release so let's update them.
Other notable changes are 'cpu-throttle-tailslow' migration property,
'zlib' compression for qcow2 images and absrtact socket support.
Signed-off-by: Peter Krempa
---
As usual, I'll be refreshing this until the release so
On Wed, Jun 03, 2020 at 11:29:36AM +0200, Peter Krempa wrote:
> On Wed, Jun 03, 2020 at 11:11:08 +0200, Michal Privoznik wrote:
> > On 6/3/20 10:40 AM, Peter Krempa wrote:
> > > On Wed, Jun 03, 2020 at 10:27:57 +0200, Michal Privoznik wrote:
> > > > On 6/3/20 9:31 AM, Peter Krempa wrote:
> > > > >
On Fri, May 15, 2020 at 04:13:21PM +0100, Daniel P. Berrangé wrote:
> On Fri, May 15, 2020 at 02:34:01PM +0200, Michal Privoznik wrote:
> > On 5/13/20 1:56 PM, Rafael Fonseca wrote:
> > > This patch series convert various simple instances of virObject to a
> > > GObject equivalent.
> >
> > I'm
The variable cleanup introduced a typo.
Signed-off-by: Ján Tomko
Fixes: 08071ec0f113bb1fe8dcc263cb6bf87529e8b76b
Reported-by: Bronek Kozicki
Closes: https://gitlab.com/libvirt/libvirt/-/issues/27
---
Pushed as trivial.
tools/libvirt-guests.sh.in | 2 +-
1 file changed, 1 insertion(+), 1
On Tue, Jun 02, 2020 at 03:11:25PM +0200, Michal Privoznik wrote:
> On 6/2/20 12:56 PM, Daniel P. Berrangé wrote:
> > On Tue, Jun 02, 2020 at 12:53:18PM +0200, Michal Privoznik wrote:
> > > Setting OEM strings for a domain was introduced in
> > > v4.1.0-rc1~315. However, any application that
Until libvirt 2.5.0 we didn't have a real process for release
notes in place, and we just published the list of commits that
had made it into each release, dividing them into categories that
mostly matched the sections we use today. Those documents haven't
been relevant for years, but they're
The ASCII output our scripts produce is already very close to
reStructuredText, and with just a few extra tweaks we can get
almost all of the way there.
Signed-off-by: Andrea Bolognani
---
docs/news-ascii.xsl | 40 +---
scripts/reformat-news.py | 20
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> +++ b/tests/qemuxml2argvtest.c
> @@ -1676,6 +1676,10 @@ mymain(void)
> DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-set-zero",
> QEMU_CAPS_DEVICE_VFIO_PCI,
>
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
> +++ b/tests/qemuxml2argvtest.c
> @@ -1650,6 +1655,12 @@ mymain(void)
> DO_TEST("hostdev-vfio-zpci-autogenerate",
> QEMU_CAPS_DEVICE_VFIO_PCI,
> QEMU_CAPS_DEVICE_ZPCI);
> +
On Wed, 2020-06-03 at 14:44 +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Andrea Bolognani wrote:
> > -Older libvirt releases didn't have proper release notes: if you are
> > interested
> > -in changes between them, you should check out docs/news-\*.html or the
> > full git
> > -log (see
On Wed, 2020-06-03 at 15:33 +0200, Ján Tomko wrote:
> On a Wednesday in 2020, Andrea Bolognani wrote:
> > How about I use '-' instead of '*' everywhere? That will help
> > visually tell apart the symbols used to create the bullet point from
> > those used to make text bold.
>
> - looks nothing
On 6/2/20 5:53 AM, Igor Mammedov wrote:
On Mon, 1 Jun 2020 17:14:20 -0300
Daniel Henrique Barboza wrote:
[...]
An ideal situation would be QEMU to never accept incomplete NUMA topologies
in the first place.
At least with your series I can safely drop deprecated incomplete NUMA
I think that since is kind of a hack, it
doesn't deserve place in the front row.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
There are recommendations and limitations to the name of the
config blobs we need to follow [1].
Firstly, we don't want users to change any value only add new
blobs. This means, that the name must have "opt/" prefix and at
the same time must not begin with "opt/ovmf" nor "opt/org.qemu"
as these
This capability tracks whether QEMU supports -fw_cfg command line
option, more specifically whether it allows specifying filename.
There are some releases of QEMU which support -fw_cfg but not
filename. If this is ever a problem we can refine the capability
later on.
Signed-off-by: Michal
For the case where -fw_cfg uses a file, we need to set the
seclabels on it to allow QEMU the access. While QEMU allows
writing into the file (if specified on the command line), so far
we are enabling reading only and thus we can use read only label
(in case of SELinux).
Signed-off-by: Michal
On Wed, 3 Jun 2020 01:24:43 -0400
Yan Zhao wrote:
> On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote:
> > On Tue, 2 Jun 2020 23:19:48 -0400
> > Yan Zhao wrote:
> >
> > > On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote:
> > > > On Wed, 29 Apr 2020 20:39:50
On Wed, Jun 03, 2020 at 07:01:32PM +0200, Michal Privoznik wrote:
> There was a discussion whether to do this or not:
>
> https://www.redhat.com/archives/libvir-list/2020-May/msg00954.html
>
> Before you start reviewing, naming is hard and I was unable to come up
> with a good element names and
QEMU has -fw_cfg which allows users to tweak how firmware
configures itself and/or provide new configuration blobs.
Introduce new element as a direct child of
that will hold these new blobs.
It's possible to either specify new value as a string or provide
a filename which contents then serve as
There was a discussion whether to do this or not:
https://www.redhat.com/archives/libvir-list/2020-May/msg00954.html
Before you start reviewing, naming is hard and I was unable to come up
with a good element names and place, so suggestions are more than
welcome!
Michal Prívozník (6):
This is pretty straightforward and self explanatory.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1837990
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c| 38 ++
tests/qemuxml2argvdata/fw_cfg.args | 32 +
If virDomainUpdateDeviceFlags() was used to update an , and
the interface type changed from type='network' where the network was
an unmanaged bridge (so actualType == bridge) to type='bridge'
(i.e. actualType *also* == bridge), the update would fail due to the
perceived change in type.
In
On a Tuesday in 2020, Andrea Bolognani wrote:
As the name clearly implies, it's supposed to list the .html.in
files that are generated from .rst files, but it mistakenly lists
the corresponding .html files instead.
Signed-off-by: Andrea Bolognani
---
docs/Makefile.am | 2 +-
1 file changed, 1
On a Tuesday in 2020, Andrea Bolognani wrote:
The primary git repository is the one on GitLab these days.
Signed-off-by: Andrea Bolognani
---
docs/news-html.xsl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Wed, Jun 03, 2020 at 11:22:47AM +0100, Daniel P. Berrangé wrote:
> We need to be able to cast from virObjectEventPtr to one of
> its many subclasses. Some of these subclasses have 8 byte
> alignment on 32-bit platforms, but virObjectEventPtr only
> has 4 byte alignment.
>
> Previously the
On 6/2/20 9:58 PM, Laine Stump wrote:
On 5/28/20 1:09 PM, Jim Fehlig wrote:
Similar to commit 6c17606b7cc, normalize the MAC addresses in persistent
and live device config to avoid a different MAC address for the device
once the VM is rebooted and persistent config takes affect.
Well...
On 6/3/20 5:22 AM, Daniel P. Berrangé wrote:
Forcing 8-byte alignment on virObjectEventPtr removes the
alignment increase during casts to subclasses.
Signed-off-by: Daniel P. Berrangé
---
Technically a build-breaker, but since we don't have any existing
usage of __attribute__((aligned)), I
On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote:
> Prior to 2621d48f005a "gnulib: delete all gnulib integration",
> one could pass ./autogen.sh --no-git to prevent the libvirt build
> system from running git submodule update.
>
> This feature is needed by systems like the Xen Project
On a Wednesday in 2020, Michal Privoznik wrote:
This reverts b897973f2e0.
Please disconnect the period from the commit ID.
(Popular choices include:
* putting a space in there
* removing it completely
* wrapping the commit ID in angle brackets
)
Even though it may have been the case
On a Tuesday in 2020, Andrea Bolognani wrote:
Instead of storing release notes as XML and then converting them
to HTML and ASCII at build time using XSLT and a custom script,
we can use reStructuredText as both the source and ASCII
representation and generate HTML from it using the same tooling
On a Wednesday in 2020, Andrea Bolognani wrote:
On Wed, 2020-06-03 at 14:41 +0200, Ján Tomko wrote:
On a Tuesday in 2020, Andrea Bolognani wrote:
> +v6.4.0 (2020-06-02)
> +===
> +
> +* **New features**
> +
> + - qemu: Add support for pvscsi controllers
You can use an asterisk
On a Wednesday in 2020, Michal Privoznik wrote:
This is convenience macro, use it more. This commit was generated
using the following spatch:
@@
symbol node;
identifier old;
identifier ctxt;
type xmlNodePtr;
@@
- xmlNodePtr old;
+ VIR_XPATH_NODE_AUTORESTORE(ctxt);
...
- old =
Pavel Hrdina writes ("Re: [PATCH] autogen.sh: Restore --no-git (avoid git
submodule update)"):
> To be honest I don't understand why would anyone want to keep track of
> all submodules of all projects for any CI and update it manually every
> time the upstream project changes these submodules.
Pavel Hrdina writes ("Re: [PATCH] autogen.sh: Restore --no-git (avoid git
submodule update)"):
> On Tue, Jun 02, 2020 at 04:47:45PM +0100, Ian Jackson wrote:
> > -git submodule update --init || exit 1
> > +if [ "x$1" = x--no-git ]; then
> > + shift
> > +else
> > + git submodule update --init
On Wed, Jun 3, 2020 at 12:29 PM Daniel P. Berrangé wrote:
>
> We need to be able to cast from virObjectEventPtr to one of
> its many subclasses. Some of these subclasses have 8 byte
> alignment on 32-bit platforms, but virObjectEventPtr only
> has 4 byte alignment.
>
> Previously the virObject
On a Tuesday in 2020, Andrea Bolognani wrote:
Until libvirt 2.5.0 we didn't have a real process for release
notes in place, and we just published the list of commits that
had made it into each release, dividing them into categories that
mostly matched the sections we use today. Those documents
Pavel Hrdina writes ("Re: [PATCH] autogen.sh: Restore --no-git (avoid git
submodule update)"):
> There should not be any need to disable this explicitly unless you want
> to build libvirt with different revisions of submodules.
The Xen Project CI has a cross-tree bisector. It is capable of
On Wed, 2020-06-03 at 14:41 +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Andrea Bolognani wrote:
> > +v6.4.0 (2020-06-02)
> > +===
> > +
> > +* **New features**
> > +
> > + - qemu: Add support for pvscsi controllers
>
> You can use an asterisk for the nested bullet list as
Instead of storing release notes as XML and then converting them
to HTML and ASCII at build time using XSLT and a custom script,
we can use reStructuredText as both the source and ASCII
representation and generate HTML from it using the same tooling
we already use for the rest of the
browse: https://gitlab.com/abologna/libvirt/-/tree/news-convert-cleanup
git fetch: https://gitlab.com/abologna/libvirt.git news-convert-cleanup
Changes since [v1]
* use '*' for all bullet points, regardless of how deep they're
nested;
* patches 1/5 and 2/5 have been pushed.
[v1]
70 matches
Mail list logo
