Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Pino Toscano
On Tuesday, 18 August 2020 09:54:25 CEST Michal Privoznik wrote: > On 8/17/20 5:58 PM, Peter Krempa wrote: > > On Mon, Aug 17, 2020 at 17:40:04 +0200, Michal Privoznik wrote: > >> On 8/17/20 5:16 PM, Peter Krempa wrote: > >>> On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: >

RE: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

2020-08-18 Thread Zang, Rui
> -Original Message- > From: Martin Kletzander > Sent: Monday, August 17, 2020 4:58 PM > To: Zhong, Luyao > Cc: libvir-list@redhat.com; Zang, Rui ; Michal Privoznik > > Subject: Re: [libvirt][RFC PATCH] add a new 'default' option for attribute > mode > in numatune > > On Tue, Aug

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On 2020/8/14 下午1:16, Yan Zhao wrote: On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote:

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Peter Krempa
On Tue, Aug 18, 2020 at 09:54:25 +0200, Michal Privoznik wrote: [...] > As promised yesterday, I've dived into the code and found out that the major > number can be specified as a parameter to the dm module (just tested and it > works). So the next thing I tried was to see how could we check

Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-18 Thread Erik Skultety
On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote: > Reference to `maxQueuedJobs` required us to access > config of the qemu-driver. And creating its copy in > the `qemuDomainJob` helped us access the variable > without referencing the driver's config. > > Signed-off-by: Prathamesh

Re: [PATCH 0/2] virdevmapper: Deal with kernels without DM support

2020-08-18 Thread Christian Ehrhardt
On Mon, Aug 17, 2020 at 4:27 PM Michal Privoznik wrote: > > *** BLURB HERE *** > > Michal Prívozník (2): > virdevmapper: Don't error on kernels without DM support > virdevmapper: Deal with unloading dm module Hi Michal, I know from the discussions on the patches that there likely will be

Re: [PATCH 0/3] Avoid some GCC 10 warnings

2020-08-18 Thread Marc Hartmayer
On Mon, Aug 17, 2020 at 08:22 AM +0200, Erik Skultety wrote: > On Thu, Aug 13, 2020 at 04:03:43PM +0200, Boris Fiuczynski wrote: >> Caught these when switching to F32 using GCC v10.2.1 on s390x. >> >> Boris Fiuczynski (3): >> qemu: avoid maybe-uninitialized warning by GCC 10 >> tools: avoid

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Daniel P . Berrangé
Your mail came through as HTML-only so all the quoting and attribution is mangled / lost now :-( On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > On 2020/8/14

Re: [PATCH] docs: build: Fix links to 'edit this page' for kbase/manpages/internals

2020-08-18 Thread Pavel Hrdina
On Mon, Aug 17, 2020 at 12:18:33PM +0200, Peter Krempa wrote: > Commit 862cf2ace4f04dadc175caacc74448e96c625ccb modified the generator > to base edit links in the root of the repository but forgot to add the > 'docs/' prefix to the code generating kbase articles, manpages and the > internals

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Michal Privoznik
On 8/18/20 10:10 AM, Pino Toscano wrote: What about stat()ing /dev/mapper/control? That should give you the major/minor of that special character device. That won't help. We need to get the major of devmapper targets. For instance, if there is /dev/dm-0 node, it's going to be a block

Re: [GSoC][PATCH v2 4/6] qemu_domain: funciton declarations moved to correct file

2020-08-18 Thread Erik Skultety
On Mon, Aug 17, 2020 at 10:37:19AM +0530, Prathamesh Chavan wrote: > Functions `qemuDomainRemoveInactiveJob` and > `qemuDomainRemoveInactiveJobLocked` had their declaration > misplaced in `qemu_domainjob` and were moved to > `qemu_domain`. > > Signed-off-by: Prathamesh Chavan > --- Reviewed-by:

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 09:55:27 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > Another point, as we discussed in another thread, it's really hard to make > > sure the above API work for all types of devices and frameworks. So having a > > vendor

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Michal Privoznik
On 8/17/20 5:58 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 17:40:04 +0200, Michal Privoznik wrote: On 8/17/20 5:16 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in

Re: [GSoC][PATCH v2 1/6] qemu_domain: Added `qemuDomainJobInfo` to domainJob's `privateData`

2020-08-18 Thread Erik Skultety
On Mon, Aug 17, 2020 at 10:37:16AM +0530, Prathamesh Chavan wrote: > As `qemuDomainJobInfo` had attributes specific to qemu hypervisor's > jobs, we moved the attribute `current` and `completed` from > `qemuDomainJobObj` to its `privateData` structure. > > In this process, two callback functions:

Re: [PATCH 2/2] virdevmapper: Deal with unloading dm module

2020-08-18 Thread Peter Krempa
On Mon, Aug 17, 2020 at 18:02:04 +0200, Andrea Bolognani wrote: > On Mon, 2020-08-17 at 17:28 +0200, Peter Krempa wrote: > > On Mon, Aug 17, 2020 at 16:26:55 +0200, Michal Privoznik wrote: > > > -if ((controlFD = virDMOpen()) < 0) > > > +if ((controlFD = virDMOpen()) < 0) { > > > +

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Daniel P . Berrangé
On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > On 2020/8/14 下午1:16, Yan Zhao wrote: > > On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote: > > > On 2020/8/10 下午3:46, Yan Zhao wrote: > > > > > driver is it handled by? > > > > It looks that the devlink is for network

Re: [GSoC][PATCH v2 5/6] virmigraiton: `qemuMigrationJobPhase` transformed for more generic use

2020-08-18 Thread Erik Skultety
On Mon, Aug 17, 2020 at 10:37:20AM +0530, Prathamesh Chavan wrote: > `qemuMigrationJobPhase` was transformed into `virMigrationJobPhase` > and a common util file `virmigration` was created to store its > defination. > > Signed-off-by: Prathamesh Chavan > --- Like I mentioned in review of v1,

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Daniel P . Berrangé
On Tue, Aug 18, 2020 at 11:06:17AM +0200, Cornelia Huck wrote: > On Tue, 18 Aug 2020 09:55:27 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > Another point, as we discussed in another thread, it's really hard to make > > > sure the above

Re: [PATCH v2 0/2] Deal with kernels without DM support

2020-08-18 Thread Christian Ehrhardt
On Tue, Aug 18, 2020 at 11:36 AM Michal Privoznik wrote: > > v2 of: > > https://www.redhat.com/archives/libvir-list/2020-August/msg00489.html > > diff to v1: > - After discussion to v1 I've decided to not cache DM major number and > thus the patches looks a bit different. > > Michal Prívozník

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 10:16:28 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: > >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > > On 2020/8/14 下午1:16, Yan Zhao wrote: >

Re: [PATCH v2 1/2] virdevmapper: Don't cache device-mapper major

2020-08-18 Thread Peter Krempa
On Tue, Aug 18, 2020 at 11:30:24 +0200, Michal Privoznik wrote: > The device mapper major is needed in virIsDevMapperDevice() which > determines whether given device is managed by device-mapper. This > number is obtained by parsing /proc/devices and then stored in a > global variable so that the

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 10:24:33 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 11:06:17AM +0200, Cornelia Huck wrote: > > On Tue, 18 Aug 2020 09:55:27 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > > Another point, as

Re: [PATCH v2 0/2] Deal with kernels without DM support

2020-08-18 Thread Christian Ehrhardt
On Tue, Aug 18, 2020 at 12:11 PM Christian Ehrhardt wrote: > > On Tue, Aug 18, 2020 at 11:36 AM Michal Privoznik wrote: > > > > v2 of: > > > > https://www.redhat.com/archives/libvir-list/2020-August/msg00489.html > > > > diff to v1: > > - After discussion to v1 I've decided to not cache DM major

[PATCH] numa_conf: Properly check for caches in virDomainNumaDefValidate()

2020-08-18 Thread Michal Privoznik
When adding support for HMAT, in f0611fe8830 I've introduced a check which aims to validate /domain/cpu/numa/interconnects. As a part of that, there is a loop which checks whether all with @cache attribute refer to an existing cache level. For instance:

[PATCH] NEWS: Document recent virdevmapper fix

2020-08-18 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 63ca689b43..b80e72f8c6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v6.7.0 (unreleased) * **Bug fixes** + * virdevmapper: Deal with kernels without

RE: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Parav Pandit
Hi Jason, From: Jason Wang Sent: Tuesday, August 18, 2020 2:32 PM On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On 2020/8/14 下午1:16, Yan Zhao wrote: On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote: On 2020/8/10 下午3:46,

Re: [PATCH] NEWS: Document recent virdevmapper fix

2020-08-18 Thread Andrea Bolognani
On Tue, 2020-08-18 at 13:14 +0200, Michal Privoznik wrote: > + * virdevmapper: Deal with kernels without DM support > + > +In the previous release libvirt dropped libdevmapper in favor of its own > +implementation. However, it forgot to deal with kernels that either don't s/forgot to

Re: [PATCH v2 2/2] virdevmapper: Handle kernel without device-mapper support

2020-08-18 Thread Peter Krempa
On Tue, Aug 18, 2020 at 11:30:25 +0200, Michal Privoznik wrote: > In one of my latest patch (v6.6.0~30) I was trying to remove > libdevmapper use in favor of our own implementation. However, the > code did not take into account that device mapper can be not > compiled into the kernel (e.g. be a

[PATCH v2 0/2] Deal with kernels without DM support

2020-08-18 Thread Michal Privoznik
v2 of: https://www.redhat.com/archives/libvir-list/2020-August/msg00489.html diff to v1: - After discussion to v1 I've decided to not cache DM major number and thus the patches looks a bit different. Michal Prívozník (2): virdevmapper: Don't cache device-mapper major virdevmapper: Handle

[PATCH v2 2/2] virdevmapper: Handle kernel without device-mapper support

2020-08-18 Thread Michal Privoznik
In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in favor of our own implementation. However, the code did not take into account that device mapper can be not compiled into the kernel (e.g. be a separate module that's not loaded) in which case /proc/devices won't have

[PATCH v2 1/2] virdevmapper: Don't cache device-mapper major

2020-08-18 Thread Michal Privoznik
The device mapper major is needed in virIsDevMapperDevice() which determines whether given device is managed by device-mapper. This number is obtained by parsing /proc/devices and then stored in a global variable so that the file doesn't have to be parsed again. However, as it turns out this logic

Re: [GSoC][PATCH v2 6/6] qemu_domainjob: remove dependency on `qemuDomainDiskPrivatePtr`

2020-08-18 Thread Erik Skultety
On Mon, Aug 17, 2020 at 10:37:21AM +0530, Prathamesh Chavan wrote: > Dependency on qemu-specific `diskPrivatePtr` was removed > by moving the funcitons `qemuDomainObjPrivateXMLParseJobNBD` > and `qemuDomainObjPrivateXMLFormatNBDMigration` to > `qemu_domain`, and moving their calls inside > the

RE: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Parav Pandit
Hi Cornelia, > From: Cornelia Huck > Sent: Tuesday, August 18, 2020 3:07 PM > To: Daniel P. Berrangé > Cc: Jason Wang ; Yan Zhao > ; k...@vger.kernel.org; libvir-list@redhat.com; > qemu-de...@nongnu.org; Kirti Wankhede ; > eau...@redhat.com; xin-ran.w...@intel.com; cor...@lwn.net; openstack- >

[PATCH 2/2] qemu: don't needlessly unset close callback during perform phase

2020-08-18 Thread Nikolay Shirokovskiy
During API call connection is referenced and close callback is called when connection is disposed. Thus during API call close callback cannot be triggered and we don't need to unset callback on API call duration. This code was added in [1] and commit does not explain this part of the patch. [1]

[PATCH 0/2] qemu: migration corner case fix and cleanup

2020-08-18 Thread Nikolay Shirokovskiy
Nikolay Shirokovskiy (2): qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish qemu: don't needlessly unset close callback during perform phase src/qemu/qemu_migration.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) -- 1.8.3.1

[PATCH 1/2] qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish

2020-08-18 Thread Nikolay Shirokovskiy
qemuMigrationSrcCleanup uses qemuDomainObjDiscardAsyncJob currently. But discard does not reduce jobs_queued counter so it leaks. Also discard does not notify other threads that job condition is available. Discard does reset nested job but nested job is not possible in this conditions.

Re: [PATCH] doCoreDump: fix return value not expect as result

2020-08-18 Thread Erik Skultety
On Sat, Aug 08, 2020 at 04:19:58PM +0800, Hao Wang wrote: > From: Hao Wang > Subject: [PATCH] doCoreDump: fix return value not expect as result > > In a case that qemuDumpToFd() return zero while VIR_CLOSE(fd) fails, > codes will go to "cleanup" with "ret=0", resulting in unexpected return >

Re: [libvirt PATCH 16/16] virsh: add "nodedev-start" command

2020-08-18 Thread Erik Skultety
On Thu, Jul 16, 2020 at 05:21:46PM -0500, Jonathon Jongsma wrote: > This virsh command maps to virNodeDeviceCreate(), which starts a node > device that has been previously defined by virNodeDeviceDefineXML(). > This is only supported for mediated devices. > > Signed-off-by: Jonathon Jongsma > ---

Re: [libvirt PATCH 0/2] meson augeas test fixes

2020-08-18 Thread Michal Privoznik
On 8/18/20 3:44 PM, Pavel Hrdina wrote: Pavel Hrdina (2): src/meson: introduce srcdir and builddir into augeas_test_data dictionary meson/src: add missing augeas tests src/bhyve/meson.build | 3 +++ src/libxl/meson.build | 3 +++ src/locking/meson.build | 9 +++

[libvirt PATCH 2/2] meson/src: add missing augeas tests

2020-08-18 Thread Pavel Hrdina
Most of our augeas files are generated during meson setup into build directory and we were running augeas tests only for these files. However, we have some other augeas and config files that are not modified during meson setup and they are only in source directories. In order to run tests for

[libvirt PATCH 0/2] meson augeas test fixes

2020-08-18 Thread Pavel Hrdina
Pavel Hrdina (2): src/meson: introduce srcdir and builddir into augeas_test_data dictionary meson/src: add missing augeas tests src/bhyve/meson.build | 3 +++ src/libxl/meson.build | 3 +++ src/locking/meson.build | 9 +++ src/logging/meson.build | 3 +++ src/lxc/meson.build

[libvirt PATCH 1/2] src/meson: introduce srcdir and builddir into augeas_test_data dictionary

2020-08-18 Thread Pavel Hrdina
This will be used later to specify different include directories for augparse binary to run augeas tests. Signed-off-by: Pavel Hrdina --- src/meson.build | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/meson.build b/src/meson.build index

[libvirt PATCH v2 08/16] nodedev: handle mdevs that disappear from mdevctl

2020-08-18 Thread Jonathon Jongsma
mdevctl does not currently provide any events when the list of defined devices changes, so we will need to poll mdevctl for the list of defined devices periodically. When a mediated device no longer exists from one iteration to the next, we need to treat it as an "undefine" event. When we get

[libvirt PATCH v2 05/16] nodedev: add ability to list and parse defined mdevs

2020-08-18 Thread Jonathon Jongsma
This adds some internal API to query for persistent mediated devices that are defined by mdevctl. Following commits will make use of this information. This just provides the infrastructure and tests for this feature. One test verifies that we are executing mdevctl with the proper arguments, and

[libvirt PATCH v2 04/16] virsh: Add --active, --inactive, --all to nodedev-list

2020-08-18 Thread Jonathon Jongsma
Now that we can filter active and inactive node devices in virConnectListAllNodeDevices(), add these switches to the virsh command. Eventual output (once everything is hooked up): virsh # nodedev-list --inactive --cap mdev mdev_07d8b8b0_7e04_4c0f_97ed_9214ce12723c

Re: [libvirt PATCH 2/2] meson/src: add missing augeas tests

2020-08-18 Thread Pavel Hrdina
It should be src/meson in the subject, fixed in my local branch. Pavel signature.asc Description: PGP signature

Re: [PATCH v2 01/17] virfdstream: Use g_autofree in virFDStreamThreadDoRead()

2020-08-18 Thread Peter Krempa
On Tue, Jul 07, 2020 at 21:46:19 +0200, Michal Privoznik wrote: > The buffer that allocated in the virFDStreamThreadDoRead() can be > automatically freed, or if saved into the message structure it > can be stolen. > > Signed-off-by: Michal Privoznik > --- > src/util/virfdstream.c | 6 ++ >

[libvirt PATCH v2 12/16] api: add virNodeDeviceUndefine()

2020-08-18 Thread Jonathon Jongsma
This interface allows you to undefine a persistently defined (but inactive) mediated devices. It is implemented via 'mdevctl' Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h | 2 + src/driver-nodedev.h | 4 ++ src/libvirt-nodedev.c

[libvirt PATCH v2 01/16] tests: remove extra trailing semicolon

2020-08-18 Thread Jonathon Jongsma
The macro should not have a trailing semicolon so that when the macro is used, the user can add a semicolon themselves. Signed-off-by: Jonathon Jongsma --- tests/nodedevmdevctltest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/nodedevmdevctltest.c

[libvirt PATCH v2 00/16] Add support for persistent mediated devices

2020-08-18 Thread Jonathon Jongsma
This patch series follows the previously-merged series which added support for transient mediated devices. This series expands mdev support to include persistent device definitions. Again, it relies on mdevctl as the backend. It follows the common libvirt pattern of APIs by adding the following

[libvirt PATCH v2 14/16] virsh: add nodedev-undefine command

2020-08-18 Thread Jonathon Jongsma
Add a virsh command that maps to virNodeDeviceUndefine(). Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 34203c0e91..db56fbc5e9 100644

[libvirt PATCH v2 10/16] api: add virNodeDeviceDefineXML()

2020-08-18 Thread Jonathon Jongsma
With mediated devices, we can now define persistent node devices that can be started and stopped. In order to take advantage of this, we need an API to define new node devices. Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h | 4 + src/driver-nodedev.h

[libvirt PATCH v2 06/16] nodedev: add STOPPED/STARTED lifecycle events

2020-08-18 Thread Jonathon Jongsma
Since a mediated device can be persistently defined by the mdevctl backend, we need additional lifecycle events beyond CREATED/DELETED to indicate that e.g. the device has been stopped but the device definition still exists. Signed-off-by: Jonathon Jongsma --- examples/c/misc/event-test.c

[libvirt PATCH v2 15/16] api: add virNodeDeviceCreate()

2020-08-18 Thread Jonathon Jongsma
This new API function provides a way to start a persistently-defined mediate device that was defined by virNodeDeviceDefineXML() (or one that was defined externally via mdevctl) Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h| 2 + src/driver-nodedev.h

[libvirt PATCH v2 02/16] nodedev: introduce concept of 'active' node devices

2020-08-18 Thread Jonathon Jongsma
we will be able to define mediated devices that can be started or stopped, so we need to be able to indicate whether the device is active or not, similar to other resources (storage pools, domains, etc.) Signed-off-by: Jonathon Jongsma --- src/conf/virnodedeviceobj.c| 14 ++

[libvirt PATCH v2 03/16] nodedev: Add ability to filter by active state

2020-08-18 Thread Jonathon Jongsma
Add two flag values for virConnectListAllNodeDevices() so that we can list only node devices that are active or inactive. Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h| 9 ++--- src/conf/node_device_conf.h | 8 src/conf/virnodedeviceobj.c

[libvirt PATCH v2 07/16] nodedev: add mdevctl devices to node device list

2020-08-18 Thread Jonathon Jongsma
At startup, query devices that are defined by 'mdevctl' and add them to the node device list. This adds a complication: we now have two potential sources of information for a node device: - udev for all devices and for activated mediated devices - mdevctl for persistent mediated devices

[libvirt PATCH v2 09/16] nodedev: add an mdevctl thread

2020-08-18 Thread Jonathon Jongsma
We need to peridocally query mdevctl for changes to device definitions since an administrator can define new devices with mdevctl outside of libvirt. In order to do this, a new thread is created to handle the querying. In the future, mdevctl may add a way to signal device add / remove via events,

[libvirt PATCH v2 16/16] virsh: add "nodedev-start" command

2020-08-18 Thread Jonathon Jongsma
This virsh command maps to virNodeDeviceCreate(), which starts a node device that has been previously defined by virNodeDeviceDefineXML(). This is only supported for mediated devices. Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 61 +++ 1

[libvirt PATCH v2 13/16] virsh: Factor out function to find node device

2020-08-18 Thread Jonathon Jongsma
Several functions accept providing a node device by name or by wwnn,wwpn pair. Extract the logic to do this into a function that can be used by both callers. Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 58 +-- 1 file changed, 28

[libvirt PATCH v2 11/16] virsh: add nodedev-define command

2020-08-18 Thread Jonathon Jongsma
Add a virsh command that maps to virNodeDeviceDefineXML(). Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index f078ce6516..45d6c7b493 100644

[libvirt PATCH 1/2] meson: Fix indentation

2020-08-18 Thread Andrea Bolognani
We use two spaces everywhere else. This commit is best viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- meson.build | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/meson.build b/meson.build index 0913308bec..18259973b8 100644 ---

[libvirt PATCH 0/2] meson: Small style fixes

2020-08-18 Thread Andrea Bolognani
All pushed as trivial. Andrea Bolognani (2): meson: Fix indentation meson: Don't use spaces after parentheses meson.build | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) -- 2.26.2

Re: qemu modularization of qemu-5.1 vs libvirt domcapabilities cache?

2020-08-18 Thread Jim Fehlig
On 8/5/20 2:19 AM, Andrea Bolognani wrote: On Wed, 2020-08-05 at 02:09 -0400, Mark Mielke wrote: Hi all: In testing qemu-5.1rc2 on my Fedora 32 home system, I found that the Fedora rawhide package has broken out both the QXL display device and the USB redirect device into separate RPM modules:

[libvirt PATCH] meson: Fix typo supprt -> support

2020-08-18 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- Pushed as trivial. meson_options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson_options.txt b/meson_options.txt index 1d19094e2e..c538d323c1 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -36,7 +36,7 @@

Re: [PATCH V2 0/3] Xen: Add support for qemu commandline passthrough

2020-08-18 Thread Jim Fehlig
Hi All, Any comments on V2 of this series? (Thanks Jano for reviewing V1!) Regards, Jim On 8/4/20 4:13 PM, Jim Fehlig wrote: V2 of https://www.redhat.com/archives/libvir-list/2020-July/msg02043.html Changes in V2: - Drop use of virStringListCopy, and hence patch 1/4 - Switch to using 'xen'

[libvirt PATCH 2/2] meson: Don't use spaces after parentheses

2020-08-18 Thread Andrea Bolognani
We don't do that anywhere else. Signed-off-by: Andrea Bolognani --- meson.build | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index 18259973b8..a72d0c0e85 100644 --- a/meson.build +++ b/meson.build @@ -1753,11 +1753,11 @@ if not

Re: [PATCH] numa_conf: Properly check for caches in virDomainNumaDefValidate()

2020-08-18 Thread Laine Stump
On 8/18/20 6:55 AM, Michal Privoznik wrote: When adding support for HMAT, in f0611fe8830 I've introduced a check which aims to validate /domain/cpu/numa/interconnects. As a part of that, there is a loop which checks whether all with @cache attribute refer to an existing cache level. For

[libvirt PATCH] RFC: Add support for vDPA network devices

2020-08-18 Thread Jonathon Jongsma
vDPA network devices allow high-performance networking in a virtual machine by providing a wire-speed data path. These devices require a vendor-specific host driver but the data path follows the virtio specification. The support for vDPA devices was recently added to qemu. This allows libvirt to

[libvirt PATCH] meson: Fix typo backand -> backend

2020-08-18 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- Pushed as trivial. meson_options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson_options.txt b/meson_options.txt index 1313effd09..1d19094e2e 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -74,7 +74,7 @@

Re: libvirt 6.6.0 tarball breaks on Homebrew/MacOS

2020-08-18 Thread Daniel P . Berrangé
On Tue, Aug 18, 2020 at 11:25:19AM -0700, Scott Shambarger wrote: > The latest release at https://libvirt.org/sources/libvirt-6.6.0.tar.xz > includes a configure script that breaks Homebrew (and other builds on > MacOS/Darwin). The breaking change is related to a new version of the file >

libvirt 6.6.0 tarball breaks on Homebrew/MacOS

2020-08-18 Thread Scott Shambarger
The latest release at https://libvirt.org/sources/libvirt-6.6.0.tar.xz includes a configure script that breaks Homebrew (and other builds on MacOS/Darwin). The breaking change is related to a new version of the file m4/libtool.m4; line 2648 was changed to: shrext_cmds='`test .$module =

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:36, Cornelia Huck wrote: On Tue, 18 Aug 2020 10:16:28 +0100 Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:32, Parav Pandit wrote: Hi Jason, From: Jason Wang Sent: Tuesday, August 18, 2020 2:32 PM On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On 2020/8/14 下午1:16, Yan Zhao wrote: On Thu, Aug 13, 2020 at 12:24:50PM

Re: [GSoC][PATCH v2 6/6] qemu_domainjob: remove dependency on `qemuDomainDiskPrivatePtr`

2020-08-18 Thread Prathamesh Chavan
On Tue, Aug 18, 2020 at 3:13 PM Erik Skultety wrote: > > On Mon, Aug 17, 2020 at 10:37:21AM +0530, Prathamesh Chavan wrote: > > Dependency on qemu-specific `diskPrivatePtr` was removed > > by moving the funcitons `qemuDomainObjPrivateXMLParseJobNBD` > > and

[libvirt PATCH 2/2] meson: Don't hardcode /etc in APPARMOR_DIR

2020-08-18 Thread Andrea Bolognani
src/security/apparmor/meson.build builds this path dynamically based on the value of sysconfdir, so we should do the same here or the code and the filesystem might end up disagreeing. Signed-off-by: Andrea Bolognani --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[libvirt PATCH 0/2] meson: AppArmor fixes

2020-08-18 Thread Andrea Bolognani
Found while updating the Debian package for libvirt to a snapshot taken from master. Possibly more to come. Andrea Bolognani (2): meson: Set WITH_APPARMOR_PROFILES meson: Don't hardcode /etc in APPARMOR_DIR meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.26.2

[libvirt PATCH 1/2] meson: Set WITH_APPARMOR_PROFILES

2020-08-18 Thread Andrea Bolognani
This variable is used in src/security/meson.build to decide whether to install the AppArmor profiles, and at the moment even when the user specifies -Dapparmor_profiles=true they don't get installed. Signed-off-by: Andrea Bolognani --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:16, Daniel P. Berrangé wrote: Your mail came through as HTML-only so all the quoting and attribution is mangled / lost now :-( My bad, sorry. On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Yan Zhao
On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote: > Hi Cornelia, > > > From: Cornelia Huck > > Sent: Tuesday, August 18, 2020 3:07 PM > > To: Daniel P. Berrangé > > Cc: Jason Wang ; Yan Zhao > > ; k...@vger.kernel.org; libvir-list@redhat.com; > > qemu-de...@nongnu.org; Kirti

RE: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Parav Pandit
> From: Yan Zhao > Sent: Wednesday, August 19, 2020 9:01 AM > On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote: > > Please refer to my previous email which has more example and details. > hi Parav, > the example is based on a new vdpa tool running over netlink, not based on >

RE: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, August 19, 2020 8:16 AM > On 2020/8/18 下午5:32, Parav Pandit wrote: > > Hi Jason, > > > > From: Jason Wang > > Sent: Tuesday, August 18, 2020 2:32 PM > > > > > > On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > On Tue, Aug 18, 2020 at 11:24:30AM +0800,