Sorry, looks like I'm compiling with debug options and missed this error.
It was a deliberate change but compiler don't like it.
The build fix is pushed.
Nikolay
On Wed, Jan 6, 2021 at 5:44 PM Daniel P. Berrangé
wrote:
> On Fri, Dec 18, 2020 at 09:56:47AM +0300, Nikolay Shirokovskiy wrote:
>
On a Wednesday in 2021, Peter Krempa wrote:
New libxml2 handles '\n' properly so the literal newline is not
necessary.
, because 2.9.1 is the minimum version we support.
Signed-off-by: Peter Krempa
---
docs/schemas/domaincommon.rng | 8 ++--
docs/schemas/storagecommon.rng | 4 +---
2
On a Wednesday in 2021, Peter Krempa wrote:
Objects such as domain, pool, etc re-define the regex for the format.
Add more generic types for objects with/without a slash which we'll be
able to reuse also for other objects.
Signed-off-by: Peter Krempa
---
docs/schemas/basictypes.rng| 13
The 'fulong2e' machine alias has been marked as deprecated since
QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e').
Time to remove it now.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/system/deprecated.rst | 5 -
docs/system/removed-features.rst | 5 +
Signed-off-by: Ryan Gahagan
---
src/util/virstoragefile.c | 8
src/util/virstoragefile.h | 8
2 files changed, 16 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 1176630282..3097e11984 100644
--- a/src/util/virstoragefile.c
+++
Signed-off-by: Ryan Gahagan
---
docs/formatdomain.rst | 24 ++--
docs/schemas/domaincommon.rng | 32
2 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index
Signed-off-by: Ryan Gahagan
---
src/conf/domain_conf.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 453e06491e..96ee009058 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6888,6
Signed-off-by: Ryan Gahagan
---
src/qemu/qemu_block.c | 67 +++-
src/qemu/qemu_domain.c | 70 ++
2 files changed, 136 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index
Per Issue 90[1], QEMU supports using an NFS disk but Libvirt had no
support for attaching a disk of this type. This patch series adds in
this capability as well as the tests necessary to make sure it works
correctly.
The changes in this second version over the previous patch series for
this issue
Signed-off-by: Ryan Gahagan
---
src/util/virstoragefile.c | 49 +++
tests/virstoragetest.c| 13 +++
2 files changed, 62 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 3097e11984..d67f0f2c3f 100644
---
Signed-off-by: Ryan Gahagan
---
src/libxl/libxl_conf.c| 1 +
src/libxl/xen_xl.c| 1 +
src/qemu/qemu_block.c | 3 +++
src/qemu/qemu_command.c | 1 +
src/qemu/qemu_domain.c| 2 ++
src/qemu/qemu_snapshot.c | 3 +++
src/util/virstoragefile.c | 6 ++
Signed-off-by: Ryan Gahagan
---
.../disk-network-nfs.x86_64-latest.args | 56 +++
tests/qemuxml2argvdata/disk-network-nfs.xml | 48
tests/qemuxml2argvtest.c | 1 +
...isk-network-nfs-inactive.x86_64-latest.xml | 54 ++
On a Wednesday in 2021, Peter Krempa wrote:
There's plenty of existing documentation [1] which shows as example a
name which contains a space and a dot ('client.admin secret') as ceph
usage name.
Use a more relaxed type in the RNG schema since the usage name is
actually just a string used to
On a Wednesday in 2021, Peter Krempa wrote:
Patches 1-6 are mostly cleanups noticed while looking at the schema.
See patch 7/7 for explanation.
Peter Krempa (7):
virSecretDefParseUsage: Use g_autofree for type_str
secretXMLParseNode: Clean up freeing of memory
virSecretLookupParseSecret:
Am Wed, 6 Jan 2021 19:46:02 +0100
schrieb Philippe Mathieu-Daudé :
> The 'fulong2e' machine alias has been marked as deprecated since
> QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e').
> Time to remove it now.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On Tue, Jan 5, 2021 at 11:50 AM Yan Fu wrote:
> Tested with v6.10.0-283-g1948d4e61e.
>
> 1.Can define/start/destroy mdev device successfully;
>
> 2.'virsh nodedev-list' has no '--active' option, which is inconsistent
> with the description in the patch：
> # virsh nodedev-list --active
> error:
Reviewed-by: Huacai Chen
On Thu, Jan 7, 2021 at 2:46 AM Philippe Mathieu-Daudé wrote:
>
> The 'fulong2e' machine alias has been marked as deprecated since
> QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e').
> Time to remove it now.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
The two scenarios were found by Coverity after a seemingly-unrelated
change to virLXCProcessSetupInterfaceTap() (in commit ecfc2d5f43), and
explained by John Ferlan here:
https://www.redhat.com/archives/libvir-list/2020-December/msg00810.html
To re-explain:
a) On entry to
On 12/18/20 10:45 PM, Shi Lei wrote:
On 2020-12-18 at 22:01, John Ferlan wrote:
Coverity reminds us of the ancient software engineering proverb related
to being stuck with ownership because you touched the code last :-) - I
know this patch didn't cause the problem, but because the code was
Hi Michal
> On Jan 6, 2021, at 19:45, Michal Privoznik wrote:
>
> On 1/4/21 3:31 AM, Eiichi Tsukata wrote:
>> Currently, swtpm TPM state file is removed when a transient domain is
>> powered off or undefined. When we store TPM state on a shared storage
>> such as NFS and use transient domain,
In all cases *except* when parsing status XML as libvirt is being
restarted, the XML parser will delete any manually specified interface
name (aka "" aka net->ifname) that could have been
generated by virNetDevGenerateName(). This means that during the setup
when a domain is being started (e.g.
Laine Stump (2):
lxc: remove unnecessary call to virNetDevReserveName()
lxc: eliminate leaked and dangling pointers in
virLXCProcessSetupInterfaceTap
src/lxc/lxc_process.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
--
2.29.2
On 2021-01-06 at 18:21, Michal Privoznik wrote:
>On 1/6/21 3:40 AM, Shi Lei wrote:
>> Extract common code as helper function virNetlinkTalk, then simplify
>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/util/virnetlink.c | 225
On 2021-01-07 at 10:52, Shi Lei wrote:
>On 2021-01-06 at 18:21, Michal Privoznik wrote:
>>On 1/6/21 3:40 AM, Shi Lei wrote:
>>> Extract common code as helper function virNetlinkTalk, then simplify
>>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>>
>>> - default:
>>> -
virDeviceHasPCIExpressLink() wasn't checking that pcie_cap_pos was
valid before attempting to use it, which could lead to reading the
byte at offset 0+PCI_CAP_ID_EXP instead of [valid
offset]+PCI_CAP_ID_EXP. In particular, this could happen for
"integrated" PCI devices (those that are on the PCIe
Hi Jiri,
On 2021/1/7 2:11, Jiri Denemark wrote:
> On Tue, Jan 05, 2021 at 21:54:05 +0800, Keqian Zhu wrote:
>> On 2021/1/5 21:34, Daniel P. Berrangé wrote:
>>> On Tue, Jan 05, 2021 at 09:28:27PM +0800, Keqian Zhu wrote:
>> The purpose of QEMU commit 65ace0604551 (migration: add postcopy total
On Wed, Jan 06, 2021 at 00:07:42 +0100, Jiri Denemark wrote:
> The kernel refuses to set guest TSC frequency less than a minimum
> frequency or greater than maximum frequency (both computed based on the
> host TSC frequency). When writing the libvirt code with a reversed logic
> (return success
On Mon, Jan 04, 2021 at 15:49:07 -0600, Ryan Gahagan wrote:
> On Mon, Jan 4, 2021 at 8:24 AM Peter Krempa wrote:
>
> > On Tue, Dec 29, 2020 at 15:21:25 -0600, Ryan Gahagan wrote:
> > > +
> > > +
> > > +
> > > +
> > > +
> > > +nfs
> > > +
> > >
On Mon, Jan 04, 2021 at 17:14:54 -0600, Ryan Gahagan wrote:
> On Mon, Jan 4, 2021 at 8:41 AM Peter Krempa wrote:
>
> > On Tue, Dec 29, 2020 at 15:21:28 -0600, Ryan Gahagan wrote:
> > > +src->nfs_uid = (uid_t) uidStore;
> > > +src->nfs_gid = (gid_t) gidStore;
> >
> > This function must
On Tue, Jan 05, 2021 at 05:18:13PM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> This is something I've been giving a thought after working in Gitlab issue
> #72 and decided to run through the ML before hitting the code.
>
> We don't have an easy way to retrieve the domain that is using an
On Wed, Jan 06, 2021 at 10:47:23AM +0100, Tim Wiederhake wrote:
> Changes to a virtio network device such as
>
>
>
> ...
>
> were quietly dismissed by `virsh update-device ... --live`.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/qemu/qemu_hotplug.c | 10 ++
> 1
On Fri, Dec 18, 2020 at 09:56:47AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/qemu/qemu_migration.c
On 1/5/21 11:40 PM, Shi Lei wrote:
V1 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00836.html
Since V1:
- Minor fixes for reporting system error in Patch 4.
Shi Lei (4):
netlink: Remove invalid flags(NLM_F_CREATE and NLM_F_EXCL) for RTM_DELLINK
netlink:
Changes to a virtio network device such as
...
were quietly dismissed by `virsh update-device ... --live`.
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_hotplug.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c
As of commits 3b1244bffdb and 4770a96c662 renaming of the domain works
also with checkpoints and snapshots. Update the docs.
https://bugzilla.redhat.com/show_bug.cgi?id=1913138
Signed-off-by: Peter Krempa
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This series adds and enables the Snowridge CPU model.
Note that qemu currently uses the same model ID for Icelake-Server [1]
and Snowridge [2]. The correct ID for Icelake is 106 [3], a mistake
that has been fixed in libvirt already [4], but is still missing in
qemu [5].
[1]
Signed-off-by: Tim Wiederhake
---
...64-cpuid-Atom-P5362-processor-disabled.xml |8 +
..._64-cpuid-Atom-P5362-processor-enabled.xml | 10 +
.../x86_64-cpuid-Atom-P5362-processor.json| 2415 +
.../x86_64-cpuid-Atom-P5362-processor.xml | 61 +
4 files changed, 2494
Signed-off-by: Tim Wiederhake
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/x86_Snowridge.xml | 71 +++
.../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 +
Signed-off-by: Tim Wiederhake
---
src/cpu_map/x86_features.xml | 3 +++
tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 +
tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml | 1 +
3 files changed, 5 insertions(+)
diff --git
Signed-off-by: Tim Wiederhake
---
tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml
b/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml
index
Signed-off-by: Tim Wiederhake
---
.../cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml
Signed-off-by: Tim Wiederhake
---
src/cpu_map/x86_features.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
index b0bf22d916..a5a987deba 100644
--- a/src/cpu_map/x86_features.xml
+++ b/src/cpu_map/x86_features.xml
@@ -357,6
Signed-off-by: Tim Wiederhake
---
src/cpu_map/x86_features.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
index a5a987deba..4836595a8c 100644
--- a/src/cpu_map/x86_features.xml
+++ b/src/cpu_map/x86_features.xml
@@ -581,4
On Thu, Dec 24, 2020 at 08:14:31AM -0600, Jonathon Jongsma wrote:
> At startup, query devices that are defined by 'mdevctl' and add them to
> the node device list.
>
> This adds a complication: we now have two potential sources of
> information for a node device:
> - udev for all devices and for
On 1/6/21 7:09 AM, Daniel P. Berrangé wrote:
On Tue, Jan 05, 2021 at 05:18:13PM -0300, Daniel Henrique Barboza wrote:
Hi,
This is something I've been giving a thought after working in Gitlab issue
#72 and decided to run through the ML before hitting the code.
We don't have an easy way to
On Thu, Dec 24, 2020 at 08:14:33AM -0600, Jonathon Jongsma wrote:
> mdevctl does not currently provide any events when the list of defined
> devices changes, so we will need to poll mdevctl for the list of defined
> devices periodically. When a mediated device no longer exists from one
> iteration
On 12/9/20 11:26 AM, Michal Privoznik wrote:
>
Polite ping.
Michal
On 12/4/20 2:11 PM, Michal Privoznik wrote:
>
Polite ping.
Michal
The last user was removed by commit
<40f0e0348dfc84f28a500e262c4953b0d3b44fa0>.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms| 1 -
src/util/virstorageencryption.c | 34 -
src/util/virstorageencryption.h | 2 --
3
The only reason why virstoragefile.h needs to be included in virfile.h
is that virFileNBDDeviceAssociate() takes virStorageFileFormat argument.
The function doesn't need the enum value as it converts the value to
string and uses only that.
Change the argument to string which will allow us to
Function virQEMUBuildQemuImgKeySecretOpts is not used anywhere else
so there is no need to have it in util.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 1 -
src/storage/storage_util.c | 74 --
src/util/virqemu.c
It is not used anywhere else.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/storage_conf.c | 23 ++-
src/util/virstoragefile.c | 24
src/util/virstoragefile.h | 2 --
3 files changed, 22 insertions(+), 27 deletions(-)
diff
The last usage outside of tests was removed by commit
<780f8c94ca8b3dee7eb59c1bfbc32f672f965df8>.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 1 -
src/util/virstoragefile.c | 33 -
src/util/virstoragefile.h | 3 ---
The function doesn't take virStorageSource as argument and has nothing
in common with virStorageSource or storage file.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms| 1 -
src/locking/lock_driver_lockd.c | 68 -
All these headers are indirectly included provided by virfile.h having
virstoragefile.h which will be removed in the following patch.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/driver.c | 1 +
src/qemu/qemu_interop_config.c | 1 +
src/qemu/qemu_shim.c
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 2 +-
src/storage/storage_util.c | 2 +-
src/util/virfile.c | 47 ++
src/util/virfile.h | 4
src/util/virstoragefile.c | 47
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_migration.c | 2 +-
src/util/virfile.c| 13 +
src/util/virfile.h| 1 +
src/util/virstoragefile.c | 11 ---
src/util/virstoragefile.h | 1 -
6 files
This series is pushed, posting only to track the changes to fix the
issues pointed out by Peter.
Pavel Hrdina (9):
util: remove unused virStorageGenerateQcowPassphrase
virstoragefile: remove unused virStorageFileChainCheckBroken
util: move virQEMUBuildQemuImgKeySecretOpts into storage
On Fri, Dec 18, 2020 at 09:56:48AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise we can get misleading error messages. One example is when connection
> is broken we got "this function is not supported by the connection driver:
> virDomainMigrate3" from virDomainMigrate3.
>
> Signed-off-by:
On a Wednesday in 2021, Michal Privoznik wrote:
Tested with the following change:
diff --git a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
index f6bb663e97..875e2316a0 100644
--- a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
On Thu, Dec 24, 2020 at 08:14:34AM -0600, Jonathon Jongsma wrote:
> The udev thread handles received udev events. This is accomplished by
> setting dataReady to 'true' and signalling the thread.
>
> We also want to use this thread to handle mdev events, so we'll need to
> add another variable to
On Thu, Dec 24, 2020 at 08:14:35AM -0600, Jonathon Jongsma wrote:
> We need to periodically query mdevctl for changes to device definitions
> since an administrator can define new devices with mdevctl outside of
> libvirt.
>
> In the future, mdevctl may add a way to signal device add/remove via
>
On Wed, Dec 09, 2020 at 11:26:52AM +0100, Michal Privoznik wrote:
> Some secdrivers (typically SELinux driver) generate unique
> dynamic seclabel for each domain (unless a static one is
> requested in domain XML). This is achieved by calling
> qemuSecurityGenLabel() from qemuProcessPrepareDomain()
On Fri, Dec 18, 2020 at 09:56:45AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/libvirt-domain.c | 511
On Fri, Dec 18, 2020 at 09:56:46AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
>
On Wed, Jan 6, 2021 at 6:00 PM Peter Krempa wrote:
> As of commits 3b1244bffdb and 4770a96c662 renaming of the domain works
> also with checkpoints and snapshots. Update the docs.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1913138
>
> Signed-off-by: Peter Krempa
> ---
>
On Fri, Dec 04, 2020 at 02:11:24PM +0100, Michal Privoznik wrote:
> When an interface has some bandwidth limitation set (it's root
> qdisc is htb in that case) but this gets cleared out via public
> API call (virDomainSetInterfaceParameters() or
> virDomainUpdateDeviceFlags()) then
This allows simplification of the caller as well as will enable a later
refactor of qemuMonitorJSONMakeCommandInternal.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 9 +++--
src/qemu/qemu_monitor.c | 11 +++
src/qemu/qemu_monitor.h | 2 +-
On 1/4/21 3:31 AM, Eiichi Tsukata wrote:
Currently, swtpm TPM state file is removed when a transient domain is
powered off or undefined. When we store TPM state on a shared storage
such as NFS and use transient domain, TPM states should be kept as it is.
Add per-TPM emulator option
Now that individual child elements allow their children to be
interleaved, let's allow direct children of to be
interleaved too.
Signed-off-by: Michal Privoznik
---
docs/schemas/domaincommon.rng | 346 +-
1 file changed, 174 insertions(+), 172 deletions(-)
diff
The element of can have children elements
( and ). Allow them to be interleaved.
Signed-off-by: Michal Privoznik
---
docs/schemas/domaincommon.rng | 54 ++-
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/docs/schemas/domaincommon.rng
virJSONValueObjectRemoveKey can be used as direct replacement. Fix the
one caller and remove the duplicate function.
Signed-off-by: Peter Krempa
---
src/util/virjson.c | 29 -
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/src/util/virjson.c
Check once before looping through the args.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index d2712e0dce..662d0d5df6 100644
---
This allows simplification of the callers.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 13 -
src/qemu/qemu_monitor.c | 11 +++
src/qemu/qemu_monitor.h | 2 +-
src/qemu/qemu_monitor_json.c | 5 ++---
src/qemu/qemu_monitor_json.h
We create a new 'vm' so we must also fake the nodeset.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 662d0d5df6..8b2df07448 100644
--- a/tests/qemuxml2argvtest.c
+++
Use automatic memory freeing and remove the 'cleanup' label and 'ret'
variable.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
This is a resend of the patches from:
https://www.redhat.com/archives/libvir-list/2020-November/msg01625.html
which can be justified without the rest of the series. This series
cleans up some monitor code and few related bits to testing.
The reset of the series will be posted once there's
Remove freeing/clearing of @props as the function doesn't guarantee that
it happens on success, rename the variable hodling copy of the alias and
use g_autofree to automatically free it and remove the cleanup label as
well as 'ret' variable.
Signed-off-by: Peter Krempa
---
The monitor code uses 'flags' for the flags of the monitor builder,
while in this function it's a different set of flags. All callers pass a
variable named 'cdevflags', so rename the argument to suit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 10 +-
1 file changed, 5
Prepare for a refactor of qemuMonitorJSONMakeCommandInternal.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 3 +--
src/qemu/qemu_monitor_json.c | 5 +++--
src/qemu/qemu_monitor_json.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor.c
All callers of qemuMonitorJSONMakeCommandInternal will benefit from
making @arguments a double pointer and passing it to
virJSONValueObjectCreate directly which will clear it if it steals the
value.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 32
Use automatic memory freeing to remove the 'cleanup:' label and 'ret'
variable.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
The callers of qemuMonitorAddObject rely on the fact that @alias is
filled only when the object is added successfully. This is documented
but the code didn't behave like that.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
On Mon, Jan 04, 2021 at 04:30:03PM +0100, Peter Krempa wrote:
> On Mon, Dec 14, 2020 at 16:55:24 +0100, Pavel Hrdina wrote:
> > The function doesn't take virStorageSource as argument and has nothing
> > in common with virStorageSource or storage file.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
On 1/6/21 3:40 AM, Shi Lei wrote:
Extract common code as helper function virNetlinkTalk, then simplify
the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 225 +-
src/util/virnetlink.h |
On Wed, Jan 06, 2021 at 11:27:09AM +0100, Erik Skultety wrote:
> On Thu, Dec 24, 2020 at 08:14:31AM -0600, Jonathon Jongsma wrote:
> > At startup, query devices that are defined by 'mdevctl' and add them to
> > the node device list.
> >
> > This adds a complication: we now have two potential
According to our parser (virDomainTPMDefParseXML()) the version
is an optional attribute and independent of TPM backend type.
Therefore, it's not a choice group, which is what our RNG schema
suggests.
Signed-off-by: Michal Privoznik
---
docs/schemas/domaincommon.rng | 20
1
On Wed, Jan 06, 2021 at 11:27:09AM +0100, Erik Skultety wrote:
> On Thu, Dec 24, 2020 at 08:14:31AM -0600, Jonathon Jongsma wrote:
> > At startup, query devices that are defined by 'mdevctl' and add them to
> > the node device list.
> >
> > This adds a complication: we now have two potential
Our element can have child element. But
with the way our schema is written it can't be interleaved and
has to go first.
Signed-off-by: Michal Privoznik
---
docs/schemas/domaincommon.rng | 42 +--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git
Tested with the following change:
diff --git a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
index f6bb663e97..875e2316a0 100644
--- a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
+++
On Fri, Dec 04, 2020 at 02:11:23PM +0100, Michal Privoznik wrote:
> While the code that's setting default qdisc is clever enough to
> not overwrite any bandwidth (potentially) set by
> virNetDevBandwidthSet() (and thus the root qdisc htb is not
> replaced with noqueue), it does print a debug
On 1/6/21 7:53 AM, Michal Privoznik wrote:
According to our parser (virDomainTPMDefParseXML()) the version
is an optional attribute and independent of TPM backend type.
Therefore, it's not a choice group, which is what our RNG schema
suggests.
Signed-off-by: Michal Privoznik
---
On Thu, Dec 24, 2020 at 08:14:30AM -0600, Jonathon Jongsma wrote:
> Since a mediated device can be persistently defined by the mdevctl
> backend, we need additional lifecycle events beyond CREATED/DELETED to
> indicate that e.g. the device has been stopped but the device definition
> still exists.
On Thu, Dec 24, 2020 at 08:14:36AM -0600, Jonathon Jongsma wrote:
> With mediated devices, we can now define persistent node devices that
> can be started and stopped. In order to take advantage of this, we need
> an API to define new node devices.
>
> Signed-off-by: Jonathon Jongsma
> ---
...
On Wed, Jan 06, 2021 at 08:00:52AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 1/6/21 7:09 AM, Daniel P. Berrangé wrote:
> > On Tue, Jan 05, 2021 at 05:18:13PM -0300, Daniel Henrique Barboza wrote:
> > > Hi,
> > >
> > > This is something I've been giving a thought after working in Gitlab
Changes to a virtio network device such as
...
were quietly dismissed by `virsh update-device ... --live`.
Signed-off-by: Tim Wiederhake
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_hotplug.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
On Tue, Jan 05, 2021 at 17:25:53 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtvzd.rst | 215
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
Signed-off-by: Daniel Henrique Barboza
---
Changes from v2:
- clarified that the bug fix will not affect existing guests that will
update from an older Libvirt version to 7.0.0.
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git
On 1/6/21 12:03 PM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 12:00:30PM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 11:47 AM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 11:42:09AM -0300, Daniel Henrique Barboza wrote:
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
On Tue, Jan 05, 2021 at 17:25:54 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst| 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtxend.rst | 215
1 - 100 of 137 matches
Mail list logo
