Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 11:00 hat Peter Maydell geschrieben: > On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > > > We want to switch both from QemuOpts to the keyval parser in the future, > > which results in some incompatibilities, mainly around list handling. > > Mark the non-JSON version of both

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 13:06 hat Damien Hedde geschrieben: > On 9/24/21 11:04, Kevin Wolf wrote: > > Directly call qdev_device_add_from_qdict() for QMP device_add instead of > > first going through QemuOpts and converting back to QDict. > > > > Note that this changes the behaviour of device_add, though

Re: [PATCH 06/11] qdev: Add Error parameter to qdev_set_id()

2021-09-27 Thread Damien Hedde
Hi Kevin, I proposed a very similar patch in our rfc series because we needed some of the cleaning you do here. https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05679.html I've added a bit of doc for the function, feel free to take it if you want. On 9/24/21 16:09, Vladimir

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-09-27 Thread Damien Hedde
On 9/24/21 11:04, Kevin Wolf wrote: Directly call qdev_device_add_from_qdict() for QMP device_add instead of first going through QemuOpts and converting back to QDict. Note that this changes the behaviour of device_add, though in ways that should be considered bug fixes: QemuOpts ignores

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > We want to switch both from QemuOpts to the keyval parser in the future, > which results in some incompatibilities, mainly around list handling. > Mark the non-JSON version of both as unstable syntax so that management > tools switch to JSON

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 12:17:03PM +0200, Kevin Wolf wrote: > Am 27.09.2021 um 10:21 hat Daniel P. Berrangé geschrieben: > > On Mon, Sep 27, 2021 at 10:15:43AM +0200, Paolo Bonzini wrote: > > > On 24/09/21 11:04, Kevin Wolf wrote: > > > > We want to switch both from QemuOpts to the keyval parser

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 10:21 hat Daniel P. Berrangé geschrieben: > On Mon, Sep 27, 2021 at 10:15:43AM +0200, Paolo Bonzini wrote: > > On 24/09/21 11:04, Kevin Wolf wrote: > > > We want to switch both from QemuOpts to the keyval parser in the future, > > > which results in some incompatibilities, mainly

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 10:15:43AM +0200, Paolo Bonzini wrote: > On 24/09/21 11:04, Kevin Wolf wrote: > > We want to switch both from QemuOpts to the keyval parser in the future, > > which results in some incompatibilities, mainly around list handling. > > Mark the non-JSON version of both as

Entering freeze for libvirt-7.8.0

2021-09-27 Thread Jiri Denemark
I have just tagged v7.8.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH v5 1/4] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines

2021-09-27 Thread Ani Sinha
On Mon, 27 Sep 2021, Ján Tomko wrote: > On a Monday in 2021, Ani Sinha wrote: > > The following change in qemu added support for a global boolean flag > > specific > > to i440fx machines that would turn off or on acpi based hotplug for pci root > > bus: > > > > 3d7e78aaf ("Introduce a new

Re: [PATCH v5 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-27 Thread Ani Sinha
On Mon, 27 Sep 2021, Ján Tomko wrote: > On a Monday in 2021, Ani Sinha wrote: > > This change introduces libvirt xml support to enable/disable hotplug on the > > pci-root controller. It adds a 'target' subelement for the pci-root > > controller > > with a 'hotplug' property. This property can

Re: [PATCH v5 1/4] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines

2021-09-27 Thread Ján Tomko
On a Monday in 2021, Ani Sinha wrote: The following change in qemu added support for a global boolean flag specific to i440fx machines that would turn off or on acpi based hotplug for pci root bus: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") The

Re: [PATCH] qemu: ingore the transient domain state in fake reboot

2021-09-27 Thread Michal Prívozník
On 9/26/21 11:06 AM, Zhenzhong Duan wrote: > When action for 'on_poweroff' is set to 'restart', 'fake reboot' > is triggered and qemu shutdown state is transient. Domain state > need not to be changed and events not sent in this case. > > Fixes:4ffc807214cb80086d57e1d3e7b60959a41d2874 >

Re: [PATCH v5 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-27 Thread Ján Tomko
On a Monday in 2021, Ani Sinha wrote: This change introduces libvirt xml support to enable/disable hotplug on the pci-root controller. It adds a 'target' subelement for the pci-root controller with a 'hotplug' property. This property can be used to enable or disable hotplug for the pci-root

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Paolo Bonzini
On 24/09/21 11:04, Kevin Wolf wrote: We want to switch both from QemuOpts to the keyval parser in the future, which results in some incompatibilities, mainly around list handling. Mark the non-JSON version of both as unstable syntax so that management tools switch to JSON and we can later make

Re: [PATCH v5 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-27 Thread Laine Stump
On 9/27/21 4:05 AM, Ján Tomko wrote: On a Monday in 2021, Ani Sinha wrote: This change introduces libvirt xml support to enable/disable hotplug on the pci-root controller. It adds a 'target' subelement for the pci-root controller with a 'hotplug' property. This property can be used to enable

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 12:27, Kevin Wolf wrote: > > Am 27.09.2021 um 11:00 hat Peter Maydell geschrieben: > > On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > > > > > We want to switch both from QemuOpts to the keyval parser in the future, > > > which results in some incompatibilities,

Re: [PATCH v4 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

2021-09-27 Thread Laine Stump
On 9/27/21 12:54 AM, Ani Sinha wrote: On Sun, 26 Sep 2021, Laine Stump wrote: +QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG); +DO_TEST_PARSE_ERROR_NOCAPS("pc-i440fx-acpi-root-hotplug-enable"); Ah, now I understand the origin of pc-i440fx-acpi-root-hotplug-enable.xml in the

Re: [PATCH v5 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-27 Thread Ani Sinha
On Mon, 27 Sep 2021, Laine Stump wrote: > On 9/27/21 4:05 AM, Ján Tomko wrote: > > On a Monday in 2021, Ani Sinha wrote: > > > This change introduces libvirt xml support to enable/disable hotplug on > > > the > > > pci-root controller. It adds a 'target' subelement for the pci-root > > >

[libvirt PATCH] vshCmddefCheckInternals: Fix typo

2021-09-27 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 189c452f73..7b77acad34 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -279,7 +279,7 @@ vshCmddefCheckInternals(vshControl *ctl, }

Re: [libvirt PATCH] vshCmddefCheckInternals: Fix typo

2021-09-27 Thread Ján Tomko
On a Monday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 189c452f73..7b77acad34 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -279,7 +279,7 @@

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 14:52 hat Peter Maydell geschrieben: > On Mon, 27 Sept 2021 at 12:27, Kevin Wolf wrote: > > > > Am 27.09.2021 um 11:00 hat Peter Maydell geschrieben: > > > On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > > > > > > > We want to switch both from QemuOpts to the keyval parser

[libvirt PATCH v5 4/7] News: Add PCI VPD-related helper functions to virpci

2021-09-27 Thread Dmitrii Shcherbakov
Signed-off-by: Dmitrii Shcherbakov --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a4178e505c..4617198f82 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,6 +37,13 @@ v7.8.0 (unreleased) functionality got added for Linux only at this point

[libvirt PATCH v5 0/7] Add a PCI/PCIe device VPD Capability

2021-09-27 Thread Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and exposing VPD resources as XML elements in a new nested capability of PCI/PCIe devices called 'vpd'. The series contains the following incremental changes: * The PCI VPD parser module, in-memory resource representation and tests;

[libvirt PATCH v5 6/7] News: Add PCI VPD capability support

2021-09-27 Thread Dmitrii Shcherbakov
Signed-off-by: Dmitrii Shcherbakov --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 4617198f82..4db4e0e3e3 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -44,6 +44,13 @@ v7.8.0 (unreleased) to invoke the PCI VPD parser to get a list of resources

[libvirt PATCH v5 2/7] News: Add a PCI VPD parser

2021-09-27 Thread Dmitrii Shcherbakov
Signed-off-by: Dmitrii Shcherbakov --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index fd20e50d18..a4178e505c 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -29,6 +29,14 @@ v7.8.0 (unreleased) active. This information can also be retrieved with the

[libvirt PATCH v5 3/7] Add PCI VPD-related helper functions to virpci

2021-09-27 Thread Dmitrii Shcherbakov
Add helper functions to virpci to provide means of checking for a VPD file presence and for VPD resource retrieval using the PCI VPD parser. The added test assesses the basic functionality of VPD retrieval while the full parser is tested by virpcivpdtest. Signed-off-by: Dmitrii Shcherbakov ---

[libvirt PATCH v5 7/7] Add PCI VPD Capability Documentation

2021-09-27 Thread Dmitrii Shcherbakov
Describes the format of the newly added VPD capability and gives and example for a real-world device. Signed-off-by: Dmitrii Shcherbakov --- docs/drvnodedev.html.in | 46 + docs/formatnode.html.in | 24 - 2 files changed, 69

[libvirt PATCH v5 5/7] Add PCI VPD Capability Support

2021-09-27 Thread Dmitrii Shcherbakov
* XML serialization and deserialization of PCI VPD resources; * PCI VPD capability flags added and used in relevant places; * XML to XML tests for the added capability. Signed-off-by: Dmitrii Shcherbakov --- docs/schemas/nodedev.rng | 40 +++

[libvirt PATCH v5 1/7] Add a PCI/PCIe device VPD Parser

2021-09-27 Thread Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and storing results in memory. The VPD format is specified in "I.3. VPD Definitions" in PCI specs (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe 4.0 notes, the PCI Local Bus and PCIe VPD formats are binary compatible

RE: [libvirt][PATCH v7 0/5] Support query and use SGX

2021-09-27 Thread Huang, Haibin
Really appreciate if anyone can give comments/opinions on this patch. Thank you in advance. > -Original Message- > From: Huang, Haibin > Sent: Wednesday, September 8, 2021 9:16 AM > To: libvir-list@redhat.com; Huang, Haibin ; Ding, > Jian-feng ; Yang, Lin A ; Lu, > Lianhao ;

[PATCH v6 0/4] Add support to enable/disable hotplug on pci-root controller

2021-09-27 Thread Ani Sinha
changelog: v6: incorporated Jan's suggestions. v5: incorporated suggestions from Laine for patches #2 and #3. The qemu command line is now added in a new function and called from qemuBuildControllersByTypeCommandLine(). Output xmls are now symlinked to input xmls for unit tests. v4:

[PATCH v6 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

2021-09-27 Thread Ani Sinha
This change adds qemu backend command line support for enabling or disabling hotplug on the pci-root controller using the 'target' sub-element of the pci-root controller as shown below: '' is only valid for pc (x86) machines and turns on the following command line option that is passed to

[PATCH v6 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-27 Thread Ani Sinha
This change introduces libvirt xml support to enable/disable hotplug on the pci-root controller. It adds a 'target' subelement for the pci-root controller with a 'hotplug' property. This property can be used to enable or disable hotplug for the pci-root controller. For example, in order to disable

[PATCH v6 4/4] NEWS: release note the new hotplug enable/disable option on pci-root controller

2021-09-27 Thread Ani Sinha
A new 'target' subelement of the pci-root controller has been introduced having a 'hotplug' property. This proprty can be used to turn off or turn on hotplug capability of the devices plugged into the pci-root ports. This change release notes this feature for the next release. The new element can

[PATCH v6 1/4] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines

2021-09-27 Thread Ani Sinha
The following change in qemu added support for a global boolean flag specific to i440fx machines that would turn off or on acpi based hotplug for pci root bus: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") The option is passed as "-global

[PATCH] conf: fix block type CDROM cannot support startupPolicy

2021-09-27 Thread Jie Wang
block type CDROM also support startupPolicy in the past, so let us fix it. Signed-off-by: Jie Wang --- src/conf/domain_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f7025bffe4..dd374e8ab3 100644 ---

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

2021-09-27 Thread Ani Sinha
On Sat, Sep 25, 2021 at 8:39 PM Ani Sinha wrote: > > Ok then let me do this. I will split up this patch set and send out a > separate patch set just for acpi-hotplug-root with the conf change as > suggested by danpb. It makes sense for me too to go down the path of his > suggestion. > >