[Libvir] [PATCH] stats_linux.c: Only include xs.h if WITH_XEN.

2007-11-15 Thread Jim Paris
Fixes compile error when building --without-xen on a host that has no Xen headers installed. --- src/stats_linux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stats_linux.c b/src/stats_linux.c index 5e6d06c..125af45 100644 --- a/src/stats_linux.c +++

[Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

2007-11-15 Thread Jim Paris
Signed one-bit bitfields are odd (values are 0 and -1?). The code doesn't test for == 1, so it's not currently broken, but it's fragile. (Noticed by Sparse). --- src/qemu_conf.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu_conf.h b/src/qemu_conf.h index

Re: [Libvir] [PATCH] Make make distcheck work.

2007-11-15 Thread Daniel Veillard
On Wed, Nov 14, 2007 at 07:56:02PM +0100, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: On Wed, Nov 14, 2007 at 03:57:10PM +0100, Jim Meyering wrote: Here's another infrastructure-fixing patch. I got most of the way to an honest make distcheck, but fixing a final failing

Re: [Libvir] [PATCH] stats_linux.c: Only include xs.h if WITH_XEN.

2007-11-15 Thread Richard W.M. Jones
Jim Paris wrote: Fixes compile error when building --without-xen on a host that has no Xen headers installed. --- src/stats_linux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stats_linux.c b/src/stats_linux.c index 5e6d06c..125af45 100644 ---

Re: [Libvir] [PATCH] Make make distcheck work.

2007-11-15 Thread Jim Meyering
Daniel Veillard [EMAIL PROTECTED] wrote: ... Adjusted patch below. ... okay, makes sense to me, +1 Thanks. committed. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] [PATCH] Miscellaneous cleanups for virNodeGetFreeMemory and virNodeGetCellsFreeMemory

2007-11-15 Thread Richard W.M. Jones
Same patch, just rebased to the latest libvirt CVS. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company

[Libvir] [PATCH 2/2] KVM network stats

2007-11-15 Thread Richard W.M. Jones
This patch adds the implementation of virDomainInterfaceStats for QEMU KVM domains. The function simply verifies that the requested path (interface name) belongs to the domain, then calls the existing code in stats_linux.c. Rich. -- Emerging Technologies, Red Hat -

[Libvir] [PATCH 1/2] KVM network stats

2007-11-15 Thread Richard W.M. Jones
Firstly there's a bug in how we parse /proc/net/dev. The format of each interface line turns out to be: %6s:... so in other words network interface names smaller than 6 characters are right justified (padded on the left with spaces). This isn't a problem for Xen because the shortest

Re: [Libvir] [PATCH] Miscellaneous cleanups for virNodeGetFreeMemory and virNodeGetCellsFreeMemory

2007-11-15 Thread Daniel Veillard
On Thu, Nov 15, 2007 at 02:11:37PM +, Richard W.M. Jones wrote: Same patch, just rebased to the latest libvirt CVS. Looks fine to me, thanks for the documentation update too, sorry I forgot to set it up :-\ Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel

Re: [Libvir] [PATCH] Miscellaneous cleanups for virNodeGetFreeMemory and virNodeGetCellsFreeMemory

2007-11-15 Thread Richard W.M. Jones
Daniel Veillard wrote: On Thu, Nov 15, 2007 at 02:11:37PM +, Richard W.M. Jones wrote: Same patch, just rebased to the latest libvirt CVS. Looks fine to me, thanks for the documentation update too, sorry I forgot to set it up :-\ Thanks, applied! Rich. -- Emerging Technologies, Red

Re: [Libvir] [PATCH 1/2] KVM network stats

2007-11-15 Thread Richard W.M. Jones
Daniel Veillard wrote: On Thu, Nov 15, 2007 at 03:53:00PM +, Richard W.M. Jones wrote: Firstly there's a bug in how we parse /proc/net/dev. The format of each interface line turns out to be: %6s:... so in other words network interface names smaller than 6 characters are right

[Libvir] [PATCH 0/2] KVM network stats

2007-11-15 Thread Richard W.M. Jones
This two part patch collects network interface stats from KVM domains. With this patch, virt-top will show the stats in its network interface view, as in the screengrab below. Rich. virt-top 15:47:38 - x86_64 4/4CPU 2814MHz 3967MB 0.1% 1 domains, 1 active, 1 running, 0 sleeping, 0 paused, 0

Re: [Libvir] PATCH: 1/4: Cleanup remote dispatch legacy code

2007-11-15 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: This patch simply cleans up some legacy code which was choosing between the QEMU driver protocol, and the generic remote protocol. There is no ABI wire change there - just tidying up the structs we use internally. a/qemud/protocol.c | 17