Re: [libvirt] libvirtd crashing with network bridge configuration

2008-12-23 Thread Emre Erenoglu
Hi Daniel, On Sun, Dec 21, 2008 at 6:15 PM, Daniel P. Berrange wrote: > > > > However, I still have the crash in the dmesg output, as before, errors > like: > > > > > > > > sysfs: duplicate filename '0' can not be > > created > > > > [ cut here > > - > > > > WARNING: at fs

Re: [libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-23 Thread Daniel P. Berrange
On Tue, Dec 23, 2008 at 05:50:03PM +, John Levon wrote: > On Tue, Dec 23, 2008 at 04:05:13PM +0100, Markus Armbruster wrote: > > > RHEL-5 has a peculiar version of Xen, which requires some special > > casing. Add a configure option for that. It will be used in later > > commits. > > Ugh, sh

Re: [libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-23 Thread John Levon
On Tue, Dec 23, 2008 at 04:05:13PM +0100, Markus Armbruster wrote: > RHEL-5 has a peculiar version of Xen, which requires some special > casing. Add a configure option for that. It will be used in later > commits. Ugh, shouldn't this be staying in a private Red Hat repository? regards john --

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-23 Thread Jim Meyering
John Levon wrote: > On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: > >> This all looks fine, but I'd prefer to retain the WARNING in the generated >> file, so that people are less likely to modify it directly. Along the > > Sure, your changes sound fine - are you going to commit yo

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-23 Thread John Levon
On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: > This all looks fine, but I'd prefer to retain the WARNING in the generated > file, so that people are less likely to modify it directly. Along the Sure, your changes sound fine - are you going to commit your version? thanks john -

[libvirt] [PATCH 6/7] Enable NUMA support for RHEL-5

2008-12-23 Thread Markus Armbruster
RHEL-5 supports NUMA since 5.2. Relax the version number checks. This breaks older versions, which will be fixed in the next commit. Signed-off-by: Markus Armbruster --- src/xen_internal.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/xen_internal.c b/src

[libvirt] [PATCH 7/7] Don't treat missing topology information as error

2008-12-23 Thread Markus Armbruster
The check for missing topology information fails if and only if the system doesn't support NUMA. We reach the check only when sys_interface_version is high enough for NUMA. In other words, the check fails when sys_interface_version incorrectly indicates NUMA support, and it turns that condition f

[libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-23 Thread Markus Armbruster
RHEL-5 has a peculiar version of Xen, which requires some special casing. Add a configure option for that. It will be used in later commits. Signed-off-by: Markus Armbruster --- configure.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure.in b/configur

[libvirt] [PATCH 1/7] Fix network device inconsistency between xm and sxpr

2008-12-23 Thread Markus Armbruster
xenDaemonFormatSxpr() adds (type ioemu) only if xendConfigVersion < 4. xenXMDomainConfigFormatNet() adds type=ioemu always. Change it make it consistent with xenDaemonFormatSxpr(). Signed-off-by: Markus Armbruster --- src/xm_internal.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-

[libvirt] [PATCH 2/7] Fix graphics configuration inconsistency between xm and sxpr

2008-12-23 Thread Markus Armbruster
xenDaemonFormatSxpr() generates old-style HVM graphics configuration when xendConfigVersion is below 4. xenXMDomainConfigFormat() does that always. Change it to make it consistent with xenDaemonFormatSxpr(). Signed-off-by: Markus Armbruster --- src/xm_internal.c |2 +- 1 files changed, 1 i

[libvirt] [PATCH 5/7] Fix PVFB device configuration for RHEL-5

2008-12-23 Thread Markus Armbruster
PVFB configuration depends on the version. The version number check doesn't work for RHEL-5 because its PVFB device was backported from later versions. Special-case it. Signed-off-by: Markus Armbruster --- src/xend_internal.c |6 -- src/xm_internal.c |4 +++- 2 files changed, 7 i

[libvirt] [PATCH 4/7] Fix HVM network device configuration for RHEL-5

2008-12-23 Thread Markus Armbruster
Omit (type ioemu) on RHEL-5, because it breaks PV drivers on HVM there. Signed-off-by: Markus Armbruster --- src/xend_internal.c |8 +++- src/xm_internal.c |8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/xend_internal.c b/src/xend_internal.c index 3

[libvirt] [PATCH 0/7 RFC] RHEL-5 support, and a few preparatory fixes

2008-12-23 Thread Markus Armbruster
This patch series attempts to make libvirt just work on RHEL-5. Right now it doesn't, mostly because libvirt relies on version number checks in a couple of places, and RHEL-5's version numbers aren't the whole truth due to various backports of later stuff. The first two patches are plain bug fixe

Re: [libvirt] [PATCH] 0/8 logging infrastructure for libvirt[d]

2008-12-23 Thread Daniel Veillard
On Mon, Dec 22, 2008 at 05:17:22PM +0100, Daniel Veillard wrote: > On Mon, Dec 22, 2008 at 02:01:38PM +0100, Daniel Veillard wrote: > make check is fixed now, Just extra docs are needed, I will finish > those tomorrow, Commited, available at http://libvirt.org/logging.html I have put them un

Re: [libvirt] document vnc's keymap option

2008-12-23 Thread Daniel Veillard
On Tue, Dec 23, 2008 at 01:59:58PM +0100, Guido Günther wrote: > Hi, > possible patch attached. Looks fine to me, +1, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ |

[libvirt] Re: [PATCH]: virAsprintf cleanup v2

2008-12-23 Thread Guido Günther
On Tue, Dec 23, 2008 at 10:45:57AM +0100, Jim Meyering wrote: > Guido Günther wrote: > > new version attached. It adds your suggestions and also uses virAsprintf > > in the new src/logging.c. > > Thanks! > That looks fine, applies, and passes tests. > You're welcome to apply it. Applied now. --

[libvirt] document vnc's keymap option

2008-12-23 Thread Guido Günther
Hi, possible patch attached. -- Guido >From e991a8740a5777d779fb8df0b4b2514a9878b464 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= Date: Mon, 22 Dec 2008 23:23:57 +0100 Subject: [PATCH] document vnc's keymap parameter --- docs/drvqemu.html.in |2 +- docs/formatdomain.

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2008-12-23 Thread Jim Meyering
john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1230005985 28800 > # Node ID 9621540df10095ea8b0cdc83cdd3d17a68509a64 > # Parent 60090fd4e447795742265241b39f2759d9530514 > Split out version script into multiple files ... > diff --git a/src/Makefile.am b/src/M

RE: [libvirt] [OpenVZ]

2008-12-23 Thread Ivan Vovk
Thanks Evgeniy! Was this patch committed? -Original Message- From: Evgeniy Sokolov [mailto:e...@openvz.org] Sent: Thursday, December 18, 2008 4:49 PM To: Ivan Vovk Cc: veill...@redhat.com; Daniel P. Berrange; asp...@gmail.com; libvir-list@redhat.com Subject: Re: [libvirt] [OpenVZ

[libvirt] Re: [PATCH]: virAsprintf cleanup v2

2008-12-23 Thread Jim Meyering
Guido Günther wrote: > new version attached. It adds your suggestions and also uses virAsprintf > in the new src/logging.c. Thanks! That looks fine, applies, and passes tests. You're welcome to apply it. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/l