Rename virStorageVolFormatFileSystem to virStorageFileFormat and
move to src/util/storage_file.[ch]
* src/Makefile.am: add src/util/storage_file.[ch]
* src/conf/storage_conf.[ch]: move enum from here ...
* src/util/storage_file.[ch]: .. to here
* src/libvirt_private.syms: update To/FromString
* src/util/storage_file.c: add virStorageFileGetMetadata() so that
the caller does not need to open the file
---
src/libvirt_private.syms |1 +
src/util/storage_file.c | 20
src/util/storage_file.h |3 +++
3 files changed, 24 insertions(+), 0 deletions(-)
diff
Finally, we get to the point of all this.
Move virStorageGetMetadataFromFD() to virStorageFileGetMetadataFromFD()
and move to src/util/storage_file.[ch]
There's no functional changes in this patch, just code movement
* src/storage/storage_backend_fs.c: move code from here ...
*
Use virStorageFileGetMetadata() to find any backing stores for images
and re-label them
Without this, qemu cannot access qcow2 backing files, see:
https://bugzilla.redhat.com/497131
* src/security/security_selinux.c: re-label backing store files in
SELinuxSetSecurityImageLabel()
---
Prepare the code probing a file's format and associated metadata for
moving into libvirt_util.
* src/storage/storage_backend_fs.c: re-factor the format and metadata
probing code in preparation for moving it
---
src/storage/storage_backend_fs.c | 148 +++---
1
Introduce a metadata structure and make virStorageGetMetadataFromFD()
fill it in.
* src/util/storage_file.h: add virStorageFileMetadata
* src/backend/storage_backend_fs.c: virStorageGetMetadataFromFD() now
fills in the virStorageFileMetadata structure
---
src/storage/storage_backend_fs.c |
On Mon, Sep 28, 2009 at 06:42:14PM -0400, Laine Stump wrote:
On 09/28/2009 06:39 PM, Laine Stump wrote:
On 09/28/2009 11:30 AM, Daniel Veillard wrote:
The virXPath... function take extra care to preserve the XPath context
node (ctxt-node) but in the case of virXPathString and virXPathBoolean
On Mon, Sep 28, 2009 at 09:03:37PM -0500, Charles Duffy wrote:
Charles Duffy wrote:
What I'm tempted to do is add a command which sends a sigil to stderr to
the end of the exec: migration lines specified by libvirt, and wait for
either that sigil or an error to show up in the log for that
On Mon, Sep 28, 2009 at 06:54:19PM -0400, Laine Stump wrote:
This was causing subsequent calls to virXPathxxx() to fail, since
ctxt-node was left pointing at the dhcp node, rather than the
protocol node. Previously this had gone unnoticed, as the dhcp node
was the only thing parsed under ip,
+enum virStorageFileFormat {
+VIR_STORAGE_FILE_RAW = 0,
+VIR_STORAGE_FILE_DIR,
+VIR_STORAGE_FILE_BOCHS,
+VIR_STORAGE_FILE_CLOOP,
+VIR_STORAGE_FILE_COW,
+VIR_STORAGE_FILE_DMG,
+VIR_STORAGE_FILE_ISO,
+VIR_STORAGE_FILE_QCOW,
+VIR_STORAGE_FILE_QCOW2,
+
On Tue, Sep 29, 2009 at 11:27:18AM +0200, Pritesh Kothari wrote:
+enum virStorageFileFormat {
+VIR_STORAGE_FILE_RAW = 0,
+VIR_STORAGE_FILE_DIR,
+VIR_STORAGE_FILE_BOCHS,
+VIR_STORAGE_FILE_CLOOP,
+VIR_STORAGE_FILE_COW,
+VIR_STORAGE_FILE_DMG,
+
On Fri, Sep 25, 2009 at 05:44:35PM -0500, Jamie Strandboge wrote:
This simplifies adding new files. Part of this process involved adding
support for kernel, initrd, loader, serial, and console. I have commented
out code for hostdev (and pci would be easy enough), but it requires a
patch to
On Thu, Sep 24, 2009 at 04:00:02PM +0100, Daniel P. Berrange wrote:
In the QEMU driver source code the methods which talk to the QEMU
monitor currently all just call qemudMonitorCommand() directly
with the raw command string, and then parse the raw reply.
In the not too distant future QEMU
This patch replaces the use of NULL with empty strings () in a call to
OpenHardDisk, which otherwise fails with E_INVALIDARG.
Florian
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index c02b18c..f5a8c97 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -3206,9 +3206,9 @@
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-
boun...@redhat.com] On Behalf Of Daniel P. Berrange
Sent: Monday, September 28, 2009 4:47 PM
To: Iyer, Shyam
Cc: libvir-list@redhat.com; Bellad, Sudhir; Domsch, Matt; KM, Paniraja
Subject: Re: [libvirt]
Hi,
Got my git/hg builds of libvirtd/virt-manager running together with kvm.
Took some time but finally think I'm getting the
hang of it.
I noticed two things going from my pre-packaged Debian packages.
The older xml files I had seemed to generate a faulty kvm cmdline:
disk type='file'
On Tue, Sep 29, 2009 at 4:16 AM, Daniel P. Berrange berra...@redhat.comwrote:
Yeah, I've been thinking much the same this morning. I think we should
consider what the optimal setup is for our needs long term and try and
do whatever we can for that in QEMU now. I think it'd definitely be
Oh, regarding my previous post, I ran virt-manager --debug so see what's
going on (I'm missing much more than just the vm names). I'm thinking I
either missed installing some bits or my gtk/glade setup is already obsolete
(Debian Lenny). Any hints?
(virt-manager.py:27842): libglade-WARNING **:
On Tue, Sep 29, 2009 at 01:11:45PM +0200, Fred Leeflang wrote:
Oh, regarding my previous post, I ran virt-manager --debug so see what's
going on (I'm missing much more than just the vm names). I'm thinking I
either missed installing some bits or my gtk/glade setup is already obsolete
(Debian
-Original Message-
From: Dave Allan [mailto:dal...@redhat.com]
Sent: Monday, September 28, 2009 6:44 PM
To: Iyer, Shyam
Cc: libvir-list@redhat.com; Bellad, Sudhir; Domsch, Matt; KM, Paniraja
Subject: Re: [libvirt] [RFC] Multi-IQN proposal
shyam_i...@dell.com wrote:
Thanks for
On Tue, Sep 29, 2009 at 12:12:23PM +0200, Daniel Veillard wrote:
On Thu, Sep 24, 2009 at 04:00:02PM +0100, Daniel P. Berrange wrote:
In the QEMU driver source code the methods which talk to the QEMU
monitor currently all just call qemudMonitorCommand() directly
with the raw command string,
On Mon, Sep 28, 2009 at 04:30:06PM -0600, Jim Fehlig wrote:
Chris Lalancette wrote:
While your patch would fix the problem, I'm not sure it's a good long-term
solution. Other differences might come up in the future, and trying to
worry
about vshDeinit being re-entrant is probably not
On Tuesday 29 September 2009 12:27:49 Florian Vichot wrote:
This patch replaces the use of NULL with empty strings () in a call to
OpenHardDisk, which otherwise fails with E_INVALIDARG.
The patch fix's it but the more appropriate fix would be as below.
Regards,
Pritesh
diff --git
On Tue, 29 Sep 2009, Daniel P. Berrange wrote:
On Fri, Sep 25, 2009 at 05:44:35PM -0500, Jamie Strandboge wrote:
This simplifies adding new files. Part of this process involved adding
support for kernel, initrd, loader, serial, and console. I have commented
out code for hostdev (and pci
On Tue, Sep 29, 2009 at 02:18:41PM +0200, Pritesh Kothari wrote:
On Tuesday 29 September 2009 12:27:49 Florian Vichot wrote:
This patch replaces the use of NULL with empty strings () in a call to
OpenHardDisk, which otherwise fails with E_INVALIDARG.
The patch fix's it but the more
Hi Experts,
Just wondering is it possible now to run libvirt deamon on non-linux
platforms (mainly windows and mac)? If yes, are there instructions on how to
build it. If no, what was the roadblock?
I'm trying to find a tool that can control the VMM for desktop/laptop users
under win/mac/linux.
On Tue, Sep 29, 2009 at 05:50:34AM -0600, Yushu Yao wrote:
Hi Experts,
Just wondering is it possible now to run libvirt deamon on non-linux
platforms (mainly windows and mac)? If yes, are there instructions on how to
build it. If no, what was the roadblock?
I'm trying to find a tool that
I'm suggesting to try to push 0.7.2 around Fri 16 Oct, we already have
a number of cleanup patches in and serious improvements for ESX driver.
If we go with that plan I think patches and big changes should be pushed
in the tree by Fri 9, this includes among other things the AppArmor
security
On Tue, Sep 29, 2009 at 04:24:16PM +0200, Daniel Veillard wrote:
I'm suggesting to try to push 0.7.2 around Fri 16 Oct, we already have
a number of cleanup patches in and serious improvements for ESX driver.
If we go with that plan I think patches and big changes should be pushed
in the tree
FYI,
the data streams patches are now committed
Daniel
On Fri, Sep 25, 2009 at 09:58:51AM +0200, Daniel Veillard wrote:
On Mon, Aug 24, 2009 at 09:51:03PM +0100, Daniel P. Berrange wrote:
The following series of patches introduce support for generic data
streams in the libvirt API, the
Hi All,
There is bug in vboxDomainDestroy() where in the while powerdown the method
doesn't wait till its completion.
Fix in the attached patch.
Regards,
Pritesh
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 07515fe..65e3449 100644
--- a/src/vbox/vbox_tmpl.c
+++
On Tue, Sep 29, 2009 at 03:29:49PM +0100, Daniel P. Berrange wrote:
On Tue, Sep 29, 2009 at 04:24:16PM +0200, Daniel Veillard wrote:
I'm suggesting to try to push 0.7.2 around Fri 16 Oct, we already have
a number of cleanup patches in and serious improvements for ESX driver.
If we go with
Daniel P. Berrange wrote:
On Tue, Sep 29, 2009 at 02:39:59AM -0400, Jim Paris wrote:
Hi,
After upgrading libvirt on one system, my kvm guests running a 2.6.26
kernel with virtio networking could no longer communicate with the
network.
It seems that the problem is caused by newer
This series of patches adds minimal support for SPICE graphics
which is newly introduced in RHEL-5.4's fork of KVM. Since this
is not yet merged in upstream QEMU/KVM, I'm not proposing to merge
all these patches. The two XML schema patches are straightforward
to merge.
The two implementation ones
* src/qemu_conf.c: Add dummy entry in enumeration
* docs/schemas/domain.rng: Add 'qxl' as a type for the video tag
* src/domain_conf.c, src/domain_conf.h: Add QXL to video type
enumerations
---
docs/schemas/domain.rng |7 +++
src/conf/domain_conf.c |3 ++-
src/conf/domain_conf.h |
This adds an element
graphics type='spice' port='5903' tlsPort='5904' listen='127.0.0.1'/
This is the bare minimum that should be exposed in the guest
config for SPICE. Other parameters are better handled as per
host level configuration tunables
* docs/schemas/domain.rng: Define the SPICE
This supports the -qxl argument in RHEL-5's fork of KVM
which has SPICE support. QXL is a graphics card, but
inexplicably doesn't use the standard -vga syntax for
generic configuration. Also -qxl is rather useless unless
you also supply -spice (coming in next patch)
* src/qemu_conf.c: Probe for
This supports the -spice argument in RHEL-5's fork of KVM
which has SPICE support. There are many more options for
-spice than need to be added - at very least the x509
cert paths should be pulled out of /etc/libvirt/qemu.conf
* src/qemu_conf.c, src/qemu_conf.h: Add SPICE flag. Check for
-spice
Jim Paris wrote:
Daniel P. Berrange wrote:
On Tue, Sep 29, 2009 at 02:39:59AM -0400, Jim Paris wrote:
Hi,
After upgrading libvirt on one system, my kvm guests running a 2.6.26
kernel with virtio networking could no longer communicate with the
network.
It seems that the
This wasn't the file I meant to send!
On 09/29/2009 03:58 PM, Laine Stump wrote:
Fix some minor grammer (and one other) nits in comments that end up in
generated API reference documentation. No functional/binary differences.
[...]
--
Libvir-list mailing list
Libvir-list@redhat.com
From: root r...@vlap.laine.org
This patch adds the flag VIR_INTERFACE_XML_INACTIVE to
virInterfaceGetXMLDesc's flags. When it is *not* set (the default),
the live interface info will be returned in the XML. in particular,
the IP address(es) and netmask(s) will be retrieved by querying the
device
On 09/29/2009 04:02 PM, Laine Stump wrote:
From: rootr...@vlap.laine.org
Note that I accidentally did the local commit as root, and didn't notice
it until now. If this patch gets committed, please change the From: first.
This patch adds the flag VIR_INTERFACE_XML_INACTIVE to
On Tue, 2009-09-29 at 15:20 -0400, Jim Paris wrote:
Nevermind that, my conclusions were bogus. Things still didn't quite add
up, so I tracked down what's really going on here:
- Libvirt 0.7.1 (as packaged by Debian) has IFF_VNET_HDR support.
- Qemu-kvm 0.11.0 (as built by myself) did NOT
On 09/29/2009 10:02 PM, Laine Stump wrote:
From: rootr...@vlap.laine.org
This patch adds the flag VIR_INTERFACE_XML_INACTIVE to
virInterfaceGetXMLDesc's flags.
What about calling it instead VIR_INTERFACE_XML_CONFIG and adding a
dummy (0) VIR_INTERFACE_XML_DEVICE, and corresponding
On Tue, Sep 29, 2009 at 11:13:56PM +0200, Paolo Bonzini wrote:
On 09/29/2009 10:02 PM, Laine Stump wrote:
From: rootr...@vlap.laine.org
This patch adds the flag VIR_INTERFACE_XML_INACTIVE to
virInterfaceGetXMLDesc's flags.
What about calling it instead VIR_INTERFACE_XML_CONFIG and adding a
2009/9/29 Daniel P. Berrange berra...@redhat.com:
On Sat, Sep 26, 2009 at 02:24:33AM +0200, Matthias Bolte wrote:
I tracked down a memleak in libvirtd's message processing. The leak
was introduced in commit 47cab734995fa9521b1df05d37e9978eedd8d3a2
Split out code for handling incoming method
46 matches
Mail list logo
