Re: [libvirt] Unable to open virt-manager

2010-03-24 Thread Doron Fediuck
On Tuesday 23 March 2010 21:53:04 Cole Robinson wrote: On 03/23/2010 12:12 PM, Doron Fediuck wrote: Hi, I'm trying to work remotely on a server with F12, using vnc. When I start virt-manager, I do not get the authentication popup, and instead I get this message: Unable to open

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Gerd Hoffmann
On 03/24/10 00:13, Jamie Lokier wrote: Gerd Hoffmann wrote: - networking: man, setting networking is a mess, libvirt just does it for you. +1 Even when not using libvirt for a reason or another I usually hook my virtual machines into virbr0 (libvirt default network). I had the opposite

[libvirt] [PATCH] tests: test-lib.sh portability and clean-up

2010-03-24 Thread Jim Meyering
No big deal, but I saw recent additions of test ... -a ... (not portable) so fixed the rest, too. Now, searching for violations shows none: git grep '\test .* -a ' Whether it's possible to rely on test -a in test scripts is debatable: perhaps you've ensured that the SHELL you use when running

[libvirt] [PATCH] build: suppress distracting build output

2010-03-24 Thread Jim Meyering
While building make check, I saw this scroll by (too quickly to see what it was), but it was different enough from the rest that... CCLD libvirt.la CCLD libvirt_test.la make check-local make[3]: Entering directory `/home/j/w/co/libvirt/src' if test -x '/usr/bin/augparse';

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Juan Quintela
Andi Kleen a...@firstfloor.org wrote: Juan Quintela quint...@redhat.com writes: - networking: man, setting networking is a mess, libvirt just does it for you. Agreed it's messy, but isn't this something that the standard qemu command line tool could potentially do better by itself? I

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Paolo Bonzini
/* Return the number of snapshots for this domain */ int virDomainSnapshotNum(virDomainPtr domain, unsigned int flags); Shouldn't this be called virDomainNumOfSnapshots to be consistent with the naming or other num-of functions? Gah. I struggled with this; I like the fact that all of the

Re: [libvirt] [PATCH] poll(-0.001) does not sleep forever.

2010-03-24 Thread Jim Meyering
Eric Blake wrote: On 03/23/2010 09:07 AM, Philipp Hahn wrote: The conversion from seconds to milliseconds should only be done for actual delays = 0, not for the magic -1 value used for infinite timeouts. ACK. Thanks. I pushed that. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Andi Kleen
Juan Quintela quint...@redhat.com writes: - networking: man, setting networking is a mess, libvirt just does it for you. Agreed it's messy, but isn't this something that the standard qemu command line tool could potentially do better by itself? I don't see why you need a wrapper for that.

[libvirt] prematurely pushed my build/portability/clean-up patches

2010-03-24 Thread Jim Meyering
Jim Meyering wrote: Eric Blake wrote: On 03/23/2010 09:07 AM, Philipp Hahn wrote: The conversion from seconds to milliseconds should only be done for actual delays = 0, not for the magic -1 value used for infinite timeouts. ACK. Thanks. I pushed that. Whoops. While pushing that, I

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Daniel Veillard
On Tue, Mar 23, 2010 at 01:48:19PM -0600, Eric Blake wrote: On 03/23/2010 01:23 PM, Chris Lalancette wrote: } virDomainSnapshotDeactivate; int virDomainSnapshotDeactivate(virDomainSnapshotPtr snapshot, unsigned int flags); I'm not sure if

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Daniel Veillard
On Tue, Mar 23, 2010 at 07:35:22PM +0100, Matthias Bolte wrote: 2010/3/23 Chris Lalancette clala...@redhat.com: /* Return the number of snapshots for this domain */ int virDomainSnapshotNum(virDomainPtr domain, unsigned int flags); Shouldn't this be called virDomainNumOfSnapshots to be

Re: [libvirt] [PATCH] esx: Make the conf parser compare names case insensitive in VMX mode

2010-03-24 Thread Daniel Veillard
On Wed, Mar 24, 2010 at 02:12:14AM +0100, Matthias Bolte wrote: The keys of entries in a VMX file are case insensitive. Both scsi0:1.fileName and scsi0:1.filename are valid. Therefore, make the conf parser compare names case insensitive in VMX mode to accept every capitalization variation.

Re: [libvirt] [PATCH] vbox: Fix segfault on empty device source

2010-03-24 Thread Daniel Veillard
On Wed, Mar 24, 2010 at 01:23:37AM +0100, Matthias Bolte wrote: 2010/3/22 Eric Blake ebl...@redhat.com: On 03/22/2010 02:40 PM, Matthias Bolte wrote: source file=''/ results in def-disks[i]-src == NULL. But vboxDomainDefineXML didn't check def-disks[i]-src for NULL and expected it to be a

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 09:52:51AM +0100, Paolo Bonzini wrote: /* Return the number of snapshots for this domain */ int virDomainSnapshotNum(virDomainPtr domain, unsigned int flags); Shouldn't this be called virDomainNumOfSnapshots to be consistent with the naming or other num-of

[libvirt] [PATCH 5/6] Allow parsing graphics in device XML

2010-03-24 Thread Daniel P. Berrange
Expand the parser for the standalone device XML format to allow inclusion of the graphics device type * src/conf/domain_conf.h: Add virDomainGraphicsDef to the virDomainDeviceDef struct * src/conf/domain_conf.c: Wire up parser for virDomainGraphicsDef to virDomainDeviceDefParse method ---

[libvirt] [PATCH 4/6] Introduce a update-device command in virsh

2010-03-24 Thread Daniel P. Berrange
Support the new virDomainUpdateDeviceFlags API in virsh by adding a new 'update-device' command. In the future this should be augmented with an explicit 'change-disk' command for media change to make it end user discoverable, as attach-disk is. * tools/virsh.c: Add 'update-device' command ---

[libvirt] [PATCH 3/6] Implement virDomainUpdateDeviceFlags API in all drivers with media change

2010-03-24 Thread Daniel P. Berrange
To allow the new virDomainUpdateDeviceFlags() API to be universally used with all drivers, this patch adds an impl to all the current drivers which support CDROM or Floppy disk media change via the current virDomainAttachDeviceFlags API * src/qemu/qemu_driver.c, src/vbox/vbox_tmpl.c,

[libvirt] [PATCH 6/6] Implement VNC password change in QEMU

2010-03-24 Thread Daniel P. Berrange
Use the new virDomainUpdateDeviceFlags API to allow the VNC password to be changed on the fly * src/internal.h: Define STREQ_NULLABLE() which is like STREQ() but does not crash if either argument is NULL, and treats two NULLs as equal. * src/libvirt_private.syms: Export

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-03-24 Thread Darryl L. Pierce
On Thu, Mar 11, 2010 at 04:10:24PM -0500, Darryl L. Pierce wrote: Here is what's output by libvirtd: 11:36:57.608: debug : virRun:809 : /usr/sbin/dnsmasq --strict-order --bind-interfaces --pid-file=/var/run/libvirt/network/testbr6762.pid --conf-file= --listen-address 192.168.132.1

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Anthony Liguori
On 03/24/2010 12:17 AM, Avi Kivity wrote: On 03/23/2010 08:00 PM, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. So the fundamental topic

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Anthony Liguori
On 03/24/2010 05:42 AM, Avi Kivity wrote: The filtering access part of this daemon is also not mapping well onto libvirt's access model, because we don't soley filter based on UID in libvirtd. We have it configurable based on UID, policykit, SASL, TLS/x509 already, and intend adding role

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Avi Kivity
On 03/24/2010 02:30 PM, Anthony Liguori wrote: On 03/24/2010 07:27 AM, Avi Kivity wrote: On 03/24/2010 02:19 PM, Anthony Liguori wrote: qemud - daemonaizes itself - listens on /var/lib/qemud/guests for incoming guest connections - listens on /var/lib/qemud/clients for incoming client

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Avi Kivity
On 03/24/2010 02:30 PM, Paul Brook wrote: On 03/23/2010 09:24 PM, Anthony Liguori wrote: We also provide an API for guest creation (the qemu command line). As an aside, I'd like to see all command line options have qmp equivalents (most of them can be implemented with a 'set'

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Anthony Liguori
On 03/24/2010 07:29 AM, Avi Kivity wrote: On 03/24/2010 02:23 PM, Anthony Liguori wrote: On 03/24/2010 05:42 AM, Avi Kivity wrote: The filtering access part of this daemon is also not mapping well onto libvirt's access model, because we don't soley filter based on UID in libvirtd. We have it

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Avi Kivity
On 03/24/2010 02:32 PM, Anthony Liguori wrote: You don't get a directory filled with a zillion socket files pointing at dead guests. Agree that's a poor return on investment. Deleting it on atexit combined with flushing the whole directory at startup is a pretty reasonable solution to this

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Chris Lalancette
On 03/24/2010 05:51 AM, Daniel Veillard wrote: /* Set this snapshot as the current one for a domain, to be * used next time domain is started */ int virDomainSnapshotActivate(virDomainSnapshotPtr snapshot, unsigned int flags); This delayed semantic cannot be

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Chris Lalancette
On 03/24/2010 04:52 AM, Paolo Bonzini wrote: /* Deactivate a snapshot - with no flags, the snapshot is not used anymore, * but also not removed. With a MERGE flag, it merges the snapshot into * the base image. With a DISCARD flag, it deletes the snapshot. MERGE * and

[libvirt] [RFC]: Snapshot API v2

2010-03-24 Thread Chris Lalancette
Based on discussion, I've modified the snapshot API to the below. I've incorporated most of the semantic changes we talked about; the renaming of various API calls I've left for later, since it is a minor point. More comments welcome! /* NOTE: struct _virDomainSnapshot is a private structure,

Re: [libvirt] [RFC]: Snapshot API v2

2010-03-24 Thread Matthias Bolte
2010/3/24 Chris Lalancette clala...@redhat.com: Based on discussion, I've modified the snapshot API to the below.  I've incorporated most of the semantic changes we talked about; the renaming of various API calls I've left for later, since it is a minor point. More comments welcome! /* NOTE:

Re: [libvirt] [RFC]: Snapshot API v2

2010-03-24 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 02:34:41PM +0100, Matthias Bolte wrote: 2010/3/24 Chris Lalancette clala...@redhat.com: Based on discussion, I've modified the snapshot API to the below.  I've incorporated most of the semantic changes we talked about; the renaming of various API calls I've left for

Re: [libvirt] error: internal error canonical hostname pointed to localhost, but this is not allowed

2010-03-24 Thread Chris Lalancette
On 03/23/2010 11:00 AM, Kenneth Nagin wrote: Changing qemudDomainMigratePrepare2 call to virGetHostnameLocalhost from: if ((hostname = virGetHostnameLocalhost(0)) == NULL) to: if ((hostname = virGetHostnameLocalhost(1)) == NULL) seems to fix the problem. But maybe this is only masking a

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Matthias Bolte
2010/3/24 Daniel P. Berrange berra...@redhat.com: On Wed, Mar 24, 2010 at 09:09:08AM -0400, Chris Lalancette wrote: On 03/24/2010 04:52 AM, Paolo Bonzini wrote: How canparent  be settable? If I have snapshots A and B    A -  B -  current state and I create a new snapshot C,

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 02:42:30PM +0100, Matthias Bolte wrote: 2010/3/24 Daniel P. Berrange berra...@redhat.com: On Wed, Mar 24, 2010 at 09:09:08AM -0400, Chris Lalancette wrote: On 03/24/2010 04:52 AM, Paolo Bonzini wrote: How canparent  be settable? If I have snapshots A and B

Re: [libvirt] Unable to open virt-manager

2010-03-24 Thread Cole Robinson
On 03/24/2010 03:06 AM, Doron Fediuck wrote: On Tuesday 23 March 2010 21:53:04 Cole Robinson wrote: On 03/23/2010 12:12 PM, Doron Fediuck wrote: Hi, I'm trying to work remotely on a server with F12, using vnc. When I start virt-manager, I do not get the authentication popup, and instead I

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Gerd Hoffmann
In practice I've seen this not working correctly in the past, i.e. my ^^^ br0 didn't pop up in the virt-manager nic setup page. Please file a bug: virt-manager has had bridge detection for years, so something must be going wrong.

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-03-24 Thread Paolo Bonzini
On 03/24/2010 01:08 PM, Darryl L. Pierce wrote: On Thu, Mar 11, 2010 at 04:10:24PM -0500, Darryl L. Pierce wrote: Here is what's output by libvirtd: 11:36:57.608: debug : virRun:809 : /usr/sbin/dnsmasq --strict-order --bind-interfaces --pid-file=/var/run/libvirt/network/testbr6762.pid

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Paolo Bonzini
On 03/24/2010 02:09 PM, Chris Lalancette wrote: The problem, though, is what Mattias points out; there is no (easy) way that, given state C, I can get back to state A to make a new snapshot. I actually have to be at state A to take a new snapshot with a parent of A. I think this is a place

[libvirt] [PATCH] Don't replace persistent domain config with migrated config

2010-03-24 Thread Jiri Denemark
When a domain is defined on host1, migrated to host2 and then migrated back to host1, its current configuration would overwrite the libvirtd's in-memory copy of persistent configuration of that domain. This is not desired as we want to preserve the persistent configuration untouched. This patch

[libvirt] [PATCH] Add entry point logging for cpu functions

2010-03-24 Thread Jiri Denemark
--- src/cpu/cpu.c | 46 -- 1 files changed, 44 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index be0f15e..183862a 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -23,6 +23,7 @@ #include config.h +#include logging.h

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Chris Lalancette
On 03/24/2010 10:40 AM, Paolo Bonzini wrote: If you do not want to allow setting the parent, you can also add a flag --inactive to virsh snapshot-create that would create the snapshot without making it active. Then you would makeparent an informational field about which snapshot

Re: [libvirt] [RFC]: Snapshot API v2

2010-03-24 Thread Chris Lalancette
On 03/24/2010 09:36 AM, Daniel P. Berrange wrote: The virsh commands will be: virsh snapshot-create [--compress] dom xmlfile virsh snapshot-list dom virsh snapshot-dumpxml dom name virsh create-with-snapshot dom snapshotname It should be called start-with-snapshot. I'm not sure if this

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-03-24 Thread Darryl L. Pierce
On Wed, Mar 24, 2010 at 03:34:04PM +0100, Paolo Bonzini wrote: I'm still in the same state here. Shall I open a bug against libvirt regarding it not recognizing the --tftp-root argument? That would be against dnsmasq? I'm not sure it is. When I use dnsmasq then it honors tftp-root just fine.

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-03-24 Thread Paolo Bonzini
On 03/24/2010 04:24 PM, Darryl L. Pierce wrote: On Wed, Mar 24, 2010 at 03:34:04PM +0100, Paolo Bonzini wrote: I'm still in the same state here. Shall I open a bug against libvirt regarding it not recognizing the --tftp-root argument? That would be against dnsmasq? I'm not sure it is. When

Re: [libvirt] [RFC]: Snapshot API

2010-03-24 Thread Paolo Bonzini
On 03/24/2010 12:02 PM, Daniel P. Berrange wrote: I don't see any need to special case the base image here. The main virDOmainSnapshotDelete() API already lets you discard all snapshots until you get to the base image - VMWare/VirtualBox already demonstrate this is sufficient. Is this as

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Markus Armbruster
Paul Brook p...@codesourcery.com writes: IMO the no_user flag is a bug, and should not exist. Sorry, what's that? Usually an indication that a device has been incorrectly or inproperly converted to the qdev interface. Can also be an indication that the device can't support multiple

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 12:42:16 +0200 Avi Kivity a...@redhat.com wrote: So, at best qemud is a toy for people who are annoyed by libvirt. Is the reason for doing this in qemu because libvirt is annoying? I don't see how adding yet another layer/daemon is going to improve ours and user's life (the

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-03-24 Thread Darryl L. Pierce
On Wed, Mar 24, 2010 at 04:41:23PM +0100, Paolo Bonzini wrote: On 03/24/2010 04:24 PM, Darryl L. Pierce wrote: On Wed, Mar 24, 2010 at 03:34:04PM +0100, Paolo Bonzini wrote: I'm still in the same state here. Shall I open a bug against libvirt regarding it not recognizing the --tftp-root

[libvirt] [PATCH] Strict check when listing domains

2010-03-24 Thread Eduardo Otubo
-- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index e4d67dc..f9a36a1 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@

[libvirt] ANNOUNCE: virt-manager 0.8.4 and virtinst 0.500.3

2010-03-24 Thread Cole Robinson
I'm happy to announce two new releases: virt-manager 0.8.4: virt-manager is a desktop application for managing KVM and Xen virtual machines via libvirt. virtinst 0.500.3: virtinst is a collection of command line tools for provisioning libvirt virtual machines, including virt-install and

Re: [libvirt] error: internal error canonical hostname pointed to localhost, but this is not allowed

2010-03-24 Thread Cole Robinson
On 03/24/2010 09:36 AM, Chris Lalancette wrote: On 03/23/2010 11:00 AM, Kenneth Nagin wrote: Changing qemudDomainMigratePrepare2 call to virGetHostnameLocalhost from: if ((hostname = virGetHostnameLocalhost(0)) == NULL) to: if ((hostname = virGetHostnameLocalhost(1)) == NULL) seems to fix

Re: [libvirt] error: internal error canonical hostname pointed to localhost, but this is not allowed

2010-03-24 Thread Chris Lalancette
On 03/24/2010 03:36 PM, Cole Robinson wrote: On 03/24/2010 09:36 AM, Chris Lalancette wrote: On 03/23/2010 11:00 AM, Kenneth Nagin wrote: Changing qemudDomainMigratePrepare2 call to virGetHostnameLocalhost from: if ((hostname = virGetHostnameLocalhost(0)) == NULL) to: if ((hostname =

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:42 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 12:42:16 +0200 Avi Kivitya...@redhat.com wrote: So, at best qemud is a toy for people who are annoyed by libvirt. Is the reason for doing this in qemu because libvirt is annoying? Mostly. I don't see how

Re: [libvirt] [PATCH] esx: Make the conf parser compare names case insensitive in VMX mode

2010-03-24 Thread Matthias Bolte
2010/3/24 Daniel Veillard veill...@redhat.com: On Wed, Mar 24, 2010 at 02:12:14AM +0100, Matthias Bolte wrote: The keys of entries in a VMX file are case insensitive. Both scsi0:1.fileName and scsi0:1.filename are valid. Therefore, make the conf parser compare names case insensitive in VMX

Re: [libvirt] [PATCH] vbox: Fix segfault on empty device source

2010-03-24 Thread Matthias Bolte
2010/3/24 Daniel Veillard veill...@redhat.com: On Wed, Mar 24, 2010 at 01:23:37AM +0100, Matthias Bolte wrote: 2010/3/22 Eric Blake ebl...@redhat.com: On 03/22/2010 02:40 PM, Matthias Bolte wrote: source file=''/ results in def-disks[i]-src == NULL. But vboxDomainDefineXML didn't check

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivity a...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 12:42:16 +0200 Avi Kivitya...@redhat.com wrote: So, at best qemud is a toy for people who are annoyed by libvirt. Is the reason for

[libvirt] [PATCH 1/1] Add disk error policy to domain XML

2010-03-24 Thread David Allan
--- docs/schemas/domain.rng | 12 +++- src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h | 10 ++ src/libvirt_private.syms |2 +- src/qemu/qemu_conf.c | 12 +--- tests/qemuhelptest.c |1 + tests/qemuxml2argvtest.c |3 +++

[libvirt] [PATCH 0/1] Disk error policy

2010-03-24 Thread David Allan
The following patch adds support for setting the disk error policy to the domain XML and using it when setting up the qemu command line. It specifies the werror=somepolicy,rerror=somepolicy flags to tell qemu what to do in the case of an io error. This patch is my first foray into the setup

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Anthony Liguori
On 03/24/2010 03:12 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivitya...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 12:42:16 +0200 Avi Kivitya...@redhat.com wrote: So, at best qemud is a toy for people

Re: [libvirt] [PATCH] tests: test-lib.sh portability and clean-up

2010-03-24 Thread Eric Blake
On 03/24/2010 02:40 AM, Jim Meyering wrote: No big deal, but I saw recent additions of test ... -a ... (not portable) so fixed the rest, too. Now, searching for violations shows none: git grep '\test .* -a ' Better would be git grep '\test .* -[ao] ' Whether it's possible to rely on

Re: [libvirt] [PATCH] build: suppress distracting build output

2010-03-24 Thread Eric Blake
On 03/24/2010 02:48 AM, Jim Meyering wrote: Not a problem, but let's eliminate the distraction. Here's a patch. With it, instead of the above if test... lines, you'll see this single line: GEN augeas-check ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 15:32:42 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/24/2010 03:12 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivitya...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 12:42:16

[libvirt] [PATCH 1/2] build: don't use test cond1 -o cond2: it's not portable

2010-03-24 Thread Eric Blake
* configure.ac: Use test cond1 || test cond2 instead. * m4/compiler-flags.m4 (gl_COMPILER_FLAGS): Likewise. * tests/test-lib.sh (verbose): Likewise. --- I guess this serves as an implicit ACK to the fact that you accidentally pushed your patches along the same lines. Is it worth reformatting any

[libvirt] [PATCH 2/2] maint: update syntax-check rule to also catch test's -o operator

2010-03-24 Thread Eric Blake
* cfg.mk (sc_prohibit_test_minus_a): Rename... (sc_prohibit_test_minus_ao): ...and flag '-o', too. --- cfg.mk |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index 4302338..27cfca4 100644 --- a/cfg.mk +++ b/cfg.mk @@ -269,11 +269,14 @@

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 21:54:09 +0100 Alexander Graf ag...@suse.de wrote: On 24.03.2010, at 21:32, Anthony Liguori wrote: On 03/24/2010 03:12 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivitya...@redhat.com wrote: On 03/24/2010 06:42 PM, Luiz Capitulino

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Anthony Liguori
On 03/24/2010 04:25 PM, Luiz Capitulino wrote: I see it as a related problem, because what seems to be under discussion is the quality of our interfaces with humans and tools. Also, when we were discussing the usuability problems I remember that you *WARNING: I might be wrong here, please

Re: [libvirt] [PATCH 1/6] Introduce a new virDomainUpdateDeviceFlags public API

2010-03-24 Thread Eric Blake
On 03/24/2010 05:46 AM, Daniel P. Berrange wrote: +++ b/src/libvirt.c @@ -1868,7 +1868,7 @@ error: * * Deprecated after 0.4.6. * Renamed to virDomainCreateXML() providing identical functionality. - * This existing name will left indefinitely for API compatability. + * This existing

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Jamie Lokier
Avi Kivity wrote: On 03/24/2010 02:32 PM, Anthony Liguori wrote: You don't get a directory filled with a zillion socket files pointing at dead guests. Agree that's a poor return on investment. Deleting it on atexit combined with flushing the whole directory at startup is a pretty

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Jamie Lokier
Anthony Liguori wrote: But the advantage is that if libvirt provided an API for a QMP transport encapsulated in their secure protocol, then provided the plumbed that API through their Python interface, you could use it for free in Python without having to reinvent the wheel. It's not free