Re: [libvirt] Documentation for synchronous hooks

2010-04-27 Thread Daniel Veillard
On Mon, Apr 26, 2010 at 08:42:12PM -0400, Jintao Yang wrote: hi DV, I saw the changelog of 0.7.8, which told the hooks scripts are supported. but is it took away in 0.8.0-4? [r...@dhcp-66-70 libvirt]# rpm -ql libvirt | grep etc /etc/libvirt /etc/libvirt/libvirtd.conf [...]

Re: [libvirt] [PATCH] cygwin: Handle differences in the XDR implementation

2010-04-27 Thread Matthias Bolte
2010/4/26 Eric Blake ebl...@redhat.com: On 04/25/2010 05:31 AM, Matthias Bolte wrote: Cygwin's XDR implementation defines xdr_u_int64_t instead of xdr_uint64_t and lacks IXDR_PUT_INT32/IXDR_GET_INT32. Would you mind reporting this upstream?  Charles Wilson on the cygwin list can probably fix

[libvirt] [PATCH] cygwin/mingw: Fix version script handling

2010-04-27 Thread Matthias Bolte
Let configure detect ld instead of hardcoding /usr/bin/ld, because MinGW may have ld in /bin. Only use a .def file to export symbols on MinGW. Cygwin's ld supports the normal .syms file used on Linux. --- configure.ac | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Matthias Bolte
2010/4/27 Stefan Berger stef...@us.ibm.com: libvir-list-boun...@redhat.com wrote on 04/26/2010 03:20:47 PM: static struct sigaction zero_sigaction = {0}; struct sigaction action_stop = zero_sigaction; action_stop.sa_handler = stop; But don't go changing this commit just for that

Re: [libvirt] [PATCH] desactivate lxc and qemu support on non-linux systems

2010-04-27 Thread Daniel Veillard
On Mon, Apr 26, 2010 at 08:44:29PM +0200, Matthias Bolte wrote: 2010/4/26 Eric Blake ebl...@redhat.com: On 04/26/2010 07:41 AM, Daniel Veillard wrote:   note that with_qemu is set to yes by default Daniel diff --git a/configure.ac b/configure.ac index 99bc906..d360b4e 100644 ---

Re: [libvirt] [PATCH] cygwin/mingw: Fix version script handling

2010-04-27 Thread Daniel Veillard
On Tue, Apr 27, 2010 at 10:01:41AM +0200, Matthias Bolte wrote: Let configure detect ld instead of hardcoding /usr/bin/ld, because MinGW may have ld in /bin. Only use a .def file to export symbols on MinGW. Cygwin's ld supports the normal .syms file used on Linux. --- configure.ac | 11

[libvirt] [PATCH] Fix build with DEBUG_RAW_IO=1

2010-04-27 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com --- src/qemu/qemu_monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) At the top of qemu_monitor.c the following lines can be seen: #define DEBUG_IO 0 #define DEBUG_RAW_IO 0 diff --git a/src/qemu/qemu_monitor.c

[libvirt] [PATCH] cleanup the download section

2010-04-27 Thread Daniel Veillard
Just removing reverences to the deprecated CVS server and the old git on et.redhat.com Daniel diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 493923c..a0cb6fc 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -43,19 +43,6 @@ a

[libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send to applications. However, when we ask qemu to stop the CPUs we are not

Re: [libvirt] [PATCH] Fix build with DEBUG_RAW_IO=1

2010-04-27 Thread Daniel Veillard
On Tue, Apr 27, 2010 at 10:39:54AM +0200, jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com --- src/qemu/qemu_monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) At the top of qemu_monitor.c the following lines can be seen: #define DEBUG_IO 0

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Daniel Veillard
On Tue, Apr 27, 2010 at 11:20:39AM +0200, jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 06:46:31PM -0400, Stefan Berger wrote: libvir-list-boun...@redhat.com wrote on 04/26/2010 03:20:47 PM: static struct sigaction zero_sigaction = {0}; struct sigaction action_stop = zero_sigaction; action_stop.sa_handler = stop; But don't go changing this

Re: [libvirt] [PATCH 1/1] Fix indentation for storage conf XML

2010-04-27 Thread Daniel Veillard
On Mon, Apr 26, 2010 at 06:06:31PM +0200, Daniel Veillard wrote: On Fri, Apr 23, 2010 at 11:09:01PM -0400, David Allan wrote: * virStorageEncryptionFormat is called from both virDomainDiskDefFormat and virStorageVolTargetDefFormat. The proper indentation in the generated XML depends on

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Jiri Denemark
With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send to applications. However, when we ask qemu to stop the CPUs we are not really interested in qemu event

Re: [libvirt] [PATCH] Fix build with DEBUG_RAW_IO=1

2010-04-27 Thread Jiri Denemark
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index c4f2725..38ee058 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -166,7 +166,7 @@ char *qemuMonitorEscapeShell(const char *in) } -#if QEMU_DEBUG_RAW_IO +#if DEBUG_RAW_IO # include

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Jiri Denemark
With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send to applications. However, when we ask qemu to stop the CPUs we are not really interested in qemu event

[libvirt] [PATCH v2] nwfilter: add support for RAPR protocol

2010-04-27 Thread Stefan Berger
This patch adds support for the RARP protocol. This may be needed due to qemu sending out a RARP packet (at least that's what it seems to want to do even though the protocol id is wrong) when migration finishes and we'd need a rule to let the packets pass. Unfortunately my installation of

Re: [libvirt] [PATCH v2] nwfilter: add support for RAPR protocol

2010-04-27 Thread Daniel Veillard
On Tue, Apr 27, 2010 at 07:00:26AM -0400, Stefan Berger wrote: This patch adds support for the RARP protocol. This may be needed due to qemu sending out a RARP packet (at least that's what it seems to want to do even though the protocol id is wrong) when migration finishes and we'd need a rule

Re: [libvirt] [PATCH v2] nwfilter: add support for RAPR protocol

2010-04-27 Thread Stefan Berger
Daniel Veillard veill...@redhat.com wrote on 04/27/2010 07:19:25 AM: Please respond to veillard On Tue, Apr 27, 2010 at 07:00:26AM -0400, Stefan Berger wrote: This patch adds support for the RARP protocol. This may be needed due to qemu sending out a RARP packet (at least that's what it

[libvirt] Compile v0.8.0 under fedora 12 / mingw

2010-04-27 Thread Dev.Atom
Hi there, I'm trying to compile the libvirt from git (today). I use these configure parameters : ./configure --prefix=/usr/i686-pc-mingw32/sys-root/mingw/ --host=i686-pc-mingw32 --without-xen --without-xen-inotify --without-umlt --without-openvz --without-phyp --without-xenapi --without-vbox

Re: [libvirt] [PATCH] cleanup the download section

2010-04-27 Thread Matthias Bolte
2010/4/27 Daniel Veillard veill...@redhat.com:  Just removing reverences to the deprecated CVS server and the old git on et.redhat.com Daniel diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 493923c..a0cb6fc 100644 --- a/docs/downloads.html.in +++

Re: [libvirt] [PATCH] cleanup the download section

2010-04-27 Thread Daniel Veillard
On Tue, Apr 27, 2010 at 02:07:42PM +0200, Matthias Bolte wrote: 2010/4/27 Daniel Veillard veill...@redhat.com:  Just removing reverences to the deprecated CVS server and the old git on et.redhat.com Daniel diff --git a/docs/downloads.html.in b/docs/downloads.html.in index

Re: [libvirt] [PATCH 1/8] Fix up the locking in the snapshot code.

2010-04-27 Thread Daniel Veillard
On Fri, Apr 23, 2010 at 01:27:45PM -0400, Chris Lalancette wrote: In particular I was forgetting to take the qemuMonitorPrivatePtr lock (via qemuDomainObjBeginJob), which would cause problems if two users tried to access the same domain at the same time. This patch also fixes a problem where I

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Stefan Berger
Matthias Bolte matthias.bo...@googlemail.com wrote on 04/27/2010 04:03:54 AM: 2010/4/27 Stefan Berger stef...@us.ibm.com: [...] I just pushed a patch to fix this. Got the git update now and your build fix. virsh works for me. I tested it with a connection to a remote libvirtd using

[libvirt] Q of Libvirt and Xen

2010-04-27 Thread ศุภฤกษ์ . . . ฉัตรธนโชติ . . .
Hi ! sir I'm newbie of xen and libvirt. I'm practice use libvirt API for control xen on CenOS 5.4 using C language. How can I learn it. I can't found a simple C file for testing libvirt and xen. please suggest me for How can I using libvirt for control xen with C and May I have a example code

Re: [libvirt] [kl...@ethgen.de: [Pkg-libvirt-maintainers] Bug#579208: USB Class/Number/... is base 16, not base 10 (Failed to convert 'ff' to unsigned int)]

2010-04-27 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Am Mo den 26. Apr 2010 um 18:26 schrieb Eric Blake: Is there documentation somewhere that mentions what base the udev strings are encoded in? A short look to the code: drivers/usb/core/sysfs.c: usb_descriptor_attr(bDeviceClass, %02x\n)

[libvirt] [PATCH] Use a new directory for dnsmasq files

2010-04-27 Thread Daniel Veillard
On Mon, Apr 26, 2010 at 05:29:02PM +0200, Daniel Veillard wrote: On Sat, Apr 24, 2010 at 04:46:33AM +0900, Satoru SATOH wrote: As far as I tested, it works as expected and not aware of any critical issues. So if you're ok, I want to get it merge in. Okay, after Jim's thorough review and

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Eric Blake
On 04/27/2010 07:00 AM, Stefan Berger wrote: virsh works for me. I tested it with a connection to a remote libvirtd using a plain unencrypted TCP connection: virsh -c qemu+tcp://server/system Not the same luck here. I still see it aborting. Also the 'make check' test-poll doesn't succeed

Re: [libvirt] [PATCH] Use a new directory for dnsmasq files

2010-04-27 Thread Eric Blake
On 04/27/2010 07:51 AM, Daniel Veillard wrote: Move dnsmasq host file to a separate directory use /var/lib/libvirt/dnsmasq since /var/lib/libvirt/network is unreadable by the dnsmasq binary * src/network/bridge_driver.c: update DNSMASQ_STATE_DIR * src/Makefile.am: create it on make

Re: [libvirt] [PATCH 1/8] Fix up the locking in the snapshot code.

2010-04-27 Thread Chris Lalancette
On 04/27/2010 08:26 AM, Daniel Veillard wrote: On Fri, Apr 23, 2010 at 01:27:45PM -0400, Chris Lalancette wrote: In particular I was forgetting to take the qemuMonitorPrivatePtr lock (via qemuDomainObjBeginJob), which would cause problems if two users tried to access the same domain at the

Re: [libvirt] [PATCH 4/8] Fix up the error message if we can't parse the snapshot XML.

2010-04-27 Thread Chris Lalancette
On 04/23/2010 02:06 PM, Matthias Bolte wrote: 2010/4/23 Chris Lalancette clala...@redhat.com: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/conf/domain_conf.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH] maint: update to latest gnulib

2010-04-27 Thread Eric Blake
* cfg.mk (gnulib_dir): Override default in maint.mk. * .gnulib: Update to latest. Reported by Jim Meyering. --- Update to the latest gnulib for some portability fixes. Thankfully, we already pass all of the new syntax checks, but Jim did note (on the gnulib list) that we failed to define

Re: [libvirt] [PATCH] maint: update to latest gnulib

2010-04-27 Thread Jim Meyering
Eric Blake wrote: * cfg.mk (gnulib_dir): Override default in maint.mk. * .gnulib: Update to latest. Reported by Jim Meyering. --- Update to the latest gnulib for some portability fixes. Thankfully, we already pass all of the new syntax checks, but Jim did note (on the gnulib list) that we

[libvirt] new NULL-dereference in qemu_driver.c

2010-04-27 Thread Jim Meyering
I ran clang on the very latest and it spotted this problem: From qemu_driver.c, around line 11100, else { /* qemu is a little funny with running guests and the restoration * of snapshots. If the snapshot was taken online, * then after a loadvm monitor command, the

Re: [libvirt] new NULL-dereference in qemu_driver.c

2010-04-27 Thread Daniel P. Berrange
On Tue, Apr 27, 2010 at 06:45:16PM +0200, Jim Meyering wrote: I ran clang on the very latest and it spotted this problem: From qemu_driver.c, around line 11100, else { /* qemu is a little funny with running guests and the restoration * of snapshots. If the snapshot was

[libvirt] using clang

2010-04-27 Thread Jim Meyering
Some people have expressed an interest in setting up a libvirt autobuilder using clang. If you do that, be aware that you'll see an ugly looking NULL-deref problem when using the clang that comes with F12 or F13, but if you're using a new enough version (rawhide), it's gone. The offending code

Re: [libvirt] [kl...@ethgen.de: [Pkg-libvirt-maintainers] Bug#579208: USB Class/Number/... is base 16, not base 10 (Failed to convert 'ff' to unsigned int)]

2010-04-27 Thread Guido Günther
On Mon, Apr 26, 2010 at 11:26:51AM -0600, Eric Blake wrote: On 04/26/2010 11:11 AM, Guido Günther wrote: Hi, this patch from Klau Ethgen looks right to me. O.k. to apply? I'll remove the comment with this patch then. Is there documentation somewhere that mentions what base the udev

Re: [libvirt] [PATCH] nwfilter: let qemu's after-migration packet pass

2010-04-27 Thread Eric Blake
On 04/27/2010 10:03 AM, Stefan Berger wrote: Qemu currently sends an Ethernet packet with protocol id 0x835 once a VM was successfully migrated. The content of the packet looks like a gratuitous RARP, just with the wrong protocol ID, which should be 0x8035. Have you reported this upstream to

Re: [libvirt] [PATCH] nwfilter: add support for RAPR protocol

2010-04-27 Thread Eric Blake
On 04/23/2010 09:02 PM, Stefan Berger wrote: This patch adds support for the RARP protocol. This may be needed due to qemu sending out a RARP packet (at least that's what it seems to want to do even though the protocol id is wrong) when migration finishes and we'd need a rule to let the

Re: [libvirt] nwfilter: add test case for RARP protocol

2010-04-27 Thread Eric Blake
On 04/23/2010 09:02 PM, Stefan Berger wrote: This patch adds a test case for the RARP protocol. Signed-off-by: Stefan Berger stef...@us.ibm.com --- tests/nwfilterxml2xmlin/rarp-test.xml | 33 + tests/nwfilterxml2xmlout/rarp-test.xml | 18

Re: [libvirt] [PATCH 4/8] Fix up the error message if we can't parse the snapshot XML.

2010-04-27 Thread Matthias Bolte
2010/4/27 Chris Lalancette clala...@redhat.com: On 04/23/2010 02:06 PM, Matthias Bolte wrote: 2010/4/23 Chris Lalancette clala...@redhat.com: Signed-off-by: Chris Lalancette clala...@redhat.com ---  src/conf/domain_conf.c |    3 +--  1 files changed, 1 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH 4/8] Fix up the error message if we can't parse the snapshot XML.

2010-04-27 Thread Chris Lalancette
On 04/27/2010 02:08 PM, Matthias Bolte wrote: XML description for %s is not well formed or invalid Ah, sorry. I missed the fact that VIR_ERR_XML_ERROR results in this format string. I'm fine with the original patch then. ACK. If you grep the codebase for VIR_ERR_XML_ERROR then you'll

Re: [libvirt] [PATCH] nwfilter: let qemu's after-migration packet pass

2010-04-27 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 04/27/2010 01:51:09 PM: On 04/27/2010 10:03 AM, Stefan Berger wrote: Qemu currently sends an Ethernet packet with protocol id 0x835 once a VM was successfully migrated. The content of the packet looks like a gratuitous RARP, just with the wrong

Re: [libvirt] using clang

2010-04-27 Thread Daniel P. Berrange
On Tue, Apr 27, 2010 at 07:05:44PM +0200, Jim Meyering wrote: Some people have expressed an interest in setting up a libvirt autobuilder using clang. If you do that, be aware that you'll see an ugly looking NULL-deref problem when using the clang that comes with F12 or F13, but if you're

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 11:20:39 +0200 jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send to

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Daniel P. Berrange
On Tue, Apr 27, 2010 at 03:50:20PM -0300, Luiz Capitulino wrote: On Tue, 27 Apr 2010 11:20:39 +0200 jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 20:01:06 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Tue, Apr 27, 2010 at 03:50:20PM -0300, Luiz Capitulino wrote: On Tue, 27 Apr 2010 11:20:39 +0200 jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get

[libvirt] [PATCH 0/5]: Add a API for query domain disk sizing info

2010-04-27 Thread Daniel P. Berrange
This is somewhat late for the 0.8.1 release, but this is a rather critical API for some of the use cases of RHEV. It introduces a new API against a virDomainPtr to allow the direct querying of the size of guest block devices. This is modelled on the virStorageVol API for getting size, so I'm

[libvirt] [PATCH 1/5] Add virDomainGetBlockInfo API to query disk sizing

2010-04-27 Thread Daniel P. Berrange
Some applications need to be able to query a guest's disk info, even for paths not managed by the storage pool APIs. This adds a very simple API to get this information, modelled on the virStorageVolGetInfo API, but with an extra field 'physical'. Normally 'physical' and 'allocation' will be

[libvirt] [PATCH 2/5] Internal driver API infrastructure for virDomainGetBlockInfo

2010-04-27 Thread Daniel P. Berrange
This defines the internal driver API and stubs out each driver * src/driver.h: Define virDrvDomainGetBlockInfo signature * src/libvirt.c, src/libvirt_public.syms: Glue public API to drivers * src/esx/esx_driver.c, src/lxc/lxc_driver.c, src/opennebula/one_driver.c, src/openvz/openvz_driver.c,

[libvirt] [PATCH 4/5] Implement virDomainGetBlockInfo in QEMU driver

2010-04-27 Thread Daniel P. Berrange
* src/qemu/qemu_driver.c: Implementation of virDomainGetBlockInfo * src/util/storage_file.h: Add DEV_BSIZE * src/storage/storage_backend.c: Remove DEV_BSIZE --- src/qemu/qemu_driver.c| 116 + src/storage/storage_backend.c |4 --

[libvirt] [PATCH 5/5] Add new domblkinfo command to virsh

2010-04-27 Thread Daniel P. Berrange
virsh # domblkinfo demoguest /dev/hda2 Capacity: 1048576000 Allocation: 104857600 Physical: 104857600 * tools/virsh.c: Implement domblkinfo command mapping to the new virDomainGetBlockInfo API --- tools/virsh.c | 48 1

[libvirt] [PATCH 3/5] Remote protocol impl for virDomainGetBlockInfo

2010-04-27 Thread Daniel P. Berrange
* daemon/remote.c: Server side dispatcher * daemon/remote_dispatch_args.h, daemon/remote_dispatch_prototypes.h, daemon/remote_dispatch_ret.h, daemon/remote_dispatch_table.h: Update with new API * src/remote/remote_driver.c: Client side dispatcher * src/remote/remote_protocol.c,

[libvirt] [PATCH] qemudDomainCreate: correct a slightly misdirected goto

2010-04-27 Thread Jim Meyering
I was looking at other uses of qemuDomainObjEndJob and saw this: From f8ccc44e7890c1b2ae2ebc266ca5d6215fe9c80d Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 27 Apr 2010 22:16:02 +0200 Subject: [PATCH] qemudDomainCreate: correct a slightly misdirected goto *

Re: [libvirt] [PATCH 06/10] Qemu Monitor API entry point.

2010-04-27 Thread Chris Lalancette
On 04/22/2010 08:27 AM, Daniel P. Berrange wrote: --- a/src/Makefile.am +++ b/src/Makefile.am @@ -32,7 +32,7 @@ if WITH_NETWORK UUID=$(shell uuidgen 2/dev/null) endif -lib_LTLIBRARIES = libvirt.la +lib_LTLIBRARIES = libvirt.la libvirt-qemu.la moddir = $(libdir)/libvirt/drivers

Re: [libvirt] [PATCH] qemudDomainCreate: correct a slightly misdirected goto

2010-04-27 Thread Eric Blake
On 04/27/2010 02:17 PM, Jim Meyering wrote: I was looking at other uses of qemuDomainObjEndJob and saw this: From f8ccc44e7890c1b2ae2ebc266ca5d6215fe9c80d Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 27 Apr 2010 22:16:02 +0200 Subject: [PATCH]

Re: [libvirt] [PATCH 06/10] Qemu Monitor API entry point.

2010-04-27 Thread Daniel P. Berrange
On Tue, Apr 27, 2010 at 04:16:15PM -0400, Chris Lalancette wrote: On 04/22/2010 08:27 AM, Daniel P. Berrange wrote: --- a/src/Makefile.am +++ b/src/Makefile.am @@ -32,7 +32,7 @@ if WITH_NETWORK UUID=$(shell uuidgen 2/dev/null) endif -lib_LTLIBRARIES = libvirt.la

Re: [libvirt] new NULL-dereference in qemu_driver.c

2010-04-27 Thread Jim Meyering
Daniel P. Berrange wrote: On Tue, Apr 27, 2010 at 06:45:16PM +0200, Jim Meyering wrote: I ran clang on the very latest and it spotted this problem: From qemu_driver.c, around line 11100, else { /* qemu is a little funny with running guests and the restoration * of

[libvirt] [PATCH] build: fix autogen rule for VPATH build

2010-04-27 Thread Eric Blake
* cfg.mk (gnulib_srcdir): Override maint.mk default. (_update_required): Run in correct directory. --- I noticed an error message about bootstrap.conf not found when trying to do a VPATH build for my new clang setup. This subsumes up my earlier patch to declare the correct gnulib_srcdir, as

[libvirt] [PATCH 2/2] build: fix python in VPATH build

2010-04-27 Thread Eric Blake
Match the fact that docs/Makefile.am dumps libvirt-api.xml in the build dir, not the source dir. * python/Makefile.am (API_DESC): Point make to the builddir for .xml files. * python/generator.py (buildStubs): Output in correct location. --- This was the only other thing getting in the way of a

Re: [libvirt] [PATCH 06/10] Qemu Monitor API entry point.

2010-04-27 Thread Chris Lalancette
On 04/27/2010 04:25 PM, Daniel P. Berrange wrote: Causes the build to fail when linking virsh: CCLD virsh ../src/.libs/libvirt-qemu.so: undefined reference to `qemuMonitorCommand' collect2: ld returned 1 exit status Indeed, if I nm src/.libs/libvirt-qemu.so: [clala...@localhost

Re: [libvirt] new NULL-dereference in qemu_driver.c

2010-04-27 Thread Chris Lalancette
On 04/27/2010 04:40 PM, Jim Meyering wrote: Daniel P. Berrange wrote: On Tue, Apr 27, 2010 at 06:45:16PM +0200, Jim Meyering wrote: I ran clang on the very latest and it spotted this problem: From qemu_driver.c, around line 11100, else { /* qemu is a little funny with running

Re: [libvirt] [PATCH 2/5] Internal driver API infrastructure for virDomainGetBlockInfo

2010-04-27 Thread Eric Blake
On 04/27/2010 01:34 PM, Daniel P. Berrange wrote: This defines the internal driver API and stubs out each driver * src/driver.h: Define virDrvDomainGetBlockInfo signature * src/libvirt.c, src/libvirt_public.syms: Glue public API to drivers * src/esx/esx_driver.c, src/lxc/lxc_driver.c,

Re: [libvirt] [PATCH 3/5] Remote protocol impl for virDomainGetBlockInfo

2010-04-27 Thread Eric Blake
On 04/27/2010 01:35 PM, Daniel P. Berrange wrote: * daemon/remote.c: Server side dispatcher * daemon/remote_dispatch_args.h, daemon/remote_dispatch_prototypes.h, daemon/remote_dispatch_ret.h, daemon/remote_dispatch_table.h: Update with new API * src/remote/remote_driver.c: Client side

Re: [libvirt] [PATCH 4/5] Implement virDomainGetBlockInfo in QEMU driver

2010-04-27 Thread Eric Blake
On 04/27/2010 01:35 PM, Daniel P. Berrange wrote: * src/qemu/qemu_driver.c: Implementation of virDomainGetBlockInfo * src/util/storage_file.h: Add DEV_BSIZE * src/storage/storage_backend.c: Remove DEV_BSIZE +if (S_ISREG(sb.st_mode)) { +#ifndef __MINGW32__ +info-physical =

Re: [libvirt] [PATCH 5/5] Add new domblkinfo command to virsh

2010-04-27 Thread Eric Blake
On 04/27/2010 01:35 PM, Daniel P. Berrange wrote: virsh # domblkinfo demoguest /dev/hda2 Capacity: 1048576000 Allocation: 104857600 Physical: 104857600 * tools/virsh.c: Implement domblkinfo command mapping to the new virDomainGetBlockInfo API And the changes to

[libvirt] [PATCH] nwfilter: allow to mix filterrefs and rules in the schema

2010-04-27 Thread Stefan Berger
So far the references to other filters needed to appear before filtering rules. With the below patch they can now appear in any order. Also I forgot to add a couple of 'rarp's. Signed-off-by: Stefan Berger stef...@us.ibm.com --- docs/schemas/nwfilter.rng | 472