Re: [libvirt] Release of libvirt-0.8.7

2011-01-04 Thread Justin Clift
On 04/01/2011, at 2:32 PM, Daniel Veillard wrote: The New Year gift just arrived :-) As expected I made the release this morning, it is available as usual at: ftp://libvirt.org/libvirt/libvirt-0.8.7.tar.gz Cool. :) Due to specific condition (without my workstation and networking

Re: [libvirt] fork of php-libvirt

2011-01-04 Thread Justin Clift
On 30/12/2010, at 12:03 AM, Radek Hladik wrote: Dne 29.12.2010 8:00, Lyre napsal(a): I've added many APIs to php-libvirt, including network, node device, interface, and snapshot support. Unfortunately, I wasn't able to contact original author Radek, I really hope he can see this. So I

Re: [libvirt] virsh help keywords vs. command prefixes

2011-01-04 Thread Justin Clift
On 04/01/2011, at 7:10 AM, Paul Jenner wrote: Hi all. From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match the virsh command prefixes where they exist. For example help nwfilter would tell me about

Re: [libvirt] virsh + ssh

2011-01-04 Thread Justin Clift
On 01/01/2011, at 9:38 PM, Daniel Huhardeaux wrote: Hi, connecting to a remote server using qemu+ssh is always done with root user. The problem we face is that we don't allow root connection for ssh. Would it be possible to launch sudo on the remote server so we could connect with the

Re: [libvirt] [PATCH] build: avoid 'make syntax-check' failure

2011-01-04 Thread Justin Clift
On 04/01/2011, at 3:27 AM, Eric Blake wrote: * cfg.mk (local-checks-to-skip): Add sc_copyright_check, since we don't use version-etc module. --- This is the simpler variant that avoids a .gnulib update. While gnulib has had a lot of recent fixes, most of them have been for HP-UX, Solaris,

Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

2011-01-04 Thread Justin Clift
On 04/01/2011, at 12:11 AM, Laine Stump wrote: On 01/03/2011 04:19 AM, Jiri Denemark wrote: @@ -715,7 +715,7 @@ brDelInetAddress(brControl *ctl ATTRIBUTE_UNUSED, virSocketAddr *addr, unsigned int prefix) { -virCommandPtr cmd; +virCommandPtr

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-04 Thread Neil Wilson
On Mon, 2011-01-03 at 09:19 -0500, Stefan Berger wrote: One issue is probably around migration and the server (qemu-referenced) x509 certificates. If the certificates are embedded (rather than referenced) in the domain XML they will automatically migrate when the VM migrates, which is

Re: [libvirt] virsh help keywords vs. command prefixes

2011-01-04 Thread Osier Yang
于 2011年01月04日 16:51, Justin Clift 写道: On 04/01/2011, at 7:10 AM, Paul Jenner wrote: Hi all. From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match the virsh command prefixes where they exist. For

Re: [libvirt] announce mailing list

2011-01-04 Thread Zdenek Styblik
On 01/04/2011 10:02 AM, Justin Clift wrote: On 03/01/2011, at 12:49 AM, Zdenek Styblik wrote: On 01/02/2011 02:41 PM, Daniel Veillard wrote: On Sun, Jan 02, 2011 at 09:03:28AM +0100, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, not a long time ago there was

Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

2011-01-04 Thread Osier Yang
于 2011年01月04日 17:13, Justin Clift 写道: On 04/01/2011, at 12:11 AM, Laine Stump wrote: On 01/03/2011 04:19 AM, Jiri Denemark wrote: @@ -715,7 +715,7 @@ brDelInetAddress(brControl *ctl ATTRIBUTE_UNUSED, virSocketAddr *addr, unsigned int prefix) { -

Re: [libvirt] announce mailing list

2011-01-04 Thread Justin Clift
On 03/01/2011, at 12:49 AM, Zdenek Styblik wrote: On 01/02/2011 02:41 PM, Daniel Veillard wrote: On Sun, Jan 02, 2011 at 09:03:28AM +0100, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, not a long time ago there was information about announce mailing list. One

Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

2011-01-04 Thread Jiri Denemark
I always build with --enable-compile-warnings=error so any compiler warning results in build failure. No special options beyond that. Right. I do that too, and never saw an error. Your compiler must be warning on more things than mine. Here's my build commandline (copied from Jim nearly

Re: [libvirt] [PATCH] Support for qemu aio drive option

2011-01-04 Thread Chris Lalancette
On 01/03/11 - 04:43:06PM, Eric Blake wrote: On 05/17/2010 03:31 PM, Eric Blake wrote: [adding Matthias on cc] Reviving an old thread, as it is something I plan on working in the near future. On 05/17/2010 03:07 PM, Chris Lalancette wrote: On 05/12/2010 11:26 PM, Eric Blake wrote:

Re: [libvirt] adding smartcard support to libvirt

2011-01-04 Thread Alon Levy
On Mon, Jan 03, 2011 at 11:50:18AM -0700, Eric Blake wrote: [adding the public list for feedback on new XML. Background: Alon is working on adding some new command line arguments to qemu to make it possible to share smartcard access between a host and its virtual guests; while this is not

Re: [libvirt] [PATCH] build: avoid 'make syntax-check' failure

2011-01-04 Thread Daniel Veillard
On Mon, Jan 03, 2011 at 09:27:58AM -0700, Eric Blake wrote: * cfg.mk (local-checks-to-skip): Add sc_copyright_check, since we don't use version-etc module. --- This is the simpler variant that avoids a .gnulib update. While gnulib has had a lot of recent fixes, most of them have been for

[libvirt] [PATCH] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Stefan Berger
While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek() to the end of the Qemu VM's log file failing. The patch below replaces the two occurrences of lseek() in the relevant path with lseek64() and solves this

Re: [libvirt] [PATCH] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 01/04/2011 09:46:07 AM: While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek() to the end of the Qemu VM's log file failing. The patch below replaces the two

Re: [libvirt] [PATCH] build: avoid 'make syntax-check' failure

2011-01-04 Thread Eric Blake
On 01/04/2011 02:08 AM, Justin Clift wrote: On 04/01/2011, at 3:27 AM, Eric Blake wrote: * cfg.mk (local-checks-to-skip): Add sc_copyright_check, since we don't use version-etc module. --- This is the simpler variant that avoids a .gnulib update. While gnulib has had a lot of recent fixes,

Re: [libvirt] [PATCH 2/2] Cancel migration/dump if user presses Ctrl-C when migration/dump is in progress

2011-01-04 Thread Daniel P. Berrange
On Thu, Dec 23, 2010 at 05:07:34PM +0800, Hu Tao wrote: --- src/remote/remote_driver.c |2 +- tools/virsh.c | 126 ++-- 2 files changed, 110 insertions(+), 18 deletions(-) diff --git a/src/remote/remote_driver.c

Re: [libvirt] Release of libvirt-0.8.7

2011-01-04 Thread Eric Blake
On 01/03/2011 08:32 PM, Daniel Veillard wrote: The New Year gift just arrived :-) As expected I made the release this morning, it is available as usual at: ftp://libvirt.org/libvirt/libvirt-0.8.7.tar.gz Due to specific condition (without my workstation and networking troubles) the

Re: [libvirt] [PATCH] docs: Add additional indentation to level 3 menu items

2011-01-04 Thread Daniel P. Berrange
On Fri, Dec 17, 2010 at 10:13:07PM +0100, Matthias Bolte wrote: formatnetwork.html has a menu item at level 3. libvirt.css doesn't have a explicit rule for level 3 and level 3 and level 2 items end up at the same indentation level. Add an additional 1em indentation to level 3 menu items. No

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-04 Thread Daniel P. Berrange
On Fri, Dec 24, 2010 at 10:31:20AM +0800, Osier Yang wrote: Add VM name/UUID in log for domain related APIs. Format: param0=%p, param1=%p, (VM: %s) * src/libvirt.c --- src/libvirt.c | 293 +++-- 1 files changed, 220 insertions(+), 73

Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

2011-01-04 Thread Laine Stump
On 01/04/2011 06:37 AM, Jiri Denemark wrote: I noticed you don't have -O2 in your CFLAGS, which might be the issue here. While -g is much better than -g -O2 when you actually start debugging, gcc does not issue some warnings when it compiles without optimizations :-( That probably explains

Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

2011-01-04 Thread Laine Stump
On 01/04/2011 04:24 AM, Osier Yang wrote: 于 2011年01月04日 17:13, Justin Clift 写道: On 04/01/2011, at 12:11 AM, Laine Stump wrote: On 01/03/2011 04:19 AM, Jiri Denemark wrote: @@ -715,7 +715,7 @@ brDelInetAddress(brControl *ctl ATTRIBUTE_UNUSED, virSocketAddr *addr,

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-04 Thread Osier Yang
于 2011年01月04日 23:30, Daniel P. Berrange 写道: On Fri, Dec 24, 2010 at 10:31:20AM +0800, Osier Yang wrote: Add VM name/UUID in log for domain related APIs. Format: param0=%p, param1=%p, (VM: %s) * src/libvirt.c --- src/libvirt.c | 293 +++--

Re: [libvirt] [PATCH 11/13] Update iptables.c to also support ip6tables.

2011-01-04 Thread Daniel P. Berrange
On Mon, Dec 20, 2010 at 03:03:23AM -0500, Laine Stump wrote: All of the iptables functions eventually call down to a single bottom-level function, and fortunately, ip6tables syntax (for all the args that we use) is identical to iptables format (except the addresses), so all we need to do is:

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-04 Thread Eric Blake
On 01/04/2011 08:30 AM, Daniel P. Berrange wrote: virDomainGetConnect (virDomainPtr dom) { -DEBUG(dom=%p, dom); +const char *name = virDomainGetName(dom); + +DEBUG(dom=%p, (VM: %s), dom, NULLSTR(name)); Calling virDomainGetName() which is also a public API will pollute the

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-04 Thread Osier Yang
于 2011年01月04日 23:51, Eric Blake 写道: On 01/04/2011 08:30 AM, Daniel P. Berrange wrote: virDomainGetConnect (virDomainPtr dom) { -DEBUG(dom=%p, dom); +const char *name = virDomainGetName(dom); + +DEBUG(dom=%p, (VM: %s), dom, NULLSTR(name)); Calling virDomainGetName() which is

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-04 Thread Daniel P. Berrange
On Tue, Dec 21, 2010 at 09:47:10PM -0700, Eric Blake wrote: On 12/21/2010 03:40 PM, Paweł Krześniak wrote: By default dnsmasq is spawned with option --conf-file= which disables reading of global configuration file -- this is fine for most situations. In fact, the libvirt policy is that it

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-04 Thread Daniel P. Berrange
On Thu, Dec 23, 2010 at 09:53:57AM -0700, Eric Blake wrote: On 12/23/2010 06:50 AM, Paweł Krześniak wrote: On Wed, Dec 22, 2010 at 16:50, Laine Stump la...@laine.org wrote: I agree with Eric that this should be discussed with Dan Berrange and/or Daniel Veillard before comitting anything to

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-04 Thread Daniel P. Berrange
On Wed, Dec 22, 2010 at 10:09:54AM +0100, Paweł Krześniak wrote: 2010/12/22 Eric Blake ebl...@redhat.com: On 12/21/2010 03:40 PM, Paweł Krześniak wrote: This patch adds possibility to run customized DNS/DHCP environment, by spawning dnsmasq with alternative configuration file if such file

Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

2011-01-04 Thread Daniel P. Berrange
On Mon, Jan 03, 2011 at 08:11:57AM -0500, Laine Stump wrote: On 01/03/2011 04:19 AM, Jiri Denemark wrote: @@ -715,7 +715,7 @@ brDelInetAddress(brControl *ctl ATTRIBUTE_UNUSED, virSocketAddr *addr, unsigned int prefix) { -virCommandPtr cmd; +

Re: [libvirt] [PATCH] Support ipv[46]routing network parameters

2011-01-04 Thread Daniel P. Berrange
On Mon, Dec 27, 2010 at 06:44:23PM +0100, Paweł Krześniak wrote: Support for optional parameters ipv[46]routing in XML network definition. These parameters allows to set up alternative binary or script to be run during network start. Such customization allows to run additional services for

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-04 Thread Daniel P. Berrange
On Wed, Dec 29, 2010 at 04:45:26PM +, Neil Wilson wrote: Hi, At the moment SASL VNC authentication in libvirt allows any of the userids to access any of the VNC consoles on a particular libvirt host. There is a section in the qemu_command code marked TODO: Support ACLs later and we

Re: [libvirt] [PATCH] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Eric Blake
[hmm, are you aware that messages from you are adding a cc to libvir-list-bounces?] On 01/04/2011 08:02 AM, Stefan Berger wrote: While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek() to the end of the Qemu

Re: [libvirt] [PATCH] Support for qemu aio drive option

2011-01-04 Thread Daniel P. Berrange
On Tue, Jan 04, 2011 at 08:12:21AM -0500, Chris Lalancette wrote: On 01/03/11 - 04:43:06PM, Eric Blake wrote: On 05/17/2010 03:31 PM, Eric Blake wrote: [adding Matthias on cc] Reviving an old thread, as it is something I plan on working in the near future. On 05/17/2010

Re: [libvirt] [PATCH] Support for qemu aio drive option

2011-01-04 Thread Eric Blake
On 01/04/2011 09:33 AM, Daniel P. Berrange wrote: Does this deserve a new iobackend element, or should it merely be a new optional attribute of the existing driver element, as in: driver name='qemu' type='qcow2' cache='none' iobackend='aiothreads'/ I slightly prefer making it a new attribute

[libvirt] [PATCH v2] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Stefan Berger
V2: - removed replacements of lseek() to lseek64() from patch While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek() to the end of the Qemu VM's log file failing. The patch below fixes the problem by

Re: [libvirt] [PATCH v2] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Eric Blake
On 01/04/2011 09:43 AM, Stefan Berger wrote: V2: - removed replacements of lseek() to lseek64() from patch While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek() to the end of the Qemu VM's log file

Re: [libvirt] [PATCH 11/13] Update iptables.c to also support ip6tables.

2011-01-04 Thread Laine Stump
On 01/04/2011 10:48 AM, Daniel P. Berrange wrote: @@ -735,6 +765,7 @@ iptablesForwardMasquerade(iptablesContext *ctx, if (protocol protocol[0]) { if (physdev physdev[0]) { ret = iptablesAddRemoveRule(ctx-nat_postrouting, +

Re: [libvirt] [PATCH v2] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Daniel P. Berrange
On Tue, Jan 04, 2011 at 10:16:54AM -0700, Eric Blake wrote: On 01/04/2011 09:43 AM, Stefan Berger wrote: V2: - removed replacements of lseek() to lseek64() from patch While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start

Re: [libvirt] virsh + ssh

2011-01-04 Thread Eric Blake
[forwarding back to the list, in case this helps anyone else] On 01/04/2011 10:24 AM, Eric Blake wrote: On 01/04/2011 10:13 AM, Daniel Huhardeaux wrote: My problem was that I wanted to do it with virt-manager which only connect using URI qemu+ssh://r...@remote/system :-( virt-manager lets

Re: [libvirt] [PATCH v2] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Eric Blake
On 01/04/2011 10:22 AM, Daniel P. Berrange wrote: On Tue, Jan 04, 2011 at 10:16:54AM -0700, Eric Blake wrote: On 01/04/2011 09:43 AM, Stefan Berger wrote: V2: - removed replacements of lseek() to lseek64() from patch While doing some testing with Qemu and creating huge logfiles I

Re: [libvirt] virsh + ssh

2011-01-04 Thread Daniel Huhardeaux
Eric sorry for private mail, I tought libvirt-list was the To. Le 04/01/2011 18:13, Daniel Huhardeaux a écrit : Hi all Le 03/01/2011 22:32, Eric Blake a écrit : On 01/01/2011 03:38 AM, Daniel Huhardeaux wrote: Hi, connecting to a remote server using qemu+ssh is always done with root user.

Re: [libvirt] virsh + ssh

2011-01-04 Thread Daniel Huhardeaux
Le 04/01/2011 18:24, Eric Blake a écrit : On 01/04/2011 10:13 AM, Daniel Huhardeaux wrote: My problem was that I wanted to do it with virt-manager which only connect using URI qemu+ssh://r...@remote/system :-( virt-manager lets you add a new connection and specify the username. On

[libvirt] hypervisor feature - hardware assisted paging

2011-01-04 Thread Jim Fehlig
I'm looking into a bug where a libvirt-created xen HVM guest boots *very* slowly on an EPT-enabled machine, particularly when the guest has a dedicated PCI device. xen-unstable c/s 16931 [1] introduced a per-guest HAP (hardware assisted paging) setting. Unfortunately, the sane default of hap=1

Re: [libvirt] Release of libvirt-0.8.7

2011-01-04 Thread Justin Clift
On 04/01/2011, at 2:32 PM, Daniel Veillard wrote: The New Year gift just arrived :-) As expected I made the release this morning, it is available as usual at: ftp://libvirt.org/libvirt/libvirt-0.8.7.tar.gz 0.8.7 is now available through Homebrew on MacOS X too. -- libvir-list mailing

Re: [libvirt] [PATCH v2] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Stefan Berger
On 01/04/2011 12:16 PM, Eric Blake wrote: On 01/04/2011 09:43 AM, Stefan Berger wrote: V2: - removed replacements of lseek() to lseek64() from patch While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek()

Re: [libvirt] Release of libvirt-0.8.7

2011-01-04 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/04/11 18:44, Justin Clift wrote: On 04/01/2011, at 2:32 PM, Daniel Veillard wrote: The New Year gift just arrived :-) As expected I made the release this morning, it is available as usual at:

Re: [libvirt] Release of libvirt-0.8.7

2011-01-04 Thread Justin Clift
On 05/01/2011, at 5:19 AM, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/04/11 18:44, Justin Clift wrote: On 04/01/2011, at 2:32 PM, Daniel Veillard wrote: The New Year gift just arrived :-) As expected I made the release this morning, it is available as

Re: [libvirt] [PATCH] esx: Add domain autostart support

2011-01-04 Thread Eric Blake
On 12/29/2010 05:36 PM, Matthias Bolte wrote: --- As we're currently in feature freeze this patch is meant to be applied after the next release. And we're now out of feature freeze, so I'm reviewing this... + +static int +esxDomainSetAutostart(virDomainPtr domain, int autostart) +{ +

[libvirt] [PATCH] docs: added libvirt-announce to contact page

2011-01-04 Thread Justin Clift
Also added explicit links to the subscription and archive pages for the user and developer mailing lists. --- docs/contact.html.in | 77 +- 1 files changed, 51 insertions(+), 26 deletions(-) diff --git a/docs/contact.html.in

Re: [libvirt] [PATCH] esx: Move occurrence check into esxVI_LookupObjectContentByType

2011-01-04 Thread Eric Blake
On 12/30/2010 05:36 AM, Matthias Bolte wrote: This simplifies the callers of esxVI_LookupObjectContentByType. src/esx/esx_driver.c | 19 ++-- src/esx/esx_vi.c | 128 - src/esx/esx_vi.h |3 +- 3 files changed, 69

Re: [libvirt] [PATCH] vbox: Use correct VRAM size unit

2011-01-04 Thread Eric Blake
On 12/30/2010 07:27 AM, Matthias Bolte wrote: VirtualBox uses megabyte, libvirt uses kilobyte. --- src/vbox/vbox_tmpl.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Oops - this could have qualified for a bug fix, but I didn't review it pre-release, so it missed the window.

Re: [libvirt] hypervisor feature - hardware assisted paging

2011-01-04 Thread Chris Lalancette
On 01/04/11 - 10:41:07AM, Jim Fehlig wrote: I'm looking into a bug where a libvirt-created xen HVM guest boots *very* slowly on an EPT-enabled machine, particularly when the guest has a dedicated PCI device. xen-unstable c/s 16931 [1] introduced a per-guest HAP (hardware assisted paging)

Re: [libvirt] [PATCH] docs: added libvirt-announce to contact page

2011-01-04 Thread Eric Blake
On 01/04/2011 11:39 AM, Justin Clift wrote: Also added explicit links to the subscription and archive pages for the user and developer mailing lists. --- docs/contact.html.in | 77 +- 1 files changed, 51 insertions(+), 26 deletions(-)

Re: [libvirt] announce mailing list

2011-01-04 Thread Eric Blake
On 01/02/2011 06:41 AM, Daniel Veillard wrote: 1] how can one sign-up into this list? I've been greeted with reply mail is blocked for this user or something like that :) Hum, weird, I need to check that ! 2] announce mailing list is not mentioned at

[libvirt] [PATCH] docs: added libvirt-announce to contact page

2011-01-04 Thread Justin Clift
Also added explicit links to the subscription and archive pages for the user and developer mailing lists. --- Adjusted with the items from Erics review. :) docs/contact.html.in | 87 +++--- 1 files changed, 61 insertions(+), 26 deletions(-) diff

[libvirt] [PATCHv2] docs: added libvirt-announce to contact page

2011-01-04 Thread Justin Clift
Also added explicit links to the subscription and archive pages for the user and developer mailing lists. --- Adjusted with the items from Erics review. :) Posted this a few minutes ago without v2 in subject line as well (forgot, oops). docs/contact.html.in | 87

Re: [libvirt] announce mailing list

2011-01-04 Thread Justin Clift
On 05/01/2011, at 6:08 AM, Eric Blake wrote: snip I've seen some projects (at least zsh comes to mind) where mailing lists are nested - posting to the announce list can only be done by project managers, but that post is instantly received on all three lists; anyone can post to the users or

[libvirt] RFC: exposing a config setting to force vhost-net support on/off

2011-01-04 Thread Laine Stump
There's a request to allow libvirt to explicitly turn on/off the new vhost-net feature of virtio network cards. I see a few ways to do it, and am looking for opinions on which is best. (For the uninitiated, vhost-net is a new kernel-based virtio implementation that saves the overhead of

Re: [libvirt] announce mailing list

2011-01-04 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/04/11 20:08, Eric Blake wrote: [...] I've seen some projects (at least zsh comes to mind) where mailing lists are nested - posting to the announce list can only be done by project managers, but that post is instantly received on all three

Re: [libvirt] [PATCHv2] docs: added libvirt-announce to contact page

2011-01-04 Thread Eric Blake
On 01/04/2011 12:24 PM, Justin Clift wrote: Also added explicit links to the subscription and archive pages for the user and developer mailing lists. p - Both mailing lists require that you subscribe before posting to the list, - otherwise your posting will be delayed for

Re: [libvirt] [PATCH] vmx: Add support for video device VRAM size

2011-01-04 Thread Eric Blake
On 12/30/2010 10:14 AM, Matthias Bolte wrote: Update test suite accordingly. + +virBufferVSprintf(buffer, svga.vramSize = \%d\\n, + def-vram * 1024); /* Scale from kilobytes to bytes */ Should this be %lld, def-vram * 1024ll, to avoid overflow concerns? Otherwise,

Re: [libvirt] RFC: exposing a config setting to force vhost-net support on/off

2011-01-04 Thread Eric Blake
On 01/04/2011 12:37 PM, Laine Stump wrote: It's simple enough to put a bit of extra logic at the point where we make that decision. I see 3 possibilities: 1) default - use vhost-net if it's loaded, don't if it isn't (current behavior) 2) require - use vhost-net if it's loaded, and refuse

Re: [libvirt] [PATCH] esx: Add domain autostart support

2011-01-04 Thread Matthias Bolte
2011/1/4 Eric Blake ebl...@redhat.com: On 12/29/2010 05:36 PM, Matthias Bolte wrote: --- As we're currently in feature freeze this patch is meant to be applied after the next release. And we're now out of feature freeze, so I'm reviewing this... + +static int

Re: [libvirt] Remove bashisms from libvirt-guests

2011-01-04 Thread Eric Blake
On 01/04/2011 11:13 AM, Laurent Léonard wrote: The attached patch should match with your comments. Thank you, Thank you for the work. +++ b/tools/Makefile.am @@ -146,6 +146,9 @@ BUILT_SOURCES += libvirt-guests.init libvirt-guests.init: libvirt-guests.init.in

[libvirt] Fwd: [PATCHv2] docs: added libvirt-announce to contact page

2011-01-04 Thread Justin Clift
Hey Daniel, Is Erics' text below (with the + 's) correct? Regards and best wishes, Justin Clift Begin forwarded message: From: Eric Blake ebl...@redhat.com Date: 5 January 2011 7:00:55 AM AEDT To: Justin Clift jcl...@redhat.com Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCHv2]

[libvirt] [TCK] [PATCH v2] Test cases for network ipv6 support

2011-01-04 Thread Stefan Berger
v2: - added test cases using 'ip addr ...' and 'ip route ...' commands This patch adds a couple of test cases for the recently added network ipv6 support. Signed-off-by: Stefan Bergerstef...@us.ibm.com --- scripts/networks/networkxml2hostout/tck-testnet-3.dat | 39 +

Re: [libvirt] Remove bashisms from libvirt-guests

2011-01-04 Thread Eric Blake
On 01/04/2011 04:50 PM, Laurent Léonard wrote: Here's what I'm planning on squashing in. However, I still have one nagging problem, that I haven't been able to figure out yet - even though we listed libvirt-guests.init.in in po/POTFILES.in, xgettext doesn't seem to be picking it up into

Re: [libvirt] [PATCH] qemu driver: use lseek64 for setting position in logfile

2011-01-04 Thread Stefan Berger
On 01/04/2011 07:38 PM, Daniel Veillard wrote: On Tue, Jan 04, 2011 at 09:46:07AM -0500, Stefan Berger wrote: Looks fine to me, ACK I checked it in earlier today with the lseek64's removed... But the real problem is getting huge log files, there is a trade off between the default log level

[libvirt] [PATCH v5 3/4] timer impl

2011-01-04 Thread Wen Congyang
* src/util/timer.c src/util/timer.h: timer implementation * src/libvirt.c: Initialize timer * src/Makefile.am: build timer * src/libvirt_private.syms: Export public functions Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- cfg.mk |1 + src/Makefile.am |3

[libvirt] [PATCH v5 2/4] test event when builing without libvirtd

2011-01-04 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- tests/Makefile.am |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 746cfa5..cc33d60 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -199,10 +199,8 @@ if

[libvirt] [PATCH v5 4/4] force guest to suspend at timeout

2011-01-04 Thread Wen Congyang
If a guest has not completed live migration before timeout, then auto-suspend the guest, where the migration will complete offline. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- tools/virsh.c | 67 +++ tools/virsh.pod |4 +++ 2

[libvirt] [PATCH v5 1/4] move daemon/event.* into src/util/ directory

2011-01-04 Thread Wen Congyang
move daemon/event.* into src/util/ directory because the timer needs the API virEventRunOnce(). git diff rename does not work... Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- daemon/Makefile.am |1 - daemon/event.c | 700

Re: [libvirt] Fwd: [PATCHv2] docs: added libvirt-announce to contact page

2011-01-04 Thread Daniel Veillard
On Wed, Jan 05, 2011 at 09:01:53AM +1100, Justin Clift wrote: Hey Daniel, Is Erics' text below (with the + 's) correct? p - Both mailing lists require that you subscribe before posting to the list, - otherwise your posting will be delayed for manual approval by

Re: [libvirt] [TCK] [PATCH v2] Test cases for network ipv6 support

2011-01-04 Thread Laine Stump
On 01/04/2011 06:44 PM, Stefan Berger wrote: v2: - added test cases using 'ip addr ...' and 'ip route ...' commands This patch adds a couple of test cases for the recently added network ipv6 support. I don't really feel qualified to do a good review of patches for libvirt-tck, but since

[libvirt] [PATCH] Log an error on attempts to add a NAT rule for non-IPv4 addresses

2011-01-04 Thread Laine Stump
Although the upper-layer code protected against it, it was possible to call iptablesForwardMasquerade() with an IPv6 address and have it attempt to add a rule to the MASQUERADE chain of ip6tables (which doesn't exist). This patch changes that function to check the protocol of the given address,

[libvirt] [PATCH] Improve error reporting when parsing dhcp info for virtual networks

2011-01-04 Thread Laine Stump
This is partially in response to https://bugzilla.redhat.com/show_bug.cgi?id=653300 The crash in that report was coincidentally fixed when we switched from using inet_pton() to using virSocketParseAddr(), but the absence of an ip address in a dhcp static host definition was still silently

Re: [libvirt] [PATCHv2] docs: added libvirt-announce to contact page

2011-01-04 Thread Justin Clift
On 05/01/2011, at 3:02 PM, Daniel Veillard wrote: On Wed, Jan 05, 2011 at 09:01:53AM +1100, Justin Clift wrote: Hey Daniel, Is Erics' text below (with the + 's) correct? p - Both mailing lists require that you subscribe before posting to the list, - otherwise your posting