[libvirt] [PATCH] qemu: Remove bogus codes in function getCompressionType

2011-07-26 Thread Osier Yang
The error will never be reported, remove the codes, and also improve the docs in qemu.conf to tell user the truth. --- src/qemu/qemu.conf |4 src/qemu/qemu_driver.c | 16 +--- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu.conf

[libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Daniel Veillard
As plannned we are entering the freeze for libvirt-0.9.4 . I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.4-rc1.tar.gz This seems to pass my minimal tests without problems, but please give it a try too and report problems, I will

[libvirt] [PATCH] tools: format percent strings of nodecpustats

2011-07-26 Thread ajia
* tools/virsh.c: format strings display for virsh nodecpustats --percent. * how to reproduce? % virsh nodecpustats --percent usage:2.0% user : 1.0% system: 1.0% idle : 98.0% iowait: 0.0% * after format strings % virsh nodecpustats --percent

Re: [libvirt] FYI: qemu -M option deprecated upstream, removed from -help output

2011-07-26 Thread Paolo Bonzini
On 07/25/2011 10:22 PM, Eric Blake wrote: As long as QEMU supports -M ? it should not be a problem. The -M option is not scraped from -help output. If -M is going away, then libvirt _should_ scrape -help output to see whether to use -M or -machine, rather than blindly using -M. -M going

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Osier Yang
于 2011年07月26日 14:48, Daniel Veillard 写道: As plannned we are entering the freeze for libvirt-0.9.4 . I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.4-rc1.tar.gz This seems to pass my minimal tests without problems, but please give

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Daniel Veillard
On Tue, Jul 26, 2011 at 05:02:49PM +0800, Osier Yang wrote: 于 2011年07月26日 14:48, Daniel Veillard 写道: As plannned we are entering the freeze for libvirt-0.9.4 . I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.4-rc1.tar.gz This

Re: [libvirt] [PATCH] tests: fix compilation failures

2011-07-26 Thread Daniel P. Berrange
On Mon, Jul 25, 2011 at 01:36:23PM -0600, Eric Blake wrote: On 07/25/2011 09:39 AM, Daniel P. Berrange wrote: (struct testTLSCertReq): Alter time members. (testTLSGenerateCert): Reflect the change. (mymain): Reduce stack usage. --- -/* if zero, then the current time will be used */

Re: [libvirt] [PATCH] Fix import of private key with older gnutls

2011-07-26 Thread Daniel Veillard
On Mon, Jul 25, 2011 at 06:18:42PM +0100, Daniel P. Berrange wrote: With older GNUTLS the gnutls_x509_privkey_import function is unable to import our private key. Instead we must use the alternative gnutls_x509_privkey_import_pkcs8() (as certtool does). * virnettlscontexttest.c: Fix import

Re: [libvirt] [PATCH] set cpu bandwidth for the vm

2011-07-26 Thread Daniel P. Berrange
On Mon, Jul 25, 2011 at 01:37:14PM +0800, Wen Congyang wrote: The cpu bandwidth is applied at the vcpu group level. We should apply it at the vm group level too, because the vm may do heavy I/O, and it will affect the other vm. We apply cpu bandwidth at the vcpu and the vm group level, so we

Re: [libvirt] [PATCH ] send-key: Implement Python API

2011-07-26 Thread Daniel P. Berrange
On Thu, Jul 21, 2011 at 05:21:10PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/python/libvirt-override.c b/python/libvirt-override.c index b713b6a..1ef5bfa 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -3789,6

Re: [libvirt] [PATCH] Fix import of private key with older gnutls

2011-07-26 Thread Daniel P. Berrange
On Tue, Jul 26, 2011 at 06:14:27PM +0800, Daniel Veillard wrote: On Mon, Jul 25, 2011 at 06:18:42PM +0100, Daniel P. Berrange wrote: With older GNUTLS the gnutls_x509_privkey_import function is unable to import our private key. Instead we must use the alternative

[libvirt] gnulib compiler warning detection broken on RHEL5 autoconf

2011-07-26 Thread Daniel P. Berrange
I was wondering why I didn't see any compile warnings from the broken gnutls code on RHEL5 when I noticed that we were building without any compiler warning flags at all. It seems configure fails on RHEL5 vintage autoconf checking whether compiler handles -Wall... ./configure: line 75468:

[libvirt] [PATCH] Fix build with gnutls 1.0.x branch

2011-07-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- src/rpc/virnettlscontext.c | 15 +++ tests/virnettlscontexttest.c |2 +- 2 files changed, 16 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index db03669..2a58ede 100644 ---

[libvirt] [PATCH] Fix typos in virsh.pod file

2011-07-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * tools/virsh.pod: Fix missing tag in docs --- tools/virsh.pod |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 5b7fa9c..ed9eb93 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Ruben Kerkhof
On Tue, Jul 26, 2011 at 08:48, Daniel Veillard veill...@redhat.com wrote:  As plannned we are entering the freeze for libvirt-0.9.4 . I have made a release candidate 1 tarball (and associated rpms) at  ftp://libvirt.org/libvirt/libvirt-0.9.4-rc1.tar.gz This seems to pass my minimal tests

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-26 Thread Daniel P. Berrange
On Mon, Jul 25, 2011 at 05:00:51AM -0400, Laine Stump wrote: Once it's plugged in, the listen element will be an optional replacement for the listen, port, tlsPort, and autoport attributes that graphics elements already have. If the listen type='address', it will have an attribute called

[libvirt] [PATCH] network: Fix typo

2011-07-26 Thread Osier Yang
Introduced by commit 239322cb, reported by Ruben Kerkhof. --- src/network/bridge_driver.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/network/bridge_driver.h b/src/network/bridge_driver.h index 518a5ba..4913126 100644 --- a/src/network/bridge_driver.h +++

Re: [libvirt] [PATCH] network: Fix typo

2011-07-26 Thread Daniel P. Berrange
On Tue, Jul 26, 2011 at 08:25:10PM +0800, Osier Yang wrote: Introduced by commit 239322cb, reported by Ruben Kerkhof. --- src/network/bridge_driver.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/network/bridge_driver.h b/src/network/bridge_driver.h index

Re: [libvirt] [PATCH] network: Fix typo

2011-07-26 Thread Osier Yang
于 2011年07月26日 19:51, Daniel P. Berrange 写道: On Tue, Jul 26, 2011 at 08:25:10PM +0800, Osier Yang wrote: Introduced by commit 239322cb, reported by Ruben Kerkhof. --- src/network/bridge_driver.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH] doc: Add doc for blockpull and blockjob commands

2011-07-26 Thread Osier Yang
Commit b31abc6f0 introduce commands blockpull and blockjob, but forgot to add the docs meanwhile. --- tools/virsh.pod | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 5b7fa9c..02c98c8 100644 --- a/tools/virsh.pod

Re: [libvirt] [PATCH] Fix typos in virsh.pod file

2011-07-26 Thread Osier Yang
于 2011年07月26日 18:56, Daniel P. Berrange 写道: From: Daniel P. Berrangeberra...@redhat.com * tools/virsh.pod: Fix missing tag in docs --- tools/virsh.pod |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 5b7fa9c..ed9eb93 100644

[libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in file system extended attributes. Some file systems, such as NFS, do not support the

Re: [libvirt] [PATCH] Fix build with gnutls 1.0.x branch

2011-07-26 Thread Daniel Veillard
On Tue, Jul 26, 2011 at 11:56:19AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- src/rpc/virnettlscontext.c | 15 +++ tests/virnettlscontexttest.c |2 +- 2 files changed, 16 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] Fix typos in virsh.pod file

2011-07-26 Thread Daniel Veillard
On Tue, Jul 26, 2011 at 11:56:30AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * tools/virsh.pod: Fix missing tag in docs --- tools/virsh.pod |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Daniel Veillard
On Tue, Jul 26, 2011 at 01:02:21PM +0200, Ruben Kerkhof wrote: On Tue, Jul 26, 2011 at 08:48, Daniel Veillard veill...@redhat.com wrote: This fails on F-13 with: [...] In file included from qemu/qemu_command.c:40: ./network/bridge_driver.h:58:4: error: invalid preprocessing directive #defing

Re: [libvirt] [RFC PATCH 0/5] Support online resizing of block devices.

2011-07-26 Thread Eric Blake
On 07/25/2011 11:51 PM, Osier Yang wrote: This patch series introduce new API virDomainBlockResize to expose qemu monitor command block_size, which is for resizing the a block device while the domain is running. The prototype for the new API is: int virDomainBlockResize (virDomainPtr

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Christoph Hellwig
I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Eric Blake
On 07/26/2011 06:51 AM, Corey Bryant wrote: There are some additional features provided by certain image types where Qemu reopens the image file. All of these scenarios will be unsupported for the fd: protocol, at least for this patch: - The -snapshot command line option - The savevm

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Eric Blake
On 07/26/2011 07:02 AM, Christoph Hellwig wrote: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. What is it that you hate - the particular qemu

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 15:02, schrieb Christoph Hellwig: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. I think the problem here is more with the

Re: [libvirt] [PATCH] set cpu bandwidth for the vm

2011-07-26 Thread Wen Congyang
At 07/26/2011 06:24 PM, Daniel P. Berrange write: On Mon, Jul 25, 2011 at 01:37:14PM +0800, Wen Congyang wrote: The cpu bandwidth is applied at the vcpu group level. We should apply it at the vm group level too, because the vm may do heavy I/O, and it will affect the other vm. We apply cpu

Re: [libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 16:00, schrieb Eric Blake: On 07/26/2011 06:51 AM, Corey Bryant wrote: There are some additional features provided by certain image types where Qemu reopens the image file. All of these scenarios will be unsupported for the fd: protocol, at least for this patch: - The

[libvirt] [PATCH] bandwidth: Integrate bandwidth into portgroups

2011-07-26 Thread Michal Privoznik
Every DomainNetDef has a bandwidth, as does every portgroup. Whenever a DomainNetDef of type NETWORK is about to be used, a call is made to networkAllocateActualDevice(). This function chooses the best bandwidth object and places it in the DomainActualNetDef. From that point on, whenever some code

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 10:05 AM, Kevin Wolf wrote: Am 26.07.2011 15:02, schrieb Christoph Hellwig: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead.

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-26 Thread Laine Stump
On 07/26/2011 07:35 AM, Daniel P. Berrange wrote: On Mon, Jul 25, 2011 at 05:00:51AM -0400, Laine Stump wrote: Once it's plugged in, thelisten element will be an optional replacement for the listen, port, tlsPort, and autoport attributes that graphics elements already have. If thelisten

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 16:46, schrieb Corey Bryant: On 07/26/2011 10:05 AM, Kevin Wolf wrote: Am 26.07.2011 15:02, schrieb Christoph Hellwig: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd

[libvirt] [PATCH] Fix race in ref counting when handling RPC jobs

2011-07-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When an incoming RPC message is ready for processing, virNetServerClientDispatchRead() will invoke the 'dispatchFunc' callback. This is set to virNetServerDispatchNewMessage This function puts the message + client in a queue for processing by

Re: [libvirt] [PATCH] Fix race in ref counting when handling RPC jobs

2011-07-26 Thread Eric Blake
On 07/26/2011 08:56 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com When an incoming RPC message is ready for processing, virNetServerClientDispatchRead() will invoke the 'dispatchFunc' callback. This is set to virNetServerDispatchNewMessage This function

[libvirt] [PATCH] Build: fix build if HAVE_AVAHI is not defined

2011-07-26 Thread Stefan Berger
Fix the build if HAVE_AVAHI is not defined. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/rpc/virnetserver.c |2 ++ 1 file changed, 2 insertions(+) Index: libvirt-acl/src/rpc/virnetserver.c === ---

Re: [libvirt] [PATCH] Build: fix build if HAVE_AVAHI is not defined

2011-07-26 Thread Eric Blake
On 07/26/2011 09:11 AM, Stefan Berger wrote: Fix the build if HAVE_AVAHI is not defined. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/rpc/virnetserver.c | 2 ++ 1 file changed, 2 insertions(+) Index: libvirt-acl/src/rpc/virnetserver.c

Re: [libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in file system extended attributes. Some

Re: [libvirt] [PATCH 1/1] Fix incorrect implication about list options

2011-07-26 Thread Eric Blake
On 07/25/2011 09:20 PM, Dave Allan wrote: The description of the list command seemed to suggest that it could take a set of domains as an argument, which is not correct in the current HEAD. If virsh list is intended to take a list of domains, then this patch should be NAK'd and a bug opened

Re: [libvirt] [PATCH] Build: fix build if HAVE_AVAHI is not defined

2011-07-26 Thread Stefan Berger
On 07/26/2011 11:12 AM, Eric Blake wrote: On 07/26/2011 09:11 AM, Stefan Berger wrote: Fix the build if HAVE_AVAHI is not defined. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/rpc/virnetserver.c | 2 ++ 1 file changed, 2 insertions(+) Index:

Re: [libvirt] [PATCH] qemu: Remove bogus codes in function getCompressionType

2011-07-26 Thread Eric Blake
On 07/26/2011 01:04 AM, Osier Yang wrote: The error will never be reported, remove the codes, and also improve the docs in qemu.conf to tell user the truth. --- src/qemu/qemu.conf |4 src/qemu/qemu_driver.c | 16 +--- 2 files changed, 9 insertions(+), 11

Re: [libvirt] [PATCH] tools: format percent strings of nodecpustats

2011-07-26 Thread Eric Blake
On 07/26/2011 01:32 AM, Alex Jia wrote: * tools/virsh.c: format strings display for virsh nodecpustats --percent. * how to reproduce? % virsh nodecpustats --percent usage:2.0% user : 1.0% system: 1.0% idle : 98.0% iowait: 0.0% Yuck. ACK

Re: [libvirt] FYI: qemu -M option deprecated upstream, removed from -help output

2011-07-26 Thread Eric Blake
On 07/26/2011 02:53 AM, Paolo Bonzini wrote: On 07/25/2011 10:22 PM, Eric Blake wrote: As long as QEMU supports -M ? it should not be a problem. The -M option is not scraped from -help output. If -M is going away, then libvirt _should_ scrape -help output to see whether to use -M or

Re: [libvirt] gnulib compiler warning detection broken on RHEL5 autoconf

2011-07-26 Thread Eric Blake
On 07/26/2011 04:45 AM, Daniel P. Berrange wrote: I was wondering why I didn't see any compile warnings from the broken gnutls code on RHEL5 when I noticed that we were building without any compiler warning flags at all. It seems configure fails on RHEL5 vintage autoconf checking whether

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Jason Helfman
I have this failure for bsd: rpc/virnetserver.c:786: error: 'virNetServer' has no member named 'mdns' gmake[3]: *** [libvirt_net_rpc_server_la-virnetserver.lo] Error 1 gmake[3]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.4/src' gmake[2]: *** [all] Error 2 gmake[2]:

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Eric Blake
On 07/26/2011 10:18 AM, Jason Helfman wrote: I have this failure for bsd: rpc/virnetserver.c:786: error: 'virNetServer' has no member named 'mdns' gmake[3]: *** [libvirt_net_rpc_server_la-virnetserver.lo] Error 1 gmake[3]: Leaving directory

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Jason Helfman
On Tue, Jul 26, 2011 at 10:24:57AM -0600, Eric Blake thus spake: On 07/26/2011 10:18 AM, Jason Helfman wrote: I have this failure for bsd: rpc/virnetserver.c:786: error: 'virNetServer' has no member named 'mdns' gmake[3]: *** [libvirt_net_rpc_server_la-virnetserver.lo] Error 1 gmake[3]:

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Alexander Graf
On 26.07.2011, at 18:57, Corey Bryant wrote: Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Eric Blake
On 07/26/2011 10:40 AM, Jason Helfman wrote: Thanks! I have this error now, though. No difference between the tarball source and the git sources for this file. remote.c:1643: error: 'tmp' undeclared (first use in this function) gmake[3]: *** [libvirtd-remote.o] Error 1 That's odd. Line 1643

Re: [libvirt] [PATCH] bandwidth: Integrate bandwidth into portgroups

2011-07-26 Thread Laine Stump
On 07/26/2011 10:35 AM, Michal Privoznik wrote: Every DomainNetDef has a bandwidth, as does every portgroup. Whenever a DomainNetDef of type NETWORK is about to be used, a call is made to networkAllocateActualDevice(). This function chooses the best bandwidth object and places it in the

Re: [libvirt] gnulib compiler warning detection broken on RHEL5 autoconf

2011-07-26 Thread Eric Blake
On 07/26/2011 10:05 AM, Eric Blake wrote: On 07/26/2011 04:45 AM, Daniel P. Berrange wrote: I was wondering why I didn't see any compile warnings from the broken gnutls code on RHEL5 when I noticed that we were building without any compiler warning flags at all. It seems configure fails on

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Jason Helfman
On Tue, Jul 26, 2011 at 11:45:19AM -0600, Eric Blake thus spake: On 07/26/2011 10:40 AM, Jason Helfman wrote: Thanks! I have this error now, though. No difference between the tarball source and the git sources for this file. remote.c:1643: error: 'tmp' undeclared (first use in this function)

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Eric Blake
On 07/26/2011 12:16 PM, Jason Helfman wrote: remote.c: At top level: remote.c:409: error: negative width in bit-field '_gl_verify_error_if_negative' remote.c: In function 'remoteDispatchDomainGetBlockJobInfo': remote.c:1630: error: 'virDomainBlockJobInfo' undeclared (first use in this function)

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Eric Blake
On 07/26/2011 12:28 PM, Zdenek Styblik wrote: ~~~ SNIP ~~~ rpc/virnetserver.c: In function 'virNetServerFree': rpc/virnetserver.c:786:5: warning: implicit declaration of function 'virNetServerMDNSFree' [-Wimplicit-function-declaration] rpc/virnetserver.c:786:5: warning: nested extern declaration

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-26 Thread Jason Helfman
On Tue, Jul 26, 2011 at 12:26:20PM -0600, Eric Blake thus spake: On 07/26/2011 12:16 PM, Jason Helfman wrote: remote.c: At top level: remote.c:409: error: negative width in bit-field '_gl_verify_error_if_negative' remote.c: In function 'remoteDispatchDomainGetBlockJobInfo': remote.c:1630:

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 01:10 PM, Alexander Graf wrote: On 26.07.2011, at 18:57, Corey Bryant wrote: Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and

[libvirt] [PATCH] build: support warnings on RHEL 5

2011-07-26 Thread Eric Blake
Without this, a configure built by autoconf 2.59 was broken when trying to detect which compiler warning flags were supported. * .gnulib: Update to latest, for warnings.m4 fix. * src/qemu/qemu_conf.c (includes): Drop unused include. * src/uml/uml_conf.c (include): Likewise. Reported by Daniel P.

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-26 Thread Matthias Bolte
2011/6/1 Eric Blake ebl...@redhat.com: On 05/31/2011 02:51 PM, Matthias Bolte wrote: AM_GNU_GETTEXT calls AM_ICONV_LINK. AM_ICONV_LINK saves and alters CPPFLAGS, but doesn't restore it when it finds libiconv. This results in /usr/local/include ending up in the gcc command line before the

Re: [libvirt] [PATCH] build: support warnings on RHEL 5

2011-07-26 Thread Eric Blake
On 07/26/2011 02:25 PM, Eric Blake wrote: Without this, a configure built by autoconf 2.59 was broken when trying to detect which compiler warning flags were supported. * .gnulib: Update to latest, for warnings.m4 fix. * src/qemu/qemu_conf.c (includes): Drop unused include. * src/uml/uml_conf.c

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-26 Thread Eric Blake
On 07/26/2011 02:45 PM, Matthias Bolte wrote: +++ b/configure.ac @@ -2011,8 +2011,16 @@ dnl Enable building libvirtd? AM_CONDITIONAL([WITH_LIBVIRTD],[test x$with_libvirtd = xyes]) dnl Check for gettext - don't go any newer than what RHEL 5 supports +dnl +dnl save and restore CPPFLAGS around

[libvirt] [PATCH] build: avoid type-punning compiler warning

2011-07-26 Thread Eric Blake
On RHEL 5, with gcc 4.1.2: rpc/virnetsaslcontext.c: In function 'virNetSASLSessionUpdateBufSize': rpc/virnetsaslcontext.c:396: warning: dereferncing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] * src/rpc/virnetsaslcontext.c (virNetSASLSessionUpdateBufSize): Use a

Re: [libvirt] [PATCH 06/10] qemu: Remove special case for virDomainBlockStats

2011-07-26 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: Like other query commands, this can now be called directly during migration. --- src/qemu/qemu_domain.h|4 --- src/qemu/qemu_driver.c| 54 +++-- src/qemu/qemu_migration.c | 18 ---

Re: [libvirt] [PATCH 05/10] qemu: Remove special case for virDomainGetBlockInfo

2011-07-26 Thread Eric Blake
On 07/22/2011 03:10 PM, Eric Blake wrote: On 07/18/2011 06:27 PM, Jiri Denemark wrote: Like other query commands, this can now be called directly during migration. --- src/qemu/qemu_domain.h | 4 src/qemu/qemu_driver.c | 42 --

Re: [libvirt] [PATCH 08/10] qemu: Remove special case for virDomainMigrateSetMaxDowntime

2011-07-26 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: Call qemu monitor command directly within a special job that is only allowed during outgoing migration. --- src/qemu/qemu_domain.c|1 - src/qemu/qemu_domain.h|6 -- src/qemu/qemu_driver.c| 23 +++

Re: [libvirt] [PATCH 07/10] qemu: Remove special case for virDomainMigrateSetMaxSpeed

2011-07-26 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: Call qemu monitor command directly within a special job that is only allowed during outgoing migration. --- src/qemu/qemu_domain.c|1 + src/qemu/qemu_domain.h|3 +-- src/qemu/qemu_driver.c| 23 +++

Re: [libvirt] [PATCH 09/10] qemu: Remove special case for virDomainSuspend

2011-07-26 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: --- src/qemu/qemu_domain.h|1 - src/qemu/qemu_driver.c| 46 ++-- src/qemu/qemu_migration.c |6 + 3 files changed, 24 insertions(+), 29 deletions(-) ACK. -- Eric Blake

Re: [libvirt] [PATCH 04/10] qemu: Recover from interrupted migration

2011-07-26 Thread Eric Blake
On 07/22/2011 03:06 PM, Eric Blake wrote: + case QEMU_MIGRATION_PHASE_PERFORM2: + case QEMU_MIGRATION_PHASE_PERFORM3: + /* migration is still in progress, let's cancel it and resume the + * domain */ + VIR_DEBUG(Canceling unfinished outgoing migration of domain %s, + vm-def-name); + /* TODO

Re: [libvirt] [PATCH 10/10] qemu: Remove special case for virDomainAbortJob

2011-07-26 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: This doesn't abort migration job in any phase, yet. --- src/qemu/qemu_domain.c|9 +--- src/qemu/qemu_domain.h| 12 +++--- src/qemu/qemu_driver.c| 36 ++--- src/qemu/qemu_migration.c | 48

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-26 Thread Eric Blake
On 07/26/2011 08:50 AM, Laine Stump wrote: I think it is a somewhat overkill to have 'autoport' be a setting per-listen element. I can't imagine people want a fixed port number on one IP addr, but a dynamic port number on another IP addr. So we could just keep that on the top level element.

[libvirt] [PATCH] python: Properly report errors if virStreamRecv fails

2011-07-26 Thread Cole Robinson
We only want to raise the special value -2. -1 should return None which tells the bindings to throw an exception. --- python/libvirt-override.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 70e0238..bdff0e9

Re: [libvirt] [PATCH] python: Properly report errors if virStreamRecv fails

2011-07-26 Thread Eric Blake
On 07/26/2011 05:26 PM, Cole Robinson wrote: We only want to raise the special value -2. -1 should return None which tells the bindings to throw an exception. --- python/libvirt-override.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/python/libvirt-override.c

Re: [libvirt] [PATCH] python: Properly report errors if virStreamRecv fails

2011-07-26 Thread Cole Robinson
On 07/26/2011 07:27 PM, Eric Blake wrote: On 07/26/2011 05:26 PM, Cole Robinson wrote: We only want to raise the special value -2. -1 should return None which tells the bindings to throw an exception. --- python/libvirt-override.c |4 +++- 1 files changed, 3 insertions(+), 1

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-26 Thread Eric Blake
On 07/25/2011 03:00 AM, Laine Stump wrote: Once it's plugged in, thelisten element will be an optional replacement for the listen, port, tlsPort, and autoport attributes that graphics elements already have. If thelisten type='address', it will have an attribute called 'address' which will

[libvirt] [PATCH 1/4] python: add python binding for virDomainGetBlkioParameters

2011-07-26 Thread Hu Tao
--- python/libvirt-override-api.xml |6 +- python/libvirt-override.c | 79 +- 2 files changed, 79 insertions(+), 6 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index a8929b1..00f8e6a 100644 ---

[libvirt] [PATCH 3/4] python: add python binding for virDomainGetMemoryParameters

2011-07-26 Thread Hu Tao
--- python/libvirt-override-api.xml |6 +- python/libvirt-override.c | 79 +- 2 files changed, 79 insertions(+), 6 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 928bfb7..0a67f9d 100644 ---

[libvirt] [PATCH 2/4] python: add python binding for virDomainSetBlkioParameters

2011-07-26 Thread Hu Tao
--- python/libvirt-override-api.xml |1 + python/libvirt-override.c | 94 +- 2 files changed, 92 insertions(+), 3 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 00f8e6a..928bfb7 100644 ---

[libvirt] [PATCH 4/4] python: add python binding for virDomainSetMemoryParameters

2011-07-26 Thread Hu Tao
--- python/libvirt-override-api.xml |1 + python/libvirt-override.c | 94 +- 2 files changed, 92 insertions(+), 3 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 0a67f9d..2fa5eed 100644 ---

Re: [libvirt] [PATCH] doc: Add doc for blockpull and blockjob commands

2011-07-26 Thread Daniel Veillard
On Tue, Jul 26, 2011 at 09:03:22PM +0800, Osier Yang wrote: Commit b31abc6f0 introduce commands blockpull and blockjob, but forgot to add the docs meanwhile. --- tools/virsh.pod | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod

Re: [libvirt] [PATCH] doc: Add doc for blockpull and blockjob commands

2011-07-26 Thread Osier Yang
于 2011年07月27日 10:44, Daniel Veillard 写道: On Tue, Jul 26, 2011 at 09:03:22PM +0800, Osier Yang wrote: Commit b31abc6f0 introduce commands blockpull and blockjob, but forgot to add the docs meanwhile. --- tools/virsh.pod | 21 + 1 files changed, 21 insertions(+), 0

[libvirt] [PATCH] virsh: fix memory leak in cmdVolPath code

2011-07-26 Thread ajia
* tools/virsh.c: avoid memory leak in cmdVolPath. * how to reproduce? % dd if=/dev/zero of=/var/lib/libvirt/images/foo.img count=1 bs=10M % virsh pool-refresh default % valgrind -v --leak-check=full virsh vol-path --vol /var/lib/libvirt/images/foo.img * actual results: Detected in

Re: [libvirt] [PATCH] tools: format percent strings of nodecpustats

2011-07-26 Thread Alex Jia
On 07/26/2011 11:52 PM, Eric Blake wrote: On 07/26/2011 01:32 AM, Alex Jia wrote: * tools/virsh.c: format strings display for virsh nodecpustats --percent. * how to reproduce? % virsh nodecpustats --percent usage:2.0% user : 1.0% system: 1.0% idle :

Re: [libvirt] [PATCH] virsh: fix memory leak in cmdVolPath code

2011-07-26 Thread Osier Yang
于 2011年07月27日 11:33, Alex Jia 写道: * tools/virsh.c: avoid memory leak in cmdVolPath. * how to reproduce? % dd if=/dev/zero of=/var/lib/libvirt/images/foo.img count=1 bs=10M % virsh pool-refresh default % valgrind -v --leak-check=full virsh vol-path --vol