Re: [libvirt] [PATCH 0/3] snapshot: auto-cleanup metadata of transient domains

On Wed, Sep 21, 2011 at 01:08:49PM -0600, Eric Blake wrote: > I intended to do this ever since I changed the API of virDomainUndefine > to reject undefine of persistent guests with snapshots, but am only > now getting around to it. This missed 0.9.5, but I think it is worth > including in 0.9.6 ev

Re: [libvirt] [PATCH] storage: Do not use comma as seperator for lvs output

hi Osier : 于 2011年09月21日 17:07, Osier Yang 写道: * src/storage/storage_backend_logical.c: If a logical vol is created with multiple stripes. (e.g. --stripes 3), the "device" field of lvs output will have multiple fileds which are seperated by comma. It means the RE we write in the codes will not w

Re: [libvirt] [PATCH] sanlock: fix memory leak

On Wed, Sep 21, 2011 at 02:22:57PM -0600, Eric Blake wrote: > Detected by Coverity. The only way to get to error_unlink is if > path was successfully assigned, so the if was useless. Meanwhile, > there was a return statement that did not free path. > > * src/locking/lock_driver_sanlock.c > (virL

Re: [libvirt] [PATCH 1/3] snapshot: fix logic bug in qemu undefine

On Wed, Sep 21, 2011 at 01:08:50PM -0600, Eric Blake wrote: > Commit 19f8c98 introduced VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, > with the intent that omitting the flag makes undefine fail, and > including the flag deletes metadata. But it used the wrong logic. > Also, hoist the transient domain s

Re: [libvirt] [PATCH] virsh: fix regression in argv parsing

On Wed, Sep 21, 2011 at 09:29:47AM -0600, Eric Blake wrote: > On 09/21/2011 08:54 AM, Eric Blake wrote: > >Commit 85d2810 broke commands with mandatory argv (send-key, > >qemu-monitor-command). This fixes things, and enhances the > >test to cover it. > > To make review easier, I'll enhance the co

Re: [libvirt] "Connection does not support host device enumeration"

? 2011?09?22? 12:46, Osier Yang ??: ? 2011?09?22? 12:41, Kaushal Shriyan ??: On Thu, Sep 22, 2011 at 9:41 AM, Osier Yang wrote: ? 2011?09?22? 09:11, Kaushal Shriyan ??: does not support host device enumeration Seems your libvirt is compiled without --with-hal and --with-udev Regards Osier

Re: [libvirt] "Connection does not support host device enumeration"

于 2011年09月22日 12:41, Kaushal Shriyan 写道: > On Thu, Sep 22, 2011 at 9:41 AM, Osier Yang wrote: >> 于 2011年09月22日 09:11, Kaushal Shriyan 写道: >>> does not support host device enumeration >> Seems your libvirt is compiled without --with-hal and >> --with-udev >> >> Regards >> Osier >> > Hi Osier > > Th

Re: [libvirt] "Connection does not support host device enumeration"

On Thu, Sep 22, 2011 at 9:41 AM, Osier Yang wrote: > 于 2011年09月22日 09:11, Kaushal Shriyan 写道: >> >> does not support host device enumeration > > Seems your libvirt is compiled without --with-hal and > --with-udev > > Regards > Osier > Hi Osier Thanks for the reply. Please let me know how do i en

Re: [libvirt] "Connection does not support host device enumeration"

于 2011年09月22日 09:11, Kaushal Shriyan 写道: does not support host device enumeration Seems your libvirt is compiled without --with-hal and --with-udev Regards Osier -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] locking: remove redundant codes

On 09/22/2011 09:35 AM, Eric Blake wrote: On 09/21/2011 07:15 PM, a...@redhat.com wrote: From: Alex Jia * src/locking/lock_driver_sanlock.c: remove redundant codes in error_unlink label from virLockManagerSanlockSetupLockspace, in fact, the codes make sure 'path' is non-null before gett

Re: [libvirt] [PATCH] locking: remove redundant codes

On 09/21/2011 07:15 PM, a...@redhat.com wrote: From: Alex Jia * src/locking/lock_driver_sanlock.c: remove redundant codes in error_unlink label from virLockManagerSanlockSetupLockspace, in fact, the codes make sure 'path' is non-null before getting to error_unlink label, so 'if (path)'

Re: [libvirt] [PATCH] qemu: avoid dereferencing a NULL pointer

On 09/22/2011 05:29 AM, Eric Blake wrote: On 09/21/2011 01:02 PM, a...@redhat.com wrote: From: Alex Jia * src/qemu/qemu_process.c: Taking if (qemuDomainObjEndJob(driver, obj) == 0) true branch then 'obj' is NULL, virDomainObjIsActive(obj) and virDomainObjUnref(obj) will dereference NULL

Re: [libvirt] [PATCH] locking: avoid dereferencing a NULL pointer

On 09/22/2011 04:12 AM, Eric Blake wrote: On 09/21/2011 12:10 PM, a...@redhat.com wrote: From: Alex Jia * src/locking/lock_driver_sanlock.c: in fact, virStrcpy calls virStrncpy(dest, src, strlen(src), destbytes) then return result, if 'path' is NULL, it means 'src' is also NULL, strlen(NU

[libvirt] "Connection does not support host device enumeration"

Hi, I have "20:04.0 Network controller: Sangoma Technologies Corp. A104d QUAD T1/E1 AFT card" on Host OS, Its not visible on guest OS using linux KVM application. I did open the window for guest from virt-manager on my Ubuntu Linux Desktop 11.04, shut down the guest, then select the "Details" vi

[libvirt] [PATCH] locking: remove redundant codes

From: Alex Jia * src/locking/lock_driver_sanlock.c: remove redundant codes in error_unlink label from virLockManagerSanlockSetupLockspace, in fact, the codes make sure 'path' is non-null before getting to error_unlink label, so 'if (path)' is redundant, removing it in here and will also s

Re: [libvirt] [PATCH] storage: Do not use comma as seperator for lvs output

于 2011年09月21日 18:22, Daniel P. Berrange 写道: On Wed, Sep 21, 2011 at 05:07:56PM +0800, Osier Yang wrote: * src/storage/storage_backend_logical.c: If a logical vol is created with multiple stripes. (e.g. --stripes 3), the "device" field of lvs output will have multiple fileds which are seperated

Re: [libvirt] [PATCH] virsh: More friendly err if no pool is specified for looking up a vol

于 2011年09月21日 23:19, Eric Blake 写道: On 09/21/2011 01:12 AM, Osier Yang wrote: There are 3 ways to lookup a volume, only virStorageVolLookupByName needs pool object. So if no --pool is specified, it will tries to get the volume via virStorageVolLookupByPath/virStorageVolLookupByKey. But if all 3

Re: [libvirt] [PATCH] storage: Wait udev events are handled before removing lvm vol

于 2011年09月21日 23:18, Eric Blake 写道: On 09/21/2011 12:52 AM, Osier Yang wrote: Related #BZ: https://bugzilla.redhat.com/show_bug.cgi?id=702260. There are two problems described in the BZ: 1) "Can't remove open logical volume". 2) "Unable to deactivate logical volume "foo"" This patch just inten

[libvirt] [PATCH 4/3] snapshot: also delete empty directory

The previous patch removed all snapshots, but not the directory where the snapshots lived, which is still a form of stale data. * src/qemu/qemu_domain.c (qemuDomainRemoveInactive): Wipe any snapshot directory. --- I could probably also just squash this into 2/3. src/qemu/qemu_domain.c | 12 ++

Re: [libvirt] [PATCH] qemu: avoid dereferencing a NULL pointer

On 09/21/2011 01:02 PM, a...@redhat.com wrote: From: Alex Jia * src/qemu/qemu_process.c: Taking if (qemuDomainObjEndJob(driver, obj) == 0) true branch then 'obj' is NULL, virDomainObjIsActive(obj) and virDomainObjUnref(obj) will dereference NULL pointer. Signed-off-by: Alex Jia --- src/

Re: [libvirt] [PATCHv2] Add unsafe cache mode support for disk driver

On 09/21/2011 03:14 PM, Eric Blake wrote: +++ b/tests/qemuhelptest.c @@ -77,8 +77,8 @@ static int testHelpStrParsing(const void *data) if (STRNEQ(got, expected)) { fprintf(stderr, - "Computed flags do not match: got %s, expected %s\n", - got, expected); + "%s: computed flags do not match: got %s

Re: [libvirt] [PATCHv2] Add unsafe cache mode support for disk driver

On 09/21/2011 10:29 AM, Oskari Saarenmaa wrote: QEMU 0.13 introduced cache=unsafe for -drive, this patch exposes it in the libvirt layer. * Introduced a new QEMU capability flag ($prefix_CACHE_UNSAFE), as even if $prefix_CACHE_V2 is set, we can't known if unsafe is supported. *

Re: [libvirt] [PATCH] qemu: add ability to set PCI device "rombar" on or off

On 09/21/2011 10:25 AM, Laine Stump wrote: This patch was made in response to: https://bugzilla.redhat.com/show_bug.cgi?id=738095 In short, qemu's default for the rombar setting (which makes the firmware ROM of a PCI device visible/not on the guest) was previously 0 (not visible), but they r

[libvirt] [PATCH] sanlock: fix memory leak

Detected by Coverity. The only way to get to error_unlink is if path was successfully assigned, so the if was useless. Meanwhile, there was a return statement that did not free path. * src/locking/lock_driver_sanlock.c (virLockManagerSanlockSetupLockspace): Fix mem-leak, and drop useless if. ---

Re: [libvirt] [PATCH] locking: avoid dereferencing a NULL pointer

On 09/21/2011 12:10 PM, a...@redhat.com wrote: From: Alex Jia * src/locking/lock_driver_sanlock.c: in fact, virStrcpy calls virStrncpy(dest, src, strlen(src), destbytes) then return result, if 'path' is NULL, it means 'src' is also NULL, strlen(NULL) will dereference a NULL pointer, whi

[libvirt] [PATCH 2/3] snapshot: prepare to remove transient snapshot metadata

This patch is mostly code motion - moving some functions out of qemu_driver and into qemu_domain so they can be reused by multiple qemu_* files (since qemu_driver.h must not grow). It also adds a new helper function, qemuDomainRemoveInactive, which will be used in the next patch. * src/qemu/qemu_d

[libvirt] [PATCH 3/3] snapshot: remove snapshot metadata on transient exit

Commit 282fe1f0 documented that transient domains will auto-delete any snapshot metadata when the last reference to the domain is removed, and that management apps are in charge of grabbing any snapshot metadata prior to that point. However, this was not actually implemented for qemu until now. *

[libvirt] [PATCH 0/3] snapshot: auto-cleanup metadata of transient domains

I intended to do this ever since I changed the API of virDomainUndefine to reject undefine of persistent guests with snapshots, but am only now getting around to it. This missed 0.9.5, but I think it is worth including in 0.9.6 even if we have a short release cycle to work around the qemu shutdown

[libvirt] [PATCH 1/3] snapshot: fix logic bug in qemu undefine

Commit 19f8c98 introduced VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, with the intent that omitting the flag makes undefine fail, and including the flag deletes metadata. But it used the wrong logic. Also, hoist the transient domain sooner, so that we don't accidentally remove metadata of a transient

[libvirt] [PATCH] qemu: avoid dereferencing a NULL pointer

From: Alex Jia * src/qemu/qemu_process.c: Taking if (qemuDomainObjEndJob(driver, obj) == 0) true branch then 'obj' is NULL, virDomainObjIsActive(obj) and virDomainObjUnref(obj) will dereference NULL pointer. Signed-off-by: Alex Jia --- src/qemu/qemu_process.c | 32 +-

[libvirt] [PATCH] qemu: avoid dereferencing a NULL pointer

From: Alex Jia * src/qemu/qemu_process.c: Taking if (qemuDomainObjEndJob(driver, obj) == 0) true branch then 'obj' is NULL, virDomainObjIsActive(obj) and virDomainObjUnref(obj) will dereference NULL pointer. Signed-off-by: Alex Jia --- src/qemu/qemu_process.c | 32 +-

[libvirt] [PATCH] locking: avoid dereferencing a NULL pointer

From: Alex Jia * src/locking/lock_driver_sanlock.c: in fact, virStrcpy calls virStrncpy(dest, src, strlen(src), destbytes) then return result, if 'path' is NULL, it means 'src' is also NULL, strlen(NULL) will dereference a NULL pointer, which probably causes a segmentation fault. Signed-of

[libvirt] [PATCHv2] Add unsafe cache mode support for disk driver

QEMU 0.13 introduced cache=unsafe for -drive, this patch exposes it in the libvirt layer. * Introduced a new QEMU capability flag ($prefix_CACHE_UNSAFE), as even if $prefix_CACHE_V2 is set, we can't known if unsafe is supported. * qemuhelptest prints test case name on failure. --- Up

[libvirt] [PATCH] qemu: add ability to set PCI device "rombar" on or off

This patch was made in response to: https://bugzilla.redhat.com/show_bug.cgi?id=738095 In short, qemu's default for the rombar setting (which makes the firmware ROM of a PCI device visible/not on the guest) was previously 0 (not visible), but they recently changed the default to 1 (visible). Un

Re: [libvirt] [PATCH] virsh: fix regression in argv parsing

On 09/21/2011 08:54 AM, Eric Blake wrote: Commit 85d2810 broke commands with mandatory argv (send-key, qemu-monitor-command). This fixes things, and enhances the test to cover it. To make review easier, I'll enhance the commit message: Prior to commit 85d2810, we had an issue where: snapshot

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

On 09/21/2011 05:00 PM, Eric Blake wrote: On 09/21/2011 06:28 AM, Eric Blake wrote: +++ libvirt-0.9.5.new/tools/virsh.c 2011-09-21 13:56:17.0 +0200 @@ -13916,8 +13916,8 @@ vshCmddefGetData(const vshCmdDef *cmd, u opt =&cmd->opts[i]; if (opt->type != VSH_OT_ARGV) { *opts_need_arg&= ~(1<<

Re: [libvirt] [PATCH] storage: Wait udev events are handled before removing lvm vol

On 09/21/2011 12:52 AM, Osier Yang wrote: Related #BZ: https://bugzilla.redhat.com/show_bug.cgi?id=702260. There are two problems described in the BZ: 1) "Can't remove open logical volume". 2) "Unable to deactivate logical volume "foo"" This patch just intends to fix 2), as 1) is expected if th

Re: [libvirt] [PATCH] virsh: More friendly err if no pool is specified for looking up a vol

On 09/21/2011 01:12 AM, Osier Yang wrote: There are 3 ways to lookup a volume, only virStorageVolLookupByName needs pool object. So if no --pool is specified, it will tries to get the volume via virStorageVolLookupByPath/virStorageVolLookupByKey. But if all 3 ways fails, and no --pool is specifi

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

On 09/21/2011 06:28 AM, Eric Blake wrote: +++ libvirt-0.9.5.new/tools/virsh.c 2011-09-21 13:56:17.0 +0200 @@ -13916,8 +13916,8 @@ vshCmddefGetData(const vshCmdDef *cmd, u opt =&cmd->opts[i]; if (opt->type != VSH_OT_ARGV) { *opts_need_arg&= ~(1<< i); - *opts_seen |= 1<< i; } + *opts_seen |

Re: [libvirt] [PATCH] qemu: Avoid loop of fake reboots

On Wed, Sep 21, 2011 at 08:17:32 -0600, Eric Blake wrote: > On 09/21/2011 08:08 AM, Jiri Denemark wrote: > > Once virDomainReboot is called for a domain, guest OS initiated shutdown > > would always result in reboot instead of shutdown. Only > > virDomainShutdown would actually shutd such domain do

Re: [libvirt] [PATCH v2] qemu: Fix shutdown regression with buggy qemu

On Wed, Sep 21, 2011 at 08:19:25 -0600, Eric Blake wrote: > On 09/21/2011 08:06 AM, Jiri Denemark wrote: > > The commit that prevents disk corruption on domain shutdown > > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > > 0.14.* and 0.15.* because of a regression bug in QE

[libvirt] [PATCH] virsh: fix regression in argv parsing

Commit 85d2810 broke commands with mandatory argv (send-key, qemu-monitor-command). This fixes things, and enhances the test to cover it. * tools/virsh.c (vshCmddefGetOption, vshCmddefGetData) (vshCommandParse): Fix option parsing for required argv option. (vshCmddefOptParse): Check that argv opt

Re: [libvirt] [PATCH] Fix synchronous reading of stream data

On Wed, Sep 21, 2011 at 02:54:38PM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > commit 984840a2c292402926ad100aeea33f8859ff31a9 removed the > notification of waiting calls when VIR_NET_CONTINUE messages > arrive. This was to fix the case of a virStreamAbort() call > being pre

Re: [libvirt] [PATCH v2] qemu: Fix shutdown regression with buggy qemu

On 09/21/2011 08:06 AM, Jiri Denemark wrote: The commit that prevents disk corruption on domain shutdown (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed only recently in QEMU git. The affected versions of

Re: [libvirt] [PATCH] qemu: Avoid loop of fake reboots

On 09/21/2011 08:08 AM, Jiri Denemark wrote: Once virDomainReboot is called for a domain, guest OS initiated shutdown would always result in reboot instead of shutdown. Only virDomainShutdown would actually shutd such domain down. That's because we forgot to reset fakeReboot flag once we asked th

[libvirt] [PATCH v2] qemu: Fix shutdown regression with buggy qemu

The commit that prevents disk corruption on domain shutdown (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed only recently in QEMU git. The affected versions of QEMU do not quit on SIGTERM if started with -no

[libvirt] [PATCH] qemu: Avoid loop of fake reboots

Once virDomainReboot is called for a domain, guest OS initiated shutdown would always result in reboot instead of shutdown. Only virDomainShutdown would actually shutd such domain down. That's because we forgot to reset fakeReboot flag once we asked the domain to reboot. --- src/qemu/qemu_process.

Re: [libvirt] [PATCH] Fix synchronous reading of stream data

On 09/21/2011 07:54 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" commit 984840a2c292402926ad100aeea33f8859ff31a9 removed the notification of waiting calls when VIR_NET_CONTINUE messages arrive. This was to fix the case of a virStreamAbort() call being prematurely notified of completi

[libvirt] [PATCH] Fix synchronous reading of stream data

From: "Daniel P. Berrange" commit 984840a2c292402926ad100aeea33f8859ff31a9 removed the notification of waiting calls when VIR_NET_CONTINUE messages arrive. This was to fix the case of a virStreamAbort() call being prematurely notified of completion. The problem is that sometimes there are dummy

[libvirt] [test-API][PATCH v3] Add test case update_devflag.py for update device flag

--- repos/domain/update_devflag.py | 231 1 files changed, 231 insertions(+), 0 deletions(-) create mode 100644 repos/domain/update_devflag.py diff --git a/repos/domain/update_devflag.py b/repos/domain/update_devflag.py new file mode 100644 index 000

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

于 2011年09月21日 20:28, Eric Blake 写道: On 09/21/2011 06:18 AM, Jason Krieg wrote: Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 So does command send-key. *opts_seen moved into the != VSH_OT_ARGV if statement so

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

On Wed, Sep 21, 2011 at 06:28:26AM -0600, Eric Blake wrote: > On 09/21/2011 06:18 AM, Jason Krieg wrote: > >Hi, > > > >the virsh qemu-monitor-command is not working with libvirt 0.9.5 > > > >with git commit 85d2810823a31634b12145d6c196930b40425370 > > > >*opts_seen moved into the != VSH_OT_ARGV if

Re: [libvirt] [Qemu-devel] [PATCH] qemu: Fix shutdown regression

0.14 shouldn't have this bug, but it looks like 0.15 has it. Justin, can you cherry-pick d9389b96 and 941f511a into stable-0.15 in order to fix -no-shutdown? Kevin I can confirm this, I`m using qemu-kvm 0.14.1 and do not run into this bug Regards Jason -- libvir-list mailing list libvir

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

On 09/21/2011 06:18 AM, Jason Krieg wrote: Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 *opts_seen moved into the != VSH_OT_ARGV if statement so now opts_seen is only set if not VSH_OT_ARGV diff -Nurp libv

[libvirt] virsh qemu-monitor-command broken with 0.9.5

Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 *opts_seen moved into the != VSH_OT_ARGV if statement so now opts_seen is only set if not VSH_OT_ARGV see attached fix Regards Jason diff -Nurp libvirt-0.9.5/tools/

Re: [libvirt] [PATCH] daemon: Modify init script to check for libvirtd managed with upstart

On 09/21/2011 01:17 PM, Daniel P. Berrange wrote: On Wed, Sep 21, 2011 at 12:46:33PM +0200, Peter Krempa wrote: On some systems init scripts are installed along with upstart . This may cause trouble if user tries to restart/stop a instance of libvirtd managed with upstart with init script. This

Re: [libvirt] [PATCH] qemu: Fix shutdown regression

On Wed, Sep 21, 2011 at 10:29:35 +0100, Daniel P. Berrange wrote: > On Wed, Sep 21, 2011 at 10:43:32AM +0200, Jiri Denemark wrote: > > The commit that prevents disk corruption on domain shutdown > > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > > 0.14.* and 0.15.* because

Re: [libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"

On Tue, Sep 20, 2011 at 06:00:55PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 20, 2011 at 06:20:48PM +0200, Michal Privoznik wrote: > > This partially reverts commit 984840a2c292402926ad100aeea33f8859ff31a9. > > > > Without this patch, client don't finish a stream which makes any > > API invol

[libvirt] [RFC v1] API to invoke S3/S4 on a KVM host and also resume from within libvirt

This patch adds a new API to put a KVM host to a suspended state (either Suspend-to-RAM or Suspend-to-Disk) and also resume the host back from within libvirt. This uses the RTC wakeup mechanism to set up a timer alarm before suspending the host, so that in-band resume is facilitated since the firin

Re: [libvirt] [PATCH 1/2] qemu: using correct function to reboot guest.

I got that mean. Thanks for your reply! On 2011年09月21日 18:27, Daniel P. Berrange wrote: On Wed, Sep 21, 2011 at 05:53:31PM +0800, x...@linux.vnet.ibm.com wrote: From: Xu He Jie Signed-off-by: Xu He Jie --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH] daemon: Modify init script to check for libvirtd managed with upstart

On Wed, Sep 21, 2011 at 12:46:33PM +0200, Peter Krempa wrote: > On some systems init scripts are installed along with upstart . This may > cause trouble if user tries to restart/stop a instance of libvirtd > managed with upstart with init script. > > This patch adds check for a started libvirtd ma

Re: [libvirt] [PATCH v2] qemu: Allow domain reboot after core dump

On 09/21/2011 02:47 PM, Michal Privoznik wrote: This patch introduces possibility to reboot domain after core dump finishes. The new flag VIR_DUMP_REBOOT was added to virDomainCoreDumpFlags. The new functionality is accessible via virsh too: virsh dump --reboot --- diff to v1: -check for success

Re: [libvirt] libvirt-0.9.5 availability of rc2

On Wed, Sep 21, 2011 at 10:55:37AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 20, 2011 at 12:03:00PM +0800, Daniel Veillard wrote: > > On Mon, Sep 19, 2011 at 08:15:18AM -0500, Adam Litke wrote: > > > On Mon, Sep 19, 2011 at 04:04:04PM +0800, Daniel Veillard wrote: > > > > On Sun, Sep 18, 2011

[libvirt] [PATCH] daemon: Modify init script to check for libvirtd managed with upstart

On some systems init scripts are installed along with upstart . This may cause trouble if user tries to restart/stop a instance of libvirtd managed with upstart with init script. This patch adds check for a started libvirtd managed by upstart and fails the init script. [root@localhost ~]# initctl

Re: [libvirt] [PATCH 1/2] qemu: using correct function to reboot guest.

On Wed, Sep 21, 2011 at 05:53:31PM +0800, x...@linux.vnet.ibm.com wrote: > From: Xu He Jie > > > Signed-off-by: Xu He Jie > --- > src/qemu/qemu_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index f4ee4

Re: [libvirt] [Qemu-devel] [PATCH] qemu: Fix shutdown regression

Am 20.09.2011 20:01, schrieb Eric Blake: > On 09/20/2011 11:39 AM, Jiri Denemark wrote: >> The commit that prevents disk corruption on domain shutdown >> (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU >> 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed >>

Re: [libvirt] [PATCH] storage: Do not use comma as seperator for lvs output

On Wed, Sep 21, 2011 at 05:07:56PM +0800, Osier Yang wrote: > * src/storage/storage_backend_logical.c: > > If a logical vol is created with multiple stripes. (e.g. --stripes 3), > the "device" field of lvs output will have multiple fileds which are > seperated by comma. It means the RE we write in

Re: [libvirt] [PATCH] API: prefer to use NULLSTR macro

于 2011年09月21日 17:53, Daniel Veillard 写道: On Wed, Sep 21, 2011 at 05:38:26PM +0800, Osier Yang wrote: --- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 05c0a87..8f94b11 100644 --- a/src/libvirt.c +++ b/src/libvirt.c

[libvirt] [PATCH] storage: Do not break the whole vol lookup process in the middle

* src/storage/storage_driver.c: As virStorageVolLookupByPath lookups all the pool objs of the drivers, breaking when failing on getting the stable path of the pool will just breaks the lookup process, it can cause the API fails even if the vol exists indeed. It won't get any benifit. This patch is

Re: [libvirt] libvirt-0.9.5 availability of rc2

On Tue, Sep 20, 2011 at 12:03:00PM +0800, Daniel Veillard wrote: > On Mon, Sep 19, 2011 at 08:15:18AM -0500, Adam Litke wrote: > > On Mon, Sep 19, 2011 at 04:04:04PM +0800, Daniel Veillard wrote: > > > On Sun, Sep 18, 2011 at 09:37:22AM -0500, Adam Litke wrote: > > > Hum, I wonder if remoteRelayD

[libvirt] [PATCH 2/2] qemu: remove YAJL check for qemuDomainReboot

From: Xu He Jie Signed-off-by: Xu He Jie --- src/qemu/qemu_driver.c | 41 ++--- 1 files changed, 14 insertions(+), 27 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b0c9c02..ee98662 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 1/2] qemu: using correct function to reboot guest.

From: Xu He Jie Signed-off-by: Xu He Jie --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f4ee4c3..b0c9c02 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1567,7 +1567

Re: [libvirt] [PATCH] API: prefer to use NULLSTR macro

On Wed, Sep 21, 2011 at 05:38:26PM +0800, Osier Yang wrote: > --- > src/libvirt.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/libvirt.c b/src/libvirt.c > index 05c0a87..8f94b11 100644 > --- a/src/libvirt.c > +++ b/src/libvirt.c > @@ -10300,7 +10300,7 @@ virC

Re: [libvirt] [PATCH 1/2] xen: use typical allocations

On Tue, Sep 20, 2011 at 12:11:31PM -0600, Eric Blake wrote: > The next patch will add a syntax check that flags this usage in xen > as awkward - while it was valid memory management, it was very hard > to maintain. Swapping to a more traditional allocation may be a bit > slower, but easier to unde

Re: [libvirt] [PATCH] qemu: Fix shutdown regression

On Wed, Sep 21, 2011 at 10:43:32AM +0200, Jiri Denemark wrote: > The commit that prevents disk corruption on domain shutdown > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed > only recently in QEMU git. T

Re: [libvirt] [Qemu-devel] [PATCH] qemu: Fix shutdown regression

On Tue, Sep 20, 2011 at 12:01:58PM -0600, Eric Blake wrote: > On 09/20/2011 11:39 AM, Jiri Denemark wrote: > >The commit that prevents disk corruption on domain shutdown > >(96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > >0.14.* and 0.15.* because of a regression bug in QEM

Re: [libvirt] [PATCH] qemu: Fix shutdown regression

On Tue, Sep 20, 2011 at 02:06:49PM -0400, Dave Allan wrote: > On Tue, Sep 20, 2011 at 07:39:15PM +0200, Jiri Denemark wrote: > > The commit that prevents disk corruption on domain shutdown > > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > > 0.14.* and 0.15.* because of a

[libvirt] [PATCH] API: prefer to use NULLSTR macro

--- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 05c0a87..8f94b11 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -10300,7 +10300,7 @@ virConnectFindStoragePoolSources(virConnectPtr conn,

[libvirt] [PATCH] qemu: Fix shutdown regression

The commit that prevents disk corruption on domain shutdown (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed only recently in QEMU git. The affected versions of QEMU do not quit on SIGTERM if started with -no

[libvirt] [PATCH] storage: Do not use comma as seperator for lvs output

* src/storage/storage_backend_logical.c: If a logical vol is created with multiple stripes. (e.g. --stripes 3), the "device" field of lvs output will have multiple fileds which are seperated by comma. It means the RE we write in the codes will not work well anymore. E.g. (lvs output for a stripped

Re: [libvirt] [PATCH 1/2] xen: use typical allocations

On Tue, Sep 20, 2011 at 12:11:31PM -0600, Eric Blake wrote: > The next patch will add a syntax check that flags this usage in xen > as awkward - while it was valid memory management, it was very hard > to maintain. Swapping to a more traditional allocation may be a bit > slower, but easier to unde

Re: [libvirt] [PATCH 2/2] remote: fix crash on OOM

On Tue, Sep 20, 2011 at 12:11:32PM -0600, Eric Blake wrote: > Bug introduced in commit 675464b. On an OOM, this would try to > dereference a char* and free the contents as a pointer, which is > doomed to failure. > > Adding a syntax check will prevent mistakes like this in the future. > > * cfg.