On 11/02/2011 07:01 PM, Eric Blake wrote:
On 10/31/2011 07:01 AM, Stefan Berger wrote:
NWFilters can be provided name-value pairs using the following
XML notiation:
s/notiation/notation/
The internal representation currently is so that a name is stored as a
string and the value as well
On 11/01/2011 05:47 PM, Eric Blake wrote:
This allows strings to be transported between client and server
in the context of name-type-value virTypedParameter functions.
For compatibility,
o new clients will not send strings to old servers, based on
a feature check
o new servers
On 10/31/2011 07:01 AM, Stefan Berger wrote:
This patch adds test cases for parsing of parameters with
multiple occurrances of the same name.
s/occurrances/occurrences/
+++ libvirt-acl/tests/nwfilterxml2xmlin/attr-value-test.xml
@@ -0,0 +1,27 @@
+
+83011800-f663-96d6-8841-fd836b4318c6
+
+
+
+
On 10/31/2011 07:01 AM, Stefan Berger wrote:
This patch modifies the NWFilter parameter parser to support multiple
elements with the same name and to internally build a list of items.
An example of the XML looks like this:
The list of values is then stored in the n
On 10/31/2011 07:01 AM, Stefan Berger wrote:
This patch extends the NWFilter driver for Linux (ebiptables) to create
rules for each member of a previously introduced list. If for example
an attribute value (internally) looks like this:
IP = [10.0.0.1, 10.0.0.2, 10.0.0.3]
then 3 rules will be ge
On 10/31/2011 07:01 AM, Stefan Berger wrote:
NWFilters can be provided name-value pairs using the following
XML notiation:
s/notiation/notation/
The internal representation currently is so that a name is stored as a
string and the value as well. This patc
On 11/02/2011 04:00 PM, Guido Günther wrote:
+template = strdup("/tmp/libvirt_XX");
No need to malloc() the template. Just do:
char template[] = "/tmp/libvirt_XX";
This was actually the first version I had but it didn't seem to match
libvirt's style (in the non-const form and I
On Wed, Nov 02, 2011 at 03:39:54PM -0600, Eric Blake wrote:
> On 11/02/2011 03:31 PM, Guido Günther wrote:
> >to avoid exceeding UNIX_PATH_MAX
> >---
> > tests/virnetsockettest.c | 60
> > ++---
> > 1 files changed, 40 insertions(+), 20 deletions(-)
>
>
On Wed, Nov 02, 2011 at 03:35:05PM -0600, Eric Blake wrote:
> On 11/02/2011 03:30 PM, Guido Günther wrote:
> >---
> > src/rpc/virnetsocket.c |3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> >diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> >index ab88e19..d832c5
On 11/02/2011 03:31 PM, Guido Günther wrote:
to avoid exceeding UNIX_PATH_MAX
---
tests/virnetsockettest.c | 60 ++---
1 files changed, 40 insertions(+), 20 deletions(-)
I like this better than Stefan's proposal (a temporary directory is
better than
On 11/02/2011 02:24 PM, Stefan Berger wrote:
@@ -214,6 +219,19 @@ static int testSocketUNIXAccept(const void *data
ATTRIBUTE_UNUSED)
}
}
+ if (strlen(path) >= sizeof(sun.sun_path)) {
+ if (!virStrcpy(path, "/tmp/test.sock.XX", sizeof(sun.sun_path))) {
+ VIR_DEBUG("Unexpected error using virS
On 11/02/2011 03:30 PM, Guido Günther wrote:
---
src/rpc/virnetsocket.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index ab88e19..d832c53 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -327,7 +
to avoid exceeding UNIX_PATH_MAX
---
tests/virnetsockettest.c | 60 ++---
1 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c
index 6320ce0..aeb4f3f 100644
--- a/tests/virnetsockettest.c
+++
---
src/rpc/virnetsocket.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index ab88e19..d832c53 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -327,7 +327,8 @@ int virNetSocketNewListenUNIX(const char
On Wed, Nov 02, 2011 at 02:19:07PM -0600, Eric Blake wrote:
> On 11/02/2011 12:57 PM, Guido Günther wrote:
> >Built fine on most Debian architectures:
> >
> >
> > https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental
> >
> >The built failure on amd64 is due to virnetsockett
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
The default console type may vary based on the OS type. ie a Xen
paravirt guests wants a 'xen' console, while a fullvirt guests
wants a 'serial' console.
A plain integer default console type in the capabilities does
no
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
To allow virDomainOpenConsole to access non-primary consoles,
device aliases are required to be set. Until now only the QEMU
driver has done this. Update LXC& UML to set aliases for any
console devices
* src/lxc/lxc_d
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
When no element was set at all, the default console
target type was not being honoured
* src/conf/domain_conf.c: Set default target type for consoles
with no
---
src/conf/domain_conf.c |3 +++
1 files change
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
Currently the LXC controller only supports setup of a single
text console. This is wired up to the container init's stdio,
as well as /dev/console and /dev/tty1. Extending support for
multiple consoles, means wiring up
On 11/02/2011 02:57 PM, Guido Günther wrote:
On Mon, Oct 31, 2011 at 05:51:55PM +0800, Daniel Veillard wrote:
We are now entering the freeze for libvirt-0.9.7 .
We may make an exception for patch set which got a few round of reviews
though, like Stefan's ones (v4 IIRC), and anything which we
On 11/02/2011 12:57 PM, Guido Günther wrote:
Built fine on most Debian architectures:
https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental
The built failure on amd64 is due to virnetsockettest failing with:
5) Socket UNIX Accept... libvir: RPC error : Path
/bui
On 11/02/2011 12:42 PM, Stefan Berger wrote:
On 11/02/2011 02:00 PM, Eric Blake wrote:
libvirt.c guarantees that nparams is non-zero for scheduler parameters.
* src/test/test_driver.c (testDomainGetSchedulerParamsFlags): Drop
redundant check.
---
src/test/test_driver.c | 4
1 files changed,
On 11/02/2011 11:53 AM, Stefan Berger wrote:
On 11/02/2011 01:26 PM, Eric Blake wrote:
Document the parameter names that will be used by
virDomain{Get,Set}SchedulerParameters{,Flags}, rather than
hard-coding those names in each driver, to match what is
done with memory, blkio, and blockstats par
On 11/02/2011 12:35 PM, Stefan Berger wrote:
On 11/02/2011 02:00 PM, Eric Blake wrote:
Allow the user to call with nparams too small, per API documentation.
+ if (virStrcpyStatic(params[1].field, "cap") == NULL) {
I remember this one here:
VIR_DOMAIN_SCHEDULER_CAP
Is this the same one ? If s
On Mon, Oct 31, 2011 at 05:51:55PM +0800, Daniel Veillard wrote:
> We are now entering the freeze for libvirt-0.9.7 .
> We may make an exception for patch set which got a few round of reviews
> though, like Stefan's ones (v4 IIRC), and anything which we know may
> need fixing in the API before th
On 11/02/2011 02:00 PM, Eric Blake wrote:
Allow the user to call with nparams too small, per API documentation.
* src/xen/xen_hypervisor.c (xenHypervisorGetSchedulerParameters):
Allow fewer than max.
* src/xen/xend_internal.c (xenDaemonGetSchedulerParameters):
Likewise.
---
src/xen/xen_hypervi
On 11/02/2011 02:00 PM, Eric Blake wrote:
Allow the user to call with nparams too small, per API documentation.
Also, libvirt.c filters out nparams of 0 for scheduler parameters.
* src/lxc/lxc_driver.c (lxcDomainGetMemoryParameters): Allow fewer
than max.
(lxcGetSchedulerParametersFlags): Drop r
On 11/02/2011 02:00 PM, Eric Blake wrote:
libvirt.c guarantees that nparams is non-zero for scheduler parameters.
* src/test/test_driver.c (testDomainGetSchedulerParamsFlags): Drop
redundant check.
---
src/test/test_driver.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff
On 11/02/2011 02:00 PM, Eric Blake wrote:
Allow the user to call with nparams too small, per API documentation.
* src/esx/esx_driver.c (esxDomainGetMemoryParameters): Drop
redundant check.
(esxDomainGetSchedulerParametersFlags): Allow fewer than max.
---
src/esx/esx_driver.c | 14 +--
On 11/02/2011 02:00 PM, Eric Blake wrote:
Allow the user to call with nparams too small, per API documentation.
* src/libxl/libxl_driver.c
(libxlDomainGetSchedulerParametersFlags): Allow fewer than max.
---
src/libxl/libxl_driver.c | 22 ++
1 files changed, 10 insertions
On 11/02/2011 05:12 AM, Stefan Berger wrote:
On 11/01/2011 07:47 PM, Eric Blake wrote:
Qemu will be the first driver to make use of a typed string in the
next round of additions. Separate out the trivial addition.
* src/qemu/qemu_driver.c (qemudSupportsFeature): Advertise feature.
(qemuDomainGe
Allow the user to call with nparams too small, per API documentation.
* src/xen/xen_hypervisor.c (xenHypervisorGetSchedulerParameters):
Allow fewer than max.
* src/xen/xend_internal.c (xenDaemonGetSchedulerParameters):
Likewise.
---
src/xen/xen_hypervisor.c | 26 --
src/
Allow the user to call with nparams too small, per API documentation.
Also, libvirt.c filters out nparams of 0 for scheduler parameters.
* src/lxc/lxc_driver.c (lxcDomainGetMemoryParameters): Allow fewer
than max.
(lxcGetSchedulerParametersFlags): Drop redundant check.
---
src/lxc/lxc_driver.c |
libvirt.c guarantees that nparams is non-zero for scheduler parameters.
* src/test/test_driver.c (testDomainGetSchedulerParamsFlags): Drop
redundant check.
---
src/test/test_driver.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test
Allow the user to call with nparams too small, per API documentation.
* src/libxl/libxl_driver.c
(libxlDomainGetSchedulerParametersFlags): Allow fewer than max.
---
src/libxl/libxl_driver.c | 22 ++
1 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/src/libxl/l
Allow the user to call with nparams too small, per API documentation.
* src/esx/esx_driver.c (esxDomainGetMemoryParameters): Drop
redundant check.
(esxDomainGetSchedulerParametersFlags): Allow fewer than max.
---
src/esx/esx_driver.c | 14 +-
1 files changed, 1 insertions(+), 13 del
Following in the wake of my qemu cleanup [1], I figured it was
worth fixing the other drivers as well. Let me know if I should
squash this into one patch instead of 5.
[1] https://www.redhat.com/archives/libvir-list/2011-November/msg00055.html
Eric Blake (5):
esx: allow getting < max typed par
On 11/02/2011 01:26 PM, Eric Blake wrote:
Document the parameter names that will be used by
virDomain{Get,Set}SchedulerParameters{,Flags}, rather than
hard-coding those names in each driver, to match what is
done with memory, blkio, and blockstats parameters.
* include/libvirt/libvirt.h.in (VIR_
I am getting 'system_u:object_r:svirt_image_t:s0:c129,c783' on
'/var/lib/libvirt/images/vm01.img': Permission denied'
when I try to install using virt-manager.
#semanage fcontext -l | grep images
/var/lib/libvirt/images(/.*)? all files
system_u:object_r:svirt_imag
Document the parameter names that will be used by
virDomain{Get,Set}SchedulerParameters{,Flags}, rather than
hard-coding those names in each driver, to match what is
done with memory, blkio, and blockstats parameters.
* include/libvirt/libvirt.h.in (VIR_DOMAIN_SCHEDULER_CPU_SHARES)
(VIR_DOMAIN_SCH
Thank you for the info.
I'll keep watching this mailing list.
David.
--
Dr. Dong-In "David" Kang
Computer Scientist
USC/ISI
- Original Message -
From: "Eric Blake"
To: "Dong-In David Kang"
Cc: libvir-list@redhat.com
Sent: Wednesday, November 2, 2011 12:57:16 PM
S
On 11/02/2011 10:37 AM, Dong-In David Kang wrote:
Hello,
Replying to a random previous message, even if you change the subject
line, doesn't create a new thread. Your message got buried in an
existing thread, making it harder to find; in the future, it is better
to start a new thread via
Hello,
Is it planned to support sVirt for LXC?
I know the current libvirt does not support sVirt for LXC.
I found that a branch at
https://gitorious.org/~berrange/libvirt/staging/commits/lxc-svirt seems to
support sVirt for LXC.
I downloaded the tar file and overwrite libvirt-0.9.6 with the b
2011/11/2 Eric Blake :
> On 11/02/2011 04:17 AM, Daniel P. Berrange wrote:
>>
>> There's a compile problem with this patch
>>
>> CC libvirt_driver_qemu_la-qemu_driver.lo
>> qemu/qemu_driver.c: In function 'qemuDomainBlockStatsFlags':
>> qemu/qemu_driver.c:7325:24: error: 'param' may be used u
On 11/01/2011 11:17 PM, Wen Congyang wrote:
commit 27908453 introduces a regression, and it will
cause libvirt crashed when starting network.
The reason is that tapfd may be NULL, but we dereference
it without checking whether it is NULL.
if ((errno = brSetInterfaceMac(ctl, *ifname, ma
On 11/02/2011 04:17 AM, Daniel P. Berrange wrote:
There's a compile problem with this patch
CC libvirt_driver_qemu_la-qemu_driver.lo
qemu/qemu_driver.c: In function 'qemuDomainBlockStatsFlags':
qemu/qemu_driver.c:7325:24: error: 'param' may be used uninitialized in this
function [-Werro
On 11/02/2011 10:25 AM, Wen Congyang wrote:
On 11/02/2011 07:16 PM, Stefan Berger wrote:
On 11/02/2011 01:17 AM, Wen Congyang wrote:
commit 27908453 introduces a regression, and it will
cause libvirt crashed when starting network.
The reason is that tapfd may be NULL, but we dereference
it wit
On 11/02/2011 07:16 PM, Stefan Berger wrote:
On 11/02/2011 01:17 AM, Wen Congyang wrote:
commit 27908453 introduces a regression, and it will
cause libvirt crashed when starting network.
The reason is that tapfd may be NULL, but we dereference
it without checking whether it is NULL.
---
src/ut
On 11/02/2011 01:17 AM, Wen Congyang wrote:
commit 27908453 introduces a regression, and it will
cause libvirt crashed when starting network.
The reason is that tapfd may be NULL, but we dereference
it without checking whether it is NULL.
---
src/util/bridge.c | 18 ++
1 fi
On 11/02/2011 06:28 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
* src/qemu/qemu_driver.c: Fix use of uninitialized 'params'
---
src/qemu/qemu_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
in
On 11/01/2011 07:47 PM, Eric Blake wrote:
Qemu will be the first driver to make use of a typed string in the
next round of additions. Separate out the trivial addition.
* src/qemu/qemu_driver.c (qemudSupportsFeature): Advertise feature.
(qemuDomainGetBlkioParameters, qemuDomainGetMemoryParamete
2011/11/1 Eric Blake :
> Document the parameter names that will be used by
> virDomain{Get,Set}SchedulerParameters{,Flags}, rather than
> hard-coding those names in each driver, to match what is
> done with memory, blkio, and blockstats parameters.
>
> * include/libvirt/libvirt.h.in (VIR_DOMAIN_SCH
On 11/01/2011 07:47 PM, Eric Blake wrote:
Send and receive string typed parameters across RPC.
* src/remote/remote_protocol.x (remote_typed_param_value): Add
another union value.
* daemon/remote.c (remoteSerializeTypedParameters)
(remoteDeserializeTypedParameters): Handle strings on rpc.
* src/r
On 11/01/2011 07:47 PM, Eric Blake wrote:
This allows strings to be transported between client and server
in the context of name-type-value virTypedParameter functions.
For compatibility,
o new clients will not send strings to old servers, based on
a feature check
o new servers
From: "Daniel P. Berrange"
* src/qemu/qemu_driver.c: Fix use of uninitialized 'params'
---
src/qemu/qemu_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f81cb88..3194e6b 100644
--- a/src/qemu/qemu_drive
On Mon, Oct 31, 2011 at 05:33:24PM -0600, Eric Blake wrote:
> Since all virTypedParameter APIs allow us to return the number
> of slots we actually populated, we should allow the user to
> call with nparams too small (without overrunning their array)
> or too large (ignoring the tail of the array t
On 02.11.2011 06:17, Wen Congyang wrote:
> commit 27908453 introduces a regression, and it will
> cause libvirt crashed when starting network.
>
> The reason is that tapfd may be NULL, but we dereference
> it without checking whether it is NULL.
>
> ---
> src/util/bridge.c | 18 ++-
On 11/02/2011 02:07 PM, Alex Jia wrote:
This email is automatically generated.
The test result is based on the following git commit:
9765653 qemu: allow getting< max typed parameters
For details, please see attachment.
Sorry for noise, please ignore this mail, I forgot to stop cron
schedule
"Christian Benvenuti (benve)" writes:
>> -Original Message-
>> From: qemu-devel-bounces+benve=cisco@nongnu.org
> [mailto:qemu-devel-
>> bounces+benve=cisco@nongnu.org] On Behalf Of Markus Armbruster
>> Sent: Monday, October 31, 2011 7:05 AM
>> To: Daniel P. Berrange
>> Cc: libvir-
59 matches
Mail list logo
