Re: [libvirt] [test-API][PATCH 1/2] update env_clear for new way of function reference

2011-11-14 Thread Guannan Sun
ACK pls also push last series patch of clean work. Thanks! Best Regards! Wayne Sun Redhat QE, Beijing, China +86-10-6260-8246 - Original Message - From: Guannan Ren g...@redhat.com To: libvir-list@redhat.com Sent: Friday, November 11, 2011 11:21:27 AM Subject: [libvirt] [test-API][PATCH

Re: [libvirt] [test-API][PATCH 2/2] update proxy and mapper part for cleanup using new reference

2011-11-14 Thread Guannan Sun
ACK Thanks! Best Regards! Wayne Sun Redhat QE, Beijing, China +86-10-6260-8246 - Original Message - From: Guannan Ren g...@redhat.com To: libvir-list@redhat.com Sent: Friday, November 11, 2011 11:21:28 AM Subject: [libvirt] [test-API][PATCH 2/2] update proxy and mapper part for

Re: [libvirt] make install libvirt failled.

2011-11-14 Thread Osier Yang
于 2011年11月14日 12:42, ShaoHe Feng 写道: I make install libvirt failed on my Ubuntu 11.11. I think some html dependent packages are missed on my build environment. Does anyone know the reason? Thanks. You need to install xhtml1-dtds Regards, Osier -- libvir-list mailing list

Re: [libvirt] [PATCH libvirt-glib 2/3] Add GVirDomainInterface

2011-11-14 Thread Christophe Fergeau
On Thu, Nov 10, 2011 at 04:15:01PM -0500, Marc-André Lureau wrote: On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote: Do we really need to use GSlice here? I consider GSlice as something to use when you want to make many allocations of same-size objects, will we allocate

Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-14 Thread Christophe Fergeau
Hey, On Thu, Nov 10, 2011 at 04:10:32PM -0500, Marc-André Lureau wrote: - Mensaje original - +G_GNUC_INTERNAL +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) G_GNUC_INTERNAL isn't needed here since it's the default setting for symbols not listed

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Kevin Wolf
Am 12.11.2011 11:25, schrieb Avi Kivity: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going to work right now even with proper clustered storage. I think doing a block level flush

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 10:58:16AM +0100, Kevin Wolf wrote: Am 12.11.2011 11:25, schrieb Avi Kivity: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going to work right now even

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going to work right now even with proper clustered storage. I think

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 10:16:10AM +, Daniel P. Berrange wrote: On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going

Re: [libvirt] [PATCH libvirt-glib 2/3] Add GVirDomainInterface

2011-11-14 Thread Christophe Fergeau
Hey, A few more comments I made on IRC (no access to this email when I reviewed the patches), sending them here to be sure they are not missed/lost. The same comments apply to patch 3/3. Can you resend the 3 patches with the various issues fixed? then I'll ACK them. Christophe On Thu, Nov 10,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 10:16:10AM +, Daniel P. Berrange wrote: On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori:

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Kevin Wolf
Am 14.11.2011 12:08, schrieb Daniel P. Berrange: On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 10:16:10AM +, Daniel P. Berrange wrote: On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: Am 14.11.2011 12:08, schrieb Daniel P. Berrange: On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 10:16:10AM +, Daniel P. Berrange wrote: On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 11:08:02AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 10:16:10AM +, Daniel P. Berrange wrote: On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: On 11/11/2011 12:15 PM,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: Am 14.11.2011 12:08, schrieb Daniel P. Berrange: On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 10:16:10AM +,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: Am 14.11.2011 12:08, schrieb Daniel P. Berrange: On Mon, Nov 14, 2011 at 12:24:22PM +0200,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Gleb Natapov
On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: Do you have some more details on the kind of errors? Missing files, permissions, something like this? Or rather something related to the actual content of an image file? Missing files due to wrong/missing NFS mounts, or

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 11:37:27AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: Am 14.11.2011 12:08,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 11:37:27AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: Am 14.11.2011 12:08,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 01:56:36PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:37:27AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: On Mon, Nov 14,

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 01:51:40PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:37:27AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wrote: On Mon, Nov 14,

[libvirt] [PATCH 6/6 (v2)] Allow non-blocking message sending on virNetClient

2011-11-14 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Split the existing virNetClientSend into two parts virNetClientSend and virNetClientSendNoReply, instead of having a 'bool expectReply' parameter. Add a new virNetClientSendNonBlock which returns 2 on full send, 1 on partial send, 0 on no send, -1 on

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2011 at 11:58:14AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 01:56:36PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14, 2011 at 11:37:27AM +, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 14,

[libvirt] [PATCH libvirt-glib 1/6] Add GVirDomainDevice abstract class

2011-11-14 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am|3 + .../libvirt-gobject-domain-device-private.h| 31 + libvirt-gobject/libvirt-gobject-domain-device.c| 139 libvirt-gobject/libvirt-gobject-domain-device.h| 64 +

[libvirt] [PATCH libvirt-glib 3/6] Add GVirDomainDisk

2011-11-14 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am |2 + libvirt-gobject/libvirt-gobject-domain-disk.c | 208 + libvirt-gobject/libvirt-gobject-domain-disk.h | 78 + libvirt-gobject/libvirt-gobject.h |1 + libvirt-gobject/libvirt-gobject.sym

[libvirt] [PATCH libvirt-glib 5/6] Use G_DEFINE_BOXED_TYPE for boxed types

2011-11-14 Thread Marc-André Lureau
--- libvirt-gobject/libvirt-gobject-connection.c | 26 ++--- libvirt-gobject/libvirt-gobject-domain-disk.c | 15 +-- libvirt-gobject/libvirt-gobject-domain-interface.c | 15 +-- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 25 +---

[libvirt] [PATCH libvirt-glib 2/6] Add GVirDomainInterface

2011-11-14 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am|2 + libvirt-gobject/libvirt-gobject-domain-interface.c | 211 libvirt-gobject/libvirt-gobject-domain-interface.h | 81 libvirt-gobject/libvirt-gobject.h |1 +

[libvirt] [PATCH libvirt-glib 4/6] Copy G_DEFINE_BOXED_TYPE from GObject 2.26+

2011-11-14 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am |1 + libvirt-gobject/libvirt-gobject-compat.h | 72 ++ 2 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 libvirt-gobject/libvirt-gobject-compat.h diff --git a/libvirt-gobject/Makefile.am

[libvirt] [PATCH libvirt-glib 6/6] Remove useless memset(0) of private data

2011-11-14 Thread Marc-André Lureau
GObject initialization ensures objects and their private data are 0's. --- libvirt-gconfig/libvirt-gconfig-capabilities.c|6 +- libvirt-gconfig/libvirt-gconfig-domain-snapshot.c |6 +- libvirt-gconfig/libvirt-gconfig-domain.c |6 +-

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Anthony Liguori
On 11/14/2011 04:16 AM, Daniel P. Berrange wrote: On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going to work right now even

[libvirt] [RFC PATCH v2 0/4] Libvirt for PowerPC

2011-11-14 Thread Prerna Saxena
Hi, Recent development in KVM for 64-bit Power ISA Book3S machines, allows users to run multiple KVM guest instances on POWER7 and PPC970 processor based systems. Also qemu-system-ppc64 has been enhanced to support a new machine type pseries suitable for Power Book3S machines. This addition

[libvirt] [RFC PATCH v2 2/4] PowerPC : Add PPC CPU Driver

2011-11-14 Thread Prerna Saxena
From 918e49581c91c007086a0a7189c9b6cf83ba2bb0 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Oct 2011 05:56:20 -0700 Subject: [PATCH 2/4] Add PPC cpu driver. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com Signed-off-by: Anton Blanchard

[libvirt] [RFC PATCH v2 1/4] PowerPC : Use Sysfs to gather host topology

2011-11-14 Thread Prerna Saxena
From 9084802bdf7a2c10d6a913cb7dde001ab6ab3543 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Oct 2011 05:45:30 -0700 Subject: [PATCH 1/4] Use sysfs to gather host topology, in place of /proc/cpuinfo Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com ---

[libvirt] [RFC PATCH v2 3/4] PowerPC : Add support for ppc64 qemu

2011-11-14 Thread Prerna Saxena
From cf5850d807fb6d86a16879a3e4fe120a96b78e27 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Oct 2011 06:01:33 -0700 Subject: [PATCH 3/4] Add support for ppc64 qemu Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |

[libvirt] [RFC PATCH v2 4/4] PowerPC : Bifurcate arch-specific qemu initialization code from generic qemu command line generation.

2011-11-14 Thread Prerna Saxena
From ae7764be4454be1900fc3ee0a03bf819d5cd12de Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 14 Nov 2011 19:43:26 +0530 Subject: [PATCH 4/4] Separate out arch-specific qemu initialization from generic qemu commandline building code. At present,

[libvirt] [PATCH TECHPREVIEW RFC 0/4] LibSSH2 transport option for libvirt

2011-11-14 Thread Peter Krempa
This patchset adds a new secure transport layer to enable secure connections without the need to spawn external processes. The layer is implemented into virNetSocket. This patches still lack some functionality, which I will add before the final version is done, but I'd like to have some feedback

[libvirt] [PATCH TECHPREVIEW RFC 4/4] libssh2_transport: Use libssh2 driver code in remote driver

2011-11-14 Thread Peter Krempa
This patch adds URI options to support libssh2 transport in the remote driver. A new transport sceme is introduced eg. qemu+libssh://... that utilizes the libssh2 code added in previous patches. The libssh2 code requires the authentication callback to be able to perform keyboard-interactive

[libvirt] [PATCH TECHPREVIEW RFC 1/4] libssh2_transport: add main libssh2 transport implementation

2011-11-14 Thread Peter Krempa
This patch adds helper functions to libssh2 that enable us to use libssh2 in conjunction with libvirt-native virNetSocket-s instead of using a spawned ssh client process. This implemetation supports tunneled plaintext, keyboard-interactive, private key, ssh agent based and null authentication.

[libvirt] [PATCH TECHPREVIEW RFC 2/4] libssh2_transport: add ssh context support to virNetSocket

2011-11-14 Thread Peter Krempa
This patch enables virNetSocket to be used as an ssh client when properly configured. Fucntion virNetSocketNewConnectLibSSH() is added, that takes all needed parameters and creates a libssh2 session context and performs steps needed to open the connection. * src/libvirt_private.syms: Export the

Re: [libvirt] [PATCH libvirt-glib 1/6] Add GVirDomainDevice abstract class

2011-11-14 Thread Christophe Fergeau
ACK 1-5, please don't push 6 for now as it may cause bad conflicts with some pending libvirt-gconfig changes. If you want to push the libvirt-gobject bits now, let me know, I'll look at it. Christophe On Mon, Nov 14, 2011 at 01:50:02PM +0100, Marc-André Lureau wrote: ---

Re: [libvirt] [PATCH libvirt-glib 3/6] Add GVirDomainDisk

2011-11-14 Thread Christophe Fergeau
On Mon, Nov 14, 2011 at 01:50:04PM +0100, Marc-André Lureau wrote: +/** + * gvir_domain_disk_get_stats: + * @self: the domain disk + * @err: an error + * + * This function returns network disk stats. Individual fields + * within the stats structure may be returned as -1, which indicates +

Re: [libvirt] [PATCH] storage: forbid rebuilding existing disk storage pools

2011-11-14 Thread Guido Günther
On Mon, Nov 14, 2011 at 12:58:08PM +0800, Osier Yang wrote: 于 2011年11月13日 00:19, Guido Günther 写道: which would blow away all volumes. Honor VIR_STORAGE_POOL_BUILD_OVERWRITE to force a rebuild. This was caught by libvirt-tck's storage/110-disk-pool.t. Cheers, -- Guido ---

Re: [libvirt] [PATCH 4/5] blkiotune: add interface for blkiotune.device_weight

2011-11-14 Thread Eric Blake
On 11/08/2011 05:43 AM, Stefan Berger wrote: On 11/08/2011 06:00 AM, Hu Tao wrote: This adds per-device weights toblkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the domain

[libvirt] [PATCH TECHPREVIEW RFC 3/4] libssh2_transport: Add libssh2 session support to net client code

2011-11-14 Thread Peter Krempa
This patch adds a glue layer to enable using libssh2 code with the network client code. As in the original client implementation, shell code is sent to the server to detect correct options for netcat. *src/rpc/virnetclient.c: *src/rpc/virnetclient.h: Add function to handle connection to a

Re: [libvirt] [PATCH 11/33] Rename virVirtualPortProfileParams APIs

2011-11-14 Thread Daniel P. Berrange
On Wed, Nov 09, 2011 at 02:12:02AM -0500, Laine Stump wrote: On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Rename the virVirtualPortProfileParams struct to be virNetDevVPortProfile, and rename the APIs to match this prefix. *

Re: [libvirt] [PATCH 12/33] Fix error reporting in port profile parsing/formatting APIs

2011-11-14 Thread Daniel P. Berrange
On Wed, Nov 09, 2011 at 02:58:32AM -0500, Laine Stump wrote: After applying this patch, make fails with: CC libvirt_util_la-network.lo cc1: warnings being treated as errors util/network.c: In function 'virNetDevVPortProfileParse': util/network.c:712:23: error: assignment makes pointer

Re: [libvirt] PATCH: Fix build without MACVTAP

2011-11-14 Thread Stefan Berger
On 11/12/2011 06:39 AM, Michael Wood wrote: Hi Commit c31d23a78715f1144c73862c46ab0436de8b5e85 removed the conn parameter from qemuPhysIfaceConnect(), but it's still used if WITH_MACVTAP is false. Also, it's still mentioned in the comment above the function: From

Re: [libvirt] [RFC PATCH v2 0/4] Libvirt for PowerPC

2011-11-14 Thread Stefan Berger
On 11/14/2011 09:43 AM, Prerna Saxena wrote: Hi, Recent development in KVM for 64-bit Power ISA Book3S machines, allows users to run multiple KVM guest instances on POWER7 and PPC970 processor based systems. Also qemu-system-ppc64 has been enhanced to support a new machine type pseries suitable

[libvirt] [libvirt-glib PATCH] Add vapi dependency to Makefile.am and fix parallel build

2011-11-14 Thread nirbheek
From: Nirbheek Chauhan nirbh...@gentoo.org libvirt-glib-1.0.vapi is needed to generate libvirt-gobject-1.0.vapi Without an explicit dependency, make -jN fails Signed-off-by: Nirbheek Chauhan nirbh...@gentoo.org --- vapi/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libvirt] Bridged Networking Wiki Up-to-Date?

2011-11-14 Thread Eli Qiao
? 2011?11?13? 10:38, Bob Cochran ??: Greetings, I just installed Fedora 16 on a new server and want to create a Fedora 16 virtual machine. I have not created or used VMs on Fedora in quite some time. Now I have several compelling reasons to use Fedora virtualization so I am kind of coming

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-14 Thread Eric Blake
On 11/13/2011 09:08 PM, MATSUDA, Daiki wrote: NACK. There is nothing inherently wrong with the source file not being a qcow2 file. The whole point of creating a runtime snapshot is that the original file (of _any_ format) becomes the backing file of a new qcow2 file, so that the original

Re: [libvirt] [PATCH 5/5] blkiotune: add qemu support for blkiotune.device_weight

2011-11-14 Thread Eric Blake
On 11/08/2011 06:05 AM, Stefan Berger wrote: On 11/08/2011 06:00 AM, Hu Tao wrote: Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c | 22 +

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-14 Thread Stefan Berger
On 11/11/2011 04:54 PM, Justin Clift wrote: On 12/11/2011, at 8:06 AM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-14 Thread Stefan Berger
On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function 'virBufferEscape': util/buf.c:469: warning:

Re: [libvirt] [RFC PATCH v2 0/4] Libvirt for PowerPC

2011-11-14 Thread Prerna Saxena
On 11/15/2011 02:36 AM, Stefan Berger wrote: On 11/14/2011 09:43 AM, Prerna Saxena wrote: Hi, Recent development in KVM for 64-bit Power ISA Book3S machines, allows users to run multiple KVM guest instances on POWER7 and PPC970 processor based systems. Also qemu-system-ppc64 has been enhanced

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-14 Thread Eric Blake
On 11/14/2011 05:54 PM, Stefan Berger wrote: On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function

[libvirt] [PATCHv4 0/4] implement per-device cgroup blkio weight in qemu

2011-11-14 Thread Eric Blake
v8: two new bug cleanup commits, move major()/minor() handling out of domain_conf.c into cgroup.c, and fix behavior when more than one device is listed, add a test for xml parsing. v7 was here (1-3 are already applied, 4-5 of that series are now 3-4):

[libvirt] [PATCHv4 1/4] API: prevent query of --live and --config at once

2011-11-14 Thread Eric Blake
Drivers were inconsistent when presented both --live and --config at once. For example, within qemu, getting memory parameters favored live, while getting blkio tuning favored config. Some, but not all, attempts to mix flags on query were filtered at the virsh level, but we shouldn't have to

[libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-14 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com This adds per-device weights to blkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the domain definition rather than tied to individual devices/disk

[libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-14 Thread Lei Li
This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 69 src/driver.h | 18 +

[libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-14 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c | 20 ++ src/qemu/qemu_driver.c

[libvirt] [PATCHv4 2/4] qemu: fix blkiotune --live --config

2011-11-14 Thread Eric Blake
Without this, 'virsh blkiotune --live --config --weight=n' only affected live. * src/qemu/qemu_driver.c (qemuDomainSetBlkioParameters): Allow setting both configurations at once. --- src/qemu/qemu_driver.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH 6/8] Doc: Add description and validation for blkdeviotune

2011-11-14 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- docs/formatdomain.html.in | 31 +++ docs/schemas/domaincommon.rng | 24 2 files changed, 55 insertions(+), 0 deletions(-) diff

[libvirt] [PATCH 0/8 v4] Summary on block IO throttle

2011-11-14 Thread Lei Li
Changes since V3 - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. - Relevant changes to remote driver, qemu driver, python support and virsh. Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config

[libvirt] [PATCH 4/8] Support block I/O throtte in XML

2011-11-14 Thread Lei Li
Enable block I/O throttle for per-disk in XML. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 101 +- src/conf/domain_conf.h | 12 ++ src/qemu/qemu_command.c |

[libvirt] [PATCH 8/8] Add tests for blkdeviotune

2011-11-14 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- .../qemuxml2argv-blkdeviotune.args |5 +++ .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml | 37 tests/qemuxml2argvtest.c

[libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-14 Thread Lei Li
Support Block I/O Throttle setting and query to remote driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- daemon/remote.c | 109 ++ src/remote/remote_driver.c | 96

[libvirt] [PATCH 7/8] Support virDomain{Set, Get}BlockIoThrottle in the python API

2011-11-14 Thread Lei Li
Python support for both setting and getting block I/O throttle. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- python/generator.py |2 + python/libvirt-override-api.xml | 16 python/libvirt-override.c | 178

[libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-14 Thread Lei Li
This patch implement the block I/O throttle setting and getting support to qemu driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 340 ++ src/qemu/qemu_monitor.c

[libvirt] [PATCH 5/8] Enable the blkdeviotune command in virsh

2011-11-14 Thread Lei Li
Support virsh command blkdeviotune. Can set or query a block disk I/O throttle setting. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- tools/virsh.c | 240 +++ tools/virsh.pod | 23

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-14 Thread Eric Blake
On 11/14/2011 09:33 PM, Lei Li wrote: This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. +/** + * virDomainSetBlockIoTune: + * @dom: pointer to domain object + * @disk: Fully-qualified disk name Hmm. Fully-qualified name here, + * @params: Pointer to blkio

Re: [libvirt] [PATCHv4 0/4] implement per-device cgroup blkio weight in qemu

2011-11-14 Thread Eric Blake
On 11/14/2011 09:29 PM, Eric Blake wrote: Oops - subject line glitch - this is v8, not v4. v8: two new bug cleanup commits, move major()/minor() handling out of domain_conf.c into cgroup.c, and fix behavior when more than one device is listed, add a test for xml parsing. v7 was here (1-3

Re: [libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-14 Thread Eric Blake
On 11/14/2011 09:33 PM, Lei Li wrote: Support Block I/O Throttle setting and query to remote driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com + +struct remote_domain_get_block_io_throttle_args { +remote_nonnull_domain dom; +

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-14 Thread Lei Li
On 11/15/2011 12:46 PM, Eric Blake wrote: On 11/14/2011 09:33 PM, Lei Li wrote: This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. +/** + * virDomainSetBlockIoTune: + * @dom: pointer to domain object + * @disk: Fully-qualified disk name Hmm. Fully-qualified name

Re: [libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-14 Thread Hu Tao
On Mon, Nov 14, 2011 at 09:30:01PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com This adds per-device weights to blkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-14 Thread Hu Tao
On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c