Re: [libvirt] domjobabort return the same error in distinct cases

2011-12-05 Thread Shahar Havivi
On 04.12.11 18:20, Shahar Havivi wrote: Hi, I am using the python api: domain.abortjob(), if there is no job I get exception with error code: VIR_ERR_OPERATION_INVALID with the error message: 'Requested operation is not valid: no job is active on the domain' when there is a job I

[libvirt] [FW: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release]

2011-12-05 Thread Daniel P. Berrange
- Forwarded message from Anthony Liguori aligu...@us.ibm.com - Date: Thu, 01 Dec 2011 15:23:37 -0600 From: Anthony Liguori aligu...@us.ibm.com To: qemu-devel qemu-de...@nongnu.org Subject: [Qemu-devel] [ANNOUNCE] QEMU 1.0 release On behalf of the QEMU Team, I'd like to announce the

Re: [libvirt] [PATCH] remote_driver: don't fail if keepalive check fails

2011-12-05 Thread Jiri Denemark
On Sun, Dec 04, 2011 at 15:42:29 +0100, Guido Günther wrote: Otherwise connections to older libvirt abort with: $ virsh -c qemu+ssh://host.example.com/system list error: invalid connection pointer in virDrvSupportsFeature error: failed to connect to the hypervisor Tested against 0.8.3 and

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Christophe Fergeau
This is exactly the same patch as the one you sent before isn't it? What about the g_set_error VS gvir_error_new concerns? How do we handle this? Christophe On Sat, Dec 03, 2011 at 01:44:48AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---

Re: [libvirt] [PATCH] build: fix build on Cygwin

2011-12-05 Thread Daniel P. Berrange
On Sat, Dec 03, 2011 at 01:03:08PM -0700, Eric Blake wrote: The RPC fixups needed on Linux are also needed on cygwin, and worked without further tweaking to the list of fixups. Also, unlike BSD, Cygwin exports 'struct ifreq', but unlike Linux, Cygwin lacks the ioctls that we were using

Re: [libvirt] [libvirt-glib] Add gvir_config_domain_set_lifecycle

2011-12-05 Thread Daniel P. Berrange
On Fri, Dec 02, 2011 at 05:23:12PM +0100, Christophe Fergeau wrote: This is used to control what happens (restart, stop, ...) to the VM when it crashes, shuts down, ... --- libvirt-gconfig/libvirt-gconfig-domain.c | 20 libvirt-gconfig/libvirt-gconfig-domain.h |

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Daniel P. Berrange
On Sat, Dec 03, 2011 at 12:11:04AM +0200, Zeeshan Ali (Khattak) wrote: On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org +    if

[libvirt] [PATCH] Introduce gvir_set_error (and friends) convert all code

2011-12-05 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The pattern GError **error; *err = gvir_error_new(...) is dangerous because 'err' could be NULL, and it is tedious to expect everyone to check. Introduce a new set of APIs for setting errors gvir_set_error(err, ...) and convert

Re: [libvirt] [libvirt-glib] Add gvir_xml_set_error

2011-12-05 Thread Daniel P. Berrange
On Fri, Dec 02, 2011 at 06:00:15PM +0100, Christophe Fergeau wrote: This mirrors g_set_error, but uses gvir_xml_error_new. The main benefit of using gvxr_xml_set_error over gvir_xml_error_new is that it handles NULL GError **. --- libvirt-gconfig/libvirt-gconfig-helpers-private.h |2 +

Re: [libvirt] [libvirt-glib 1/2] Add gvir_set_error[_literal]

2011-12-05 Thread Daniel P. Berrange
On Sat, Dec 03, 2011 at 12:39:20AM +0100, Christophe Fergeau wrote: They mirror g_set_error[_literal] functionality but append the error reported by libvirt to the error message. --- libvirt-glib/libvirt-glib-error.c | 49 +

Re: [libvirt] [PATCH 0/5] Interface pools and passthrough mode

2011-12-05 Thread Daniel P. Berrange
On Tue, Nov 29, 2011 at 08:29:35PM -0500, Laine Stump wrote: On 11/29/2011 02:53 PM, Daniel P. Berrange wrote: On Tue, Nov 29, 2011 at 03:46:13PM +, Shradha Shah wrote: Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap a direct connection to

Re: [libvirt] [RFC v5 PATCH 0/5] PowerPC : Extend Libvirt for PowerPC architecture

2011-12-05 Thread Daniel P. Berrange
On Fri, Dec 02, 2011 at 02:31:13PM -0500, Stefan Berger wrote: On 12/02/2011 11:54 AM, Prerna Saxena wrote: Libvirt continues to be the key interface to configure and manage the KVM guest instances on x86. This patch set is an effort to enable libvirt to support KVM guest configuration and

Re: [libvirt] [PATCH 1/2] python: Expose binding for virNodeGetCPUStats()

2011-12-05 Thread Peter Krempa
On 12/02/2011 06:19 PM, Eric Blake wrote: ACK with nits fixed, and worth including in 0.9.8. Thanks, fixed pushed. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/2] python: Expose binding for virNodeGetMemoryStats()

2011-12-05 Thread Peter Krempa
On 12/02/2011 06:23 PM, Eric Blake wrote: Copy and paste, so not a problem with this patch any more so than the other functions that used the same code pattern, but can PyDict_SetItem fail? If so, should be be reclaiming the entries added so far before returning overall failure, instead of

Re: [libvirt] [libvirt-glib] Add gvir_xml_set_error

2011-12-05 Thread Christophe Fergeau
On Mon, Dec 05, 2011 at 11:27:04AM +, Daniel P. Berrange wrote: On Fri, Dec 02, 2011 at 06:00:15PM +0100, Christophe Fergeau wrote: This mirrors g_set_error, but uses gvir_xml_error_new. The main benefit of using gvxr_xml_set_error over gvir_xml_error_new is that it handles NULL GError

Re: [libvirt] [PATCH] Introduce gvir_set_error (and friends) convert all code

2011-12-05 Thread Christophe Fergeau
On Mon, Dec 05, 2011 at 11:25:31AM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The pattern GError **error; *err = gvir_error_new(...) is dangerous because 'err' could be NULL, and it is tedious to expect everyone to check. Introduce a

Re: [libvirt] [PATCH] remote_driver: don't fail if keepalive check fails

2011-12-05 Thread Guido Günther
On Mon, Dec 05, 2011 at 11:54:54AM +0100, Jiri Denemark wrote: On Sun, Dec 04, 2011 at 15:42:29 +0100, Guido Günther wrote: Otherwise connections to older libvirt abort with: $ virsh -c qemu+ssh://host.example.com/system list error: invalid connection pointer in virDrvSupportsFeature

Re: [libvirt] [PATCH] Add support for QEMU 1.0

2011-12-05 Thread Jiri Denemark
On Fri, Dec 02, 2011 at 13:31:28 -0700, Eric Blake wrote: On 12/02/2011 01:29 PM, Jiri Denemark wrote: --- src/qemu/qemu_capabilities.c | 15 ++- tests/qemuhelpdata/qemu-1.0| 252 tests/qemuhelpdata/qemu-1.0-device | 138

[libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4 libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 30 insertions(+), 0 deletions(-)

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 5, 2011 at 1:10 PM, Christophe Fergeau cferg...@redhat.com wrote: This is exactly the same patch as the one you sent before isn't it? What about the g_set_error VS gvir_error_new concerns? How do we handle this? Oops! Forgot to commit. :( -- Regards, Zeeshan Ali (Khattak) FSF

[libvirt] [PATCH] examples: Update event tests for shutdown event

2011-12-05 Thread Jiri Denemark
--- examples/domain-events/events-c/event-test.c | 22 ++- examples/domain-events/events-python/event-test.py |6 +++- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/examples/domain-events/events-c/event-test.c

Re: [libvirt] [PATCH] Introduce gvir_set_error (and friends) convert all code

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 12:59:36PM +0100, Christophe Fergeau wrote: On Mon, Dec 05, 2011 at 11:25:31AM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The pattern GError **error; *err = gvir_error_new(...) is dangerous because

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 03:21:54PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4

Re: [libvirt] [PATCH] qemu: Rework handling of shutdown event

2011-12-05 Thread Jiri Denemark
On Fri, Dec 02, 2011 at 09:22:37 -0700, Eric Blake wrote: On 12/02/2011 08:02 AM, Jiri Denemark wrote: When QEMU guest finishes its shutdown sequence, qemu stops virtual CPUs and when started with -no-shutdown waits for us to kill it using SGITERM. Since QEMU is flushing its internal

Re: [libvirt] [PATCH] qemu: Rework handling of shutdown event

2011-12-05 Thread Daniel P. Berrange
On Fri, Dec 02, 2011 at 09:22:37AM -0700, Eric Blake wrote: On 12/02/2011 08:02 AM, Jiri Denemark wrote: When QEMU guest finishes its shutdown sequence, qemu stops virtual CPUs and when started with -no-shutdown waits for us to kill it using SGITERM. Since QEMU is flushing its internal

Re: [libvirt] Add console support

2011-12-05 Thread Daniel P. Berrange
On Fri, Dec 02, 2011 at 02:40:03PM +0100, Christophe Fergeau wrote: Hi, This patch series adds support for setting console nodes as has been discussed in the [PATCH libvirt-glib 02/15] Add objects for dealing with console devices thread. It introduces a GVirConfigDomainChardev which

[libvirt] [PATCH v4] Implement DNS SRV record into the bridge driver

2011-12-05 Thread Michal Novotny
Hi, this is the fourth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man page and tests for both xml2xml and xml2argv were added as well. This

[libvirt] [PATCH] Fix incorrect symbols for virtime.h module breaking Mingw32

2011-12-05 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The Mingw32 linker highlighted that the symbols for virtime.h declared in libvirt_private.syms were incorrect * src/libvirt_private.syms: Fix virtime.h symbols --- src/libvirt_private.syms |9 ++--- 1 files changed, 6 insertions(+), 3

[libvirt] KVM call agenda for 12/6 (Tuesday) @ 10am US/Eastern

2011-12-05 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Proposal (from Anthony): 1. A short introduction to each of the guest agents, what guests they support, and what verbs they support. 2. A short description of key requirements from each party (oVirt, libvirt, QEMU) for a

Re: [libvirt] Add console support

2011-12-05 Thread Christophe Fergeau
On Mon, Dec 05, 2011 at 01:35:52PM +, Daniel P. Berrange wrote: On Fri, Dec 02, 2011 at 02:40:03PM +0100, Christophe Fergeau wrote: Hi, This patch series adds support for setting console nodes as has been discussed in the [PATCH libvirt-glib 02/15] Add objects for dealing with

Re: [libvirt] [PATCH 00/10] Console coruption with two or more clients series

2011-12-05 Thread Dave Allan
On Thu, Dec 01, 2011 at 04:35:10PM +0100, Peter Krempa wrote: On 10/18/2011 12:34 PM, Daniel P. Berrange wrote: On Wed, Oct 12, 2011 at 03:43:10PM +0200, Peter Krempa wrote: This series fixes anoying console corruption if two clients try to connect at same time to the console. The current

[libvirt] [libvirt-glib] Use gvir_error_set_literal in more places

2011-12-05 Thread Christophe Fergeau
GVirConnection has some gvir_set_error uses that can be replaced by gvir_set_error_set_literal. When passing a single string, this is safer since we are guaranteed that unwanted printf-format sequences in the string won't cause issues. --- libvirt-gobject/libvirt-gobject-connection.c | 22

Re: [libvirt] Add console support

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 05:13:54PM +0100, Christophe Fergeau wrote: On Mon, Dec 05, 2011 at 01:35:52PM +, Daniel P. Berrange wrote: On Fri, Dec 02, 2011 at 02:40:03PM +0100, Christophe Fergeau wrote: Hi, This patch series adds support for setting console nodes as has been

Re: [libvirt] In freeze for libvirt-0.9.8 and availability of rc2

2011-12-05 Thread Eric Blake
On 12/04/2011 02:26 AM, Peter Krempa wrote: I tried building rc2 on my macbook and build was successful, but I've got a warning on each file built: cc1: warning: command line option -Wabi is valid for C++/ObjC++ but not for C cc1: warning: command line option -Wdeprecated is valid for

Re: [libvirt] [PATCH] examples: Update event tests for shutdown event

2011-12-05 Thread Eric Blake
On 12/05/2011 06:22 AM, Jiri Denemark wrote: --- examples/domain-events/events-c/event-test.c | 22 ++- examples/domain-events/events-python/event-test.py |6 +++- 2 files changed, 20 insertions(+), 8 deletions(-) ACK. And since it only touches examples, we can

[libvirt] [PATCH 2/3] spec: add dmidecode as prereq

2011-12-05 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=754909 complains that because libvirt didn't require dmidecode, that the logs are noisy and virConnectGetSysinfo needlessly fails. Even 'virt-what' requires dmidecode, so it's not that onerous of a dependency. We may be able to drop this in the future

[libvirt] [PATCH 3/3] spec: fix sanlock dependency

2011-12-05 Thread Eric Blake
* libvirt.spec.in (with_sanlock): On RHEL, don't force sanlock on architectures where it isn't available. --- libvirt.spec.in | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 35762a5..39c814a 100644 --- a/libvirt.spec.in +++

Re: [libvirt] [PATCH 3/3] spec: fix sanlock dependency

2011-12-05 Thread Eric Blake
On 12/05/2011 10:38 AM, Eric Blake wrote: * libvirt.spec.in (with_sanlock): On RHEL, don't force sanlock on architectures where it isn't available. --- libvirt.spec.in | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index

Re: [libvirt] [PATCH 1/3] spec: always autoreconf when building rpm

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 10:38:49AM -0700, Eric Blake wrote: Over time, Fedora and RHEL RPMs have often backported upstream patches that touched configure.ac and/or Makefile.am; this necessitates rerunning the autotools for the patch to be effective. Making this part of the spec file will make

Re: [libvirt] [PATCH 3/3] spec: fix sanlock dependency

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 10:38:51AM -0700, Eric Blake wrote: * libvirt.spec.in (with_sanlock): On RHEL, don't force sanlock on architectures where it isn't available. --- libvirt.spec.in | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in

Re: [libvirt] [PATCH 2/3] spec: add dmidecode as prereq

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 10:38:50AM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=754909 complains that because libvirt didn't require dmidecode, that the logs are noisy and virConnectGetSysinfo needlessly fails. Even 'virt-what' requires dmidecode, so it's not that

Re: [libvirt] [PATCH 00/14] Add a virtlockd lock manager daemon

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 06:54:08PM +0100, Guido Günther wrote: On Thu, Jul 07, 2011 at 03:17:18PM +0100, Daniel P. Berrange wrote: The lock manager infrastructure we recently added to QEMU only has two possible drivers at this time, 'nop' and 'sanlock'. The former does absolutely nothing,

Re: [libvirt] [PATCH 00/14] Add a virtlockd lock manager daemon

2011-12-05 Thread Guido Günther
On Thu, Jul 07, 2011 at 03:17:18PM +0100, Daniel P. Berrange wrote: The lock manager infrastructure we recently added to QEMU only has two possible drivers at this time, 'nop' and 'sanlock'. The former does absolutely nothing, while the latter requires a 3rd party package installed and is a

Re: [libvirt] [PATCH 2/3] spec: add dmidecode as prereq

2011-12-05 Thread Eric Blake
On 12/05/2011 10:54 AM, Daniel P. Berrange wrote: On Mon, Dec 05, 2011 at 10:38:50AM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=754909 complains that because libvirt didn't require dmidecode, that the logs are noisy and virConnectGetSysinfo needlessly fails. Even

Re: [libvirt] [PATCH 0/5] Interface pools and passthrough mode

2011-12-05 Thread Laine Stump
On 12/05/2011 06:37 AM, Daniel P. Berrange wrote: On Tue, Nov 29, 2011 at 08:29:35PM -0500, Laine Stump wrote: On 11/29/2011 02:53 PM, Daniel P. Berrange wrote: On Tue, Nov 29, 2011 at 03:46:13PM +, Shradha Shah wrote: Interface Pools and Passthrough mode: Current Method: The passthrough

[libvirt] [PATCHv2 1/3] spec: make it easier to autoreconf when building rpm

2011-12-05 Thread Eric Blake
Over time, Fedora and RHEL RPMs have often backported upstream patches that touched configure.ac and/or Makefile.am; this necessitates rerunning the autotools for the patch to be effective. Making this part of the spec file will make it easier for future backports to pull patches without thinking

Re: [libvirt] KVM Call Agenda for 12/6 (Tuesday) @ 10am US/Eastern

2011-12-05 Thread Chris Wright
* Chris Wright (chr...@redhat.com) wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: 1. A short introduction to each of the guest agents, what guests they support, and what verbs they support. I think we did this once before w/ Matahari. Can we please capture these things in email

[libvirt] Group for accessing one/all VM graphics and not virsh

2011-12-05 Thread Reeted
Hello libvirt people, is there a (preferably simple) way in Linux to allow a certain set of users to be able to do: virt-viewer --connect qemu+ssh://username@virthost/system vmname for connecting to virt-viewer BUT without letting them do all the other things that can be done with virsh?

Re: [libvirt] [PATCH v4] Implement DNS SRV record into the bridge driver

2011-12-05 Thread Eric Blake
On 12/05/2011 07:03 AM, Michal Novotny wrote: Hi, this is the fourth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man page and tests for

Re: [libvirt] [Qemu-devel] Guest Agent Summaries

2011-12-05 Thread Michael Roth
On 12/05/2011 01:21 PM, Chris Wright wrote: * Chris Wright (chr...@redhat.com) wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: 1. A short introduction to each of the guest agents, what guests they support, and what verbs they support. I think we did this once before w/ Matahari. Can

[libvirt] [PATCH 1/2] maint: use common xml quoting style

2011-12-05 Thread Eric Blake
According to the official XML specification [1], attributes can be specified with either ' or (where the difference is that you can use '' or 'quot;' but must use quot;, and conversely for ' or apos; vs. 'apos;'). But our code generation in src/conf prefers to output the '' notation, as it is

[libvirt] [PATCH 2/2] maint: extend xml quoting style to rng files

2011-12-05 Thread Eric Blake
See the previous patch for rationale. Done with: $ find docs -name '*.rng' | \ xargs sed -i 's/\([a-zA-Z0-9_]*=\)\([^]*\)/\1'\''\2'\''/g' * cfg.mk (sc_rng_quote_style): Extend the rule. * docs/schemas/*.rng: Fix fallout. --- Alas, this diffstat is too big to send to the list uncompressed;

Re: [libvirt] [PATCH 1/2] maint: use common xml quoting style

2011-12-05 Thread Eric Blake
On 12/05/2011 02:48 PM, Eric Blake wrote: According to the official XML specification [1], attributes can be specified with either ' or (where the difference is that you can use '' or 'quot;' but must use quot;, and conversely for ' or apos; vs. 'apos;'). But our code generation in src/conf

[libvirt] [PATCH 3/2] maint: extend xml quoting style to html docs

2011-12-05 Thread Eric Blake
See the previous patch for rationale. Done with: $ find docs -name '*.html.in' | \ xargs sed -i '/lt;/ s/\([a-zA-Z0-9_]*=\)\([^]*\)/\1'\''\2'\''/g' * cfg.mk (sc_xml_quote_style): Extend the rule. * docs/*.html.in: Fix fallout. --- I'm not as worried about the overall html file being a

[libvirt] [PATCH] security: don't try to restore label on NFS if label failed

2011-12-05 Thread Eric Blake
I noticed that the logs contained messages like this: 2011-12-05 23:32:40.382+: 26569: warning : SELinuxRestoreSecurityFileLabel:533 : cannot lookup default selinux label for /nfs/libvirt/images/dom.img for all my domain images living on NFS. But if we would just remember that on domain

Re: [libvirt] [Qemu-devel] Guest Agent Summaries

2011-12-05 Thread Perry Myers
On 12/05/2011 04:36 PM, Michael Roth wrote: On 12/05/2011 01:21 PM, Chris Wright wrote: * Chris Wright (chr...@redhat.com) wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: 1. A short introduction to each of the guest agents, what guests they support, and what verbs they support. I

[libvirt] Coverity automatic detection

2011-12-05 Thread Alex Jia
This email is automatically generated. The test result is based on the following git commit: d336dbd spec: fix sanlock dependency Analysis summary report: Files analyzed : 241 Total LoC input to cov-analyze : 328912 Functions analyzed : 7999