Re: [libvirt] [PATCH V4 3/5] add nodeGetCPUmap.

2012-02-02 Thread KAMEZAWA Hiroyuki
On Tue, 31 Jan 2012 17:58:17 +0800 Hu Tao hu...@cn.fujitsu.com wrote: + +/** + * virBitmapParseCommaSeparatedFormat: + * + * When bitmap is printed in ascii format, expecially in Linux, s/expecially/especially/ + * comma-separated format is sometimes used. For example, a bitmap

Re: [libvirt] [PATCH] virsh: Plug memory leak on cmdUndefine

2012-02-02 Thread Peter Krempa
On 02/02/2012 07:25 AM, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com --- tools/virsh.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index c8fd448..73c2192 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2787,10

Re: [libvirt] [PATCH v3 3/7] virsh: add support for VIR_DOMAIN_CONSOLE_* flags

2012-02-02 Thread Peter Krempa
On 02/02/2012 01:43 AM, Eric Blake wrote: On 01/26/2012 10:16 AM, Peter Krempa wrote: This patch adds support for the newly introduced VIR_DOMAIN_CONSOLE_FORCE and VIR_DOMAIN_CONSOLE_SAFE flags. The console command now has an optional parameter --force that specifies that the user wants to

Re: [libvirt] [PATCH 1/2 v3] Python: Refactoring virTypedParameter conversion for NUMA tuning APIs

2012-02-02 Thread Guannan Ren
Could anyone please help to review these patchset? Thanks :) On 01/28/2012 10:53 PM, Guannan Ren wrote: *virDomainSetNumaParameters *virDomainGetNumaParameters --- python/Makefile.am |4 +- python/libvirt-override-api.xml | 13 ++

Re: [libvirt] [vdsm] oVirt Live Snapshots

2012-02-02 Thread Shu Ming
Can someone explain what is DB in this wiki page? See, Live snapshots operation extend regular snapshots as follow: * Create a locked snapshot in DB On 2012-1-30 19:00, Federico Simoncelli wrote: Hi, oVirt, and more specifically VDSM, is currently implementing the live snapshot

Re: [libvirt] [PATCHv3 1/4] xml: Add element title to allow short description of domains

2012-02-02 Thread Daniel Veillard
On Wed, Feb 01, 2012 at 02:03:49PM +0100, Peter Krempa wrote: This patch adds a new element title to the domain XML. This attribute can hold a short title defined by the user to ease the identification of domains. The title may not contain newlines and should be reasonably short.

Re: [libvirt] [vdsm] oVirt Live Snapshots

2012-02-02 Thread Federico Simoncelli
- Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-de...@nongnu.org, libvir-list@redhat.com, VDSM Project Development vdsm-de...@lists.fedorahosted.org, Dave Allan dal...@redhat.com, Eric Blake ebl...@redhat.com Sent:

Re: [libvirt] [PATCHv3 2/4] API: Add api to set and get domain metadata

2012-02-02 Thread Daniel Veillard
On Wed, Feb 01, 2012 at 02:03:50PM +0100, Peter Krempa wrote: This patch adds API to modify domain metadata for running and stopped domains. The api supports changing description, title as well as the newly added metadata element. The API has support for storing data in the metadata element

Re: [libvirt] [PATCH] vmware: detect when a domain was shut down from the inside

2012-02-02 Thread Daniel Veillard
On Wed, Feb 01, 2012 at 02:29:37PM +0100, Jean-Baptiste Rouault wrote: This patch adds an internal function vmwareGetVMStatus to get the real state of the domain. This function is used in various places in the driver, in particular to detect when the domain has been shut down by the user with

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-02 Thread Cole Robinson
On 02/02/2012 08:54 AM, Cheer Xiao wrote: 2012/2/2 Cole Robinson crobi...@redhat.com: On 02/02/2012 08:05 AM, Cheer Xiao wrote: Hi all, I was setting up libvirt and virt-manager for managing Xen VMs. But when I hit New in virt-manager to provision a new VM, virt-manager gives me the error:

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-02 Thread Cheer Xiao
2012/2/2 Cole Robinson crobi...@redhat.com: On 02/02/2012 08:54 AM, Cheer Xiao wrote: 2012/2/2 Cole Robinson crobi...@redhat.com: On 02/02/2012 08:05 AM, Cheer Xiao wrote: Hi all, I was setting up libvirt and virt-manager for managing Xen VMs. But when I hit New in virt-manager to provision

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-02 Thread Cole Robinson
On 02/02/2012 09:07 AM, Cheer Xiao wrote: 2012/2/2 Cole Robinson crobi...@redhat.com: On 02/02/2012 08:54 AM, Cheer Xiao wrote: 2012/2/2 Cole Robinson crobi...@redhat.com: On 02/02/2012 08:05 AM, Cheer Xiao wrote: Hi all, I was setting up libvirt and virt-manager for managing Xen VMs. But

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-02 Thread Ansis Atteka
Libvirt has a function virNetDevBridgeRemovePort() which can remove port from the Linux Bridge, but it seems that no one calls it. Wanted to confirm if port removal happens automatically for Linux Bridges if VM goes down? The difference between OVS and Linux Bridge is that OVS will need a hook

[libvirt] Small postpone of the 0.9.10 freeze

2012-02-02 Thread Daniel Veillard
I'm finally back from vacation, and looking at the list it seems there is many patches floating that should be pushed for 0.9.10 . I suggest then to take a few more days to try to push patches especially about APIs, and enter the freeze on Monday instead. So we have a couple more working days to

Re: [libvirt] link failure on RHEL 5

2012-02-02 Thread Eric Blake
On 02/01/2012 05:29 PM, Eric Blake wrote: I haven't investigated what is missing in the Makefiles, but I'm getting link failures on RHEL 5: ../src/.libs/libvirt_driver_nwfilter.a(libvirt_driver_nwfilter_la-nwfilter_ebiptables_driver.o): In function `_printDataType':

Re: [libvirt] [PATCH v3 3/7] virsh: add support for VIR_DOMAIN_CONSOLE_* flags

2012-02-02 Thread Eric Blake
On 02/02/2012 04:04 AM, Peter Krempa wrote: What you have is good, but you should also add --safe and --force to 'virsh start --console' and 'virsh create --console'. Hmm, for virsh start, naming it --force might be risky since we already have --force-boot; there, I might go --force-console.

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-02 Thread Cheer Xiao
2012/2/2 Cole Robinson crobi...@redhat.com: ... [snip] ... Okay, libvirt is detecting things correctly. So why is virt-manager confused? Using that capabilities output works for me. What virt-manager version are you using? Can you run virt-manager with --debug, connect to xen, open the 'new

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-02 Thread Laine Stump
On 02/02/2012 09:30 AM, Ansis Atteka wrote: Libvirt has a function virNetDevBridgeRemovePort() which can remove port from the Linux Bridge, but it seems that no one calls it. Wanted to confirm if port removal happens automatically for Linux Bridges if VM goes down? I didn't write that code,

[libvirt] [PATCH v2 0/1] netlink events

2012-02-02 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name This is the second version of the netlink event code. it has most of the proposed changes by Eric and Daniel included. DirkH D. Herrendoerfer (1): Add netlink message event service daemon/libvirtd.c|9 + src/Makefile.am

Re: [libvirt] [PATCH 1/2 v3] Python: Refactoring virTypedParameter conversion for NUMA tuning APIs

2012-02-02 Thread Eric Blake
On 01/28/2012 07:53 AM, Guannan Ren wrote: *virDomainSetNumaParameters *virDomainGetNumaParameters --- python/Makefile.am |4 +- python/libvirt-override-api.xml | 13 ++ python/libvirt-override.c | 314 +++ 3

[libvirt] [PATCHv2 1/2] qemu: new GRACEFUL flag for virDomainDestroy w/ QEMU support

2012-02-02 Thread Laine Stump
When libvirt's virDomainDestroy API is shutting down the qemu process, it first sends SIGTERM, then waits for 1.6 seconds and, if it sees the process still there, sends a SIGKILL. There have been reports that this behavior can lead to data loss because the guest running in qemu doesn't have time

[libvirt] [PATCHv2 0/2] qemu: new GRACEFUL flag for virDomainDestroy

2012-02-02 Thread Laine Stump
This is the 2nd attempt at solving the problem of virDomainDestroy uncermoniously sending SIGKILL to the qemu process before it's had a chance to flush its disk buffers. In v1, I altered the default behavior of virDomainDestroy(), but that was rejected as changing established API behavior. In v2,

Re: [libvirt] [PATCH 2/2 v3] Python: modify other functions to use {get, set}PyVirTypedParameter

2012-02-02 Thread Eric Blake
On 01/28/2012 07:53 AM, Guannan Ren wrote: *libvirt_virDomainBlockStatsFlags *libvirt_virDomainGetSchedulerParameters *libvirt_virDomainGetSchedulerParametersFlags *libvirt_virDomainSetSchedulerParameters *libvirt_virDomainSetSchedulerParametersFlags

[libvirt] [PATCHv2 2/2] qemu: increase the timeout before sending SIGKILL to qemu process

2012-02-02 Thread Laine Stump
The current default method of terminating the qemu process is to send a SIGTERM, wait for up to 1.6 seconds for it to cleanly shutdown, then send a SIGKILL and wait for up to 1.4 seconds more for the process to terminate. This is problematic because occasionally 1.6 seconds is not long enough for

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-02 Thread Ansis Atteka
On Thu, Feb 2, 2012 at 6:08 PM, Laine Stump la...@laine.org wrote: On 02/02/2012 09:30 AM, Ansis Atteka wrote: Libvirt has a function virNetDevBridgeRemovePort() which can remove port from the Linux Bridge, but it seems that no one calls it. Wanted to confirm if port removal happens

Re: [libvirt] [PATCH v2 1/1] Add netlink message event service

2012-02-02 Thread Laine Stump
On 02/02/2012 11:22 AM, D. Herrendoerfer wrote: From: D. Herrendoerferd.herrendoer...@herrendoerfer.name This is the second version of the netlink event code. it has most of the proposed changes by Eric and Daniel included. (actually Laine and Daniel :-) From: D.

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-02 Thread Ansis Atteka
On Thu, Feb 2, 2012 at 10:10 PM, Laine Stump la...@laine.org wrote: On 02/02/2012 01:28 PM, Ansis Atteka wrote: On Thu, Feb 2, 2012 at 6:08 PM, Laine Stump la...@laine.org wrote: On 02/02/2012 09:30 AM, Ansis Atteka wrote: Libvirt has a function virNetDevBridgeRemovePort() which can

[libvirt] [PATCH 1/1] Add detail to documentation on storage pools and volumes.

2012-02-02 Thread Dave Allan
The storage pools page contains details about the capabilities of the various pool types, but not an overview of how they are intended to be used. This patch adds some explanation of what pools and volumes can be used for and why an administrator might want to use them. --- docs/storage.html.in

Re: [libvirt] [PATCH 1/1] Add detail to documentation on storage pools and volumes.

2012-02-02 Thread Eric Blake
On 02/02/2012 03:06 PM, Dave Allan wrote: The storage pools page contains details about the capabilities of the various pool types, but not an overview of how they are intended to be used. This patch adds some explanation of what pools and volumes can be used for and why an administrator

[libvirt] [PATCH] command: allow merging stdout and stderr in string capture

2012-02-02 Thread Eric Blake
Sometimes, its easier to run children with 21 in shell notation, and just deal with stdout and stderr interleaved. This was already possible for fd handling; extend it to also work when doing string capture of a child process. * docs/internals/command.html.in: Document this. * src/util/command.c

[libvirt] [PATCH 0/5] switch python bindings to use libvirt_util

2012-02-02 Thread Eric Blake
As threatened here: https://www.redhat.com/archives/libvir-list/2012-February/msg00122.html and as requested here: https://www.redhat.com/archives/libvir-list/2012-January/msg00491.html along with some prerequisite patches. I was quite shocked when I discovered that we didn't have a syntax-check

[libvirt] [PATCH 2/5] python: drop redundant function

2012-02-02 Thread Eric Blake
I noticed some redundant code while preparing my next patch. * python/generator.py (py_types): Fix 'const char *' mapping. * python/typewrappers.h (libvirt_charPtrConstWrap): Drop. * python/typewrappers.c (libvirt_charPtrConstWrap): Delete, since it is identical to libvirt_constcharPtrWrap. ---

[libvirt] [PATCH 3/5] build: prohibit raw malloc and free

2012-02-02 Thread Eric Blake
Our HACKING discourages use of malloc and free, for at least a couple of years now. But we weren't enforcing it, until now :) For now, I've exempted python and tests, and will clean those up in subsequent patches. Examples should be permanently exempt, since anyone copying our examples won't

[libvirt] [PATCH 4/5] build: expand rule to cover testsuite

2012-02-02 Thread Eric Blake
The bulk of this patch was done with: sed -i 's/\(\bfree *(/VIR_FREE(/g' tests/*.c followed by fixing the few compile errors that resulted. * cfg.mk (exclude_file_name_regexp--sc_prohibit_raw_allocation): Remove tests from exemption. * tests/testutils.h: Add common header. *

[libvirt] [PATCH 1/5] build: clean up CPPFLAGS/INCLUDES usage

2012-02-02 Thread Eric Blake
Our syntax checker missed all-lower-case variables (this will be fixed by the next .gnulib update). Additionally, anywhere that we mix in-tree files with generated files, automake recommends listing builddir prior to srcdir for VPATH builds. * src/Makefile.am (*_la_CFLAGS): Favor $(top_srcdir).

[libvirt] [PATCH 5/5] python: use libvirt_util to avoid raw free

2012-02-02 Thread Eric Blake
This patch starts the process of elevating the python binding code to be on the same level as the rest of libvirt when it comes to requiring good coding styles. Statically linking against the libvirt_util library makes it much easier to write good code, rather than having to open-code and

Re: [libvirt] [PATCH v2 0/5] Introduce sVirt to LXC driver

2012-02-02 Thread Eric Blake
On 01/25/2012 07:12 AM, Daniel P. Berrange wrote: This is an update of https://www.redhat.com/archives/libvir-list/2012-January/msg00418.html Changes since v1: - Pushed the first 2 patches which passed review - Update to include all Eric's suggested changes - Rebase to latest GIT

Re: [libvirt] [PATCH] command: allow merging stdout and stderr in string capture

2012-02-02 Thread Laine Stump
On 02/02/2012 07:17 PM, Eric Blake wrote: Sometimes, its easier to run children with 21 in shell notation, and just deal with stdout and stderr interleaved. This was already possible for fd handling; extend it to also work when doing string capture of a child process. *

[libvirt] [PATCH] virsh: extension of virsh attach-disk for rawio

2012-02-02 Thread Taku Izumi
This patch extends virsh attach-disk command so that we can specify rawio attribute. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- tools/virsh.c |3 +++ tools/virsh.pod |3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) Index: libvirt/tools/virsh.c

Re: [libvirt] [PATCH] virsh: extension of virsh attach-disk for rawio

2012-02-02 Thread Osier Yang
On 2012年02月03日 12:33, Taku Izumi wrote: This patch extends virsh attach-disk command so that we can specify rawio attribute. Signed-off-by: Taku Izumiizumi.t...@jp.fujitsu.com --- tools/virsh.c |3 +++ tools/virsh.pod |3 ++- 2 files changed, 5 insertions(+), 1 deletion(-)