[libvirt] Are they reasonable FD leaks?

2012-02-03 Thread Alex Jia
Hi all, I met some FD leaks when I tried the following scenario: % dd if=/dev/null of=/var/lib/libvirt/images/foo bs=1 count=1 seek=10M % virsh define foo.xml (disk source file points to '/var/lib/libvirt/images/foo') % virsh vol-clone foo foo-clone default (the original guest

Re: [libvirt] Are they reasonable FD leaks?

2012-02-03 Thread Alex Jia
If you're using libvirt upstream to check it, you need to revoke commit 6152c74, which fixed memory leak issue on cmdUndefine(), it's okay without FD leaks if memory leak is fixed, in other words, you will met FD leaks if you saw the following similar error information: error: Failed to

Re: [libvirt] [PATCHv2 1/2] qemu: new GRACEFUL flag for virDomainDestroy w/ QEMU support

2012-02-03 Thread Daniel Veillard
On Thu, Feb 02, 2012 at 12:54:28PM -0500, Laine Stump wrote: When libvirt's virDomainDestroy API is shutting down the qemu process, it first sends SIGTERM, then waits for 1.6 seconds and, if it sees the process still there, sends a SIGKILL. There have been reports that this behavior can lead

Re: [libvirt] [PATCH 1/2 v3] Python: Refactoring virTypedParameter conversion for NUMA tuning APIs

2012-02-03 Thread Guannan Ren
On 02/03/2012 01:48 AM, Eric Blake wrote: On 01/28/2012 07:53 AM, Guannan Ren wrote: *virDomainSetNumaParameters *virDomainGetNumaParameters --- python/Makefile.am |4 +- python/libvirt-override-api.xml | 13 ++ python/libvirt-override.c | 314

Re: [libvirt] [PATCHv2 2/2] qemu: increase the timeout before sending SIGKILL to qemu process

2012-02-03 Thread Daniel Veillard
On Thu, Feb 02, 2012 at 12:54:29PM -0500, Laine Stump wrote: The current default method of terminating the qemu process is to send a SIGTERM, wait for up to 1.6 seconds for it to cleanly shutdown, then send a SIGKILL and wait for up to 1.4 seconds more for the process to terminate. This is

[libvirt] [PATCH] conf: Plug memory on virDomainDiskDefParseXML

2012-02-03 Thread ajia
From: Alex Jia a...@redhat.com Detected by valgrind. Leak is introduced in commit 397e6a7. * src/conf/domain_conf.c(virDomainDiskDefParseXML): fix memory leak. How to reproduce? % make -C tests check TESTS=qemuxml2argvtest % cd tests valgrind -v --leak-check=full ./qemuxml2argvtest * Actual

Re: [libvirt] [PATCH] vmware: detect when a domain was shut down from the inside

2012-02-03 Thread Matthias Bolte
2012/2/1 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net: This patch adds an internal function vmwareGetVMStatus to get the real state of the domain. This function is used in various places in the driver, in particular to detect when the domain has been shut down by the user with the

[libvirt] [PATCH 1/4] virsh: Two new helper functions for disk device changes

2012-02-03 Thread Osier Yang
vshFindDisk is to find the disk node in xml doc with given target and flags (indicates disk type, normal disk or changeable disk). vshPrepareDiskXML is to make changes on the disk node (e.g. create and insert the new source node for inserting media of CDROM drive). --- tools/virsh.c | 207

[libvirt] [PATCH 4/4] virsh: Add document for cmdChangeMedia

2012-02-03 Thread Osier Yang
--- tools/virsh.pod | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 28ad422..6ac7d15 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1475,6 +1475,31 @@ option can be used to force device update, e.g.,

[libvirt] [PATCH 0/4 v2] New command for changing media

2012-02-03 Thread Osier Yang
[PATCH 0/4] introduces two new helper functions: vshFindDisk is to find the disk XML node in xml doc with the flags (indicates it's normal disk or changeable disk). VshPrepareDiskXML is to prepare the disk XML for disk changing commands' use, such as detach-disk. The purpose of this patch is to

[libvirt] [PATCH 2/4] virsh: Use vshFindDisk and vshPrepareDiskXML in cmdDetachDisk

2012-02-03 Thread Osier Yang
The first use of the two new helper functions. --- tools/virsh.c | 62 1 files changed, 9 insertions(+), 53 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index ca69f30..5dad1d6 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@

[libvirt] [PATCH 3/4] virsh: New command cmdChangeMedia

2012-02-03 Thread Osier Yang
One could use it to eject, insert, or update media of the CDROM or floppy drive. See the documents for more details. --- tools/virsh.c | 134 + 1 files changed, 134 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c

Re: [libvirt] [PATCH] conf: Plug memory on virDomainDiskDefParseXML

2012-02-03 Thread Osier Yang
On 2012年02月03日 16:42, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com Detected by valgrind. Leak is introduced in commit 397e6a7. * src/conf/domain_conf.c(virDomainDiskDefParseXML): fix memory leak. How to reproduce? % make -C tests check TESTS=qemuxml2argvtest % cd tests valgrind -v

Re: [libvirt] [PATCH 2/5] python: drop redundant function

2012-02-03 Thread Jiri Denemark
On Thu, Feb 02, 2012 at 17:33:21 -0700, Eric Blake wrote: I noticed some redundant code while preparing my next patch. * python/generator.py (py_types): Fix 'const char *' mapping. * python/typewrappers.h (libvirt_charPtrConstWrap): Drop. * python/typewrappers.c (libvirt_charPtrConstWrap):

Re: [libvirt] [PATCH 1/5] build: clean up CPPFLAGS/INCLUDES usage

2012-02-03 Thread Jiri Denemark
On Thu, Feb 02, 2012 at 17:33:20 -0700, Eric Blake wrote: Our syntax checker missed all-lower-case variables (this will be fixed by the next .gnulib update). Additionally, anywhere that we mix in-tree files with generated files, automake recommends listing builddir prior to srcdir for VPATH

Re: [libvirt] [libvirt-glib] Add gvir_storage_vol_resize()

2012-02-03 Thread Christophe Fergeau
ACK Christophe On Wed, Feb 01, 2012 at 10:32:02PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add wrapper for virStorageVolResize(). --- libvirt-gobject/libvirt-gobject-storage-vol.c | 27 +

Re: [libvirt] [PATCH 3/5] build: prohibit raw malloc and free

2012-02-03 Thread Jiri Denemark
On Thu, Feb 02, 2012 at 17:33:22 -0700, Eric Blake wrote: Our HACKING discourages use of malloc and free, for at least a couple of years now. But we weren't enforcing it, until now :) For now, I've exempted python and tests, and will clean those up in subsequent patches. Examples should be

Re: [libvirt] [PATCH 4/5] build: expand rule to cover testsuite

2012-02-03 Thread Jiri Denemark
On Thu, Feb 02, 2012 at 17:33:23 -0700, Eric Blake wrote: The bulk of this patch was done with: sed -i 's/\(\bfree *(/VIR_FREE(/g' tests/*.c followed by fixing the few compile errors that resulted. * cfg.mk (exclude_file_name_regexp--sc_prohibit_raw_allocation): Remove tests from

Re: [libvirt] [PATCH 5/5] python: use libvirt_util to avoid raw free

2012-02-03 Thread Jiri Denemark
On Thu, Feb 02, 2012 at 17:33:24 -0700, Eric Blake wrote: This patch starts the process of elevating the python binding code to be on the same level as the rest of libvirt when it comes to requiring good coding styles. Statically linking against the libvirt_util library makes it much easier

[libvirt] need help in vm migration

2012-02-03 Thread punit gupta
sir i am using fedora 14 and libvirt 0.8 and qemu 13 ,and i am trying to migrate my vm using virt-manager but it is giving error . internal error Process exited while reading console log output: char device redirected to /dev/pts/1 qemu: could not open disk image /home/punit/qemu/dos1.img: No

Re: [libvirt] need help in vm migration

2012-02-03 Thread Alex Jia
On 02/03/2012 05:16 PM, punit gupta wrote: sir i am using fedora 14 and libvirt 0.8 and qemu 13 ,and i am trying to migrate my vm using virt-manager but it is giving error . internal error Process exited while reading console log output: char device redirected to /dev/pts/1 qemu: could

[libvirt] [PATCH] lxc: Fix build with AppArmor

2012-02-03 Thread Jiri Denemark
--- src/Makefile.am |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b25a439..dd77eec 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1526,6 +1526,9 @@ endif if WITH_SECDRIVER_SELINUX libvirt_lxc_LDADD +=

Re: [libvirt] [PATCH] lxc: Fix build with AppArmor

2012-02-03 Thread Daniel Veillard
On Fri, Feb 03, 2012 at 10:52:56AM +0100, Jiri Denemark wrote: --- src/Makefile.am |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b25a439..dd77eec 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1526,6 +1526,9

[libvirt] [PATCH] qemu: Fix seamless spice migration

2012-02-03 Thread Jiri Denemark
Calling qemuDomainMigrateGraphicsRelocate notifies spice clients to connect to destination qemu so that they can seamlessly switch streams once migration is done. Unfortunately, current qemu is not able to accept any connections while incoming migration connection is open. Thus, we need to delay

Re: [libvirt] [PATCH] lxc: Fix build with AppArmor

2012-02-03 Thread Jiri Denemark
On Fri, Feb 03, 2012 at 17:59:02 +0800, Daniel Veillard wrote: On Fri, Feb 03, 2012 at 10:52:56AM +0100, Jiri Denemark wrote: --- src/Makefile.am |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b25a439..dd77eec

[libvirt] [PATCH] Replace TAB with white spaces

2012-02-03 Thread Osier Yang
--- src/libvirt.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index f58dfa6..e8473c2 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -8519,9 +8519,9 @@ error: * Bytes are stored in little-endian

[libvirt] [PATCH v4] npiv: Auto-generate WWN if it's not specified

2012-02-03 Thread Osier Yang
The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble. And use Qumranet's OUI (00:1A:4A) as the 3-byte

Re: [libvirt] [PATCH] Replace TAB with white spaces

2012-02-03 Thread Michal Privoznik
On 03.02.2012 12:14, Osier Yang wrote: --- src/libvirt.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) ACK Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Replace TAB with white spaces

2012-02-03 Thread Osier Yang
On 2012年02月03日 18:51, Michal Privoznik wrote: On 03.02.2012 12:14, Osier Yang wrote: --- src/libvirt.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) ACK Michal Thanks, Pushed. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] docs: Enhance documentation of the old-style boot configuration

2012-02-03 Thread Jiri Denemark
Also encourages people to use per-device boot elements for better control. --- docs/formatdomain.html.in | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6bf64a6..ff09113 100644 ---

Re: [libvirt] [PATCH v2 1/2] Added RSS information gathering into qemudGetProcessInfo

2012-02-03 Thread Daniel Veillard
On Tue, Jan 24, 2012 at 02:25:04PM +0100, Martin Kletzander wrote: One more parameter added into the function parsing /proc/pid/stat and the call of the function is fixed as well. --- v2: - correction of the format in fscanf in qemudGetProcessInfo src/qemu/qemu_driver.c | 25

Re: [libvirt] [PATCH v2 2/2] Added RSS reporting

2012-02-03 Thread Daniel Veillard
On Tue, Jan 24, 2012 at 02:25:05PM +0100, Martin Kletzander wrote: Added RSS information gathering into qemuMemoryStats into qemu driver and the reporting into virsh dommemstat. --- v2: - fixed sign for the ret variable (can be negative) include/libvirt/libvirt.h.in |7 ++-

[libvirt] [PATCH/RFC v3 0/1] rename netlink files to virnetlink

2012-02-03 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name To Laines (!) reply, this is the renamed code, I will base my further work on this. I hope I didn't oversee anything. DirkH D. Herrendoerfer (1): Rename netlink.[ch] to virnetlink.[ch] po/POTFILES.in |2 +-

[libvirt] [PATCH] Added missing memory reporting into python bindings

2012-02-03 Thread Martin Kletzander
Two types of memory stats were not reported by python bindings. This patch fixes both of them. --- python/libvirt-override.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 18849f8..289a9bb 100644 ---

[libvirt] [PATCH] Fixed connection definition for non-SELinux builds

2012-02-03 Thread Martin Kletzander
This patch fixes the access of variable con in two files where the variable was declared only on SELinux builds and thus the build failed without SELinux. It's a rather nasty fix but helps fix the build quickly and without any major changes to the code. --- src/lxc/lxc_container.c |2 ++

Re: [libvirt] [PATCH] Fixed connection definition for non-SELinux builds

2012-02-03 Thread Michal Privoznik
On 03.02.2012 16:03, Martin Kletzander wrote: This patch fixes the access of variable con in two files where the variable was declared only on SELinux builds and thus the build failed without SELinux. It's a rather nasty fix but helps fix the build quickly and without any major changes to the

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-03 Thread Ansis Atteka
On Thu, Feb 2, 2012 at 10:47 PM, Ansis Atteka aatt...@nicira.com wrote: On Thu, Feb 2, 2012 at 10:10 PM, Laine Stump la...@laine.org wrote: On 02/02/2012 01:28 PM, Ansis Atteka wrote: On Thu, Feb 2, 2012 at 6:08 PM, Laine Stump la...@laine.org wrote: On 02/02/2012 09:30 AM, Ansis

Re: [libvirt] [PATCH] qemu: fix my typo at commit 74e034964c32edb1732d0ff7642f3977f3587d72

2012-02-03 Thread Laine Stump
On 01/31/2012 10:22 PM, Eric Blake wrote: On 01/31/2012 05:54 PM, Taku Izumi wrote: Fix my typo at commit 74e034964c32edb1732d0ff7642f3977f3587d72 disk-rawio == -1 indicates that this value is not specified. So in case of this, domain must not be tainted. Signed-off-by: Taku

Re: [libvirt] [PATCH] qemu: fix my typo at commit 74e034964c32edb1732d0ff7642f3977f3587d72

2012-02-03 Thread Eric Blake
On 02/03/2012 09:09 AM, Laine Stump wrote: On 01/31/2012 10:22 PM, Eric Blake wrote: On 01/31/2012 05:54 PM, Taku Izumi wrote: Fix my typo at commit 74e034964c32edb1732d0ff7642f3977f3587d72 disk-rawio == -1 indicates that this value is not specified. So in case of this, domain must not

Re: [libvirt] [PATCH] Fixed connection definition for non-SELinux builds

2012-02-03 Thread Eric Blake
On 02/03/2012 08:03 AM, Martin Kletzander wrote: This patch fixes the access of variable con in two files where the variable was declared only on SELinux builds and thus the build failed without SELinux. It's a rather nasty fix but helps fix the build quickly and without any major changes to

Re: [libvirt] [PATCH] virsh: extension of virsh attach-disk for rawio

2012-02-03 Thread Laine Stump
On 02/02/2012 11:49 PM, Osier Yang wrote: On 2012年02月03日 12:33, Taku Izumi wrote: This patch extends virsh attach-disk command so that we can specify rawio attribute. Signed-off-by: Taku Izumiizumi.t...@jp.fujitsu.com --- tools/virsh.c |3 +++ tools/virsh.pod |3 ++- 2 files

Re: [libvirt] [PATCH] command: allow merging stdout and stderr in string capture

2012-02-03 Thread Eric Blake
On 02/02/2012 06:10 PM, Laine Stump wrote: On 02/02/2012 07:17 PM, Eric Blake wrote: Sometimes, its easier to run children with 21 in shell notation, and just deal with stdout and stderr interleaved. This was already possible for fd handling; extend it to also work when doing string capture

Re: [libvirt] [PATCHv2 2/2] qemu: increase the timeout before sending SIGKILL to qemu process

2012-02-03 Thread Eric Blake
On 02/03/2012 01:24 AM, Daniel Veillard wrote: On Thu, Feb 02, 2012 at 12:54:29PM -0500, Laine Stump wrote: The current default method of terminating the qemu process is to send a SIGTERM, wait for up to 1.6 seconds for it to cleanly shutdown, then send a SIGKILL and wait for up to 1.4 seconds

Re: [libvirt] [PATCHv2 1/2] qemu: new GRACEFUL flag for virDomainDestroy w/ QEMU support

2012-02-03 Thread Eric Blake
On 02/03/2012 01:12 AM, Daniel Veillard wrote: On Thu, Feb 02, 2012 at 12:54:28PM -0500, Laine Stump wrote: When libvirt's virDomainDestroy API is shutting down the qemu process, it first sends SIGTERM, then waits for 1.6 seconds and, if it sees the process still there, sends a SIGKILL. @@

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-03 Thread Laine Stump
On 02/03/2012 10:42 AM, Ansis Atteka wrote: On Thu, Feb 2, 2012 at 10:10 PM, Laine Stump la...@laine.org mailto:la...@laine.org wrote: There are a few other places where it may be appropriate to do the bridge removal during error paths; this same search may

Re: [libvirt] Are they reasonable FD leaks?

2012-02-03 Thread Daniel P. Berrange
On Fri, Feb 03, 2012 at 03:04:41AM -0500, Alex Jia wrote: If you're using libvirt upstream to check it, you need to revoke commit 6152c74, which fixed memory leak issue on cmdUndefine(), it's okay without FD leaks if memory leak is fixed, in other words, you will met FD leaks if you saw the

Re: [libvirt] [PATCH v2 0/5] Introduce sVirt to LXC driver

2012-02-03 Thread Daniel P. Berrange
On Thu, Feb 02, 2012 at 05:45:48PM -0700, Eric Blake wrote: On 01/25/2012 07:12 AM, Daniel P. Berrange wrote: This is an update of https://www.redhat.com/archives/libvir-list/2012-January/msg00418.html Changes since v1: - Pushed the first 2 patches which passed review -

Re: [libvirt] need help in vm migration

2012-02-03 Thread Eric Blake
On 02/03/2012 02:33 AM, Alex Jia wrote: On 02/03/2012 05:16 PM, punit gupta wrote: sir i am using fedora 14 and libvirt 0.8 and qemu 13 ,and i am trying to migrate my vm using virt-manager but it is giving error . Fedora 14 is no longer supported, and the version of libvirt on that machine

Re: [libvirt] [PATCH 5/5] python: use libvirt_util to avoid raw free

2012-02-03 Thread Eric Blake
On 02/03/2012 02:12 AM, Jiri Denemark wrote: On Thu, Feb 02, 2012 at 17:33:24 -0700, Eric Blake wrote: This patch starts the process of elevating the python binding code to be on the same level as the rest of libvirt when it comes to requiring good coding styles. Statically linking against

Re: [libvirt] [PATCH] docs: Enhance documentation of the old-style boot configuration

2012-02-03 Thread Eric Blake
On 02/03/2012 05:35 AM, Jiri Denemark wrote: Also encourages people to use per-device boot elements for better control. --- docs/formatdomain.html.in | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266

Re: [libvirt] [PATCH] Added missing memory reporting into python bindings

2012-02-03 Thread Eric Blake
On 02/03/2012 07:53 AM, Martin Kletzander wrote: Two types of memory stats were not reported by python bindings. This patch fixes both of them. --- python/libvirt-override.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override.c

Re: [libvirt] [PATCH v4] npiv: Auto-generate WWN if it's not specified

2012-02-03 Thread Eric Blake
On 02/03/2012 04:17 AM, Osier Yang wrote: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble.

Re: [libvirt] [PATCH v4] npiv: Auto-generate WWN if it's not specified

2012-02-03 Thread Eric Blake
On 02/03/2012 11:05 AM, Eric Blake wrote: + if (virAsprintf(wwn, %x%s%x%02x%02x%02x%02x, 0x5, QUMRANET_OUI, Why not just: if (virAsprintf(wwn, 5 QUMRANET_OUI %010llx, (unsigned long long) virRandomBits(36)) 0) Correction - %09llx, for 36 bits of output from your random

[libvirt] [PATCH] virterror.c: Fix several spelling mistakes

2012-02-03 Thread Philipp Hahn
compat{a-i}bility erron{-e}ous nec{c-}essary. Either the or a. Signed-off-by: Philipp Hahn h...@univention.de --- ChangeLog-old | 36 ++-- docs/drvlxc.html.in |2 +- docs/formatdomain.html.in |4 ++-- docs/locking.html.in

Re: [libvirt] [PATCH] virterror.c: Fix several spelling mistakes

2012-02-03 Thread Eric Blake
On 02/03/2012 11:20 AM, Philipp Hahn wrote: compat{a-i}bility erron{-e}ous nec{c-}essary. Either the or a. Signed-off-by: Philipp Hahn h...@univention.de --- ACK and pushed, after fixing one nit. ChangeLog-old | 36 ++-- Changing

[libvirt] [[PATCH 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Laine Stump
This allows virsh to use the new VIR_DOMAIN_DESTROY_GRACEUL flag for virDomainDestroyFlags. --- tools/virsh.c |7 ++- tools/virsh.pod |6 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 42985a9..3478185 100644 ---

Re: [libvirt] [[PATCH 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Michal Privoznik
On 03.02.2012 20:16, Laine Stump wrote: This allows virsh to use the new VIR_DOMAIN_DESTROY_GRACEUL flag for virDomainDestroyFlags. --- tools/virsh.c |7 ++- tools/virsh.pod |6 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c

[libvirt] [[PATCHv2 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Laine Stump
This allows virsh to use the new VIR_DOMAIN_DESTROY_GRACEUL flag for virDomainDestroyFlags. --- Okay, how about this one :-) tools/virsh.c |9 - tools/virsh.pod |6 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index

Re: [libvirt] [[PATCHv2 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Michal Privoznik
On 03.02.2012 20:34, Laine Stump wrote: This allows virsh to use the new VIR_DOMAIN_DESTROY_GRACEUL flag for virDomainDestroyFlags. --- Okay, how about this one :-) tools/virsh.c |9 - tools/virsh.pod |6 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff

Re: [libvirt] [[PATCHv2 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Eric Blake
On 02/03/2012 12:34 PM, Laine Stump wrote: This allows virsh to use the new VIR_DOMAIN_DESTROY_GRACEUL flag for virDomainDestroyFlags. --- Okay, how about this one :-) tools/virsh.c |9 - tools/virsh.pod |6 +- 2 files changed, 13 insertions(+), 2 deletions(-)

Re: [libvirt] [[PATCHv2 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Laine Stump
On 02/03/2012 02:44 PM, Michal Privoznik wrote: On 03.02.2012 20:34, Laine Stump wrote: This allows virsh to use the new VIR_DOMAIN_DESTROY_GRACEUL flag for virDomainDestroyFlags. --- Okay, how about this one :-) tools/virsh.c |9 - tools/virsh.pod |6 +- 2 files

Re: [libvirt] [PATCH] qemu: Fix seamless spice migration

2012-02-03 Thread Eric Blake
On 02/03/2012 03:04 AM, Jiri Denemark wrote: Calling qemuDomainMigrateGraphicsRelocate notifies spice clients to connect to destination qemu so that they can seamlessly switch streams once migration is done. Unfortunately, current qemu is not able to accept any connections while incoming

Re: [libvirt] [libvirt-glib] Add gvir_storage_vol_resize()

2012-02-03 Thread Daniel P. Berrange
On Wed, Feb 01, 2012 at 10:32:02PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add wrapper for virStorageVolResize(). --- libvirt-gobject/libvirt-gobject-storage-vol.c | 27 + libvirt-gobject/libvirt-gobject-storage-vol.h

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-02-03 Thread Ansis Atteka
Laine, How do I make interfaceid persistent across libvirtd restarts if user did not specify one in domain XML config file and libvirtd generated it for him automatically? It seems that different interfaceid is regenerated each time the libvirtd is restarted. If I understand correctly then two

Re: [libvirt] [[PATCHv2 3/2]] virsh: add --graceful switch to destroy command

2012-02-03 Thread Laine Stump
On 02/03/2012 02:52 PM, Eric Blake wrote: On 02/03/2012 12:34 PM, Laine Stump wrote: +{graceful, VSH_OT_BOOL, VSH_OFLAG_NONE, N_(needs rawio capability)}, In addition to Michal's review, fix your extra copy-and-paste. Yep, did that too. Thanks! -- libvir-list mailing list

Re: [libvirt] [PATCH/RFC v3 1/1] Rename netlink.[ch] to virnetlink.[ch]

2012-02-03 Thread Laine Stump
On 02/03/2012 09:13 AM, D. Herrendoerfer wrote: From: D. Herrendoerferd.herrendoer...@herrendoerfer.name Rename the src/util/netlink files to src/util/virnetlink to better fit the naming scheme. Also rename nlComm to virNetlinkCommand. I removed the .po file changes (those are maintained

Re: [libvirt] [PATCHv4 2/2] qemu: eliminate Ignoring open failure when using root-squash NFS

2012-02-03 Thread Eric Blake
On 02/01/2012 11:36 PM, Laine Stump wrote: This eliminates the warning message reported in: https://bugzilla.redhat.com/show_bug.cgi?id=624447 It was caused by a failure to open an image file that is not accessible by root (the uid libvirtd is running as) because it's on a root-squash

Re: [libvirt] [PATCHv4 1/2] util: refactor virFileOpenAs

2012-02-03 Thread Eric Blake
On 02/01/2012 11:36 PM, Laine Stump wrote: virFileOpenAs previously would only try opening a file as the current user, or as a different user, but wouldn't try both methods in a single call. This made it cumbersome to use as a replacement for open(2). Additionally, it had a lot of historical

[libvirt] [PATCH] maint: consolidate several .gitignore files

2012-02-03 Thread Eric Blake
Unlike .cvsignore under CVS, git allows for ignoring nested names. We weren't very consistent where new tests were being ignored (some in .gitignore, some in tests/.gitignore), and I found it easier to just consolidate everything. * .gitignore: Subsume entries from subdirectories. *

Re: [libvirt] [PATCHv4 1/2] util: refactor virFileOpenAs

2012-02-03 Thread Laine Stump
On 02/03/2012 03:41 PM, Eric Blake wrote: On 02/01/2012 11:36 PM, Laine Stump wrote: virFileOpenAs previously would only try opening a file as the current user, or as a different user, but wouldn't try both methods in a single call. This made it cumbersome to use as a replacement for open(2).

Re: [libvirt] [PATCHv4 2/2] qemu: eliminate Ignoring open failure when using root-squash NFS

2012-02-03 Thread Laine Stump
On 02/03/2012 03:45 PM, Eric Blake wrote: On 02/01/2012 11:36 PM, Laine Stump wrote: This eliminates the warning message reported in: https://bugzilla.redhat.com/show_bug.cgi?id=624447 It was caused by a failure to open an image file that is not accessible by root (the uid libvirtd is

Re: [libvirt] [PATCH] maint: consolidate several .gitignore files

2012-02-03 Thread Laine Stump
On 02/03/2012 04:31 PM, Eric Blake wrote: Unlike .cvsignore under CVS, git allows for ignoring nested names. We weren't very consistent where new tests were being ignored (some in .gitignore, some in tests/.gitignore), and I found it easier to just consolidate everything. I don't see why not.

Re: [libvirt] [PATCHv2 2/2] qemu: increase the timeout before sending SIGKILL to qemu process

2012-02-03 Thread Eric Blake
On 02/03/2012 10:06 AM, Eric Blake wrote: On 02/03/2012 01:24 AM, Daniel Veillard wrote: On Thu, Feb 02, 2012 at 12:54:29PM -0500, Laine Stump wrote: The current default method of terminating the qemu process is to send a SIGTERM, wait for up to 1.6 seconds for it to cleanly shutdown, then

[libvirt] [PATCH] RFC Libvirt + Openvswitch

2012-02-03 Thread Ansis Atteka
This patch allows libvirt to add interfaces to already existing Open vSwitch bridges. The following syntax in domain XML file must be used: interface type='bridge' mac address='52:54:00:d0:3f:f2'/ source bridge='ovsbr'/ virtualport type='openvswitch' parameters

Re: [libvirt] [PATCH] maint: consolidate several .gitignore files

2012-02-03 Thread Eric Blake
On 02/03/2012 02:48 PM, Laine Stump wrote: On 02/03/2012 04:31 PM, Eric Blake wrote: Unlike .cvsignore under CVS, git allows for ignoring nested names. We weren't very consistent where new tests were being ignored (some in .gitignore, some in tests/.gitignore), and I found it easier to just

Re: [libvirt] [PATCH 1/4] add a qemu-specific event register API, to passthough the new events come from qemu

2012-02-03 Thread Eric Blake
On 12/16/2011 09:58 AM, shao...@linux.vnet.ibm.com wrote: From: ShaoHe Feng shao...@linux.vnet.ibm.com Basically, this feature can go along with qemu monitor passthrough. That way, if we use new commands in the monitor that generate new events, we want some way to receive those new events

Re: [libvirt] [PATCH 2/4] add a qemu-specific event register API supported in remote driver

2012-02-03 Thread Eric Blake
On 12/16/2011 09:58 AM, shao...@linux.vnet.ibm.com wrote: From: ShaoHe Feng shao...@linux.vnet.ibm.com Pretty light on the commit message. Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com --- daemon/libvirtd.h| 10 +++ daemon/remote.c | 172

Re: [libvirt] [PATCH 3/4] add a qemu-specific event register API supported in qemu driver

2012-02-03 Thread Eric Blake
On 12/16/2011 09:59 AM, shao...@linux.vnet.ibm.com wrote: From: ShaoHe Feng shao...@linux.vnet.ibm.com Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 42 ++ src/qemu/qemu_monitor.c | 10

Re: [libvirt] [PATCH 4/4] add a qemu-specific event register python binding API

2012-02-03 Thread Eric Blake
On 12/16/2011 09:59 AM, shao...@linux.vnet.ibm.com wrote: From: ShaoHe Feng shao...@linux.vnet.ibm.com Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com --- python/generator.py | 28 + python/libvirt-qemu-override.c | 140

Re: [libvirt] for testing the new qemu specific regiater API

2012-02-03 Thread Eric Blake
On 12/16/2011 09:59 AM, shao...@linux.vnet.ibm.com wrote: From: ShaoHe Feng shao...@linux.vnet.ibm.com this patch is just used to the new register API add two command, register-event and deregister-event in virsh in order to test the new API. there will come an RESUME events when qemu