[libvirt] [PATCH v5] npiv: Auto-generate WWN if it's not specified

2012-02-06 Thread Osier Yang
The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble. And use Qumranet's OUI (00:1A:4A) as the 3-byte

[libvirt] [PATCH] Bug fix: Allow sysinfo to display processor information

2012-02-06 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 6 Feb 2012 13:46:10 +0530 Subject: [PATCH] Bugfix: Allow sysinfo to display 'processor' information Calls to virSysinfoParseBIOS(), virSysinfoParseSystem() would update the buffer pointer 'base', so the processor information would be lost

[libvirt] [PATCH] apparmor: Add missing comma

2012-02-06 Thread Jiri Denemark
Typo introduced by c18a88ac --- Pushed as build-breaker. src/security/virt-aa-helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 1971f40..3c9e541 100644 --- a/src/security/virt-aa-helper.c +++

[libvirt] [PATCH] tests: Fix build with -Werror

2012-02-06 Thread Jiri Denemark
--- Pushed as build-breaker. Use of uninitialized n after the former error label was the issue (gcc didn't get it right though). I forgot to mention this in the commit message :-( tests/cputest.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git

Re: [libvirt] [PATCH] docs: Enhance documentation of the old-style boot configuration

2012-02-06 Thread Jiri Denemark
On Fri, Feb 03, 2012 at 10:46:08 -0700, Eric Blake wrote: On 02/03/2012 05:35 AM, Jiri Denemark wrote: Also encourages people to use per-device boot elements for better control. --- docs/formatdomain.html.in | 22 +- 1 files changed, 17 insertions(+), 5

Re: [libvirt] [PATCH] qemu: Fix seamless spice migration

2012-02-06 Thread Jiri Denemark
On Fri, Feb 03, 2012 at 12:48:58 -0700, Eric Blake wrote: On 02/03/2012 03:04 AM, Jiri Denemark wrote: Calling qemuDomainMigrateGraphicsRelocate notifies spice clients to connect to destination qemu so that they can seamlessly switch streams once migration is done. Unfortunately, current

[libvirt] segment fault from libvirtmod

2012-02-06 Thread Guannan Ren
Hi, The Makefile.am in python forget to add probes.o if WITH_DTRACE but after I added it and tried to connect, using libvirt.open(qemu:///system) in python , it reported: segment fault I tried to figure out, but failed. If anyone can help this, thanks.

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-06 Thread Alex Jia
Hi all, I found the following issues: 1. compilation warnings: CC cputest.o cputest.c: In function 'cpuTestBaseline': cputest.c:122: warning: 'n' may be used uninitialized in this function [-Wuninitialized] cputest.c:122: note: 'n' was declared here At top level: cc1: warning: unrecognized

Re: [libvirt] [PATCH] RFC Libvirt + Openvswitch

2012-02-06 Thread Laine Stump
On 02/03/2012 05:55 PM, Ansis Atteka wrote: This patch allows libvirt to add interfaces to already existing Open vSwitch bridges. You guys are moving fast! The following syntax in domain XML file must be used: interface type='bridge' mac address='52:54:00:d0:3f:f2'/

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-06 Thread Daniel Veillard
On Mon, Feb 06, 2012 at 04:11:45AM -0500, Alex Jia wrote: Hi all, I found the following issues: [...] 2. test cases fail: TEST: virnetsockettest !!!.!!! 15 FAIL TEST: qemuxml2argvtest !!.. 40

[libvirt] [PATCH] Update myself in AUTHORS

2012-02-06 Thread ajia
From: Alex Jia a...@redhat.com Move myself from 'Previous maintainers' section to 'the primary maintainers and people with commit access rights' section, because I have a commit right now. Signed-off-by: Alex Jia a...@redhat.com --- AUTHORS |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH] Update myself in AUTHORS

2012-02-06 Thread Alex Jia
On 02/06/2012 06:36 PM, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com Move myself from 'Previous maintainers' section to 'the primary maintainers and people with commit access rights' section, because I have a commit right now. s/right/rights/ Signed-off-by: Alex Jiaa...@redhat.com ---

Re: [libvirt] [PATCH] Update myself in AUTHORS

2012-02-06 Thread Michal Privoznik
On 06.02.2012 11:38, Alex Jia wrote: On 02/06/2012 06:36 PM, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com Move myself from 'Previous maintainers' section to 'the primary maintainers and people with commit access rights' section, because I have a commit right now. s/right/rights/

[libvirt] [test-API][PATCH v2 2/2] Add and update functions in streamAPI

2012-02-06 Thread Wayne Sun
* accpet connection object and stream flag as parameter in __init__ remove connect function for connction is given in as parameter. * remove newStream() from each function create new stream object in __init__. function also need flags parameter. * Add 5 new functions

[libvirt] [PATCH] xen_xm: Fix SIGSEGV in xenXMDomainDefineXML

2012-02-06 Thread Philipp Hahn
On CentOS5 with xen-3.0.3: Program received signal SIGSEGV, Segmentation fault. virFree (ptrptr=0x8) at util/memory.c:310 310 free(*(void**)ptrptr); (gdb) bt #0 virFree (ptrptr=0x8) at util/memory.c:310 #1 0x2ae167c8 in xenXMDomainDefineXML (conn=0x694e80, xml=0x6b2ce0

[libvirt] [libvirt-glib 2/7] Make root_node optional in gvir_config_xml_parse

2012-02-06 Thread Christophe Fergeau
It's only used to make some sanity checks on what was just parsed, so allowing NULL root_node is fine. --- libvirt-gconfig/libvirt-gconfig-helpers.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-helpers.c

[libvirt] [libvirt-glib 6/7] API to get/set custom metadata from/to domain config

2012-02-06 Thread Christophe Fergeau
Based on a patch from Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 67 ++ libvirt-gconfig/libvirt-gconfig-domain.h |7 +++ libvirt-gconfig/libvirt-gconfig.sym |2 + 3 files changed, 76 insertions(+), 0

[libvirt] [libvirt-glib 5/7] Add gvir_config_object_set_namespace helper

2012-02-06 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-object-private.h |3 +++ libvirt-gconfig/libvirt-gconfig-object.c | 20 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [libvirt-glib 1/7] Fix gvir_config_object_new_from_xml error reporting

2012-02-06 Thread Christophe Fergeau
It's currently failing to report parsing errors if the passed in error is NULL. --- libvirt-gconfig/libvirt-gconfig-object.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index

[libvirt] [libvirt-glib 7/7] Add testcase for gvir_config_domain_[gs]et_custom_xml

2012-02-06 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 14636e5..1610587 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++

[libvirt] [libvirt-glib 3/7] Add gvir_config_xml_node_to_string helper

2012-02-06 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-helpers-private.h |1 + libvirt-gconfig/libvirt-gconfig-helpers.c | 20 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-helpers-private.h

[libvirt] [libvirt-glib] Don't assign const char * to non-const

2012-02-06 Thread Christophe Fergeau
This causes a gcc warning. --- libvirt-gobject/libvirt-gobject-storage-pool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c b/libvirt-gobject/libvirt-gobject-storage-pool.c index db496f3..5a4b4bc 100644 ---

[libvirt] [libvirt-glib 4/7] Handle namespaces in gvir_config_object_delete_child{ren}

2012-02-06 Thread Christophe Fergeau
These functions now take an additional argument corresponding to a namespace href. It's optional and can be NULL when namespaces should be ignored. The 'child_name' argument can now be NULL in order to remove all nodes belonging to a given namespace. ---

Re: [libvirt] [libvirt-glib] Don't assign const char * to non-const

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:55:37PM +0100, Christophe Fergeau wrote: This causes a gcc warning. --- libvirt-gobject/libvirt-gobject-storage-pool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c

Re: [libvirt] [libvirt-glib 2/7] Make root_node optional in gvir_config_xml_parse

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:12PM +0100, Christophe Fergeau wrote: It's only used to make some sanity checks on what was just parsed, so allowing NULL root_node is fine. --- libvirt-gconfig/libvirt-gconfig-helpers.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [libvirt-glib 1/7] Fix gvir_config_object_new_from_xml error reporting

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:11PM +0100, Christophe Fergeau wrote: It's currently failing to report parsing errors if the passed in error is NULL. --- libvirt-gconfig/libvirt-gconfig-object.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] xen_xm: Fix SIGSEGV in xenXMDomainDefineXML

2012-02-06 Thread Jiri Denemark
On Mon, Feb 06, 2012 at 12:50:47 +0100, Philipp Hahn wrote: On CentOS5 with xen-3.0.3: Program received signal SIGSEGV, Segmentation fault. virFree (ptrptr=0x8) at util/memory.c:310 310 free(*(void**)ptrptr); (gdb) bt #0 virFree (ptrptr=0x8) at util/memory.c:310 #1

Re: [libvirt] [libvirt-glib 3/7] Add gvir_config_xml_node_to_string helper

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:13PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-helpers-private.h |1 + libvirt-gconfig/libvirt-gconfig-helpers.c | 20 2 files changed, 21 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [libvirt-glib 5/7] Add gvir_config_object_set_namespace helper

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:15PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-object-private.h |3 +++ libvirt-gconfig/libvirt-gconfig-object.c | 20 2 files changed, 23 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [libvirt-glib 4/7] Handle namespaces in gvir_config_object_delete_child{ren}

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:14PM +0100, Christophe Fergeau wrote: These functions now take an additional argument corresponding to a namespace href. It's optional and can be NULL when namespaces should be ignored. The 'child_name' argument can now be NULL in order to remove all nodes

Re: [libvirt] [libvirt-glib 6/7] API to get/set custom metadata from/to domain config

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:16PM +0100, Christophe Fergeau wrote: Based on a patch from Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 67 ++ libvirt-gconfig/libvirt-gconfig-domain.h |7 +++

Re: [libvirt] [libvirt-glib 7/7] Add testcase for gvir_config_domain_[gs]et_custom_xml

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 12:56:17PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/tests/test-domain-create.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index

Re: [libvirt] Are they reasonable FD leaks?

2012-02-06 Thread Peter Krempa
On 02/03/2012 06:25 PM, Daniel P. Berrange wrote: On Fri, Feb 03, 2012 at 03:04:41AM -0500, Alex Jia wrote: If you're using libvirt upstream to check it, you need to revoke commit 6152c74, which fixed memory leak issue on cmdUndefine(), it's okay without FD leaks if memory leak is fixed, in

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-06 Thread Cheer Xiao
2012/2/5 Cheer Xiao xiaqq...@gmail.com: 2012/2/4 Cole Robinson crobi...@redhat.com: ... [snip] ... Okay, none of that indicates why it isn't working. I can't reproduce using your capabilities output and virt-manager 0.9.0 either (though I hacked it in so I could have missed a detail). Can

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-06 Thread Cheer Xiao
2012/2/6 Cheer Xiao xiaqq...@gmail.com: 2012/2/5 Cheer Xiao xiaqq...@gmail.com: 2012/2/4 Cole Robinson crobi...@redhat.com: ... [snip] ... Okay, none of that indicates why it isn't working. I can't reproduce using your capabilities output and virt-manager 0.9.0 either (though I hacked it in

Re: [libvirt] [libvirt-glib 3/7] Add gvir_config_xml_node_to_string helper

2012-02-06 Thread Christophe Fergeau
On Mon, Feb 06, 2012 at 12:02:23PM +, Daniel P. Berrange wrote: In gvir_config_object_to_xml() we pass '1' for the 'format' argument to get pretty-printed XML. Perhaps we should do the same here too ? Sure, makes sense to be consistent. Actually, we could even go with this followup patch:

Re: [libvirt] [libvirt-glib 3/7] Add gvir_config_xml_node_to_string helper

2012-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 02:08:34PM +0100, Christophe Fergeau wrote: On Mon, Feb 06, 2012 at 12:02:23PM +, Daniel P. Berrange wrote: In gvir_config_object_to_xml() we pass '1' for the 'format' argument to get pretty-printed XML. Perhaps we should do the same here too ? Sure, makes sense

[libvirt] [PATCH] xen-xm: fix data loss in domain edit

2012-02-06 Thread Philipp Hahn
On CentOS5: If virsh edit $DOM is used and an error happens (for example changing any live cycle action to a non-existing value), libvirt forgets that $DOM exists, since it is already removed from the internal hash tables, which are used for domain lookup. In once case (unreproducible) even the

[libvirt] [PATCH] xen-xm: SIGSEGV in xenXMDomainDefineXML: filename

2012-02-06 Thread Philipp Hahn
filename is not initialized to NULL while it's unconditionally freed in the error path. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xm_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index

[libvirt] [PATCH v4 0/7] Console corruption patchset

2012-02-06 Thread Peter Krempa
Rebased and tweaked to current upstream. Some patches still need review: * 1/7 pidfile: Make checking binary path in virPidFileRead optional - ACKed in v3 by Eric - minor spelling fixes * 2/7 Add flags for virDomainOpenConsole - ACKed in v3 by Eric - spelling fixes - added docs

[libvirt] [PATCH v4 3/7] virsh: add support for VIR_DOMAIN_CONSOLE_* flags

2012-02-06 Thread Peter Krempa
This patch adds support for the newly introduced VIR_DOMAIN_CONSOLE_FORCE and VIR_DOMAIN_CONSOLE_SAFE flags. The console command now has an optional parameter --force that specifies that the user wants to forcibly interrupt an ongoing console session and create a new one. Flag --safe requests that

[libvirt] [PATCH v4 1/7] pidfile: Make checking binary path in virPidFileRead optional

2012-02-06 Thread Peter Krempa
This patch changes behavior of virPidFileRead to enable passing NULL as path to the binary the pid file should be checked against to skip this check. This enables using this function for reading files that have same semantics as pid files, but belong to unknown processes. ---

[libvirt] [PATCH v4 2/7] Add flags for virDomainOpenConsole

2012-02-06 Thread Peter Krempa
This patch adds a set of flags to be used with the virDomainOpenConsole API call to specify if the user wishes to interrupt an existing console session or just to try open a new one. VIR_DOMAIN_CONSOLE_SAFE - specifies that the console connection should be opened only if

[libvirt] [PATCH v4 6/7] util: Add helpers for safe domain console operations

2012-02-06 Thread Peter Krempa
This patch adds a set of functions used in creating console streams for domains using PTYs and ensures mutually exclusive access to the PTYs. If mutualy exclusive access is not used, two clients may open the same console, which results in corruption on both clients as both of them race to read

[libvirt] [PATCH v4 5/7] fdstream: Add internal callback on stream close

2012-02-06 Thread Peter Krempa
This patch adds another callback to a FDstream object. The original callback is used by the daemon stream driver to handle events. This callback is called if and only if the stream is about to be closed. This might be used to handle cleanup steps after a fdstream exits. This will be used later on

[libvirt] [PATCH v4 4/7] fdstream: Emit stream abort callback even if poll() doesnt.

2012-02-06 Thread Peter Krempa
This patch causes the fdstream driver to call the stream event callback if virStreamAbort() is issued on a stream using this driver. This prohibited to abort streams from the daemon, as the daemon remote handler installs a callback to watch for stream errors as the only mean of detecting changes

[libvirt] [PATCH v4 7/7] qemu: Add ability to abort existing console while creating new one

2012-02-06 Thread Peter Krempa
This patch fixes console corruption, that happens if two concurrent sessions are opened for a single console on a domain. Result of this corruption was that each of the console streams recieved just a part of the data written to the pipe so every console rendered unusable. New helper function for

[libvirt] [PATCH] virsh: Fix resource leak while listing inactive domains with titles

2012-02-06 Thread Peter Krempa
Commit fad5cd210899dfde4afe36712754dc921c3f3051 introduces a new flag that allows to show domain's title with domains. This commit introduced resource leak while listing inactive domains with titles. --- Sadly, I missed this even when it was incorrectly intended. :( (extra context for easier

Re: [libvirt] [PATCH] virsh: Fix resource leak while listing inactive domains with titles

2012-02-06 Thread Jiri Denemark
On Mon, Feb 06, 2012 at 15:33:53 +0100, Peter Krempa wrote: Commit fad5cd210899dfde4afe36712754dc921c3f3051 introduces a new flag that allows to show domain's title with domains. This commit introduced resource leak while listing inactive domains with titles. --- Sadly, I missed this even

[libvirt] [PATCH 1/2] util: Generalize virFileDirectFd

2012-02-06 Thread Jiri Denemark
virFileDirectFd was used for accessing files opened with O_DIRECT using libvirt_iohelper. We will want to use the helper for accessing files regardless on O_DIRECT and thus virFileDirectFd was generalized and renamed to virFileWrapperFd. --- src/qemu/qemu_driver.c | 42 +++-

[libvirt] [PATCH 0/2] qemu: Fix stalls during live core dump

2012-02-06 Thread Jiri Denemark
Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu when dumping core to avoid stalls in live mode. Jiri Denemark (2): util: Generalize virFileDirectFd qemu: Always use iohelper for dumping domain core src/qemu/qemu_driver.c |

[libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-06 Thread Jiri Denemark
Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu instead, which can easily be done using iohelper. --- src/qemu/qemu_driver.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] segment fault from libvirtmod

2012-02-06 Thread Michal Privoznik
On 06.02.2012 10:08, Guannan Ren wrote: Hi, The Makefile.am in python forget to add probes.o if WITH_DTRACE but after I added it and tried to connect, using libvirt.open(qemu:///system) in python , it reported: segment fault I tried to figure out,

Re: [libvirt] [PATCH] virsh: Fix resource leak while listing inactive domains with titles

2012-02-06 Thread Peter Krempa
On 02/06/2012 03:48 PM, Jiri Denemark wrote: On Mon, Feb 06, 2012 at 15:33:53 +0100, Peter Krempa wrote: Commit fad5cd210899dfde4afe36712754dc921c3f3051 introduces a new flag that allows to show domain's title with domains. This commit introduced resource leak while listing inactive domains

Re: [libvirt] Are they reasonable FD leaks?

2012-02-06 Thread Alex Jia
Daniel and Peter, thanks. Alex - Original Message - From: Peter Krempa pkre...@redhat.com To: Daniel P. Berrange berra...@redhat.com Cc: Alex Jia a...@redhat.com, libvir libvir-list@redhat.com Sent: Monday, February 6, 2012 8:57:51 PM Subject: Re: [libvirt] Are they reasonable FD leaks?

Re: [libvirt] [PATCH] Update myself in AUTHORS

2012-02-06 Thread Alex Jia
Michal, thanks, pushed now. Alex - Original Message - From: Michal Privoznik mpriv...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir libvir-list@redhat.com Sent: Monday, February 6, 2012 6:40:41 PM Subject: Re: [libvirt] [PATCH] Update myself in AUTHORS On 06.02.2012 11:38, Alex

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-06 Thread Cole Robinson
On 02/06/2012 08:01 AM, Cheer Xiao wrote: 2012/2/6 Cheer Xiao xiaqq...@gmail.com: 2012/2/5 Cheer Xiao xiaqq...@gmail.com: 2012/2/4 Cole Robinson crobi...@redhat.com: ... [snip] ... Okay, none of that indicates why it isn't working. I can't reproduce using your capabilities output and

[libvirt] [libvirt-glib] Fix [gs]et_custom_xml-related leaks

2012-02-06 Thread Christophe Fergeau
I forgot to run the testing code through valgrind before pushing the patches so a few small memory leaks crept in. --- libvirt-gconfig/libvirt-gconfig-domain.c |1 + libvirt-gconfig/tests/test-domain-create.c |8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git

[libvirt] [RFC] Specific vcpu hot-(un)plug API proposal

2012-02-06 Thread Peter Krempa
Hypervisors are starting to support hot-(un)plugging of specific vcpus. This adds more flexibility for the management tools to decide which CPU should be added or removed. Libvirt's API in current state does not allow to choose arbitrary vCPU id's for the new vCPU's and does not support

Re: [libvirt] [PATCH] cgroup:fix bug to keep --device-weights value persistent

2012-02-06 Thread Guannan Ren
ping :) On 02/02/2012 07:57 PM, Guannan Ren wrote: src/qemu/qemu_driver.c When run virsh blkiotune dom --device-weights /dev/sda,400 --config it couldn't be persistent after dom restart. The patch fix it. --- src/qemu/qemu_driver.c | 53

[libvirt] [PATCH] maint: Add test output files to .gitignore

2012-02-06 Thread Peter Krempa
Commit 8f00276c8a6140cec6a6d50441c802981d329c0c consolidated other .gitignore files to the master one, but forgot to add some test output files. --- Detected by git status on a cleaned repo with make check done: # On branch master # Untracked files: # (use git add file... to include in what will

Re: [libvirt] [RFC] Specific vcpu hot-(un)plug API proposal

2012-02-06 Thread Eric Blake
On 02/06/2012 10:10 AM, Peter Krempa wrote: Hypervisors are starting to support hot-(un)plugging of specific vcpus. This adds more flexibility for the management tools to decide which CPU should be added or removed. Libvirt's API in current state does not allow to choose arbitrary vCPU id's

Re: [libvirt] [PATCH] maint: Add test output files to .gitignore

2012-02-06 Thread Eric Blake
On 02/06/2012 10:30 AM, Peter Krempa wrote: Commit 8f00276c8a6140cec6a6d50441c802981d329c0c consolidated other .gitignore files to the master one, but forgot to add some test output files. --- Detected by git status on a cleaned repo with make check done: # On branch master # Untracked

Re: [libvirt] [PATCH] maint: Add test output files to .gitignore

2012-02-06 Thread Peter Krempa
On 02/06/2012 06:34 PM, Eric Blake wrote: On 02/06/2012 10:30 AM, Peter Krempa wrote: Commit 8f00276c8a6140cec6a6d50441c802981d329c0c consolidated other .gitignore files to the master one, but forgot to add some test output files. --- Detected by git status on a cleaned repo with make check

Re: [libvirt] [RFC PATCH V2] Add proxy FS support to libvirt

2012-02-06 Thread M. Mohan Kumar
Hi Daniel, Any comment on this patch? M. Mohan Kumar wrote: From: M. Mohan Kumarmo...@in.ibm.com A new FS driver type 'proxy' is added to QEMU 9p server. This patch adds support for using proxy FS driver from libvirt. QEMU proxy FS driver uses socket for communicating between helper and qemu

[libvirt] RFC: PCI-Passthrough of SRIOV VF's new forward mode

2012-02-06 Thread Shradha Shah
RFC: New network forward type pci-passthrough-hybrid I saw a couple of posts regarding PCI-Passthrough usage of SRIOV VF's a couple of weeks ago (20th Jan 2012). Initially I was going to post this RFC along with a set of patches. I would require a few more days to clean my patches for submission

Re: [libvirt] [PATCH v5] npiv: Auto-generate WWN if it's not specified

2012-02-06 Thread Eric Blake
On 02/06/2012 02:11 AM, Osier Yang wrote: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble.

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-06 Thread Eric Blake
On 02/06/2012 03:11 AM, Alex Jia wrote: TEST: qemuxml2argvtest !!.. 40 ..!. 80 120 160

Re: [libvirt] [PATCH] seclabel: make code and RNG match

2012-02-06 Thread Eric Blake
On 02/05/2012 08:42 AM, Ansis Atteka wrote: My bad, it actually seems that your patch fixed my issue after I manually removed the domain XML file that was stuck in /var/run. I've gone ahead and pushed the patch, since it helped. Nevertheless, it seems that the issue when virt-manager

Re: [libvirt] [PATCH v5] npiv: Auto-generate WWN if it's not specified

2012-02-06 Thread Matthias Bolte
2012/2/6 Eric Blake ebl...@redhat.com: On 02/06/2012 02:11 AM, Osier Yang wrote: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote

[libvirt] [PATCH] libvirtd: Enable private /tmp under systemd.

2012-02-06 Thread Eric Blake
The last intentional use of /tmp by libvirt was patched in commit bd6083c9b; we can add an extra measure of security by explicitly requesting that libvirtd's /tmp is not visible to arbitrary users. See https://bugzilla.redhat.com/782474 * daemon/libvirtd.service.in (Service): Enable PrivateTmp.

Re: [libvirt] [PATCH] libvirtd: Enable private /tmp under systemd.

2012-02-06 Thread Eric Blake
On 02/06/2012 02:15 PM, Eric Blake wrote: The last intentional use of /tmp by libvirt was patched in commit bd6083c9b; we can add an extra measure of security by explicitly requesting that libvirtd's /tmp is not visible to arbitrary users. See https://bugzilla.redhat.com/782474 *

[libvirt] [PATCH 1/1] Clarify the purpose of domxml-from-native

2012-02-06 Thread Dave Allan
Someone mentioned to me that they interpreted this section of the KVM driver page as suggesting that new guests should be created by creating a qemu commandline and converting it to XML with domxml-from-native. I don't think that's the intent of domxml-from-native, so I added that clarification.

Re: [libvirt] [PATCH] Bug fix: Allow sysinfo to display processor information

2012-02-06 Thread Eric Blake
On 02/06/2012 01:36 AM, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 6 Feb 2012 13:46:10 +0530 Subject: [PATCH] Bugfix: Allow sysinfo to display 'processor' information Calls to virSysinfoParseBIOS(), virSysinfoParseSystem() would update the buffer pointer

Re: [libvirt] [PATCH 1/1] Clarify the purpose of domxml-from-native

2012-02-06 Thread Eric Blake
On 02/06/2012 02:45 PM, Dave Allan wrote: Someone mentioned to me that they interpreted this section of the KVM driver page as suggesting that new guests should be created by creating a qemu commandline and converting it to XML with domxml-from-native. I don't think that's the intent of

[libvirt] [PATCH 1/1] Clarify the purpose of domxml-from-native (v2)

2012-02-06 Thread Dave Allan
Someone mentioned to me that they interpreted this section of the KVM driver page as suggesting that new guests should be created by creating a qemu commandline and converting it to XML with domxml-from-native. I don't think that's the intent of domxml-from-native, so I added that clarification.

Re: [libvirt] [PATCH 1/2] util: Generalize virFileDirectFd

2012-02-06 Thread Eric Blake
On 02/06/2012 07:51 AM, Jiri Denemark wrote: virFileDirectFd was used for accessing files opened with O_DIRECT using libvirt_iohelper. We will want to use the helper for accessing files regardless on O_DIRECT and thus virFileDirectFd was generalized and renamed to virFileWrapperFd. ---

Re: [libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-06 Thread Eric Blake
On 02/06/2012 07:51 AM, Jiri Denemark wrote: Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu instead, which can easily be done using iohelper. --- src/qemu/qemu_driver.c |3 +-- 1 files changed, 1 insertions(+), 2

Re: [libvirt] segment fault from libvirtmod

2012-02-06 Thread Eric Blake
On 02/06/2012 07:59 AM, Michal Privoznik wrote: Running git bisect showed it was caused by c700613b8d463212d142c97108b7a2352e23e559. However, I think it only exposed the design problem we are facing here. IMHO problem is when an application tries to call virConnectOpen() (or

Re: [libvirt] [PATCH] xen-xm: SIGSEGV in xenXMDomainDefineXML: filename

2012-02-06 Thread Eric Blake
On 02/06/2012 06:13 AM, Philipp Hahn wrote: filename is not initialized to NULL while it's unconditionally freed in the error path. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xm_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] xen-xm: fix data loss in domain edit

2012-02-06 Thread Eric Blake
On 02/06/2012 06:09 AM, Philipp Hahn wrote: On CentOS5: If virsh edit $DOM is used and an error happens (for example changing any live cycle action to a non-existing value), libvirt forgets that $DOM exists, since it is already removed from the internal hash tables, which are used for domain

Re: [libvirt] [PATCH 1/1] Clarify the purpose of domxml-from-native (v2)

2012-02-06 Thread Eric Blake
On 02/06/2012 03:17 PM, Dave Allan wrote: Someone mentioned to me that they interpreted this section of the KVM driver page as suggesting that new guests should be created by creating a qemu commandline and converting it to XML with domxml-from-native. I don't think that's the intent of

[libvirt] [PATCH 0/1] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
Sorry for the somewhat redundant cover letter, but needed to note that: This applies on top of [PATCH v2 0/8] qemu-ga: add support for Windows, and can also be obtained from: git://github.com/mdroth/qemu.git qga-guest-sync-delimited As noted in the commit there's a wiki write-up with more

[libvirt] [PATCH] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-sentence due to reboot, forced restart, etc). qemu-ga handles this situation on its end by

Re: [libvirt] [PATCH 0/1] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
On Mon, Feb 06, 2012 at 06:07:34PM -0600, Michael Roth wrote: Sorry for the somewhat redundant cover letter, but needed to note that: This applies on top of [PATCH v2 0/8] qemu-ga: add support for Windows, and can also be obtained from: git://github.com/mdroth/qemu.git

[libvirt] [PATCH v2 0/1] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
Sorry for the somewhat redundant cover letter, but needed to note that: This applies on top of [PATCH v2 0/8] qemu-ga: add support for Windows, and can also be obtained from: git://github.com/mdroth/qemu.git qga-guest-sync-delimited CHANGES SINCE v1: - removed deprecation flag for guest-sync,

[libvirt] [PATCH v2] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-sentence due to reboot, forced restart, etc). qemu-ga handles this situation on its end by

Re: [libvirt] [PATCH 1/1] Clarify the purpose of domxml-from-native (v2)

2012-02-06 Thread Dave Allan
On Mon, Feb 06, 2012 at 04:06:13PM -0700, Eric Blake wrote: On 02/06/2012 03:17 PM, Dave Allan wrote: Someone mentioned to me that they interpreted this section of the KVM driver page as suggesting that new guests should be created by creating a qemu commandline and converting it to XML

Re: [libvirt] RFC: PCI-Passthrough of SRIOV VF's new forward mode

2012-02-06 Thread Laine Stump
On 02/06/2012 12:58 PM, Shradha Shah wrote: RFC: New network forward type pci-passthrough-hybrid I saw a couple of posts regarding PCI-Passthrough usage of SRIOV VF's a couple of weeks ago (20th Jan 2012). Initially I was going to post this RFC along with a set of patches. I would require a few

Re: [libvirt] [test-API][PATCH v2 2/2] Add and update functions in streamAPI

2012-02-06 Thread Alex Jia
On 02/06/2012 06:55 PM, Wayne Sun wrote: * accpet connection object and stream flag as parameter in __init__ remove connect function for connction is given in as parameter. * remove newStream() from each function create new stream object in __init__. function also need

[libvirt] [PATCH] build: avoid gcc 4.7 warning about inlines

2012-02-06 Thread Eric Blake
gcc 4.7 complains: util/virhashcode.c:49:17: error: always_inline function might not be inlinable [-Werror=attributes] util/virhashcode.c:35:17: error: always_inline function might not be inlinable [-Werror=attributes] Normal 'inline' is a hint that the compiler may ignore; the fact that the

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-06 Thread Justin Clift
On 06/02/2012, at 6:21 PM, Daniel Veillard wrote: We are now entering the freeze for libvirt-0.9.10 Hopefully all the API changes needed for that version are already commited to git head. I have made a release candidate 1 tarball (and associated rpms) at

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-06 Thread Alex Jia
On 02/07/2012 02:41 AM, Eric Blake wrote: On 02/06/2012 03:11 AM, Alex Jia wrote: TEST: qemuxml2argvtest !!.. 40 ..!. 80 120

Re: [libvirt] [PATCH] Bug fix: Allow sysinfo to display processor information

2012-02-06 Thread Prerna Saxena
On 02/07/2012 03:18 AM, Eric Blake wrote: On 02/06/2012 01:36 AM, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 6 Feb 2012 13:46:10 +0530 Subject: [PATCH] Bugfix: Allow sysinfo to display 'processor' information Calls to virSysinfoParseBIOS(),