Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-10 Thread Michal Privoznik
On 10.02.2012 00:32, Eric Blake wrote: On 02/06/2012 12:21 AM, Daniel Veillard wrote: We are now entering the freeze for libvirt-0.9.10 Hopefully all the API changes needed for that version are already commited to git head. I have made a release candidate 1 tarball (and associated rpms) at

[libvirt] [PATCHv3] python: Fix problems of virDomain{Set, Get}BlkioParameters bindings

2012-02-10 Thread ajia
From: Alex Jia a...@redhat.com The parameter 'device_weight' is a string, however, the 'VIR_TYPED_PARAM_STRING' type condition is missed by libvirt_virDomain{Set, Get}BlkioParameters bindings, the result is we can't get or change 'device_weight' value. The latest python binding codes are

[libvirt] [PATCH] python: make other APIs share common {get, set}PyVirTypedParameter

2012-02-10 Thread Guannan Ren
*libvirt_virDomainBlockStatsFlags *libvirt_virDomainGetSchedulerParameters *libvirt_virDomainGetSchedulerParametersFlags *libvirt_virDomainSetSchedulerParameters *libvirt_virDomainSetSchedulerParametersFlags *libvirt_virDomainSetBlkioParameters

[libvirt] QEMU applying for Google Summer of Code 2012

2012-02-10 Thread Stefan Hajnoczi
This year's Google Summer of Code has been announced: http://www.google-melange.com/gsoc/events/google/gsoc2012 For those who haven't heard of GSoC before, it funds university students to work on open source projects during the summer. Organizations, such as QEMU, can participate to attract

[libvirt] thunderbird bug workaround (was Re: [PATCH libvirt] domain: add implicit USB controller)

2012-02-10 Thread Paolo Bonzini
On 02/08/2012 02:28 PM, Jiri Denemark wrote: On Wed, Feb 08, 2012 at 07:37:19 -0500, Cole Robinson wrote: On 02/08/2012 02:26 AM, Osier Yang wrote: diff --git a/tests/define-dev-segfault b/tests/define-dev-segfault index 3feff46..0a0532b 100755 --- a/tests/define-dev-segfault +++

Re: [libvirt] QEMU applying for Google Summer of Code 2012

2012-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2012 at 10:30:24AM +, Stefan Hajnoczi wrote: This year's Google Summer of Code has been announced: http://www.google-melange.com/gsoc/events/google/gsoc2012 For those who haven't heard of GSoC before, it funds university students to work on open source projects during

Re: [libvirt] QEMU applying for Google Summer of Code 2012

2012-02-10 Thread Stefan Hajnoczi
On Fri, Feb 10, 2012 at 10:59 AM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Feb 10, 2012 at 10:30:24AM +, Stefan Hajnoczi wrote: This year's Google Summer of Code has been announced: http://www.google-melange.com/gsoc/events/google/gsoc2012 For those who haven't heard of GSoC

[libvirt] [PATCH v2] qemu: Implement DomainPMSuspendForDuration

2012-02-10 Thread Michal Privoznik
via user agent. --- diff to v1: -allow mem and hybrid targets iff system_wakeup monitor command is presented src/qemu/qemu_agent.c| 31 +++ src/qemu/qemu_agent.h|2 + src/qemu/qemu_capabilities.c |1 + src/qemu/qemu_capabilities.h |1 +

Re: [libvirt] [PATCH] util: Do not use PRIx64 macro

2012-02-10 Thread Osier Yang
On 2012年02月10日 20:05, Osier Yang wrote: It breaks the build on Mingw32, because PRIx64 is coming from the Win32 headers, but virAsprintf uses the gnulib printf. It's pushed under build breaking rule. --- src/util/virrandom.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[libvirt] [PATCH] util: Do not use PRIx64 macro

2012-02-10 Thread Osier Yang
It breaks the build on Mingw32, because PRIx64 is coming from the Win32 headers, but virAsprintf uses the gnulib printf. --- src/util/virrandom.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virrandom.c b/src/util/virrandom.c index 630bc00..151cf4b 100644

[libvirt] [PATCH 0/3] Introduce virDomainPMWakeup API

2012-02-10 Thread Michal Privoznik
This is counterpart for virDomainPMSuspendForDuration API which we have already in. It allows user to wake up guest from S3 state. Michal Privoznik (3): Introduce virDomainPMWakeup API virsh: Expose virDomainPMWakeup qemu: Implement virDomainPMWakeup API include/libvirt/libvirt.h.in |

[libvirt] [PATCH 3/3] qemu: Implement virDomainPMWakeup API

2012-02-10 Thread Michal Privoznik
--- src/qemu/qemu_driver.c | 54 ++ src/qemu/qemu_monitor.c | 20 +++ src/qemu/qemu_monitor.h |2 + src/qemu/qemu_monitor_json.c | 21 src/qemu/qemu_monitor_json.h |2 + src/qemu/qemu_monitor_text.c

[libvirt] [PATCH 2/3] virsh: Expose virDomainPMWakeup

2012-02-10 Thread Michal Privoznik
--- tools/virsh.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 66ba61c..4971e36 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2436,6 +2436,50 @@ cleanup: } /* + * dompmwakeup

[libvirt] [PATCH 1/3] Introduce virDomainPMWakeup API

2012-02-10 Thread Michal Privoznik
This API allows a domain which previously called virDomainPMSuspendForDuration() to be woken up. --- include/libvirt/libvirt.h.in |2 + src/driver.h |4 +++ src/libvirt.c| 50 ++ src/libvirt_public.syms |1

[libvirt] [PATCH v2] Cleanup of the quick dirty fix from last week

2012-02-10 Thread Martin Kletzander
Just a cleanup of commit 32f881c6c42f94da70a3782fe20a058fe3dc39cc. --- src/lxc/lxc_container.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index e93fda5..2282eb0 100644 --- a/src/lxc/lxc_container.c

Re: [libvirt] [PATCH v3] Support for cpu64-rhel* qemu cpu models

2012-02-10 Thread Martin Kletzander
On 01/30/2012 05:25 PM, Martin Kletzander wrote: In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf Bump up, could somebody please have a look at

Re: [libvirt] Downloading and wiping assumes volume is a device or file

2012-02-10 Thread Wido den Hollander
Hi, On 02/09/2012 09:27 PM, Eric Blake wrote: On 02/09/2012 01:04 PM, Wido den Hollander wrote: Hi, I'm still working on the RBD (RADOS / Ceph) storage driver for libvirt and I noticed the virStorageVolDownload and virStorageVolWipe methods. I assumed those would be passed on to the storage

Re: [libvirt] [PATCH v2] Cleanup of the quick dirty fix from last week

2012-02-10 Thread Eric Blake
On 02/10/2012 08:22 AM, Martin Kletzander wrote: Just a cleanup of commit 32f881c6c42f94da70a3782fe20a058fe3dc39cc. --- src/lxc/lxc_container.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH v3] Support for cpu64-rhel* qemu cpu models

2012-02-10 Thread Eric Blake
On 01/30/2012 09:25 AM, Martin Kletzander wrote: In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- v3: - fixed sse3 naming (it's 'pni' in the

Re: [libvirt] [PATCH 1/3] Introduce virDomainPMWakeup API

2012-02-10 Thread Eric Blake
On 02/10/2012 06:43 AM, Michal Privoznik wrote: This API allows a domain which previously called virDomainPMSuspendForDuration() to be woken up. --- include/libvirt/libvirt.h.in |2 + src/driver.h |4 +++ src/libvirt.c| 50

Re: [libvirt] [PATCH 2/3] virsh: Expose virDomainPMWakeup

2012-02-10 Thread Eric Blake
On 02/10/2012 06:43 AM, Michal Privoznik wrote: --- tools/virsh.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) Missing documentation. I can't ack without at least something in virsh.pod. But the code looks correct. -- Eric Blake

Re: [libvirt] [PATCH 3/3] qemu: Implement virDomainPMWakeup API

2012-02-10 Thread Eric Blake
On 02/10/2012 06:43 AM, Michal Privoznik wrote: Pretty light on the commit message. --- src/qemu/qemu_driver.c | 54 ++ src/qemu/qemu_monitor.c | 20 +++ src/qemu/qemu_monitor.h |2 + src/qemu/qemu_monitor_json.c

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-10 Thread Dave Allan
On Thu, Feb 09, 2012 at 04:32:46PM -0700, Eric Blake wrote: On 02/06/2012 12:21 AM, Daniel Veillard wrote: We are now entering the freeze for libvirt-0.9.10 Hopefully all the API changes needed for that version are already commited to git head. I have made a release candidate 1

Re: [libvirt] [PATCH 1/3] Introduce virDomainPMWakeup API

2012-02-10 Thread Eric Blake
On 02/10/2012 11:56 AM, Eric Blake wrote: On 02/10/2012 06:43 AM, Michal Privoznik wrote: This API allows a domain which previously called virDomainPMSuspendForDuration() to be woken up. --- include/libvirt/libvirt.h.in |2 + src/driver.h |4 +++ src/libvirt.c

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-10 Thread Eric Blake
On 02/10/2012 12:21 PM, Dave Allan wrote: I'm wondering if we're too late for one more API to round out the API we added in this release. Qemu is proposing a new monitor command system_wakeup which lets the host inject a power-button wakeup to a guest that has gone into S3 sleep. Since we

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-10 Thread Eric Blake
On 02/10/2012 01:33 PM, Eric Blake wrote: On the other hand, it probably also points out that we are missing a counterpart: virDomainGetPowerState(domain, flags) after all, with NodeSuspendForDuration, we always know what state we are in (the host is active if you can query, and all other

Re: [libvirt] RFC: PCI-Passthrough of SRIOV VF's new forward mode

2012-02-10 Thread Laine Stump
On 02/08/2012 06:18 AM, Shradha Shah wrote: Hello Laine, Many Thanks for reviewing the RFC. Please find my reply inline. On 02/07/2012 02:36 AM, Laine Stump wrote: On 02/06/2012 12:58 PM, Shradha Shah wrote: RFC: New network forward type pci-passthrough-hybrid I saw a couple of posts

[libvirt] [PATCH v2] RFC Libvirt + Openvswitch

2012-02-10 Thread Ansis Atteka
This patch allows libvirt to add interfaces to already existing Open vSwitch bridges. The following syntax in domain XML file can be used: interface type='bridge' mac address='52:54:00:d0:3f:f2'/ source bridge='ovsbr'/ virtualport type='openvswitch' parameters

Re: [libvirt] [PATCH v2] qemu: Implement DomainPMSuspendForDuration

2012-02-10 Thread Eric Blake
On 02/10/2012 04:25 AM, Michal Privoznik wrote: via user agent. --- diff to v1: -allow mem and hybrid targets iff system_wakeup monitor command is presented Before I review too much of this, remember that there is still a pending discussion that might rename the API slightly to add in the

[libvirt] [PATCH] qemu: make block io tuning smarter

2012-02-10 Thread Eric Blake
When blkdeviotune was first committed in 0.9.8, we had the limitation that setting one value reset all others. But bytes and iops should be relatively independent. Furthermore, setting tuning values on a live domain followed by dumpxml did not output the new settings. * src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 2/4] Fix warnings about pid_t printf format on mingw64

2012-02-10 Thread Eric Blake
On 02/01/2012 05:28 PM, Marc-André Lureau wrote: Define PID_FORMAT and fix warnings for mingw64 x86_64 build. NACK to PID_FORMAT. I'd rather use %lld, (long long) pid, throughout. But I'm incorporating your patch into a respun series, look for it soon. -- Eric Blake ebl...@redhat.com

Re: [libvirt] [PATCH 3/4] virpidfile: replace fopen/fwrite/fscanf with more portable version

2012-02-10 Thread Eric Blake
On 02/01/2012 05:28 PM, Marc-André Lureau wrote: Replace calls to fwrite() and fscanf() with more portable-friendly version, such as snprintf() and virStrToLong(). I'm tweaking this to mention why snprintf is more portable - because we're using gnulib for snprintf but not for fprintf. ---

Re: [libvirt] [PATCH 4/4] Remove compile-time pid_t size check

2012-02-10 Thread Eric Blake
On 02/01/2012 05:28 PM, Marc-André Lureau wrote: It seems all the code use pid_t type properly, so it is safe to drop that check now. --- src/util/command.c|3 --- src/util/virpidfile.c |2 -- 2 files changed, 0 insertions(+), 5 deletions(-) ACK to doing this, but I'll just

[libvirt] [PATCH 1/2] build: use correct type for pid and similar types

2012-02-10 Thread Eric Blake
No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid constructs like 'int pid'. Our API in libvirt-qemu cannot be changed without breaking ABI; but then again, libvirt-qemu can only be used on systems that support UNIX sockets, which rules out Windows (even if qemu could be compiled

[libvirt] [PATCH 0/2] mingw64 build fixes

2012-02-10 Thread Eric Blake
I still don't have my mingw64 cross-compile working nicely, so although I'd like to push this under the build-breaker rule, I would feel safer waiting for Marc-André's test results. Eric Blake (2): build: use correct type for pid and similar types build: fix output of pid values cfg.mk

[libvirt] [PATCH 2/2] build: fix output of pid values

2012-02-10 Thread Eric Blake
Nuke the last vestiges of printing pid_t values with the wrong types, at least in code compiled on mingw64. There may be other places, but for now they are only compiled on systems where the existing %d doesn't trigger gcc warnings. * src/rpc/virnetsocket.c (virNetSocketNew): Use %lld and

Re: [libvirt] [PATCHv3] python: Fix problems of virDomain{Set, Get}BlkioParameters bindings

2012-02-10 Thread Eric Blake
On 02/10/2012 02:41 AM, a...@redhat.com wrote: From: Alex Jia a...@redhat.com The parameter 'device_weight' is a string, however, the 'VIR_TYPED_PARAM_STRING' type condition is missed by libvirt_virDomain{Set, Get}BlkioParameters bindings, the result is we can't get or change

Re: [libvirt] [PATCH] python: make other APIs share common {get, set}PyVirTypedParameter

2012-02-10 Thread Eric Blake
On 02/10/2012 03:17 AM, Guannan Ren wrote: *libvirt_virDomainBlockStatsFlags *libvirt_virDomainGetSchedulerParameters *libvirt_virDomainGetSchedulerParametersFlags *libvirt_virDomainSetSchedulerParameters *libvirt_virDomainSetSchedulerParametersFlags

Re: [libvirt] [PATCHv3] python: Fix problems of virDomain{Set, Get}BlkioParameters bindings

2012-02-10 Thread Eric Blake
On 02/10/2012 05:10 PM, Eric Blake wrote: On 02/10/2012 02:41 AM, a...@redhat.com wrote: From: Alex Jia a...@redhat.com The parameter 'device_weight' is a string, however, the 'VIR_TYPED_PARAM_STRING' type condition is missed by libvirt_virDomain{Set, Get}BlkioParameters bindings, the

Re: [libvirt] [PATCH v4 1/7] pidfile: Make checking binary path in virPidFileRead optional

2012-02-10 Thread Eric Blake
On 02/06/2012 06:50 AM, Peter Krempa wrote: This patch changes behavior of virPidFileRead to enable passing NULL as path to the binary the pid file should be checked against to skip this check. This enables using this function for reading files that have same semantics as pid files, but belong

Re: [libvirt] [PATCH v4 2/7] Add flags for virDomainOpenConsole

2012-02-10 Thread Eric Blake
On 02/06/2012 06:50 AM, Peter Krempa wrote: This patch adds a set of flags to be used with the virDomainOpenConsole API call to specify if the user wishes to interrupt an existing console session or just to try open a new one. VIR_DOMAIN_CONSOLE_SAFE - specifies that the console connection

Re: [libvirt] [PATCH 3/5 V5] add nodeGetCPUmap() for getting available CPU IDs in a bitmap.

2012-02-10 Thread Eric Blake
On 02/09/2012 03:43 AM, Lai Jiangshan wrote: From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com add virBitmapParseCommaSeparetedFormat() for parsing bitmap in s/Separeted/Separated/ comma separeted ascii format. and again This format of bitmap is used in Linux sysfs and cpuset.