[libvirt] [PATCH] fix deadlock when qemu cannot start

2012-03-15 Thread Wen Congyang
When qemu cannot start, we may call qemuProcessStop() twice. We have check whether the vm is running at the beginning of qemuProcessStop() to avoid libvirt deadlock. We call qemuProcessStop() with driver and vm locked. It seems that we can avoid libvirt deadlock. But unfortunately we may unlock dri

Re: [libvirt] [PATCH v2 4/5] qemu: Wire up virDomainSuspendForDuration API

2012-03-15 Thread Osier Yang
On 03/16/2012 07:11 AM, Eric Blake wrote: On 01/26/2012 12:59 PM, Michal Privoznik wrote: This makes use of QEMU guest agent to implement the virDomainSuspendForDuration API. --- src/qemu/qemu_driver.c | 93 1 files changed, 93 insertions(+),

Re: [libvirt] [PATCH v3] qemu: Support numad

2012-03-15 Thread Osier Yang
On 03/16/2012 06:12 AM, Eric Blake wrote: On 03/08/2012 06:36 AM, Osier Yang wrote: numad is an user-level daemon that monitors NUMA topology and processes resource consumption to facilitate good NUMA resource alignment of applications/virtual machines to improve performance and minimize cost of

Re: [libvirt] [PATCH v2] python: add virDomainGetCPUStats python binding API

2012-03-15 Thread Guannan Ren
Is there anyone who would like to review this :) On 03/14/2012 09:03 PM, Guannan Ren wrote: dom.getCPUStats(True, 0) [{'cpu_time': 92913537401L, 'system_time': 547000L, 'user_time': 31000L}] dom.getCPUStats(False, 0) [{'cpu_time': 39476858499L}, {'cpu_time'

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Jesse Cook
On Thu, Mar 15, 2012 at 9:43 AM, Eric Blake wrote: > On 03/15/2012 05:51 AM, Daniel P. Berrange wrote: >> On Thu, Mar 15, 2012 at 06:22:38AM -0500, Jesse Cook wrote: >>> Just to clarify, you would like to see: > > I have not actually tried this, but based on my understanding of the RPC > famework,

Re: [libvirt] [PATCH v2 4/5] qemu: Wire up virDomainSuspendForDuration API

2012-03-15 Thread Eric Blake
On 01/26/2012 12:59 PM, Michal Privoznik wrote: > This makes use of QEMU guest agent to implement the > virDomainSuspendForDuration API. > --- > src/qemu/qemu_driver.c | 93 > > 1 files changed, 93 insertions(+), 0 deletions(-) > + > +if (!v

Re: [libvirt] Using Libvirt to change the bridge a virtual network card of a running vm is connected to

2012-03-15 Thread Eric Blake
On 01/26/2012 04:10 AM, Daniel P. Berrange wrote: > On Wed, Jan 25, 2012 at 04:09:22PM +0100, Hendrik Schwartke wrote: >> I wrote a patch to change the mapping between a virtual bridge >> interface and the host bridge while the host is up. It's based on >> commit 6fba577e505611e6c25c68e322942eab775

Re: [libvirt] Memory leak on list_domains

2012-03-15 Thread Eric Blake
On 01/25/2012 03:20 AM, Carlos Rodrigues wrote: > Hi, > > I have some problems on my application with memory leak when call > list_domains method. > > I'm using libvirt 0.8.3 and Sys::Virt 0.2.4 Perl Module. > > Does anyone have any idea what's the problem? Sorry for not noticing this mail soon

Re: [libvirt] [PATCH v2 2/3] snapshots: Introduce VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag

2012-03-15 Thread Eric Blake
On 01/24/2012 01:21 PM, Michal Privoznik wrote: > With this flag, virDomainSnapshotCreate will use fs-freeze and > fs-thaw guest agent commands to quiesce guest's disks. > --- > include/libvirt/libvirt.h.in |4 ++ > src/libvirt.c|6 +++ > src/qemu/qemu_driver.c | 87

Re: [libvirt] [PATCH v3] qemu: Support numad

2012-03-15 Thread Eric Blake
On 03/08/2012 06:36 AM, Osier Yang wrote: > numad is an user-level daemon that monitors NUMA topology and > processes resource consumption to facilitate good NUMA resource > alignment of applications/virtual machines to improve performance > and minimize cost of remote memory latencies. It provides

Re: [libvirt] Modified version of the libvirt-test-api wrapper

2012-03-15 Thread Lucas Meneghel Rodrigues
On 03/14/2012 11:56 AM, Guannan Ren wrote: On 03/14/2012 06:45 PM, Daniel Veillard wrote: On Tue, Mar 13, 2012 at 11:05:31PM -0300, Lucas Meneghel Rodrigues wrote: Hi Guannan: I've worked on your first version of the libvirt-test-api wrapper for autotest. Could you please check if you like the

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Jesse Cook
On Thu, Mar 15, 2012 at 1:10 PM, Eric Blake wrote: > On 03/15/2012 11:48 AM, Daniel P. Berrange wrote: >> Using the sequence of RPC calls to iterate over this is only >> addressing that second part of memory usage. So I'm not really >> feeling that's a huge win, given the complexity it introduces.

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Eric Blake
On 03/15/2012 11:48 AM, Daniel P. Berrange wrote: > Using the sequence of RPC calls to iterate over this is only > addressing that second part of memory usage. So I'm not really > feeling that's a huge win, given the complexity it introduces. > > I'm inclined to say, that if people are creating se

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 10:47:25AM -0600, Eric Blake wrote: > On 03/15/2012 08:31 AM, Eric Blake wrote: > > It may also be worth considering the addition of _just_ a new ranged RPC > > call, but no new public API, by making the public API smart enough to > > automatically call the ranged RPC multip

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Eric Blake
On 03/15/2012 11:30 AM, Jesse Cook wrote: >> At any rate, I don't have code to back this up, but it's certainly food >> for thought on whether it makes sense to try and enhance our use of RPC >> to support transactions without also having to add new public API. >> > > Your solution seems reasonab

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Jesse Cook
On Thu, Mar 15, 2012 at 11:47 AM, Eric Blake wrote: > On 03/15/2012 08:31 AM, Eric Blake wrote: >> It may also be worth considering the addition of _just_ a new ranged RPC >> call, but no new public API, by making the public API smart enough to >> automatically call the ranged RPC multiple times t

Re: [libvirt] [PATCH] sanlock: Enhance error message to point to possible problem with selinux

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 10:55:20AM -0600, Eric Blake wrote: > On 03/15/2012 10:35 AM, Daniel P. Berrange wrote: > > On Thu, Mar 15, 2012 at 05:23:09PM +0100, Peter Krempa wrote: > >> If the connection to the sanlock daemon is forbidden by selinux the > >> error message was not clear enough. This pa

[libvirt] [PATCH] Add support for forcing a private network namespace for LXC guests

2012-03-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If no elements are included in an LXC guest XML description, then the LXC guest will just see the host's network interfaces. It is desirable to be able to hide the host interfaces, without having to define any guest interfaces. This patch introduces a new feature flag

Re: [libvirt] [PATCH] sanlock: Enhance error message to point to possible problem with selinux

2012-03-15 Thread Eric Blake
On 03/15/2012 10:35 AM, Daniel P. Berrange wrote: > On Thu, Mar 15, 2012 at 05:23:09PM +0100, Peter Krempa wrote: >> If the connection to the sanlock daemon is forbidden by selinux the >> error message was not clear enough. This patch adds a check if proper >> configuration for selinux is used whil

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Eric Blake
On 03/15/2012 08:31 AM, Eric Blake wrote: > It may also be worth considering the addition of _just_ a new ranged RPC > call, but no new public API, by making the public API smart enough to > automatically call the ranged RPC multiple times to build up a single > return to the user. After all, if w

Re: [libvirt] [PATCH] lib: Don't access configuration if none is present

2012-03-15 Thread Peter Krempa
On 03/15/2012 05:37 PM, Daniel P. Berrange wrote: On Thu, Mar 15, 2012 at 05:22:28PM +0100, Peter Krempa wrote: Commit e457d5ef2015e6106094b85f8bbd1582002edc4d adds ability to pass the default URI using the client configuration file. If the file is not present, it still accesses the NULL config

Re: [libvirt] [PATCH] lib: Don't access configuration if none is present

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 05:22:28PM +0100, Peter Krempa wrote: > Commit e457d5ef2015e6106094b85f8bbd1582002edc4d adds ability to pass the > default URI using the client configuration file. If the file is not > present, it still accesses the NULL config object causing a segfault. > > Caught running

Re: [libvirt] [PATCH] sanlock: Enhance error message to point to possible problem with selinux

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 05:23:09PM +0100, Peter Krempa wrote: > If the connection to the sanlock daemon is forbidden by selinux the > error message was not clear enough. This patch adds a check if proper > configuration for selinux is used while trying to connect to sanlock. > > *src/locking/lock_

[libvirt] [PATCH] sanlock: Enhance error message to point to possible problem with selinux

2012-03-15 Thread Peter Krempa
If the connection to the sanlock daemon is forbidden by selinux the error message was not clear enough. This patch adds a check if proper configuration for selinux is used while trying to connect to sanlock. *src/locking/lock_driver_sanlock.c: - add macro virLockSystemError that checks for

[libvirt] [PATCH] lib: Don't access configuration if none is present

2012-03-15 Thread Peter Krempa
Commit e457d5ef2015e6106094b85f8bbd1582002edc4d adds ability to pass the default URI using the client configuration file. If the file is not present, it still accesses the NULL config object causing a segfault. Caught running "make check". --- src/libvirt.c |3 ++- 1 files changed, 2 insertio

Re: [libvirt] [PATCHv2] Emit graphics events when a SPICE client connects/disconnects

2012-03-15 Thread Laine Stump
On 03/15/2012 12:19 AM, Osier Yang wrote: > On 03/14/2012 11:05 PM, Laine Stump wrote: >> Wire up the domain graphics event notifications for SPICE. Adapted >> from a RHEL-only patch written by Dan Berrange that used custom >> __com.redhat_SPICE events - equivalent events are now available in >> up

Re: [libvirt] [PATCH] qemuDomainDetachPciDiskDevice: Free allocated cgroup

2012-03-15 Thread Michal Privoznik
On 15.03.2012 13:04, Peter Krempa wrote: > On 03/15/2012 11:49 AM, Michal Privoznik wrote: >> This function potentially allocates new virCgroup but never >> frees it. >> --- > > ACK. > > Peter Thanks, pushed. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Eric Blake
On 03/15/2012 08:41 AM, Daniel P. Berrange wrote: > On Thu, Mar 15, 2012 at 08:31:32AM -0600, Eric Blake wrote: >> On 03/14/2012 07:42 PM, Jesse J. Cook wrote: >>> 256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) >>> is a >>> more appropriate limit and should be sufficient

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Eric Blake
On 03/15/2012 05:51 AM, Daniel P. Berrange wrote: > On Thu, Mar 15, 2012 at 06:22:38AM -0500, Jesse Cook wrote: >> Just to clarify, you would like to see: I have not actually tried this, but based on my understanding of the RPC famework, I'd expect: >> >> v0.9.10 pre-patch client talk to v0.9.10

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 08:31:32AM -0600, Eric Blake wrote: > On 03/14/2012 07:42 PM, Jesse J. Cook wrote: > > 256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) > > is a > > more appropriate limit and should be sufficient. You are more likely to run > > into other system li

Re: [libvirt] [PATCH 1/1] conf, util: on restart of libvirt restart vepa callbacks

2012-03-15 Thread Laine Stump
On 03/14/2012 05:00 AM, D. Herrendoerfer wrote: > From: "D. Herrendoerfer" > > When libvirtd is restarted, also restart the netlink event > message callbacks for existing VEPA connections and send > a message to lldpad for these existing links, so it learns > the new libvirtd pid. > > Note: This P

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Eric Blake
On 03/14/2012 07:42 PM, Jesse J. Cook wrote: > 256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) is a > more appropriate limit and should be sufficient. You are more likely to run > into other system limitations first, such as the 31998 inode link limit on > ext3. > --- > s

[libvirt] [PATCH] qemu: Split ide-drive into ide-cd and ide-hd

2012-03-15 Thread Osier Yang
A "ide-drive" device can be either a hard disk or a CD-ROM, if there is ",media=cdrom" specified for the backend, it's a CD-ROM, otherwise it's a hard disk. Upstream qemu splitted "ide-drive" into "ide-hd" and "ide-cd" since commit 1f56e32, and ",media=cdrom" is not required for ide-cd anymore. "i

[libvirt] [PATCH] qemu: Split scsi-disk into into scsi-hd and scsi-cd

2012-03-15 Thread Osier Yang
A "scsi-disk" device can be either a hard disk or a CD-ROM, if there is ",media=cdrom" specified for the backend, it's a CD-ROM, otherwise it's a hard disk. But upstream qemu splitted "scsi-disk" into "scsi-hd" and "scsi-cd" since commit b443ae, and ",media=cdrom" is not required for scsi-cd anymo

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Jesse Cook
Just to clarify, you would like to see: v0.9.10 pre-patch client talk to v0.9.10 patch server v0.9.10 patch client talk to v0.9.10 pre-patch server Would the test code I used in my cover letter be sufficient? If so, I could probably test this fairly easily and quickly today. On Thu, Mar 15, 201

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Jesse Cook
On Thu, Mar 15, 2012 at 5:14 AM, Daniel P. Berrange wrote: > > On Wed, Mar 14, 2012 at 08:42:35PM -0500, Jesse J. Cook wrote: > > 256 (8 bits) is insufficient for large scale deployments. 65536 (16 > > bits) is a > > more appropriate limit and should be sufficient. You are more likely to > > run >

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Jesse Cook
On Thu, Mar 15, 2012 at 3:42 AM, Osier Yang wrote: > On 03/15/2012 09:42 AM, Jesse J. Cook wrote: >> >> 256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) >> is a >> more appropriate limit and should be sufficient. You are more likely to >> run >> into other system limitatio

Re: [libvirt] [PATCH] qemuDomainDetachPciDiskDevice: Free allocated cgroup

2012-03-15 Thread Peter Krempa
On 03/15/2012 11:49 AM, Michal Privoznik wrote: This function potentially allocates new virCgroup but never frees it. --- ACK. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 06:22:38AM -0500, Jesse Cook wrote: > Just to clarify, you would like to see: > > v0.9.10 pre-patch client talk to v0.9.10 patch server > v0.9.10 patch client talk to v0.9.10 pre-patch server And for comparison v0.9.10 pre-patch client talk to v0.9.10 pre-patch server

[libvirt] [PATCH] numad: Fix typo and warning

2012-03-15 Thread Osier Yang
src/libvirt_private.syms: s/virDomainCpuPlacement/virDomainCpuPlacementMode/ src/qemu/qemu_process.c def->mem.cur_balloon expects "llu" -- pushed under build-breaker rule --- src/libvirt_private.syms |4 ++-- src/qemu/qemu_process.c |2 +- 2 files changed, 3 insertions(+), 3 deletions

[libvirt] [PATCH v3 1/2] PowerPC : Implement sysinfo on PowerPC.

2012-03-15 Thread Prerna
From: Prerna Saxena Date: Thu, 15 Mar 2012 16:05:26 +0530 Subject: [PATCH 1/2] Implement sysinfo on PowerPC. Libvirt on x86 parses 'dmidecode' to gather characteristics of host system. On PowerPC, this is now implemented by reading /proc/cpuinfo NOTE: memory-DIMM information is not presently impl

[libvirt] [PATCH v3 0/3] Sysinfo improvements for PowerPC & x86

2012-03-15 Thread Prerna
This series of patches implements the following: Patch 1/2 : Implement sysinfo for PowerPC. OnPowerPC, sysinfo is obtained by reading /proc/cpuinfo since dmidecode is not available. Patch 2/2 : Based on Eric's suggestion (http://www.redhat.com/archives/libvir-list/2012-February/msg00509.html) All

[libvirt] [PATCH] hold the reference when call monitor's callback

2012-03-15 Thread Wen Congyang
When qemu cannot startup, we will call EOF notify callback. Unfortunately, there is a bug in libvirt, and it will cause mon->ref to be 0 while we call EOF notify callback. This bug will cause the libvirt to be deadlock. We call the other callback while holding the reference. So I think we should a

[libvirt] [PATCH] qemuDomainDetachPciDiskDevice: Free allocated cgroup

2012-03-15 Thread Michal Privoznik
This function potentially allocates new virCgroup but never frees it. --- src/qemu/qemu_hotplug.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e088a49..f1c1283 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qe

[libvirt] [PATCH v3 2/2] x86: Allow sysinfo to fall back on /proc/cpuinfo if demidecode is absent.

2012-03-15 Thread Prerna
From: Prerna Saxena Date: Thu, 16 Feb 2012 15:33:43 +0530 Subject: [PATCH 2/2] Sysinfo : Allow x86 to fetch sysinfo from /proc/cpuinfo in the event 'dmidecode' is absent in the system. Until now, libvirt on x86 flags an error message if dmidecode is not found. With this patch, the following is a

Re: [libvirt] [PATCH] virsh: A bit smarter attach-disk

2012-03-15 Thread Michal Privoznik
On 15.03.2012 10:13, Osier Yang wrote: > Detects the file type of source path if no "--sourcetype" and > "driver" is specified, instead of always set the disk type as > "block". > > And previous "virCommandOptString" ensures "source" is not NULL, > remove the conditional checking. > --- > tools/v

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 08:42:35PM -0500, Jesse J. Cook wrote: > 256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) is a > more appropriate limit and should be sufficient. You are more likely to run > into other system limitations first, such as the 31998 inode link limit on

Re: [libvirt] [PATCH v2] virsh: A bit smarter attach-disk

2012-03-15 Thread Osier Yang
On 03/15/2012 05:32 PM, Michal Privoznik wrote: On 15.03.2012 11:17, Osier Yang wrote: Detects the file type of source path if no "--sourcetype" and "driver" is specified, instead of always set the disk type as "block". --- tools/virsh.c |7 ++- 1 files changed, 6 insertions(+), 1 del

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-15 Thread Chunyan Liu
2012/3/15 Jim Fehlig > > While testing this patch, I noticed some strange problems wrt concurrent > operations in the driver. E.g. if I start a migration and then query > dominfo on the migrating domain, it kills the migration > > xen134: # virsh migrate --live sles11sp1-pv xen+ssh://xen142 > er

Re: [libvirt] [PATCH v2] virsh: A bit smarter attach-disk

2012-03-15 Thread Michal Privoznik
On 15.03.2012 11:17, Osier Yang wrote: > Detects the file type of source path if no "--sourcetype" and > "driver" is specified, instead of always set the disk type as > "block". > --- > tools/virsh.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > ACK Michal -- libvir-list

[libvirt] [PATCH v2] virsh: A bit smarter attach-disk

2012-03-15 Thread Osier Yang
Detects the file type of source path if no "--sourcetype" and "driver" is specified, instead of always set the disk type as "block". --- tools/virsh.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d45a4c9..19f9bbe 100644 --- a/to

Re: [libvirt] [PATCH] virsh: A bit smarter attach-disk

2012-03-15 Thread Osier Yang
On 03/15/2012 05:12 PM, Michal Privoznik wrote: On 15.03.2012 10:13, Osier Yang wrote: Detects the file type of source path if no "--sourcetype" and "driver" is specified, instead of always set the disk type as "block". And previous "virCommandOptString" ensures "source" is not NULL, remove the

Re: [libvirt] [Qemu-trivial] do_spice_init error on Ubuntu11.10

2012-03-15 Thread Stefan Hajnoczi
On Thu, Mar 08, 2012 at 11:29:48AM +0800, suyi wang wrote: > Hi all: Hi Suyi, qemu-trivial is a mailing list for QEMU patches, questions should be directed at the regular QEMU mailing list. I have CCed qemu-devel and libvirt-list so your question will go to the QEMU and libvirt communities. Are

Re: [libvirt] [Resending][PATCH v2 2/2] x86: Allow sysinfo to fall back on /proc/cpuinfo if demidecode is absent

2012-03-15 Thread Prerna Saxena
On 03/15/2012 12:40 PM, Daniel Veillard wrote: > On Thu, Mar 15, 2012 at 12:28:05PM +0530, Prerna Saxena wrote: >> On 03/15/2012 11:37 AM, Daniel Veillard wrote: >>> On Thu, Mar 15, 2012 at 11:21:09AM +0530, Prerna Saxena wrote: Hi Daniel, Thank you for taking a look. > [...] Thanks

[libvirt] [PATCH] virsh: A bit smarter attach-disk

2012-03-15 Thread Osier Yang
Detects the file type of source path if no "--sourcetype" and "driver" is specified, instead of always set the disk type as "block". And previous "virCommandOptString" ensures "source" is not NULL, remove the conditional checking. --- tools/virsh.c | 14 +- 1 files changed, 9 insert

Re: [libvirt] [PATCH] Increased upper limit on lists of pool names

2012-03-15 Thread Osier Yang
On 03/15/2012 09:42 AM, Jesse J. Cook wrote: 256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) is a more appropriate limit and should be sufficient. You are more likely to run into other system limitations first, such as the 31998 inode link limit on ext3. --- src/remote

Re: [libvirt] [Resending][PATCH v2 2/2] x86: Allow sysinfo to fall back on /proc/cpuinfo if demidecode is absent

2012-03-15 Thread Daniel Veillard
On Thu, Mar 15, 2012 at 12:28:05PM +0530, Prerna Saxena wrote: > On 03/15/2012 11:37 AM, Daniel Veillard wrote: > > On Thu, Mar 15, 2012 at 11:21:09AM +0530, Prerna Saxena wrote: > >> Hi Daniel, > >> Thank you for taking a look. [...] > >> Thanks for pointing this out. I investigated this discrepan

Re: [libvirt] [PATCH] virsh: fix invalid free

2012-03-15 Thread Alex Jia
Thanks and pushed now. - Original Message - From: "Osier Yang" To: "Alex Jia" Cc: libvir-list@redhat.com Sent: Thursday, March 15, 2012 3:16:48 PM Subject: Re: [libvirt] [PATCH] virsh: fix invalid free On 03/15/2012 02:06 PM, Alex Jia wrote: > * tools/virsh.c (cmdDetachDisk): fix invali

Re: [libvirt] [Resending][PATCH v2 2/2] x86: Allow sysinfo to fall back on /proc/cpuinfo if demidecode is absent

2012-03-15 Thread Prerna Saxena
On 03/15/2012 11:37 AM, Daniel Veillard wrote: > On Thu, Mar 15, 2012 at 11:21:09AM +0530, Prerna Saxena wrote: >> Hi Daniel, >> Thank you for taking a look. >> >> On 03/14/2012 02:29 PM, Daniel Veillard wrote: >>> On Tue, Mar 13, 2012 at 11:10:16AM +0530, Prerna Saxena wrote: From: Prerna Sax