On 03/21/2012 06:13 PM, Guannan Ren wrote:
On 03/21/2012 08:46 PM, Peter Krempa wrote:
For some tests it's not needed to ping the guest in the startup process.
This patch adds a flag to the start and destroy test to skip such
attempts (that consume a lot of time)
---
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Avoid the need for each driver to parse query parameters itself
by storing them directly in the virURIPtr struct. The parsing
code is a copy of that from src/util/qparams.c The latter will
be removed in
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Avoid the need for each driver to parse query parameters itself
by storing them directly in the virURIPtr struct. The parsing
code is a copy of that from src/util/qparams.c The latter will
be removed in
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Convert drivers currently using the qparams APIs, to instead
use the virURIPtr query parameters directly.
* src/esx/esx_util.c, src/hyperv/hyperv_util.c,
src/remote/remote_driver.c,
On 03/21/2012 08:46 PM, Peter Krempa wrote:
This is a set of more or less independent fixes and improvements to the
test API. I ran across these while trying to write a basic test case as
a Hello world! to the test-API.
Improvements are in fields of cross-distro compatibility, broken API's and
On 03/22/2012 03:02 PM, Martin Kletzander wrote:
I'd rather do it using the get() method for dictionaries with some
default, i.e. params.get('flags', None).
Just my $0.02
Martin
Thanks, This belongs to enhancement work, let us do it a little later.
Probably, we need a cleanup patch
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
To follow latest naming conventions, rename src/util/authhelper.[ch]
to src/util/virauth.[ch].
* src/util/authhelper.[ch]: Rename to src/util/virauth.[ch]
* src/esx/esx_driver.c,
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Ensure that the functions in virauth.h have names matching the file
prefix, by renaming virRequest{Username,Password} to
virAuthGet{Username,Password}
---
src/esx/esx_driver.c |8
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
* src/util/virauth.c, src/util/virauth.h: Add virAuthGetConfigFilePath
* include/libvirt/virterror.h, src/util/virterror.c: Add
VIR_FROM_AUTH error domain
---
include/libvirt/virterror.h |1 +
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
This defines the format for the auth credential config file and
provides APIs to access the data. The config file contains
one or more named 'credential' sets
[credentials-$NAME]
credname1=value1
On 03/21/2012 04:45 PM, Guannan Ren wrote:
On 03/21/2012 08:46 PM, Peter Krempa wrote:
The streamAPI class that encapsulates work with libvirt's streams was
fundamentaly broken:
- each call to one of the methods created a new stream and
performed the call
- some methods called virStream methods
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
SASL may prompt for credentials after either a 'start' or 'step'
invocation. In both cases the code to handle this is the same.
Refactor this code into a separate method to reduce the duplication,
since
On 03/21/2012 05:02 PM, Guannan Ren wrote:
On 03/21/2012 08:46 PM, Peter Krempa wrote:
This patch adds a wrapper that enables work with consoles in the
test-API.
---
lib/domainAPI.py | 9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/lib/domainAPI.py b/lib/domainAPI.py
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
When SASL requests auth credentials, try to look them up in the
config file first. If any are found, remove them from the list
that the user is prompted for
---
src/esx/esx_driver.c | 58
Wouldn't this actualy defeat the encapsulation that is provided in the
StreamAPI class? With this change you can reuse the StreamAPI object
for other actions later on too, without loosing the abstraction.
With the chagne you pushed:
diff --git a/lib/domainAPI.py b/lib/domainAPI.py
index
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, trying to summarize what was discussed in the call:
On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
Let's say we moved CPU definitions to /usr/share/qemu/cpu-models.xml.
Obviously, we'd want a
On 2012年03月21日 01:33, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
The '.ini' file format is a useful alternative to the existing
config file style, when you need to have config files which
are hashes of hashes. The 'virKeyFilePtr' object provides a
way to parse these
On Thu, Mar 22, 2012 at 09:36:30AM +0530, Onkar N Mahajan wrote:
Libvirt doesn't care about security during hot add disk images. It even
accepts addition of disk images of other guest running on the host.
Steps followed to create this scenario :
Now, try to add vm1's disk image into vm2
On 03/22/2012 08:54 AM, Guannan Ren wrote:
On 03/21/2012 08:46 PM, Peter Krempa wrote:
This is a set of more or less independent fixes and improvements to the
test API. I ran across these while trying to write a basic test case as
a Hello world! to the test-API.
Improvements are in fields of
There was one big inconsistency in our source files when return was
used. Sometimes it was used with parentheses and sometimes
without. The old-style return(value) was removed in the first commit,
the second commit introduces new syntax-check to ensure the style will
remain the same in the future.
After cleanup introduced with previous commit, there is a need for
syntax-check rule taking care of return(). Regexp used in 'prohibit'
parameter is taken from the cleanup commit and modified so it fits
'grep -E' format. Semicolon at the end is needed, otherwise the regexp
could match return with
This fixes a race condition when VIR_EVENT_HANDLE_HANGUP is triggered
during lxcDomainDestroyFlags: lxcMonitorEvent tries to acquire the
driver lock held by lxcDomainDestroyFlags and blocks. Meanwhile
lxcDomainDestroyFlags will free the vm structure and release the driver
lock. lxcMonitorEvent
With this patch, the newStream() method of the ConnectAPI class returns
an already encapsulated StreamAPI object .
*lib/connectAPI.py: - modify newStream method to return StreamAPI
object
*lib/streamAPI.py: - modify constructor to take virStream objects
---
Add the local copy of the flags.
---
lib/connectAPI.py |2 ++
lib/domainAPI.py |3 +++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/connectAPI.py b/lib/connectAPI.py
index dab5e7d..2723fc8 100644
--- a/lib/connectAPI.py
+++ b/lib/connectAPI.py
@@ -350,3 +350,5 @@
On 03/20/2012 11:33 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This defines the format for the auth credential config file and
provides APIs to access the data. The config file contains
one or more named 'credential' sets
[credentials-$NAME]
Dear all,
I have the following situation:
-I replaced the standard bridge driver with the Open VSwitch one;
-I started a NAT-network on Libvirt (bridge name virbr1);
-I started a Virtual Machine (VM1) on Libvirt, and I tagged his interface
(vnet0) with tag=2;
-if I run # ovs-vsctl show I obtain:
On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, trying to summarize what was discussed in the call:
On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
Let's say we moved CPU definitions to
On 03/22/2012 08:54 PM, Peter Krempa wrote:
With this patch, the newStream() method of the ConnectAPI class returns
an already encapsulated StreamAPI object .
*lib/connectAPI.py: - modify newStream method to return StreamAPI
object
*lib/streamAPI.py: - modify
On 03/22/2012 08:56 PM, Peter Krempa wrote:
Add the local copy of the flags.
---
lib/connectAPI.py |2 ++
lib/domainAPI.py |3 +++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/connectAPI.py b/lib/connectAPI.py
index dab5e7d..2723fc8 100644
---
From: Daniel P. Berrange berra...@redhat.com
Currently the libvirt.service unit file for systemd does not
specify any kill mode. So systemd kills off every process
inside its cgroup. ie all dnsmasq processes, all virtual
machines. This obviously not what we want. Set KillMode=process
so that it
On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the libvirt.service unit file for systemd does not
specify any kill mode. So systemd kills off every process
inside its cgroup. ie all dnsmasq processes, all virtual
machines.
On 03/17/2012 10:27 PM, Eric Blake wrote:
QEmu 1.1 is adding a 'transaction' command to the JSON monitor.
Each element of a transaction corresponds to a top-level command,
with the additional guarantee that the transaction flushes all
pending I/O, then guarantees that all actions will be
On Thu, 2012-03-22 at 14:10 +, Mark McLoughlin wrote:
On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the libvirt.service unit file for systemd does not
specify any kill mode. So systemd kills off every process
On Thu, Mar 22, 2012 at 02:10:30PM +, Mark McLoughlin wrote:
On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the libvirt.service unit file for systemd does not
specify any kill mode. So systemd kills off every
On Thu, 2012-03-22 at 14:22 +, Daniel P. Berrange wrote:
On Thu, Mar 22, 2012 at 02:10:30PM +, Mark McLoughlin wrote:
On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the libvirt.service unit file for systemd
On Thu, Mar 22, 2012 at 10:31:21AM -0300, Eduardo Habkost wrote:
On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, trying to summarize what was discussed in the call:
On Mon, Mar 12, 2012 at 10:08:10AM
On Thu, Mar 22, 2012 at 02:27:59PM +, Mark McLoughlin wrote:
On Thu, 2012-03-22 at 14:22 +, Daniel P. Berrange wrote:
On Thu, Mar 22, 2012 at 02:10:30PM +, Mark McLoughlin wrote:
On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange
On 03/17/2012 10:27 PM, Eric Blake wrote:
The hardest part about adding transactions is not using the new
monitor command, but undoing the partial changes we made prior
to a failed transaction.
* src/qemu/qemu_driver.c (qemuDomainSnapshotCreateDiskActive): Use
transaction when available.
On 03/20/2012 03:29 PM, Eric Blake wrote:
The oVirt developers have stated that the real reasons they want
to have qemu reuse existing volumes when creating a snapshot are:
1. the management framework is set up so that creation has to be
done from a central node for proper resource tracking,
On 03/21/2012 10:07 PM, Dave Allan wrote:
virsh.pod had several instances in which it referred to the
documentation which was a little puzzling to me since it is
documentation. Reading the document from end to end makes it clear
that it means a specific URI which was noted previously in the
On Thu, Mar 22, 2012 at 11:37:39AM -0500, Anthony Liguori wrote:
On 03/22/2012 04:32 AM, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, this problem is solved if the defaults are easily found on
/usr/share.
What problem is solved and why are we
This patch adds DHCP snooping support to libvirt. The learning method for
IP addresses is specified by setting the ip_learning variable to one of
any [default] (existing IP learning code), none (static only addresses)
or dhcp (DHCP snooping).
Active leases are saved in a lease file and reloaded
On Thu, Mar 22, 2012 at 6:10 AM, Daniele Milani dano1...@hotmail.it wrote:
Dear all,
I have the following situation:
-I replaced the standard bridge driver with the Open VSwitch one;
-I started a NAT-network on Libvirt (bridge name virbr1);
-I started a Virtual Machine (VM1) on Libvirt, and
I think I could try the first solution. Can you explain me how do I create the
port used by dnsmasq?
For example, is it correct to execute
# ovs-vsctl add-port virbr1 port2 tag=2
to create a port for the vLan whose tag is 2 named port2?
Daniele Milani
Date: Thu, 22 Mar 2012 10:54:21 -0700
On Thu, Mar 22, 2012 at 11:11 AM, Daniele Milani dano1...@hotmail.itwrote:
I think I could try the first solution. Can you explain me how do I
create the port used by dnsmasq?
For example, is it correct to execute
# ovs-vsctl add-port virbr1 port2 tag=2
to create a port for the vLan whose
On 03/22/2012 09:10 AM, Daniele Milani wrote:
Dear all,
I have the following situation:
-I replaced the standard bridge driver with the Open VSwitch one;
I'm curious what you mean by this.
libvirt's virtual networks currently only support the standard linux
bridge device. There is no code in
(Cc'ing to libvirt-us...@redhat.com)
On 03/22/2012 02:43 PM, Ansis Atteka wrote:
On Thu, Mar 22, 2012 at 11:11 AM, Daniele Milani dano1...@hotmail.it
mailto:dano1...@hotmail.it wrote:
I think I could try the first solution. Can you explain me how do
I create the port used by
David Stevens/Beaverton/IBM@IBMUS wrote on 03/22/2012 01:27:10 PM:
This patch adds DHCP snooping support to libvirt. The learning method
for
IP addresses is specified by setting the ip_learning variable to one
of
any [default] (existing IP learning code), none (static only
addresses)
or
There were a couple of minor inaccuracies in the freecell manpage and
virsh help. The first patch fixes the manpage and the second, to
virsh.c, attempts to fix the help output. The virsh.c patch appears
to produce the correct output, but is pure cargo cult programming, so
it should be very
On 03/22/2012 12:14 PM, Eduardo Habkost wrote:
On Thu, Mar 22, 2012 at 11:37:39AM -0500, Anthony Liguori wrote:
On 03/22/2012 04:32 AM, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, this problem is solved if the defaults are easily found on
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 9e5c9b2..d9cff0c 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -4742,7 +4742,7 @@ static const vshCmdInfo info_freecell[] = {
};
static const vshCmdOptDef
On 03/22/2012 01:59 PM, Dave Allan wrote:
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 9e5c9b2..d9cff0c 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -4742,7 +4742,7 @@ static const vshCmdInfo
On 03/22/2012 12:56 PM, Laine Stump wrote:
On 03/21/2012 10:07 PM, Dave Allan wrote:
virsh.pod had several instances in which it referred to the
documentation which was a little puzzling to me since it is
documentation. Reading the document from end to end makes it clear
that it means a
On 03/22/2012 01:59 PM, Dave Allan wrote:
---
tools/virsh.pod | 23 ++-
1 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f0df4fd..b4deae8 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -401,11 +401,24 @@
Stefan Berger/Watson/IBM wrote on 03/22/2012 12:22:20 PM:
I tried it. It doesn't apply more than one IP address. The code also
doesn't apply cleanly to the tip.
Stefan
Stefan,
I did a git pull yesterday to which this patch is
applied; here is the last entry before the patch:
On Thu, Mar 22, 2012 at 02:13:07PM -0600, Eric Blake wrote:
On 03/22/2012 01:59 PM, Dave Allan wrote:
---
tools/virsh.pod | 23 ++-
1 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f0df4fd..b4deae8 100644
On Thu, Mar 22, 2012 at 02:10:30PM -0600, Eric Blake wrote:
On 03/22/2012 01:59 PM, Dave Allan wrote:
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 9e5c9b2..d9cff0c 100644
--- a/tools/virsh.c
+++
Modified per Eric's feedback: removed incorrect virsh help change,
removed unnecessary examples in the manpage. I also fixed two
instances in which I referred to nodes instead of cells.
Dave
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
tools/virsh.pod | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f0df4fd..a8bd739 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -401,11 +401,16 @@ Bvirsh list --title
0 Domain-0 running
David Stevens/Beaverton/IBM wrote on 03/22/2012 04:22:55 PM:
From: David Stevens/Beaverton/IBM
To: Stefan Berger/Watson/IBM
Cc: Daniel P. Berrange berra...@redhat.com, libvir-list@redhat.com
Date: 03/22/2012 04:23 PM
Subject: Re: [libvirt PATCHv6 1/1] add DHCP snooping
Stefan
Stefan Berger/Watson/IBM wrote on 03/22/2012 03:04:53 PM:
I have some concerns about the cancelation of the thread. It can
hold the snoop lock and get cancelled while holding it. Next time
that lock is grabbed we will get a deadlock...
The snoop lock is acquired in
On 03/22/2012 04:49 PM, David Stevens wrote:
Stefan Berger/Watson/IBM wrote on 03/22/2012 03:04:53 PM:
I have some concerns about the cancelation of the thread. It can
hold the snoop lock and get cancelled while holding it. Next time
that lock is grabbed we will get a deadlock...
The
Eric Blake ebl...@redhat.com wrote on 03/22/2012 03:54:31 PM:
pthread_cancel() tends to imply that you are properly managing signal
blocking across threads; we haven't used it anywhere else in libvirt,
and I'm extremely wary of pulling it in now, as there's probably a lot
of subtle bugs
David Stevens/Beaverton/IBM wrote on 03/22/2012 07:26:06 PM:
From: David Stevens/Beaverton/IBM
To: Eric Blake ebl...@redhat.com
Cc: libvir-list@redhat.com, Stefan Berger/Watson/IBM@IBMUS
Date: 03/22/2012 07:26 PM
Subject: Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping
Eric Blake
Stefan Berger/Watson/IBM wrote on 03/22/2012 05:00:45 PM:
Maybe we should go with the previous code from a while ago which was
setting a flag for the thread to die. It caused other work-arounds
to become necessary but at least we don't have to deal with possibly
async. deaths of threads
Eric Blake ebl...@redhat.com wrote on 03/22/2012 06:54:31 PM:
On 03/22/2012 04:49 PM, David Stevens wrote:
Stefan Berger/Watson/IBM wrote on 03/22/2012 03:04:53 PM:
I have some concerns about the cancelation of the thread. It can
hold the snoop lock and get cancelled while holding
David Stevens/Beaverton/IBM wrote on 03/22/2012 08:10:44 PM:
From: David Stevens/Beaverton/IBM
To: Stefan Berger/Watson/IBM
Cc: Eric Blake ebl...@redhat.com, libvir-list@redhat.com
Date: 03/22/2012 08:10 PM
Subject: Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping
Stefan
Stefan Berger/Watson/IBM wrote on 03/22/2012 05:33:41 PM:
Ok.
An idea may be that the threat has to 'find' its snoop request in a
global list every time it processes a packet. Once it cannot find it
anymore, it dies. Removing the request from the global list would be
the way to terminate
---
docs/formatdomain.html.in |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 4edada3..3a504a1 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2903,8 +2903,8 @@ qemu-kvm -net
On 03/22/2012 08:40 PM, Zhou Peng wrote:
Commit message could have mentioned the typo; it took me three reads to
see what you changed.
---
docs/formatdomain.html.in |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in
On 03/22/2012 02:49 PM, Dave Allan wrote:
---
tools/virsh.pod | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f0df4fd..a8bd739 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -401,11 +401,16 @@ Bvirsh
On 2012年03月22日 19:33, Martin Kletzander wrote:
Return statements with parameter enclosed in parentheses were modified
and parentheses were removed. The whole change was scripted, here is how:
List of files was obtained using this command:
git grep -l -e
A snapshot-based mirrored storage migration sequence requires both the
'drive-mirror' action in 'transaction' (present if the 'drive-mirror'
standalone monitor command also exists) and the 'drive-reopen' monitor
command (it would be nice if that were also part of a 'transaction',
but the initial
Delete a mirrored snapshot by picking which of the two files in the
mirror to reopen. This is not atomic, so we update the snapshot
in place as we iterate through each successful disk. Since we limited
mirrored snapshots to transient domains, there is no persistent
configuration to update. This
I was originally going to send this as two rounds, one for
the XML additions of adding mirrors, and one for the flag
addition to virDomainSnapshotDelete for mapping to drive-reopen;
but it turned out that testing is easier if I finish the series.
Note that this is minimally tested at the moment;
This extends domainsnapshot XML to add a new element under each
disk of a disk snapshot:
disk name='vda'
source file='/path/to/live'/
mirror file='/path/to/mirror'/
/disk
For now, if a mirror is requested, the snapshot must be external,
and assumes the same driver format (qcow2 or
The hardest part of this patch is figuring out how to provide proper
security labeling and lock manager setup for the mirror, as well as
rolling it all back on error.
* src/qemu/qemu_driver.c (qemuDomainSnapshotCreateXML): Decide
when mirrors are allowed.
(qemuDomainSnapshotDiskPrepare): Prepare
This completes the public API for using mirrored snapshots as a
means of performing live storage migration. Of course, it will
take additional patches to actually provide the implementation.
The idea here is that oVirt can start with a domain with 'vda'
open on /path1/to/old.qcow2 with a base
For now, disk migration via mirroring is not implemented. But when
we do implement it, we have to deal with the fact that qemu does
not provide an easy way to re-start a qemu process with mirroring
still intact (it _might_ be possible by using qemu -S then an
initial 'drive-mirror' with disk
On Fedora16 or above, qemu is supported now. So it is added
in rpm packaging.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
libvirt.spec.in |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 072fd8e..568a84f 100644
---
On 03/22/2012 07:33 PM, Martin Kletzander wrote:
After cleanup introduced with previous commit, there is a need for
syntax-check rule taking care of return(). Regexp used in 'prohibit'
parameter is taken from the cleanup commit and modified so it fits
'grep -E' format. Semicolon at the end is
81 matches
Mail list logo
