On May 1, 2012, at 10:19 PM, Daniel Veillard veill...@redhat.com wrote:
On Mon, Apr 30, 2012 at 11:43:32AM -0700, Jason Helfman wrote:
On Mon, Apr 30, 2012 at 01:38:27PM -0500, Doug Goldstein thus spake:
On Sat, Apr 28, 2012 at 10:35 PM, Jason Helfman jhelf...@e-e.com wrote:
Okay, I screwed
On Wed, May 02, 2012 at 01:22:37AM -0500, Doug Goldstein wrote:
On May 1, 2012, at 10:19 PM, Daniel Veillard veill...@redhat.com wrote:
On Mon, Apr 30, 2012 at 11:43:32AM -0700, Jason Helfman wrote:
On Mon, Apr 30, 2012 at 01:38:27PM -0500, Doug Goldstein thus spake:
On Sat, Apr 28, 2012
Am 01.05.2012 22:25, schrieb Anthony Liguori:
Thanks for sending this out Stefan.
On 05/01/2012 10:31 AM, Stefan Hajnoczi wrote:
Libvirt can take advantage of SELinux to restrict the QEMU process and
prevent
it from opening files that it should not have access to. This improves
security
On Wed, May 2, 2012 at 9:20 AM, Kevin Wolf kw...@redhat.com wrote:
Am 01.05.2012 22:25, schrieb Anthony Liguori:
Thanks for sending this out Stefan.
On 05/01/2012 10:31 AM, Stefan Hajnoczi wrote:
Libvirt can take advantage of SELinux to restrict the QEMU process and
prevent
it from opening
On Tue, May 01, 2012 at 04:31:44PM +0100, Stefan Hajnoczi wrote:
From: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
---
qemu-options.hx | 42 ++
1
On Wed, May 02, 2012 at 10:20:17AM +0200, Kevin Wolf wrote:
Am 01.05.2012 22:25, schrieb Anthony Liguori:
Thanks for sending this out Stefan.
On 05/01/2012 10:31 AM, Stefan Hajnoczi wrote:
Libvirt can take advantage of SELinux to restrict the QEMU process and
prevent
it from opening
On Tue, May 01, 2012 at 04:31:42PM +0100, Stefan Hajnoczi wrote:
Libvirt can take advantage of SELinux to restrict the QEMU process and prevent
it from opening files that it should not have access to. This improves
security because it prevents the attacker from escaping the QEMU process if
On Tue, May 01, 2012 at 04:31:44PM +0100, Stefan Hajnoczi wrote:
From: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
---
qemu-options.hx | 42 ++
1
On Tue, May 01, 2012 at 08:30:27PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c |1 +
libvirt-gobject/libvirt-gobject-domain-snapshot.c |1 +
libvirt-gobject/libvirt-gobject-domain.c
On Tue, May 01, 2012 at 03:10:42PM -0400, Laine Stump wrote:
This patch is one alternative to solve the problem detailed in:
https://bugzilla.redhat.com/show_bug.cgi?id=816465
Some other unidentified library in use by libvirtd (in another thread)
is apparently temporarily binding to a
Am 02.05.2012 10:27, schrieb Stefan Hajnoczi:
On Wed, May 2, 2012 at 9:20 AM, Kevin Wolf kw...@redhat.com wrote:
Am 01.05.2012 22:25, schrieb Anthony Liguori:
Thanks for sending this out Stefan.
On 05/01/2012 10:31 AM, Stefan Hajnoczi wrote:
Libvirt can take advantage of SELinux to restrict
Am 02.05.2012 10:53, schrieb Daniel P. Berrange:
On Wed, May 02, 2012 at 10:20:17AM +0200, Kevin Wolf wrote:
Am 01.05.2012 22:25, schrieb Anthony Liguori:
Thanks for sending this out Stefan.
On 05/01/2012 10:31 AM, Stefan Hajnoczi wrote:
Libvirt can take advantage of SELinux to restrict the
On Wed, May 02, 2012 at 11:45:26AM +0200, Kevin Wolf wrote:
Am 02.05.2012 10:53, schrieb Daniel P. Berrange:
On Wed, May 02, 2012 at 10:20:17AM +0200, Kevin Wolf wrote:
Am 01.05.2012 22:25, schrieb Anthony Liguori:
Thanks for sending this out Stefan.
On 05/01/2012 10:31 AM, Stefan
Hey,
On Mon, Apr 30, 2012 at 02:55:06PM -0400, William Jon McCann wrote:
This has a number of advantages for us:
It allows sharing a home directory between different machines, or
sessions (eg. using NFS)
Supports performing smart or selective migration of settings
between different
What happens when some parameters are not listed/when some blank lines are
missing? Does it output a warning, or abort?
Also, one oddity below,
Christophe
On Tue, May 01, 2012 at 08:30:27PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
ACK on this one, dunno if we'll want an async variant of this.
Christophe
On Tue, May 01, 2012 at 08:30:38PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-capabilities.c |4 ---
From: Daniel P. Berrange berra...@redhat.com
* src/util/threads-pthread.c, src/util/threads.h: Add virThreadCancel
---
src/util/threads-pthread.c |5 +
src/util/threads.h |1 +
2 files changed, 6 insertions(+)
diff --git a/src/util/threads-pthread.c
From: Daniel P. Berrange berra...@redhat.com
When dispatching an RPC API call, setup the access manager to hold
the real effective identities of the current server client whose
RPC is being dispatched. The setting is thread-local, so only
affects the API call in this thread
---
This is a repost of
https://www.redhat.com/archives/libvir-list/2012-January/msg00907.html
which got no comments last time out.
This series of patch is the minimal required to get a working proof
of concept implementation of fine grained access control in libvirt.
This demonstrates
-
From: Daniel P. Berrange berra...@redhat.com
Allow the logging APIs to be called with a va_list for format
args, instead of requiring var-args usage.
* src/util/logging.h, src/util/logging.c: Add virLogVMessage
---
src/util/logging.c | 29 -
src/util/logging.h |
From: Daniel P. Berrange berra...@redhat.com
Add APIs which allow storage of a real effective identity on
all server clients. Also add an API which allows creation of an
initial identity based on the results of client authentication
processes like TLS, x509, SASL, SO_PEERCRED
---
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in |1 +
src/Makefile.am |3 +-
src/access/viraccessdriverselinux.c | 388 +++
src/access/viraccessdriverselinux.h | 28 +++
From: Daniel P. Berrange berra...@redhat.com
Currently the server determines whether authentication of clients
is complete, by checking whether an identity is set. This patch
removes that lame hack and replaces it with an explicit method
for changing the client auth code
* daemon/remote.c:
From: Daniel P. Berrange berra...@redhat.com
Add new APIs virNetServerClientGetTLSSession,
virNetServerClientIsLocal, virNetServerClientGetSecurityContext
virNetServerClientGetSASLSession, virNetSocketGetSecurityContext
and virNetTLSSessionGetX509DName
---
src/rpc/virnetserverclient.c | 48
From: Daniel P. Berrange berra...@redhat.com
---
include/libvirt/virterror.h |3 +
po/POTFILES.in|1 +
src/Makefile.am | 16 +
src/access/apis.txt | 577 +
src/access/viraccessdriver.h |
From: Daniel P. Berrange berra...@redhat.com
Inserts the minimal access control checks to the QEMU driver to
protect usage of virDomainObjPtr objects.
---
src/qemu/qemu_driver.c| 626 +++--
src/qemu/qemu_migration.c |5 +
2 files changed, 605
From: Daniel P. Berrange berra...@redhat.com
Introduce a new 'access_driver' configuration parameter which
specifies the name of the access control manager driver to
activate. By default the 'no op' driver is active
---
src/qemu/qemu.conf |5 +
src/qemu/qemu_conf.c |9 +
From: Daniel P. Berrange berra...@redhat.com
---
include/libvirt/libvirt.h.in | 30 ++
include/libvirt/virterror.h |1 +
src/datatypes.h | 20
src/libvirt.c| 246 ++
src/libvirt_public.syms |5 +
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in |1 +
src/Makefile.am | 12 ++-
src/access/org.libvirt.domain.policy | 37
src/access/viraccessdriverpolkit.c | 163 ++
Quoting Stefan Berger (stef...@linux.vnet.ibm.com):
On 04/30/2012 06:59 PM, Serge Hallyn wrote:
configure.ac:
Check for libnl-3. If found, find libnl-route-3. If not found,
do the original check to look for libnl-1.
[...]
--- a/src/util/virnetlink.c
+++ b/src/util/virnetlink.c
@@
On 05/01/2012 10:16 AM, Guannan Ren wrote:
usbFindDevice():get usb device according to
idVendor, idProduct, bus, device
it is the most strict search
usbFindDevByBus():get usb device according to bus, device
it returns only one usb device
Anthony, isn't this going to get in for 1.1? I was expecting it to be
applied before the freeze.
On Tue, Apr 24, 2012 at 05:32:55PM -0300, Eduardo Habkost wrote:
Changes v1 - v2:
- Move qemu_read_default_config_files() prototype to qemu-config.h
- Make defconfig and userconfig variable
Am 02.05.2012 15:50, schrieb Eduardo Habkost:
Anthony, isn't this going to get in for 1.1? I was expecting it to be
applied before the freeze.
You wrote you would respin it with s/int/bool/. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,
On Wed, May 2, 2012 at 1:34 PM, Christophe Fergeau cferg...@redhat.com wrote:
What happens when some parameters are not listed/when some blank lines are
missing?
Does it output a warning, or abort?
You get a warning.
diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c
On Wed, May 02, 2012 at 04:01:55PM +0200, Andreas Färber wrote:
Am 02.05.2012 15:50, schrieb Eduardo Habkost:
Anthony, isn't this going to get in for 1.1? I was expecting it to be
applied before the freeze.
You wrote you would respin it with s/int/bool/. :)
I sent an additional patch
On Wed, May 2, 2012 at 2:05 PM, Christophe Fergeau cferg...@redhat.com wrote:
ACK on this one, dunno if we'll want an async variant of this.
Yeah, maybe async variant is needed if this situation doesn't improve
significantly: https://bugzilla.redhat.com/show_bug.cgi?id=817427
--
Regards,
On Wed, May 02, 2012 at 05:17:19PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 1:34 PM, Christophe Fergeau cferg...@redhat.com
wrote:
I'm a bit surprised that here you add a @err annotation, but further down
the patch you rename some @err to @error. Was the renaming an
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am| 11 ++-
...virt-gconfig-capabilities-cpu-feature-private.h | 39
Coverity logs:
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/phyp/phyp_driver.c:523: alloc_fn:
Calling allocation function fopen.
/builddir/build/BUILD/libvirt-0.9.10/src/phyp/phyp_driver.c:523: var_assign:
Assigning: fd = storage returned from fopen(local_file, rb).
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/esx/esx_vi.c:1893: alloc_arg: Calling
allocation function esxVI_ObjectSpec_Alloc on objectSpec.
/builddir/build/BUILD/libvirt-0.9.10/src/esx/esx_vi_types.generated.c:2065:
alloc_arg: esxVI_Alloc allocates memory that is stored into
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/nodeinfo.c:629: alloc_fn: Calling
allocation function fopen.
/builddir/build/BUILD/libvirt-0.9.10/src/nodeinfo.c:629: var_assign: Assigning:
cpuinfo = storage returned from fopen(/proc/cpuinfo, r).
---
src/util/virnetlink.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
index b2e9d51..33db8db 100644
--- a/src/util/virnetlink.c
+++ b/src/util/virnetlink.c
@@ -337,11 +337,13 @@ virNetlinkEventServiceStart(void)
Coverity logs:
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/xen/xen_inotify.c:103: alloc_fn:
Calling allocation function xenDaemonLookupByUUID.
/builddir/build/BUILD/libvirt-0.9.10/src/xen/xend_internal.c:2534: alloc_fn:
Storage is returned from allocation function
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=771021
For more details, please refer to the coverity logs attached
in the BZ.
There is still one error which I don't understand:
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/uml/uml_driver.c:325: alloc_fn:
Calling allocation
A few quick comments, I'll review it more deeply later,
On Tue, May 01, 2012 at 08:30:40PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am| 11 ++-
ping
On Fri, Apr 20, 2012 at 3:13 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
Fixes build on Windows systems
---
configure.ac | 2 ++
tests/Makefile.am | 8 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/test/test_driver.c:1041: alloc_arg:
Calling allocation function virXPathNodeSet on devs.
/builddir/build/BUILD/libvirt-0.9.10/src/util/xml.c:621: alloc_arg: virAllocN
allocates memory that is stored into *list.
On Wed, May 02, 2012 at 10:51:32PM +0800, Osier Yang wrote:
Related coverity log:
Error: FORWARD_NULL:
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:355:
assign_zero: Assigning: params = 0.
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:458:
On Wed, May 02, 2012 at 10:51:37PM +0800, Osier Yang wrote:
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/nodeinfo.c:629: alloc_fn: Calling
allocation function fopen.
/builddir/build/BUILD/libvirt-0.9.10/src/nodeinfo.c:629: var_assign:
Assigning: cpuinfo = storage returned
On Tue, May 01, 2012 at 08:30:38PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-capabilities.c |4 ---
libvirt-gobject/libvirt-gobject-connection.c | 32
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
diff --git a/libvirt-gconfig/libvirt-gconfig.sym
b/libvirt-gconfig/libvirt-gconfig.sym
index ffeb16b..b1df17b 100644
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++
Related coverity log:
Error: FORWARD_NULL:
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:355:
assign_zero: Assigning: params = 0.
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:458:
var_deref_model: Passing null variable params to function
getPyVirTypedParameter,
On Tue, May 01, 2012 at 08:30:40PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
+
+#ifndef __LIBVIRT_GCONFIG_CAPABILITIES_CPU_ARCH_H__
+#define __LIBVIRT_GCONFIG_CAPABILITIES_CPU_ARCH_H__
+
+G_BEGIN_DECLS
+
Error: RESOURCE_LEAK:
/builddir/build/BUILD/libvirt-0.9.10/src/nodeinfo.c:629: alloc_fn: Calling
allocation function fopen.
/builddir/build/BUILD/libvirt-0.9.10/src/nodeinfo.c:629: var_assign: Assigning:
cpuinfo = storage returned from fopen(/proc/cpuinfo, r).
On Wed, May 02, 2012 at 04:57:41PM +0200, Marc-André Lureau wrote:
ping
On Fri, Apr 20, 2012 at 3:13 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
Fixes build on Windows systems
---
configure.ac | 2 ++
tests/Makefile.am | 8 +++-
2 files changed, 9
On 05/01/2012 10:16 AM, Guannan Ren wrote:
refactor qemuPrepareHostdevUSBDevices function, make it focus on
adding usb device to activeUsbHostdevs after check. After that,
the usb hotplug function qemuDomainAttachHostDevice also could use
it.
expand qemuPrepareHostUSBDevices to perform the
On 02.05.2012 13:44, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Allow the logging APIs to be called with a va_list for format
args, instead of requiring var-args usage.
* src/util/logging.h, src/util/logging.c: Add virLogVMessage
---
src/util/logging.c | 29
On 05/02/2012 09:22 AM, Michal Privoznik wrote:
On 02.05.2012 13:44, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Allow the logging APIs to be called with a va_list for format
args, instead of requiring var-args usage.
* src/util/logging.h, src/util/logging.c: Add
On 02.05.2012 13:44, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the server determines whether authentication of clients
is complete, by checking whether an identity is set. This patch
removes that lame hack and replaces it with an explicit method
for
On 02.05.2012 13:44, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
* src/util/threads-pthread.c, src/util/threads.h: Add virThreadCancel
---
src/util/threads-pthread.c |5 +
src/util/threads.h |1 +
2 files changed, 6 insertions(+)
diff
On 02.05.2012 13:44, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add new APIs virNetServerClientGetTLSSession,
virNetServerClientIsLocal, virNetServerClientGetSecurityContext
virNetServerClientGetSASLSession, virNetSocketGetSecurityContext
and
On 05/01/2012 10:16 AM, Guannan Ren wrote:
One usb device could be allowed to hotplug in at a time. If user
give a xml as follows. Probably there are two usb devices avaiable
but with different value of bus, device
we give a error to let user use address to specify the desired one.
On 05/02/2012 05:11 AM, Daniel P. Berrange wrote:
On Tue, May 01, 2012 at 03:10:42PM -0400, Laine Stump wrote:
This patch is one alternative to solve the problem detailed in:
https://bugzilla.redhat.com/show_bug.cgi?id=816465
Some other unidentified library in use by libvirtd (in another
On Tue, May 01, 2012 at 09:50:31AM -0400, William Jon McCann wrote:
+static int migrateProfile(void)
+{
+char *old_base = NULL;
+char *updated = NULL;
+char *home = NULL;
+char *xdg_dir = NULL;
+char *config_dir = NULL;
+int ret = -1;
+mode_t old_umask;
+
+
On Wed, May 02, 2012 at 11:29:36AM -0400, Laine Stump wrote:
On 05/02/2012 05:11 AM, Daniel P. Berrange wrote:
On Tue, May 01, 2012 at 03:10:42PM -0400, Laine Stump wrote:
This patch is one alternative to solve the problem detailed in:
https://bugzilla.redhat.com/show_bug.cgi?id=816465
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
+{
+ g_debug(Init GVirConfigCapabilitiesCPUFeature=%p, conn);
+
+ conn-priv = GVIR_CONFIG_CAPABILITIES_CPU_FEATURE_GET_PRIVATE(conn);
+}
On Wed, May 02, 2012 at 05:22:53PM +0200, Michal Privoznik wrote:
On 02.05.2012 13:44, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
* src/util/threads-pthread.c, src/util/threads.h: Add virThreadCancel
---
src/util/threads-pthread.c |5 +
On Wed, May 2, 2012 at 11:30 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Tue, May 01, 2012 at 09:50:31AM -0400, William Jon McCann wrote:
+static int migrateProfile(void)
+{
+ char *old_base = NULL;
+ char *updated = NULL;
+ char *home = NULL;
+ char *xdg_dir = NULL;
+
On Mon, Apr 30, 2012 at 12:56:05PM -0600, Eric Blake wrote:
On 04/30/2012 12:43 PM, Jason Helfman wrote:
Ok, but having the same download path is just as confusing, as it looks
like
an update to 0.9.11, when it is a different release.
But for all intents and purposes, it IS an update to
On Wed, May 02, 2012 at 06:35:07PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Having a per-feature GVirConfigObject seems overkill since it will
only be a string wrapper, and a GVirConfigObject wrapping just a string
On Wed, May 2, 2012 at 5:55 PM, Christophe Fergeau cferg...@redhat.com wrote:
+
+const gchar *
+gvir_config_capabilities_domain_get_emulator(GVirConfigCapabilitiesDomain
*caps)
Is this method just a copy and paste bug, or is it needed? The reason I'm
asking is that I cannot see the
On 05/01/2012 03:27 AM, Eric Blake wrote:
On 04/20/2012 10:01 AM, Dmitry Guryanov wrote:
Add driver, which can report node info only.
.
+++ b/src/pvs/pvs_driver.c
@@ -0,0 +1,271 @@
+/*
+ * pvs_driver.c: core driver functions for managing
+ * Parallels Virtuozzo Server hosts
+ *
+ *
More files will be added to the list, with additional attributes, later.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 152cbbb..62332e9 100644
On 05/02/2012 09:59 AM, Dmitry Guryanov wrote:
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA
Not a problem with your
Not needed anymore, as the code that uses the variable is already inside
arch_init.c.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c |3 +--
arch_init.h |2 --
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index
Changes v1 - v2:
- Actually change the variable type declaration to 'bool'
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 1e5e593..eb3e088 100644
--- a/vl.c
+++ b/vl.c
@@ -2279,7 +2279,7
Changes v2 - v3:
- Actually change 'defconfig' type declaration to bool
- Rebase against latest qemu.git (commit
563987d0a799f90b58a575b190a57546c335191b)
Changes v1 - v2:
- Move qemu_read_default_config_files() prototype to qemu-config.h
- Make defconfig and userconfig variable bool
-
Changes v2 - v3:
- Rebase against latest qemu.git
Changes v1 - v2:
- Change 'userconfig' field/variables to bool instead of int
- Coding style change
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 11 ---
qemu-config.h |2 +-
qemu-options.hx | 16
Changes v1 - v2:
- userconfig variable is now bool, not int
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile | 12 +++-
arch_init.c |1 +
sysconfigs/target/cpus-x86_64.conf | 128 ++
Function added to arch_init.c because it depends on arch-specific
settings.
Changes v1 - v2:
- Move qemu_read_default_config_file() prototype to qemu-config.h
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 18 ++
qemu-config.h |4
vl.c
On 05/02/2012 10:05 AM, Eric Blake wrote:
On 05/02/2012 09:59 AM, Dmitry Guryanov wrote:
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
On 2012年05月01日 16:16, Guannan Ren wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=815755
The set of patch tries to fix the issue when multiple usb devices with
same idVendor, idProduct are availible on host, the usb device with
lowest bus:device will be attached to guest if usb xml file is
On 2012年05月03日 00:35, Eric Blake wrote:
On 05/02/2012 10:26 AM, Osier Yang wrote:
The error could be more clear, e.g.
multiple USB deivces for vendor='15e1',
product='2007', useaddress to specify one.
And it's not XML error, the XML is just fine. The XML with
only 'vendor' and 'product'
On 05/02/2012 10:26 AM, Osier Yang wrote:
The error could be more clear, e.g.
multiple USB deivces for vendor='15e1',
product='2007', use address to specify one.
And it's not XML error, the XML is just fine. The XML with
only 'vendor' and 'product' specified could still work well
if no
Il 01/05/2012 22:56, Eric Blake ha scritto:
What sort
of timing restrictions are there? For example, the proposed
'drive-reopen' command (probably now delegated to qemu 1.2) would mean
that qemu would be calling back into libvirt in order to do the reopen.
If libvirt takes its time in
On 05/01/2012 02:16 AM, Guannan Ren wrote:
usbFindDevice():get usb device according to
idVendor, idProduct, bus, device
it is the most strict search
usbFindDevByBus():get usb device according to bus, device
it returns only one usb device
On 2012年05月01日 16:16, Guannan Ren wrote:
usbFindDevice():get usb device according to
idVendor, idProduct, bus, device
it is the most strict search
usbFindDevByBus():get usb device according to bus, device
Should we name it as usbFindDevByAddress? Given that
On 05/01/2012 02:16 AM, Guannan Ren wrote:
One usb device could be allowed to hotplug in at a time. If user
give a xml as follows. Probably there are two usb devices avaiable
s/avaiable/available/
but with different value of bus, device
we give a error to let user use address to specify
On 05/01/2012 02:16 AM, Guannan Ren wrote:
refactor qemuPrepareHostdevUSBDevices function, make it focus on
adding usb device to activeUsbHostdevs after check. After that,
the usb hotplug function qemuDomainAttachHostDevice also could use
it.
expand qemuPrepareHostUSBDevices to perform the
Hi,
On Wed, May 2, 2012 at 6:26 AM, Christophe Fergeau cferg...@redhat.com wrote:
Hey,
On Mon, Apr 30, 2012 at 02:55:06PM -0400, William Jon McCann wrote:
This has a number of advantages for us:
It allows sharing a home directory between different machines, or
sessions (eg. using NFS)
On 2012年05月01日 16:16, Guannan Ren wrote:
refactor qemuPrepareHostdevUSBDevices function, make it focus on
adding usb device to activeUsbHostdevs after check. After that,
the usb hotplug function qemuDomainAttachHostDevice also could use
it.
expand qemuPrepareHostUSBDevices to perform the usb
As defined in:
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
This offers a number of advantages:
* Allows sharing a home directory between different machines, or
sessions (eg. using NFS)
* Cleanly separates cache, runtime (eg. sockets), or app data from
user settings
*
---
docs/apps.html.in |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 29bebbd..10ea6bf 100644
--- a/docs/apps.html.in
+++ b/docs/apps.html.in
@@ -219,6 +219,14 @@
community. It uses libvirt for communication
On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Wed, May 02, 2012 at 06:35:07PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Having a per-feature GVirConfigObject seems overkill since it
On 05/02/2012 11:53 AM, William Jon McCann wrote:
As defined in:
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
If I'm not mistaken, this is v3? When using git send-mail, you can use
--subject-prefix=PATCHv3 to make it more obvious to reviewers.
This offers a number
On 2012年05月03日 02:06, Osier Yang wrote:
On 2012年05月01日 16:16, Guannan Ren wrote:
One usb device could be allowed to hotplug in at a time. If user
give a xml as follows.
s/give/gives/
Probably there are two usb devices avaiable
s/avaiable/available/
but with different value of bus, device
On Wed, May 02, 2012 at 07:53:41PM +0200, Eugen Feller wrote:
---
docs/apps.html.in |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 29bebbd..10ea6bf 100644
--- a/docs/apps.html.in
+++ b/docs/apps.html.in
@@
On 05/02/2012 09:05 AM, Osier Yang wrote:
Related coverity log:
Error: FORWARD_NULL:
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:355:
assign_zero: Assigning: params = 0.
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:458:
var_deref_model: Passing null
On 2012年05月01日 16:16, Guannan Ren wrote:
One usb device could be allowed to hotplug in at a time. If user
give a xml as follows.
s/give/gives/
Probably there are two usb devices avaiable
s/avaiable/available/
but with different value of bus, device
we give a error to let user useaddress
On Wed, May 2, 2012 at 9:02 PM, Eric Blake ebl...@redhat.com wrote:
On 05/02/2012 11:53 AM, William Jon McCann wrote:
As defined in:
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
If I'm not mistaken, this is v3? When using git send-mail, you can use
1 - 100 of 130 matches
Mail list logo