Re: [libvirt] [PATCH 1/1] Assign spapr-vio address value to VIO devices without hardcode

2012-05-18 Thread Li Zhang
On 05/18/2012 06:41 AM, Eric Blake wrote: On 05/17/2012 12:16 AM, Li Zhang wrote: Hardcode address will cause conflicts when there are a lot of VIO devices. This patch is to remove the harcode of the address, and assign a variable to it, which is cnt * 0x1000UL. And assign spapr-vio address to

Re: [libvirt] Report of tsan first testing with libvirt(d)

2012-05-18 Thread Daniel P. Berrange
On Fri, May 18, 2012 at 11:55:05AM +0800, Daniel Veillard wrote: One of the ouput raised frequently is: -- ==5838== WARNING: Possible data race during write of size 4 at 0x34723B3BD0: {{{ ==5838==T1 (L{L17, L125}):

Re: [libvirt] [PATCHv5 0/2] support vcpu_time in qemu

2012-05-18 Thread Hu Tao
On Thu, May 17, 2012 at 03:56:46PM -0600, Eric Blake wrote: This is my enhancements to Hu's series. If it still works for his testing, then I'm ready to push it. Thanks Eric. v5 works here. But I don't have a cpu-hotplug/hotunplug environment, so this case is not tested. I also think we

Re: [libvirt] [PATCHv5 2/2] Adds support to param 'vcpu_time' in qemu_driver.

2012-05-18 Thread Hu Tao
On Thu, May 17, 2012 at 03:56:48PM -0600, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com This involves setting the cpuacct cgroup to a per-vcpu granularity, as well as summing the each vcpu accounting into a common array. Now that we are reading more than one cgroup file, we

Re: [libvirt] [PATCHv5 1/2] Add a new param 'vcpu_time' to virDomainGetCPUStats

2012-05-18 Thread Hu Tao
On Thu, May 17, 2012 at 03:56:47PM -0600, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Currently virDomainGetCPUStats gets total cpu usage, which consists of: 1. vcpu usage: the physical cpu time consumed by virtual cpu(s) of domain 2. hypervisor: `total cpu usage' -

Re: [libvirt] [Qemu-devel] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-18 Thread Stefan Hajnoczi
On Thu, May 17, 2012 at 08:14:15AM -0600, Eric Blake wrote: On 05/17/2012 07:42 AM, Stefan Hajnoczi wrote: The -open-hook-fd approach allows QEMU to support file descriptor passing without changing -drive. It also supports snapshot_blkdev and other commands By the way, How will it

Re: [libvirt] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-18 Thread Stefan Hajnoczi
On Thu, May 17, 2012 at 10:02:01PM +0800, Zhi Yong Wu wrote: On Thu, May 17, 2012 at 9:42 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Fri, May 04, 2012 at 11:28:47AM +0800, Zhi Yong Wu wrote: On Tue, May 1, 2012 at 11:31 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote:

Re: [libvirt] Report of tsan first testing with libvirt(d)

2012-05-18 Thread Daniel Veillard
On Fri, May 18, 2012 at 09:16:20AM +0100, Daniel P. Berrange wrote: On Fri, May 18, 2012 at 11:55:05AM +0800, Daniel Veillard wrote: [...] The other one raised is actually something I had initially found with the first run on libxml2 so it's relatively consistent: Yay libxml2 is not

Re: [libvirt] Report of tsan first testing with libvirt(d)

2012-05-18 Thread Daniel P. Berrange
On Fri, May 18, 2012 at 06:40:06PM +0800, Daniel Veillard wrote: On Fri, May 18, 2012 at 09:16:20AM +0100, Daniel P. Berrange wrote: On Fri, May 18, 2012 at 11:55:05AM +0800, Daniel Veillard wrote: [...] The other one raised is actually something I had initially found with the first

Re: [libvirt] How to use a Virtio-serial port

2012-05-18 Thread Pankaj Rawat
Hi, Can Anyone please tell me if there is any option in virt-install by which we can specify this vitio-serial port I mean I don't want to edit xml file and then define it as it is a post installation process. I want to enable the virtio-serial port when I install the guest using virt-install

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-18 Thread Pankaj Rawat
Hi, Can Anyone please tell me if there is any option in virt-install by which we can specify this many consoles I mean I don’t want to edit xml file and then define it as it is a post installation process. I want to enable the multiple console port when I install the guest using virt-install

Re: [libvirt] How to use a Virtio-serial port

2012-05-18 Thread Michal Privoznik
On 18.05.2012 12:56, Pankaj Rawat wrote: Hi, Can Anyone please tell me if there is any option in virt-install by which we can specify this vitio-serial port I mean I don't want to edit xml file and then define it as it is a post installation process. I want to enable the virtio-serial

[libvirt] [PATCH 0/2] Make virsh *edit more bearable

2012-05-18 Thread Michal Privoznik
If there's an error in XML, all changes made by user are lost. Users (read /me) tends to get angry with this. Allow them to get back and re-edit. Michal Privoznik (2): virsh: Switch from generated cmd*Edit commands to nongenerated virsh: Allow users to reedit rejected XML cfg.mk

[libvirt] [PATCH 1/2] virsh: Switch from generated cmd*Edit commands to nongenerated

2012-05-18 Thread Michal Privoznik
Currently, we either generate some cmd*Edit commands (cmdPoolEdit and cmdNetworkEdit) via sed script or copy the body of cmdEdit (e.g. cmdInterfaceEdit, cmdNWFilterEdit, etc.). This fact makes it harder to implement any new feature to our editing system. Therefore switch to new implementation -

[libvirt] [PATCH 2/2] virsh: Allow users to reedit rejected XML

2012-05-18 Thread Michal Privoznik
If users *-edit but make a mistake in XML all changes are permanently lost. However, if virsh is not running within a script we can as user if he wants to re-edit the file and correct the mistakes. --- tools/console.c| 40 +--- tools/console.h|2

Re: [libvirt] [PATCHv5 2/2] Adds support to param 'vcpu_time' in qemu_driver.

2012-05-18 Thread Eric Blake
On 05/18/2012 03:09 AM, Hu Tao wrote: On Thu, May 17, 2012 at 03:56:48PM -0600, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com This involves setting the cpuacct cgroup to a per-vcpu granularity, as well as summing the each vcpu accounting into a common array. Now that we are reading

[libvirt] [PATCH] build: fix virnetlink on glibc 2.11

2012-05-18 Thread Eric Blake
We were being lazy - virnetlink.c was getting uint32_t as a side-effect from glibc 2.14's unistd.h, but older glibc 2.11 does not provide uint32_t from unistd.h. In fact, POSIX states that unistd.h need only provide intptr_t, not all of stdint.h, so the bug really is ours. Reported by Jonathan

Re: [libvirt] [PATCH 1/2] virsh: Switch from generated cmd*Edit commands to nongenerated

2012-05-18 Thread Eric Blake
On 05/18/2012 06:48 AM, Michal Privoznik wrote: Currently, we either generate some cmd*Edit commands (cmdPoolEdit and cmdNetworkEdit) via sed script or copy the body of cmdEdit (e.g. cmdInterfaceEdit, cmdNWFilterEdit, etc.). This fact makes it harder to implement any new feature to our editing

Re: [libvirt] [PATCH 2/2] virsh: Allow users to reedit rejected XML

2012-05-18 Thread Eric Blake
On 05/18/2012 06:48 AM, Michal Privoznik wrote: If users *-edit but make a mistake in XML all changes are permanently lost. However, if virsh is not running within a script we can as user if he wants to re-edit the file s/as/ask/ and correct the mistakes. --- tools/console.c| 40

Re: [libvirt] [PATCH 1/2] virsh: Switch from generated cmd*Edit commands to nongenerated

2012-05-18 Thread Eric Blake
On 05/18/2012 06:48 AM, Michal Privoznik wrote: Currently, we either generate some cmd*Edit commands (cmdPoolEdit and cmdNetworkEdit) via sed script or copy the body of cmdEdit (e.g. cmdInterfaceEdit, cmdNWFilterEdit, etc.). This fact makes it harder to implement any new feature to our editing

Re: [libvirt] [PATCH libvirt] storage: add preallocation element

2012-05-18 Thread Eric Blake
On 05/17/2012 04:59 PM, Marc-André Lureau wrote: On Fri, May 18, 2012 at 12:13 AM, Eric Blake ebl...@redhat.com wrote: Meta-question - is pre-allocation something that is persistent with the existence of the storage volume, or is it something that is one-shot at the creation of the volume?

Re: [libvirt] [PATCH V4] nwfilter: Add support for ipset

2012-05-18 Thread Eric Blake
On 05/14/2012 07:00 PM, Stefan Berger wrote: This patch adds support for the recent ipset iptables extension to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' of IP addresses, ports and other packet parameters and allows for faster lookup (in the order of O(1) vs. O(n)) and rule

[libvirt] [PATCH] virBuffer: add way to trim back extra text

2012-05-18 Thread Eric Blake
I'm tired of writing: bool sep = false; while (...) { if (sep) virBufferAddChar(buf, ','); sep = true; virBufferAdd(buf, str); } This makes it easier, allowing one to write: while (...) virBufferAsprintf(buf, %s,, str); virBufferTrim(buf, ,, -1); to trim any remaining

[libvirt] RFE: virConnectListAllDomains()

2012-05-18 Thread Eric Blake
Use of virConnectListDomains() and virConnectListDefinedDomains() is: 1. inherently racy. A domain can change between active and inactive between two back-to-back calls, and thus be entirely skipped or enumerated twice when concatenating lists. 2. painful to use. ListDomains gives ids,

[libvirt] [libvirt-glib] Add getter for GVirConfigDomainOS.arch

2012-05-18 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-os.c |7 +++ libvirt-gconfig/libvirt-gconfig-domain-os.h |1 + libvirt-gconfig/libvirt-gconfig.sym |1 + 3 files changed, 9 insertions(+), 0 deletions(-) diff --git