[libvirt] [PATCH] lxc: return correct number of CPUs

2012-05-29 Thread Martin Kletzander
When getting number of CPUs the host has assigned, there was always number 1 returned. Even though all lxc domains with no pinning launched by libvirt run on all pCPUs (by default, no matter what's the number), we should at least return the same number as the user specified when creating the

[libvirt] [PATCH 1/1] Assign correct address type to spapr-vlan and spapr-vty.

2012-05-29 Thread Li Zhang
For pseires guest, spapr-vlan and spapr-vty is based on spapr-vio address. According to model of network device, the address type should be assigned automatically. For serial device, serial pty device is recognized as spapr-vty device, which is also on spapr-vio. So this patch is to correct the

Re: [libvirt] Error when running virsh version and virt-manager

2012-05-29 Thread Shradha Shah
The output of virsh capabilities is: [root@c6100o bin]# virsh capabilities capabilities host uuid44454c4c-3500-1058-8030-b4c04f33354a/uuid cpu archx86_64/arch modelWestmere/model vendorIntel/vendor topology sockets='1' cores='4' threads='2'/ feature

Re: [libvirt] Error when running virsh version and virt-manager

2012-05-29 Thread Osier Yang
On 2012年05月29日 18:09, Shradha Shah wrote: The output of virsh capabilities is: [root@c6100o bin]# virsh capabilities capabilities host uuid44454c4c-3500-1058-8030-b4c04f33354a/uuid cpu archx86_64/arch modelWestmere/model vendorIntel/vendor topology

Re: [libvirt] [PATCH V14 1/5] Introduce virMacAddr typedef

2012-05-29 Thread Stefan Berger
On 05/25/2012 10:43 PM, Eric Blake wrote: On 05/25/2012 05:56 AM, Stefan Berger wrote: --- src/util/virmacaddr.h |2 ++ 1 file changed, 2 insertions(+) Index: libvirt/src/util/virmacaddr.h === ---

Re: [libvirt] [PATCH] Fix memory leak

2012-05-29 Thread Stefan Berger
On 05/29/2012 12:04 AM, Osier Yang wrote: On 2012年05月29日 06:18, Stefan Berger wrote: Fix the following memory leak: ==3240== 23 bytes in 1 blocks are definitely lost in loss record 242 of 744 ==3240== at 0x4C2A4CD: malloc (vg_replace_malloc.c:236) ==3240== by 0x8077537: __vasprintf_chk

Re: [libvirt] serial console/events example script

2012-05-29 Thread Dave Allan
On Fri, May 25, 2012 at 08:34:20PM -0600, Eric Blake wrote: On 03/29/2012 03:57 PM, Daniel P. Berrange wrote: On Thu, Mar 29, 2012 at 04:55:39PM -0400, Dave Allan wrote: On Wed, Feb 15, 2012 at 09:11:32PM -0500, Dave Allan wrote: Hi all, A while back I wrote the attached code to

[libvirt] [PATCH] build: silence warning from autoconf

2012-05-29 Thread Eric Blake
Autoconf 2.60 and later insist on using ${datarootdir}, rather than the derived ${datadir} (although the latter defaults to the former, it is possible to set configure arguments so that they differ): config.status: creating libvirt.pc config.status: WARNING: 'libvirt.pc.in' seems to ignore the

[libvirt] [PATCH] virsh: avoid strncpy

2012-05-29 Thread Eric Blake
strncpy is generally evil - it runs the risk of missing NUL termination, and more often than not wastes time zeroing way more bytes than strictly necessary. We've avoided this evil in our virStrncpy wrapper, except for places where we forgot to use the wrapper; meanwhile, we have also added an

Re: [libvirt] [PATCH] build: work around mingw isatty issues

2012-05-29 Thread Eric Blake
On 05/28/2012 02:36 AM, Daniel P. Berrange wrote: On Fri, May 25, 2012 at 10:03:28PM -0600, Eric Blake wrote: On 05/07/2012 04:24 PM, Eric Blake wrote: Gnulib finally relaxed the isatty license, needed as first mentioned here:

Re: [libvirt] [PATCH] virsh: avoid strncpy

2012-05-29 Thread Michal Privoznik
On 29.05.2012 16:36, Eric Blake wrote: strncpy is generally evil - it runs the risk of missing NUL termination, and more often than not wastes time zeroing way more bytes than strictly necessary. We've avoided this evil in our virStrncpy wrapper, except for places where we forgot to use the

Re: [libvirt] [PATCH] virsh: avoid strncpy

2012-05-29 Thread Eric Blake
On 05/29/2012 08:54 AM, Michal Privoznik wrote: On 29.05.2012 16:36, Eric Blake wrote: strncpy is generally evil - it runs the risk of missing NUL termination, and more often than not wastes time zeroing way more bytes than strictly necessary. We've avoided this evil in our virStrncpy

Re: [libvirt] [PATCH] lxc: return correct number of CPUs

2012-05-29 Thread Eric Blake
On 05/29/2012 01:12 AM, Martin Kletzander wrote: When getting number of CPUs the host has assigned, there was always number 1 returned. Even though all lxc domains with no pinning launched by libvirt run on all pCPUs (by default, no matter what's the number), we should at least return the same

Re: [libvirt] Compiling Error

2012-05-29 Thread Eric Blake
On 05/28/2012 11:36 AM, Dipankar Sarma wrote: On Mon, May 28, 2012 at 11:13:23AM +0100, Daniel P. Berrange wrote: On Mon, May 28, 2012 at 02:24:16AM -0400, Alex Jia wrote: Hi all, I met some compiling error since May 26: snip make[3]: Entering directory `/home/ajia/Workspace/libvirt/src'

Re: [libvirt] Compiling Error

2012-05-29 Thread Eric Blake
On 05/28/2012 08:43 PM, Alex Jia wrote: I met some compiling error since May 26: snip make[3]: Entering directory `/home/ajia/Workspace/libvirt/src' CCLD libvirt_driver_qemu.la libtool: link: `libvirt_qemu_probes.lo' is not a valid libtool object I see that too 'make' still can't work

[libvirt] [PATCH] build: fix testing of augeas files in VPATH builds

2012-05-29 Thread Eric Blake
Without this fix, a VPATH build fails with messages like: make[3]: Entering directory `/home/remote/eblake/libvirt-tmp2/build/daemon' ../../build-aux/augeas-gentest.pl libvirtd.conf ../../daemon/test_libvirtd.aug.in test_libvirtd.aug cannot read libvirtd.conf: No such file or directory at

Re: [libvirt] [PATCH] build: fix testing of augeas files in VPATH builds

2012-05-29 Thread Eric Blake
On 05/29/2012 01:28 PM, Eric Blake wrote: Without this fix, a VPATH build fails with messages like: make[3]: Entering directory `/home/remote/eblake/libvirt-tmp2/build/daemon' ../../build-aux/augeas-gentest.pl libvirtd.conf ../../daemon/test_libvirtd.aug.in test_libvirtd.aug cannot read

Re: [libvirt] Compiling Error

2012-05-29 Thread Eric Blake
On 05/29/2012 12:51 PM, Eric Blake wrote: Found it, and I'm pushing this under the build-breaker rule. It's always fun when _deleting_ lines from Makefile.am results in _adding_ lines to Makefile to fix the bug. From 8a115526e6f64f1ffb2fbff6e29c845f68f66510 Mon Sep 17 00:00:00 2001

[libvirt] [PATCH] build: don't lose probes.o files

2012-05-29 Thread Eric Blake
The previous patch fixed an incremental build, but missed that on a fresh checkout, we now have nothing requiring that stops make from nuking libvirt_qemu_probes.o. * src/Makefile.am ($(libvirt_driver_qemu_la_SOURCES)): Delete, since this variable is empty. (.PRECIOUS): Add %_probes.o, so they

[libvirt] Website sidebar not consistent between libvirt.org and wiki.libvirt.org

2012-05-29 Thread Cole Robinson
The sidebar here looks right: http://libvirt.org/ But the sidebar here seems pretty out of date: http://wiki.libvirt.org/ Including missing options, and the FAQ link pointing to the old FAQ.html file which shouldn't exist anymore. Any one know how to fix? Thanks, Cole -- libvir-list mailing

[libvirt] [PATCH2 2/1] build: fix testing of augeas files in VPATH builds

2012-05-29 Thread Eric Blake
Without this fix, a VPATH build (such as used by ./autobuild.sh) fails with messages like: make[3]: Entering directory `/home/remote/eblake/libvirt-tmp2/build/daemon' ../../build-aux/augeas-gentest.pl libvirtd.conf ../../daemon/test_libvirtd.aug.in test_libvirtd.aug cannot read libvirtd.conf: No

[libvirt] [PATCH 3/1] build: use same perl binary throughout build

2012-05-29 Thread Eric Blake
Some of our rules used $(PERL), while others used 'perl'. Always using the variable allows a developer to point to a different (often better) perl than the default one found on $PATH. * daemon/Makefile.am ($(srcdir)/remote_dispatch.h): s/perl/$(PERL). * src/Makefile.am

Re: [libvirt] [PATCH 3/1] build: use same perl binary throughout build

2012-05-29 Thread Eric Blake
On 05/29/2012 04:03 PM, Eric Blake wrote: Some of our rules used $(PERL), while others used 'perl'. Always using the variable allows a developer to point to a different (often better) perl than the default one found on $PATH. * daemon/Makefile.am ($(srcdir)/remote_dispatch.h):

Re: [libvirt] serial console/events example script

2012-05-29 Thread Eric Blake
On 05/29/2012 07:30 AM, Dave Allan wrote: A while back I wrote the attached code to demonstrate how to use events and serial console to create a serial console that stays up even when the VM is down. Is it worth adding to the examples? It might need some work, as I am not terribly strong

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-05-29 Thread Cole Robinson
On 05/03/2012 10:05 PM, Li Zhang wrote: Now, there is only SCSI bus and controller type in libvirt. And when configuring VSCSI controller, it needs to configure the spapr-vio bus address type externally. It's a little inconvenient to configure the controller type. This patch is to add VSCSI

[libvirt] [PATCH] command: avoid double close bugs

2012-05-29 Thread Eric Blake
KAMEZAWA Hiroyuki reported a nasty double-free bug when virCommand is used to convert a string into input to a child command. The problem is that the poll() loop of virCommandProcessIO would close() the write end of the pipe in order to let the child see EOF, then the caller virCommandRun() would

[libvirt] [PATCH] build: include augeas-gentest.pl and libvirt_qemu_probes.h into dist file

2012-05-29 Thread Wen Congyang
We generate *.aug from *.aug.in by augeas-gentest.pl, so this script should be included in dist file. We split QEMU dtrace probes into separate file, but we forget include libvirt_qemu_probes.h into dist file. --- src/Makefile.am |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH] build: include augeas-gentest.pl and libvirt_qemu_probes.h into dist file

2012-05-29 Thread Eric Blake
On 05/29/2012 08:15 PM, Wen Congyang wrote: We generate *.aug from *.aug.in by augeas-gentest.pl, so this script should be included in dist file. We split QEMU dtrace probes into separate file, but we forget include libvirt_qemu_probes.h into dist file. --- src/Makefile.am |4 +++-

Re: [libvirt] [PATCH] command: avoid double close bugs

2012-05-29 Thread Wen Congyang
At 05/30/2012 09:20 AM, Eric Blake Wrote: KAMEZAWA Hiroyuki reported a nasty double-free bug when virCommand is used to convert a string into input to a child command. The problem is that the poll() loop of virCommandProcessIO would close() the write end of the pipe in order to let the child