Re: [libvirt] question about save/restore domain

2012-07-03 Thread Eric Blake
On 07/03/2012 02:44 PM, Zeeshan Ali (Khattak) wrote: > Yeah, this feature is about cloning the VM but using a single file > that has everything about the domain: disk, ram and the config. Unfortunately, there is no single-file format that represents the state of a qemu domain; it really is the co

Re: [libvirt] [PATCH 1/3] esx: Wrap libcurl multi handle

2012-07-03 Thread Doug Goldstein
On Tue, Jul 3, 2012 at 3:17 PM, Matthias Bolte wrote: > 2012/7/3 Doug Goldstein : >> On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte >> wrote: >>> --- >>>  src/esx/esx_vi.c |  111 >>> ++ >>>  src/esx/esx_vi.h |   18 + >>>  2 files change

Re: [libvirt] [PATCH 0/3] esx: Storage volume up- and download

2012-07-03 Thread Matthias Bolte
2012/7/3 Daniel P. Berrange : > On Tue, Jul 03, 2012 at 09:51:52PM +0200, Matthias Bolte wrote: >> 2012/7/3 Doug Goldstein : >> > On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte >> > wrote: >> >> I started the download part and the stream driver quite a while ago >> >> but stopped and put it aside

Re: [libvirt] question about save/restore domain

2012-07-03 Thread Zeeshan Ali (Khattak)
On Tue, Jul 3, 2012 at 9:18 PM, Eric Blake wrote: > On 07/03/2012 11:35 AM, Jovanka Gulicoska wrote: >> On Tue, Jul 3, 2012 at 6:01 PM, Eric Blake wrote: >>> >>> On 07/03/2012 06:42 AM, Jovanka Gulicoska wrote: Hi, my name is Jovanka Gulicoska and I'm SoC student. I'm working on >>

Re: [libvirt] [PATCH 0/3] esx: Storage volume up- and download

2012-07-03 Thread Daniel P. Berrange
On Tue, Jul 03, 2012 at 09:51:52PM +0200, Matthias Bolte wrote: > 2012/7/3 Doug Goldstein : > > On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte > > wrote: > >> I started the download part and the stream driver quite a while ago > >> but stopped and put it aside as I realized that the storage volume

Re: [libvirt] [PATCH 2/3] esx: Extend esxVI_CURL_Download for partial downloads

2012-07-03 Thread Matthias Bolte
2012/7/3 Doug Goldstein : > On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte > wrote: >> --- >> src/esx/esx_driver.c |2 +- >> src/esx/esx_vi.c | 27 +-- >> src/esx/esx_vi.h |3 ++- >> 3 files changed, 28 insertions(+), 4 deletions(-) >> >> diff --git a/src

Re: [libvirt] [PATCH 1/3] esx: Wrap libcurl multi handle

2012-07-03 Thread Matthias Bolte
2012/7/3 Doug Goldstein : > On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte > wrote: >> --- >> src/esx/esx_vi.c | 111 >> ++ >> src/esx/esx_vi.h | 18 + >> 2 files changed, 129 insertions(+), 0 deletions(-) >> +/* esxVI_MultiCURL_All

Re: [libvirt] [PATCH 0/3] esx: Storage volume up- and download

2012-07-03 Thread Matthias Bolte
2012/7/3 Doug Goldstein : > On Mon, Jul 2, 2012 at 4:44 PM, Matthias Bolte > wrote: >> I started the download part and the stream driver quite a while ago >> but stopped and put it aside as I realized that the storage volume >> API up- and download functions assume one file per volume. This is a >

Re: [libvirt] Release of libvirt-0.9.13

2012-07-03 Thread Jason Helfman
On Mon, Jul 02, 2012 at 01:10:23PM +0800, Daniel Veillard thus spake: Okay the new release is out and available as uauls at ftp://libvirt.org/libvirt/ I've just committed this update for FreeBSD, as well. Thanks for everyone's hard work! -jgh -- Jason Helfman System Administrator expe

Re: [libvirt] question about save/restore domain

2012-07-03 Thread Eric Blake
On 07/03/2012 11:35 AM, Jovanka Gulicoska wrote: > On Tue, Jul 3, 2012 at 6:01 PM, Eric Blake wrote: >> >> On 07/03/2012 06:42 AM, Jovanka Gulicoska wrote: >>> Hi, >>> >>> my name is Jovanka Gulicoska and I'm SoC student. I'm working on >>> implementing save/load of VM in Gnome-Boxes. >>> Somethin

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I think adding a +1 to the refcount for the monitor makes sense. I'm a bit unsure how to increment the refcount when a monitor reconnects though. Maybe it is as simple as adding a +1 to each fd's ref

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Eric Blake
On 07/03/2012 11:46 AM, Corey Bryant wrote: > > Yes, I think adding a +1 to the refcount for the monitor makes sense. > > I'm a bit unsure how to increment the refcount when a monitor reconnects > though. Maybe it is as simple as adding a +1 to each fd's refcount when > the next QMP monitor con

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/03/2012 01:03 PM, Eric Blake wrote: On 07/03/2012 10:25 AM, Corey Bryant wrote: I thought qemu would rather return the number of the fdset (which it also assigns if none it passed, i.e. for fdset creation). Does libvirt need the number of an individual fd? If libvirt prefers to assign

Re: [libvirt] question about save/restore domain

2012-07-03 Thread Jovanka Gulicoska
On Tue, Jul 3, 2012 at 6:01 PM, Eric Blake wrote: > > On 07/03/2012 06:42 AM, Jovanka Gulicoska wrote: > > Hi, > > > > my name is Jovanka Gulicoska and I'm SoC student. I'm working on > > implementing save/load of VM in Gnome-Boxes. > > Something confused me about snapshots. In the documentation a

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Eric Blake
On 07/03/2012 10:25 AM, Corey Bryant wrote: >> I thought qemu would rather return the number of the fdset (which it >> also assigns if none it passed, i.e. for fdset creation). Does libvirt >> need the number of an individual fd? >> >> If libvirt prefers to assign fdset numbers itself, I'm not aga

Re: [libvirt] [PATCHv3 0/5] Virtio support for S390

2012-07-03 Thread Michal Privoznik
On 29.06.2012 17:02, Viktor Mihajlovski wrote: > As 0.9.13 is stabilizing and I will not be available next week > I am sending this reworked patch set already today, looking forward > to comments. > > This series adds support for the s390 flavor of virtio devices. > Since the s390 virtio devices a

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/03/2012 11:59 AM, Kevin Wolf wrote: Am 03.07.2012 17:40, schrieb Corey Bryant: Thanks again for taking time to discuss this at today's QEMU community call. Here's the proposal we discussed at the call. Please let me know if I missed anything or if there are any issues with this design.

Re: [libvirt] [PATCHv3 5/5] S390: Adding testcases for s390

2012-07-03 Thread Michal Privoznik
On 29.06.2012 17:02, Viktor Mihajlovski wrote: > Add minimal s390-virtio domain testcase and testcases for virtio serial, > net, disk for the virtio-s390 bus. > > Signed-off-by: Viktor Mihajlovski > --- > .../qemuxml2argv-console-virtio-s390.args |9 ++ > .../qemuxml2argv-consol

Re: [libvirt] [PATCHv3 2/5] qemu: Change tests to use (modified) qemuDomainAssignAddresses

2012-07-03 Thread Michal Privoznik
On 29.06.2012 17:02, Viktor Mihajlovski wrote: > Rewrote the device assignment parts in tests to use qemuDomainAssignAddresses. > This way the tests will work for new device address types as they show > up in the future (like s390 device types). > > Signed-off-by: Viktor Mihajlovski > --- > test

Re: [libvirt] [PATCHv3 1/5] qemu: Extended qemuDomainAssignAddresses to be callable from everywhere.

2012-07-03 Thread Michal Privoznik
On 29.06.2012 17:02, Viktor Mihajlovski wrote: > This is in preparation of the enablement of s390 guests with virtio devices. > > The assignment of device addresses happens in different places, i.e. the > qemu driver and process modules as well as in the unit tests in slightly > different flavors.

Re: [libvirt] [PATCHv3 4/5] S390: Domain Schema for s390-virtio machines.

2012-07-03 Thread Michal Privoznik
On 29.06.2012 17:02, Viktor Mihajlovski wrote: > Added s390-virtio machine type to the XML schema for domains in order > to not fail the domain schema tests. > > Signed-off-by: Viktor Mihajlovski > --- > docs/schemas/domaincommon.rng | 20 > 1 files changed, 20 insertions(

Re: [libvirt] [PATCHv3 3/5] S390: Add support for virtio-s390 devices.

2012-07-03 Thread Michal Privoznik
On 29.06.2012 17:02, Viktor Mihajlovski wrote: > The s390(x) architecture doesn't feature a PCI bus. For the purpose of > supporting virtio devices a virtual bus called virtio-s390 is used. > A new address type VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390 is used to > distinguish the virtio devices o

Re: [libvirt] [Patch v2 3/3] apparmor: QEMU bridge helper policy updates

2012-07-03 Thread rmarwah
Quoting Jamie Strandboge : On Fri, 2012-06-29 at 14:08 -0400, rmar...@linux.vnet.ibm.com wrote: From: Richa Marwaha This patch provides AppArmor policy updates for the QEMU bridge helper. The QEMU bridge helper is a SUID executable exec'd by QEMU that drops capabilities to CAP_NET_ADMIN and

[libvirt] [PATCH 01/15] Add a opaque parameter to the RPC client init callback

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The callback that is invoked when a new RPC client is initialized does not have any opaque parameter. Add one so that custom data can be passed into the callback Signed-off-by: Daniel P. Berrange --- daemon/libvirtd.c |3 ++- daemon/remote.c|3 ++

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Kevin Wolf
Am 03.07.2012 17:40, schrieb Corey Bryant: > Thanks again for taking time to discuss this at today's QEMU community call. > > Here's the proposal we discussed at the call. Please let me know if I > missed anything or if there are any issues with this design. > > Proposal Five: New monitor comm

Re: [libvirt] question about save/restore domain

2012-07-03 Thread Eric Blake
On 07/03/2012 06:42 AM, Jovanka Gulicoska wrote: > Hi, > > my name is Jovanka Gulicoska and I'm SoC student. I'm working on > implementing save/load of VM in Gnome-Boxes. > Something confused me about snapshots. In the documentation about life > cycle, in section about Save/Restore is said that do

[libvirt] [PATCH 12/15] Move monitor into virLXCControllerPtr

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the monitor FDs into the virLXCControllerPtr object removing the need for the 'struct lxcMonitor' object Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 115 ++ 1 file changed, 55 insertions(+), 60 de

[libvirt] [PATCH 09/15] Move loop device FDs into virLXCControllerPtr object

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the list of loop device FDs into the virLXCControllerPtr object and make sure that virLXCControllerStopInit will close them all Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 50 +++--- 1 file changed,

[libvirt] [PATCH 15/15] Switch to using virNetServer APIs for monitor socket

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In preparation for introducing a full RPC protocol for libvirt_lxc, switch over to using the virNetServer APIs for the monitor connection Signed-off-by: Daniel P. Berrange --- src/Makefile.am |2 + src/lxc/lxc_controller.c | 268 +---

[libvirt] [PATCH 06/15] Store the init PID in the virLXCController object

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Keep a record of the init PID in the virLXCController object and create a virLXCControllerStopInit method for killing this process Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 74 +++--- 1 file changed, 44

[libvirt] [PATCH 08/15] Move daemon handshake FD into virLXCControllerPtr

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Keep the FD uses to handshake with the libvirtd daemon in the virLXCControllerPtr object. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/src/

[libvirt] [PATCH 14/15] Move loop device setup code into virfile.{c, h}

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" While it is not currently used elsewhere in libvirt, the code for finding a free loop device & associating a file with it is not LXC specific. Move it into the viffile.{c,h} file where potentially shared code is more commonly kept. Signed-off-by: Daniel P. Berrange --

[libvirt] [PATCH 07/15] Make console handling part of virLXCControllerPtr

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Turn 'struct lxc_console' into virLXCControllerConsolePtr and make it a part of virLXCControllerPtr Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 264 ++ 1 file changed, 152 insertions(+), 112 deletions(

[libvirt] [PATCH 10/15] Move security manager into virLXCControllerPtr object

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the security manager object into the virLXCControllerPtr object. Also simplify the code creating it in the first place Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 37 +++-- 1 file changed, 15 insertions(+),

[libvirt] [PATCH 02/15] Allow RPC server to run single threaded

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Refactor the RPC server dispatcher code so that if 'max_workers==0' the entire server will run single threaded. This is useful for use cases where there will only ever be 1 client connected which serializes its requests Signed-off-by: Daniel P. Berrange --- src/rpc/v

[libvirt] [PATCH 05/15] Move veth device management into virLXCControllerPtr object

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the veth device name state into the virLXCControllerPtr object and stop passing it around. Also use size_t instead of unsigned int for the array length parameters. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_container.c | 10 +++--- src/lxc/lxc_containe

[libvirt] [PATCH 03/15] Avoid build shared source files again for libvirt_lxc

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently the build of libvirt_lxc will cause recompilation of all sources under src/util, src/conf, src/security and more. Switch the libvirt_lxc process to link against the libtool convenience libraries that are already built as part of the main libvirt.os & libvirtd

[libvirt] [PATCH 13/15] Move cgroup objects into virLXCControllerPtr

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the cgroup object into virLXCControllerPtr and rename all the setup methods to include 'Cgroup' in their name if appropriate Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 132 +++--- 1 file changed, 67

[libvirt] [PATCH 11/15] Move /dev/pts setup out of virLXCControllerRun

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The virLXCControllerRun method is getting a little too large, and about 50% of its code is related to setting up a /dev/pts mount. Move the latter out into a dedicated method Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 229 ++

[libvirt] [PATCH 00/15] Major refactor of LXC controller code

2012-07-03 Thread Daniel P. Berrange
The LXC controller code (libvirt_lxc binary) has grown rather large and complicated over time. One of the particularly bad problems is that there is no single store of global state. The results is that methods are passing around huge lists of parameters and it becomes unclear who is responsible for

[libvirt] [PATCH 04/15] Introduce a virLXCControllerPtr object to hold LXC controller state

2012-07-03 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The LXC controller code is having to pass around an ever increasing number of parameters between methods. To make the code more managable introduce a virLXCControllerPtr to hold all this state, starting with the container name and virDomainDefPtr object Signed-off-by:

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/02/2012 06:02 PM, Corey Bryant wrote: On 06/26/2012 06:54 PM, Eric Blake wrote: On 06/26/2012 04:28 PM, Corey Bryant wrote: With this proposed series, we have usage akin to: 1. pass_fd FDSET={M} -> returns a string "/dev/fd/N" showing QEMU's view of the FD 2. drive_ad

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Daniel P. Berrange
On Tue, Jul 03, 2012 at 05:11:48PM +0200, Wido den Hollander wrote: > Yes, there is memory corruption somewhere. I never used valgrind > before, but the output seems to show. > > I ran libvirtd inside a screen, I've attached the screenlog with all > the output. > > At the end you'll see there is

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Wido den Hollander
On 03-07-12 16:54, Daniel P. Berrange wrote: On Tue, Jul 03, 2012 at 04:42:54PM +0200, Wido den Hollander wrote: On 03-07-12 15:13, Daniel P. Berrange wrote: That is really bizarre. Can you look at what is actually stored in the .base64 file each time ? And what 'secret-get-value' replies

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Daniel P. Berrange
On Tue, Jul 03, 2012 at 04:42:54PM +0200, Wido den Hollander wrote: > > > On 03-07-12 15:13, Daniel P. Berrange wrote: > >>> > >>>That is really bizarre. Can you look at what is actually stored > >>>in the .base64 file each time ? And what 'secret-get-value' > >>>replies with ? > >> > >>I haven't

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Wido den Hollander
On 03-07-12 15:13, Daniel P. Berrange wrote: That is really bizarre. Can you look at what is actually stored in the .base64 file each time ? And what 'secret-get-value' replies with ? I haven't been able to look into this any further, however: I just downloaded 0.9.13 from the libvirt websit

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.13

2012-07-03 Thread Justin Clift
On 02/07/2012, at 3:10 PM, Daniel Veillard wrote: > > Okay the new release is out and available as uauls at >ftp://libvirt.org/libvirt/ Now in OSX Homebrew too. :) + Justin -- Aeolus Community Manager http://www.aeolusproject.org -- libvir-list mailing list libvir-list@redhat.com https:/

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/02/2012 06:31 PM, Eric Blake wrote: On 07/02/2012 04:02 PM, Corey Bryant wrote: Here's another option that Kevin and I discussed today on IRC. I've modified a few minor details since the discussion. And Kevin please correct me if anything is wrong. Proposal Four: Pass a set of fds via

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Daniel P. Berrange
On Tue, Jul 03, 2012 at 03:11:59PM +0200, Wido den Hollander wrote: > > > On 25-06-12 16:54, Daniel P. Berrange wrote: > > > >>Notice this behavior: > >> > >>root@stack01:~# virsh secret-set-value > >>322bccea-f2ed-4eae-a7e5-d0793ffb162d > >>AQAE+uJPCFpELBAAkTniQvHabBGj0Quwnu2imA== > >>Secret val

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Wido den Hollander
On 25-06-12 16:54, Daniel P. Berrange wrote: Notice this behavior: root@stack01:~# virsh secret-set-value 322bccea-f2ed-4eae-a7e5-d0793ffb162d AQAE+uJPCFpELBAAkTniQvHabBGj0Quwnu2imA== Secret value set root@stack01:~# md5sum /etc/libvirt/secrets/322bccea-f2ed-4eae-a7e5-d0793ffb162d.base64 b4

Re: [libvirt] [PATCH] Added the attribute vendor_id to the cpu model

2012-07-03 Thread Hendrik Schwartke
On 03.07.2012 12:06, Michal Privoznik wrote: On 28.06.2012 12:21, Hendrik Schwartke wrote: Introducing the attribute vendor_id to force the CPUID instruction in a kvm guest to return the specified vendor. --- docs/schemas/domaincommon.rng |7 + src/conf/cpu_conf.c | 64 +++

Re: [libvirt] [PATCH] Added the attribute vendor_id to the cpu model

2012-07-03 Thread Michal Privoznik
On 28.06.2012 12:21, Hendrik Schwartke wrote: > Introducing the attribute vendor_id to force the CPUID instruction > in a kvm guest to return the specified vendor. > --- > docs/schemas/domaincommon.rng |7 + > src/conf/cpu_conf.c | 64 > +---

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 0.9.13

2012-07-03 Thread Daniel P. Berrange
I am pleased to announce that release 0.9.13 of Sys-Virt, the libvirt Perl API binding is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.13.tar.gz Changed in this release: - Add all new APIs and constants in libvirt 0.9.13 Further information, in

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Kevin Wolf
Am 03.07.2012 00:31, schrieb Eric Blake: > On 07/02/2012 04:02 PM, Corey Bryant wrote: > >> Here's another option that Kevin and I discussed today on IRC. I've >> modified a few minor details since the discussion. And Kevin please >> correct me if anything is wrong. >> >> Proposal Four: Pass a se

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Daniel P. Berrange
On Mon, Jul 02, 2012 at 04:31:09PM -0600, Eric Blake wrote: > On 07/02/2012 04:02 PM, Corey Bryant wrote: > > > Here's another option that Kevin and I discussed today on IRC. I've > > modified a few minor details since the discussion. And Kevin please > > correct me if anything is wrong. > > > >

Re: [libvirt] libvirt can't get capablities

2012-07-03 Thread Li Zhang
On 07/02/2012 06:14 PM, Daniel P. Berrange wrote: On Mon, Jul 02, 2012 at 05:47:08PM +0800, Li Zhang wrote: Hi, I have suffered several times on both x86 machine and power machine. When we want to use libvirt to create on VMs, it reports "unknown OS type hvm". We can't get capabilities. Th